Re: [osg-users] TriStripVisitor issue

2009-11-25 Thread Tanguy Fautre
Users Subject: Re: [osg-users] TriStripVisitor issue Hi Tanguy, On Wed, Nov 25, 2009 at 12:27 PM, Tanguy Fautre wrote: > I've sent it to you yesterday on your Gmail address. Can you confirm > you've received it? Yes, I received it thanks. Just been juggling other tasks at this end

Re: [osg-users] TriStripVisitor issue

2009-11-25 Thread Robert Osfield
Hi Tanguy, On Wed, Nov 25, 2009 at 12:27 PM, Tanguy Fautre wrote: > I've sent it to you yesterday on your Gmail address. Can you confirm > you've received it? Yes, I received it thanks. Just been juggling other tasks at this end so haven't yet dived into the code. Cheers, Robert. _

Re: [osg-users] TriStripVisitor issue

2009-11-25 Thread Tanguy Fautre
09 5:10 PM To: OpenSceneGraph Users Subject: Re: [osg-users] TriStripVisitor issue On Tue, Nov 24, 2009 at 4:59 PM, Tanguy Fautre wrote: > I'll do these modifications and check them tonight when I'm back home. > To speed things up (and because we're going to backport OSG ch

Re: [osg-users] TriStripVisitor issue

2009-11-24 Thread Robert Osfield
On Tue, Nov 24, 2009 at 4:59 PM, Tanguy Fautre wrote: > I'll do these modifications and check them tonight when I'm back home. > To speed things up (and because we're going to backport OSG changes), > I'm not going to do a full release on TriStripper website yet; instead > I'll send you a zip cont

Re: [osg-users] TriStripVisitor issue

2009-11-24 Thread Tanguy Fautre
ersion. Cheers, Tanguy -Original Message- From: osg-users-boun...@lists.openscenegraph.org [mailto:osg-users-boun...@lists.openscenegraph.org] On Behalf Of Robert Osfield Sent: 24 November 2009 3:33 PM To: OpenSceneGraph Users Subject: Re: [osg-users] TriStripVisitor issue Hi Tanguy, On

Re: [osg-users] TriStripVisitor issue

2009-11-24 Thread Robert Osfield
Hi Tanguy, On Tue, Nov 24, 2009 at 2:55 PM, Tanguy Fautre wrote: > http://users.telenet.be/tfautre/softdev/tristripper/ Thanks the link and explanation. > After a quick look at the header, I've noticed protections against > min/max macros that will cause a hard failure when those are detected >

Re: [osg-users] TriStripVisitor issue

2009-11-24 Thread Tanguy Fautre
Of Robert Osfield Sent: 24 November 2009 12:13 PM To: OpenSceneGraph Users Subject: Re: [osg-users] TriStripVisitor issue Hi Tanguy, Thanks for chipping in. Could you point me at the latest rev your tri-stripper code. One thing we will need to do is report your tri-stripping code to all the comp

Re: [osg-users] TriStripVisitor issue

2009-11-24 Thread Robert Osfield
ne has volunteered after a few weeks, just give me > some serious whipping and force me to do it. > > > Regards, > > Tanguy > > > -Original Message- > From: osg-users-boun...@lists.openscenegraph.org > [mailto:osg-users-boun...@lists.openscenegraph.org] On

Re: [osg-users] TriStripVisitor issue

2009-11-24 Thread Tanguy Fautre
me some serious whipping and force me to do it. Regards, Tanguy -Original Message- From: osg-users-boun...@lists.openscenegraph.org [mailto:osg-users-boun...@lists.openscenegraph.org] On Behalf Of Robert Osfield Sent: 23 November 2009 2:30 PM To: OpenSceneGraph Users Subject: Re: [o

Re: [osg-users] TriStripVisitor issue

2009-11-23 Thread Robert Osfield
Hi Stephan, On Mon, Nov 23, 2009 at 4:15 PM, Stephan Kussmaul wrote: > The problem we encountered was when the TriStripVisitor was used with double > data (e.g. for OpenFlight with double precision). As far as I can remember > in this case the wrong member function (remap(...))  in the base class

Re: [osg-users] TriStripVisitor issue

2009-11-23 Thread Stephan Kussmaul
Hi Robert, We are using OSG 2.8.2. The problem we encountered was when the TriStripVisitor was used with double data (e.g. for OpenFlight with double precision). As far as I can remember in this case the wrong member function (remap(...)) in the base class was used. That's why we had to add

Re: [osg-users] TriStripVisitor issue

2009-11-23 Thread Robert Osfield
HI Stephan, On Mon, Nov 23, 2009 at 2:31 PM, Stephan Kussmaul wrote: > We found a bug those days in TriStripVisitor.cpp. I didn't really read your > latest email, but this might be related to your precision issues: What bug was this? Could you explain? Which version of the OSG? > > class Writ

Re: [osg-users] TriStripVisitor issue

2009-11-23 Thread Stephan Kussmaul
Hi Manu, We found a bug those days in TriStripVisitor.cpp. I didn't really read your latest email, but this might be related to your precision issues: class WriteValue : public osg::ConstValueVisitor { ... // add those 3 lines virtual void apply(const Vec2d& v) { _o << v; }

Re: [osg-users] TriStripVisitor issue

2009-11-23 Thread Robert Osfield
Hi Manu, The TriStripVisitor shouldn't change anything in the data apart form re-organize it. Adding in tolerances to the vertex comparisons would require the vertex data to modified to collapse adjacent vertices's onto the same position in space. Would could add such functionality as an extra p

Re: [osg-users] TriStripVisitor issue

2009-11-23 Thread Emmanuel Roche
Okay, more details on this: the problem comes from the helper structure "VertexAttribComparitor" in the function VertexAttribComparitor::compare(unsigned int lhs, unsigned int rhs) we call the template array compare(unsigned int lhs, unsigned int rhs) function, and there we just use regular comp

Re: [osg-users] TriStripVisitor issue

2009-11-23 Thread Emmanuel Roche
Hi Robert, Actually, I've noticed that the problem doesn't come from the underlying tristripper library: instead, it seems that the indice array generated from my vertices is incorrect: I suspect that the comparison function to find if too vertices are the same or not is too precise in my case. D

Re: [osg-users] TriStripVisitor issue

2009-11-23 Thread Emmanuel Roche
Actually, I also noticed that OSG v2.8.1 uses version 1.0 of the tristripper library. As I'm quite in an hurry, I think I will re-implement my own tristripvisitor with the latest version of tristripper and check if this makes a difference. Will let you know what's the result of this test. But I b

Re: [osg-users] TriStripVisitor issue

2009-11-23 Thread Robert Osfield
Hi Manu, If the tristripper doesn't connect the triangles together well then it can result on few tristrips and lots of unconnected traingles that it has to put into a single list of triangles to avoid lots of separate primitive calls. As to why your model is not being stripped well I can't say.

[osg-users] TriStripVisitor issue

2009-11-23 Thread Emmanuel Roche
Hi everyone, I have a strange problem with the TryStripVisitor: When I use it on a model (with about 6000 triangles, described as TRIANGLES [thus using 18000 vertices]) I get trip strip primitive sets indeed BUT actually I get a few TRIANGLE_STRIP primitive sets with 4 vertices in each, and t