Re: [osg-users] osgQt Coverity Scan reported issue, Qt experts please chip in.

2016-07-07 Thread Robert Osfield
Checked in more defect fixes last night the overnight Coverty Scan now reports just 4 remaining defects. I fixed one this morning so the only three left are in the glu tessellation codes. This means the "reported" defect density is now 0.01 defects per 1000 lines of code. Given Coverity pegs

Re: [osg-users] osgQt Coverity Scan reported issue, Qt experts please chip in.

2016-07-05 Thread Philippe Renon
Why not put the glu tessellation code in an ignore list ? Embedded code that can be upgraded once in a while should be left alone unless critical bugs are found. I don't know if the glu code falls in that category. -- Read this topic online here:

Re: [osg-users] osgQt Coverity Scan reported issue, Qt experts please chip in.

2016-07-05 Thread Robert Osfield
Defect count now down to 0.04 reported defects per 1000 lines of code. This is well below the average for an open source project of the OSG's size, but now so close to zero it feels pretty obtainable. The only places defects need fixing are in the osgjs/gles plugins and the glu tessellation code

Re: [osg-users] osgQt Coverity Scan reported issue, Qt experts please chip in.

2016-06-29 Thread Robert Osfield
Hi All, I have been continuing to chip away at the defects reported by the Coverity Scan. From a defect count of 1.2 per 1000 lines of code we are now down to 0.32 per 1000 lines. Almost all of these are in the osgPlugins. The headers, core libraries and NodeKits all have zero reported

Re: [osg-users] osgQt Coverity Scan reported issue, Qt experts please chip in.

2016-06-25 Thread Robert Osfield
Hi Jan, Thanks for the details. I have changed the code across to using the Qt versions as you suggested: git diff diff --git a/src/osgQt/QGraphicsViewAdapter.cpp b/src/osgQt/QGraphicsViewAdapter.cpp index 0556445..4d0200e 100644 --- a/src/osgQt/QGraphicsViewAdapter.cpp +++

Re: [osg-users] osgQt Coverity Scan reported issue, Qt experts please chip in.

2016-06-24 Thread Jordi Torres
Hi Jan, El 24/6/2016 21:46, "Jan Ciger" escribió: > > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Hello, > > On 24/06/16 20:32, Robert Osfield wrote: > > If you have a github account you should be able to login in with > > this account. Alternatively you can create

Re: [osg-users] osgQt Coverity Scan reported issue, Qt experts please chip in.

2016-06-24 Thread Jan Ciger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hello, On 24/06/16 20:32, Robert Osfield wrote: > If you have a github account you should be able to login in with > this account. Alternatively you can create your own account for > Coverity. I have logged in with my Github account, but unless

Re: [osg-users] osgQt Coverity Scan reported issue, Qt experts please chip in.

2016-06-24 Thread Robert Osfield
Hi Jan, On 24 June 2016 at 14:20, Jan Ciger wrote: > Could you, please, post the report from Coverity? Will try below, but the source/defect browser they provides a nice way of exploring related code so worth logging in if you can. > The link above demands > login from me.

Re: [osg-users] osgQt Coverity Scan reported issue, Qt experts please chip in.

2016-06-24 Thread Jan Ciger
Hello Robert, On Fri, Jun 24, 2016 at 12:13 PM, Robert Osfield wrote: > Hi All, > > The Coverity Scan has picked up what it thinks is a defect in > QGraphicsViewAdapter: > > > https://scan9.coverity.com/reports.htm#v25753/p12834/fileInstanceId=5614557=1105702=124679 >

[osg-users] osgQt Coverity Scan reported issue, Qt experts please chip in.

2016-06-24 Thread Robert Osfield
Hi All, The Coverity Scan has picked up what it thinks is a defect in QGraphicsViewAdapter: https://scan9.coverity.com/reports.htm#v25753/p12834/fileInstanceId=5614557=1105702=124679 I've looked at the relevant code, copy and pasted below for reference. The issue looks to be related to mixing