Re: [ovs-dev] [PATCH v2] openvswitch: Trim off padding before L3+ netfilter processing

On Fri, Dec 22, 2017 at 4:39 PM, Ed Swierk wrote: > On Fri, Dec 22, 2017 at 3:31 PM, Pravin Shelar wrote: >> On Thu, Dec 21, 2017 at 7:17 AM, Ed Swierk >> wrote: >>> IPv4 and IPv6 packets may arrive with lower-layer

Re: [ovs-dev] Pravin Shelar

On Tue, Jan 2, 2018 at 11:36 AM, David Miller wrote: > From: Pravin Shelar > Date: Thu, 28 Dec 2017 15:47:39 -0800 > >> Thanks Joe for the patch. But it is corrupted. I will send updated patch >> soon. > > I'm still waiting for this, just FYI :) I sent the

Re: [ovs-dev] [PATCH] dpif-netdev: Refactor datapath flow cache

Hi Yipeng, Thanks for the reply. On Tue, Jan 2, 2018 at 10:45 AM, Wang, Yipeng1 wrote: > Hi, William, > > Thanks for the comment. You are right. If the RSS hash does not consider the > fields that matter, the situation you mentioned could happen. > > There are two

Re: [ovs-dev] API for connecting ovs bridge to manage packets

sorry. I just realize the rconn.h had become a public APIs a month ago :) Thanks Zhenyu Gao 2018-01-03 9:21 GMT+08:00 Gao Zhenyu : > Thanks for the suggestion. I will try to make them become regular APIs and > submit patch later. > > Thanks > Zhenyu Gao > > 2018-01-03

Re: [ovs-dev] API for connecting ovs bridge to manage packets

Thanks for the suggestion. I will try to make them become regular APIs and submit patch later. Thanks Zhenyu Gao 2018-01-03 0:37 GMT+08:00 Ben Pfaff : > On Fri, Dec 29, 2017 at 11:39:16AM +0800, Gao Zhenyu wrote: > > As you know ovn consumes rconn functions in pinctrl.c to

Re: [ovs-dev] [no-slow 4/6] ofproto: Add 'ofproto_uuid' and 'ofp_in_port' to user action cookie.

> On Jan 2, 2018, at 10:13 AM, Ben Pfaff wrote: > > On Thu, Dec 21, 2017 at 02:25:13PM -0800, Justin Pettit wrote: >> Previously, the ofproto instance and OpenFlow port have been derived >> based on the datapath port number. This change explicitly declares them >> both, which

Re: [ovs-dev] [PATCH V2] lib: Make error messages more useful

On 1/2/2018 11:52 AM, Ben Pfaff wrote: On Thu, Dec 28, 2017 at 01:52:41PM -0800, Greg Rose wrote: There are many "opening datapath" error messages and when one occurs it is impossible to know just from the log message which of the "opening datapath" errors occurred. Add a helper function that

Re: [ovs-dev] [PATCH 0/3] Initial support for new SIP Alg.

Tiago Lam writes: > This patch-set is an initial approach at implementing the new SIP Alg, > mentioned by Aaron at [1]. Thanks for this work, Tiago! > I'm mostly interested in getting to know your thoughts of how this is > headed. There are a couple of points that are worth

Re: [ovs-dev] [PATCH V2] lib: Make error messages more useful

On Thu, Dec 28, 2017 at 01:52:41PM -0800, Greg Rose wrote: > There are many "opening datapath" error messages and when one occurs > it is impossible to know just from the log message which of the > "opening datapath" errors occurred. Add a helper function that > incorporates the calling

Re: [ovs-dev] [no-slow 2/6] ofproto-dpif: Reorganize upcall handling.

> On Dec 28, 2017, at 3:22 PM, Gregory Rose wrote: > > SFAICT it emulates exactly what the system-traffic.at test 001 does. And it > works fine... /shrug. > > What distribution, kernel, etc are you using for your check-kmod testing? > I'll try to emulate that >

Re: [ovs-dev] Pravin Shelar

From: Pravin Shelar Date: Thu, 28 Dec 2017 15:47:39 -0800 > Thanks Joe for the patch. But it is corrupted. I will send updated patch soon. I'm still waiting for this, just FYI :) ___ dev mailing list d...@openvswitch.org

[ovs-dev] [PATCH] lex: Fix parsing of long tokens.

When a token is longer than the built-in 256-byte buffer, a buffer is malloc()'d but it was not properly null-terminated. Found by afl-fuzz. Reported-by: Bhargava Shastry Signed-off-by: Ben Pfaff --- ovn/lib/lex.c | 2 +- 1 file changed, 1

Re: [ovs-dev] [no-slow 2/6] ofproto-dpif: Reorganize upcall handling.

On 12/28/2017 3:22 PM, Gregory Rose wrote: On 12/21/2017 2:25 PM, Justin Pettit wrote: - This reduces the number of times upcall cookies are processed. - It separate true miss calls from slow-path actions. The reorganization will also be useful for a future commit. Signed-off-by:

Re: [ovs-dev] [PATCH V2] OF1.5/EXT-334 OXS/Extensible Flow Entry Statistics Support

On Tue, Jan 02, 2018 at 08:13:12AM +, Jan Scheurich wrote: > > -Original Message- > > From: ovs-dev-boun...@openvswitch.org > > [mailto:ovs-dev-boun...@openvswitch.org] On Behalf Of SatyaValli > > Sent: Monday, 01 January, 2018 11:59 > > To: d...@openvswitch.org > > Cc: Manasa

[ovs-dev] Actualización para los retos en 2018

Estrategias efectivas para sus finanzas Reformas y estrategias fiscales 2018 19 de enero- Mtro. David Lozada Martínez - 9am-3pm El panorama económico nacional previsto para 2018 se encuentra sujeto a eventos que podrían impactar negativamente la economía mexicana, como que algún miembro del

Re: [ovs-dev] [PATCH 05/12] openvswitch: drop unneeded newline

From: Julia Lawall Date: Wed, 27 Dec 2017 15:51:38 +0100 > OVS_NLERR prints a newline at the end of the message string, so the > message string does not need to include a newline explicitly. Done > using Coccinelle. > > Signed-off-by: Julia Lawall

Re: [ovs-dev] [PATCH v3] ovs-vsctl: show DPDK version

Matteo Croce writes: > On Tue, Jan 2, 2018 at 6:08 PM, Aaron Conole wrote: >> Hi Matteo, >> >> Matteo Croce writes: >> >>> Show DPDK version if Open vSwitch is compiled with DPDK support. >>> Add a `dpdk_version` column in the

Re: [ovs-dev] [PATCH] faq: Correct location of flow.h.

On Tue, Jan 02, 2018 at 10:14:42AM -0800, Gregory Rose wrote: > On 1/2/2018 8:31 AM, Ben Pfaff wrote: > >Reported-by: Alan Kayahan > >Signed-off-by: Ben Pfaff > >--- > > Documentation/faq/contributing.rst | 10 +- > > 1 file changed, 5 insertions(+), 5

Re: [ovs-dev] [PATCH] dpif-netdev: Refactor datapath flow cache

Hi, William, Thanks for the comment. You are right. If the RSS hash does not consider the fields that matter, the situation you mentioned could happen. There are two design options for CD as you may find, when the signatures collide, we could either replace the existing entry (the current

Re: [ovs-dev] [PATCH v3] ovs-vsctl: show DPDK version

On Tue, Jan 02, 2018 at 06:18:03PM +0100, Matteo Croce wrote: > On Tue, Jan 2, 2018 at 6:08 PM, Aaron Conole wrote: > > Hi Matteo, > > > > Matteo Croce writes: > > > >> Show DPDK version if Open vSwitch is compiled with DPDK support. > >> Add a

Re: [ovs-dev] [no-slow 6/6] ofproto-dpif: Don't slow-path controller actions with pause.

On Thu, Dec 21, 2017 at 02:25:15PM -0800, Justin Pettit wrote: > A previous patch removed slow-pathing for controller actions with the > exception of ones that specified "pause". This commit removes that > restriction so that no controller actions are slow-pathed. > > Signed-off-by: Justin

Re: [ovs-dev] [no-slow 1/6] ofproto-dpif: Add ability to look up an ofproto by UUID.

> On Jan 2, 2018, at 8:40 AM, Ben Pfaff wrote: > > On Thu, Dec 21, 2017 at 02:25:10PM -0800, Justin Pettit wrote: >> This will have callers in the future. >> >> Signed-off-by: Justin Pettit > > The new comment in struct ofproto_dpif only refers to one of the >

Re: [ovs-dev] [PATCH] faq: Correct location of flow.h.

On 1/2/2018 8:31 AM, Ben Pfaff wrote: Reported-by: Alan Kayahan Signed-off-by: Ben Pfaff --- Documentation/faq/contributing.rst | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/Documentation/faq/contributing.rst

Re: [ovs-dev] [no-slow 4/6] ofproto: Add 'ofproto_uuid' and 'ofp_in_port' to user action cookie.

On Thu, Dec 21, 2017 at 02:25:13PM -0800, Justin Pettit wrote: > Previously, the ofproto instance and OpenFlow port have been derived > based on the datapath port number. This change explicitly declares them > both, which will be helpful in future commits that no longer can depend > on having a

Re: [ovs-dev] [PATCH v3] ovs-vsctl: show DPDK version

On Tue, Jan 2, 2018 at 6:08 PM, Aaron Conole wrote: > Hi Matteo, > > Matteo Croce writes: > >> Show DPDK version if Open vSwitch is compiled with DPDK support. >> Add a `dpdk_version` column in the datamodel, change ovs-ctl and ovs-dev.py >> to populate the

Re: [ovs-dev] [PATCH v3] ovs-vsctl: show DPDK version

Hi Matteo, Matteo Croce writes: > Show DPDK version if Open vSwitch is compiled with DPDK support. > Add a `dpdk_version` column in the datamodel, change ovs-ctl and ovs-dev.py > to populate the field with the right value. > > Signed-off-by: Matteo Croce >

Re: [ovs-dev] [no-slow 3/6] ofp-actions: Add action "debug_slow" for testing slow-path.

On Thu, Dec 21, 2017 at 02:25:12PM -0800, Justin Pettit wrote: > It isn't otherwise useful and in fact hurts performance so it's disabled > without --enable-dummy. > > An upcoming commit will make use of this. > > Signed-off-by: Justin Pettit Acked-by: Ben Pfaff

Re: [ovs-dev] [no-slow 2/6] ofproto-dpif: Reorganize upcall handling.

On Thu, Dec 21, 2017 at 02:25:11PM -0800, Justin Pettit wrote: > - This reduces the number of times upcall cookies are processed. > - It separate true miss calls from slow-path actions. > > The reorganization will also be useful for a future commit. > > Signed-off-by: Justin Pettit

Re: [ovs-dev] [no-slow 1/6] ofproto-dpif: Add ability to look up an ofproto by UUID.

On Thu, Dec 21, 2017 at 02:25:10PM -0800, Justin Pettit wrote: > This will have callers in the future. > > Signed-off-by: Justin Pettit The new comment in struct ofproto_dpif only refers to one of the hmap_nodes. Acked-by: Ben Pfaff

Re: [ovs-dev] API for connecting ovs bridge to manage packets

On Fri, Dec 29, 2017 at 11:39:16AM +0800, Gao Zhenyu wrote: > As you know ovn consumes rconn functions in pinctrl.c to connect the > bridge. But the rconn functions are private functions. I mean those > functions are not exposed in include/openvswitch/*.h file, so they are not > regular

[ovs-dev] [PATCH] faq: Correct location of flow.h.

Reported-by: Alan Kayahan Signed-off-by: Ben Pfaff --- Documentation/faq/contributing.rst | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/Documentation/faq/contributing.rst b/Documentation/faq/contributing.rst index

Re: [ovs-dev] [PATCH] ovn-nbctl: Add lrp's gateway chassis information in show command

On Tue, Jan 02, 2018 at 06:13:27PM +0530, nusid...@redhat.com wrote: > From: Numan Siddique > > Having this information in the show command will be helpful. > > Signed-off-by: Numan Siddique Applied, thanks!

[ovs-dev] master now "frozen" for forking

Hello everyone. We are at the point in the release cycle where traditionally we would fork a branch from master for release. We have tried a slightly different approach a few times and I'd like to propose that we do it again. Instead of forking immediately, I propose that we "freeze" master so

Re: [ovs-dev] OVS DPDK: dpdk_merge pull request

Thanks! I merged this to master. On Wed, Dec 20, 2017 at 10:38:19PM +, Stokes, Ian wrote: > Hi Ben, > > The following changes since commit fa233667eecac83c68662702622f4d0c66d2364b: > > bond: Fix bug that writes to freed memory (2017-12-20 09:36:39 -0800) > > are available in the git

Re: [ovs-dev] [Cluster-devel] [PATCH 00/12] drop unneeded newline

On Tue, 2018-01-02 at 15:00 +0100, Julia Lawall wrote: > On Tue, 2 Jan 2018, Bob Peterson wrote: > > - Original Message - > > > - Original Message - > > > > > Still, the GFS2 and DLM code has a plethora of broken-up printk messages, > > and I don't like the thought of re-combining

Re: [ovs-dev] [Cluster-devel] [PATCH 00/12] drop unneeded newline

On Tue, 2 Jan 2018, Bart Van Assche wrote: > On Tue, 2018-01-02 at 15:00 +0100, Julia Lawall wrote: > > On Tue, 2 Jan 2018, Bob Peterson wrote: > > > - Original Message - > > > > - Original Message - > > > > > > > Still, the GFS2 and DLM code has a plethora of broken-up printk

Re: [ovs-dev] [PATCH] tests: Add system-dpdk-testsuite

Hi Cian, Thank you for your comment. I've uploaded version V2 of the patch which resolves your findings. Best regards, Marcin -Original Message- From: Ferriter, Cian Sent: Wednesday, December 20, 2017 6:16 PM To: Rybka, MarcinX ; d...@openvswitch.org Cc:

[ovs-dev] [PATCH v2] tests: Add system-dpdk-testsuite

New OVS-DPDK testsuite, which can be launched via `make check-dpdk`, tests OVS using a DPDK datapath. The testsuite contains already initial tests: 1. EAL init 2. Add standard DPDK PHY port 3. Add vhost-user-client port Signed-off-by: Marcin Rybka ---

Re: [ovs-dev] [PATCH] netdev-dpdk: fix port addition for ports sharing same PCI id

ping ... On Thu, Dec 21, 2017 at 12:03:36AM +0800, Yuanhan Liu wrote: > Some NICs have only one PCI address associated with multiple ports. This > patch extends the dpdk-devargs option's format to cater for such devices. > > To achieve that, this patch uses a new syntax that will be adapted and

Re: [ovs-dev] [Cluster-devel] [PATCH 00/12] drop unneeded newline

On Tue, 2 Jan 2018, Bob Peterson wrote: > - Original Message - > | - Original Message - > | | Drop newline at the end of a message string when the printing function > adds > | | a newline. > | > | Hi Julia, > | > | NACK. > | > | As much as it's a pain when searching the source

Re: [ovs-dev] [Cluster-devel] [PATCH 00/12] drop unneeded newline

- Original Message - | - Original Message - | | Drop newline at the end of a message string when the printing function adds | | a newline. | | Hi Julia, | | NACK. | | As much as it's a pain when searching the source code for output strings, | this patch set goes against the

Re: [ovs-dev] [Cluster-devel] [PATCH 00/12] drop unneeded newline

On Tue, 2 Jan 2018, Bob Peterson wrote: > - Original Message - > | Drop newline at the end of a message string when the printing function adds > | a newline. > > Hi Julia, > > NACK. > > As much as it's a pain when searching the source code for output strings, > this patch set goes

Re: [ovs-dev] [Cluster-devel] [PATCH 00/12] drop unneeded newline

- Original Message - | Drop newline at the end of a message string when the printing function adds | a newline. Hi Julia, NACK. As much as it's a pain when searching the source code for output strings, this patch set goes against the accepted Linux coding style document. See:

[ovs-dev] [PATCH] ovn-nbctl: Add lrp's gateway chassis information in show command

From: Numan Siddique Having this information in the show command will be helpful. Signed-off-by: Numan Siddique --- ovn/utilities/ovn-nbctl.c | 9 + 1 file changed, 9 insertions(+) diff --git a/ovn/utilities/ovn-nbctl.c

[ovs-dev] [OVN][Request] New OVS 2.8 tag

Hi folks, It'd be great if we could have 2.8.2 tag so that we can benefit from some patches that we would require in OVN and its OpenStack integration such as: * OVN: Add external_ids to NAT and Logical_Router_Static_Route tables [0] * ovn-northd; Treat logical ports of router type as always

Re: [ovs-dev] [PATCH V2] OF1.5/EXT-334 OXS/Extensible Flow Entry Statistics Support

> -Original Message- > From: ovs-dev-boun...@openvswitch.org > [mailto:ovs-dev-boun...@openvswitch.org] On Behalf Of SatyaValli > Sent: Monday, 01 January, 2018 11:59 > To: d...@openvswitch.org > Cc: Manasa Cherukupally ; Surya Muttamsetty >