Re: [ovs-dev] [PATCH ovn v10 0/4] Introduce infrastructure for VIF plug providers.

On Mon, Nov 8, 2021 at 11:08 PM Numan Siddique wrote: > > On Fri, Nov 5, 2021 at 5:32 PM Frode Nordahl > wrote: > > > > fre. 5. nov. 2021, 20:43 skrev Han Zhou : > > > > > > > > > > > On Fri, Nov 5, 2021 at 7:00 AM Frode Nordahl > > > wrote: > > > > > > > > Introduce infrastructure for VIF plug

Re: [ovs-dev] [PATCH ovn v4] ovn-northd: Virtual port add ND/ARP responder flows for IPv6 VIPs.

On Wed, Nov 3, 2021 at 9:37 AM Mohammad Heib wrote: > > currently ovn-northd only handle virtual ports with VIP IPv4 and ignores > virtual ports with VIP IPv6. > > This patch adds support for virtual ports with VIP IPv6 by adding > lflows to the lsp_in_arp_rsp logical switch pipeline. > Those

Re: [ovs-dev] [PATCH] [python] Avoid alloc of an attr dict/row+column

On 10/13/21 16:34, Timothy Redaelli wrote: > On Tue, 12 Oct 2021 14:13:31 -0500 > Terry Wilson wrote: > >> Python objects normally have a dictionary named __dict__ allocated >> for handling dynamically assigned attributes. Depending on >> architecture and Python version, that empty dict may be

Re: [ovs-dev] [PATCH] github: Remove workaround fixing up /etc/hosts.

On 10/13/21 16:11, David Marchand wrote: > On Fri, Oct 8, 2021 at 1:58 PM Dumitru Ceara wrote: >> >> The issue that was worked around has been fixed in the meantime: >> https://github.com/actions/virtual-environments/issues/3353 >> >> Signed-off-by: Dumitru Ceara > > Fairly trivial and ovsrobot

Re: [ovs-dev] [PATCH ovn v4 4/6] northd: Introduce struct northd_data

On Wed, Nov 3, 2021 at 11:37 PM Han Zhou wrote: > On Wed, Oct 27, 2021 at 10:24 AM Mark Gray wrote: > > > > 'struct northd_data' is used to hold the global state data for the > > incremental processing node 'en_northd'. This structure will also hold > > 'struct northd_input' which will hold

Re: [ovs-dev] [PATCH ovn v4 6/6] northd: Do not calculate database sequence numbers incrementally

On Thu, Nov 4, 2021 at 12:02 AM Han Zhou wrote: > On Wed, Oct 27, 2021 at 10:24 AM Mark Gray wrote: > > > > In order to remove the IDL loop variable from the engine context, > > we do not calculate the database sequence numbers incrementally. > > > > Signed-off-by: Mark Gray > > --- > >

Re: [ovs-dev] [PATCH] rhel: use /run instead of /var/run

On 7/12/21 22:15, Flavio Leitner wrote: > On Wed, May 12, 2021 at 05:08:08PM +0200, Timothy Redaelli wrote: >> Systemd unit file generates warnings about PID file path since /var/run >> is a legacy path so just use /run instead of /var/run. >> >> /var/run is a symlink of /run starting from RHEL7

Re: [ovs-dev] [PATCH ovn] ovs: Bump submodule to include ovsdb/IDL optimizations.

On Fri, Nov 5, 2021 at 5:11 AM Dumitru Ceara wrote: > > There are two relevant OVS commits picked with this submodule update. > The first one significantly improves performance of OVN database clients > and the second one adds memory reporting for the OVN IDL clients. > > 1bdda7b6d ovsdb-idl:

Re: [ovs-dev] [PATCH ovn v10 0/4] Introduce infrastructure for VIF plug providers.

On Fri, Nov 5, 2021 at 5:32 PM Frode Nordahl wrote: > > fre. 5. nov. 2021, 20:43 skrev Han Zhou : > > > > > > > On Fri, Nov 5, 2021 at 7:00 AM Frode Nordahl > > wrote: > > > > > > Introduce infrastructure for VIF plug providers and add feature to > > > ovn-controller to add and remove ports on

Re: [ovs-dev] [ovn] chassis with VXLAN breaks setup which is using OVN-IC

+ Ihar if he has any comments. Thanks Numan On Mon, Nov 8, 2021 at 4:57 PM Vladislav Odintsov wrote: > > Hi, > > is seems like I found a regression with a latest ovn main branch code using > ovn-ic. > My setup utilises ramp switches (ovn-controller-vtep), so some chassis have > vxlan encap.

[ovs-dev] [ovn] chassis with VXLAN breaks setup which is using OVN-IC

Hi, is seems like I found a regression with a latest ovn main branch code using ovn-ic. My setup utilises ramp switches (ovn-controller-vtep), so some chassis have vxlan encap. But I guess the problem affects non-vtep switch VXLAN installations too. OVN IC transit switches use tunnel key ids >

Re: [ovs-dev] [PATCH v6 2/2] dpctl: dpif: allow viewing and configuring dp cache sizes

On 11/5/21 10:22, Eelco Chaudron wrote: > > > On 4 Nov 2021, at 16:21, Ilya Maximets wrote: > >> Hi, Eelco. Thanks for the patch! >> >> I'd like to test it a bit more on my setup before applying, but the >> code looks mostly OK to me. >> >> See some nits inline. >> >> Bets regards, Ilya

Re: [ovs-dev] [PATCH v6 1/2] dpctl: dpif: add kernel datapath cache hit output

On 11/5/21 10:20, Eelco Chaudron wrote: > > > On 4 Nov 2021, at 15:51, Ilya Maximets wrote: > >> Hi, Eelco. Sorry for this taking so long. >> >> The patch looks good to me, just one small nit below. >> >> On 9/6/21 10:53, Eelco Chaudron wrote: >>> This patch adds cache usage statistics to the

Re: [ovs-dev] [PATCH] ovsdb: Don't let transaction history grow larger than the database.

On 11/8/21 20:44, Han Zhou wrote: > > > On Mon, Nov 8, 2021 at 11:33 AM Ilya Maximets > wrote: >> >> On 11/8/21 20:14, Han Zhou wrote: >> > >> > >> > On Mon, Nov 8, 2021 at 10:49 AM Ilya Maximets > > > >

Re: [ovs-dev] [PATCH] ovsdb: Don't let transaction history grow larger than the database.

On 11/2/21 17:34, Dumitru Ceara wrote: > On 10/14/21 4:58 PM, Ilya Maximets wrote: >> If user frequently changes a lot of rows in a database, transaction >> history could grow way larger than the database itself. This wastes >> a lot of memory and also makes monitor_cond_since slower than >>

Re: [ovs-dev] [PATCH] ovsdb: Don't let transaction history grow larger than the database.

On Mon, Nov 8, 2021 at 11:33 AM Ilya Maximets wrote: > > On 11/8/21 20:14, Han Zhou wrote: > > > > > > On Mon, Nov 8, 2021 at 10:49 AM Ilya Maximets mailto:i.maxim...@ovn.org>> wrote: > >> > >> On 11/8/21 19:24, Han Zhou wrote: > >> > > >> > > >> > On Fri, Nov 5, 2021 at 2:55 PM Ilya Maximets

Re: [ovs-dev] [PATCH] ovsdb: Don't let transaction history grow larger than the database.

On 11/8/21 20:14, Han Zhou wrote: > > > On Mon, Nov 8, 2021 at 10:49 AM Ilya Maximets > wrote: >> >> On 11/8/21 19:24, Han Zhou wrote: >> > >> > >> > On Fri, Nov 5, 2021 at 2:55 PM Ilya Maximets > > > >

Re: [ovs-dev] [PATCH 4/4] Tunnel: Snoop ingress packets and update neigh cache if needed.

Gaëtan Rivet writes: > On Tue, Nov 2, 2021, at 18:12, Paolo Valerio wrote: >> In case of native tunnel with bfd enabled, if the MAC address of the >> remote end's interface changes (e.g. because it got rebooted, and the >> MAC address is allocated dinamically), the BFD session will never be >>

Re: [ovs-dev] [PATCH 3/4] Native tunnel: Do not refresh the entry while revalidating.

Gaëtan Rivet writes: > On Tue, Nov 2, 2021, at 18:12, Paolo Valerio wrote: >> This is a minor issue but visible e.g. when you try to flush the neigh >> cache while the ARP flow is still present in the datapath, triggering >> the revalidation of the datapath flows which subsequently >>

Re: [ovs-dev] [PATCH 2/4] Native tunnel: Add tnl/neigh/ageing command.

Gaëtan Rivet writes: > On Tue, Nov 2, 2021, at 18:12, Paolo Valerio wrote: >> with the command is now possible to change the ageing time of the >> cache entries. >> >> For the existing entries the ageing time is updated only if the >> current expiration is greater than the new one. In any case,

Re: [ovs-dev] [PATCH 1/4] Native tunnel: Read/write expires atomically.

Gaëtan Rivet writes: > On Tue, Nov 2, 2021, at 18:12, Paolo Valerio wrote: > > Hi Paolo, > > I think this commit needs more details. > I'm guessing the threads involved are the PMDs and main, are there others? > > Coherency is implicit on x86 cores, but those parallel read/writes are > undefined

Re: [ovs-dev] [PATCH 0/4] Native tunnel: Update neigh entries in tnl termination.

Gaëtan Rivet writes: > On Tue, Nov 2, 2021, at 18:12, Paolo Valerio wrote: >> - Dropped the RFC tag >> - Included Flavio's suggestions >> - Squashed patch #5 into #2 and #3 >> >> The series is composed of the following patches: >> >> #1: Expires is modified in different contexts (revalidator,

Re: [ovs-dev] [PATCH] ovsdb: Don't let transaction history grow larger than the database.

On Mon, Nov 8, 2021 at 10:49 AM Ilya Maximets wrote: > > On 11/8/21 19:24, Han Zhou wrote: > > > > > > On Fri, Nov 5, 2021 at 2:55 PM Ilya Maximets mailto:i.maxim...@ovn.org>> wrote: > >> > >> On 10/23/21 08:40, Han Zhou wrote: > >> > > >> > > >> > On Thu, Oct 14, 2021 at 7:58 AM Ilya Maximets

Re: [ovs-dev] [PATCH] ovsdb: Don't let transaction history grow larger than the database.

On 11/8/21 19:24, Han Zhou wrote: > > > On Fri, Nov 5, 2021 at 2:55 PM Ilya Maximets > wrote: >> >> On 10/23/21 08:40, Han Zhou wrote: >> > >> > >> > On Thu, Oct 14, 2021 at 7:58 AM Ilya Maximets > > > >

Re: [ovs-dev] [PATCH] ovsdb: Don't let transaction history grow larger than the database.

On Fri, Nov 5, 2021 at 2:55 PM Ilya Maximets wrote: > > On 10/23/21 08:40, Han Zhou wrote: > > > > > > On Thu, Oct 14, 2021 at 7:58 AM Ilya Maximets mailto:i.maxim...@ovn.org>> wrote: > >> > >> If user frequently changes a lot of rows in a database, transaction > >> history could grow way larger

[ovs-dev] [PATCH ovn 2/2] northd: Don't add ARP responder flows for unreachable VIPs.

From: Numan Siddique If a logical router is associated with load balancer VIPs which are unreachable from it, we don't need to add ARP responder flows in the L2_LKUP stage of ingress pipeline of the logical switches connected to the router. This patch removes these flows. Signed-off-by: Numan

[ovs-dev] [PATCH ovn 1/2] northd: Treat reachable and unreachable VIPs differently.

From: Numan Siddique If a logical switch is used to join multiple gateway routers and if each of these gateway routers are configured with the same load balancer, then after the commit [1] it's results in a flow explosion in the "ls_in_l2_lkup" stage of this logical switch. So, this patch

Re: [ovs-dev] [PATCH ovn v2] ci: Don't run unit tests for system-test job.

On Mon, Nov 8, 2021 at 10:43 AM Dumitru Ceara wrote: > > On 11/3/21 5:55 PM, num...@ovn.org wrote: > > From: Numan Siddique > > > > system-test matrix first runs unit tests and then system tests. > > And if unit tests fail, system tests are not run. > > > > This patch now runs only system tests

Re: [ovs-dev] [PATCH ovn v2] ci: Don't run unit tests for system-test job.

On 11/3/21 5:55 PM, num...@ovn.org wrote: > From: Numan Siddique > > system-test matrix first runs unit tests and then system tests. > And if unit tests fail, system tests are not run. > > This patch now runs only system tests for system-test matrix. > A new entry is added in the test matrix -

Re: [ovs-dev] [PATCH] Revert "odp-util: Always report ODP_FIT_TOO_LITTLE for IGMP."

Ilya Maximets writes: > On 11/1/21 15:47, Aaron Conole wrote: >> This reverts commit c645550bb249 ("odp-util: Always report >> ODP_FIT_TOO_LITTLE for IGMP.") >> >> Always forcing a slow path action can result in some over-broad >> flows which swallow all traffic and force them to userspace, as

Re: [ovs-dev] [PATCH ovn v1 1/5] manpages.mk: fix dependencies path

On 11/8/21 12:45 PM, Adrian Moreno wrote: > > > On 11/5/21 17:12, Dumitru Ceara wrote: >> On 10/21/21 11:10 AM, Adrian Moreno wrote: >>> Currently, if "make" is run after the project is built, the root >>> manpage (ovn-detrace.1) is rebuilt unnecessarily. >>> >>> The reason is that its

Re: [ovs-dev] [PATCH ovn v1 1/5] manpages.mk: fix dependencies path

On 11/5/21 17:12, Dumitru Ceara wrote: On 10/21/21 11:10 AM, Adrian Moreno wrote: Currently, if "make" is run after the project is built, the root manpage (ovn-detrace.1) is rebuilt unnecessarily. The reason is that its dependencies are wrong: files such as lib/common.man or lib/ovs.tmac do

Re: [ovs-dev] [PATCH] ovsdb: Don't let transaction history grow larger than the database.

On 11/5/21 10:55 PM, Ilya Maximets wrote: > On 10/23/21 08:40, Han Zhou wrote: >> >> >> On Thu, Oct 14, 2021 at 7:58 AM Ilya Maximets > > wrote: >>> >>> If user frequently changes a lot of rows in a database, transaction >>> history could grow way larger than the

[ovs-dev] [PATCH ovn] tests: Really fix requested-chassis localport test

The first test case of adding localport without a requested-chassis option is invalid as this would make the chassis do claim/release thrashing leading to a unpredictable test results. Create the localport in NB DB prior to creating the ports on the chassis. The step by step ovn-nbctl CLI