Bleep bloop. Greetings Ales Musil, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: "Fixes" tag is malformed.
Use the following format:
git log -1 --pretty=format:"Fixes: %
Extend the tests for "ct-no-masked-label" and
"ovn-ct-lb-related" with check for LB lflows
when LB is configured with "skip_snat" or "force_snat".
Signed-off-by: Ales Musil
---
This patch should be backported only to 23.03.
---
tests/ovn-northd.at | 32
1 file ch
Fix missing enclose for LB lflows when both
"ct-no-masked-label" and "ovn-ct-lb-related"
features are set false and the LB is configured
with either "skip_snat" or "force_snat".
Add missing test case for those.
Fixes: cd600de6 ("northd: Add flag for CT related.")
Signed-off-by: Ales Musil
---
Thi
On 8 Mar 2023, at 3:34, Faicker Mo wrote:
> Updated,
> Under my env, the sleep time before revalidator/purge can't be shorten to
> 0.2s or 0.5s.
> It's not reasonable there exists a dp flow after revalidator/purge.
What about my suggested change of removing the sleeps completely? Does it work
Updated,
Under my env, the sleep time before revalidator/purge can't be shorten to 0.2s
or 0.5s.
It's not reasonable there exists a dp flow after revalidator/purge.
From: Faicker Mo
Date: 2023-03-06 12:22:48
To:Eelco Chaudron
cc: d...@openvswitch.org,i.maxim...@ovn.org,simon.hor...@corigine.
Hi Aaron,
Thanks for your feedback.
Aaron Conole, Mar 07, 2023 at 19:57:
> I'm concerned about this - this is a negative interference with rte_flow
> offload. And rte_flow offload would also just alleviate these problems,
> yes? Maybe we should encourage a user to just turn on flow offloading?
Robin Jarry writes:
> Some control protocols are used to maintain link status between
> forwarding engines (e.g. LACP). When the system is not sized properly,
> the PMD threads may not be able to process all incoming traffic from the
> configured Rx queues. When a signaling packet of such protoco
Flavio Leitner writes:
> On Tue, Mar 07, 2023 at 02:32:04PM +0100, David Marchand wrote:
>> On Tue, Mar 7, 2023 at 2:06 PM Aaron Conole wrote:
>> >
>> > Open vSwitch generally tries to let the underlying operating system
>> > managed the low level details of hardware, for example DMA mapping,
>>
David Marchand writes:
> On Tue, Mar 7, 2023 at 2:06 PM Aaron Conole wrote:
>>
>> Open vSwitch generally tries to let the underlying operating system
>> managed the low level details of hardware, for example DMA mapping,
>> bus arbitration, etc. However, when using DPDK, the underlying
>> opera
On Tue, Mar 7, 2023 at 12:38 AM Ales Musil wrote:
>
>
>
> On Thu, Feb 23, 2023 at 7:35 AM Han Zhou wrote:
>>
>> Han Zhou (3):
>> ovn.at: Fix virtual port tests.
>> system-ovn.at: Add system test for virtual port with floating IP.
>> northd: Use dynamic mac-binding for virtual port IPs.
>>
>
On 3/7/23 16:03, Eelco Chaudron wrote:
>
>
> On 6 Mar 2023, at 3:49, Nobuhiro MIKI wrote:
>
>> v7:
>> - Fix error message
>> v6:
>> - Fix notation quirks between man page and in-app help
>> - Fix error message in ovs/route/add command
>> - Fix coding style
>> v5:
>> - Add patch to fix man page
>
On 2/28/23 16:52, Eelco Chaudron wrote:
> Run "make check-offloads" as part of the GitHub actions tests.
>
> This test was run 25 times using GitHub actions, and the
> failing rerun test cases where excluded. There are quite some
> first-run failures, but unfortunately, there is no other
> more st
On 3/7/23 17:31, Simon Horman wrote:
> On Tue, Mar 07, 2023 at 04:58:47PM +0100, Eelco Chaudron wrote:
>>
>>
>> On 7 Mar 2023, at 16:32, Eelco Chaudron wrote:
>>
>>> On 3 Mar 2023, at 16:15, Simon Horman wrote:
>>>
On Tue, Feb 28, 2023 at 04:52:15PM +0100, Eelco Chaudron wrote:
> Run "make
On Tue, Mar 07, 2023 at 04:58:47PM +0100, Eelco Chaudron wrote:
>
>
> On 7 Mar 2023, at 16:32, Eelco Chaudron wrote:
>
> > On 3 Mar 2023, at 16:15, Simon Horman wrote:
> >
> >> On Tue, Feb 28, 2023 at 04:52:15PM +0100, Eelco Chaudron wrote:
> >>> Run "make check-offloads" as part of the GitHub a
On 7 Mar 2023, at 16:32, Eelco Chaudron wrote:
> On 3 Mar 2023, at 16:15, Simon Horman wrote:
>
>> On Tue, Feb 28, 2023 at 04:52:15PM +0100, Eelco Chaudron wrote:
>>> Run "make check-offloads" as part of the GitHub actions tests.
>>>
>>> This test was run 25 times using GitHub actions, and the
>
On Tue, Mar 07, 2023 at 12:24:37PM -0300, Flavio Leitner wrote:
> On Tue, Mar 07, 2023 at 02:32:04PM +0100, David Marchand wrote:
> > On Tue, Mar 7, 2023 at 2:06 PM Aaron Conole wrote:
> > >
> > > Open vSwitch generally tries to let the underlying operating system
> > > managed the low level detai
On 3 Mar 2023, at 16:15, Simon Horman wrote:
> On Tue, Feb 28, 2023 at 04:52:15PM +0100, Eelco Chaudron wrote:
>> Run "make check-offloads" as part of the GitHub actions tests.
>>
>> This test was run 25 times using GitHub actions, and the
>> failing rerun test cases where excluded. There are qu
On Tue, Mar 07, 2023 at 02:32:04PM +0100, David Marchand wrote:
> On Tue, Mar 7, 2023 at 2:06 PM Aaron Conole wrote:
> >
> > Open vSwitch generally tries to let the underlying operating system
> > managed the low level details of hardware, for example DMA mapping,
> > bus arbitration, etc. Howeve
On 6 Mar 2023, at 3:49, Nobuhiro MIKI wrote:
> v7:
> - Fix error message
> v6:
> - Fix notation quirks between man page and in-app help
> - Fix error message in ovs/route/add command
> - Fix coding style
> v5:
> - Add patch to fix man page
> v4:
> - Add cleanup patch for ovs/route/add
> - Remove
On 6 Mar 2023, at 3:49, Nobuhiro MIKI wrote:
> When adding a route with ovs/route/add command, the source address
> in "ovs_router_entry" structure is always the FIRST address that the
> interface has. See "ovs_router_get_netdev_source_address"
> function for more information.
>
> If an interfa
On 6 Mar 2023, at 3:49, Nobuhiro MIKI wrote:
> Fixed the manual page to indicate that both IPv4/IPv6
> are supported. Also added missing pkt_mark on one side
> and fixed the "gw" and "bridge" notation quirks.
>
> Reviewed-by: Simon Horman
> Signed-off-by: Nobuhiro MIKI
> ---
> lib/ovs-router
On Tue, Mar 7, 2023 at 2:06 PM Aaron Conole wrote:
>
> Open vSwitch generally tries to let the underlying operating system
> managed the low level details of hardware, for example DMA mapping,
> bus arbitration, etc. However, when using DPDK, the underlying
> operating system yields control of ma
> On Tue, Mar 07, 2023 at 11:57:16AM +0100, Lorenzo Bianconi wrote:
> > Drop ip packets with ct status set to invalid in post snat and
> > lb_aff_learn router stages.
> > Skip ICMPv{4,6} error messages packet in ct.inv rules in order to avoid
> > to introduce too complicated code.
> >
> > Reported
Open vSwitch generally tries to let the underlying operating system
managed the low level details of hardware, for example DMA mapping,
bus arbitration, etc. However, when using DPDK, the underlying
operating system yields control of many of these details to userspace
for management.
In the case
On Tue, Mar 07, 2023 at 11:57:16AM +0100, Lorenzo Bianconi wrote:
> Drop ip packets with ct status set to invalid in post snat and
> lb_aff_learn router stages.
> Skip ICMPv{4,6} error messages packet in ct.inv rules in order to avoid
> to introduce too complicated code.
>
> Reported-at: https://b
Drop ip packets with ct status set to invalid in post snat and
lb_aff_learn router stages.
Skip ICMPv{4,6} error messages packet in ct.inv rules in order to avoid
to introduce too complicated code.
Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2160685
Signed-off-by: Lorenzo Bianconi
--
On Tue, Feb 28, 2023 at 11:25 AM Enrique Llorente
wrote:
> Configure mac address
> The mac address returned by ARP/NDP can be configured similar to LSP
> addresses where the mac is the first entry on the list
>
> IPv6
> Support NDP IPv6 protocol
>
> Use CIDRs
> Allow to specify subnets for ipv4 a
On Mon, Feb 27, 2023 at 7:41 PM Vladislav Odintsov
wrote:
> This patch fixes ovn-northd.service and ovn-db@.service systemd units
> which didn't pass startup options to ovn-ctl script while stop_* call.
>
> For instance if ovn-northd service was started with option
> '--ovn-manage-ovsdb=no' and N
On Tue, Mar 07, 2023 at 12:24:55PM +0800, Wan Junjie wrote:
> Hi Simon Horman,
>
> Thanks for your review.
>
>
> On Mon, Mar 6, 2023 at 11:23 PM Simon Horman
> wrote:
> > On Sat, Mar 04, 2023 at 11:23:50AM +0800, Wan Junjie wrote:
...
> > > On Fri, Mar 3, 2023 at 11:06 PM Simon Horman
> > >
On Thu, Feb 23, 2023 at 7:35 AM Han Zhou wrote:
> Han Zhou (3):
> ovn.at: Fix virtual port tests.
> system-ovn.at: Add system test for virtual port with floating IP.
> northd: Use dynamic mac-binding for virtual port IPs.
>
> northd/northd.c | 103
> no
On Sat, Mar 4, 2023 at 12:03 AM Ilya Maximets wrote:
> We no longer use conjunctions for these flows, so no need to
> try to append them.
>
> Fixes: c2f968235241 ("controller: Fix hairpin SNAT flow explosion if
> hairpin_snat_ip is set.")
> Signed-off-by: Ilya Maximets
> ---
> controller/lflow.
On Mon, Mar 6, 2023 at 12:07 PM Xavier Simonart wrote:
> As commented in northd.c, we should not use ct() for router ports.
> When there are no stateful_acl, this patch prevents sending packet to
> conntrack
> for router ports.
> The patch does this by issuing ct_clear in ls_out_pre_lb stage so t
32 matches
Mail list logo
