[ovs-dev] [PATCH] AUTHORS: update email for Lance Richardson

2020-01-08 Thread Lance Richardson via dev
Update email address for Lance Richardson. Signed-off-by: Lance Richardson --- .mailmap| 1 + AUTHORS.rst | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/.mailmap b/.mailmap index 4688ab0cd..894062d48 100644 --- a/.mailmap +++ b/.mailmap @@ -53,6 +53,7 @@ Joe Stringer

Re: [ovs-dev] [PATCH v4] ovn: Check for known logical switch port types.

2017-09-06 Thread Lance Richardson
type to "void" > v3: > * OVN_NB_LSP_TYPES declaration is static > * northd will not copy unknown port types to southbound DB > * re-ordered port types in OVN_NB_LSP_TYPES > v2: > * Used ARRAY_SIZE to calculate length

Re: [ovs-dev] [PATCH 2/2] ovn: Support chassis hostname in requested-chassis.

2017-09-05 Thread Lance Richardson
s much more convenient. This patch > extends the "requested-chassis" option to support both the Chassis > name or the hostname as a value. > > Signed-off-by: Russell Bryant <russ...@ovn.org> > --- LGTM. Acked-by: Lance Richardson <lrich...@redhat.com> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v3] ovn: Check for known logical switch port types.

2017-09-05 Thread Lance Richardson
> From: "Mark Michelson" > To: d...@openvswitch.org > Sent: Friday, August 25, 2017 3:14:33 PM > Subject: [ovs-dev] [PATCH v3] ovn: Check for known logical switch port types. > > OVN is lenient with the types of logical switch ports. Maybe too > lenient. This patch attempts

Re: [ovs-dev] [PATCH] travis: parallel builds and tests

2017-08-30 Thread Lance Richardson
Travis-CI builds for branches 2.6 and 2.7 are also failing due to the 50 minute per-job limit, perhaps this should be back-ported to those branches as well. Regards, Lance - Original Message - > From: "Lance Richardson" <lrich...@redhat.com> > To: d...@

[ovs-dev] [PATCH] sparse: eliminate "duplicate initialization" warning

2017-08-28 Thread Lance Richardson
fields of .flow to zero, which is redundant because according to the C99 semantics for structure initialization, initializing any single member of a structure results in all other members being initialized to zero, and the next line initializes a member of the same structure. Signed-off-by: Lance

Re: [ovs-dev] [PATCH] controller: Remote connection option to OpenFlow switch.

2017-08-24 Thread Lance Richardson
good assumption, for example, ovn-controller implements QoS features by configuring qdiscs on kernel netdevices corresponding to interfaces on the ovs integration bridge. Regards, Lance Richardson > > Thanks, > > Jai > > > > From: Jai

[ovs-dev] [PATCH] netdev-dpdk: use 64-bit arithmetic when converting rates

2017-08-24 Thread Lance Richardson
v-dpdk.c: Add ingress-policing functionality.") Signed-off-by: Lance Richardson <lrich...@redhat.com> --- Note: Found by inspection, untested. lib/netdev-dpdk.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index 1aaf6f7e2..4

Re: [ovs-dev] [ovs-discuss] OVS+DPDK QoS rate limit issue

2017-08-24 Thread Lance Richardson
nd burst to bytes. */ -    rate_bytes = rate * 1000/8; -    burst_bytes = burst * 1000/8; +    rate_bytes = rate * 1000ULL/8; +    burst_bytes = burst * 1000ULL/8;        policer->app_srtcm_params.cir = rate_bytes;      policer->app_srtcm_params.cbs = burst_bytes; Regards, Lanc

[ovs-dev] [PATCH v2] ovn: support requested-chassis option for logical switch ports

2017-08-19 Thread Lance Richardson
al security. Signed-off-by: Lance Richardson <lrich...@redhat.com> --- v2: Added documentation text suggested by Russell Bryant. ovn/controller/binding.c | 15 +++- ovn/ovn-nb.xml | 8 +++ ovn/ovn-sb.xml | 8 +++ tes

Re: [ovs-dev] [PATCH] ovn: support requested-chassis option for logical switch ports

2017-08-19 Thread Lance Richardson
> From: "Ben Pfaff" <b...@ovn.org> > To: "Lance Richardson" <lrich...@redhat.com> > Cc: d...@openvswitch.org > Sent: Friday, August 18, 2017 7:15:07 PM > Subject: Re: [ovs-dev] [PATCH] ovn: support requested-chassis option for > logical switch p

[ovs-dev] [PATCH] ovn: support requested-chassis option for logical switch ports

2017-08-18 Thread Lance Richardson
al security. Signed-off-by: Lance Richardson <lrich...@redhat.com> --- ovn/controller/binding.c | 15 +++- ovn/ovn-nb.xml | 5 ovn/ovn-sb.xml | 5 tests/ovn.at | 59 4 files changed, 83 insertio

Re: [ovs-dev] [PATCH 1/2] python: fix python3 encode/decode on Windows

2017-08-16 Thread Lance Richardson
_type(buff) > -return buff > - > - > def get_new_event(sa=None, bManualReset=True, bInitialState=True, >objectName=None): > return win32event.CreateEvent(sa, bManualReset, bInitialState, > objectName) > -- > 2.10.0.windows.1 > _

[ovs-dev] [PATCH] travis: parallel builds and tests

2017-08-10 Thread Lance Richardson
environment is provisioned with two CPUs, use -j2 for builds and -j4 for tests. Testing in a cloned repository shows slightly more than a 50% reduction in overall test time. Signed-off-by: Lance Richardson <lrich...@redhat.com> --- .travis/linux-build.sh | 8 1 file changed, 4 inse

Re: [ovs-dev] [PATCH 1/2] travis: Explicitly disable LLVM for sparse build.

2017-08-09 Thread Lance Richardson
> From: "Ben Pfaff" <b...@ovn.org> > To: "Lance Richardson" <lrich...@redhat.com> > Cc: d...@openvswitch.org > Sent: Wednesday, August 9, 2017 4:47:49 PM > Subject: Re: [ovs-dev] [PATCH 1/2] travis: Explicitly disable LLVM for sparse > build. &g

Re: [ovs-dev] [PATCH 1/2] travis: Explicitly disable LLVM for sparse build.

2017-08-09 Thread Lance Richardson
> From: "Ben Pfaff" > To: d...@openvswitch.org > Cc: "Ben Pfaff" > Sent: Thursday, July 27, 2017 4:41:05 PM > Subject: [ovs-dev] [PATCH 1/2] travis: Explicitly disable LLVM for sparse > build. > > Newer travis environments claim to have LLVM support (llvm-config

Re: [ovs-dev] [PATCH] python: make python idl unicode-tolerant

2017-08-09 Thread Lance Richardson
> From: "Russell Bryant" <russ...@ovn.org> > To: "Ben Pfaff" <b...@ovn.org> > Cc: "Lance Richardson" <lrich...@redhat.com>, "ovs dev" <d...@openvswitch.org> > Sent: Wednesday, August 9, 2017 3:42:05 PM > Subject: Re

[ovs-dev] [PATCH v2] python: make python idl unicode-tolerant

2017-08-09 Thread Lance Richardson
<twil...@redhat.com> Signed-off-by: Lance Richardson <lrich...@redhat.com> --- v1-v2: - Changed a unicode string in ovsdb-idl.at to avoid an issue in some installations of gnome-terminal (coredump). - Fixed a flake8 line length warning in test-ovsdb.py. - Added co-authored-by/acked-b

Re: [ovs-dev] DNS support options

2017-08-08 Thread Lance Richardson
- Original Message - > From: "Ben Pfaff" <b...@ovn.org> > To: "Lance Richardson" <lrich...@redhat.com> > Cc: d...@openvswitch.org > Sent: Tuesday, August 8, 2017 4:49:52 PM > Subject: Re: [ovs-dev] DNS support options > > On Tue, Aug

Re: [ovs-dev] DNS support options

2017-08-08 Thread Lance Richardson
> From: "Ben Pfaff" <b...@ovn.org> > To: "Lance Richardson" <lrich...@redhat.com> > Cc: d...@openvswitch.org > Sent: Tuesday, August 8, 2017 3:48:15 PM > Subject: Re: [ovs-dev] DNS support options > > On Tue, Aug 08, 2017 at 02:59:21PM -040

Re: [ovs-dev] DNS support options

2017-08-08 Thread Lance Richardson
> From: "Ben Pfaff" > To: d...@openvswitch.org > Sent: Tuesday, August 8, 2017 2:43:17 PM > Subject: [ovs-dev] DNS support options > > Open vSwitch currently supports only IP addresses for specifying > OpenFlow and OVSDB remotes. It would be nice to support DNS names. > Open

[ovs-dev] [PATCH] python: make python idl unicode-tolerant

2017-08-08 Thread Lance Richardson
-by: Terry Wilson <twil...@redhat.com> Signed-off-by: Lance Richardson <lrich...@redhat.com> --- python/ovs/json.py| 9 +++-- python/ovs/jsonrpc.py | 3 +-- python/ovs/stream.py | 6 -- tests/ovsdb-idl.at| 13 + tests/test-ovsdb.py | 5 - 5 files

[ovs-dev] [PATCH] tests: fix wrapped comment

2017-08-04 Thread Lance Richardson
Add missing '#' to comment line. Signed-off-by: Lance Richardson <lrich...@redhat.com> --- It's odd that this doesn't result in failures in more environments, but it does fail under Alpine Linux. tests/ovn.at | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/ov

Re: [ovs-dev] [PATCH] ovs-vsctl-bashcomp: Make compatible with busybox "awk".

2017-08-04 Thread Lance Richardson
igned-off-by: Ben Pfaff <b...@ovn.org> > --- Makes sense, verified that these test cases now pass in the Alpine environment with busybox awk. Acked-by: Lance Richardson <lrich...@redhat.com> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH v8 7/7] ovn-controller: use idl indexes for logical datapath

2017-08-03 Thread Lance Richardson
Use IDL index to iterate over all logical ports in a given logical datapath, avoiding the overhead of creating/destroying an indexing data structure in each iteration of the ovn-controller main loop. Signed-off-by: Lance Richardson <lrich...@redhat.com> --- v8: Rebased, changes require

[ovs-dev] [PATCH v8 6/7] ovn-controller: use idl indexes for logical port table

2017-08-03 Thread Lance Richardson
Use IDL index for logical port table lookups, avoiding the overhead of creating/destroying an index hmap for each iteration of the ovn-controller main loop. Signed-off-by: Lance Richardson <lrich...@redhat.com> --- v8: Rebased, changes required. v7: New patch. ovn/controller/bin

[ovs-dev] [PATCH v8 5/7] ovn-controller: use idl index for multicast group table

2017-08-03 Thread Lance Richardson
Use IDL index for multicast group table lookups, avoiding the overhead of creating/destroying an index hmap for each iteration of the ovn-controller main loop. Signed-off-by: Lance Richardson <lrich...@redhat.com> --- v8: Rebased, changes required. v7: New patch. ovn/controller/l

[ovs-dev] [PATCH v8 4/7] ovsdb-idl: Autogenerated functions for compound indexes

2017-08-03 Thread Lance Richardson
ncourt <esteb...@hpe.com> Co-authored-by: Arnoldo Lutz Guevara <arnoldo.lutz.guev...@hpe.com> Co-authored-by: Esteban Rodriguez Betancourt <esteb...@hpe.com> Signed-off-by: Lance Richardson <lrich...@redhat.com> --- v8: - Rebased, no changes. v7: - Rebased and made n

[ovs-dev] [PATCH v8 3/7] ovsdb-idl: idl compound indexes implementation

2017-08-03 Thread Lance Richardson
This patch adds support for the creation of multicolumn indexes in the C IDL to enable for efficient search and retrieval of database rows by key. Signed-off-by: Esteban Rodriguez Betancourt <esteb...@hpe.com> Co-authored-by: Lance Richardson <lrich...@redhat.com> Signed-off-by: Lanc

[ovs-dev] [PATCH v8 2/7] lib: skiplist implementation

2017-08-03 Thread Lance Richardson
Skiplist implementation intended for use in the IDL compound indexes feature. Signed-off-by: Esteban Rodriguez Betancourt <esteb...@hpe.com> Co-authored-by: Lance Richardson <lrich...@redhat.com> Signed-off-by: Lance Richardson <lrich...@redhat.com> --- v8: - Rebased, no ch

[ovs-dev] [PATCH v8 1/7] ovsdb-idl: compound indexes design document

2017-08-03 Thread Lance Richardson
Arturo Sauma Vargas <jorge.sa...@hpe.com> Co-authored-by: Javier Albornoz <javier.albor...@hpe.com> Co-authored-by: Esteban Rodriguez Betancourt <esteb...@hpe.com> Co-authored-by: Jorge Arturo Sauma Vargas <jorge.sa...@hpe.com> Co-aughored-by: Lance Richardson <lrich...@redh

[ovs-dev] [PATCH v8 0/7] ovsdb-idl: ovsdb client index support

2017-08-03 Thread Lance Richardson
mewhat. v5: - Rebased on ovs master. - Implemented changes suggestion in review of v4. - Coding style fixes, some text polishing. - Testing by using this feature to eliminate a number of ad-hoc indexing structures used in ovn-controller. - Fixes for memory leaks found in testing. Lance

Re: [ovs-dev] [PATCH] rhel: Use systemd Restart option for ovn-controllers.

2017-08-02 Thread Lance Richardson
rt_controller > $OVN_CONTROLLER_OPTS > +ExecStart=/usr/share/openvswitch/scripts/ovn-ctl --no-monitor \ > + start_controller $OVN_CONTROLLER_OPTS > ExecStop=/usr/share/openvswitch/scripts/ovn-ctl stop_controller > > [Install] > -- > 2.13.3 > LGTM, but now I'm won

Re: [ovs-dev] [PATCH] ovn: Fix the failing "2335: ovn -- ACL logging" test case

2017-08-02 Thread Lance Richardson
> From: nusid...@redhat.com > To: d...@openvswitch.org > Sent: Monday, 31 July, 2017 2:20:53 PM > Subject: [ovs-dev] [PATCH] ovn: Fix the failing "2335: ovn -- ACL logging" > test case > > From: Numan Siddique > > The test case is failing mainly because of timing issue.

Re: [ovs-dev] [PATCH] docs: Refer to correct package name for sphinx theme.

2017-07-26 Thread Lance Richardson
> 2.13.3 > > ___ > dev mailing list > d...@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > I didn't know there was an "ovs-sphinx-theme" package to install before looking at this. LGTM. Acked-by: Lanc

[ovs-dev] [PATCH] ovn-controller: avoid null ptr dereference

2017-07-26 Thread Lance Richardson
Avoid null pointer dereference in fdb_calculate_active_tunnels() when integration bridge isn't present. This is easily encountered by executing "make sandbox SANDBOXFLAGS=--ovn". Fixes: 3475695ea61c ("ovn: l3ha, enable bfd between tunnel endpoints") Signed-off-by: Lan

Re: [ovs-dev] [PATCH] ovn: Restrict encap modification to its creating chassis

2017-07-26 Thread Lance Richardson
e encap table in > the ovn southbound database by only allowing modification by the > chassis that created the encap. > > Signed-off-by: Mark Michelson <mmich...@redhat.com> > Reported-by: Lance Richardson <lrich...@redhat.com> > --- > ovn/controller/chassis.c | 1

Re: [ovs-dev] [PATCH v3] netdev: check for NULL fields in netdev_get_addrs

2017-07-26 Thread Lance Richardson
it a/lib/netdev.c b/lib/netdev.c > index 0d5fad5..eed4d09 100644 > --- a/lib/netdev.c > +++ b/lib/netdev.c > @@ -1946,7 +1946,7 @@ netdev_get_addrs(const char dev[], struct in6_addr > **paddr, > } > > for (ifa = if_addr_list; ifa; ifa = ifa->ifa_next) { > -if (ifa->ifa_addr != NULL) { > +if (ifa->ifa_addr && ifa->ifa_name && ifa->ifa_netmask) { > int family; > > family = ifa->ifa_addr->sa_family; > -- > 1.8.3.1 > Makes sense, LGTM. Acked-by: Lance Richardson <lrich...@redhat.com> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] AUTHORS.rst: Add Mark Michelson.

2017-07-25 Thread Lance Richardson
gt; Martin Casado cas...@nicira.com > Martino Fornasa m...@fornasa.it > -- > 2.13.3 > Acked-by: Lance Richardson <lrich...@redhat.com> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v5 3/4] ovsdb-idl: idl compound indexes implementation

2017-07-14 Thread Lance Richardson
> From: "Rodriguez Betancourt, Esteban" <esteb...@hpe.com> > To: "Lance Richardson" <lrich...@redhat.com> > Cc: "Ben Pfaff" <b...@ovn.org>, d...@openvswitch.org, "Javier Albornoz" > <javier.albor...@hpe.com>, "Arnold

[ovs-dev] [PATCH v7 4/7] ovsdb-idl: Autogenerated functions for compound indexes

2017-07-14 Thread Lance Richardson
ncourt <esteb...@hpe.com> Co-authored-by: Arnoldo Lutz Guevara <arnoldo.lutz.guev...@hpe.com> Co-authored-by: Esteban Rodriguez Betancourt <esteb...@hpe.com> Signed-off-by: Lance Richardson <lrich...@redhat.com> --- v7: - Rebased and made needed changes in ovsdb-idlc.in for

[ovs-dev] [PATCH v7 6/7] ovn-controller: use idl indexes for logical port table

2017-07-14 Thread Lance Richardson
Use IDL index for logical port table lookups, avoiding the overhead of creating/destroying an index hmap for each iteration of the ovn-controller main loop. Signed-off-by: Lance Richardson <lrich...@redhat.com> --- v7: New patch. ovn/controller/binding.c| 27 --- ovn/cont

[ovs-dev] [PATCH v7 7/7] ovn-controller: use idl indexes for logical datapath

2017-07-14 Thread Lance Richardson
Use IDL index to iterate over all logical ports in a given logical datapath, avoiding the overhead of creating/destroying an indexing data structure in each iteration of the ovn-controller main loop. Signed-off-by: Lance Richardson <lrich...@redhat.com> --- v7: New patch. ovn/cont

[ovs-dev] [PATCH v7 5/7] ovn-controller: use idl index for multicast group table

2017-07-14 Thread Lance Richardson
Use IDL index for multicast group table lookups, avoiding the overhead of creating/destroying an index hmap for each iteration of the ovn-controller main loop. Signed-off-by: Lance Richardson <lrich...@redhat.com> --- v7: New patch. ovn/controller/lflow.c | 20 +

[ovs-dev] [PATCH v7 3/7] ovsdb-idl: idl compound indexes implementation

2017-07-14 Thread Lance Richardson
This patch adds support for the creation of multicolumn indexes in the C IDL to enable for efficient search and retrieval of database rows by key. Signed-off-by: Esteban Rodriguez Betancourt <esteb...@hpe.com> Co-authored-by: Lance Richardson <lrich...@redhat.com> Signed-off-by: Lanc

[ovs-dev] [PATCH v7 1/7] ovsdb-idl: compound indexes design document

2017-07-14 Thread Lance Richardson
Arturo Sauma Vargas <jorge.sa...@hpe.com> Co-authored-by: Javier Albornoz <javier.albor...@hpe.com> Co-authored-by: Esteban Rodriguez Betancourt <esteb...@hpe.com> Co-authored-by: Jorge Arturo Sauma Vargas <jorge.sa...@hpe.com> Co-aughored-by: Lance Richardson <lrich...@redh

[ovs-dev] [PATCH v7 2/7] lib: skiplist implementation

2017-07-14 Thread Lance Richardson
Skiplist implementation intended for use in the IDL compound indexes feature. Signed-off-by: Esteban Rodriguez Betancourt <esteb...@hpe.com> Co-authored-by: Lance Richardson <lrich...@redhat.com> Signed-off-by: Lance Richardson <lrich...@redhat.com> --- v7: - More coding sty

[ovs-dev] [PATCH v7 0/7] ovsdb-idl: ovsdb client index support

2017-07-14 Thread Lance Richardson
- Rebased on ovs master. - Implemented changes suggestion in review of v4. - Coding style fixes, some text polishing. - Testing by using this feature to eliminate a number of ad-hoc indexing structures used in ovn-controller. - Fixes for memory leaks found in testing. Lance Richardson (7

Re: [ovs-dev] [PATCH v5 3/4] ovsdb-idl: idl compound indexes implementation

2017-07-13 Thread Lance Richardson
> From: "Rodriguez Betancourt, Esteban" <esteb...@hpe.com> > To: "Lance Richardson" <lrich...@redhat.com>, "Ben Pfaff" <b...@ovn.org> > Cc: d...@openvswitch.org, "Javier Albornoz" <javier.albor...@hpe.com>, > "Arnold

Re: [ovs-dev] [PATCH v5 3/4] ovsdb-idl: idl compound indexes implementation

2017-07-13 Thread Lance Richardson
- Original Message - > From: "Ben Pfaff" <b...@ovn.org> > To: "Lance Richardson" <lrich...@redhat.com> > Cc: d...@openvswitch.org, esteb...@hpe.com, "javier albornoz" > <javier.albor...@hpe.com>, "jorge sauma" > &l

Re: [ovs-dev] [PATCH] tests: Disable no-format-truncation warnings

2017-07-13 Thread Lance Richardson
LAGS) > +if HAVE_WNO_FORMAT_TRUNCATION > +tests_ovstest_CFLAGS += -Wno-format-truncation > +endif > + > dist_check_SCRIPTS = tests/flowgen.pl > > noinst_PROGRAMS += tests/test-strtok_r > -- > 2.13.0 > I've run into this as well after upgrading to F26. I dislike su

Re: [ovs-dev] [PATCH v5 4/4] ovsdb-idl: Autogenerated functions for compound indexes

2017-07-11 Thread Lance Richardson
> From: "Ben Pfaff" <b...@ovn.org> > To: "Lance Richardson" <lrich...@redhat.com> > Cc: d...@openvswitch.org, esteb...@hpe.com, "javier albornoz" > <javier.albor...@hpe.com>, "jorge sauma" > <jorge.sa...@hpe.com>,

Re: [ovs-dev] [PATCH v5 3/4] ovsdb-idl: idl compound indexes implementation

2017-07-11 Thread Lance Richardson
> From: "Ben Pfaff" <b...@ovn.org> > To: "Lance Richardson" <lrich...@redhat.com> > Cc: d...@openvswitch.org, esteb...@hpe.com, "javier albornoz" > <javier.albor...@hpe.com>, "jorge sauma" > <jorge.sa...@hpe.com>,

Re: [ovs-dev] [PATCH v5 2/4] lib: skiplist implementation

2017-07-11 Thread Lance Richardson
> From: "Ben Pfaff" <b...@ovn.org> > To: "Lance Richardson" <lrich...@redhat.com> > Cc: d...@openvswitch.org, esteb...@hpe.com, "javier albornoz" > <javier.albor...@hpe.com>, "jorge sauma" > <jorge.sa...@hpe.com>,

[ovs-dev] [PATCH] tests: use full option name in bridge tests

2017-07-10 Thread Lance Richardson
GNU getopt_long() accepts abbreviated long option names that are unambiguous, but other implemenations (notably musl libc) do not. Avoid issues with non-GNU implementations by using the full option name. Signed-off-by: Lance Richardson <lrich...@redhat.com> --- tests/bridge.at | 4 ++--

Re: [ovs-dev] [PATCH] gitignore: Ignore some generated files.

2017-07-10 Thread Lance Richardson
> From: "Justin Pettit" > To: d...@openvswitch.org > Sent: Monday, 10 July, 2017 2:51:39 AM > Subject: [ovs-dev] [PATCH] gitignore: Ignore some generated files. > > "ovn-docker-overlay-driver", "ovn-docker-underlay-driver", and > "ovs-vtep" are generated, so they should be

[ovs-dev] [PATCH] ovn-controller: fix use-after-free in physical_run()

2017-07-08 Thread Lance Richardson
nd. Fixes: 40128e371ec3 ("physical: Refactor port binding processing.") Signed-off-by: Lance Richardson <lrich...@redhat.com> --- ovn/controller/physical.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/ovn/controller/physical.c b/ovn/controller/physica

[ovs-dev] [PATCH v6 4/4] ovsdb-idl: Autogenerated functions for compound indexes

2017-07-01 Thread Lance Richardson
ncourt <esteb...@hpe.com> Co-authored-by: Arnoldo Lutz Guevara <arnoldo.lutz.guev...@hpe.com> Co-authored-by: Esteban Rodriguez Betancourt <esteb...@hpe.com> Signed-off-by: Lance Richardson <lrich...@redhat.com> --- v6: - No longer need to dynam

[ovs-dev] [PATCH v6 3/4] ovsdb-idl: idl compound indexes implementation

2017-07-01 Thread Lance Richardson
This patch adds support for the creation of multicolumn indexes in the C IDL to enable for efficient search and retrieval of database rows by key. Signed-off-by: Esteban Rodriguez Betancourt <esteb...@hpe.com> Co-authored-by: Lance Richardson <lrich...@redhat.com> Signed-off-by: Lanc

[ovs-dev] [PATCH v6 2/4] lib: skiplist implementation

2017-07-01 Thread Lance Richardson
Skiplist implementation intended for use in the IDL compound indexes feature. Signed-off-by: Esteban Rodriguez Betancourt <esteb...@hpe.com> Co-authored-by: Lance Richardson <lrich...@redhat.com> Signed-off-by: Lance Richardson <lrich...@redhat.com> --- v6: - Coding style edi

[ovs-dev] [PATCH v6 1/4] ovsdb-idl: compound indexes design document

2017-07-01 Thread Lance Richardson
Arturo Sauma Vargas <jorge.sa...@hpe.com> Co-authored-by: Javier Albornoz <javier.albor...@hpe.com> Co-authored-by: Esteban Rodriguez Betancourt <esteb...@hpe.com> Co-authored-by: Jorge Arturo Sauma Vargas <jorge.sa...@hpe.com> Co-aughored-by: Lance Richardson <lrich...@redh

[ovs-dev] [PATCH v6 0/4] ovsdb-idl: ovsdb client index support

2017-07-01 Thread Lance Richardson
. - Implemented changes suggestion in review of v4. - Coding style fixes, some text polishing. - Testing by using this feature to eliminate a number of ad-hoc indexing structures used in ovn-controller. - Fixes for memory leaks found in testing. Lance Richardson (4): ovsdb-idl: compound indexes

[ovs-dev] [PATCH] treewide: .gitignore updates

2017-06-30 Thread Lance Richardson
Signed-off-by: Lance Richardson <lrich...@redhat.com> --- ovn/utilities/.gitignore | 2 ++ tests/.gitignore | 2 ++ vtep/.gitignore | 1 + 3 files changed, 5 insertions(+) diff --git a/ovn/utilities/.gitignore b/ovn/utilities/.gitignore index dbc3719..1d01e0b 100644 ---

[ovs-dev] [PATCH] ovn-controller: avoid crash when vswitchd connection is lost

2017-06-28 Thread Lance Richardson
). Signed-off-by: Lance Richardson <lrich...@redhat.com> --- ovn/controller/ofctrl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ovn/controller/ofctrl.c b/ovn/controller/ofctrl.c index 277d3d7..5aff230 100644 --- a/ovn/controller/ofctrl.c +++ b/ovn/controller/of

[ovs-dev] [RFC 2/3] ovn-controller: use idl indexes for logical port table

2017-06-26 Thread Lance Richardson
Use IDL index for logical port table lookups, avoiding the overhead of creating/destroying an index hmap for each iteration of the ovn-controller main loop. Signed-off-by: Lance Richardson <lrich...@redhat.com> --- ovn/controller/binding.c| 27 --- ovn/controller/bin

[ovs-dev] [RFC 3/3] ovn-controller: use idl indexes for logical datapath

2017-06-26 Thread Lance Richardson
Use IDL index to iterate over all logical ports in a given logical datapath, avoiding the overhead of creating/destroying an indexing data structure in each iteration of the ovn-controller main loop. Signed-off-by: Lance Richardson <lrich...@redhat.com> --- ovn/controller/binding.c

[ovs-dev] [RFC 1/3] ovn-controller: use idl index for multicast group table

2017-06-26 Thread Lance Richardson
Use IDL index for multicast group table lookups, avoiding the overhead of creating/destroying an index hmap for each iteration of the ovn-controller main loop. Signed-off-by: Lance Richardson <lrich...@redhat.com> --- ovn/controller/lflow.c | 20 +- ovn/controller/l

[ovs-dev] [RFC 0/3] ovn-controller: applications of IDL index feature

2017-06-26 Thread Lance Richardson
://patchwork.ozlabs.org/patch/780410/ Lance Richardson (3): ovn-controller: use idl index for multicast group table ovn-controller: use idl indexes for logical port table ovn-controller: use idl indexes for logical datapath ovn/controller/binding.c| 49 --- ovn/controller

[ovs-dev] [PATCH v5 4/4] ovsdb-idl: Autogenerated functions for compound indexes

2017-06-24 Thread Lance Richardson
ncourt <esteb...@hpe.com> Co-authored-by: Arnoldo Lutz Guevara <arnoldo.lutz.guev...@hpe.com> Co-authored-by: Esteban Rodriguez Betancourt <esteb...@hpe.com> Signed-off-by: Lance Richardson <lrich...@redhat.com> --- v5: - Coding style fixes, including in generated idl c

[ovs-dev] [PATCH v5 3/4] ovsdb-idl: idl compound indexes implementation

2017-06-24 Thread Lance Richardson
This patch adds support for the creation of multicolumn indexes in the C IDL to enable for efficient search and retrieval of database rows by key. Signed-off-by: Esteban Rodriguez Betancourt <esteb...@hpe.com> Co-authored-by: Lance Richardson <lrich...@redhat.com> Signed-off-by: Lanc

[ovs-dev] [PATCH v5 2/4] lib: skiplist implementation

2017-06-24 Thread Lance Richardson
Skiplist implementation intended for use in the IDL compound indexes feature. Signed-off-by: Esteban Rodriguez Betancourt <esteb...@hpe.com> Co-authored-by: Lance Richardson <lrich...@redhat.com> Signed-off-by: Lance Richardson <lrich...@redhat.com> --- v5: - Changed skiplist

[ovs-dev] [PATCH v5 1/4] ovsdb-idl: compound indexes design document

2017-06-24 Thread Lance Richardson
Arturo Sauma Vargas <jorge.sa...@hpe.com> Co-authored-by: Javier Albornoz <javier.albor...@hpe.com> Co-authored-by: Esteban Rodriguez Betancourt <esteb...@hpe.com> Co-authored-by: Jorge Arturo Sauma Vargas <jorge.sa...@hpe.com> Co-aughored-by: Lance Richardson <lrich...@redh

[ovs-dev] [PATCH v5 0/4] ovsdb-idl: ovsdb client index support

2017-06-24 Thread Lance Richardson
this current series solidifies some. Lance Richardson (4): ovsdb-idl: compound indexes design document lib: skiplist implementation ovsdb-idl: idl compound indexes implementation ovsdb-idl: Autogenerated functions for compound indexes Documentation/automake.mk | 1

Re: [ovs-dev] [PATCH 3/4 v4] ovsdb-idl: IDL Compound Indexes Implementation

2017-06-20 Thread Lance Richardson
> From: "Ben Pfaff" > To: "Rodriguez Betancourt, Esteban" > Cc: d...@openvswitch.org > Sent: Thursday, 2 February, 2017 12:33:24 PM > Subject: Re: [ovs-dev] [PATCH 3/4 v4] ovsdb-idl: IDL Compound Indexes > Implementation > > On Wed, Dec 28, 2016 at 07:41:48PM

Re: [ovs-dev] [PATCH 3/3] ofproto-dpif-xlate: Fix an additional misaligned reference to ovs_u128.

2017-06-14 Thread Lance Richardson
s_u128. > > nl_msg_put_unspec_uninit() can return a pointer that is only 4-byte > aligned. > > Signed-off-by: Ben Pfaff <b...@ovn.org> > --- > lib/odp-util.c | 11 +++ > ofproto/ofproto-dpif-xlate.c | 11 +-- > 2 files changed, 12

Re: [ovs-dev] [PATCH 2/3] netlink: Introduce helpers for 128-bit integer attributes.

2017-06-14 Thread Lance Richardson
> From: "Ben Pfaff" <b...@ovn.org> > To: d...@openvswitch.org > Cc: "Ben Pfaff" <b...@ovn.org>, "Lance Richardson" <lrich...@redhat.com> > Sent: Wednesday, 14 June, 2017 12:24:56 PM > Subject: [PATCH 2/3] netlink: Introduce

Re: [ovs-dev] [PATCH 1/3] unaligned: Introduce helpers for 32-bit aligned 128-bit integers.

2017-06-14 Thread Lance Richardson
| 39 +++++++ > 2 files changed, 51 insertions(+) > Acked-by: Lance Richardson <lrich...@redhat.com> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] odp-util: Avoid misaligned references to ip6_hdr.

2017-06-14 Thread Lance Richardson
> From: "Ben Pfaff" <b...@ovn.org> > To: d...@openvswitch.org > Cc: "Ben Pfaff" <b...@ovn.org>, "Lance Richardson" <lrich...@redhat.com> > Sent: Wednesday, 14 June, 2017 11:38:07 AM > Subject: [PATCH] odp-util: Avoid misaligne

Re: [ovs-dev] [PATCH] ovs-ofctl: Avoid read overrun in ofperr_decode_msg().

2017-06-13 Thread Lance Richardson
> From: "Ben Pfaff" <b...@ovn.org> > To: "Jarno Rajahalme" <ja...@ovn.org> > Cc: d...@openvswitch.org, "Lance Richardson" <lrich...@redhat.com> > Sent: Tuesday, 13 June, 2017 8:10:22 PM > Subject: Re: [PATCH] ovs-ofctl: Avoid read over

[ovs-dev] [PATCH] ofp-errors: avoid read overrun in ofperr_decode_msg()

2017-06-13 Thread Lance Richardson
to ofperr_decode_msg() indicating the size of the buffer containing the OpenFlow packet. Found via gcc's address sanitizer. Fixes: 506c1ddb3404 ("vconn: Better bundle error management.") Signed-off-by: Lance Richardson <lrich...@redhat.com> --- include/openvswitch/ofp-errors.h | 1 +

[ovs-dev] [PATCH] sandbox: disable ssl for backup ovn southbound db

2017-06-13 Thread Lance Richardson
ation from the database (the unix: socket can still be used, as was the case before SSL was enabled). Fixes: 0ced2a5c5e47 ("sandbox: use ssl for ovn-controller to sb db connection") Signed-off-by: Lance Richardson <lrich...@redhat.com> --- tutorial/ovs-sandbox | 1 - 1 file changed,

Re: [ovs-dev] [PATCH] sandbox: ovn rbac support for sandbox environment

2017-06-13 Thread Lance Richardson
> From: "Russell Bryant" <russ...@ovn.org> > To: "Lance Richardson" <lrich...@redhat.com> > Cc: "ovs dev" <d...@openvswitch.org> > Sent: Tuesday, 13 June, 2017 1:13:31 PM > Subject: Re: [ovs-dev] [PATCH] sandbox: ovn rbac support

Re: [ovs-dev] [PATCH] treewide: undefined behavior, passing null in nonnull parameters

2017-06-13 Thread Lance Richardson
> From: "Lance Richardson" <lrich...@redhat.com> > To: d...@openvswitch.org > Sent: Tuesday, 13 June, 2017 12:57:38 PM > Subject: [ovs-dev] [PATCH] treewide: undefined behavior, passing null in > nonnull parameters > > Eliminate a number of in

[ovs-dev] [PATCH] treewide: undefined behavior, passing null in nonnull parameters

2017-06-13 Thread Lance Richardson
Eliminate a number of instances of undefined behavior related to passing NULL in parameters having "nonnull" annotations. Found with gcc's undefined behavior sanitizer. Signed-off-by: Lance Richardson <lrich...@redhat.com> --- lib/netlink.c | 5 - lib/ofpbuf.c

Re: [ovs-dev] [RFC] treewide: undefined behavior, passing null in nonnull parameters

2017-06-13 Thread Lance Richardson
> From: "Ben Pfaff" <b...@ovn.org> > To: "Lance Richardson" <lrich...@redhat.com> > Cc: d...@openvswitch.org > Sent: Tuesday, 13 June, 2017 11:21:16 AM > Subject: Re: [ovs-dev] [RFC] treewide: undefined behavior, passing null in > nonnull parame

Re: [ovs-dev] [PATCH] byte-order: Fix undefined behavior of BYTES_TO_BE32.

2017-06-13 Thread Lance Richardson
> From: "Ben Pfaff" <b...@ovn.org> > To: "Lance Richardson" <lrich...@redhat.com> > Cc: d...@openvswitch.org > Sent: Tuesday, 13 June, 2017 11:17:26 AM > Subject: Re: [PATCH] byte-order: Fix undefined behavior of BYTES_TO_BE32. > > On Tue, Jun

Re: [ovs-dev] [PATCH] byte-order: Fix undefined behavior of BYTES_TO_BE32.

2017-06-13 Thread Lance Richardson
> From: "Ben Pfaff" <b...@ovn.org> > To: d...@openvswitch.org > Cc: "Ben Pfaff" <b...@ovn.org>, "Lance Richardson" <lrich...@redhat.com> > Sent: Tuesday, 13 June, 2017 12:51:14 AM > Subject: [PATCH] byte-order: Fix undefined behavior

Re: [ovs-dev] [RFC] treewide: undefined behavior, passing null in nonnull parameters

2017-06-13 Thread Lance Richardson
> From: "Ben Pfaff" <b...@ovn.org> > To: "Lance Richardson" <lrich...@redhat.com> > Cc: d...@openvswitch.org > Sent: Tuesday, 13 June, 2017 1:06:12 AM > Subject: Re: [ovs-dev] [RFC] treewide: undefined behavior, passing null in > nonnull parame

[ovs-dev] [RFC] treewide: undefined behavior, passing null in nonnull parameters

2017-06-12 Thread Lance Richardson
Eliminate a number of instances of undefined behavior related to passing NULL in parameters having "nonnull" annotations. Found with gcc's undefined behavior sanitizer. Signed-off-by: Lance Richardson <lrich...@redhat.com> --- Posting this as RFC because there is no apparent

Re: [ovs-dev] [PATCH] byte-order: avoid left shifts with unrepresentable results

2017-06-12 Thread Lance Richardson
- Original Message - > From: "Greg Rose" <gvrose8...@gmail.com> > To: "Lance Richardson" <lrich...@redhat.com> > Cc: d...@openvswitch.org > Sent: Monday, 12 June, 2017 6:44:43 PM > Subject: Re: [ovs-dev] [PATCH] byte-order: avoid left shift

[ovs-dev] [PATCH] byte-order: avoid left shifts with unrepresentable results

2017-06-12 Thread Lance Richardson
sanitizer. Signed-off-by: Lance Richardson <lrich...@redhat.com> --- lib/byte-order.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/byte-order.h b/lib/byte-order.h index e864658..782439f 100644 --- a/lib/byte-order.h +++ b/lib/byte-order.h @@ -105,9 +105,9 @@ uint32_b

Re: [ovs-dev] [PATCH] ofp-util: Initialize tunnel metadata for OpenFlow 1.0 matches.

2017-06-12 Thread Lance Richardson
n_md); > > /* Initialize most of match->flow. */ > match->flow.nw_src = ofmatch->nw_src; > -- > 2.10.2 > Strangely enough, I was just looking at error reports from gcc + ubsan and clang + memory sanitizer for this very problem. (The m

[ovs-dev] [PATCH] ovn: ssl proto/cipher configuration in nb/sb db

2017-06-07 Thread Lance Richardson
Add SSL protocol and cipher columns to SSL tables in northbound and southbound databases. Start nb/sb ovsdb-server with command- line options to use these columns. Add support to ovn-nbctl and ovn-sbctl "set-ssl" commands for user-friendly management of these settings. Signed-off

[ovs-dev] [PATCH] stream: include ssl protocol/cipher options in run-time help

2017-06-07 Thread Lance Richardson
with peer CA certificate --bootstrap-ca-cert=FILE file with peer CA certificate to read or create SSL options: --ssl-protocols=PROTOS list of SSL protocols to enable --ssl-ciphers=CIPHERS list of SSL ciphers to enable Output formatting options: Signed-off-by: Lance Richardson <lr

[ovs-dev] [PATCH v3 3/3] ovn-sbctl: support setting rbac role for remote connections

2017-05-31 Thread Lance Richardson
ead-only"/"read-write" attributes, the specified role is applied to all subsequent connections until changed. Signed-off-by: Lance Richardson <lrich...@redhat.com> --- v3: No changes. v2: No changes. ovn/utilities/ovn-sbctl.c | 12 ++-- 1 file changed, 10 insertions(

[ovs-dev] [PATCH v3 2/3] ovn: add rbac tables to ovn southbound schema

2017-05-31 Thread Lance Richardson
Add rbac "roles" and "permissions" tables to ovn southbound database schema, add support to ovn-northd for managing these tables. Signed-off-by: Lance Richardson <lrich...@redhat.com> --- v3: - Rebased and fixed conflicts in ovn-sb.ovsschema. - Updated

[ovs-dev] [PATCH v3 1/3] ovsdb: add support for role-based access controls

2017-05-31 Thread Lance Richardson
ying RBAC role string as a command-line option to ovsdb-tool (Ben Pfaff). Signed-off-by: Lance Richardson <lrich...@redhat.com> Co-authored-by: Ben Pfaff <b...@ovn.org> --- v3: - Row insertion RBAC now enforces authorization criteria. - Added a test case for r

[ovs-dev] [PATCH v3 0/3] role-based access controls for ovsdb-server, ovn-sb

2017-05-31 Thread Lance Richardson
ic testing: - travis-ci build - unit tests - ovn sandbox, modified to enable rbac - three-node vagrant configuration (one central, two chassis nodes) Lance Richardson (3): ovsdb: add support for role-based access controls ovn: add rbac tables to ovn southbound schema ovn-sbctl: support setting

Re: [ovs-dev] [PATCH v2 1/3] ovsdb: add support for role-based access controls

2017-05-31 Thread Lance Richardson
> From: "Ben Pfaff" <b...@ovn.org> > To: "Lance Richardson" <lrich...@redhat.com> > Cc: d...@openvswitch.org > Sent: Wednesday, 31 May, 2017 2:36:25 PM > Subject: Re: [ovs-dev] [PATCH v2 1/3] ovsdb: add support for role-based > access controls &g

Re: [ovs-dev] [PATCH] rhel: install firewalld ovn files with chmod 644 instead of 755

2017-05-30 Thread Lance Richardson
> From: "Timothy Redaelli" > To: d...@openvswitch.org > Sent: Monday, 29 May, 2017 11:37:26 AM > Subject: [ovs-dev] [PATCH] rhel: install firewalld ovn files with chmod 644 > instead of 755 > > Signed-off-by: Timothy Redaelli > --- LGTM, but I

  1   2   3   >