Re: [ovs-dev] OVS 3.3.1 release date

2024-05-22 Thread Vladislav Odintsov
Thanks Ilya for clarification! Looking forward to see new release. regards, Vladislav Odintsov -Original Message- From: dev on behalf of Ilya Maximets Date: Wednesday, 22 May 2024 at 18:27 To: Vladislav Odintsov , "ovs-dev@openvswitch.org" Cc: "i.maxim...@o

[ovs-dev] OVS 3.3.1 release date

2024-05-22 Thread Vladislav Odintsov
Hi all, I’m wondering whether there is a planned date for OVS 3.3.1 release? Currently there are a lot of useful bugfixes in branch-3.3 above 3.3.1 tag and latest release was on the 17th of February (>3 months ago). regards, Vladislav Odint

Re: [ovs-dev] [PATCH ovn v2] controller: Store src_mac, src_ip in svc_monitor struct.

2024-05-22 Thread Vladislav Odintsov
Again adding forgotten tag: Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2024-April/413198.html regards, Vladislav Odintsov On 22.05.2024, 15:19, "Vladislav Odintsov" wrote: These structure members are read in pinctrl_handler() in a separare thread. This

Re: [ovs-dev] [PATCH ovn] controller: Store src_mac, src_ip in svc_monitor struct.

2024-05-22 Thread Vladislav Odintsov
Hi Ales! Thanks for the review. I've addressed requested changes in v2 with your Acked-by added: https://patchwork.ozlabs.org/project/ovn/patch/20240522121913.609332-1-odiv...@gmail.com/ regards, Vladislav Odintsov On 22.05.2024, 10:59, "dev on behalf of Ales Musil" wrote:

[ovs-dev] [PATCH ovn v2] controller: Store src_mac, src_ip in svc_monitor struct.

2024-05-22 Thread Vladislav Odintsov
quot;) Signed-off-by: Vladislav Odintsov --- v1 -> v2: - Addressed Ales's comment: replaced ip_parse() & ipv6_parse() with ip46_parse(). --- controller/pinctrl.c | 37 - 1 file changed, 16 insertions(+), 21 deletions(-) diff --git a/controller/pi

Re: [ovs-dev] [PATCH ovn] ovn-ctl: Support for --config-file ovsdb-server option.

2024-05-15 Thread Vladislav Odintsov
Thanks Numan! regards, Vladislav Odintsov > On 15 May 2024, at 23:55, Numan Siddique wrote: > > On Fri, May 3, 2024 at 2:05 AM Ales Musil wrote: >> >>> On Tue, Apr 23, 2024 at 6:43 PM Vladislav Odintsov >>> wrote: >>> >>> Since O

Re: [ovs-dev] [PATCH ovn] controller: Store src_mac, src_ip in svc_monitor struct.

2024-05-14 Thread Vladislav Odintsov
Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2024-April/413198.html > On 14 May 2024, at 22:25, Vladislav Odintsov wrote: > > These structure members are read in pinctrl_handler() in a separare thread. > This is unsafe: when IDL is re-connected or some IDL objec

[ovs-dev] [PATCH ovn] controller: Store src_mac, src_ip in svc_monitor struct.

2024-05-14 Thread Vladislav Odintsov
r) >> ovsthread_wrapper (ovn-controller) >> start_thread (libpthread.so.0) >> __clone (libc.so.6) This patch removes unsafe access to IDL objects from pinctrl thread. New svc_monitor structure members are used to store needed data. CC: Numan Siddique Fixes: 8be01f4a5329 ("

[ovs-dev] [PATCH ovn v5 1/2] northd: Make `vxlan_mode` a global variable.

2024-05-03 Thread Vladislav Odintsov
This simplifies code and subsequent commit to explicitely disable VXLAN mode is based on these changes. Also "VXLAN mode" term is introduced in ovn-architecture man page. Signed-off-by: Vladislav Odintsov --- northd/en-global-config.c | 4 +- northd/northd.c

[ovs-dev] [PATCH ovn v5 2/2] northd: Add support for disabling vxlan mode.

2024-05-03 Thread Vladislav Odintsov
7f1bc3d068 Acked-By: Ihar Hrachyshka Fixes: b07f1bc3d068 ("Add VXLAN support for non-VTEP datapath bindings") Signed-off-by: Vladislav Odintsov --- NEWS | 4 northd/en-global-config.c | 7 ++- northd/northd.c | 10 -- northd/nor

[ovs-dev] [PATCH ovn v5 0/2] Add support to disable VXLAN mode.

2024-05-03 Thread Vladislav Odintsov
into two: 1. function call replaced with a global variable `vxlan_mode`; 2. introduced `disable_vxlan_mode` configuration knob; - rebased onto latest main branch. v3: - Removed accidental ovs submodule change. v2: - Added NEWS item. Vladislav Odintsov (2): northd: Make `vxlan_mode

Re: [ovs-dev] [PATCH ovn v4 1/2] northd: Make `vxlan_mode` a global variable.

2024-05-02 Thread Vladislav Odintsov
Hi Ihar, thanks for your review! > On 2 May 2024, at 18:11, Ihar Hrachyshka wrote: > > On Thu, May 2, 2024 at 5:51 AM Vladislav Odintsov <mailto:odiv...@gmail.com>> wrote: > >> This simplifies code and subsequent commit to explicitely disable vxlan >> &g

[ovs-dev] [PATCH ovn v4 1/2] northd: Make `vxlan_mode` a global variable.

2024-05-02 Thread Vladislav Odintsov
This simplifies code and subsequent commit to explicitely disable vxlan mode is based on these changes. Also `vxlan mode` term is introduced in ovn-architecture man page. Signed-off-by: Vladislav Odintsov --- northd/en-global-config.c | 4 +- northd/northd.c | 94

[ovs-dev] [PATCH ovn v4 2/2] northd: Add support for disabling vxlan mode.

2024-05-02 Thread Vladislav Odintsov
ovn/commit/b07f1bc3d068 CC: Ihar Hrachyshka Fixes: b07f1bc3d068 ("Add VXLAN support for non-VTEP datapath bindings") Signed-off-by: Vladislav Odintsov --- NEWS | 3 +++ northd/en-global-config.c | 7 ++- northd/northd.c | 10 -- northd/nor

[ovs-dev] [PATCH ovn v4 0/2] Add support to disable vxlan mode.

2024-05-02 Thread Vladislav Odintsov
change. v2: - Added NEWS item. Vladislav Odintsov (2): northd: Make `vxlan_mode` a global variable. northd: Add support for disabling vxlan mode. NEWS | 3 ++ northd/en-global-config.c | 9 +++- northd/northd.c | 100

[ovs-dev] [PATCH ovn] ovn-ctl: Support for --config-file ovsdb-server option.

2024-04-23 Thread Vladislav Odintsov
Since OVS 3.3.0 ovsdb-server accepts databases and remotes configuration via JSON text file. This patch adds support for such option. Signed-off-by: Vladislav Odintsov --- NEWS | 1 + utilities/ovn-ctl | 39 +++ 2 files changed, 36 insertions

[ovs-dev] [ovn] ovn-controller segmentation fault in svc_monitor_send_tcp_health_check__()

2024-04-11 Thread Vladislav Odintsov
main branch, so my question, if this theoretically can be connected with re-initialization of IDL? If yes, what should be done to avoid such behavior? Should ovn-controller process changes if its IDL is in inconsistent state? Any help is appreciated. Regards, Vladislav Odintsov ___

Re: [ovs-dev] [PATCH ovn v4] Make tunnel ids exhaustion test trigger the problem.

2024-04-06 Thread Vladislav Odintsov
t; reduce its effective max value for tunnel ids; which may become lower > than the current *hint for ports.) > > Fixes: a1f165a7b807 ("northd: fix infinite loop in ovn_allocate_tnlid()") > Co-Authored-By: Vladislav Odintsov > Signed-off-by: Vladislav Odintsov > Signed-off-

Re: [ovs-dev] [PATCH ovn] Make tunnel ids exhaustion test case trigger the problem.

2024-04-05 Thread Vladislav Odintsov
> On 5 Apr 2024, at 18:35, Ihar Hrachyshka wrote: > > On Thu, Apr 4, 2024 at 3:56 PM Vladislav Odintsov <mailto:odiv...@gmail.com>> wrote: >> Thanks Ihar for the patch. >> >> It definitely triggers the bug mentioned in Fixes commit, but how do you

Re: [ovs-dev] [PATCH ovn] Make tunnel ids exhaustion test case trigger the problem.

2024-04-05 Thread Vladislav Odintsov
and then create another one. I’ve tested this diff and see that northd goes to 100% CPU and doesn’t print warn log about ids exhaustion. > On 4 Apr 2024, at 23:34, Ihar Hrachyshka wrote: > > On Thu, Apr 4, 2024 at 3:56 PM Vladislav Odintsov wrote: > >> Thanks

Re: [ovs-dev] [PATCH ovn] northd: fix infinite loop in ovn_allocate_tnlid()

2024-04-04 Thread Vladislav Odintsov
> On 4 Apr 2024, at 22:51, Mark Michelson wrote: > > On 4/4/24 12:46, Dumitru Ceara wrote: >> On 4/4/24 17:52, Vladislav Odintsov wrote: >>> Thanks Dumitru! >>> I’m totally fine with your change. >>> Should I send backport patches with resolved conf

Re: [ovs-dev] [PATCH ovn] Make tunnel ids exhaustion test case trigger the problem.

2024-04-04 Thread Vladislav Odintsov
aps=@e > + > +ovn-nbctl --wait=sb ls-add lsw-exhausted > + > +check_row_count nb:Logical_Switch 4098 > +wait_row_count sb:Datapath_Binding 4097 > > OVS_WAIT_UNTIL([grep "all datapath tunnel ids exhausted" > northd/ovn-northd.log]) > > -- > 2.41.0 >

Re: [ovs-dev] [PATCH ovn] northd: fix infinite loop in ovn_allocate_tnlid()

2024-04-04 Thread Vladislav Odintsov
has similar behaviour to previous implementation. First, tnlid was set to * + 1 and then *hint was set by current tnlid. It seems the same to me. Am I missing something? > >> >> > This is all probably relevant to the question of whether any backports >> > should ha

[ovs-dev] [PATCH ovn v3] northd: Add support for disabling vxlan mode.

2024-04-04 Thread Vladislav Odintsov
ovn/commit/b07f1bc3d068 CC: Ihar Hrachyshka Fixes: b07f1bc3d068 ("Add VXLAN support for non-VTEP datapath bindings") Signed-off-by: Vladislav Odintsov --- NEWS | 3 ++ northd/en-global-config.c | 9 +++- northd/northd.c | 90 ++-

Re: [ovs-dev] [PATCH ovn v2] northd: Add support for disabling vxlan mode.

2024-04-04 Thread Vladislav Odintsov
Oh, my bad. I’ll send out v3. Sorry. > On 4 Apr 2024, at 19:53, Dumitru Ceara wrote: > > On 4/4/24 18:06, Vladislav Odintsov wrote: >> Commit [1] introduced a "vxlan mode" concept. It brought a limitation >> for available tunnel IDs because of lack of space in

Re: [ovs-dev] [PATCH ovn] northd: Add support for disabling vxlan mode.

2024-04-04 Thread Vladislav Odintsov
I’ve sent v2: https://patchwork.ozlabs.org/project/ovn/patch/20240404160628.970615-1-odiv...@gmail.com/ > On 4 Apr 2024, at 18:27, Dumitru Ceara wrote: > > On 4/4/24 14:38, Vladislav Odintsov wrote: >> *Patch [1] is >> https://patchwork.ozlabs.org/project/ovn/patch/2024040

[ovs-dev] [PATCH ovn v2] northd: Add support for disabling vxlan mode.

2024-04-04 Thread Vladislav Odintsov
ovn/commit/b07f1bc3d068 CC: Ihar Hrachyshka Fixes: b07f1bc3d068 ("Add VXLAN support for non-VTEP datapath bindings") Signed-off-by: Vladislav Odintsov --- NEWS | 3 ++ northd/en-global-config.c | 9 +++- northd/northd.c | 90 ++-

Re: [ovs-dev] [PATCH ovn] northd: fix infinite loop in ovn_allocate_tnlid()

2024-04-04 Thread Vladislav Odintsov
v, >> >> Acked-by: Mark Michelson mailto:mmich...@redhat.com>> >> > > Thanks, Vladislav and Mark! Applied to main and backported down to > 23.06 with a minor test change, please see below. > >> On 4/1/24 08:15, Vladislav Odintsov wrote: >>> In c

Re: [ovs-dev] [PATCH ovn] northd: Add support for disabling vxlan mode.

2024-04-04 Thread Vladislav Odintsov
*Patch [1] is https://patchwork.ozlabs.org/project/ovn/patch/20240401121510.758326-1-odiv...@gmail.com/ > On 4 Apr 2024, at 15:33, Vladislav Odintsov wrote: > > Hi Dumitru, > > thanks for your attention on this! > >> On 4 Apr 2024, at 13:06, Dumitru Ceara wrote

Re: [ovs-dev] [PATCH ovn] northd: Add support for disabling vxlan mode.

2024-04-04 Thread Vladislav Odintsov
Hi Dumitru, thanks for your attention on this! > On 4 Apr 2024, at 13:06, Dumitru Ceara wrote: > > On 4/3/24 22:05, Vladislav Odintsov wrote: >> re-sending email because ovs list rejected previous its content for some >> reason: >> >> Hi Ihar, >>

Re: [ovs-dev] [PATCH ovn] northd: Add support for disabling vxlan mode.

2024-04-03 Thread Vladislav Odintsov
her_config, > so - would it work if we modify is_vxlan_mode to consider it too? > > Thanks again for looking into this. > Ihar > > On Wed, Apr 3, 2024 at 6:34 AM Vladislav Odintsov <mailto:odiv...@gmail.com>> wrote: >> Commit [1] introduced a "vxlan mode&quo

Re: [ovs-dev] [PATCH ovn] northd: Add support for disabling vxlan mode.

2024-04-03 Thread Vladislav Odintsov
The failed new testcase assumes that patch [1] is applied. Should I resend them both as a single patchset? 1: https://patchwork.ozlabs.org/project/ovn/patch/20240401121510.758326-1-odiv...@gmail.com/ > On 3 Apr 2024, at 13:34, Vladislav Odintsov wrote: > > Commit [1] introduced a &q

[ovs-dev] [PATCH ovn] northd: Add support for disabling vxlan mode.

2024-04-03 Thread Vladislav Odintsov
ovn/commit/b07f1bc3d068 CC: Ihar Hrachyshka Fixes: b07f1bc3d068 ("Add VXLAN support for non-VTEP datapath bindings") Signed-off-by: Vladislav Odintsov --- northd/en-global-config.c | 9 +++- northd/northd.c | 90 ++- northd/northd.h

[ovs-dev] [PATCH ovn] northd: Add support for disabling vxlan mode.

2024-04-03 Thread Vladislav Odintsov
ovn/commit/b07f1bc3d068 CC: Ihar Hrachyshka Fixes: b07f1bc3d068 ("Add VXLAN support for non-VTEP datapath bindings") Signed-off-by: Vladislav Odintsov --- northd/en-global-config.c | 9 +++- northd/northd.c | 90 ++- northd/northd.h

[ovs-dev] [PATCH ovn] northd: fix infinite loop in ovn_allocate_tnlid()

2024-04-01 Thread Vladislav Odintsov
and adds a testcase. Signed-off-by: Vladislav Odintsov --- lib/ovn-util.c | 10 +++--- tests/ovn-northd.at | 26 ++ 2 files changed, 33 insertions(+), 3 deletions(-) diff --git a/lib/ovn-util.c b/lib/ovn-util.c index ee5cbcdc3..9f97ae2ca 100644 --- a/lib/ovn-util.c

Re: [ovs-dev] [PATCH v2] netdev-offload-tc: Fix offload of tunnel key tp_src.

2023-12-04 Thread Vladislav Odintsov
Thanks Ilya for the clarification. I didn’t know about check_logs logic. Tested-by: Vladislav Odintsov > On 4 Dec 2023, at 15:59, Ilya Maximets wrote: > > On 12/2/23 16:16, Vladislav Odintsov wrote: >> Hi Ilya, thanks for the added test! >> >> I’ve got

[ovs-dev] HWOL with Nvidia ConnectX-6 Dx v2: OVN NAT functionality

2023-12-04 Thread Vladislav Odintsov
2: https://patchwork.ozlabs.org/project/openvswitch/patch/20231201210523.3085560-1-i.maxim...@ovn.org/ Regards, Vladislav Odintsov ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] tunnel: Do not carry source port from a previous tunnel.

2023-12-02 Thread Vladislav Odintsov
type=offloaded outputs related flows. I’ve got some more test results, were offloading is not working (snat/dnat_and_snat usecases), but I’ll start a new thread for this discussion. Tested-by: Vladislav Odintsov > On 2 Dec 2023, at 00:04, Ilya Maximets wrote: > > If a packet is rece

Re: [ovs-dev] [PATCH v2] netdev-offload-tc: Fix offload of tunnel key tp_src.

2023-12-02 Thread Vladislav Odintsov
8f283af89298 ("netdev-tc-offloads: Implement netdev flow put using tc > interface") > Reported-at: > https://mail.openvswitch.org/pipermail/ovs-discuss/2023-October/052744.html > Reported-by: Vladislav Odintsov > Signed-off-by: Ilya Maximets > --- > > Version 2: >

Re: [ovs-dev] [PATCH] netdev-offload-tc: Fix offload of tunnel key tp_src.

2023-11-20 Thread Vladislav Odintsov
Hi Ilya, > On 15 Nov 2023, at 21:51, Ilya Maximets wrote: > > On 11/15/23 14:13, Vladislav Odintsov wrote: >> Hi Ilya, >> >>> On 13 Nov 2023, at 22:25, Ilya Maximets wrote: >>> >>> On 11/13/23 13:13, Eelco Chaudron wrote: >>>> &

Re: [ovs-dev] [PATCH] netdev-offload-tc: Fix offload of tunnel key tp_src.

2023-11-20 Thread Vladislav Odintsov
Hi Marcelo, PSB. > On 16 Nov 2023, at 15:02, Marcelo Ricardo Leitner wrote: > > Hi Vladislav, > > On Wed, Nov 15, 2023 at 04:13:13PM +0300, Vladislav Odintsov wrote: > ... >> Final flow: >> arp,reg11=0x2,reg12=0x6,reg14=0x4,reg15=0x2,tun_id=0x6,tun_src

Re: [ovs-dev] [PATCH] netdev-offload-tc: Fix offload of tunnel key tp_src.

2023-11-15 Thread Vladislav Odintsov
Hi Ilya, > On 13 Nov 2023, at 22:25, Ilya Maximets wrote: > > On 11/13/23 13:13, Eelco Chaudron wrote: >> >> >> On 13 Nov 2023, at 12:43, Vladislav Odintsov wrote: >> >>>> On 13 Nov 2023, at 14:17, Eelco Chaudron wrote: >>>> >

Re: [ovs-dev] [PATCH ovn] controller: Disable inactivity probe for statctrl

2023-11-15 Thread Vladislav Odintsov
Thanks Ales for the patch. My patch was under review for a long period of time and there appeared a new OF connection :) Acked-by: Vladislav Odintsov mailto:odiv...@gmail.com>> > On 15 Nov 2023, at 14:06, Ales Musil wrote: > > The inactivity probe was disabled for all connecti

Re: [ovs-dev] [PATCH branch-2.17] datapath-linux: Fix kmod build with recent CentOS Stream kernels

2023-11-14 Thread Vladislav Odintsov
Hi Ilya, Thanks for the review. regards, Vladislav Odintsov > On 15 Nov 2023, at 00:17, Ilya Maximets wrote: > > On 11/14/23 13:47, Vladislav Odintsov wrote: >> With kernel 4.18.0-477.x.y there was a compilation error: >> >> /builddir/build/BUILD/openvswitch-2.

[ovs-dev] [PATCH branch-2.17] datapath-linux: Fix kmod build with recent CentOS Stream kernels

2023-11-14 Thread Vladislav Odintsov
' was here This was introduced by upstream kernel commit [0]. This patch fixes this error adding a new path to searched functions to lookup. 0: https://lore.kernel.org/all/20211105203507.gvgl5bzmw%25a...@linux-foundation.org/ Signed-off-by: Vladislav Odintsov --- acinclude.m4 | 10 -- 1 file

Re: [ovs-dev] [PATCH] netdev-offload-tc: Fix offload of tunnel key tp_src.

2023-11-13 Thread Vladislav Odintsov
> On 13 Nov 2023, at 14:17, Eelco Chaudron wrote: > > > > On 8 Nov 2023, at 14:39, Vladislav Odintsov wrote: > >> Hi Ilya, Eelco, >> >> I’ve tried this patch against 3.1 and latest master branch. There are no >> warnings anymore, >> bu

Re: [ovs-dev] [PATCH] netdev-offload-tc: Fix offload of tunnel key tp_src.

2023-11-08 Thread Vladislav Odintsov
arios the source port doesn't actually end >> up in the action itself. >> Having a mismatch between the userspace and TC leads to constant >> revalidation of the flow and warnings in the log, and might >> potentially cause mishandling of the traffic, even though the impact &

Re: [ovs-dev] [PATCH ovn] controller: disable OpenFlow inactivity probing

2023-11-08 Thread Vladislav Odintsov
Thanks Numan! > On 2 Nov 2023, at 23:44, Numan Siddique wrote: > > On Fri, Sep 22, 2023 at 2:40 PM Han Zhou <mailto:hz...@ovn.org>> wrote: >> >> On Mon, Sep 11, 2023 at 7:31 AM Vladislav Odintsov >> wrote: >>> >>> Hi Dumitru, >>&g

Re: [ovs-dev] OVN weekly community meeting

2023-10-24 Thread Vladislav Odintsov
> On 24 Oct 2023, at 12:01, Dumitru Ceara wrote: > > On 10/24/23 10:57, Vladislav Odintsov wrote: >> Hi Dumitru! >> >>> On 24 Oct 2023, at 10:34, Dumitru Ceara wrote: >>> >>> On 10/23/23 11:58, Dumitru Ceara wrote: >>>>> In

Re: [ovs-dev] OVN weekly community meeting

2023-10-24 Thread Vladislav Odintsov
3tIXSnZZ8 > > Best regards, > Dumitru > > ___ > dev mailing list > d...@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev Regards, Vladislav Odintsov ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH ovn] controller: disable OpenFlow inactivity probing

2023-09-11 Thread Vladislav Odintsov
60s). Maybe you can give any hint how to solve this [1]. 1: https://mail.openvswitch.org/pipermail/ovs-dev/2023-June/405445.html > On 11 Sep 2023, at 15:57, Dumitru Ceara wrote: > > On 9/11/23 14:54, Dumitru Ceara wrote: >> On 6/14/23 20:02, Vladislav Odintsov wrote: >>>

Re: [ovs-dev] [PATCH ovn 2/2] ovn-controller: Assume well-known tables are in the SB schema.

2023-08-17 Thread Vladislav Odintsov
; > Ack, I did that now. > >> Otherwise it looks good to me! >> >> Acked-by: Han Zhou mailto:hz...@ovn.org>> >> > > Thanks, applied to main and backported to all branches down to 22.03. > > Regards, > Dumitru Regards, Vladislav Odintsov ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [ovn] ovn-controller high memory consumption with sbrec_server_has_##table##_table - enabled codepath

2023-08-01 Thread Vladislav Odintsov
] introduced such behaviour was backported). 0: https://github.com/ovn-org/ovn/commit/525829c47d09a114de8536d23784c458977d8321 > On 31 Jul 2023, at 14:43, Vladislav Odintsov wrote: > > Thanks Dumitru! > > I’ll test this patch in a few days. > >> On 28 Jul 2023, at 14:36, Dumitru

Re: [ovs-dev] [ovn] ovn-controller high memory consumption with sbrec_server_has_##table##_table - enabled codepath

2023-07-31 Thread Vladislav Odintsov
n your data set too. > > Thanks, > Dumitru > > [0] > https://github.com/ovn-org/ovn/blob/5a1d82cb28c554276e0c17718f808b8f244cb162/Documentation/intro/install/ovn-upgrades.rst?plain=1#L28 > > On 7/25/23 10:19, Vladislav Odintsov wrote: >> Many thanks for the information! &g

Re: [ovs-dev] [ovn] ovn-controller high memory consumption with sbrec_server_has_##table##_table - enabled codepath

2023-07-25 Thread Vladislav Odintsov
Many thanks for the information! > On 25 Jul 2023, at 11:14, Dumitru Ceara wrote: > > On 7/24/23 21:10, Vladislav Odintsov wrote: >> Hi Dumitru, >> > > Hi Vladislav, > >> I just wanted to ask wether you need any help (maybe, testing) in this? >> I’

Re: [ovs-dev] [ovn] ovn-controller high memory consumption with sbrec_server_has_##table##_table - enabled codepath

2023-07-24 Thread Vladislav Odintsov
, Dumitru Ceara wrote: >>> On 7/11/23 18:33, Vladislav Odintsov wrote: >>>> Hi Dumitru, >>>> >>>> The system on which I reproduced this issue is running 22.09.x version. >>>> I’ve tried to upgrade ovn-controller to main branch + your patch

Re: [ovs-dev] [PATCH 1/2] utilities: add "--detach" option to ovs-ctl

2023-07-17 Thread Vladislav Odintsov
Sorry, there was a typo. regards, Vladislav Odintsov > On 17 Jul 2023, at 23:59, Vladislav Odintsov wrote: > > Hi Ilya, > > My usecase is to run ovsdb-server to serve hardware_vtep ovsdb schema in OVN > controller vtep scenario. Container is used to run service on top

Re: [ovs-dev] [PATCH 1/2] utilities: add "--detach" option to ovs-ctl

2023-07-17 Thread Vladislav Odintsov
problem is we need to re-apply this patch to newer versions unless it is not accepted to upstream… I’m wonder what’s the problem to use this script not only to run ovsdb-server with Open_vSwitch schema with known limitations? regards, Vladislav Odintsov > On 14 Jul 2023, at 20:20, Ilya Maxim

Re: [ovs-dev] [ovn] ovn-controller high memory consumption with sbrec_server_has_##table##_table - enabled codepath

2023-07-11 Thread Vladislav Odintsov
/runs/5519892057 > On 11 Jul 2023, at 14:39, Dumitru Ceara wrote: > > On 7/10/23 22:20, Vladislav Odintsov wrote: >> Hi Dumitru, >> >> thanks for digging into this! I highly appreciate your help! >> > > No worries, my pleasure! :) > >> Pleas

Re: [ovs-dev] [ovn] ovn-controller high memory consumption with sbrec_server_has_##table##_table - enabled codepath

2023-07-10 Thread Vladislav Odintsov
Hi Dumitru, thanks for digging into this! I highly appreciate your help! Please, see my answers inline. > On 10 Jul 2023, at 15:28, Dumitru Ceara wrote: > > On 7/10/23 12:57, Dumitru Ceara wrote: >> On 7/6/23 13:00, Vladislav Odintsov wrote: >>> >>> >&g

Re: [ovs-dev] [ovn] ovn-controller high memory consumption with sbrec_server_has_##table##_table - enabled codepath

2023-07-06 Thread Vladislav Odintsov
> On 5 Jul 2023, at 20:07, Vladislav Odintsov wrote: > > Hi Dumitru, > > thanks for the quick response! > >> On 5 Jul 2023, at 19:53, Dumitru Ceara wrote: >> >> On 7/5/23 17:14, Vladislav Odintsov wrote: >>> Hi, >>> >> >>

Re: [ovs-dev] [ovn] ovn-controller high memory consumption with sbrec_server_has_##table##_table - enabled codepath

2023-07-05 Thread Vladislav Odintsov
Hi Dumitru, thanks for the quick response! > On 5 Jul 2023, at 19:53, Dumitru Ceara wrote: > > On 7/5/23 17:14, Vladislav Odintsov wrote: >> Hi, >> > > Hi Vladislav, > >> we’ve noticed there is a huge ovn-controller memory consumption introduced >>

[ovs-dev] [ovn] ovn-controller high memory consumption with sbrec_server_has_##table##_table - enabled codepath

2023-07-05 Thread Vladislav Odintsov
ovn/commit/1b0dbde940706e5de6e60221be78a278361fa76d Regards, Vladislav Odintsov ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH ovn] controller: disable OpenFlow inactivity probing

2023-06-14 Thread Vladislav Odintsov
out. regards, Vladislav Odintsov > On 9 Jun 2023, at 18:28, Mark Michelson wrote: > > Hi, > > Thanks for linking the email thread, since I had the exact same concern that > Numan did about detecting if ovs-vswitchd goes down. It sounds like because > of the n

Re: [ovs-dev] [PATCH ovn v2] controller, northd: pass arp/nd from HW VTEP to lrouter pipeline

2023-06-14 Thread Vladislav Odintsov
Thanks Dumitru! > On 14 Jun 2023, at 16:37, Dumitru Ceara wrote: > > On 5/30/23 17:03, Vladislav Odintsov wrote: >> This patch is intended to make next two changes: >> >> 1. Support create/update of MAC_Binding for GARP/ND from HW VTEP. >> >> Prior

Re: [ovs-dev] [PATCH 1/2] utilities: add "--detach" option to ovs-ctl

2023-06-13 Thread Vladislav Odintsov
Hi Ilya, thanks for the attention on this patchset. > On 13 Jun 2023, at 14:58, Ilya Maximets wrote: > > On 6/7/23 08:33, Vladislav Odintsov wrote: >> Default is yes (current behavior). This means that after start process >> will be run in background. When "no

Re: [ovs-dev] [ovn] ha-chassis-group false positive failover

2023-06-08 Thread Vladislav Odintsov
andard OVS controller socket (br-int.mgmt), please give an advice. Alternatively I’ve been thinking about creation another socket with another path for ovs-vswitchd<->ovn-controller OF communication. But I’m concerned about paths consistency across different distributions… Thoughts? > On 6 Jun

[ovs-dev] [PATCH ovn] controller: disable OpenFlow inactivity probing

2023-06-08 Thread Vladislav Odintsov
v/2023-May/404625.html Signed-off-by: Vladislav Odintsov --- NEWS| 5 + controller/ofctrl.c | 14 ++ controller/ofctrl.h | 4 +--- controller/ovn-controller.8.xml | 14 -- controller/ovn-controller.c

Re: [ovs-dev] [PATCH ovn v2] northd: match only on supported protocols to handle_svc_check

2023-06-08 Thread Vladislav Odintsov
Thanks, Dumitru! > On 8 Jun 2023, at 16:31, Dumitru Ceara wrote: > > On 5/30/23 14:41, Vladislav Odintsov wrote: >> Depending on the udp service, it can reply with some udp data. >> In that case ovn-controller will warn with next message: >> >> pinctrl(ovn_pi

[ovs-dev] [PATCH 1/2] utilities: add "--detach" option to ovs-ctl

2023-06-07 Thread Vladislav Odintsov
seful when running ovs-ctl inside docker container to make ovs* process to be a pid 1. Note, that with `--detach=no` database settings initialization is not done. db-version, system-ids are not set and transient ports are not deleted. Signed-off-by: Vladislav Odintsov --- utilities/ovs-

[ovs-dev] [PATCH 2/2] utilities: add --in-db-ssl option to ovs-ctl

2023-06-07 Thread Vladislav Odintsov
ssl", which has default behavior as it is now: run ovsdb server with ssl options. User must pass "--in-db-ssl=no" to run ovsdb-server without these arguments. Signed-off-by: Vladislav Odintsov --- utilities/ovs-ctl.in | 11 --- 1 file changed, 8 insertions(+), 3 deletions(

Re: [ovs-dev] [ovn] ha-chassis-group false positive failover

2023-06-06 Thread Vladislav Odintsov
Hi Han, thanks for your inputs! Please see comments inline. > On 5 Jun 2023, at 21:01, Han Zhou wrote: > > On Mon, Jun 5, 2023 at 8:58 AM Vladislav Odintsov <mailto:odiv...@gmail.com>> wrote: >> >> Hi Dumitru, Ilya, Han, >> >> do you guys have any

Re: [ovs-dev] [ovn] ha-chassis-group false positive failover

2023-06-05 Thread Vladislav Odintsov
Hi Dumitru, Ilya, Han, do you guys have any comments here? I’m gonna start working on this change in near future... Thank you. > On 17 May 2023, at 18:34, Numan Siddique wrote: > > On Wed, May 17, 2023 at 4:44 AM Vladislav Odintsov <mailto:odiv...@gmail.com>> wrote: >>

Re: [ovs-dev] [PATCH ovn 5/5] controller, northd: pass arp/nd from HW VTEP to lrouter pipeline

2023-05-30 Thread Vladislav Odintsov
v2 of patch #5 was submitted: https://patchwork.ozlabs.org/project/ovn/patch/20230530150328.1224972-1-odiv...@gmail.com/ > On 30 May 2023, at 13:12, Vladislav Odintsov wrote: > > > >> On 30 May 2023, at 13:10, Dumitru Ceara wrote: >> >> On 5/30/23 11:59, Vl

[ovs-dev] [PATCH ovn v2] controller, northd: pass arp/nd from HW VTEP to lrouter pipeline

2023-05-30 Thread Vladislav Odintsov
-by: Vladislav Odintsov --- v1 -> v2: - Addressed Dumitru's review comments. --- NEWS| 2 + controller/binding.c| 47 +++ controller/local_data.h | 3 ++ controller/physical.c | 45 ++- northd/northd.c | 10 + northd/ovn-northd.8.

Re: [ovs-dev] [PATCH ovn] controller: don't report UDP as unsupported proto in svc_check

2023-05-30 Thread Vladislav Odintsov
; On 5/24/23 13:03, Ales Musil wrote: >> On Mon, May 22, 2023 at 11:18 PM Vladislav Odintsov >> wrote: >> >>> Depending on the udp service, it can reply with some udp data. >>> In that case ovn-controller will warn with next message: >>> >>&g

[ovs-dev] [PATCH ovn v2] northd: match only on supported protocols to handle_svc_check

2023-05-30 Thread Vladislav Odintsov
-by: Vladislav Odintsov --- v1 -> v2: - Addressed Dumitru's suggestion to match on supported protocols instead of validating protocol inside pinctrl thread. --- northd/northd.c | 2 +- tests/ovn-northd.at | 30 +++--- 2 files changed, 16 insertions(+), 16 deleti

Re: [ovs-dev] [PATCH ovn 5/5] controller, northd: pass arp/nd from HW VTEP to lrouter pipeline

2023-05-30 Thread Vladislav Odintsov
> On 30 May 2023, at 13:10, Dumitru Ceara wrote: > > On 5/30/23 11:59, Vladislav Odintsov wrote: >> Hi Dumitru, >> >> thanks for the review! >> My answers are inline. >> >>> On 30 May 2023, at 12:27, Dumitru Ceara wrote: >>> >&g

Re: [ovs-dev] [PATCH ovn 5/5] controller, northd: pass arp/nd from HW VTEP to lrouter pipeline

2023-05-30 Thread Vladislav Odintsov
Hi Dumitru, thanks for the review! My answers are inline. > On 30 May 2023, at 12:27, Dumitru Ceara wrote: > > On 5/19/23 20:18, Vladislav Odintsov wrote: >> This patch is intended to make next two changes: >> >> 1. Support create/update of MAC_Binding for GARP/ND

[ovs-dev] [PATCH ovn] controller: don't report UDP as unsupported proto in svc_check

2023-05-22 Thread Vladislav Odintsov
(). This is not something abnormal, so don't write warnings. Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1913162 Signed-off-by: Vladislav Odintsov --- controller/pinctrl.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/controller/pinctrl.c b/controller/pinctrl.c index b4be22020

Re: [ovs-dev] [ovn] help wanted: how MC_FLOOD actions works for eth.mcast traffic coming from localnet lports?

2023-05-19 Thread Vladislav Odintsov
...@gmail.com/ > On 17 May 2023, at 19:05, Vladislav Odintsov wrote: > > Thanks Dumitru for the response. > > I’ve looked through this code and even tried to implement similar logic for > vtep lport, but realized, that vtep mcast traffic is a bit different from > localnet

[ovs-dev] [PATCH ovn 5/5] controller, northd: pass arp/nd from HW VTEP to lrouter pipeline

2023-05-19 Thread Vladislav Odintsov
-by: Vladislav Odintsov --- controller/binding.c| 48 controller/local_data.h | 3 ++ controller/physical.c | 46 +-- northd/northd.c | 10 + northd/ovn-northd.8.xml | 6 +++ tests/ovn.at| 99 - 6

[ovs-dev] [PATCH ovn 3/5] controller: move put_load for port-binding in function

2023-05-19 Thread Vladislav Odintsov
This is done to simplify and remove duplication of code. New function will be used in next patch. Signed-off-by: Vladislav Odintsov --- controller/physical.c | 29 + 1 file changed, 13 insertions(+), 16 deletions(-) diff --git a/controller/physical.c b/controller

[ovs-dev] [PATCH ovn 2/5] northd: build vtep hairpin lflows only for lswitches with vtep lports

2023-05-19 Thread Vladislav Odintsov
There is no need to build lflows for datapaths, where there are no vtep type lports. For instance, edge-outside logical switch, which has no vtep lports but has many chassis redirect lport, can have many useless lflows. Signed-off-by: Vladislav Odintsov --- northd/northd.c | 5

[ovs-dev] [PATCH ovn 4/5] controller: fix typo in comments

2023-05-19 Thread Vladislav Odintsov
Signed-off-by: Vladislav Odintsov --- controller/binding.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/controller/binding.c b/controller/binding.c index 28218b2e8..c7a2b3f10 100644 --- a/controller/binding.c +++ b/controller/binding.c @@ -2092,7 +2092,7 @@ binding_run

[ovs-dev] [PATCH ovn 1/5] northd: fix ls_in_hairpin l3dgw flow generation

2023-05-19 Thread Vladislav Odintsov
ller, northd, vtep: support routed networks with HW VTEP") Signed-off-by: Vladislav Odintsov --- northd/northd.c | 35 ++- northd/ovn-northd.8.xml | 13 +++-- tests/ovn.at| 17 +++-- 3 files changed, 24 insertions(+)

[ovs-dev] [PATCH ovn 0/5] VTEP lport ARP handling fixes & GARP support

2023-05-19 Thread Vladislav Odintsov
, which removes some code duplication. Patch #5 adds support for GARP coming from vtep lport handling on chassisredirect port and makes some changes in ARP/ND responder logic. Vladislav Odintsov (5): northd: fix ls_in_hairpin l3dgw flow generation northd: build vtep hairpin lflows only

Re: [ovs-dev] [ovn] help wanted: how MC_FLOOD actions works for eth.mcast traffic coming from localnet lports?

2023-05-17 Thread Vladislav Odintsov
lport mcast packets to other remote chassis. I guess I need to reject mcast l2 flood to remote ports if REGBIT_FROM_RAMP == 1. Do you have an idea for the correct place to put such logic in? > On 16 May 2023, at 23:02, Dumitru Ceara wrote: > > On 5/16/23 21:48, Vladislav Odintsov wro

Re: [ovs-dev] [ovn] ha-chassis-group false positive failover

2023-05-17 Thread Vladislav Odintsov
> On 16 May 2023, at 23:54, Numan Siddique wrote: > > Hi Vladislav, > > Sorry for the late reply. > > PSB for few comments. Thanks for your reply! My answers are inline. > > > > On Tue, May 16, 2023 at 3:42 PM Vladislav Odintsov <mailto:odiv..

Re: [ovs-dev] [ovn] help wanted: how MC_FLOOD actions works for eth.mcast traffic coming from localnet lports?

2023-05-16 Thread Vladislav Odintsov
Hi Numan, Dumitru, Ilya, Mark, if someone can help, I’ll be very grateful. Thanks in advance. > On 15 May 2023, at 15:06, Vladislav Odintsov wrote: > > Hi, > > I’m implementing neighbour learning on the chassis-redirect ports for > traffic coming from lport of vtep

Re: [ovs-dev] [ovn] ha-chassis-group false positive failover

2023-05-16 Thread Vladislav Odintsov
Hi Numan, Dumitru, Ilya, I guess I’ve managed to deal with some of these problems and have some conclusions. Please see inline. > On 14 Apr 2023, at 16:26, Vladislav Odintsov wrote: > > And as a follow-up, I see sometimes next error message in ovn-controller log,

[ovs-dev] [ovn] help wanted: how MC_FLOOD actions works for eth.mcast traffic coming from localnet lports?

2023-05-15 Thread Vladislav Odintsov
net to vif located on other chassis? Am I missing something? Let me know if any additional information is needed. Thanks! Regards, Vladislav Odintsov ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH ovn] ovn-controller docs: fix typo in ovn-monitor-all description

2023-05-05 Thread Vladislav Odintsov
Make it more clear that ovn-monitor-all option has effect on OVN Southbound database rather than local OVS. Reported-at: https://mail.openvswitch.org/pipermail/ovs-discuss/2023-May/052421.html Reported-by: Ilya Maximets Signed-off-by: Vladislav Odintsov --- controller/ovn-controller.8.xml

Re: [ovs-dev] [PATCH ovn v2] utilities: increase OVSDB inactivity probe interval for ovn-*ctl

2023-05-04 Thread Vladislav Odintsov
Hi Dumitru, Mark, The new version (v4) has been submitted at https://patchwork.ozlabs.org/project/ovn/patch/20230504165510.4026066-1-odiv...@gmail.com/ > On 3 May 2023, at 17:18, Dumitru Ceara wrote: > > On 5/3/23 16:12, Vladislav Odintsov wrote: >> Hi Dumitru and Mark

[ovs-dev] [PATCH ovn v4] utilities: increase OVSDB inactivity probe interval for ovn-*ctl

2023-05-04 Thread Vladislav Odintsov
option was provided, the initial (12 ms) interval is left. Signed-off-by: Vladislav Odintsov --- v3 -> v4: - Rebased on a fresh main branch. v2 -> v3: - Addressed Dumitru's and Mark's suggestion to split ovn-{n,s}bctl configuration option dbctl_probe_interval for nbctl_... and

[ovs-dev] [PATCH ovn v3] utilities: increase OVSDB inactivity probe interval for ovn-*ctl

2023-05-04 Thread Vladislav Odintsov
option was provided, the initial (12 ms) interval is left. Signed-off-by: Vladislav Odintsov --- v2 -> v3: - Addressed Dumitru's and Mark's suggestion to split ovn-{n,s}bctl configuration option dbctl_probe_interval for nbctl_... and sbctl_... . - Added NEWS entry. - Fixes ty

Re: [ovs-dev] [PATCH ovn v2] utilities: increase OVSDB inactivity probe interval for ovn-*ctl

2023-05-03 Thread Vladislav Odintsov
Hi Dumitru and Mark, thanks for the review! > On 3 May 2023, at 16:56, Dumitru Ceara wrote: > > On 5/3/23 15:47, Mark Michelson wrote: >> On 5/3/23 09:03, Dumitru Ceara wrote: >>> Hi Vladislav, >>> >>> On 5/3/23 02:55, Vladislav Odintsov wrot

Re: [ovs-dev] [PATCH ovn] utilities: disable OVSDB inactivity probes for non-daemon ovn-nbctl

2023-05-02 Thread Vladislav Odintsov
1: https://patchwork.ozlabs.org/project/ovn/patch/20230503005531.4005891-1-odiv...@gmail.com/ > On 18 Apr 2023, at 18:31, Vladislav Odintsov wrote: > > > >> On 18 Apr 2023, at 16:59, Dumitru Ceara wrote: >> >> On 4/14/23 15:37, Vladislav Odintsov wrote: >>&g

[ovs-dev] [PATCH ovn v2] utilities: increase OVSDB inactivity probe interval for ovn-*ctl

2023-05-02 Thread Vladislav Odintsov
to configure intervals in OVN Northbound database: OVN_Northbound.NB_Global.options.dbctl_inactivity_probe for ovn-nbctl and ovn-sbctl utilities. If no DB configuration option was provided, the initial (12 ms) interval is left. Signed-off-by: Vladislav Odintsov --- lib/ovn-util.h

Re: [ovs-dev] [PATCH ovn] utilities: disable OVSDB inactivity probes for non-daemon ovn-nbctl

2023-04-18 Thread Vladislav Odintsov
> On 18 Apr 2023, at 16:59, Dumitru Ceara wrote: > > On 4/14/23 15:37, Vladislav Odintsov wrote: >> Hi Dumitru, >> >>> On 13 Apr 2023, at 11:55, Dumitru Ceara wrote: >>> >>> Hi Vladislav, >>> >>> On 4/3/23 12:08, Ilya Maxi

  1   2   3   4   5   >