Re: [ovs-dev] [PATCH branch-2.8] netdev-dpdk: replace uint8_t with dpdk_port_t

Hi Ben, On 09/01/18 16:56, Ben Pfaff wrote: >> Sure, I was just concerned was it fixing a compilation issue or such for >> you. I've seen it's been applied already and I've given it a quick >> validation check without issue so no worries. > > I interpreted your Signed-off-by as a request to

[ovs-dev] [PATCH v3 0/3] Fix tunnel neighbor cache population

Currenlty, OVS snoops any ARP or ND packets in any bridge and populates the tunnel neighbor cache with the retreived data. For instance, when ARP reply originated by a tenant is received on an overlay bridge, the ARP message is snooped and tunnel neighbor cache is filled with tenant data, however

Re: [ovs-dev] [PATCH 0/4] ovsdb-dot python3 fixes

On Wed, Dec 27, 2017 at 06:27:09PM +, Markos Chandras wrote: > Hello, > > This patchset fixes some python3 issues when running the ovsdb-dot > tool with python3. Thanks for the fixes. I applied this series to master. ___ dev mailing list

Re: [ovs-dev] [PATCH 0/3] Initial support for new SIP Alg.

On 1/9/18, 11:33 AM, "ovs-dev-boun...@openvswitch.org on behalf of Mark Michelson" wrote: On 12/22/2017 01:53 PM, Tiago Lam wrote: > This patch-set is an initial approach at implementing the new SIP Alg, >

Re: [ovs-dev] [patch v3 2/5] conntrack: Fix alg expectation cleanup.

On 1/9/18, 12:56 PM, "ovs-dev-boun...@openvswitch.org on behalf of Ben Pfaff" wrote: On Mon, Jan 08, 2018 at 12:54:26PM -0800, Darrell Ball wrote: > Presently, alg expectations are removed by being time expired. > This was

Re: [ovs-dev] [PATCH v2 0/4] ovs-bugtool: Enahncing and refactoring the OVS-Bugtool.

On Thu, Jan 04, 2018 at 04:01:00PM +, Dávid Patrik Pintér wrote: > The development and maintenance of the OVS-Bugtool is long due. It completely > ignores DPDK datapath-related logs and information, which are essential by > troubleshooting OVS with DPDK datapath. There is also a wide set of

Re: [ovs-dev] [PATCH V3] ofproto-dpif-xlate: Incorrect handling of errors in group action processing

On Fri, Jan 05, 2018 at 10:42:31AM +, Vishal Deep Ajmera wrote: > As per OpenFlow v1.3 specification, when an action list contains a group > action a copy of the packet is passed to the group for processing by the > group. This means that if there is an error encountered during group >

Re: [ovs-dev] [PATCH] ovn-sb.xml: Correct statement on use of bit ranges.

On Tue, Jan 09, 2018 at 03:50:37PM +0100, Jakub Sitnicki wrote: > Bit range specifiers can be used only with ordinal fields. > > Signed-off-by: Jakub Sitnicki Thanks, applied to master and backported as far as it would go. ___ dev

Re: [ovs-dev] [PATCH] ovn-controller: Change duplicate flows trace from INFO to DBG

On Tue, Jan 09, 2018 at 02:54:36PM +0100, Daniel Alvarez wrote: > When ovn-controller detects that a flow is duplicated, it will print > an INFO trace. Even though it's rate limited, this patch is changing > the trace level back to DEBUG to reduce noise. > > Signed-off-by: Daniel Alvarez

Re: [ovs-dev] [patch v3 2/5] conntrack: Fix alg expectation cleanup.

On Mon, Jan 08, 2018 at 12:54:26PM -0800, Darrell Ball wrote: > Presently, alg expectations are removed by being time expired. > This was intended to happen before the control connections and > was intended to minimize the extra work involved for tracking and > removing the expectations. This is

Re: [ovs-dev] [PATCH] doc: Fix mailing list addresses.

On Tue, Jan 09, 2018 at 03:57:35PM +0100, Jakub Sitnicki wrote: > Correct typo in the email domain. > > Signed-off-by: Jakub Sitnicki Thanks, applied to master, branch-2.8, branch-2.7. ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCH 0/3] Initial support for new SIP Alg.

On 12/22/2017 01:53 PM, Tiago Lam wrote: This patch-set is an initial approach at implementing the new SIP Alg, mentioned by Aaron at [1]. I'm mostly interested in getting to know your thoughts of how this is headed. There are a couple of points that are worth bringing up: - As mentioned in

Re: [ovs-dev] [PATCH branch-2.8] netdev-dpdk: replace uint8_t with dpdk_port_t

On Tue, Jan 09, 2018 at 04:43:32PM +, Stokes, Ian wrote: > > > > -Original Message- > > From: Markos Chandras [mailto:mchand...@suse.de] > > Sent: Tuesday, January 9, 2018 4:23 PM > > To: Stokes, Ian ; d...@openvswitch.org > > Cc: Kavanagh, Mark B

Re: [ovs-dev] [PATCH] ofproto-dpif: Remove variable length userdata probe.

On Wed, Dec 20, 2017 at 07:42:40PM -0800, Justin Pettit wrote: > Commit e995e3df57 ("Allow OVS_USERSPACE_ATTR_USERDATA to be variable > length.") changed userspace action userdata from eight bytes to variable > length. OVS only supports Linux kernels greater than or equal to 3.10, > which include

Re: [ovs-dev] [PATCH branch-2.8] netdev-dpdk: replace uint8_t with dpdk_port_t

On Tue, Jan 09, 2018 at 05:02:11PM +, Markos Chandras wrote: > Hi Ben, > > On 09/01/18 16:56, Ben Pfaff wrote: > >> Sure, I was just concerned was it fixing a compilation issue or such for > >> you. I've seen it's been applied already and I've given it a quick > >> validation check without

Re: [ovs-dev] [PATCH branch-2.8] netdev-dpdk: replace uint8_t with dpdk_port_t

> Hi Ben, > > On 09/01/18 16:56, Ben Pfaff wrote: > >> Sure, I was just concerned was it fixing a compilation issue or such > for you. I've seen it's been applied already and I've given it a quick > validation check without issue so no worries. > > > > I interpreted your Signed-off-by as a

[ovs-dev] [PATCH v3 3/3] xlate: call tnl_neigh_snoop() from terminate_native_tunnel()

Currenlty, OVS snoops any ARP or ND packets in any bridge and populates the tunnel neighbor cache with the retreived data. For instance, when ARP reply originated by a tenant is received in an overlay bridge, the ARP message is snooped and tunnel neighbor cache is filled with tenant data, however

[ovs-dev] [PATCH v3 2/3] tests: modify ARP snoop tests for tunneling with clone

If ARP reply is received on LOCAL port of underlay bridge, then packets pushed to tunnel port in overlay bridge will be dropped in the underlay. This commit modifies this by receiving ARP replies on a different dummy port. This fix is needed for an upcomming correction for ARP snooping.

Re: [ovs-dev] [patch v2 0/3] dpctl conntrack: Add nconns/maxconns commands.

On Mon, Jan 08, 2018 at 03:18:41PM -0800, Darrell Ball wrote: > Commands are added to: > Get the number of conntrack connections. > Get the maximum limit of conntrack connections. > Set the maximum limit of conntrack connections. > > These commands are only supported in the userspace > datapath

Re: [ovs-dev] [PATCH branch-2.8] netdev-dpdk: replace uint8_t with dpdk_port_t

> -Original Message- > From: Markos Chandras [mailto:mchand...@suse.de] > Sent: Tuesday, January 9, 2018 4:23 PM > To: Stokes, Ian ; d...@openvswitch.org > Cc: Kavanagh, Mark B ; Ilya Maximets > > Subject: Re:

Re: [ovs-dev] [PATCH] ovn-northd: Avoid duplicate logical flows in SB db

On Tue, Jan 09, 2018 at 12:12:14PM +0100, Daniel Alvarez Sanchez wrote: > Thanks Ben, Han, Miguel. > > > On Tue, Jan 9, 2018 at 11:59 AM, Miguel Angel Ajo Pelayo < > majop...@redhat.com> wrote: > > > You're probably right, it's probably not worth increasing the complexity > > of ovn-northd when

Re: [ovs-dev] [PATCH] dpif-netdev: Refactor datapath flow cache

Hi Yipeng, On Mon, Jan 8, 2018 at 1:54 PM, Wang, Yipeng1 wrote: > I think this is an interesting idea. > > One caveat is that in this case we use the rules' field to infer the flows' > field. If the rule > does not consider a field within which the flow has high entropy,

Re: [ovs-dev] [PATCH branch-2.8] netdev-dpdk: replace uint8_t with dpdk_port_t

On Tue, Jan 09, 2018 at 09:27:11AM -0800, Ben Pfaff wrote: > On Tue, Jan 09, 2018 at 05:02:11PM +, Markos Chandras wrote: > > Hi Ben, > > > > On 09/01/18 16:56, Ben Pfaff wrote: > > >> Sure, I was just concerned was it fixing a compilation issue or such for > > >> you. I've seen it's been

Re: [ovs-dev] [PATCH] ovn-northd: Avoid duplicate logical flows in SB db

On Tue, Jan 9, 2018 at 3:12 AM, Daniel Alvarez Sanchez wrote: > > Thanks Ben, Han, Miguel. > > > On Tue, Jan 9, 2018 at 11:59 AM, Miguel Angel Ajo Pelayo < > majop...@redhat.com> wrote: > > > You're probably right, it's probably not worth increasing the complexity > > of

Re: [ovs-dev] [PATCH] ofproto-dpif: Remove variable length userdata probe.

> On Jan 9, 2018, at 10:58 AM, Ben Pfaff wrote: > > On Wed, Dec 20, 2017 at 07:42:40PM -0800, Justin Pettit wrote: >> Commit e995e3df57 ("Allow OVS_USERSPACE_ATTR_USERDATA to be variable >> length.") changed userspace action userdata from eight bytes to variable >> length. OVS

Re: [ovs-dev] [PATCH] ofp-errors: Send as much of a message as possible in an error reply.

On Mon, Jan 08, 2018 at 03:23:26PM -0800, Justin Pettit wrote: > > > On Jan 6, 2018, at 10:33 AM, Ben Pfaff wrote: > > > > /* Creates and returns an OpenFlow message of type OFPT_ERROR that conveys > > the > > diff --git a/ofproto/bundles.c b/ofproto/bundles.c > > index

[ovs-dev] [PATCH v3 1/3] ofproto-dpif-sflow: propagate actions within clone

By avoiding Tx recirculation and embedding tnl_push action within clone, the tunnel metadata is not propagated when sflow is read. Unless clone action is handled in the dpif_sflow_read_actions() function as well. This commit resolves this issue. In addition, some sflow data needs to be stored and

Re: [ovs-dev] [patch v2 2/3] dpctl conntrack: Add get number of connections.

On Mon, Jan 08, 2018 at 03:18:43PM -0800, Darrell Ball wrote: > A get command is added for number of conntrack connections. > This command is only supported in the userspace datapath > at this time. > > Signed-off-by: Darrell Ball > Signed-off-by: Antonio Fischetti

[ovs-dev] [PATCH v8 0/3] nsh: add new nsh key ttl and action dec_nsh_ttl

v7-v8 - Ths first patch in v7 series has been merged - Use assignment instead of memcpy - Fix sparse warnings - Keep nsh fields number in meta-flow.inc to be compatible with v 2.8 v6->v7 - Fix comments for v6 from Ben Pfaff - Fix checkpatch warnings - Fix static code analysis

[ovs-dev] [PATCH v8 3/3] nsh: add dec_nsh_ttl action

NSH ttl is a 6-bit field ranged from 0 to 63, it should be decremented by 1 every hop, if it is 0 or it is so after decremented, the packet should be dropped and a packet-in message is sent to main controller. Signed-off-by: Yi Yang --- include/openvswitch/ofp-actions.h |

Re: [ovs-dev] [PATCH v7 4/4] nsh: add dec_nsh_ttl action

On Tue, Jan 09, 2018 at 08:14:07AM +0800, Ben Pfaff wrote: > On Sat, Jan 06, 2018 at 01:47:54PM +0800, Yi Yang wrote: > > NSH ttl is a 6-bit field ranged from 0 to 63, it should be > > decremented by 1 every hop, if it is 0 or it is so after > > decremented, the packet should be dropped and a

Re: [ovs-dev] [PATCH v2] netdev: Custom statistics.

On 01/09/2018 08:13 AM, Weglicki, MichalX wrote: > > >> -Original Message- >> From: Kevin Traynor [mailto:ktray...@redhat.com] >> Sent: Monday, January 8, 2018 7:08 PM >> To: Weglicki, MichalX ; d...@openvswitch.org >> Subject: Re: [ovs-dev] [PATCH v2] netdev:

[ovs-dev] [PATCH v8 1/3] nsh: add new flow key 'ttl'

IETF NSH draft added a new filed ttl in NSH header, this patch is to add new nsh key 'ttl' for it. Signed-off-by: Yi Yang --- datapath/linux/compat/include/linux/openvswitch.h | 2 +- include/openvswitch/flow.h| 6 +-

[ovs-dev] [PATCH v8 2/3] nsh: fix nested mask for OVS_KEY_ATTR_NSH

NSH kernel implementation used nested mask for OVS_KEY_ATTR_NSH, so NSH userspace must adapt to it, OVS hasn't used nested mask for any key attribute so far, OVS_KEY_ATTR_NSH is the first use case. Signed-off-by: Yi Yang --- lib/odp-execute.c | 56 +--

Re: [ovs-dev] [PATCH v7 2/4] nsh: add new flow key 'ttl'

On Tue, Jan 09, 2018 at 08:11:15AM +0800, Ben Pfaff wrote: > On Sat, Jan 06, 2018 at 01:47:52PM +0800, Yi Yang wrote: > > IETF NSH draft added a new filed ttl in NSH header, this patch > > is to add new nsh key 'ttl' for it. > > > > Signed-off-by: Yi Yang > > Thanks for v7!

[ovs-dev] [RFC PATCH v1 1/1] netdev-dpdk: Fix requested MTU size validation.

This commit replaces MTU_TO_FRAME_LEN(mtu) with MTU_TO_MAX_FRAME_LEN(mtu) when validating if an MTU will exceed NETDEV_DPDK_MAX_PKT_LEN in netdev_dpdk_set_mtu(). When setting an MTU we first check if the requested MTU frame size will exceed the maximum packet frame size supported in

Re: [ovs-dev] [no-slow 2/6] ofproto-dpif: Reorganize upcall handling.

On 1/9/2018 1:33 PM, Justin Pettit wrote: On Jan 5, 2018, at 11:20 AM, Gregory Rose wrote: That didn't seem to help. The cookie->header.type is still equal to type USER_ACTION_COOKIE_UNSPEC in the classify_upcall() function and that causes this message:

Re: [ovs-dev] [no-slow 2/6] ofproto-dpif: Reorganize upcall handling.

> On Jan 5, 2018, at 11:20 AM, Gregory Rose wrote: > > That didn't seem to help. The cookie->header.type is still equal to type > USER_ACTION_COOKIE_UNSPEC > in the classify_upcall() function and that causes this message: > >

Re: [ovs-dev] [RFC PATCH v1 1/1] netdev-dpdk: Fix requested MTU size validation.

> -Original Message- > From: Stokes, Ian > Sent: Tuesday, January 9, 2018 10:54 PM > To: d...@openvswitch.org > Cc: Stokes, Ian ; Kavanagh, Mark B > > Subject: [RFC PATCH v1 1/1] netdev-dpdk: Fix requested MTU size > validation. > > This

[ovs-dev] [patch v4 1/4] conntrack: Fix alg expectation cleanup.

Presently, alg expectations are removed by being time expired. This was intended to happen before the control connections and was intended to minimize the extra work involved for tracking and removing the expectations. This is not the best option since it should be possible to remove expectations

[ovs-dev] [patch v4 2/4] conntrack: Add additional alg support.

In order to support more algs with different requirements, expectation handling is allowed to handle more cases, such as a wildcard source ip as in the case of SIP. NAT can also be skipped in some alg cases. Expectation_create() was otherwise simplified in the process. Some renaming was done to

[ovs-dev] [patch v4 4/4] conntrack: Reorder sanity checks in extract_l3_ipvx().

The functions extract_l3_ipv4 and extract_l3_ipv6 check for unsupported ip fragments and return early. The checks were after an assignment that would not be needed when early return happens. This is slightly inefficient, but mostly reads poorly. Hence, reorder the ip fragment checks before the

[ovs-dev] [patch v4 3/4] conntrack: Some style improvements.

Fix up some instances where variable declarations were not close enough to their use, as these were missed before. This is the preferred art in OVS code and flagged heavily in code reviews. This is highly desirable due to code clarity reasons. There are also some cases where newlines were not

Re: [ovs-dev] [PATCH v2] openvswitch: Trim off padding before L3+ netfilter processing

On Mon, Jan 8, 2018 at 7:02 PM, Ed Swierk wrote: > On 1/6/18 10:57, Pravin Shelar wrote: >> On Fri, Jan 5, 2018 at 10:59 PM, Ed Swierk >> wrote: >>> >>> >>> On Jan 5, 2018 22:17, "Pravin Shelar" wrote: >>> >>> On Fri, Jan

Re: [ovs-dev] [PATCH] OVN pacemaker: Fix issues when started as pacemaker container bundles

On Mon, Jan 8, 2018 at 2:35 AM, wrote: > From: Numan Siddique > > When OVN dbs are created as a pacemaker container bundle resource with > meta attribute "container-attribute-target=host" defined, the OVN OCF script > is not working properly. It should

[ovs-dev] No puede perderse este seminario

Un último recurso para la recuperación de la cartera morosa Cobranza judicial y extrajudicial 25 de enero- CP. y MAN. Fernando García Zárate - 9am-6pm En el proceso de cobranza extrajudicial, el propósito es llegar a un acuerdo sin la necesidad de ingresar a un proceso de cobranza judicial.

Re: [ovs-dev] [PATCH] dpif-netdev: Refactor datapath flow cache

>-Original Message- >> I think this is an interesting idea. >> >> One caveat is that in this case we use the rules' field to infer the flows' >> field. If the rule >> does not consider a field within which the flow has high entropy, it still >> does not help. >> Or if the rule considers

[ovs-dev] [PATCH v3] netdev-dpdk: fix port addition for ports sharing same PCI id

Some NICs have only one PCI address associated with multiple ports. This patch extends the dpdk-devargs option's format to cater for such devices. To achieve that, this patch uses a new syntax that will be adapted and implemented in future DPDK release (likely, v18.05):

Re: [ovs-dev] [ovs-dev, v5, 1/3] dpif-netdev: Refactor PMD performance into dpif-netdev-perf

Hi All, I know a v6 is under preparation so I just wanted to give some initial thoughts early before I review further. /Billy. > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Ilya Maximets > Sent: Tuesday, January 9,

Re: [ovs-dev] [ovs-dev, v2] netdev-dpdk: fix port addition for ports sharing same PCI id

This is not a full review, just s suggestion. See inline. Best regards, Ilya Maximets. On 09.01.2018 12:54, Yuanhan Liu wrote: > Some NICs have only one PCI address associated with multiple ports. This > patch extends the dpdk-devargs option's format to cater for such devices. > > To achieve

Re: [ovs-dev] [RFC PATCH 0/8] dpif-netdev: Refactor cycle count and rebased patches

> Hello everyone. I just returned from the holidays. > Thanks for working on this. Find my replies inline. > > Best regards, Ilya Maximets. > > On 08.01.2018 20:58, Kevin Traynor wrote: > > On 01/08/2018 05:31 PM, Stokes, Ian wrote: > >>> > >>> Hi Ian, > >>> > -Original Message- >

Re: [ovs-dev] [PATCH] ovn-northd: Avoid duplicate logical flows in SB db

Thanks Ben, Han, Miguel. On Tue, Jan 9, 2018 at 11:59 AM, Miguel Angel Ajo Pelayo < majop...@redhat.com> wrote: > You're probably right, it's probably not worth increasing the complexity > of ovn-northd when we can check this in the low level, and suppress > the final OpenFlow duplicates, the

Re: [ovs-dev] [ovs-dev, v5, 3/3] dpif-netdev: Detection and logging of suspicious PMD iterations

Comments inline. On 04.01.2018 15:07, Jan Scheurich wrote: > This patch enhances dpif-netdev-perf to detect iterations with > suspicious statistics according to the following criteria: > > - iteration lasts longer than US_THR microseconds (default 250). > This can be used to capture events

[ovs-dev] [PATCH v2] netdev-dpdk: fix port addition for ports sharing same PCI id

Some NICs have only one PCI address associated with multiple ports. This patch extends the dpdk-devargs option's format to cater for such devices. To achieve that, this patch uses a new syntax that will be adapted and implemented in future DPDK release (likely, v18.05):

Re: [ovs-dev] [ovs-dev, v5, 2/3] dpif-netdev: Detailed performance stats for PMDs

+Kevin, +Ian On 09.01.2018 11:53, Ilya Maximets wrote: Comments inline. On 04.01.2018 15:07, Jan Scheurich wrote:> This patch instruments the dpif-netdev datapath to record detailed > statistics of what is happening in every iteration of a PMD thread. > > The collection of detailed statistics

[ovs-dev] [PATCH v4] netdev: Custom statistics.

- New get_custom_stats interface function is added to netdev. It allows particular netdev implementation to expose custom counters in dictionary format (counter name/counter value). - New statistics are retrieved using experimenter code and are printed as a result to ofctl dump-ports. - New

Re: [ovs-dev] [ovs-dev, v5, 2/3] dpif-netdev: Detailed performance stats for PMDs

On 09.01.2018 12:00, Ilya Maximets wrote: > +Kevin, +Ian > > On 09.01.2018 11:53, Ilya Maximets wrote: > Comments inline. > > On 04.01.2018 15:07, Jan Scheurich wrote:> This patch instruments the > dpif-netdev datapath to record detailed >> statistics of what is happening in every iteration of

Re: [ovs-dev] [PATCH v2] netdev: Custom statistics.

> -Original Message- > From: Kevin Traynor [mailto:ktray...@redhat.com] > Sent: Monday, January 8, 2018 7:08 PM > To: Weglicki, MichalX ; d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH v2] netdev: Custom statistics. > > On 12/19/2017 03:00 PM, Kevin

Re: [ovs-dev] [ovs-dev, v5, 1/3] dpif-netdev: Refactor PMD performance into dpif-netdev-perf

I'm a bit lost with all the data structures in lib/dpif-netdev-perf.h. It's too complex, especially with other patches applied. And no comments there. Can we simplify? I didn't review this part. Comments inline. Best regards, Ilya Maximets. On 04.01.2018 15:07, Jan Scheurich wrote: > Add module

Re: [ovs-dev] [ovs-dev, v5, 2/3] dpif-netdev: Detailed performance stats for PMDs

Comments inline. On 04.01.2018 15:07, Jan Scheurich wrote: > This patch instruments the dpif-netdev datapath to record detailed > statistics of what is happening in every iteration of a PMD thread. > > The collection of detailed statistics can be controlled by a new > configuration parameter

Re: [ovs-dev] [RFC PATCH 6/8] dpif-netdev: Refactor cycle counting

> > I have prepared a slightly more advanced version that allows arbitrary > > nesting of cycles measurements where the nested measurements > are excluded from the outer measurement: Here's the outline. I am including > this in the next version of my umbrella series. This version > isn't tested

Re: [ovs-dev] [RFC PATCH 0/8] dpif-netdev: Refactor cycle count and rebased patches

> >>> My suggestion would be to start with the least controversial refactoring > >>> first so that we do not introduce complex things in one patch > >> that we then throw out in the next one again. By that let's try to make > >> the actual feature patches as small and independent as possible. >

Re: [ovs-dev] [RFC PATCH 0/8] dpif-netdev: Refactor cycle count and rebased patches

> -Original Message- > From: Ilya Maximets [mailto:i.maxim...@samsung.com] > Sent: Tuesday, 09 January, 2018 14:11 > To: Jan Scheurich ; Stokes, Ian > ; Kevin Traynor > Cc: d...@openvswitch.org; O Mahony, Billy

Re: [ovs-dev] [RFC PATCH 6/8] dpif-netdev: Refactor cycle counting

On 09.01.2018 03:51, Jan Scheurich wrote: > @@ -3429,16 +3381,17 @@ dp_netdev_process_rxq_port(struct dp_netdev_pmd_thread *pmd, struct pmd_perf_stats *s = >perf_stats; struct dp_packet_batch batch; int error; -int batch_cnt = 0, output_cnt = 0;

[ovs-dev] [PATCH] ovn-controller: Change duplicate flows trace from INFO to DBG

When ovn-controller detects that a flow is duplicated, it will print an INFO trace. Even though it's rate limited, this patch is changing the trace level back to DEBUG to reduce noise. Signed-off-by: Daniel Alvarez --- In our effort to ensure consistency across objects in

Re: [ovs-dev] [RFC PATCH 0/8] dpif-netdev: Refactor cycle count and rebased patches

On 09.01.2018 15:42, Jan Scheurich wrote: > Hi guys, > > Let's have a Skype call to align ourselves and the way forward. > I'm available 14-16 CET and 17-18 CET today. I'll send a tentative invite. > Please reply. Unfortunately, I'll not be able to attend today. It's already the end of my

Re: [ovs-dev] [RFC PATCH 0/8] dpif-netdev: Refactor cycle count and rebased patches

Hi guys, Let's have a Skype call to align ourselves and the way forward. I'm available 14-16 CET and 17-18 CET today. I'll send a tentative invite. Please reply. I realize there are major comments on all three patch sets: - Ilya has shared some architectural concerns on the PMD perf metrics v5

Re: [ovs-dev] [ovs-dev, v2] netdev-dpdk: fix port addition for ports sharing same PCI id

On Tue, Jan 09, 2018 at 02:14:22PM +0300, Ilya Maximets wrote: > > +static dpdk_port_t > > +netdev_dpdk_get_port_by_mac(const char *mac_str) > > +{ > > +int i; > > +struct ether_addr mac; > > +struct ether_addr port_mac; > > + > > +if (netdev_dpdk_str_to_ether(mac_str, ) != 0) { >

[ovs-dev] [PATCH branch-2.8] netdev-dpdk: replace uint8_t with dpdk_port_t

From: Mark Kavanagh netdev_dpdk_detach() declares a 'port_id' variable, of type uint8_t. This variable should instead be of type dpdk_port_t. Fixes: bb37956ac ("netdev-dpdk: Use uint8_t for port_id.") CC: Ilya Maximets Signed-off-by: Mark

Re: [ovs-dev] [ovs-dev, v5, 1/3] dpif-netdev: Refactor PMD performance into dpif-netdev-perf

Hi Ilya, Thanks for your review. Answers below. I will address your comments in the next version. BR, Jan > -Original Message- > From: Ilya Maximets [mailto:i.maxim...@samsung.com] > Sent: Tuesday, 09 January, 2018 09:35 > To: Jan Scheurich ;

[ovs-dev] [PATCH] ovn-sb.xml: Correct statement on use of bit ranges.

Bit range specifiers can be used only with ordinal fields. Signed-off-by: Jakub Sitnicki --- ovn/ovn-sb.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ovn/ovn-sb.xml b/ovn/ovn-sb.xml index ca8cbecdd..abc241ec0 100644 --- a/ovn/ovn-sb.xml +++

Re: [ovs-dev] [PATCH branch-2.8] netdev-dpdk: replace uint8_t with dpdk_port_t

> -Original Message- > From: Markos Chandras [mailto:mchand...@suse.de] > Sent: Tuesday, January 9, 2018 3:55 PM > To: d...@openvswitch.org > Cc: Kavanagh, Mark B ; Ilya Maximets > ; Stokes, Ian ; Markos > Chandras

Re: [ovs-dev] [PATCH branch-2.8] netdev-dpdk: replace uint8_t with dpdk_port_t

On Tue, Jan 09, 2018 at 03:54:45PM +, Markos Chandras wrote: > From: Mark Kavanagh > > netdev_dpdk_detach() declares a 'port_id' variable, of type uint8_t. > This variable should instead be of type dpdk_port_t. > > Fixes: bb37956ac ("netdev-dpdk: Use uint8_t for

Re: [ovs-dev] [PATCH branch-2.8] netdev-dpdk: replace uint8_t with dpdk_port_t

Hi Ian, On 09/01/18 16:16, Stokes, Ian wrote: >> -Original Message- >> From: Markos Chandras [mailto:mchand...@suse.de] >> Sent: Tuesday, January 9, 2018 3:55 PM >> To: d...@openvswitch.org >> Cc: Kavanagh, Mark B ; Ilya Maximets >> ;

Re: [ovs-dev] [PATCH v5 1/3] dpif-netdev: Refactor PMD performance into dpif-netdev-perf

Hi Jan, Thanks these patches are really very useful. I haven't finished trying them out but thought you'd prefer to get initial comments earlier. I'll continue to try to them out and revert with any further other comments later. Regards, Billy. > -Original Message- > From:

Re: [ovs-dev] [PATCH v5 2/3] dpif-netdev: Detailed performance stats for PMDs

Hi Jan, Thanks these patches are really very useful. I haven't finished trying them out but thought you'd prefer to get initial comments earlier. I'll continue to try to them out and revert with any further other comments later. Regards, Billy. > -Original Message- > From:

Re: [ovs-dev] [PATCH v5 3/3] dpif-netdev: Detection and logging of suspicious PMD iterations

Hi Jan, Thanks these patches are really very useful. I haven't finished trying them out but thought you'd prefer to get initial comments earlier. I'll continue to try to them out and revert with any further other comments later. Regards, Billy. > -Original Message- > From:

Re: [ovs-dev] [PATCH] dpif-netdev: Refactor datapath flow cache

Hi, Jan, Please find my reply inlined >-Original Message- >> >> [Wang, Yipeng] In my test, I compared the proposed EMC with current EMC with >> same 16k entries. >> If I turned off THP, the current EMC will cause many TLB misses because of >> its larger entry size, which I profiled with

Re: [ovs-dev] [no-slow 1/6] ofproto-dpif: Add ability to look up an ofproto by UUID.

> On Jan 3, 2018, at 3:31 PM, Ben Pfaff wrote: > > On Tue, Jan 02, 2018 at 10:24:21AM -0800, Justin Pettit wrote: >> >> >>> On Jan 2, 2018, at 8:40 AM, Ben Pfaff wrote: >>> >>> On Thu, Dec 21, 2017 at 02:25:10PM -0800, Justin Pettit wrote: This will have

Re: [ovs-dev] [no-slow 4/6] ofproto: Add 'ofproto_uuid' and 'ofp_in_port' to user action cookie.

> On Jan 2, 2018, at 10:13 AM, Ben Pfaff wrote: > > On Thu, Dec 21, 2017 at 02:25:13PM -0800, Justin Pettit wrote: >> Previously, the ofproto instance and OpenFlow port have been derived >> based on the datapath port number. This change explicitly declares them >> both, which

Re: [ovs-dev] [PATCH] bfd: Send BFD packets with DSCP CS6

Gentle reminder to review this patch. Regards, Pradeep -Original Message- From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-boun...@openvswitch.org] On Behalf Of Venkatesan Pradeep Sent: Monday, December 25, 2017 10:29 PM To: d...@openvswitch.org Subject: [ovs-dev] [PATCH] bfd:

Re: [ovs-dev] [no-slow 6/6] ofproto-dpif: Don't slow-path controller actions with pause.

> On Jan 2, 2018, at 10:39 AM, Ben Pfaff wrote: > > On Thu, Dec 21, 2017 at 02:25:15PM -0800, Justin Pettit wrote: >> A previous patch removed slow-pathing for controller actions with the >> exception of ones that specified "pause". This commit removes that >> restriction so that

Re: [ovs-dev] [no-slow 5/6] ofproto-dpif: Don't slow-path controller actions.

> On Jan 2, 2018, at 10:36 AM, Ben Pfaff wrote: > > On Thu, Dec 21, 2017 at 02:25:14PM -0800, Justin Pettit wrote: >> Controller actions have become more commonly used for purposes other >> than just making forwarding decisions (e.g., packet logging). A packet >> that needs to be

Re: [ovs-dev] [no-slow 2/6] ofproto-dpif: Reorganize upcall handling.

> On Jan 3, 2018, at 3:57 PM, Ben Pfaff wrote: > > On Thu, Dec 21, 2017 at 02:25:11PM -0800, Justin Pettit wrote: >>- This reduces the number of times upcall cookies are processed. >>- It separate true miss calls from slow-path actions. >> >> The reorganization will also