On Sat, Mar 16, 2019 at 2:41 AM Ben Pfaff wrote:
> On Tue, Mar 12, 2019 at 10:00:02PM +0530, nusid...@redhat.com wrote:
> > From: Numan Siddique
> >
> > This series attempts to add a new thread in pinctrl module. This thread
> > will handle the packet-ins.
> >
> > v1 -> v2
> > --
> > *
From: Numan Siddique
Prior to this patch, ovn-controller was single threaded and everytime the
poll_block() at the end of the main while() loop wakes up, it processes
the whole SB DB and translates the logical flows to OF flows.
There are few issues with this -
* For every packet-in
From: Numan Siddique
In pinctrl.c, many functions use 'swconn' variable which is declared as
global static. This patch passes 'swconn' as a variable to functions.
This will help in an upcoming patch which makes processing
packet-ins in a separate pthread.
Suggested-by: Mark Michelson
Acked-by:
From: Numan Siddique
This series attempts to add a new thread in pinctrl module. This thread
will handle the packet-ins.
v2 -> v3
-
* Fixed the clang errors.
v1 -> v2
--
* Added a new patch p1 to the series suggessted by Mark.
* Addressed the review comments from Han and Mark.
On Sat, Mar 16, 2019 at 09:56:49AM +0530, Numan Siddique wrote:
> On Sat, Mar 16, 2019, 2:28 AM Ben Pfaff wrote:
>
> > On Sat, Mar 16, 2019 at 12:28:31AM +0530, Numan Siddique wrote:
> > > On my Fedora 29 when ever I run all the ovs tests with "-j5", I see few
> > > core dumps generated for
On Sat, Mar 16, 2019, 2:28 AM Ben Pfaff wrote:
> On Sat, Mar 16, 2019 at 12:28:31AM +0530, Numan Siddique wrote:
> > On my Fedora 29 when ever I run all the ovs tests with "-j5", I see few
> > core dumps generated for ovsdb-server and python2.
>
> There are a couple of tests that intentionally
Bleep bloop. Greetings Yifeng Sun, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
git-am:
fatal: patch fragment without header at line 8: @@ -2849,8 +2849,8 @@
ADD_VETH(p0, at_ns0, br0,
This patch introduces changes needed by OVS to support latest
Linux kernels (4.19.x and 4.20.x). Recent kernels changed many
APIs used by OVS. One major change is that struct nf_conntrack_l3proto
became unvisible outside of kernel, so the needed get_l4proto
function is added in file
These fragment-related tests are failing on later kernels (4.19.x)
because kernel quietly drops any packet fragment that is not the last
but has a size smaller than IPV6_MIN_MTU. This patch fixes
them by increasing their sizes to IPV6_MIN_MTU.
Signed-off-by: Yifeng Sun
---
Background:
[1] https://mail.openvswitch.org/pipermail/ovs-dev/2018-October/353066.html
[2]
https://docs.google.com/document/d/1uoQH478wM1OZ16HrxzbOUvk5LvFnfNEWbkPT6Zmm9OU/edit?usp=sharing
This Series:
Layer 2, Layer 3 E-W and Layer 3 N-S (NO NAT) changes for vlan
backed distributed logical
Background:
[1] https://mail.openvswitch.org/pipermail/ovs-dev/2018-October/353066.html
[2]
https://docs.google.com/document/d/1uoQH478wM1OZ16HrxzbOUvk5LvFnfNEWbkPT6Zmm9OU/edit?usp=sharing
This Series:
Layer 2, Layer 3 E-W and Layer 3 N-S (NO NAT) changes for vlan
backed distributed logical
Background:
[1] https://mail.openvswitch.org/pipermail/ovs-dev/2018-October/353066.html
[2]
https://docs.google.com/document/d/1uoQH478wM1OZ16HrxzbOUvk5LvFnfNEWbkPT6Zmm9OU/edit?usp=sharing
This Series:
Layer 2, Layer 3 E-W and Layer 3 N-S (NO NAT) changes for vlan
backed distributed logical
Background:
[1] https://mail.openvswitch.org/pipermail/ovs-dev/2018-October/353066.html
[2]
https://docs.google.com/document/d/1uoQH478wM1OZ16HrxzbOUvk5LvFnfNEWbkPT6Zmm9OU/edit?usp=sharing
This Series:
Layer 2, Layer 3 E-W and Layer 3 N-S (NO NAT) changes for vlan
backed distributed logical
This series is about enhancing the logical router functionality in OVN to work
with vlan backed logical switches.
Intial proposal was discused here:
[1] https://mail.openvswitch.org/pipermail/ovs-dev/2018-October/353066.html
[2]
On Fri, Mar 15, 2019 at 4:31 PM Ben Pfaff wrote:
> On Fri, Mar 15, 2019 at 04:17:34PM -0700, Darrell Ball wrote:
> > On Fri, Mar 15, 2019 at 3:56 PM Ben Pfaff wrote:
> >
> > > On Fri, Mar 15, 2019 at 03:01:18PM -0700, Darrell Ball wrote:
> > > > Reference lists are not fully protected during
On Fri, Mar 15, 2019 at 04:17:34PM -0700, Darrell Ball wrote:
> On Fri, Mar 15, 2019 at 3:56 PM Ben Pfaff wrote:
>
> > On Fri, Mar 15, 2019 at 03:01:18PM -0700, Darrell Ball wrote:
> > > Reference lists are not fully protected during cleanup of
> > > NAT connections where the bucket lock is
It didn't seem like this is different from the original version, so I just
cherry-picked that back to branch-2.9.
Let me know if I missed something.
--Justin
> On Mar 11, 2019, at 11:35 AM, Mark Michelson wrote:
>
> From: Venkata Anil
>
> This is a backport to the 2.9 branch of the
On Fri, Mar 15, 2019 at 3:37 PM Han Zhou wrote:
>
> On Fri, Mar 15, 2019 at 3:30 PM Ben Pfaff wrote:
> >
> > On Thu, Mar 14, 2019 at 10:13:56AM -0700, Han Zhou wrote:
> > > From: Han Zhou
> > >
> > > When update is requested from follower, the leader sends AppendRequest
> > > to all followers
On Tue, Mar 12, 2019 at 08:26:43AM -0700, Toms Atteka wrote:
> If enough large input is given ofpact_finish will fail.
> Check was added and error message returned.
>
> Basic manual testing performed.
>
> Reported-by:
> https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=12972
> Signed-off-by:
From: Han Zhou
When update is requested from follower, the leader sends AppendRequest
to all followers and wait until AppendReply received from majority, and
then it will update commit index - the new entry is regarded as committed
in raft log. However, this commit will not be notified to
On Fri, Mar 15, 2019 at 3:56 PM Ben Pfaff wrote:
> On Fri, Mar 15, 2019 at 03:01:18PM -0700, Darrell Ball wrote:
> > Reference lists are not fully protected during cleanup of
> > NAT connections where the bucket lock is transiently not held during
> > list traversal. This can lead to
On Tue, Mar 12, 2019 at 11:01:03AM -0700, Yi-Hung Wei wrote:
> On Tue, Mar 12, 2019 at 5:53 AM Ilya Maximets wrote:
> >
> > This makes it look like other options.
> >
> > Signed-off-by: Ilya Maximets
> > ---
> Thanks for improving this manpage.
>
> Acked-by: Yi-Hung Wei
Thanks, applied to
'usable_protocols' is now getting set to OFPUTIL_P_OF10_ANY on return from
'parse_flow_monitor_request' function. The calling function now checks for the
value in this variable against the 'allowed_protocols' variable.
Also a check is added for a match field which is not supported in OpenFlow 1.0
On Wed, Mar 13, 2019 at 11:31:05AM -0700, Ashish Varma wrote:
> The removal of support for OpenFlow 1.6 (draft) resulted in the removal of
> "OFPUTIL_P_OF16_OXM 1 << 9". OFPUTIL_P_ANY which represets all protocols will
> now have only 9 valid bits.
>
> Signed-off-by: Ashish Varma
Thanks,
On Fri, Mar 15, 2019 at 03:01:20PM -0700, Darrell Ball wrote:
> There are a few cases where structure copy can be replaced by
> memcpy(), for possible portability benefit. This is because
> the structures involved have padding and elements of the
> structure are used to generate hashes.
>
>
Bleep bloop. Greetings Darrell Ball, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
git-am:
Failed to merge in the changes.
Patch failed at 0001 conntrack: Fix race for NAT cleanup.
The copy
On Fri, Mar 15, 2019 at 03:01:19PM -0700, Darrell Ball wrote:
> When freeing 'UNNAT conns', lookup only 'UNNAT conns' to
> protect against possible address overlap with 'default
> conns' during a DOS attempt. This is very unlikely, but
> protection is simple.
>
> Fixes: 286de2729955 ("dpdk:
On Fri, Mar 15, 2019 at 03:01:18PM -0700, Darrell Ball wrote:
> Reference lists are not fully protected during cleanup of
> NAT connections where the bucket lock is transiently not held during
> list traversal. This can lead to referencing freed memory during
> cleaning from multiple contexts.
On Fri, Mar 15, 2019 at 3:30 PM Ben Pfaff wrote:
>
> On Thu, Mar 14, 2019 at 10:13:56AM -0700, Han Zhou wrote:
> > From: Han Zhou
> >
> > When update is requested from follower, the leader sends AppendRequest
> > to all followers and wait until AppendReply received from majority, and
> > then it
On Wed, Mar 13, 2019 at 04:03:46PM +0200, Alin Gabriel Serdean wrote:
> Using python `sys.exit(-1)` on Windows produces mixed results.
> Let's take the following results from different shells:
> CMD
> >python -c "import sys; sys.exit(-1)" & echo %errorlevel%
> 1
> MSYS
> $ python -c "import sys;
On Thu, Mar 14, 2019 at 10:13:56AM -0700, Han Zhou wrote:
> From: Han Zhou
>
> When update is requested from follower, the leader sends AppendRequest
> to all followers and wait until AppendReply received from majority, and
> then it will update commit index - the new entry is regarded as
There are a few cases where structure copy can be replaced by
memcpy(), for possible portability benefit. This is because
the structures involved have padding and elements of the
structure are used to generate hashes.
Signed-off-by: Darrell Ball
---
Backport to 2.8.
v6: No change to this
Reference lists are not fully protected during cleanup of
NAT connections where the bucket lock is transiently not held during
list traversal. This can lead to referencing freed memory during
cleaning from multiple contexts. Fix this by protecting with
the existing 'cleanup' mutex in the missed
When freeing 'UNNAT conns', lookup only 'UNNAT conns' to
protect against possible address overlap with 'default
conns' during a DOS attempt. This is very unlikely, but
protection is simple.
Fixes: 286de2729955 ("dpdk: Userspace Datapath: Introduce NAT Support.")
Signed-off-by: Darrell Ball
---
On Tue, Mar 12, 2019 at 10:00:02PM +0530, nusid...@redhat.com wrote:
> From: Numan Siddique
>
> This series attempts to add a new thread in pinctrl module. This thread
> will handle the packet-ins.
>
> v1 -> v2
> --
> * Added a new patch p1 to the series suggessted by Mark.
> *
On Thu, Mar 14, 2019 at 09:48:59AM +0100, Simon Horman wrote:
> On Wed, Mar 13, 2019 at 12:06:51PM +0100, Simon Horman wrote:
> > On Tue, Feb 26, 2019 at 04:00:02PM +0300, Ilya Maximets wrote:
> > > First patch is a bugfix backport. Second one fixes the testsuite
> > > jobs on TravisCI failure due
On Fri, Mar 15, 2019 at 05:06:01PM +0300, Ilya Maximets wrote:
> 'dpctl/help' command is not registered and could not be called.
> However, 'dpctl/list-commands' prints it as available.
>
> CC: Ben Pfaff
> Fixes: 337c45285445 ("dpctl: Fix jump through wild pointer in "dpctl/help".")
>
Doesn't seem particularly useful to me, I suggest that we remove it
entirely instead.
On Fri, Mar 15, 2019 at 06:21:40PM +0300, Ilya Maximets wrote:
> s/dubug/debug/
>
> On 15.03.2019 17:06, Ilya Maximets wrote:
> > This information is useful only for parser debugging.
> > No need to print it
On Sat, Mar 16, 2019 at 12:28:31AM +0530, Numan Siddique wrote:
> On my Fedora 29 when ever I run all the ovs tests with "-j5", I see few
> core dumps generated for ovsdb-server and python2.
There are a couple of tests that intentionally do "kill -SEGV", to test
that things work properly in that
Hi,
On my Fedora 29 when ever I run all the ovs tests with "-j5", I see few
core dumps generated for ovsdb-server and python2.
Here's the back trace
[root@nusiddiq ovsdb]# gdb ./ovsdb-server
/opt/core_dumps/core.ovsdb-server.24604
GNU gdb (GDB) Fedora 8.2-6.fc29
...
...
Core was
Cursos TOP - Webinar Interactivo – Jueves 04 de Abril
Redacción de documentos ejecutivos
Este webinar se desarrolla para atender las necesidades comunicativas de los
profesionales. Funciona como una guía de
redacción, composición y ortografía necesarias para la adecuada producción de
textos
s/dubug/debug/
On 15.03.2019 17:06, Ilya Maximets wrote:
> This information is useful only for parser debugging.
> No need to print it each time to the logs.
>
> CC: Ben Pfaff
> Fixes: d1fd1ea91242 ("ovs-dpctl: New --names option to use port names in flow
> dumps.")
> Signed-off-by: Ilya
contrer l'arret
#outlook a { padding:0; }
.ReadMsgBody { width:100%; }
.ExternalClass { width:100%; }
.ExternalClass * { line-height:100%; }
body {
This information is useful only for parser debugging.
No need to print it each time to the logs.
CC: Ben Pfaff
Fixes: d1fd1ea91242 ("ovs-dpctl: New --names option to use port names in flow
dumps.")
Signed-off-by: Ilya Maximets
---
lib/dpctl.c | 4 ++--
1 file changed, 2 insertions(+), 2
'dpctl/help' command is not registered and could not be called.
However, 'dpctl/list-commands' prints it as available.
CC: Ben Pfaff
Fixes: 337c45285445 ("dpctl: Fix jump through wild pointer in "dpctl/help".")
Signed-off-by: Ilya Maximets
---
lib/dpctl.c | 4
1 file changed, 4
Ilya Maximets (2):
dpctl: Stop showing the dpctl/help command.
dpctl: Change log level for dubug information.
lib/dpctl.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
--
2.17.1
___
dev mailing list
d...@openvswitch.org
On Fri, Mar 15, 2019 at 12:28:03PM +0300, Ilya Maximets wrote:
> On 15.03.2019 11:50, Simon Horman wrote:
> > On Thu, Mar 14, 2019 at 01:14:05PM +0300, Ilya Maximets wrote:
> >> On 14.03.2019 11:48, Simon Horman wrote:
> >>> On Wed, Mar 13, 2019 at 12:06:51PM +0100, Simon Horman wrote:
> On
On 15.03.2019 11:50, Simon Horman wrote:
> On Thu, Mar 14, 2019 at 01:14:05PM +0300, Ilya Maximets wrote:
>> On 14.03.2019 11:48, Simon Horman wrote:
>>> On Wed, Mar 13, 2019 at 12:06:51PM +0100, Simon Horman wrote:
On Tue, Feb 26, 2019 at 04:00:02PM +0300, Ilya Maximets wrote:
> First
On Thu, Mar 14, 2019 at 01:14:05PM +0300, Ilya Maximets wrote:
> On 14.03.2019 11:48, Simon Horman wrote:
> > On Wed, Mar 13, 2019 at 12:06:51PM +0100, Simon Horman wrote:
> >> On Tue, Feb 26, 2019 at 04:00:02PM +0300, Ilya Maximets wrote:
> >>> First patch is a bugfix backport. Second one fixes
nla_nest_start may fail and thus deserves a check.
The fix returns -EMSGSIZE when it fails.
Signed-off-by: Kangjie Lu
---
net/openvswitch/datapath.c | 8
1 file changed, 8 insertions(+)
diff --git a/net/openvswitch/datapath.c b/net/openvswitch/datapath.c
index
50 matches
Mail list logo
