[ovs-dev] DRINGENDE SPENDE

2019-11-01 Thread Marie Holmes Charity
Sie wurden nach dem Zufallsprinzip ausgewählt, um eine Spende von Marie Holmes Charity zu erhalten. Kontaktieren Sie sie für weitere Informationen: E-Mail marieholmescharity...@gmail.com -- This email has been checked for viruses by Avast antivirus software. https://www.avast.com/antivirus

Re: [ovs-dev] [PATCH 0/2] travis: Unskip tests.

2019-11-01 Thread Ilya Maximets
On 01.11.2019 23:42, Ben Pfaff wrote: On Fri, Nov 01, 2019 at 11:38:33PM +0100, Ilya Maximets wrote: Ilya Maximets (2): travis: Workaround skipping of IPv6 tests. travis: Fix skipping of python SSL tests. Nice! Acked-by: Ben Pfaff Thanks! Applied to master. Best regards, Ilya

Re: [ovs-dev] [PATCH net-next v6 01/10] net: openvswitch: add flow-mask cache for performance

2019-11-01 Thread William Tu
On Fri, Nov 1, 2019 at 7:25 AM wrote: > > From: Tonghao Zhang > > The idea of this optimization comes from a patch which > is committed in 2014, openvswitch community. The author > is Pravin B Shelar. In order to get high performance, I > implement it again. Later patches will use it. > > Pravin

[ovs-dev] [PATCHv2] tests: Skip tests using tcp nc under check-afxdp.

2019-11-01 Thread William Tu
AF_XDP veth does not support TCP with namespaces. This patch skips two cases that use it. 118: conntrack - floating IP 119: conntrack - negative test for recirculation optimization Signed-off-by: William Tu --- v2: - skip only 118 and 119. v1: - Tested-at:

Re: [ovs-dev] [PATCH 0/2] travis: Unskip tests.

2019-11-01 Thread Ben Pfaff
On Fri, Nov 01, 2019 at 11:38:33PM +0100, Ilya Maximets wrote: > Ilya Maximets (2): > travis: Workaround skipping of IPv6 tests. > travis: Fix skipping of python SSL tests. Nice! Acked-by: Ben Pfaff ___ dev mailing list d...@openvswitch.org

[ovs-dev] [PATCH 2/2] travis: Fix skipping of python SSL tests.

2019-11-01 Thread Ilya Maximets
After this change we'll have only one windows related skipped test in default build. Signed-off-by: Ilya Maximets --- .travis.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.travis.yml b/.travis.yml index 84bdb4ba4..482efd2d1 100644 --- a/.travis.yml +++ b/.travis.yml @@ -21,6 +21,7 @@

[ovs-dev] [PATCH 0/2] travis: Unskip tests.

2019-11-01 Thread Ilya Maximets
Ilya Maximets (2): travis: Workaround skipping of IPv6 tests. travis: Fix skipping of python SSL tests. .travis.yml | 1 + .travis/linux-prepare.sh | 5 + 2 files changed, 6 insertions(+) -- 2.17.1 ___ dev mailing list

[ovs-dev] [PATCH 1/2] travis: Workaround skipping of IPv6 tests.

2019-11-01 Thread Ilya Maximets
IPv6 support disabled in TravisCI images but supported by kernel. So, we could enable it in order to not skip unit tests. We are not trying to communicate over network with IPv6, so this should not make any harm. Related issue: https://github.com/travis-ci/travis-ci/issues/8891 Signed-off-by:

Re: [ovs-dev] [PATCH] tests: Skip testcases using nc under check-afxdp.

2019-11-01 Thread William Tu
On Fri, Nov 1, 2019 at 3:10 PM Ilya Maximets wrote: > > > > On 01.11.2019 22:51, William Tu wrote: > > AF_XDP veth does not support TCP with namespaces. This patch skips them. > > > > Signed-off-by: William Tu > > --- > > v1: > >- Tested-at:

Re: [ovs-dev] [PATCH] tests: Skip testcases using nc under check-afxdp.

2019-11-01 Thread Ilya Maximets
On 01.11.2019 22:51, William Tu wrote: AF_XDP veth does not support TCP with namespaces. This patch skips them. Signed-off-by: William Tu --- v1: - Tested-at: https://travis-ci.org/williamtu/ovs-travis/builds/606194550 - make check-afxdp all pass on my machine, but cirrus, it is still

[ovs-dev] [PATCH] tests: Skip testcases using nc under check-afxdp.

2019-11-01 Thread William Tu
AF_XDP veth does not support TCP with namespaces. This patch skips them. Signed-off-by: William Tu --- v1: - Tested-at: https://travis-ci.org/williamtu/ovs-travis/builds/606194550 - make check-afxdp all pass on my machine, but cirrus, it is still unstable, observe 1 failed at:

Re: [ovs-dev] [PATCH v2] ofp-monitor: Fixed the usage of 'usable_protocols' variable in 'parse_flow_monitor_request' function.

2019-11-01 Thread Ben Pfaff
On Tue, Jul 23, 2019 at 01:02:10PM -0700, Ashish Varma wrote: > 'usable_protocols' is now getting set to OFPUTIL_P_OF10_ANY on return from > 'parse_flow_monitor_request' function. The calling function now checks for the > value in this variable against the 'allowed_protocols' variable. > Also a

[ovs-dev] [PATCH] ofproto: Fix crash on PACKET_OUT due to recursive locking after upcall.

2019-11-01 Thread Ilya Maximets
Handling of OpenFlow PACKET_OUT implies pushing the packet through the datapath and packet processing inside the datapath could trigger an upcall. In case of system datapath, 'dpif_execute()' sends packet to the kernel module and returns. If any, upcall will be triggered inside the kernel and

Re: [ovs-dev] [PATCH v1] NEWS: Add stateless NAT support

2019-11-01 Thread Mark Michelson
Thanks, I applied this to master. On 11/1/19 4:30 PM, Ankur Sharma wrote: Signed-off-by: Ankur Sharma --- NEWS | 1 + 1 file changed, 1 insertion(+) diff --git a/NEWS b/NEWS index c6c2a3a..0ad9677 100644 --- a/NEWS +++ b/NEWS @@ -3,6 +3,7 @@ Post-OVS-v2.12.0 - OVN was split out from

Re: [ovs-dev] [PATCH v1] NEWS: Add stateless NAT support

2019-11-01 Thread 0-day Robot
Bleep bloop. Greetings Ankur Sharma, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: fatal: sha1 information is lacking or useless (NEWS). Repository lacks necessary blobs to fall

Re: [ovs-dev] [PATCH ovn] Improve debuggability of OVN to OpenFlow translations.

2019-11-01 Thread Mark Michelson
Great addition, Dumitru! Acked-by: Mark Michelson On 11/1/19 8:05 AM, Dumitru Ceara wrote: Until now, when translating SB database contents to OpenFlow flows, ovn-controller stored (part of) the SB record UUID in the cookie field of the OpenFlow entry only when translating logical flows.

[ovs-dev] Estrategias de fidelización de personal.

2019-11-01 Thread Temario - Acciones preventivas
27 de Noviembre | Horario de 10:00 a 17:00 hrs. | (hora del centro de México) - Rotación Cero - Webinar en Línea Presentaremos los fundamentos para identificar el impacto que la rotación de personal tiene en nuestra empresa así como de las estrategias a aplicar para sobrellevarla. ¿Qué

Re: [ovs-dev] [PATCH v4 0/2] ALLOW Stateless NAT operations

2019-11-01 Thread Ankur Sharma
Hi Numan, Thanks for applying the patches. Sure, I have sent out the NEW entry changes. Just noticed that Acked-by is missing in the commits. Regards, Ankur From: Numan Siddique Sent: Friday, November 1, 2019 9:51 AM To: Ankur Sharma Cc: ovs-dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH

[ovs-dev] [PATCH v1] NEWS: Add stateless NAT support

2019-11-01 Thread Ankur Sharma
Signed-off-by: Ankur Sharma --- NEWS | 1 + 1 file changed, 1 insertion(+) diff --git a/NEWS b/NEWS index c6c2a3a..0ad9677 100644 --- a/NEWS +++ b/NEWS @@ -3,6 +3,7 @@ Post-OVS-v2.12.0 - OVN was split out from the OVS repository and is now released independently. - Added IPv6 NAT

[ovs-dev] [PATCHv3] netdev-afxdp: Enable loading XDP program.

2019-11-01 Thread William Tu
Now netdev-afxdp always forwards all packets to userspace because it is using libbpf's default XDP program, see 'xsk_load_xdp_prog'. There are some cases when users want to keep packets in kernel instead of sending to userspace, for example, management traffic such as SSH should be processed in

Re: [ovs-dev] [PATCH ovn 1/3] ovn-northd: Add support for Load Balancer health check

2019-11-01 Thread Mark Michelson
On 10/31/19 9:43 AM, num...@ovn.org wrote: From: Numan Siddique The present Load balancer feature in OVN provides load balancing functionality to the back end ips without checking if the chosen backend ip is reachable or not. In case a back end service is down and if that IP is chosen, then

Re: [ovs-dev] [PATCH ovn 0/3] Health check feature for Load balancer backends

2019-11-01 Thread Mark Michelson
Hi Numan, I'm curious why this feature is IPv4-only. Based on patch 3, it looks like the way is paved for IPv6 support. I'm not sure why IPv6 isn't part of the initial changeset. Aside from a small nit in patch 1, this looks great! For the series, Acked-by: Mark Michelson On 10/31/19 9:42

Re: [ovs-dev] [PATCH] Revert "ip_gre: Remove even more unused code"

2019-11-01 Thread Gregory Rose
On 11/1/2019 11:04 AM, Simon Horman wrote: On Fri, Nov 01, 2019 at 10:27:09AM -0700, Gregory Rose wrote: On 11/1/2019 9:07 AM, Greg Rose wrote: This reverts commit 42a059e02bf343787951be2824c579e1c9a26e12. Not all the necessary ipgre prefixed code was removed that should have been. Another

Re: [ovs-dev] [PATCH] Revert "ip_gre: Remove even more unused code"

2019-11-01 Thread Simon Horman
On Fri, Nov 01, 2019 at 10:27:09AM -0700, Gregory Rose wrote: > > On 11/1/2019 9:07 AM, Greg Rose wrote: > > This reverts commit 42a059e02bf343787951be2824c579e1c9a26e12. > > > > Not all the necessary ipgre prefixed code was removed that > > should have been. Another patch will follow with the

Re: [ovs-dev] [PATCH] ip_gre: Removed unused ipgre netdev ops

2019-11-01 Thread Simon Horman
On Fri, Nov 01, 2019 at 09:54:40AM -0700, Gregory Rose wrote: > > > On 11/1/2019 9:52 AM, Gregory Rose wrote: > > > >     42a059e02bf3 ("ip_gre: Remove even more unused code") > > > > That one should be fine. > > > > Thanks, > > > > Oh goodness, I meant this one should be fine. > >

Re: [ovs-dev] [PATCH ovn] Improve debuggability of OVN to OpenFlow translations.

2019-11-01 Thread Ben Pfaff
On Fri, Nov 01, 2019 at 01:05:15PM +0100, Dumitru Ceara wrote: > Until now, when translating SB database contents to OpenFlow flows, > ovn-controller stored (part of) the SB record UUID in the cookie field > of the OpenFlow entry only when translating logical flows. > > Extend this behavior to

Re: [ovs-dev] [PATCH v1] ofproto: Fix OVS crash when packets hit Openflow rules with certain combinations of nested actions

2019-11-01 Thread Ben Pfaff
On Fri, Nov 01, 2019 at 02:35:55PM +0100, Ilya Maximets wrote: > CC: ovs-dev > Sorry. > > On 01.11.2019 14:34, Ilya Maximets wrote: > > On 31.10.2019 18:12, Ben Pfaff wrote: > > > On Thu, Sep 05, 2019 at 11:12:26PM +0530, Anil Kumar Koli wrote: > > > > > * We can't get rid of ofproto_mutex in

Re: [ovs-dev] [PATCH v1] ofproto: Fix OVS crash when packets hit Openflow rules with certain combinations of nested actions

2019-11-01 Thread Ben Pfaff
On Fri, Nov 01, 2019 at 02:39:30PM +0100, Ilya Maximets wrote: > On 31.10.2019 18:24, Ben Pfaff wrote: > > For Ilya and others: the email to Anil bounced, so he probably isn't at > > Calsoft Labs any longer. > > Are you sure that it wasn't mine old email address? Oh, you're right. Apparently I

Re: [ovs-dev] connection tracking questions

2019-11-01 Thread Ben Pfaff
On Fri, Nov 01, 2019 at 01:24:24PM -0400, Aaron Conole wrote: > Nicolas Bouliane via dev writes: > > - When I use ofproto/trace and hit flows that use the connection tracking: > > ct(), does an actual lookup is made even though I'm just tracing ? or it's > > just simulated. > > If I remember

Re: [ovs-dev] [PATCH] Revert "ip_gre: Remove even more unused code"

2019-11-01 Thread Gregory Rose
On 11/1/2019 9:07 AM, Greg Rose wrote: This reverts commit 42a059e02bf343787951be2824c579e1c9a26e12. Not all the necessary ipgre prefixed code was removed that should have been. Another patch will follow with the correct removed code. Signed-off-by: Greg Rose --- Maintainers, please apply

Re: [ovs-dev] connection tracking questions

2019-11-01 Thread Aaron Conole
Nicolas Bouliane via dev writes: > Hi, > > I'm manually inserting an entry with the conntrack tool. > > # conntrack -I -d 10.36.96.56 -s 10.36.96.12 -p tcp --sport 80 --dport 80 > --state ESTABLISHED --status A > SSURED -t 300 --zone 5 > conntrack v1.4.4 (conntrack-tools): 1 flow entries have

Re: [ovs-dev] [PATCH ] travis: support ppc64le builds

2019-11-01 Thread dwilder
On 2019-10-30 19:04, Yanqin Wei (Arm Technology China) wrote: Hi, We are working to support arm64 build for ovs travis CI. It is indeed to use arch: arm64 to choose cpu architecture, because travis has provided native arm64 option now. But in this patch it seems ppc64 builds run on the ppc-VM +

Re: [ovs-dev] [PATCH] ip_gre: Removed unused ipgre netdev ops

2019-11-01 Thread Gregory Rose
On 11/1/2019 9:52 AM, Gregory Rose wrote:     42a059e02bf3 ("ip_gre: Remove even more unused code") That one should be fine. Thanks, Oh goodness, I meant this one should be fine. adf9ac69aee1 ("ip_gre: Removed unused ipgre netdev ops") - Greg

Re: [ovs-dev] [PATCH] ip_gre: Removed unused ipgre netdev ops

2019-11-01 Thread Gregory Rose
On 11/1/2019 9:48 AM, Simon Horman wrote: On Fri, Nov 01, 2019 at 09:39:29AM -0700, Gregory Rose wrote: On 11/1/2019 9:36 AM, Simon Horman wrote: On Fri, Nov 01, 2019 at 09:24:08AM -0700, Gregory Rose wrote: On 11/1/2019 9:20 AM, Simon Horman wrote: On Fri, Nov 01, 2019 at 09:02:43AM

Re: [ovs-dev] [PATCH v4 0/2] ALLOW Stateless NAT operations

2019-11-01 Thread Numan Siddique
On Fri, Nov 1, 2019, 2:57 PM Numan Siddique wrote: > On Fri, Nov 1, 2019 at 6:58 AM Ankur Sharma > wrote: > > > > NAT implementation in OVN uses connection tracker to replace > > source and dest ips. This implementation works fine and > > is the right approach for cases where external ips are

Re: [ovs-dev] [PATCH] ip_gre: Removed unused ipgre netdev ops

2019-11-01 Thread Simon Horman
On Fri, Nov 01, 2019 at 09:39:29AM -0700, Gregory Rose wrote: > > On 11/1/2019 9:36 AM, Simon Horman wrote: > > On Fri, Nov 01, 2019 at 09:24:08AM -0700, Gregory Rose wrote: > > > On 11/1/2019 9:20 AM, Simon Horman wrote: > > > > On Fri, Nov 01, 2019 at 09:02:43AM -0700, Gregory Rose wrote: > > >

Re: [ovs-dev] [PATCH] ip_gre: Removed unused ipgre netdev ops

2019-11-01 Thread Gregory Rose
On 11/1/2019 9:36 AM, Simon Horman wrote: On Fri, Nov 01, 2019 at 09:24:08AM -0700, Gregory Rose wrote: On 11/1/2019 9:20 AM, Simon Horman wrote: On Fri, Nov 01, 2019 at 09:02:43AM -0700, Gregory Rose wrote: On 11/1/2019 8:48 AM, Gregory Rose wrote: On 11/1/2019 7:50 AM, Simon Horman wrote:

Re: [ovs-dev] [PATCH] ip_gre: Removed unused ipgre netdev ops

2019-11-01 Thread Simon Horman
On Fri, Nov 01, 2019 at 09:24:08AM -0700, Gregory Rose wrote: > > On 11/1/2019 9:20 AM, Simon Horman wrote: > > On Fri, Nov 01, 2019 at 09:02:43AM -0700, Gregory Rose wrote: > > > On 11/1/2019 8:48 AM, Gregory Rose wrote: > > > > On 11/1/2019 7:50 AM, Simon Horman wrote: > > > > > On Thu, Oct 31,

Re: [ovs-dev] [PATCH] ip_gre: Removed unused ipgre netdev ops

2019-11-01 Thread Gregory Rose
On 11/1/2019 9:20 AM, Simon Horman wrote: On Fri, Nov 01, 2019 at 09:02:43AM -0700, Gregory Rose wrote: On 11/1/2019 8:48 AM, Gregory Rose wrote: On 11/1/2019 7:50 AM, Simon Horman wrote: On Thu, Oct 31, 2019 at 03:18:23PM -0700, Gregory Rose wrote: On 10/31/2019 2:08 PM, Ben Pfaff wrote:

Re: [ovs-dev] [PATCH] ip_gre: Removed unused ipgre netdev ops

2019-11-01 Thread Simon Horman
On Fri, Nov 01, 2019 at 09:02:43AM -0700, Gregory Rose wrote: > > On 11/1/2019 8:48 AM, Gregory Rose wrote: > > > > On 11/1/2019 7:50 AM, Simon Horman wrote: > > > On Thu, Oct 31, 2019 at 03:18:23PM -0700, Gregory Rose wrote: > > > > On 10/31/2019 2:08 PM, Ben Pfaff wrote: > > > > > On Thu, Oct

[ovs-dev] [PATCH] Revert "ip_gre: Remove even more unused code"

2019-11-01 Thread Greg Rose
This reverts commit 42a059e02bf343787951be2824c579e1c9a26e12. Not all the necessary ipgre prefixed code was removed that should have been. Another patch will follow with the correct removed code. Signed-off-by: Greg Rose --- datapath/linux/compat/ip_gre.c | 38

Re: [ovs-dev] [PATCH] ip_gre: Remove even more unused code

2019-11-01 Thread Gregory Rose
On 11/1/2019 1:27 AM, Ilya Maximets wrote: On 31.10.2019 23:46, Greg Rose wrote: There is a confusing mix of ipgre and gretap functions with some needed for gretap still having ipgre_ prefixes.  This time though I think I got the rest of the unused ipgre code. Fixes: d5822f428814 ("gre:

Re: [ovs-dev] [PATCH] ip_gre: Removed unused ipgre netdev ops

2019-11-01 Thread Gregory Rose
On 11/1/2019 8:48 AM, Gregory Rose wrote: On 11/1/2019 7:50 AM, Simon Horman wrote: On Thu, Oct 31, 2019 at 03:18:23PM -0700, Gregory Rose wrote: On 10/31/2019 2:08 PM, Ben Pfaff wrote: On Thu, Oct 31, 2019 at 01:30:39PM -0700, Greg Rose wrote: When cleaning up unused ipgre code the

Re: [ovs-dev] [PATCH] ip_gre: Removed unused ipgre netdev ops

2019-11-01 Thread Gregory Rose
On 11/1/2019 7:50 AM, Simon Horman wrote: On Thu, Oct 31, 2019 at 03:18:23PM -0700, Gregory Rose wrote: On 10/31/2019 2:08 PM, Ben Pfaff wrote: On Thu, Oct 31, 2019 at 01:30:39PM -0700, Greg Rose wrote: When cleaning up unused ipgre code the ipgre_netdev_ops structure was missed. Get rid of

Re: [ovs-dev] [PATCH] lib/tc: Fix flow dump for tunnel id equal zero

2019-11-01 Thread Simon Horman
On Wed, Oct 30, 2019 at 02:40:35PM +0200, Roi Dayan wrote: > From: Dmytro Linkin > > Tunnel id 0 is not printed unless tunnel flag FLOW_TNL_F_KEY is set. > Fix that by always setting FLOW_TNL_F_KEY when tunnel id is valid. > > Fixes: 0227bf092ee6 ("lib/tc: Support optional tunnel id") >

Re: [ovs-dev] [PATCH] ip_gre: Removed unused ipgre netdev ops

2019-11-01 Thread Simon Horman
On Thu, Oct 31, 2019 at 03:18:23PM -0700, Gregory Rose wrote: > > On 10/31/2019 2:08 PM, Ben Pfaff wrote: > > On Thu, Oct 31, 2019 at 01:30:39PM -0700, Greg Rose wrote: > > > When cleaning up unused ipgre code the ipgre_netdev_ops structure > > > was missed. Get rid of it now. > > > > > > Fixes:

[ovs-dev] [PATCH net-next v6 10/10] net: openvswitch: simplify the ovs_dp_cmd_new

2019-11-01 Thread xiangxia . m . yue
From: Tonghao Zhang use the specified functions to init resource. Signed-off-by: Tonghao Zhang Tested-by: Greg Rose --- net/openvswitch/datapath.c | 60 +- 1 file changed, 38 insertions(+), 22 deletions(-) diff --git a/net/openvswitch/datapath.c

[ovs-dev] [PATCH net-next v6 09/10] net: openvswitch: don't unlock mutex when changing the user_features fails

2019-11-01 Thread xiangxia . m . yue
From: Tonghao Zhang Unlocking of a not locked mutex is not allowed. Other kernel thread may be in critical section while we unlock it because of setting user_feature fail. Fixes: 95a7233c4 ("net: openvswitch: Set OvS recirc_id from tc chain index") Cc: Paul Blakey Signed-off-by: Tonghao Zhang

[ovs-dev] [PATCH net-next v6 08/10] net: openvswitch: fix possible memleak on destroy flow-table

2019-11-01 Thread xiangxia . m . yue
From: Tonghao Zhang When we destroy the flow tables which may contain the flow_mask, so release the flow mask struct. Signed-off-by: Tonghao Zhang Tested-by: Greg Rose --- net/openvswitch/flow_table.c | 186 +++ 1 file changed, 98 insertions(+), 88

[ovs-dev] [PATCH net-next v6 06/10] net: openvswitch: simplify the flow_hash

2019-11-01 Thread xiangxia . m . yue
From: Tonghao Zhang Simplify the code and remove the unnecessary BUILD_BUG_ON. Signed-off-by: Tonghao Zhang Tested-by: Greg Rose Acked-by: William Tu --- net/openvswitch/flow_table.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/net/openvswitch/flow_table.c

[ovs-dev] [PATCH net-next v6 07/10] net: openvswitch: add likely in flow_lookup

2019-11-01 Thread xiangxia . m . yue
From: Tonghao Zhang The most case *index < ma->max, and flow-mask is not NULL. We add un/likely for performance. Signed-off-by: Tonghao Zhang Tested-by: Greg Rose Acked-by: William Tu --- net/openvswitch/flow_table.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[ovs-dev] [PATCH net-next v6 05/10] net: openvswitch: optimize flow-mask looking up

2019-11-01 Thread xiangxia . m . yue
From: Tonghao Zhang The full looking up on flow table traverses all mask array. If mask-array is too large, the number of invalid flow-mask increase, performance will be drop. One bad case, for example: M means flow-mask is valid and NULL of flow-mask means deleted.

[ovs-dev] [PATCH net-next v6 04/10] net: openvswitch: optimize flow mask cache hash collision

2019-11-01 Thread xiangxia . m . yue
From: Tonghao Zhang Port the codes to linux upstream and with little changes. Pravin B Shelar, says: | In case hash collision on mask cache, OVS does extra flow | lookup. Following patch avoid it. Link: https://github.com/openvswitch/ovs/commit/0e6efbe2712da03522532dc5e84806a96f6a0dd1

[ovs-dev] [PATCH net-next v6 03/10] net: openvswitch: shrink the mask array if necessary

2019-11-01 Thread xiangxia . m . yue
From: Tonghao Zhang When creating and inserting flow-mask, if there is no available flow-mask, we realloc the mask array. When removing flow-mask, if necessary, we shrink mask array. Signed-off-by: Tonghao Zhang Tested-by: Greg Rose Acked-by: William Tu --- net/openvswitch/flow_table.c | 33

[ovs-dev] [PATCH net-next v6 02/10] net: openvswitch: convert mask list in mask array

2019-11-01 Thread xiangxia . m . yue
From: Tonghao Zhang Port the codes to linux upstream and with little changes. Pravin B Shelar, says: | mask caches index of mask in mask_list. On packet recv OVS | need to traverse mask-list to get cached mask. Therefore array | is better for retrieving cached mask. This also allows better |

[ovs-dev] [PATCH net-next v6 01/10] net: openvswitch: add flow-mask cache for performance

2019-11-01 Thread xiangxia . m . yue
From: Tonghao Zhang The idea of this optimization comes from a patch which is committed in 2014, openvswitch community. The author is Pravin B Shelar. In order to get high performance, I implement it again. Later patches will use it. Pravin B Shelar, says: | On every packet OVS needs to lookup

[ovs-dev] [PATCH net-next v6 00/10] optimize openvswitch flow looking up

2019-11-01 Thread xiangxia . m . yue
From: Tonghao Zhang This series patch optimize openvswitch for performance or simplify codes. Patch 1, 2, 4: Port Pravin B Shelar patches to linux upstream with little changes. Patch 5, 6, 7: Optimize the flow looking up and simplify the flow hash. Patch 8, 9: are bugfix. The performance

Re: [ovs-dev] [RFC] dpdk: Deprecate pdump support.

2019-11-01 Thread Aaron Conole
Ilya Maximets writes: > The conventional way for packet dumping in OVS is to use ovs-tcpdump > that works via traffic mirroring. DPDK pdump could probably be used > for some lower level debugging, but it is not commonly used for > various reasons. > > There are lots of limitations for using

Re: [ovs-dev] [PATCH v1] ofproto: Fix OVS crash when packets hit Openflow rules with certain combinations of nested actions

2019-11-01 Thread Ilya Maximets
On 31.10.2019 18:24, Ben Pfaff wrote: For Ilya and others: the email to Anil bounced, so he probably isn't at Calsoft Labs any longer. Are you sure that it wasn't mine old email address? ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCH v1] ofproto: Fix OVS crash when packets hit Openflow rules with certain combinations of nested actions

2019-11-01 Thread Ilya Maximets
CC: ovs-dev Sorry. On 01.11.2019 14:34, Ilya Maximets wrote: On 31.10.2019 18:12, Ben Pfaff wrote: On Thu, Sep 05, 2019 at 11:12:26PM +0530, Anil Kumar Koli wrote: * We can't get rid of ofproto_mutex in do_bundle_commit(), or drop it    temporarily around flow translation (i.e. the call to   

[ovs-dev] [RFC] bridge: Allow manual notifications about interfaces' updates.

2019-11-01 Thread Ilya Maximets
Sometimes interface updates could happen in a way ifnotifier is not able to catch. For example some heavy operations (device reset) in netdev-dpdk could require re-applying of the bridge configuration. For this purpose new function 'bridge_report_if_update' introduced. It could be called

[ovs-dev] [RFC] dpdk: Deprecate pdump support.

2019-11-01 Thread Ilya Maximets
The conventional way for packet dumping in OVS is to use ovs-tcpdump that works via traffic mirroring. DPDK pdump could probably be used for some lower level debugging, but it is not commonly used for various reasons. There are lots of limitations for using this functionality in practice. Most

[ovs-dev] [PATCH ovn] Improve debuggability of OVN to OpenFlow translations.

2019-11-01 Thread Dumitru Ceara
Until now, when translating SB database contents to OpenFlow flows, ovn-controller stored (part of) the SB record UUID in the cookie field of the OpenFlow entry only when translating logical flows. Extend this behavior to the following SB Database table records too: - Port_Binding - Mac_Binding -

Re: [ovs-dev] [PATCH] travis: Enable pdump for DPDK build.

2019-11-01 Thread Ilya Maximets
On 31.10.2019 9:02, David Marchand wrote: On Wed, Oct 30, 2019 at 8:53 PM Ilya Maximets wrote: OVS has support for DPDK pdump that checked in configure script. Enabling it to increase OVS build test coverage by the code guarded by DPDK_PDUMP macro. Signed-off-by: Ilya Maximets --- Travis

Re: [ovs-dev] [PATCH v3 ovn] ovn-nb/sbctl.c: Use env variables for passing options.

2019-11-01 Thread Numan Siddique
On Fri, Nov 1, 2019, 2:37 AM Ben Pfaff wrote: > On Thu, Oct 31, 2019 at 11:45:07PM +0530, Numan Siddique wrote: > > On Sat, Oct 26, 2019 at 2:02 AM Ben Pfaff wrote: > > > > > > On Fri, Oct 25, 2019 at 01:10:57PM -0700, amgin...@gmail.com wrote: > > > > From: Aliasgar Ginwala > > > > > > > >

Re: [ovs-dev] [PATCH v4 0/2] ALLOW Stateless NAT operations

2019-11-01 Thread Numan Siddique
On Fri, Nov 1, 2019 at 6:58 AM Ankur Sharma wrote: > > NAT implementation in OVN uses connection tracker to replace > source and dest ips. This implementation works fine and > is the right approach for cases where external ips are shared > (i.e. SNAT) or where we replace ip only when relevant

Re: [ovs-dev] [PATCH] ip_gre: Remove even more unused code

2019-11-01 Thread Ilya Maximets
On 31.10.2019 23:46, Greg Rose wrote: There is a confusing mix of ipgre and gretap functions with some needed for gretap still having ipgre_ prefixes. This time though I think I got the rest of the unused ipgre code. Fixes: d5822f428814 ("gre: Remove dead ipgre code") Signed-off-by: Greg Rose