do you think?
I didn't fully read the doc, but see some typos and minor issues that
caught my eye below.
Best regards, Ilya Maximets.
> Documentation/topics/index.rst | 1 +
> 3 files changed, 472 insertions(+), 1 deletion(-)
> create mode 100644 Documentati
${command}
> +unset command
> +])
Hi, Xavier. Not an issue of this particular patch as this thing was
introduced long ago, but...
The shell command 'command' is a way to call a different command ignoring
the defined aliases. Overloading the 'command' its
On 2/8/24 16:53, Eelco Chaudron wrote:
>
>
> On 8 Feb 2024, at 15:00, Ilya Maximets wrote:
>
>> On 2/8/24 13:44, Eelco Chaudron wrote:
>>>
>>>
>>> On 6 Feb 2024, at 16:01, Ilya Maximets wrote:
>>>
>>>> On 2/6/24 15:07, Eel
ionally newer kernels also support flushing a zone without
> listing
> + * it first. */
>
> struct nl_dump dump;
> struct ofpbuf buf, reply, delete;
> +int err;
> +
> +if (netlink_flush_supports_zone())
On 2/16/24 16:55, Simon Horman wrote:
> On Fri, Feb 16, 2024 at 12:46:33PM +0100, Ilya Maximets wrote:
>> Signed-off-by: Ilya Maximets
>
> Acked-by: Simon Horman
>
Thanks, Simon!
I applied the patches (first one to master and branch-3.3 and
the second one to branch-3.3 on
On 2/16/24 21:40, Mike Pattrick wrote:
> On Fri, Feb 16, 2024 at 3:23 PM Ilya Maximets wrote:
>>
>> On 2/15/24 23:53, Mike Pattrick wrote:
>>> Previously a gap existed in the tunnel system tests where only ICMP and
>>> TCP traffic was tested. However, the co
tps://github.com/igsilya/ovs/commit/f544d397250714b7ba8c1a3f81eada29ffd59142
I did several iterations of GHA runs with these changes and they
work fine in CI.
If you agree, I can fold those in while applying the set.
Please, let me know as soon as possible as we need to proceed with
the release.
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
CC: Aaron, Simon. :)
On 2/16/24 12:46, Ilya Maximets wrote:
> It's time for an OVS 3.3 release!
>
> The plan is to accept a couple more fixes before the actual release,
> namely checksum offloading fixes, but sending this set now to get
> it reviewed.
>
> Ilya Maximets
Signed-off-by: Ilya Maximets
---
NEWS | 3 +++
configure.ac | 2 +-
debian/changelog | 6 ++
3 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/NEWS b/NEWS
index fb3ec..4bfb341cf 100644
--- a/NEWS
+++ b/NEWS
@@ -1,3 +1,6 @@
+v3.3.1 - xx xxx
Beside the date update, moving the mdb NEWS entry to a more
appropriate place - ovs-appctl section.
Signed-off-by: Ilya Maximets
---
NEWS | 6 +++---
debian/changelog | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/NEWS b/NEWS
index e4eedb5b4..fb3ec 100644
It's time for an OVS 3.3 release!
The plan is to accept a couple more fixes before the actual release,
namely checksum offloading fixes, but sending this set now to get
it reviewed.
Ilya Maximets (2):
Set release date for 3.3.0.
Prepare for 3.3.1.
NEWS
y
> lose anything by moving forward with this simple change at this time?
I think, it's fine for now. The extra 2 recirculations are very unlikely
to blow up the stack, especially since the default config is to have 2 MB
of pre-allocated and mlocked stack.
So, applied for now. Also applied to 3.3 as I don't think this change
carries any risk at this time and it will make life of OVN developers/users
much easier.
But we still need to think of a better way of solving this issue for the
future.
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 2/15/24 14:36, Simon Horman wrote:
> On Thu, Feb 15, 2024 at 12:55:59PM +0100, Ilya Maximets wrote:
>> The cited commit removed direct call to RSTP module from a callback,
>> but we can still enter the module after going through a patch port
>> to a different bridge via ofp
On 2/15/24 14:18, Simon Horman wrote:
> On Tue, Feb 13, 2024 at 08:44:41PM +0100, Ilya Maximets wrote:
>> The output file of this openssl command is a certificate signed with
>> pre-existing private key. It doesn't create a private key. The
>> restricted permissions a
On 2/15/24 14:15, Simon Horman wrote:
> On Tue, Feb 13, 2024 at 08:42:36PM +0100, Ilya Maximets wrote:
>> It's not an executable file.
>>
>> Signed-off-by: Ilya Maximets
>
> Acked-by: Simon Horman
Thanks, Mike and Simon! Appli
On 2/14/24 13:43, Xavier Simonart wrote:
> When a ct element was cleaned, the cmap could be shrinked, potentially
> causing some elements to be skipped in the flush iteration.
>
> Signed-off-by: Xavier Simonart
> ---
> lib/conntrack.c | 14 -
> lib/conntrack.h | 1 +
On 2/15/24 13:42, Simon Horman wrote:
> On Tue, Feb 13, 2024 at 11:08:54AM +0100, Ilya Maximets wrote:
>> On 2/13/24 09:37, Adrian Moreno wrote:
>>>
>>>
>>> On 2/13/24 09:32, Adrian Moreno wrote:
>>>>
>>>>
>>>> On 2/9/24 17
ck avoided'.
Signed-off-by: Ilya Maximets
---
Another thing we can do to improve debugability is to also dump
the stack trace on ovs_abort. It will also help with debugging
assertions on systems where coredumps are disabled for some reason.
But it's a separate topic.
l
lock recursion.")
Reported-at:
https://mail.openvswitch.org/pipermail/ovs-discuss/2024-February/052925.html
Reported-by: Huangzhidong
Signed-off-by: Ilya Maximets
---
lib/rstp.c| 6 -
tests/rstp.at | 57 +
tests/stp.at
> @@ -122,13 +130,14 @@ avx512_dp_packet_resize_l2(struct dp_packet *b, int
> resize_by_bytes)
> /* Set the v_u16_max register to all one's. */
> const __m128i v_u16_max = _mm_cmpeq_epi16(v_zeros, v_zeros);
>
> -/* Each lane represents 16 bits in a 12-bit register. In this case the
> - * first three 16-bit values, which will map to the l2_5_ofs, l3_ofs and
> - * l4_ofs fields. */
> -const uint8_t k_lanes = 0b1110;
> +/* Each lane represents 16 bits in a 12-bit register. Here the bitmask
Not an issue of this patch, but there should be 128-bit register, not 12.
I fixed that before applying the set since we're touching this line anyway.
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
TSO.")
>> Signed-off-by: Mike Pattrick
>
> Reviewed-by: David Marchand
>
>
Thanks, Mike and David!
I applied the set and backported down to 3.3.
Patches 2 and 4 also backported down to 2.17.
Best regards, Ilya Maximets.
__
om
> tc operations.
>
> Also expand the unit test to cover queues where ceil is determined by
> the maximum link speed.
>
> Fixes: b8f8fad86435 ("netdev-linux: Use speed as max rate in tc classes.")
> Reported-by: Daryl Wang
> Suggested-by: Ilya Maximets
> Si
icted permissions in the first place.
Fixes: 99e5e05db37a ("ovs-pki: Create private keys with restricted
permissions.")
Signed-off-by: Ilya Maximets
---
utilities/ovs-pki.in | 13 +++--
1 file changed, 3 insertions(+), 10 deletions(-)
diff --git a/utilities/ovs-pki.in b/utilities/o
It's not an executable file.
Signed-off-by: Ilya Maximets
---
utilities/ovs-pki.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/utilities/ovs-pki.in b/utilities/ovs-pki.in
index e0ba910f9..37913cb6b 100755
--- a/utilities/ovs-pki.in
+++ b/utilities/ovs-pki.in
@@ -
#x27;,
but I think it's a little nicer to have separate phases, and we
can also move 'windows-prepare.sh' to the install phase.
Cache is also invalidated whenever appveyor.yml changes.
Signed-off-by: Ilya Maximets
---
appveyor.yml | 52 +++
vate folders and keys have only a full access from
their owners. Other files and folders have some extra inherited ACEs
from a containing folder.
Signed-off-by: Ilya Maximets
---
utilities/ovs-pki.in | 87 ++--
1 file changed, 84 insertions(+), 3 delet
We need to know exact linking / compilation errors in order
to fix issues. We could have uploaded it as an artifact,
but it seems easier to just print it out for now.
Signed-off-by: Ilya Maximets
---
.ci/windows-build.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.ci
/20230531192341.2006171-2-i.maxim...@ovn.org/
Fixing permissions for keys and certs generated by ovs-pki,
adding support for building with OpenSSL 3+ and fixing CI
to actually download and build with desired versions of
OpenSSL.
Ilya Maximets (4):
appveyor: Print out config.log on configuration failure
ed in different folders
based on the linkage type. So, we have to provide an exact path in
order to find the library.
'lib/VC/x64/MD' was chosen in this patch and it seems to work fine.
MD stands for dynamic linking, MT is static, 'd' stands for debug
versions of the libraries.
Sig
On 2/13/24 09:28, Adrian Moreno wrote:
>
>
> On 2/12/24 18:49, Ilya Maximets wrote:
>> On 2/12/24 09:43, Adrian Moreno wrote:
>>>
>>>
>>> On 2/9/24 17:15, Ilya Maximets wrote:
>>>> On 2/9/24 08:06, Adrian Moreno wrote:
>>>>>
On 2/13/24 09:37, Adrian Moreno wrote:
>
>
> On 2/13/24 09:32, Adrian Moreno wrote:
>>
>>
>> On 2/9/24 17:17, Ilya Maximets wrote:
>>> For some reason annotation is made for a read-lock, while all the
>>> callers are correctly holding a write-lock.
&g
On 2/12/24 14:05, Alin Serdean wrote:
> Looking forward to that patch :)
> Thank you for migrating the CI to msys!
>
> Acked-by: Alin Gabriel Serdean
> Signed-off-by: Alin Gabriel Serdean
Thanks! Applied.
I'll clean up my OpenSSL patches and send them out. :)
Best re
On 2/12/24 09:43, Adrian Moreno wrote:
>
>
> On 2/9/24 17:15, Ilya Maximets wrote:
>> On 2/9/24 08:06, Adrian Moreno wrote:
>>> In order to properly balance bond traffic, ofproto/bond periodically
>>> reads usage statistics of the post-recirculation rules
On 2/12/24 15:19, Mike Pattrick wrote:
> On Mon, Feb 12, 2024 at 7:52 AM Ilya Maximets wrote:
>>
>> On 2/12/24 09:13, Mike Pattrick wrote:
>>> When sending packets that are flagged as requiring segmentation to an
>>> interface that doens't support th
On 2/12/24 09:13, Mike Pattrick wrote:
> When sending packets that are flagged as requiring segmentation to an
> interface that doens't support this feature, send the packet to the TSO
> software fallback instead of dropping it.
>
> Signed-off-by: Mike Pattrick
>
> ---
> Note: Previously this pa
On 2/9/24 21:47, Ilya Maximets wrote:
> AppVeyor is planning to remove support for MinGW 32bit soon. And we
> had a couple of incidents where it wasn't available already, so we
> moved to a 'Previous' image.
>
> Move to msys64 instead.
>
> While at it
dout for scripts, because any
message on stderr is treated as fatal failure by powershell.
Scripts are running with 'set -e', so a failure of individual
commands will fail the script.
The OpenSSL download is still failing, but it is out of scope for
this change.
Signed-off-by: Ilya
For some reason annotation is made for a read-lock, while all the
callers are correctly holding a write-lock.
Fixes: 05df16238d43 ("ofproto/bond: Fix bond post recirc rule leak.")
Signed-off-by: Ilya Maximets
---
ofproto/bond.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
di
On 2/9/24 08:06, Adrian Moreno wrote:
> In order to properly balance bond traffic, ofproto/bond periodically
> reads usage statistics of the post-recirculation rules (which are added
> to a hidden internal table).
>
> To do that, each "struct bond_entry" (which represents a hash within a
> bond) s
On 2/8/24 18:06, Aaron Conole wrote:
> Ilya Maximets writes:
>
>> Bug Fix + Security release.
>>
>> Ilya Maximets (2):
>> Set release date for 3.2.2.
>> Prepare for 3.2.3.
>>
>> NEWS | 8 +++-
>> configure.ac | 2 +-
Bug Fix + Security release.
Ilya Maximets (2):
Set release date for 3.2.2.
Prepare for 3.2.3.
NEWS | 8 +++-
configure.ac | 2 +-
debian/changelog | 8 +++-
3 files changed, 15 insertions(+), 3 deletions(-)
--
2.43.0
Signed-off-by: Ilya Maximets
---
NEWS | 5 -
debian/changelog | 2 +-
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/NEWS b/NEWS
index 0387b66d5..47be5e065 100644
--- a/NEWS
+++ b/NEWS
@@ -1,5 +1,8 @@
-v3.2.2 - xx xxx
+v3.2.2 - 08 Feb 2024
Signed-off-by: Ilya Maximets
---
NEWS | 3 +++
configure.ac | 2 +-
debian/changelog | 6 ++
3 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/NEWS b/NEWS
index 47be5e065..baeecae04 100644
--- a/NEWS
+++ b/NEWS
@@ -1,3 +1,6 @@
+v3.2.3 - xx xxx
Bug Fix + Security release.
Ilya Maximets (2):
Set release date for 3.1.4.
Prepare for 3.1.5.
NEWS | 8 +++-
configure.ac | 2 +-
debian/changelog | 8 +++-
3 files changed, 15 insertions(+), 3 deletions(-)
--
2.43.0
Signed-off-by: Ilya Maximets
---
NEWS | 3 +++
configure.ac | 2 +-
debian/changelog | 6 ++
3 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/NEWS b/NEWS
index 8fff14652..aaddb77e8 100644
--- a/NEWS
+++ b/NEWS
@@ -1,3 +1,6 @@
+v3.1.5 - xx xxx
Signed-off-by: Ilya Maximets
---
NEWS | 3 +++
configure.ac | 2 +-
debian/changelog | 6 ++
3 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/NEWS b/NEWS
index a88724e1e..0bb28638c 100644
--- a/NEWS
+++ b/NEWS
@@ -1,3 +1,6 @@
+v3.0.7 - xx xxx
Signed-off-by: Ilya Maximets
---
NEWS | 5 -
debian/changelog | 2 +-
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/NEWS b/NEWS
index 77cf4bbac..8fff14652 100644
--- a/NEWS
+++ b/NEWS
@@ -1,5 +1,8 @@
-v3.1.4 - xx xxx
+v3.1.4 - 08 Feb 2024
Signed-off-by: Ilya Maximets
---
NEWS | 5 -
debian/changelog | 2 +-
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/NEWS b/NEWS
index 2a9a99a8f..a88724e1e 100644
--- a/NEWS
+++ b/NEWS
@@ -1,5 +1,8 @@
-v3.0.6 - xx xxx
+v3.0.6 - 08 Feb 2024
Bug Fix + Security release.
Ilya Maximets (2):
Set release date for 3.0.6.
Prepare for 3.0.7.
NEWS | 8 +++-
configure.ac | 2 +-
debian/changelog | 8 +++-
3 files changed, 15 insertions(+), 3 deletions(-)
--
2.43.0
Signed-off-by: Ilya Maximets
---
NEWS | 3 +++
configure.ac | 2 +-
debian/changelog | 6 ++
3 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/NEWS b/NEWS
index 4c3cdd651..ca111ae3a 100644
--- a/NEWS
+++ b/NEWS
@@ -1,3 +1,6 @@
+v2.17.10 - xx xxx
Bug Fix + Security release.
Ilya Maximets (2):
Set release date for 2.17.9.
Prepare for 2.17.10.
NEWS | 8 +++-
configure.ac | 2 +-
debian/changelog | 8 +++-
3 files changed, 15 insertions(+), 3 deletions(-)
--
2.43.0
Signed-off-by: Ilya Maximets
---
NEWS | 5 -
debian/changelog | 2 +-
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/NEWS b/NEWS
index 7ef97cfa8..4c3cdd651 100644
--- a/NEWS
+++ b/NEWS
@@ -1,5 +1,8 @@
-v2.17.9 - xx xxx
+v2.17.9 - 08 Feb 2024
sent to flower.
It also includes a system-traffic test for geneve packets with corrupted
metadata.
Fixes: a468645c6d33 ("lib/tc: add geneve with option match offload")
Reported-by: Haresh Khandelwal
Signed-off-by: Timothy Redaelli
Signed-off-by: Ilya Maximets
---
The patch is alrea
' match, rather than both
'icmp_type=..,icmp_code=0' when matching on neighbor discovery.
Signed-off-by: Aaron Conole
Signed-off-by: Ilya Maximets
---
The patch is already applied. Posting for completeness.
lib/odp-util.c | 31 +++--
On 2/8/24 13:44, Eelco Chaudron wrote:
>
>
> On 6 Feb 2024, at 16:01, Ilya Maximets wrote:
>
>> On 2/6/24 15:07, Eelco Chaudron wrote:
>>>
>>>
>>> On 6 Feb 2024, at 14:46, Ilya Maximets wrote:
>>>
>>>> On 2/6/24 14:30, Eelco Ch
On 2/7/24 22:07, Adrian Moreno wrote:
>
>
> On 2/7/24 19:05, Ilya Maximets wrote:
>> On 2/5/24 13:02, Adrian Moreno wrote:
>>> netdev_linux_get_speed needs to lock netdev_linux->mutex, and so do the
>>> internal tc operations. Therefore, the former
om
> tc operations.
>
> Also expand the unit test to cover queues where ceil is determined by
> the maximum link speed.
>
> Fixes: b8f8fad86435 ("netdev-linux: Use speed as max rate in tc classes.")
> Reported-by: Daryl Wang
> Suggested-by: Ilya Maximets
> Signed-off-b
On 2/6/24 22:22, Ilya Maximets wrote:
>>>
>>> I did some testing with my patch and these are the findings
>>>
>>> | Avg. Poll Intervals | Total
>>> test time | northd RSS
>>> ---
fair share of allocation overhead since
we're allocating a huge number of very small objects.
Numan also gets rid of all the space allocated for hash maps that hold
all these refcounts, and these were taking ~25% of all allocations.
Getting rid of these allocations likely saves a lot of CPU cycles a
On 2/6/24 15:07, Eelco Chaudron wrote:
>
>
> On 6 Feb 2024, at 14:46, Ilya Maximets wrote:
>
>> On 2/6/24 14:30, Eelco Chaudron wrote:
>>> Previously, the ability to override the system default for the number
>>> of handler threads was broken since to the in
lementation changed completely.
And those setups may suffer if we suddenly decide to respect the configuration
that is ignored on modern kernels for all currently supported versions of OVS.
Best regards, Ilya Maximets.
___
dev mailing list
d...@op
operation doesn't require
RBAC checks and an empty mutation is similar to selection), this introduces
an unclear difference between empty mutations with and without condition.
One performs RBAC check and the other does not. We should be consistent.
Would be also nice to have a non-RBAC te
On 2/6/24 13:50, Eelco Chaudron wrote:
>
>
> On 6 Feb 2024, at 13:46, Ilya Maximets wrote:
>
>> On 2/4/24 15:40, Timothy Redaelli wrote:
>>> A log message like this one:
>>>
>>> 2024-01-09T06:45:17.201Z|00071|bfd(handler2)|INFO|ovn-0af536-0: BFD
_packet_inner_l4(b)
> - dp_packet_l2_pad_size(b)
Hi, Mike. Thanks for v2!
I don't have any particular comments beside the ones David already made.
Could you, please, address them and post a new version?
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Session Down)
(no need to split lines, I did that only for ease of reading)
Since at least one part will change, the arrow should not be confusing anymore.
Spelling out bfd.Xx names as in the RFC is probably not necessary since we're
printing out
22.11.4
> 3.3.x23.11
>
Hi, Kevin. Thanks for the patches!
I didn't test them, but LGTM. For all DPDK update patches:
Acked-by: Ilya Maximets
P.S.: the 'master/branch-3.3' tag is likely confusing for bots,
it's better to
On 2/5/24 15:45, Ilya Maximets wrote:
> On 2/5/24 11:34, Ilya Maximets wrote:
>> On 2/5/24 09:23, Dumitru Ceara wrote:
>>> On 2/5/24 08:13, Han Zhou wrote:
>>>> On Sun, Feb 4, 2024 at 9:26 PM Numan Siddique wrote:
>>>>>
>>>>> On Sun,
On 2/5/24 11:34, Ilya Maximets wrote:
> On 2/5/24 09:23, Dumitru Ceara wrote:
>> On 2/5/24 08:13, Han Zhou wrote:
>>> On Sun, Feb 4, 2024 at 9:26 PM Numan Siddique wrote:
>>>>
>>>> On Sun, Feb 4, 2024 at 9:53 PM Han Zhou wrote:
>>>>>
On 2/5/24 11:58, Dumitru Ceara wrote:
> On 2/5/24 11:34, Ilya Maximets wrote:
>> On 2/5/24 09:23, Dumitru Ceara wrote:
>>> On 2/5/24 08:13, Han Zhou wrote:
>>>> On Sun, Feb 4, 2024 at 9:26 PM Numan Siddique wrote:
>>>>>
>>>>> On Sun,
On 2/5/24 09:23, Dumitru Ceara wrote:
> On 2/5/24 08:13, Han Zhou wrote:
>> On Sun, Feb 4, 2024 at 9:26 PM Numan Siddique wrote:
>>>
>>> On Sun, Feb 4, 2024 at 9:53 PM Han Zhou wrote:
>>>>
>>>> On Sun, Feb 4, 2024 at 5:46 AM Ilya Maximets wrot
usage is also very concerning. Unfortunately it is not tied to the
cluster-density test. The same 4-5x RSS jump is also seen in other test
like density-heavy. Last week RSS of ovn-northd in cluster-density 500 node
was between 1.5 and 2.5 GB, this week we have a range between 5.5 and 8.5 GB.
t;,
\"statistics\",\"status\",\"tag\",\"trunks\",\"vlan_mode\"]"
},"id":52,"result":null}
The column have to stay, similarly to other public interfaces.
What we can probably do is to add a new column and use/store values
from/into both, while removing the old one from the documentation.
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
zone should leave the others intact
Hi, Felix. Not a full review, but I'm a little concerned if that part
actually works for zone 0, i.e. that zone 0 remains intact when we flush
other zones.
I sent a question to the netdev list:
https://lore.kernel.org/netdev/2032238f-31ac-4106-8f22-522e76
2",
> +"version": "7.3.0",
> +"cksum": "2786772995 34106",
> "tables": {
> "NB_Global": {
> "columns": {
> @@ -293,10 +293,9 @@
> "enum": [&qu
On 1/30/24 10:55, Simon Horman wrote:
> On Mon, Jan 29, 2024 at 11:33:56PM +0100, Ilya Maximets wrote:
>> Fedora 37 reached EOL in November. Switch to the most recent version
>> to avoid potential CI failures in the future.
>>
>> Signed-off-by: Ilya Maximets
On 1/31/24 14:27, Ilya Maximets wrote:
> On 1/31/24 13:13, Ilya Maximets wrote:
>> On 1/30/24 15:18, Ilya Maximets wrote:
>>> On 1/30/24 13:07, Ilya Maximets wrote:
>>>> checkout@v3, cache@v3, setup-python@v4 and setup-go@v3 are using
>>>> outdated Node.js
On 1/31/24 13:13, Ilya Maximets wrote:
> On 1/30/24 15:18, Ilya Maximets wrote:
>> On 1/30/24 13:07, Ilya Maximets wrote:
>>> checkout@v3, cache@v3, setup-python@v4 and setup-go@v3 are using
>>> outdated Node.js 16 which is now deprecated in GHA [1], so these
>&g
On 1/30/24 15:18, Ilya Maximets wrote:
> On 1/30/24 13:07, Ilya Maximets wrote:
>> checkout@v3, cache@v3, setup-python@v4 and setup-go@v3 are using
>> outdated Node.js 16 which is now deprecated in GHA [1], so these
>> actions may stop working soon.
>>
>> Updat
On 1/30/24 13:07, Ilya Maximets wrote:
> checkout@v3, cache@v3, setup-python@v4 and setup-go@v3 are using
> outdated Node.js 16 which is now deprecated in GHA [1], so these
> actions may stop working soon.
>
> Updating to most recent major versions with Node.js 20. This stops
>
orted file pattern: go.sum
Specify a path to all .sum files we have in the repository to make
the setup-go happy. This should in theory make the builds a touch
faster. This change is in line with recent changes in ovn-kubernetes
itself.
Signed-off-by: Ilya Maximets
---
.github/workflows/cont
On 1/30/24 09:54, Jakob Meng wrote:
> On 29.01.24 23:33, Ilya Maximets wrote:
>> Fedora 37 reached EOL in November. Switch to the most recent version
>> to avoid potential CI failures in the future.
>>
>> Signed-off-by: Ilya Maximets
>> ---
>> .github/wo
On 1/25/24 21:55, Aaron Conole wrote:
> All supported versions of Fedora do package libbpf, so it
> makes sense to enable USDT support.
>
> Signed-off-by: Aaron Conole
> ---
> v8: Include the correct devel package as a dependency
>
> rhel/openvswitch-fedora.spec.in | 8
> 1 file change
Fedora 37 reached EOL in November. Switch to the most recent version
to avoid potential CI failures in the future.
Signed-off-by: Ilya Maximets
---
.github/workflows/build-and-test.yml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.github/workflows/build-and-test.yml
b
On 1/26/24 17:00, Eelco Chaudron wrote:
>
>
> On 26 Jan 2024, at 15:38, Ilya Maximets wrote:
>
>> checkout@v3, cache@v3 and setup-python@v4 are using outdated Node.js 16
>> which is now deprecated in GHA [1], so these actions will stop working
>> soon.
>&
On 1/23/24 14:53, Mohammad Heib wrote:
> Hi Dumitru,
>
> Thank you for the review,
> yes sure will bump the submodule to the last stable once they fix the issue.
I applied the BFD fix and also applied the typedef fix for the mcast_group_proto
enum. So, make sure to include both for the update.
On 1/28/24 11:20, Mohammad Heib wrote:
> Thanks, Ilya,
> Looks good to me.
>
> Acked-by: Mohammad Heib mailto:mh...@redhat.com>>
>
Thanks! I applied the change and backported to branch-3.3.
Best regards, Ilya Maximets.
> Thanks,
>
>
>
> On Fri, J
nd backported to 3.3.
I left some comments for the other patches in the set.
FWIW, Dumitru, you may want to wait for the following change to land
before upgrading submodule in OVN:
https://patchwork.ozlabs.org/project/openvswitch/patch/20240126170758.
sible that there is a variable definition in
one of the cases and braces should be used. Strangely some versions
of compilers do not require braces in this case, so OVN change works
locally, but not in CI.
Fixes: 077d0bad0436 ("mcast-snooping: Store IGMP/MLD protocol version.")
Sign
igned-off-by: Ilya Maximets
---
Version 2:
* Updated cache/resote and cache/save sub-actions as well.
.github/workflows/build-and-test.yml | 42 ++--
1 file changed, 21 insertions(+), 21 deletions(-)
diff --git a/.github/workflows/build-and-test.yml
b/.github/workflows/
On 1/25/24 22:46, Mike Pattrick wrote:
> Include inner offsets in functions where l3 and l4 offsets are either
> modified or checked.
>
> Signed-off-by: Mike Pattrick
> Fixes: 084c8087292c ("userspace: Support VXLAN and GENEVE TSO.")
> ---
> lib/dp-packet.c | 6 +-
> 1 file changed, 5 insert
On 1/25/24 22:46, Mike Pattrick wrote:
> Previously the BFD packet creation code did not appropriately set
> offsets or flags. This contributed to issues involving encapsulation and
> the TSO code.
>
> Signed-off-by: Mike Pattrick
> Fixes: ccc096898c46 ("bfd: Implement Bidirectional Forwarding De
On 1/25/24 22:46, Mike Pattrick wrote:
> This patch fixes the correctness of dp_packet_inner_l4_size() when
> checking for the existence of an inner L4 header. Previously it checked
> for the outer L4 header.
>
> This function is currently only used when a packet is already flagged
> for tunneling
On 1/26/24 14:59, Ilya Maximets wrote:
> checkout@v3, cache@v3 and setup-python@v4 are using outdated Node.js 16
> which is now deprecated in GHA [1], so these actions will stop working
> soon.
>
> Updating to most recent major versions with Node.js 20. This stops GHA
> from th
igned-off-by: Ilya Maximets
---
.github/workflows/build-and-test.yml | 38 ++--
1 file changed, 19 insertions(+), 19 deletions(-)
diff --git a/.github/workflows/build-and-test.yml
b/.github/workflows/build-and-test.yml
index 3807e5f13..8d90f9798 100644
--- a/.github/work
On 1/25/24 22:46, Mike Pattrick wrote:
> The OVN test suite identified a bug in dp_packet_ol_send_prepare() where
> a BFD packet flagged as double encapsulated would trigger a seg fault.
> The problem surfaced because bfd_put_packet was reusing a packet
> allocated on the stack that wasn't having i
On 1/24/24 17:39, Aaron Conole wrote:
> Dumitru Ceara writes:
>
>> On 1/23/24 00:11, Mike Pattrick wrote:
>>> The OVN test suite identified a bug in dp_packet_ol_send_prepare() where
>>> a BFD packet flagged as double encapsulated would trigger a seg fault.
>>> The problem surfaced because bfd_pu
On 1/23/24 14:31, Mike Pattrick wrote:
> On Tue, Jan 23, 2024 at 7:41 AM Ilya Maximets wrote:
>>
>> On 1/22/24 23:24, Mike Pattrick wrote:
>>> On Mon, Jan 22, 2024 at 4:10 PM Ilya Maximets wrote:
>>>>
>>>> On 1/22/24 21:33, Mike Pattrick wrote:
>
On 1/22/24 23:24, Mike Pattrick wrote:
> On Mon, Jan 22, 2024 at 4:10 PM Ilya Maximets wrote:
>>
>> On 1/22/24 21:33, Mike Pattrick wrote:
>>> On Mon, Jan 22, 2024 at 1:47 PM Ilya Maximets wrote:
>>>>
>>>> On 1/22/24 18:51, Mike Pattrick wro
On 1/22/24 21:33, Mike Pattrick wrote:
> On Mon, Jan 22, 2024 at 1:47 PM Ilya Maximets wrote:
>>
>> On 1/22/24 18:51, Mike Pattrick wrote:
>>> The OVN test suite identified a bug in dp_packet_ol_send_prepare() where
>>> a double encapsulated BFD packet would trigg
On 1/19/24 14:01, Eelco Chaudron wrote:
>
>
> On 19 Jan 2024, at 13:53, David Marchand wrote:
>
>> On Fri, Jan 19, 2024 at 1:49 PM Ilya Maximets wrote:
>>>
>>> On 1/18/24 14:00, David Marchand wrote:
>>>> Seen in GHA recently.
>>>>
701 - 800 of 2465 matches
Mail list logo
