Re: [ovs-dev] branching commits

> On Jan 31, 2017, at 3:03 PM, Ben Pfaff wrote: > > Hi Justin. We branched a couple of weeks ago but at the time we forgot > to update NEWS, etc. either on master or the branch. Usually you submit > those patches; do you want to do the honors this time too? Okay, I sent out

[ovs-dev] [branch-2.7] Prepare for 2.7.0.

Signed-off-by: Justin Pettit <jpet...@ovn.org> --- NEWS | 2 +- configure.ac | 2 +- debian/changelog | 79 +--- 3 files changed, 77 insertions(+), 6 deletions(-) diff --git a/NEWS b/NEWS index 0a9551c..1a3787d

Re: [ovs-dev] [PATCH] Prepare for post-2.7.0 (2.7.90).

> On Feb 1, 2017, at 9:28 AM, Ben Pfaff <b...@ovn.org> wrote: > > On Tue, Jan 31, 2017 at 05:53:41PM -0800, Justin Pettit wrote: >> Signed-off-by: Justin Pettit <jpet...@ovn.org> > > Acked-by: Ben Pfaff <b...@ovn.org>

Re: [ovs-dev] [branch-2.7] Prepare for 2.7.0.

> On Feb 1, 2017, at 9:27 AM, Ben Pfaff <b...@ovn.org> wrote: > > On Tue, Jan 31, 2017 at 05:47:45PM -0800, Justin Pettit wrote: >> Signed-off-by: Justin Pettit <jpet...@ovn.org> > > Acked-by: Ben Pfaff <b...@ovn.org> T

Re: [ovs-dev] [PATCH 2/2] ovs-fields: New manpage to document Open vSwitch and OpenFlow fields.

> On Jan 24, 2017, at 5:11 PM, Justin Pettit <jpet...@ovn.org> wrote: > > This was a lot of work. Thanks for doing it! > > --Justin Whoops! Acked-by: Justin Pettit <jpet...@ovn.org> --Justin ___ dev mailing list

Re: [ovs-dev] [PATCH 2/2] ovs-fields: New manpage to document Open vSwitch and OpenFlow fields.

> On Dec 28, 2016, at 1:10 PM, Ben Pfaff wrote: > > From: Ben Pfaff > > There is still plenty of opportunity for improvement, but this new > ovs-fields(7) manpage is much more comprehensive than ovs-ofctl(8) > could be. > > Signed-off-by: Ben Pfaff

[ovs-dev] [branch-2.7] Set release date for 2.7.0.

Signed-off-by: Justin Pettit <jpet...@ovn.org> --- NEWS | 2 +- debian/changelog | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index 89bb026..4ec96de 100644 --- a/NEWS +++ b/NEWS @@ -1,4 +1,4 @@ -v2.7.0 - xx xxx +v2.7.0 - 21 Fe

[ovs-dev] [branch-2.5 2/2] Prepare for 2.5.3.

Signed-off-by: Justin Pettit <jpet...@ovn.org> --- NEWS | 4 configure.ac | 2 +- debian/changelog | 7 +++ 3 files changed, 12 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 7c697db..6c1d998 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,7 @@ +v2.5.3 - xx xx

[ovs-dev] [branch-2.5 1/2] Set release date for 2.5.2.

Signed-off-by: Justin Pettit <jpet...@ovn.org> --- NEWS | 3 ++- debian/changelog | 9 +++-- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/NEWS b/NEWS index 27c15af..7c697db 100644 --- a/NEWS +++ b/NEWS @@ -1,10 +1,11 @@ -v2.5.2 - xx xxx +v2.5.2 - 21 Fe

[ovs-dev] [PATCH] Remove build-time generated files when "make clean" is run.

ot; was run. This commit only leaves configuration files after "make clean" is run, and removes all other generated files. Signed-off-by: Justin Pettit <jpet...@ovn.org> --- debian/automake.mk | 2 +- ovn/automake.mk | 10 +- ovn/contr

Re: [ovs-dev] [PATCH] Remove build-time generated files when "make clean" is run.

> On Feb 13, 2017, at 7:49 PM, Ben Pfaff <b...@ovn.org> wrote: > > On Mon, Feb 13, 2017 at 05:31:49PM -0800, Justin Pettit wrote: >> "make clean" should remove all files generated by building a program, while >> "make distclean" should also remov

[ovs-dev] [PATCH] ovsdb: Print enum elements for man pages in alphabetical order.

The previous behavior printed them in a pseudorandom order, which made them look odd in man pages. Signed-off-by: Justin Pettit <jpet...@ovn.org> --- python/ovs/db/types.py | 1 + 1 file changed, 1 insertion(+) diff --git a/python/ovs/db/types.py b/python/ovs/db/types.py index 78d5fcd..5

Re: [ovs-dev] [PATCH] ovsdb: Print enum elements for man pages in alphabetical order.

> On Feb 14, 2017, at 8:50 PM, Ben Pfaff <b...@ovn.org> wrote: > > On Tue, Feb 14, 2017 at 04:55:11PM -0800, Justin Pettit wrote: >> The previous behavior printed them in a pseudorandom order, which made >> them look odd in man pages. >> >> Signed

Re: [ovs-dev] [PATCH] FAQ: Update kernel support info.

> On Feb 27, 2017, at 5:45 PM, Jarno Rajahalme <ja...@ovn.org> wrote: > > OVS 2.7 works with Linux kernels 3.10-4.9. > > Signed-off-by: Jarno Rajahalme <ja...@ovn.org> Acked-by: Justin Pettit <jpet...@ovn.org> --Justin _

Re: [ovs-dev] patchwork

> On Nov 10, 2016, at 9:54 PM, Ben Pfaff wrote: > > On Fri, Nov 11, 2016 at 09:11:48AM +0800, Jeremy Kerr wrote: > >>> Jeremy, do we have the right email address subscribed to get patches >>> into OVS patchwork? We've moved around our mailing lists a bit (from >>> our own

Re: [ovs-dev] [PATCH v4] ofproto-dpif: Make ofproto/trace output easier to read.

into. It will be null if the > - * resubmit or OFPP_TABLE action didn't find a matching rule. > - * > - * 'indentation' is the resubmit recursion depth at time of invocation, > - * suitable for indenting the output. > - * > - * This is normally null so the c

Re: [ovs-dev] [PATCH v4] ofproto-dpif: Make ofproto/trace output easier to read.

> On Jan 12, 2017, at 9:23 AM, Ben Pfaff <b...@ovn.org> wrote: > > On Mon, Jan 09, 2017 at 08:46:28PM -0800, Justin Pettit wrote: >> I think it would be helpful to have a comment describing this >> function. Also mentioning that the caller maintains ownership of >

Re: [ovs-dev] [PATCH] ovs-vtep: vtep-ctl and ovs-vtep support of adding explicit tunnel key

> On Oct 27, 2016, at 8:12 AM, itamaro wrote: > > From: itamarofek Sorry for the delay. I had a bunch of suggested changes in my drafts folder and apparently never hit send. The previous patches had version numbers. I assume this is v5. Can

Re: [ovs-dev] [PATCH 9/9] ovn.at: Rewrite a test using ovn-controller 'inject-pkt' command.

> On Jan 5, 2017, at 7:48 AM, Ben Pfaff <b...@ovn.org> wrote: > > On Wed, Jan 04, 2017 at 06:13:11PM -0800, Justin Pettit wrote: >> Provide an example of using ovn-controller 'inject-pkt' and ovn-test >> 'expr-to-packets' commands to generate and verify proper han

[ovs-dev] [PATCH 2/9] ovn-controller: Expose address sets to the main loop.

Other functions in the main loop will need access to address sets in a future commit. Signed-off-by: Justin Pettit <jpet...@ovn.org> --- ovn/controller/lflow.c | 41 ++--- ovn/controller/lflow.h | 1 + ovn/controller/ovn-controller.

[ovs-dev] [PATCH 1/9] expr: Rename "macros" to "addr_sets".

Macro is a very generic term, but the arguments are only ever address sets, so rename for clarity. Signed-off-by: Justin Pettit <jpet...@ovn.org> --- include/ovn/expr.h| 18 +- ovn/controller/lflow.c| 7 ++-- ovn/lib/expr.c

[ovs-dev] [PATCH 7/9] ovn-controller: Introduce "inject-pkt" ovs-appctl command.

Add the ability to inject a packet into the connected Open vSwitch instance. This is primarily useful for testing when a test requires side-effects from an actual packet, so ovn-trace won't do. Signed-off-by: Justin Pettit <jpet...@ovn.org> --- NEWS| 2

[ovs-dev] [PATCH 9/9] ovn.at: Rewrite a test using ovn-controller 'inject-pkt' command.

Provide an example of using ovn-controller 'inject-pkt' and ovn-test 'expr-to-packets' commands to generate and verify proper handling of packets. Tests written in this way should be easier to understand than raw packets written in hexadecimal. Signed-off-by: Justin Pettit <jpet...@ovn.

Re: [ovs-dev] [PATCH v3 1/3] ofproto-dpif: Unhide structure contents.

prototypes in a > sensible way. > > Signed-off-by: Ben Pfaff <b...@ovn.org> > Acked-by: Lance Richardson <lrich...@redhat.com> Acked-by: Justin Pettit <jpet...@ovn.org> --Justin ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 2/2] ofctrl: Fix warning from sparse.

> On Jan 5, 2017, at 5:03 PM, Ben Pfaff <b...@ovn.org> wrote: > > We've used sparse "bitwise" annotations to make ofp_ports into a different > type, so this is required to avoid a sparse warning. > > CC: Justin Pettit <jpet...@ovn.org> > Fixes: 71465

Re: [ovs-dev] [PATCH v3 0/2] Clearly relate OVN and OpenFlow flows.

Yep, I'd be happy to. --Justin > On Dec 20, 2016, at 2:44 PM, Ben Pfaff wrote: > > Justin, I'd like to get this feature into OVS 2.7. Will you review > these patches? > > Thanks, > > Ben. > > On Tue, Dec 20, 2016 at 08:07:49AM -0800, Ben Pfaff wrote: >> v1->v2: >> - Patch 1

[ovs-dev] [PATCH] ofproto-dpif-upcall: Remove OVS_UNUSED from upcall_unixctl_set_flow_limit() arg.

The 'argv' argument is used. Signed-off-by: Justin Pettit <jpet...@ovn.org> --- ofproto/ofproto-dpif-upcall.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ofproto/ofproto-dpif-upcall.c b/ofproto/ofproto-dpif-upcall.c index df12882..32c7730 100644 --- a/ofproto/ofprot

[ovs-dev] [PATCH] ovn-trace: Fix small error condition memory leak in trace().

Signed-off-by: Justin Pettit <jpet...@ovn.org> --- ovn/utilities/ovn-trace.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ovn/utilities/ovn-trace.c b/ovn/utilities/ovn-trace.c index 71798f8..6d8e514 100644 --- a/ovn/utilities/ovn-trace.c +++ b/ovn/utilities/ovn-t

Re: [ovs-dev] [PATCH] rconn: Avoid abort for ill-behaved remote.

t the sandbox.) > > Reported-by: 张东亚 <fortitude.zh...@gmail.com> > Signed-off-by: Ben Pfaff <b...@ovn.org> Acked-by: Justin Pettit <jpet...@ovn.org> --Justin ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] tests: Fix race in "ovn -- vtep: 3 HVs, 1 VIFs/HV, 1 GW, 1 LS".

nvswitch=mipsel=2.6.2%7Epre%2Bgit20161223-1=1482523419=log > Signed-off-by: Ben Pfaff <b...@ovn.org> Acked-by: Justin Pettit <jpet...@ovn.org> --Justin ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] debian: Also restrict ovn-docker package to Linux.

em. > > (Perhaps OVS packaging for Debian should also support BSD, but that > would be a bigger change.) > > Reported-at: > https://buildd.debian.org/status/fetch.php?pkg=openvswitch=kfreebsd-amd64=2.6.2%7Epre%2Bgit20161223-1=1482518318=log > Signed-off-by: Ben Pfaff <

Re: [ovs-dev] [PATCH v4 2/2] ovn-trace: New --ovs option to also print OpenFlow flows.

s->ofpacts_len); > +n_fses++; > + } > +ofpbuf_uninit(); > +ofpbuf_delete(reply); > + > +if (error) { > +for (size_t i = 0; i < n_fses; i++) { > +free(CONST_CAST(struct ofpact *, fses[i].ofpacts)); > +} > +free(fses); > + > +fses = NULL; > +n_fses = 0; > +} > + > +exit: > +*fsesp = fses; > +*n_fsesp = n_fses; > +return error; > +} Acked-by: Justin Pettit <jpet...@ovn.org> --Justin ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v4 1/2] ovn-controller: Tie OpenFlow and logical flows using OpenFlow cookie.

o it may be worth noting here and in the documentation that if there are multiple datapaths with the same name, it will only choose one at random. > static void > cmd_lflow_list(struct ctl_context *ctx) > { I'd think it would be helpful to provide an option to print the first 32-bits of the

Re: [ovs-dev] [PATCH] ovn-trace: Fix small error condition memory leak in trace().

> On Dec 21, 2016, at 2:12 PM, Ben Pfaff <b...@ovn.org> wrote: > > On Wed, Dec 21, 2016 at 02:04:32PM -0800, Justin Pettit wrote: >> Signed-off-by: Justin Pettit <jpet...@ovn.org> >> --- >> ovn/utilities/ovn-trace.c | 4 +++- >> 1 file changed, 3 i

Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: Remove OVS_UNUSED from upcall_unixctl_set_flow_limit() arg.

> On Dec 21, 2016, at 4:06 PM, Joe Stringer <j...@ovn.org> wrote: > > On 21 December 2016 at 14:03, Justin Pettit <jpet...@ovn.org> wrote: >> The 'argv' argument is used. >> >> Signed-off-by: Justin Pettit <jpet...@ovn.org> > > Acked

Re: [ovs-dev] [PATCH 3/3] ofproto-dpif-xlate.c: Include controller traffic for NetFlow.

> On Mar 23, 2017, at 10:03 AM, Jarno Rajahalme <ja...@ovn.org> wrote: > > >> On Mar 22, 2017, at 11:26 PM, Justin Pettit <jpet...@ovn.org> wrote: >> >> The code previously did not include packets forwarded to the controller >> in N

[ovs-dev] [PATCH 2/3] ofproto-dpif-rid: Update comment for recirc_alloc_id__().

The hash is not recomputed if it is passed in as 0. Signed-off-by: Justin Pettit <jpet...@ovn.org> --- ofproto/ofproto-dpif-rid.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/ofproto/ofproto-dpif-rid.c b/ofproto/ofproto-dpif-rid.c index d27669ef1f68..9381dee61404

[ovs-dev] [PATCH 1/3] ofproto-dpif: Update handle_action() comment.

The comment didn't mention the SLOW_LLDP and SLOW_ACTION reasons. Signed-off-by: Justin Pettit <jpet...@ovn.org> --- ofproto/ofproto-dpif-upcall.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/ofproto/ofproto-dpif-upcall.c b/ofproto/ofproto-dpif-upcall.c

[ovs-dev] [PATCH 3/3] ofproto-dpif-xlate.c: Include controller traffic for NetFlow.

-by: Justin Pettit <jpet...@ovn.org> --- ofproto/ofproto-dpif-xlate.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofproto-dpif-xlate.c index 7df92e58dcf5..6b7a4fe51072 100644 --- a/ofproto/ofproto-dpif-xlate.c +++ b/ofproto/ofprot

Re: [ovs-dev] [PATCH] ovs-fields.7: Use a more general approach to groff encodings.

> On Jan 26, 2017, at 10:26 AM, Ben Pfaff wrote: > > It turns out that, since groff 1.20 around 2009, groff comes with a > preprocessor named "preconv" that can fix encoding issues. Use it instead > of the existing hack. Geez, you didn't know that? Where've you been? > ---

Re: [ovs-dev] [branch-2.7] Set release date for 2.7.0.

> On Feb 24, 2017, at 4:32 AM, Flavio Leitner wrote: > > > Hi, > > We pushed 2.7 through our testing and found no issues. Thank you for doing that! I hope to release today. Jarno is just checking the supported kernel versions, and then we'll send it out. --Justin

Re: [ovs-dev] [PATCH] ofproto-dpif-rid: Don't include action_set_len as part of hash.

> On Jul 28, 2017, at 9:29 AM, Ben Pfaff <b...@ovn.org> wrote: > > On Thu, Jul 27, 2017 at 07:15:33PM -0700, Justin Pettit wrote: >> It doesn't improve the hashing, since the number of bytes hashed is >> included in hash_bytes64() hash calculation. >> >

Re: [ovs-dev] [PATCHv2] ofproto-dpif: Mark packets as "untracked" after call to ct().

. Thanks! --Justin > On Aug 10, 2017, at 11:38 PM, Justin Pettit <jpet...@ovn.org> wrote: > > Packet and Connection state is only available to the processing path > that follows the "recirc_table" argument of the ct() action. The > previous behavior made the

[ovs-dev] [PATCHv2] ofproto-dpif: Mark packets as "untracked" after call to ct().

ction tracking state makes that difficult due to datapath actions containing multiple OpenFlow rules that may contain different connection tracking states. This change will make that future commit possible. Signed-off-by: Justin Pettit <jpet...@ovn.org> --- v1->v2: Fix system

Re: [ovs-dev] [PATCH] ofproto-dpif: Mark packets as "untracked" after call to ct().

> > -Original Message- > From: Darrell Ball <db...@vmware.com> > Date: Tuesday, August 8, 2017 at 5:51 PM > To: Justin Pettit <jpettit@gmail.com> > Cc: Justin Pettit <jpet...@ovn.org>, "d...@openvswitch.org" > <d...@openvswitch.org

Re: [ovs-dev] OVS 2.9 Intel Roadmap

> On Aug 11, 2017, at 8:54 AM, Stokes, Ian wrote: > > Below are the features that Intel are planning to submit for the OVS 2.9 > release. > > I've also created a google spreadsheet so that people can contribute their > own planned features. This can be found at: > >

Re: [ovs-dev] [PATCH] nx-match: Don't append "ct_nw_proto" nx_match if mask not set.

> On Jul 12, 2017, at 7:13 PM, Ben Pfaff <b...@ovn.org> wrote: > > On Wed, Jul 12, 2017 at 07:04:26PM -0700, Justin Pettit wrote: >> >>> On Jul 12, 2017, at 5:42 PM, Ben Pfaff <b...@ovn.org> wrote: >>> >>> On Wed, Jul 12, 2017 at 03

[ovs-dev] [PATCH 1/3] ofproto-dpif-rid: Include action length as part of hash.

Signed-off-by: Justin Pettit <jpet...@ovn.org> --- ofproto/ofproto-dpif-rid.c | 1 + 1 file changed, 1 insertion(+) diff --git a/ofproto/ofproto-dpif-rid.c b/ofproto/ofproto-dpif-rid.c index d546b150b938..26c2357007b2 100644 --- a/ofproto/ofproto-dpif-rid.c +++ b/ofproto/ofproto-dpif

[ovs-dev] [PATCH 3/3] ofproto-dpif-rid: Always store tunnel metadata.

such a circumstance. This changes the behavior to always copy the tunnel metadata, regardless of whether the tunnel destination is set. It also adds a unit test. Signed-off-by: Justin Pettit <jpet...@ovn.org> --- ofproto/ofproto-dpif-rid.c | 17 +++-- ofproto/ofproto-dpif-rid.

[ovs-dev] [PATCH 2/3] ofproto-dpif-rid: Store tunnel metadata in frozen metadata directly.

ot;frozen_metadata" instead of accessing it through a pointer. Signed-off-by: Justin Pettit <jpet...@ovn.org> --- ofproto/ofproto-dpif-rid.c | 26 +++--- ofproto/ofproto-dpif-rid.h | 13 + 2 files changed, 16 insertions(+), 23 deletions(-) diff --git a/ofpr

[ovs-dev] [PATCH] ofproto-dpif-xlate: Fixes for propagating state of conntrack.

The "ct" action is not supposed to make the various ct match fields available except for the pipeline instantiated through the "table" argument to the "ct" action. This commit fixes a few issues related to that and updates the tests appropriately. Signed-off-by:

Re: [ovs-dev] [PATCH] OpenFlow: Add support for "group delete" flow removed reason to 1.3.

> On Jul 16, 2017, at 10:59 AM, Ben Pfaff <b...@ovn.org> wrote: > > On Sat, Jul 15, 2017 at 04:52:54PM -0700, Justin Pettit wrote: >> Signed-off-by: Justin Pettit <jpet...@ovn.org> > > I'll assume the tests pass. Thank you! Best way to find out: pushed to

Re: [ovs-dev] [PATCH] acinclude.m4: Avoid error from printf.

cho -n") > Signed-off-by: Ben Pfaff <b...@ovn.org> Acked-by: Justin Pettit <jpet...@ovn.org> --Justin ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] connmgr: Fix crash when in_band_create() fails.

d-by: Numan Siddique <nusid...@redhat.com> > Reported-at: > https://mail.openvswitch.org/pipermail/ovs-dev/2017-July/335530.html > Signed-off-by: Ben Pfaff <b...@ovn.org> Acked-by: Justin Pettit <jpet...@ovn.org> --Justin _

Re: [ovs-dev] [PATCH] Revert "netdev: Fix netdev_open() to adhere to class type if given"

> On Jul 17, 2017, at 7:49 AM, Eelco Chaudron wrote: > > On 17/07/17 11:10, Numan Siddique wrote: >> >> >> On Mon, Jul 17, 2017 at 1:10 PM, Eelco Chaudron > > wrote: >> >>Assuming we can get the patch in before the

[ovs-dev] [PATCH] dpif-netdev: Initialize 'tun_md' member of match.

Found by valgrind. --- lib/dpif-netdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c index 6bae4acd0dd9..bf923fa9bee8 100644 --- a/lib/dpif-netdev.c +++ b/lib/dpif-netdev.c @@ -2430,6 +2430,7 @@ dp_netdev_flow_add(struct dp_netdev_pmd_thread *pmd,

[ovs-dev] [PATCH] gitignore: Ignore some generated files.

"ovn-docker-overlay-driver", "ovn-docker-underlay-driver", and "ovs-vtep" are generated, so they should be ignored. Signed-off-by: Justin Pettit <jpet...@ovn.org> --- ovn/utilities/.gitignore | 2 ++ vtep/.gitignore | 1 + 2 files changed, 3 inser

[ovs-dev] [PATCH] vlog: Make "vlog/set" without args set everything to "dbg".

The documentation stated that "ovs-appctl vlog/set" without any arguments should set every module and destination to debug level. Signed-off-by: Justin Pettit <jpet...@ovn.org> --- lib/vlog.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/lib/vlog.c b/

Re: [ovs-dev] [PATCH] treewide: .gitignore updates

> On Jun 30, 2017, at 7:28 AM, Lance Richardson wrote: > > Signed-off-by: Lance Richardson > --- > ovn/utilities/.gitignore | 2 ++ > tests/.gitignore | 2 ++ > vtep/.gitignore | 1 + > 3 files changed, 5 insertions(+) Thanks, Lance. I

Re: [ovs-dev] [PATCH] gitignore: Ignore some generated files.

> On Jul 10, 2017, at 5:03 AM, Lance Richardson wrote: > > Hi Justin, > > I posted a similar patch recently: > > https://patchwork.ozlabs.org/patch/782880/ > > It ignores these as well as some valgrind output files. Sorry I missed that. I merged your patch into

Re: [ovs-dev] [PATCH v1] docs: Use DPDK 16.11.2 stable release.

> On Jul 6, 2017, at 2:11 AM, Stokes, Ian wrote: > >> Great. I've pushed it to "branch-2.7" and it will be part of the 2.7.1 >> release, which I plan to release shortly. >> >> Since the master branch still references 16.11.1, I'd think you'd also >> like to apply this

Re: [ovs-dev] [PATCH] nx-match: Don't append "ct_nw_proto" nx_match if mask not set.

> On Jul 12, 2017, at 5:42 PM, Ben Pfaff <b...@ovn.org> wrote: > > On Wed, Jul 12, 2017 at 03:47:07PM -0700, Justin Pettit wrote: >> The function nx_put_raw() shouldn't append "ct_nw_proto" to nx_match if >> the corresponding mask isn't set. >> >&

Re: [ovs-dev] [PATCH] Revert "netdev: Fix netdev_open() to adhere to class type if given"

> On Jul 17, 2017, at 8:51 PM, Guru Shetty <g...@ovn.org> wrote: > > >> >> On 17 July 2017 at 12:51, Justin Pettit <jpet...@ovn.org> wrote: >> >> > On Jul 17, 2017, at 7:49 AM, Eelco Chaudron <echau...@redhat.com> wr

Re: [ovs-dev] [PATCH] Revert "netdev: Fix netdev_open() to adhere to class type if given"

> On Jul 17, 2017, at 10:06 PM, Numan Siddique <nusid...@redhat.com> wrote: > > On Tue, Jul 18, 2017 at 9:42 AM, Justin Pettit <jpet...@ovn.org> wrote: > > > On Jul 17, 2017, at 8:51 PM, Guru Shetty <g...@ovn.org> wrote: > > > > > >> >

[ovs-dev] [PATCH] ofproto.at: Fix minor typo in test.

Signed-off-by: Justin Pettit <jpet...@ovn.org> --- tests/ofproto.at | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/ofproto.at b/tests/ofproto.at index 9e6acfad653d..c7ea31a77ce9 100644 --- a/tests/ofproto.at +++ b/tests/ofproto.at @@ -3430,7 +3430,7 @@ udp,vl

Re: [ovs-dev] [PATCH] vlog: Make "vlog/set" without args set everything to "dbg".

> On Jul 14, 2017, at 12:58 PM, Ben Pfaff <b...@ovn.org> wrote: > > On Sun, Jul 09, 2017 at 11:51:41PM -0700, Justin Pettit wrote: >> The documentation stated that "ovs-appctl vlog/set" without any >> arguments should set every module and destination to debu

Re: [ovs-dev] [PATCH] dpif-netdev: Initialize 'tun_md' member of match.

> On Jul 14, 2017, at 12:57 PM, Ben Pfaff <b...@ovn.org> wrote: > > On Sun, Jul 09, 2017 at 11:51:38PM -0700, Justin Pettit wrote: >> Found by valgrind. > > Acked-by: Ben Pfaff <b...@ovn.org> Thanks. I pushed this to master. --Justin __

Re: [ovs-dev] [PATCH 2/2] dpif-netdev: Indicate support for various ct features.

> On Jul 19, 2017, at 3:18 PM, Darrell Ball wrote: > > I could not see any; it is good the impact from this hybrid support thing > was limited > to debug o/p then. > I don't see any new issues from this patch addition, and it is the only > reasonable > option for

Re: [ovs-dev] [PATCH] Revert "netdev: Fix netdev_open() to adhere to class type if given"

> On Jul 18, 2017, at 4:15 AM, Eelco Chaudron <echau...@redhat.com> wrote: > > On 18/07/17 08:28, Justin Pettit wrote: >>> On Jul 17, 2017, at 10:06 PM, Numan Siddique <nusid...@redhat.com> wrote: >>> >>> On Tue, Jul 18, 2017 at 9:42 AM, Justin

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Fixes for propagating state of conntrack.

> On Jul 18, 2017, at 4:27 PM, Joe Stringer <j...@ovn.org> wrote: > > On 13 July 2017 at 23:42, Justin Pettit <jpet...@ovn.org> wrote: >> The "ct" action is not supposed to make the various ct match fields >> available except for the pipeline i

[ovs-dev] [PATCH 1/2] Set release date for 2.7.2.

Signed-off-by: Justin Pettit <jpet...@ovn.org> --- NEWS | 4 ++-- debian/changelog | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/NEWS b/NEWS index 6f0768b2657f..eb691dbc3251 100644 --- a/NEWS +++ b/NEWS @@ -1,6 +1,6 @@ -v2.7.2 - xx xxx +v2.7.2 -

[ovs-dev] [PATCH 2/2] Prepare for 2.7.3.

Signed-off-by: Justin Pettit <jpet...@ovn.org> --- NEWS | 4 configure.ac | 2 +- debian/changelog | 7 +++ 3 files changed, 12 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index eb691dbc3251..3ceb55f4c623 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,7 @@ +

Re: [ovs-dev] [PATCH 1/2] Set release date for 2.7.2.

> On Jul 18, 2017, at 4:44 PM, Joe Stringer <j...@ovn.org> wrote: > > On 18 July 2017 at 16:29, Justin Pettit <jpet...@ovn.org> wrote: >> Signed-off-by: Justin Pettit <jpet...@ovn.org> > > Acked-by: Joe Stringer <j...@ovn.org> Tha

[ovs-dev] [PATCH 2/2] dpif-netdev: Indicate support for various ct features.

The userspace datapath hardcodes support for the features it supports, but it was missing "ct_state_nat", "ct_orig_tuple", and "ct_orig_tuple6". Signed-off-by: Justin Pettit <jpet...@ovn.org> --- lib/dpif-netdev.c | 3 +++ 1 file changed, 3 insertions(+)

Re: [ovs-dev] [PATCH 1/2] Set release date for 2.7.2.

> On Jul 18, 2017, at 9:43 PM, Numan Siddique <nusid...@redhat.com> wrote: > > > > On Wed, Jul 19, 2017 at 5:37 AM, Justin Pettit <jpet...@ovn.org> wrote: > > > On Jul 18, 2017, at 4:44 PM, Joe Stringer <j...@ovn.org> wrote: > > > > On

Re: [ovs-dev] [PATCH] ofproto.at: Fix minor typo in test.

> On Jul 14, 2017, at 12:59 PM, Ben Pfaff <b...@ovn.org> wrote: > > On Sun, Jul 09, 2017 at 11:51:40PM -0700, Justin Pettit wrote: >> Signed-off-by: Justin Pettit <jpet...@ovn.org> >> --- >> tests/ofproto.at | 2 +- >> 1 file changed, 1 insertio

Re: [ovs-dev] [PATCH] ofproto.at: Fix minor typo in test.

> On Jul 15, 2017, at 3:21 PM, Ben Pfaff <b...@ovn.org> wrote: > > On Sat, Jul 15, 2017 at 03:02:18PM -0700, Justin Pettit wrote: >> >>> On Jul 14, 2017, at 12:59 PM, Ben Pfaff <b...@ovn.org> wrote: >>> >>> On Sun, Jul 09, 2017 at

[ovs-dev] [PATCH] OpenFlow: Add support for "group delete" flow removed reason to 1.3.

Signed-off-by: Justin Pettit <jpet...@ovn.org> --- Documentation/topics/design.rst| 2 +- include/openflow/openflow-common.h | 6 -- lib/ofp-util.c | 18 -- tests/ofproto.at | 14 +++--- 4 files changed, 24 insertions(

Re: [ovs-dev] Revisit OVN meeting schedule?

> On Jul 26, 2017, at 8:07 AM, Russell Bryant wrote: > > It has been difficult for some of our newer contributors in Europe to > make our weekly OVN IRC meeting, so I wanted to revisit the schedule. > Roughly we have 2 options to consider: > > 1) Change the time to accommodate

Re: [ovs-dev] [PATCH 2/2] travis: Fail the build if any of the Linux build preparations fail.

previous commit originated. > > (osx-prepare.sh already does the right thing.) > > Signed-off-by: Ben Pfaff <b...@ovn.org> Acked-by: Justin Pettit <jpet...@ovn.org> --Justin ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] ovn: Add support for ACL logging.

> On Jul 27, 2017, at 4:03 PM, Han Zhou <zhou...@gmail.com> wrote: > > > > On Wed, Jul 26, 2017 at 1:55 PM, Justin Pettit <jpet...@ovn.org> wrote: > > > > Signed-off-by: Justin Pettit <jpet...@ovn.org> > > --- > > NEWS

[ovs-dev] [PATCH] netlink: Correct comment for nl_msg_put_unspec().

Signed-off-by: Justin Pettit <jpet...@ovn.org> --- lib/netlink.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/netlink.c b/lib/netlink.c index 4cf1aaca621c..de3ebcd0e792 100644 --- a/lib/netlink.c +++ b/lib/netlink.c @@ -235,8 +235,7 @@ nl_msg_put_unspec_zero(

Re: [ovs-dev] [PATCH 2/3] ofproto-dpif-rid: Store tunnel metadata in frozen metadata directly.

> On Jul 27, 2017, at 10:27 PM, Ben Pfaff <b...@ovn.org> wrote: > > On Thu, Jul 27, 2017 at 07:26:49PM -0700, Justin Pettit wrote: >> >>> On Jul 27, 2017, at 4:24 PM, Ben Pfaff <b...@ovn.org> wrote: >>> >>> On Thu, Jul 13, 2017 at 11:30

[ovs-dev] [PATCH] ovn: Add support for ACL logging.

Signed-off-by: Justin Pettit <jpet...@ovn.org> --- NEWS| 1 + include/ovn/actions.h | 67 --- ovn/controller/ovn-controller.8.xml | 9 +++ ovn/controller/pinctrl.c| 38 +++ ovn/lib/act

[ovs-dev] [PATCH 1/2] odp-util: Document size of OVS_KEY_ATTR_CT_ORIG_TUPLE_IPV4.

This attribute shares space with OVS_KEY_ATTR_CT_ORIG_TUPLE_IPV6, but it's still worth documenting. Signed-off-by: Justin Pettit <jpet...@ovn.org> --- lib/odp-util.h | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/odp-util.h b/lib/odp-util.h index f49aaa8160d9..9d4e224a747e

Re: [ovs-dev] [PATCH 1/2] odp-util: Document size of OVS_KEY_ATTR_CT_ORIG_TUPLE_IPV4.

> On Jul 19, 2017, at 10:58 AM, Joe Stringer <j...@ovn.org> wrote: > > On 18 July 2017 at 23:18, Justin Pettit <jpet...@ovn.org> wrote: >> This attribute shares space with OVS_KEY_ATTR_CT_ORIG_TUPLE_IPV6, but >> it's still worth documenting. >> >>

Re: [ovs-dev] [PATCH 2/2] dpif-netdev: Indicate support for various ct features.

> On Jul 19, 2017, at 10:45 AM, Darrell Ball <db...@vmware.com> wrote: > > > > On 7/19/17, 8:01 AM, "Justin Pettit" <jpet...@ovn.org> wrote: > > >> On Jul 19, 2017, at 2:45 AM, Darrell Ball <db...@vmware.com> wrote: >> >>

[ovs-dev] [PATCH] nx-match: Don't append "ct_nw_proto" nx_match if mask not set.

The function nx_put_raw() shouldn't append "ct_nw_proto" to nx_match if the corresponding mask isn't set. Signed-off-by: Justin Pettit <jpet...@ovn.org> --- lib/nx-match.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/nx-match.c b/lib/nx-match.c in

Re: [ovs-dev] [PATCH 2/2] dpif-netdev: Indicate support for various ct features.

> On Jul 19, 2017, at 2:45 AM, Darrell Ball wrote: > > This change does not seem to be all that useful. > > When rules are constructed, mask and action support do check previously > probed support > which will be ‘TRUE’. > > Another way to see that the below settings are

Re: [ovs-dev] [branch-2.7 1/2] Set release date for 2.7.1.

> On Jun 28, 2017, at 11:43 AM, Flavio Leitner <f...@redhat.com> wrote: > > On Wed, Jun 28, 2017 at 09:47:19AM -0700, Justin Pettit wrote: >> Signed-off-by: Justin Pettit <jpet...@ovn.org> >> --- > > Acked-by: Flavio Leitner <f...@sysclose.org> >

Re: [ovs-dev] [branch-2.7 1/2] Set release date for 2.7.1.

> On Jul 3, 2017, at 12:58 PM, Stokes, Ian wrote: > >>> On Jul 3, 2017, at 3:22 AM, Stokes, Ian wrote: >>> >>> I have a small documentation and travis patch that I would like to see >> get into 2.7.1. >>> >>>

Re: [ovs-dev] [branch-2.7 1/2] Set release date for 2.7.1.

> On Jul 3, 2017, at 7:56 AM, Flavio Leitner <f...@redhat.com> wrote: > > On Sat, Jul 01, 2017 at 04:34:34PM -0700, Justin Pettit wrote: >> >>> On Jun 28, 2017, at 11:43 AM, Flavio Leitner <f...@redhat.com> wrote: >>> >>> On Wed,

Re: [ovs-dev] [branch-2.7 1/2] Set release date for 2.7.1.

> On Jul 3, 2017, at 3:22 AM, Stokes, Ian wrote: > > I have a small documentation and travis patch that I would like to see get > into 2.7.1. > > https://patchwork.ozlabs.org/patch/778288/ > > It just updates the docs and travis to point to DPDK 16.11.2 instead of >

Re: [ovs-dev] [PATCHv2 1/2] ofp-parse: Fix small memory leak when calling parse_ofp_meter_mod_str().

> On Jul 5, 2017, at 4:09 PM, Ben Pfaff <b...@ovn.org> wrote: > > On Tue, Jun 27, 2017 at 06:14:43PM -0700, Justin Pettit wrote: >> The function parse_ofp_meter_mod_str() allocates a buffer called >> 'bands', which parse_ofp_meter_mod_str__() then steals for the

Re: [ovs-dev] [PATCH v1] docs: Use DPDK 16.11.2 stable release.

g >> Subject: Re: [ovs-dev] [PATCH v1] docs: Use DPDK 16.11.2 stable release. >> >> >> >>> -Original Message- >>> From: Darrell Ball [mailto:db...@vmware.com] >>> Sent: Wednesday, July 5, 2017 5:48 PM >>> To: Kavanagh, Mark B <mar

[ovs-dev] [PATCH] datapath: Fix missing "_ATTR" docstrings from some actions.

Signed-off-by: Justin Pettit <jpet...@ovn.org> --- datapath/linux/compat/include/linux/openvswitch.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/datapath/linux/compat/include/linux/openvswitch.h b/datapath/linux/compat/include/linux/openvswitch.h index 3f2970

[ovs-dev] [branch-2.7 2/2] Prepare for 2.7.2.

Signed-off-by: Justin Pettit <jpet...@ovn.org> --- NEWS | 4 configure.ac | 2 +- debian/changelog | 7 +++ 3 files changed, 12 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 5ed122ae77e7..6f0768b2657f 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,7 @@ +

[ovs-dev] [branch-2.7 1/2] Set release date for 2.7.1.

Signed-off-by: Justin Pettit <jpet...@ovn.org> --- NEWS | 3 ++- configure.ac | 2 +- debian/changelog | 12 3 files changed, 15 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index bbff66af3735..5ed122ae77e7 100644 --- a/NEWS +++ b/NEWS @@ -1,10

[ovs-dev] [branch-2.5 1/2] Set release date for 2.5.3.

Signed-off-by: Justin Pettit <jpet...@ovn.org> --- NEWS | 4 ++-- debian/changelog | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/NEWS b/NEWS index 6c1d998b3cb1..b87b03db442c 100644 --- a/NEWS +++ b/NEWS @@ -1,6 +1,6 @@ -v2.5.3 - xx xxx +v2.5.3 -

[ovs-dev] [branch-2.5 2/2] Prepare for 2.5.4.

Signed-off-by: Justin Pettit <jpet...@ovn.org> --- NEWS | 4 configure.ac | 2 +- debian/changelog | 7 +++ 3 files changed, 12 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index b87b03db442c..d2e62c169255 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,7 @@ +

  1   2   3   4   5   6   7   8   >