Signed-off-by: Justin Pettit
---
lib/dpif-netdev.c | 4 ++--
lib/nx-match.c| 5 ++---
2 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
index c0959050d47c..b07fc6b8b327 100644
--- a/lib/dpif-netdev.c
+++ b/lib/dpif-netdev.c
@@ -3536,7
Signed-off-by: Justin Pettit
---
lib/ovs-numa.c | 34 ++
lib/ovs-numa.h | 2 +-
2 files changed, 11 insertions(+), 25 deletions(-)
diff --git a/lib/ovs-numa.c b/lib/ovs-numa.c
index 98e97cb33fdd..24edeab2a8d9 100644
--- a/lib/ovs-numa.c
+++ b/lib/ovs-numa.c
Rename the remaining variables that were shadowing another definition.
Signed-off-by: Justin Pettit
---
lib/daemon-unix.c | 62 +--
lib/route-table.c | 9 ---
ofproto/ofproto-dpif-upcall.c | 50
Signed-off-by: Justin Pettit
---
configure.ac | 1 +
1 file changed, 1 insertion(+)
diff --git a/configure.ac b/configure.ac
index 84fed062cfa3..9940a1a453a0 100644
--- a/configure.ac
+++ b/configure.ac
@@ -168,6 +168,7 @@ OVS_ENABLE_OPTION([-Wbool-compare])
OVS_ENABLE_OPTION([-Wshift-negative
Signed-off-by: Justin Pettit
---
lib/db-ctl-base.c | 8
lib/db-ctl-base.h | 2 +-
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/lib/db-ctl-base.c b/lib/db-ctl-base.c
index ae7b6cde27f4..bfd7a54a8b5a 100644
--- a/lib/db-ctl-base.c
+++ b/lib/db-ctl-base.c
@@ -793,8 +793,8
> On Feb 28, 2018, at 12:50 PM, Ben Pfaff wrote:
>
> On Tue, Feb 27, 2018 at 10:52:34PM -0800, Justin Pettit wrote:
>> Signed-off-by: Justin Pettit
>
> Thanks.
>
> Acked-by: Ben Pfaff
Thanks. I pushed this to master.
--Justin
> On Feb 28, 2018, at 1:14 PM, Ben Pfaff wrote:
>
> On Wed, Feb 28, 2018 at 12:00:56AM -0800, Justin Pettit wrote:
>> Signed-off-by: Justin Pettit
>
> Why "rll"? Not an obvious name, to my eye.
My thinking was "local". *shrug*
> Thanks for fi
> On Feb 28, 2018, at 1:18 PM, Ben Pfaff wrote:
>
> Good work.
>
> It's a little confusing to see CURSOR_NAME as both a macro name and a
> macro argument name. Could you get rid of the macro entirely, e.g. like
> this? Otherwise, two different names would be nice.
>
> diff --git a/lib/cmap.h
> On Feb 28, 2018, at 1:23 PM, Ben Pfaff wrote:
>
> On Wed, Feb 28, 2018 at 12:01:03AM -0800, Justin Pettit wrote:
>> Signed-off-by: Justin Pettit
>
> I get one additional error when this is applied:
>
> ../lib/stream-ssl.c:1250:15: error: declaration shadows
> On Feb 16, 2018, at 2:54 PM, Ben Pfaff wrote:
>
> Most of the tree now uses "encode" as the verb for making an OpenFlow
> message, so adopt it here in this very old code as well.
>
> Signed-off-by: Ben Pfaff
Acked-
> On Mar 5, 2018, at 4:09 PM, Ben Pfaff wrote:
>
> On Mon, Mar 05, 2018 at 03:04:01PM -0800, Ashish Varma wrote:
>> Added check for NULL pointer on return from xlate_lookup_ofproto
>> function. Access to "ofproto" variable when NULL was causing segmentation
>> fault.
>>
>> VMware-BZ: #2061914
>
> On Feb 20, 2018, at 1:16 AM, Justin Pettit wrote:
>
>> On Feb 19, 2018, at 4:30 PM, Pravin Shelar wrote:
>>
>> On Mon, Feb 19, 2018 at 3:23 PM, Justin Pettit wrote:
>>>
>>>> On Feb 19, 2018, at 9:50 AM, Justin Pettit wrote:
>>>>
> On May 26, 2017, at 3:51 PM, Ben Pfaff wrote:
>
> Found by Coverity.
>
> Reported-at:
> https://scan3.coverity.com/reports.htm#v16889/p10449/fileInstanceId=14762915&defectInstanceId=4305352&mergedDefectId=180430
> Signed-off-by: Ben Pfaff
Acked
Signed-off-by: Ben Pfaff
Acked-by: Justin Pettit
--Justin
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
180413&fileStart=251&fileEnd=269
> Signed-off-by: Ben Pfaff
Acked-by: Justin Pettit
--Justin
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
> On May 26, 2017, at 4:11 PM, Ben Pfaff wrote:
>
> Found by Coverity.
>
> Reported-at:
> https://scan3.coverity.com/reports.htm#v16889/p10449/fileInstanceId=14763131&defectInstanceId=4305313&mergedDefectId=180411
> Signed-off-by: Ben Pfaff
Acked
305332&mergedDefectId=180408
> Signed-off-by: Ben Pfaff
Acked-by: Justin Pettit
--Justin
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
> On May 26, 2017, at 4:20 PM, Ben Pfaff wrote:
>
> Found by Coverity.
>
> Reported-at:
> https://scan3.coverity.com/reports.htm#v16889/p10449/fileInstanceId=14763031&defectInstanceId=4305318&mergedDefectId=180399
> Signed-off-by: Ben Pfaff
Acked
> On May 26, 2017, at 4:25 PM, Ben Pfaff wrote:
>
> Found by Coverity.
>
> Reported-by:
> https://scan3.coverity.com/reports.htm#v16889/p10449/fileInstanceId=14762655&defectInstanceId=4305334&mergedDefectId=180394
> Signed-off-by: Ben Pfaff
Acked
) {
> +for (int i = 0; i < 2; i++) {
> hash = hash_add64(hash, a[i] ^ b[i]);
Do you think it's worth adding a comment or using sizeof? It probably won't
get reverted, but I think most people think about these being "four".
Acked-by: Jus
of the other uses of print_table_instruction_features() appear to have
> the same problem.
>
> Found by Coverity.
>
> Reported-at:
> https://scan3.coverity.com/reports.htm#v16889/p10449/fileInstanceId=14762675&defectInstanceId=4305296&mergedDefectId=179859
> Signed-off-
'i' instead of 'j'. This fixes the problem.
>
> Found by Coverity.
>
> Reported-at:
> https://scan3.coverity.com/reports.htm#v16889/p10449/fileInstanceId=14762827&defectInstanceId=4305351&mergedDefectId=180429
&g
> On May 26, 2017, at 8:30 PM, Ben Pfaff wrote:
>
> Found by Coverity.
>
> Reported-at:
> https://scan3.coverity.com/reports.htm#v16889/p10449/fileInstanceId=14762682&defectInstanceId=4304823&mergedDefectId=180423
> Signed-off-by: Ben Pfaff
Acked
;
> Found by Coverity.
>
> Reported-at:
> https://scan3.coverity.com/reports.htm#v16889/p10449/fileInstanceId=14762682&defectInstanceId=4304822&mergedDefectId=180422
> Signed-off-by: Ben Pfaff
Acked-by: Justin Pettit
--Justin
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
83&defectInstanceId=4305289&mergedDefectId=179850
> Signed-off-by: Ben Pfaff
Acked-by: Justin Pettit
--Justin
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
> https://scan3.coverity.com/reports.htm#v16889/p10449/fileInstanceId=14763064&defectInstanceId=4305294&mergedDefectId=179852
> Signed-off-by: Ben Pfaff
Acked-by: Justin Pettit
--Justin
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
This commit fixes the problem.
>
> No actual error types used in OVS or OpenFlow have bit 15 set, so this
> does not fix a user-visible problem.
>
> Found by Coverity.
>
> Reported-at:
> https://scan3.coverity.com/reports.htm#v16889/p10449/fileInstanceId=14762955
449/fileInstanceId=14763098&defectInstanceId=4304031&mergedDefectId=68209
> Signed-off-by: Ben Pfaff
Acked-by: Justin Pettit
--Justin
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
blems.
>
> Found by Coverity.
>
> CC: Romain Lenglet
> Reported-at:
> https://scan3.coverity.com/reports.htm#v16889/p10449/fileInstanceId=14762995&defectInstanceId=4304799&mergedDefectId=180398
> Signed-off-by: Ben Pfaff
Acked-by: Justin Pettit
Thanks for
> On Jun 1, 2017, at 4:48 PM, Ben Pfaff wrote:
>
>> On Thu, Jun 01, 2017 at 04:18:40PM -0700, Justin Pettit wrote:
>>
>>> On May 26, 2017, at 4:46 PM, Ben Pfaff wrote:
>>>
>>> IPv6 addresses have 2 64-bit parts, but this code thought they have 4.
> On Jul 26, 2017, at 8:07 AM, Russell Bryant wrote:
>
> It has been difficult for some of our newer contributors in Europe to
> make our weekly OVN IRC meeting, so I wanted to revisit the schedule.
> Roughly we have 2 options to consider:
>
> 1) Change the time to accommodate more contributors
Signed-off-by: Justin Pettit
---
lib/netlink.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/lib/netlink.c b/lib/netlink.c
index 4cf1aaca621c..de3ebcd0e792 100644
--- a/lib/netlink.c
+++ b/lib/netlink.c
@@ -235,8 +235,7 @@ nl_msg_put_unspec_zero(struct ofpbuf *msg
> On Jul 27, 2017, at 1:54 PM, Ben Pfaff wrote:
>
> On Thu, Jul 13, 2017 at 11:30:49PM -0700, Justin Pettit wrote:
>> Signed-off-by: Justin Pettit
>> ---
>> ofproto/ofproto-dpif-rid.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/ofpr
> On Jul 27, 2017, at 2:11 PM, Joe Stringer wrote:
>
> On 27 July 2017 at 13:15, Justin Pettit wrote:
>> Signed-off-by: Justin Pettit
>> ---
>
> Acked-by: Joe Stringer
Thanks. Pushed to master.
--Justin
___
Pfaff
Thanks for fixing this!
Acked-by: Justin Pettit
--Justin
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
mmit originated.
>
> (osx-prepare.sh already does the right thing.)
>
> Signed-off-by: Ben Pfaff
Acked-by: Justin Pettit
--Justin
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
> On Jul 27, 2017, at 4:17 PM, Ben Pfaff wrote:
>
> On Thu, Jul 27, 2017 at 02:05:22PM -0700, Justin Pettit wrote:
>>
>>> On Jul 27, 2017, at 1:54 PM, Ben Pfaff wrote:
>>>
>>> On Thu, Jul 13, 2017 at 11:30:49PM -0700, Justin Petti
> On Jul 27, 2017, at 4:03 PM, Han Zhou wrote:
>
>
>
> On Wed, Jul 26, 2017 at 1:55 PM, Justin Pettit wrote:
> >
> > Signed-off-by: Justin Pettit
> > ---
> > NEWS| 1 +
> > include/ovn/actions.h
It doesn't improve the hashing, since the number of bytes hashed is
included in hash_bytes64() hash calculation.
Signed-off-by: Justin Pettit
---
ofproto/ofproto-dpif-rid.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/ofproto/ofproto-dpif-rid.c b/ofproto/ofproto-dpif-rid.c
> On Jul 27, 2017, at 4:24 PM, Ben Pfaff wrote:
>
> On Thu, Jul 13, 2017 at 11:30:50PM -0700, Justin Pettit wrote:
>> "recirc_id_node" contains a 'state_metadata_tunnel' member field. The
>> "frozen_metadata" structure used by "recird_
> On Jul 27, 2017, at 4:27 PM, Ben Pfaff wrote:
>
> On Thu, Jul 13, 2017 at 11:30:51PM -0700, Justin Pettit wrote:
>> Tunnel metadata was only stored if the tunnel destination was set. It's
>> possible, for example, that a flow could set the tunnel id field before
>
> On Jul 27, 2017, at 10:27 PM, Ben Pfaff wrote:
>
> On Thu, Jul 27, 2017 at 07:26:49PM -0700, Justin Pettit wrote:
>>
>>> On Jul 27, 2017, at 4:24 PM, Ben Pfaff wrote:
>>>
>>> On Thu, Jul 13, 2017 at 11:30:50PM -0700, Justin Pett
> On Jul 28, 2017, at 9:29 AM, Ben Pfaff wrote:
>
> On Thu, Jul 27, 2017 at 07:15:33PM -0700, Justin Pettit wrote:
>> It doesn't improve the hashing, since the number of bytes hashed is
>> included in hash_bytes64() hash calculation.
>>
>> Signed-off-by: J
> On Jul 28, 2017, at 12:38 PM, Ben Pfaff wrote:
>
> On Wed, Jul 26, 2017 at 01:55:14PM -0700, Justin Pettit wrote:
>> Signed-off-by: Justin Pettit
>
> checkpatch says:
>
>WARNING: Line has non-spaces leading whitespace
>#856 FILE:
> On Jul 27, 2017, at 7:23 PM, Han Zhou wrote:
>
> On Thu, Jul 27, 2017 at 5:59 PM, Justin Pettit wrote:
>
> > > The log action may be more generic than just for ACL. So would it better
> > > to avoid hardcode "ACL" here in the message? "ACL&
Signed-off-by: Justin Pettit
Acked-by: Han Zhou
---
v1->v2: Incorporate Ben and Han's feedback.
Improve output of "ovn-nbctl acl-list".
---
NEWS| 1 +
include/ovn/actions.h | 67
ovn/controller/ov
> On Jul 28, 2017, at 4:57 PM, Ben Pfaff wrote:
>
> On Fri, Jul 28, 2017 at 03:48:38PM -0700, Justin Pettit wrote:
>> Signed-off-by: Justin Pettit
>> Acked-by: Han Zhou
>> ---
>> v1->v2: Incorporate Ben and Han's feedback.
>>Improve
look at that file, so it may not matter.
Acked-by: Justin Pettit
--Justin
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
sed by ovn-controller.
>
> Fixes: d383eed59589 ("ovn: Add support for ACL logging.")
> CC: Justin Pettit
> Suggested-by: Lance Richardson
> Signed-off-by: Numan Siddique
Thanks! I pushed this to master.
--Justin
_
> On Aug 1, 2017, at 3:00 PM, Russell Bryant wrote:
>
> Yes, my reasoning is that a time based release schedule is only
> valuable if we stick to it as closely as possible. When dates are
> reliable, more downstream advance planning can be done.
>
> If we stray too far from published dates, do
ction tracking state makes that difficult
due to datapath actions containing multiple OpenFlow rules that may
contain different connection tracking states. This change will make
that future commit possible.
Signed-off-by: Justin Pettit
---
lib/ofp-actions.c| 27 +---
in userspace system
> tests.
>
>
>
>
> -Original Message-----
> From: on behalf of Justin Pettit
>
> Date: Tuesday, August 8, 2017 at 4:12 PM
> To: "d...@openvswitch.org"
> Subject: [ovs-dev] [PATCH] ofproto-dpif: Mark packets as "untrack
t; -Original Message-
> From: Darrell Ball
> Date: Tuesday, August 8, 2017 at 5:51 PM
> To: Justin Pettit
> Cc: Justin Pettit , "d...@openvswitch.org"
>
> Subject: Re: [ovs-dev] [PATCH] ofproto-dpif: Mark packets as "untracked"
> after call to ct()
ction tracking state makes that difficult
due to datapath actions containing multiple OpenFlow rules that may
contain different connection tracking states. This change will make
that future commit possible.
Signed-off-by: Justin Pettit
---
v1->v2: Fix system tests.
---
lib/ofp-ac
it a try and let me
know if you run into any issues.
Thanks!
--Justin
> On Aug 10, 2017, at 11:38 PM, Justin Pettit wrote:
>
> Packet and Connection state is only available to the processing path
> that follows the "recirc_table" argument of the ct() action. The
>
> On Aug 11, 2017, at 8:54 AM, Stokes, Ian wrote:
>
> Below are the features that Intel are planning to submit for the OVS 2.9
> release.
>
> I've also created a google spreadsheet so that people can contribute their
> own planned features. This can be found at:
>
> https://docs.google.com/s
> On Aug 21, 2017, at 12:38 PM, Joe Stringer wrote:
>
> Overall I think that this is an improvement to consistency of what
> connection tracking metadata is accessible from different points in
> the OpenFlow pipeline. Although this will restrict the availability of
> ct_state following the ct()
This reverts commit 8294d78ab124ec6f4b51c621e9baf7f29b287bb9.
This patch was mistakenly backported to branch-2.7. The change breaks
the OpenFlow API, which is not appropriate for a maintenance release.
Signed-off-by: Justin Pettit
Reported-by: Russell Bryant
---
ofproto/ofproto-dpif-xlate.c
> On Aug 30, 2017, at 3:57 PM, Russell Bryant wrote:
>
> On Wed, Aug 30, 2017 at 6:51 PM, Justin Pettit wrote:
>> This reverts commit 8294d78ab124ec6f4b51c621e9baf7f29b287bb9.
>>
>> This patch was mistakenly backported to branch-2.7. The change breaks
>&g
Signed-off-by: Justin Pettit
---
NEWS | 5 +
1 file changed, 5 insertions(+)
diff --git a/NEWS b/NEWS
index ecb32c4df80c..0eaa64a8dfdc 100644
--- a/NEWS
+++ b/NEWS
@@ -90,6 +90,11 @@ v2.8.0 - xx xxx
* HW offloading is done through the TC interface.
- IPv6 link local addresses
This reverts commit 8473cf69d25c4682cc6f6857b86b490a8c27cbd4.
This commit introduced a change in the conntrack API. This affected
some existing applications, so we will delay introducing the change
until the next major release.
Signed-off-by: Justin Pettit
Requested-by: Flavio Leitner
- Nothing yet! Try NEWS...
I normally copy the NEWS items into here. Do you think that's unnecessary?
Acked-by: Justin Pettit
--Justin
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
> On Aug 29, 2017, at 9:13 PM, Flavio Leitner wrote:
>
> On Mon, 21 Aug 2017 12:56:33 -0700
> Justin Pettit wrote:
>
>>> On Aug 21, 2017, at 12:38 PM, Joe Stringer wrote:
>>>
>>> Overall I think that this is an improvement to consistency o
> On Aug 31, 2017, at 1:14 PM, Ben Pfaff wrote:
>
> On Thu, Aug 31, 2017 at 01:08:31PM -0700, Justin Pettit wrote:
>>
>>> On Aug 31, 2017, at 9:33 AM, Ben Pfaff wrote:
>>>
>>> Signed-off-by: Ben Pfaff
>>> ---
>>> This will be a
> On Aug 31, 2017, at 2:38 PM, Russell Bryant wrote:
>
> On Thu, Aug 31, 2017 at 4:04 PM, Justin Pettit wrote:
>> Signed-off-by: Justin Pettit
>> ---
>> NEWS | 5 +
>> 1 file changed, 5 insertions(+)
>
> Acked-by: Russell Bryant
Thanks!
> On Aug 31, 2017, at 1:18 PM, Justin Pettit wrote:
>
>>
>> On Aug 31, 2017, at 1:14 PM, Ben Pfaff wrote:
>>
>> Since you are getting that last revert in for Flavio, and you usually do
>> the releases, do you want to take over this patch, then?
>
&
Signed-off-by: Justin Pettit
---
NEWS | 4
configure.ac | 2 +-
debian/changelog | 7 +++
3 files changed, 12 insertions(+), 1 deletion(-)
diff --git a/NEWS b/NEWS
index ce503a4ea29f..4b10e81e4c27 100644
--- a/NEWS
+++ b/NEWS
@@ -1,3 +1,7 @@
+v2.8.1 - xx xxx
> On Sep 1, 2017, at 12:50 PM, Ansis Atteka wrote:
>
> Thanks for jumping in quickly and addressing all the remaining issues.
> Second series look good to me. I will back-port all 6 patches to
> branch-2.8 now. Thank you!
I see that Ansis and Alin have pushed recent changes to branch-2.8. I'm
> On Sep 1, 2017, at 6:30 PM, Alin Serdean
> wrote:
>
> [Alin Serdean] It would be nice, but not mandatory in my opinion. Most of the
> Windows users will search for a MSI rather than compiling from source.
> The following series would be nice to be added on 2.8, because that gets
> published
Signed-off-by: Justin Pettit
---
NEWS | 4
configure.ac | 2 +-
debian/changelog | 6 ++
3 files changed, 11 insertions(+), 1 deletion(-)
diff --git a/NEWS b/NEWS
index fe3c5732e501..4a45a2b41a74 100644
--- a/NEWS
+++ b/NEWS
@@ -1,3 +1,7 @@
+v2.5.5 - xx xxx
Signed-off-by: Justin Pettit
---
NEWS | 4 ++--
debian/changelog | 3 +--
2 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/NEWS b/NEWS
index d2e62c169255..fe3c5732e501 100644
--- a/NEWS
+++ b/NEWS
@@ -1,6 +1,6 @@
-v2.5.4 - xx xxx
+v2.5.4 - 03 Sep 2017
Signed-off-by: Justin Pettit
---
Documentation/faq/releases.rst | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/faq/releases.rst b/Documentation/faq/releases.rst
index 2ecc24c4d50e..c785529528e9 100644
--- a/Documentation/faq/releases.rst
+++ b/Documentation/faq/releases.rst
> On Sep 7, 2017, at 12:58 PM, Andy Zhou wrote:
>
> On Fri, Sep 1, 2017 at 11:50 AM, Justin Pettit wrote:
>> Signed-off-by: Justin Pettit
> Acked-by: Andy Zhou
Thanks. I pushed this to branch-2.8.
--Justin
___
> On Sep 7, 2017, at 10:14 AM, Ben Pfaff wrote:
>
> On Tue, Sep 05, 2017 at 10:22:47AM -0700, Justin Pettit wrote:
>> Signed-off-by: Justin Pettit
>
> Acked-by: Ben Pfaff
Thanks. I pushed this to master and branch-2.8.
--Justin
__
> On Sep 5, 2017, at 3:28 PM, Ben Pfaff wrote:
>
> On Sun, Sep 03, 2017 at 04:00:40PM -0700, Justin Pettit wrote:
>> Signed-off-by: Justin Pettit
>
> Acked-by: Ben Pfaff
Thanks. I pushed the series to branch-2.5.
--Justin
___
> On Sep 7, 2017, at 3:42 PM, Greg Rose wrote:
>
> On 09/07/2017 01:09 PM, Justin Pettit wrote:
>>> On Sep 7, 2017, at 10:14 AM, Ben Pfaff wrote:
>>>
>>> On Tue, Sep 05, 2017 at 10:22:47AM -0700, Justin Pettit wrote:
>>>> Signed-off-by: Justin
> On Sep 7, 2017, at 3:45 PM, Greg Rose wrote:
>
> On 09/07/2017 03:44 PM, Justin Pettit wrote:
>>> On Sep 7, 2017, at 3:42 PM, Greg Rose wrote:
>>>
>>> On 09/07/2017 01:09 PM, Justin Pettit wrote:
>>>>> On Sep 7, 2017, at 10:14 AM, Ben Pfaff
> On Sep 7, 2017, at 3:48 PM, Greg Rose wrote:
>
> On 09/07/2017 03:47 PM, Justin Pettit wrote:
>>> On Sep 7, 2017, at 3:45 PM, Greg Rose wrote:
>>>
>>> On 09/07/2017 03:44 PM, Justin Pettit wrote:
>>>>> On Sep 7, 2017, at 3:42 PM, Greg Rose
> On Aug 30, 2017, at 3:42 PM, Han Zhou wrote:
>
> Signed-off-by: Han Zhou
Thanks. I pushed this to master.
--Justin
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
> On Sep 8, 2017, at 11:56 AM, Han Zhou wrote:
>
> The command error message is misleading, e.g.:
>
> $ ovn-nbctl acl-del ls1 100 'outport=="lsp1" && ip4'
> ovn-nbctl: cannot specify priority without match
>
> $ ovn-nbctl acl-del ls1 to-lport 'outport=="lsp1" && ip4'
> ovn-nbctl: cannot specif
> On Sep 11, 2017, at 8:56 AM, Mark Michelson wrote:
>
> On Fri, Sep 8, 2017 at 1:57 PM Han Zhou wrote:
>
>> The command error message is misleading, e.g.:
>>
>> $ ovn-nbctl acl-del ls1 100 'outport=="lsp1" && ip4'
>> ovn-nbctl: cannot specify priority without match
>>
>> $ ovn-nbctl acl-del
the inner
OpenFlow header? It will help people like me who miss that. :-)
Acked-by: Justin Pettit
Thanks,
--Justin
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
> On Sep 21, 2017, at 9:59 AM, Ben Pfaff wrote:
>
> Found by libFuzzer.
>
> Reported-by: Bhargava Shastry
> Signed-off-by: Ben Pfaff
Acked-by: Justin Pettit
--Justin
___
dev mailing list
d...@openvswitch.org
https://ma
> On Sep 21, 2017, at 9:59 AM, Ben Pfaff wrote:
>
> Found by libFuzzer.
>
> Reported-by: Bhargava Shastry
> Signed-off-by: Ben Pfaff
Acked-by: Justin Pettit
--Justin
___
dev mailing list
d...@openvswitch.org
https://ma
AM, Ben Pfaff wrote:
>> On Fri, Sep 22, 2017 at 02:28:16PM -0700, Justin Pettit wrote:
>>>
>>>> On Sep 21, 2017, at 9:59 AM, Ben Pfaff wrote:
>>>>
>>>> Found by libFuzzer.
>>>>
>>>> Reported-by: Bhargava Shastry
>>
> On Sep 25, 2017, at 5:54 AM, Russell Bryant wrote:
>
> There's some important changes in branch-2.7. Can we do a 2.7.3
> release soon? Does anyone have anything they need addressed first?
I'm happy to do a release. I think we're due for a 2.8.1 release, too.
Ian wants a DPDK patch moved i
ox as
> well.")
> Reported-by: Justin Pettit
> Signed-off-by: Ben Pfaff
Thanks for the quick fix!
Acked-by: Justin Pettit
--Justin
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
> On Sep 25, 2017, at 11:28 AM, Darrell Ball wrote:
>
> 2.8.0 was Aug 31.
> Maybe 2.8.1 can wait a couple weeks to give time for other potential fixes?
Any particular reason? A number of serious issues have been fixed, including a
serious crashing issue from Andy.
--Justin
Signed-off-by: Justin Pettit
---
NEWS | 4 ++--
debian/changelog | 3 +--
2 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/NEWS b/NEWS
index 3ceb55f4c623..2a8cc734ae4d 100644
--- a/NEWS
+++ b/NEWS
@@ -1,6 +1,6 @@
-v2.7.3 - xx xxx
+v2.7.3 - 26 Sep 2017
Signed-off-by: Justin Pettit
---
NEWS | 4
configure.ac | 2 +-
debian/changelog | 6 ++
3 files changed, 11 insertions(+), 1 deletion(-)
diff --git a/NEWS b/NEWS
index 2a8cc734ae4d..672e712bd75d 100644
--- a/NEWS
+++ b/NEWS
@@ -1,3 +1,7 @@
+v2.7.4 - xx xxx
itted into. It will be null if the
> - * resubmit or OFPP_TABLE action didn't find a matching rule.
> - *
> - * 'indentation' is the resubmit recursion depth at time of invocation,
> - * suitable for indenting the output.
> - *
> - * This is normally null so the client has to set it manually after
> - * calling xlate_in_init(). */
> -void (*resubmit_hook)(struct xlate_in *, struct rule_dpif *rule,
> - int indentation);
> -
> -/* If nonnull, flow translation calls this function to report some
> - * significant decision, e.g. to explain why OFPP_NORMAL translation
> - * dropped a packet. 'indentation' is the resubmit recursion depth at
> time
> - * of invocation, suitable for indenting the output. */
> -void (*report_hook)(struct xlate_in *, int indentation,
> -const char *format, va_list args);
> +/* If nonnull, this indicates that the translation is being traced. It
> + * points to the list of oftrace nodes to which the translation should
> add
> + * tracing information (with oftrace_node_append()). */
> +struct ovs_list *trace;
I don't believe there is a function called oftrace_node_append(). Did you mean
oftrace_report()?
Thanks for working on this. The output is much more readable now.
Acked-by: Justin Pettit
--Justin
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
> On Jan 12, 2017, at 9:23 AM, Ben Pfaff wrote:
>
> On Mon, Jan 09, 2017 at 08:46:28PM -0800, Justin Pettit wrote:
>> I think it would be helpful to have a comment describing this
>> function. Also mentioning that the caller maintains ownership of
>> 'text&#
> On Dec 28, 2016, at 1:10 PM, Ben Pfaff wrote:
>
> From: Ben Pfaff
>
> There is still plenty of opportunity for improvement, but this new
> ovs-fields(7) manpage is much more comprehensive than ovs-ofctl(8)
> could be.
>
> Signed-off-by: Ben Pfaff
> ---
> Documentation/ref/index.rst |
> On Jan 24, 2017, at 5:11 PM, Justin Pettit wrote:
>
> This was a lot of work. Thanks for doing it!
>
> --Justin
Whoops!
Acked-by: Justin Pettit
--Justin
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/m
> On Jan 13, 2017, at 11:28 AM, Ben Pfaff wrote:
>
> Suggested-by: Justin Pettit
> Signed-off-by: Ben Pfaff
Acked-by: Justin Pettit
--Justin
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Signed-off-by: Justin Pettit
---
NEWS | 2 +-
configure.ac | 2 +-
debian/changelog | 79 +---
3 files changed, 77 insertions(+), 6 deletions(-)
diff --git a/NEWS b/NEWS
index 0a9551c..1a3787d 100644
--- a/NEWS
+++ b/NEWS
Signed-off-by: Justin Pettit
---
NEWS | 10 ---
configure.ac | 2 +-
debian/changelog | 82 ++--
3 files changed, 88 insertions(+), 6 deletions(-)
diff --git a/NEWS b/NEWS
index 6838649..5efcce2 100644
--- a/NEWS
+++ b
> On Jan 31, 2017, at 3:03 PM, Ben Pfaff wrote:
>
> Hi Justin. We branched a couple of weeks ago but at the time we forgot
> to update NEWS, etc. either on master or the branch. Usually you submit
> those patches; do you want to do the honors this time too?
Okay, I sent out patches. Normally
> On Feb 1, 2017, at 9:28 AM, Ben Pfaff wrote:
>
> On Tue, Jan 31, 2017 at 05:53:41PM -0800, Justin Pettit wrote:
>> Signed-off-by: Justin Pettit
>
> Acked-by: Ben Pfaff
Thanks. Pushed to master.
--Justin
_
> On Feb 1, 2017, at 9:27 AM, Ben Pfaff wrote:
>
> On Tue, Jan 31, 2017 at 05:47:45PM -0800, Justin Pettit wrote:
>> Signed-off-by: Justin Pettit
>
> Acked-by: Ben Pfaff
Thanks. Pushed to branch-2.7.
--Justin
_
301 - 400 of 837 matches
Mail list logo
