On Tue, Jul 4, 2023 at 9:00 PM Ilya Maximets wrote:
>
> On 6/21/23 22:36, Mike Pattrick wrote:
> > From: Flavio Leitner
> >
> > This provides a software implementation in the case
> > the egress netdev doesn't support segmentation in hardware.
> >
>
ch is sent in order to the netdev.
Signed-off-by: Flavio Leitner
Co-authored-by: Mike Pattrick
Signed-off-by: Mike Pattrick
---
v4:
- Various formatting changes
- Fixed memory leak in soft-gso code if packet is flagged
for GSO but incorrectly lacks segment size.
---
lib/automake.mk
packets are dropped.
Signed-off-by: Flavio Leitner
Co-authored-by: Mike Pattrick
Signed-off-by: Mike Pattrick
---
v3: Corrected sparse error
---
lib/dp-packet.c| 3 ++
lib/dp-packet.h| 26
lib/netdev-dpdk.c | 12 +++-
lib/netdev-linux.c | 76
over 3kb from several translation actions.
This patch also moves some trace function from do_xlate_actions into its
own function.
Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2104779
Signed-off-by: Mike Pattrick
Reviewed-by: Simon Horman
Acked-by: Eelco Chaudron
---
Since v1
On Fri, Jul 14, 2023 at 7:31 AM Ilya Maximets wrote:
>
> On 7/11/23 14:46, Eelco Chaudron wrote:
> >
> >
> > On 10 Jul 2023, at 17:34, Mike Pattrick wrote:
> >
> >> Currently OVS keeps track of which mirrors that each packet has been
> >> sent to
7;t see an echo reply even though
one has been sent.
This patch resets the mirrors every time a packet is modified, so
mirrors will recieve every copy of a packet that is sent for output.
Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2155579
Signed-off-by: Mike Pattrick
---
ofproto/of
n setup. And this patch fixed those
issues.
Acked-by: Mike Pattrick
> ---
> utilities/ovs-tcpdump.in | 4
> 1 file changed, 4 insertions(+)
> diff --git a/utilities/ovs-tcpdump.in b/utilities/ovs-tcpdump.in
> index 420c11eb8..4cbd9a5d3 100755
> --- a/utilities/ovs-tcpdump.
On Wed, Mar 1, 2023 at 10:14 AM David Marchand
wrote:
>
> Hi Mike,
>
> This patch will need some rebasing.
>
>
> On Tue, Nov 1, 2022 at 5:27 PM Mike Pattrick wrote:
> >
> > Currently a bridge mirror will collect all packets and tools like
> > ovs-tcpdump
%|2%|
netdev | 7.39 Gbps | 4.95 Gbps | 6.24 Gbps |33%| 15%|
The ratios above are the percent reduction in total throughput when
mirroring is used either with or without a filter.
Signed-off-by: Mike Pattrick
---
Documentation/ref/ovs-tcpdump.8.rst | 4 ++
NEWS
7;t see an echo reply even though
one has been sent.
This patch resets the mirrors every time a packet is modified, so
mirrors will receive every copy of a packet that is sent for output.
Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2155579
Signed-off-by: Mike Pattrick
---
v2: Refa
removed and the caller is xlate_push_stats_entry, then a new rule will
not be replaced.
Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2213892
Signed-off-by: Mike Pattrick
---
ofproto/ofproto-dpif-xlate-cache.c | 2 +-
ofproto/ofproto-dpif-xlate.c | 2 +-
ofproto/ofproto-dpif.c
On Fri, Jul 21, 2023 at 12:16 PM Ilya Maximets wrote:
>
> On 7/20/23 16:46, Aaron Conole wrote:
> > Mike Pattrick writes:
> >
> >> Currently OVS keeps track of which mirrors that each packet has been
> >> sent to for the purpose of deduplication. However, this
On Fri, Jul 21, 2023 at 12:50 PM Mike Pattrick wrote:
>
> On Fri, Jul 21, 2023 at 12:16 PM Ilya Maximets wrote:
> >
> > On 7/20/23 16:46, Aaron Conole wrote:
> > > Mike Pattrick writes:
> > >
> > >> Currently OVS keeps track of which mirrors
On Fri, Jul 28, 2023 at 7:48 AM Ilya Maximets wrote:
> On 7/20/23 17:06, Mike Pattrick wrote:
> > When the a revalidator thread is updating statistics for an XC_LEARN
> > xcache entry in xlate_push_stats_entry it uses ofproto_flow_mod_learn.
> > The revalidator will update
On Fri, Jul 28, 2023 at 6:31 PM Ilya Maximets wrote:
>
> On 7/28/23 23:13, Mike Pattrick wrote:
> > On Fri, Jul 28, 2023 at 7:48 AM Ilya Maximets > <mailto:i.maxim...@ovn.org>> wrote:
> >
> > On 7/20/23 17:06, Mike Pattrick wrote:
> > &
On Mon, Jul 31, 2023 at 7:20 AM Ilya Maximets wrote:
>
> On 7/31/23 07:34, Mike Pattrick wrote:
> > On Fri, Jul 28, 2023 at 6:31 PM Ilya Maximets wrote:
> >>
> >> On 7/28/23 23:13, Mike Pattrick wrote:
> >>> On Fri, Jul 28, 2023 at 7:48 AM Ilya Maxime
with LACP, which can cause confusion about why an
interface is flapping down and up again.
With this patch, OVS will log when LACP packets aren't sent or recieved
on time.
Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2223306
Signed-off-by: Mike Pattrick
---
lib/lacp.c
On Fri, Aug 4, 2023 at 11:38 AM Simon Horman wrote:
> On Wed, Aug 02, 2023 at 04:06:51PM -0400, Mike Pattrick wrote:
> > Diagnosing connectivity issues involving a bond can be complicated by a
> > lack of logging in LACP. It is difficult to determine the health of
> > send
hon.org/pep-0517/
> Link: https://pypi.org/project/build/
> Signed-off-by: Robin Jarry
>
Acked-by: Mike Pattrick
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
which is the recommended replacement tool to upload on
> pypi.org.
>
> Link:
> https://blog.ganssle.io/articles/2021/10/setup-py-deprecated.html#summary
> Reported-by
> <https://blog.ganssle.io/articles/2021/10/setup-py-deprecated.html#summaryReported-by>:
> Terry Wilson
>
sle.io/articles/2021/10/setup-py-deprecated.html#summary
> Signed-off-by
> <https://blog.ganssle.io/articles/2021/10/setup-py-deprecated.html#summarySigned-off-by>:
> Robin Jarry
>
>
Acked-by: Mike Pattrick
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
with LACP, which can cause confusion about why an
interface is flapping down and up again.
With this patch, OVS will log when LACP packets aren't sent or recieved
on time.
Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2223306
Signed-off-by: Mike Pattrick
---
v2: Added ratelimits to
by over 3kb from several translation actions.
This patch also moves some trace function from do_xlate_actions into its
own function.
Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2104779
Reviewed-by: Simon Horman
Signed-off-by: Mike Pattrick
Signed-off-by: Eelco Chaudron
over 3kb from several translation actions.
This patch also moves some trace function from do_xlate_actions into its
own function.
Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2104779
Reviewed-by: Simon Horman
Signed-off-by: Mike Pattrick
Signed-off-by: Eelco Chaudron
---
ofproto
over 3kb from several translation actions.
This patch also moves some trace function from do_xlate_actions into its
own function.
Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2104779
Reviewed-by: Simon Horman
Signed-off-by: Mike Pattrick
Signed-off-by: Eelco Chaudron
---
v2
over 3kb from several translation actions.
This patch also moves some trace function from do_xlate_actions into its
own function.
Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2104779
Reviewed-by: Simon Horman
Signed-off-by: Mike Pattrick
Signed-off-by: Eelco Chaudron
---
ofproto
On Thu, Jul 13, 2023 at 9:55 AM Eelco Chaudron wrote:
>
>
>
> On 13 Jul 2023, at 15:15, Eelco Chaudron wrote:
>
> > On 13 Jul 2023, at 15:10, Ilya Maximets wrote:
> >
> >> On 7/12/23 15:37, Mike Pattrick wrote:
> >>> Several xlate actions
://bugzilla.redhat.com/show_bug.cgi?id=2214979
Signed-off-by: Mike Pattrick
---
ofproto/bond.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/ofproto/bond.c b/ofproto/bond.c
index cfdf44f85..fb108d30a 100644
--- a/ofproto/bond.c
+++ b/ofproto/bond.c
@@ -193,6 +193,7 @@ static void
force is set to false and the rule has been replaced in the
classifier with a more recent rule, then ofproto_flow_mod_learn will
just return.
Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2213892
Signed-off-by: Mike Pattrick
---
v2: Added additional checks if rule is removed
---
ofproto
force is set to false and the rule has been replaced in the
classifier with a more recent rule, then ofproto_flow_mod_learn will
just return.
Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2213892
Signed-off-by: Mike Pattrick
---
v2: Added additional checks if rule is removed
v3: v2 patch
On Wed, Aug 9, 2023 at 11:19 AM Simon Horman wrote:
>
> On Wed, Aug 09, 2023 at 06:42:21PM +0800, Dexia Li via dev wrote:
> > The netdev receiving packets will be encapsulated if output port
> > is tunnel type. Only support userspace vxlan or geneve tunnel tso
> > and inner csum offload. Calculate
On Fri, Aug 11, 2023 at 11:00 AM Simon Horman wrote:
>
> On Wed, Aug 09, 2023 at 10:58:14PM -0400, Mike Pattrick wrote:
> > When the a revalidator thread is updating statistics for an XC_LEARN
> > xcache entry in xlate_push_stats_entry it uses ofproto_flow_mod_learn.
> &
On Fri, Aug 11, 2023 at 6:56 PM Ilya Maximets wrote:
>
> On 8/4/23 19:58, Mike Pattrick wrote:
> > Diagnosing connectivity issues involving a bond can be complicated by a
> > lack of logging in LACP. It is difficult to determine the health of
> > sending and receving LACP
On Wed, Aug 16, 2023 at 4:18 PM Ilya Maximets wrote:
>
> On 8/9/23 19:00, Mike Pattrick wrote:
> > Currently a bond will not always revalidate when an active member
> > changes. This can result in counter-intuitive behaviors like the fact
> > that using ovs-appctl bon
://bugzilla.redhat.com/show_bug.cgi?id=2214979
Signed-off-by: Mike Pattrick
---
v2: Added a test
---
ofproto/bond.c | 8 +--
tests/system-traffic.at | 50 +
2 files changed, 56 insertions(+), 2 deletions(-)
diff --git a/ofproto/bond.c b/ofproto/bond.c
index
force is set to false and the rule has been replaced in the
classifier with a more recent rule, then ofproto_flow_mod_learn will
just return.
Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2213892
Signed-off-by: Mike Pattrick
---
v2: Added additional checks if rule is removed
v3: v2
On Mon, Aug 21, 2023 at 7:15 AM Ilya Maximets wrote:
>
> On 8/18/23 00:46, Mike Pattrick wrote:
> > When the a revalidator thread is updating statistics for an XC_LEARN
> > xcache entry in xlate_push_stats_entry it uses ofproto_flow_mod_learn.
> > The revalidator will upd
for net/iavf. But to be on the safe
> side, this OVS patch here is a proposal to avoid hitting bugs in some
> other drivers,
>
I didn't test this thoroughly. But the documentation says that these
flags are only required if checksum/TSO is requested.
Acked-by: Mike Pattrick
_
https://bugzilla.redhat.com/show_bug.cgi?id=2213892
Signed-off-by: Mike Pattrick
---
v2: Added additional checks if rule is removed
v3: v2 patch was corrupted in transit
v4: Added check against dpif flow stats
v5: Fixed typos, updated commit message
Changed timestamps to use datapath timestamp
On Thu, Aug 24, 2023 at 6:01 PM Ilya Maximets wrote:
>
> On 8/22/23 22:45, Mike Pattrick wrote:
> > When the a revalidator thread is updating statistics for an XC_LEARN
> > xcache entry in xlate_push_stats_entry it uses ofproto_flow_mod_learn.
> > The revalidator will upd
On Mon, Aug 28, 2023 at 4:19 AM Ilya Maximets wrote:
>
> On 8/25/23 08:12, Mike Pattrick wrote:
> > On Thu, Aug 24, 2023 at 6:01 PM Ilya Maximets wrote:
> >>
> >> On 8/22/23 22:45, Mike Pattrick wrote:
> >>> When the a revalidator thread is updating sta
https://bugzilla.redhat.com/show_bug.cgi?id=2213892
Signed-off-by: Mike Pattrick
---
v2: Added additional checks if rule is removed
v3: v2 patch was corrupted in transit
v4: Added check against dpif flow stats
v5: Fixed typos, updated commit message
Changed timestamps to use datapath timestamp
On Fri, Aug 25, 2023 at 10:28 AM Adrian Moreno wrote:
>
>
>
> On 7/18/23 21:38, Mike Pattrick wrote:
> > Currently a bridge mirror will collect all packets and tools like
> > ovs-tcpdump can apply additional filters after they have already been
> > duplicated b
084c8087292c ("userspace: Support VXLAN and GENEVE TSO.")
> Reported-at: https://github.com/openvswitch/ovs-issues/issues/321
> Signed-off-by: Ilya Maximets
Acked-by: Mike Pattrick
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
resetting the mirror context.
Fixes: feed7f677505 ("ofproto-dpif-upcall: Mirror packets that are modified.")
Reported-by: Zhangweiwei
Signed-off-by: Mike Pattrick
---
include/openvswitch/meta-flow.h | 1 +
lib/meta-flow.c | 109
ofproto/of
://bugzilla.redhat.com/show_bug.cgi?id=1975039
Reported-by: Qijun Ding
Fixes: d6afbc00d5b3 ("ipsec: Allow custom file locations.")
Signed-off-by: Mike Pattrick
---
ipsec/ovs-monitor-ipsec.in | 31 +++
1 file changed, 27 insertions(+), 4 deletions(-)
diff --g
; Fixes: 084c8087292c ("userspace: Support VXLAN and GENEVE TSO.")
> Signed-off-by: Ilya Maximets
Acked-by: Mike Pattrick
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
e2dc6080 ("userspace: Add Generic Segmentation Offloading.")
> Signed-off-by: Ilya Maximets
Acked-by: Mike Pattrick
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
rning for unexpected
> tunnel types in case something goes wrong.
>
> Fixes: 084c8087292c ("userspace: Support VXLAN and GENEVE TSO.")
> Signed-off-by: Ilya Maximets
Acked-by: Mike Pattrick
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Tue, Mar 19, 2024 at 5:35 PM Ilya Maximets wrote:
>
> On 3/13/24 22:54, Mike Pattrick wrote:
> > In v4.0, LibreSwan changed a default paths that had been hardcoded in
> > ovs-monitor-ipsec, breaking some uses of this script. This patch adds
> > support for both old an
://bugzilla.redhat.com/show_bug.cgi?id=1975039
Reported-by: Qijun Ding
Fixes: d6afbc00d5b3 ("ipsec: Allow custom file locations.")
Signed-off-by: Mike Pattrick
---
v2: Don't extract variables from ipsec script
---
ipsec/ovs-monitor-ipsec.in | 16 ++--
1 file changed, 14 insertions(
On Wed, Mar 20, 2024 at 2:05 PM Mike Pattrick wrote:
>
> In v4.0, LibreSwan changed a default paths that had been hardcoded in
> ovs-monitor-ipsec, breaking some uses of this script. This patch adds
> support for both old and newer versions by auto detecting the version
> of Lib
://bugzilla.redhat.com/show_bug.cgi?id=1975039
Reported-by: Qijun Ding
Fixes: d6afbc00d5b3 ("ipsec: Allow custom file locations.")
Signed-off-by: Mike Pattrick
---
v2: Don't extract variables from ipsec script
v3: Removed use of packaging
---
ipsec/ovs-monitor-ipsec.in | 20 ++--
1 f
to set csum=false on IPv6 tunnels.
Signed-off-by: Mike Pattrick
---
v2: Changed documentation, and added a NEWS item
v3: NEWS file merge conflict
v4: Better comments, new test
---
NEWS | 4
lib/netdev-native-tnl.c | 2 +-
lib/netdev-vport.c| 17
er to have a symmetric test.
>
> Fixes: 084c8087292c ("userspace: Support VXLAN and GENEVE TSO.")
> Reported-at:
> https://mail.openvswitch.org/pipermail/ovs-discuss/2024-March/053014.html
> Signed-off-by: Ilya Maximets
> ---
I have tested this, and it does fix the segfault here.
Acked-by: Mike Pattrick
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
address is different then
this would be the expected behavior, the collection of the packet as
it enters, and then as it exists modified.
Thank you,
Mike
>
> -邮件原件-
> 发件人: Mike Pattrick [mailto:m...@redhat.com]
> 发送时间: 2024年3月13日 1:37
> 收件人: d...@openvswitch.org
> 抄送:
09:36:53.862230 68:05:ca:21:d6:e5 > 52:54:00:67:d5:61, ethertype IPv4
> (0x0800), length 98: (tos 0x0, ttl 63, id 22176, offset 0, flags [none],
> proto ICMP (1), length 84)
> 1.1.70.2 > 11.11.70.1: ICMP echo reply, id 15498, seq 18, length 64
>
> -邮件原件-
> 发件人
to set csum=false on IPv6 tunnels.
Signed-off-by: Mike Pattrick
---
v2: Changed documentation, and added a NEWS item
v3: NEWS file merge conflict
v4: Better comments, new test
v5: Addressed identified nit's
---
NEWS | 4
lib/netdev-native-tnl.c | 2 +-
On Wed, Mar 27, 2024 at 1:39 PM Simon Horman wrote:
>
> On Tue, Feb 20, 2024 at 11:08:55PM -0500, Mike Pattrick wrote:
> > When sending packets that are flagged as requiring segmentation to an
> > interface that doens't support this feature, send the packet to the TS
ry to re-establish the connection eventually.
>
> Since probe intervals also depend on the joining state now, update
> them when the server joins the cluster.
>
> Fixes: 14b2b0aad7ae ("raft: Reintroduce jsonrpc inactivity probes.")
> Reported-by: Terry Wilson
ls whenever we get election timer
> from the log.
>
> Fixes: 14b2b0aad7ae ("raft: Reintroduce jsonrpc inactivity probes.")
> Signed-off-by: Ilya Maximets
Acked-by: Mike Pattrick
___
dev mailing list
d...@openvswitch.org
https://m
Previously the mirror_set() and mirror_get() functions took a large
number of parameters, which was inefficient and difficult to read and
extend. This patch moves most of the parameters into a struct.
Signed-off-by: Mike Pattrick
Acked-by: Simon Horman
Acked-by: Eelco Chaudron
Signed-off-by
packets are mirrored based on flow metadata. This
significantly improves overall vswitchd performance during mirroring if
only a subset of traffic is required.
Signed-off-by: Mike Pattrick
---
v8:
- Corrected code from v7 related to sequence and in_port. Mirrors
reject filters with an in_port set as
packets are mirrored based on flow metadata. This
significantly improves overall vswitchd performance during mirroring if
only a subset of traffic is required.
Signed-off-by: Mike Pattrick
---
v8:
- Corrected code from v7 related to sequence and in_port. Mirrors
reject filters with an in_port set as
Previously the mirror_set() and mirror_get() functions took a large
number of parameters, which was inefficient and difficult to read and
extend. This patch moves most of the parameters into a struct.
Signed-off-by: Mike Pattrick
Acked-by: Simon Horman
Acked-by: Eelco Chaudron
Signed-off-by
dpif-netdev.c:8899
> 0x13e691f8 in dp_netdev_input at lib/dpif-netdev.c:8908
> 0x13e600e4 in dp_netdev_process_rxq_port at lib/dpif-netdev.c:5660
> 0x13e649a8 in pmd_thread_main at lib/dpif-netdev.c:7295
> 0x13f44b2c in ovsthread_wrapper at lib/ovs-thread.c:423
>
> CC: Mike Pattrick
>
n handling.")
Reported-at: https://issues.redhat.com/browse/FDP-560
Signed-off-by: Mike Pattrick
---
Note: This solution is far from perfect, ipf.c can still insert packets
into more or less arbitrary batches but this bug fix is needed to avoid a
memory overrun and should insert packets into t
led in the single function that is causing all of
the errors.
Signed-off-by: Mike Pattrick
---
v2: Changed macro name
---
include/openvswitch/compiler.h | 11 +++
lib/ovs-rcu.c | 1 +
2 files changed, 12 insertions(+)
diff --git a/include/openvswitch/compiler.h b/include/o
On Thu, May 16, 2024 at 8:35 AM Simon Horman wrote:
>
> Hi Mike,
>
> On Wed, May 15, 2024 at 12:24:33PM -0400, Mike Pattrick wrote:
> > When conntrack is reassembling packet fragments, the same reassembly
> > context can be shared across multiple threads ha
hange introduces checks to make sure that reassembled or expired
fragments are only added to packet batches of the same type.
Fixes: 4ea96698f667 ("Userspace datapath: Add fragmentation handling.")
Reported-at: https://issues.redhat.com/browse/FDP-560
Signed-off-by: Mike Pattrick
---
com/browse/FDP-560
Signed-off-by: Mike Pattrick
---
lib/ipf.c | 27 ---
1 file changed, 20 insertions(+), 7 deletions(-)
diff --git a/lib/ipf.c b/lib/ipf.c
index 3c8960be3..2d715f5e9 100644
--- a/lib/ipf.c
+++ b/lib/ipf.c
@@ -506,13 +506,15 @@ ipf_reassemble_v6_frags(struc
Recheck-request: github-robot
On Thu, May 16, 2024 at 9:58 AM Mike Pattrick wrote:
>
> This patch attempts to fix a large number of ubsan error messages that
> take the following form:
>
> lib/netlink-notifier.c:237:13: runtime error: call to function
> route_table_change
Clang's static analyzer will complain about an uninitialized value
because we weren't properly checking the error code from a function that
would have initialized the value.
Instead, add a check for that return code.
Signed-off-by: Mike Pattrick
---
lib/netdev-native-tnl.c | 4 ++
ff-by: Mike Pattrick
Mike Pattrick (5):
netdev-offload: Fix Clang's static analyzer 'null pointer dereference'
warnings.
netdev-native-tnl: Fix Clang's static analyzer 'uninitialized value'
warnings.
dpctl: Fix Clang's static analyzer 'garbage
Clang's static analyzer will complain about an uninitialized value
because we weren't setting a value for dns_failure in all code paths.
Now we initialize this on declaration.
Signed-off-by: Mike Pattrick
---
lib/socket-util.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
di
Clang's static analyzer will complain about an uninitialized value
because in some error conditions we wouldn't set all values that are
used later.
Now we initialize more values that are needed later even in error
conditions.
Signed-off-by: Mike Pattrick
---
lib/netdev-linux.c | 7
Clang's static analyzer will complain about an uninitialized value
because we weren't setting a value for ufid_generated in all code paths.
Now we initialize this on declaration.
Signed-off-by: Mike Pattrick
---
lib/dpctl.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
Clang's static analyzer will complain about a null pointer dereference
because dumps can be set to null and then there is a loop where it could
have been written to.
Instead, return early from the netdev_ports_flow_dump_create function if
dumps is NULL.
Signed-off-by: Mike Pattrick
---
On Mon, May 20, 2024 at 2:56 AM laixiangwu <15310488...@163.com> wrote:
>
> Description:
>
> when 1) The fragment timeout is between 15 seconds and 25 seconds; 2) The
> ipf_list currently has received more than 32 fragments, and there are other
> fragments of same big packet that have not been re
Hello laixaingwu,
I happen to have a patch on the list right now for a similar sounding issue:
https://patchwork.ozlabs.org/project/openvswitch/patch/20240516153832.153496-1-...@redhat.com/
Do you happen to have a stack trace available for this crash? That
could help determine if the crash is tr
y from the netdev_ports_flow_dump_create function if
dumps is NULL.
Signed-off-by: Mike Pattrick
---
lib/netdev-offload.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/lib/netdev-offload.c b/lib/netdev-offload.c
index 931d634e1..8a9d36555 100644
--- a/lib/netdev-offlo
Clang's static analyzer will complain about uninitialized value 'hlen'
because we weren't properly checking the error code from a function that
would have initialized the value.
Instead, add a check for that return code.
Signed-off-by: Mike Pattrick
Fixes: 03fc1ad78521 (
Fix broken flow deletion via ovs-dpctl due to
missing ufid.")
Signed-off-by: Mike Pattrick
---
lib/dpctl.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/lib/dpctl.c b/lib/dpctl.c
index 3c555a559..a70df5342 100644
--- a/lib/dpctl.c
+++ b/lib/dpctl.c
@@ -1359,1
Clang's static analyzer noted that the output from
netdev_linux_get_speed_locked can be checked even if this function
doesn't set any values.
Now we always set those values to a sane default in all cases.
Fixes: 6240c0b4c80e ("netdev: Add netdev_get_speed() to netdev API.")
ability to read the database with DNS
host names.")
Fixes: 5f219af8b3c7 ("ovsdb-server: Fix handling of DNS name for listener
configuration.")
Signed-off-by: Mike Pattrick
---
lib/socket-util.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/lib/socket-util.c b/lib
5266c ("netdev-linux: Use ethtool to detect offload support.")
Signed-off-by: Mike Pattrick
---
lib/netdev-linux.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/lib/netdev-linux.c b/lib/netdev-linux.c
index 25349c605..8b855bdc4 100644
--- a/lib/netdev-linux.c
+
ability to read the database with DNS
host names.")
Fixes: 5f219af8b3c7 ("ovsdb-server: Fix handling of DNS name for listener
configuration.")
Signed-off-by: Mike Pattrick
---
lib/socket-util.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/lib/socket-util.c b/lib
support.")
Signed-off-by: Mike Pattrick
---
lib/netdev-native-tnl.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/lib/netdev-native-tnl.c b/lib/netdev-native-tnl.c
index b21176037..d6f46ac4a 100644
--- a/lib/netdev-native-tnl.c
+++ b/lib/netdev-na
Fix broken flow deletion via ovs-dpctl due to
missing ufid.")
Signed-off-by: Mike Pattrick
---
lib/dpctl.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/lib/dpctl.c b/lib/dpctl.c
index 3c555a559..a70df5342 100644
--- a/lib/dpctl.c
+++ b/lib/dpctl.c
@@ -1359,1
ff-by: Mike Pattrick
Mike Pattrick (6):
netdev-offload: Fix null pointer dereference warning on dump creation.
netdev-native-tnl: Fix use of uninitialized offset on SRv6 header pop.
dpctl: Fix uninitialized value when deleting flows.
socket: Fix uninitialized values in inet_parse_ func
y from the netdev_ports_flow_dump_create function if
dumps is NULL.
Signed-off-by: Mike Pattrick
---
lib/netdev-offload.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/lib/netdev-offload.c b/lib/netdev-offload.c
index 931d634e1..8a9d36555 100644
--- a/lib/netdev-offlo
5266c ("netdev-linux: Use ethtool to detect offload support.")
Signed-off-by: Mike Pattrick
---
lib/netdev-linux.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/lib/netdev-linux.c b/lib/netdev-linux.c
index 25349c605..c89a85a38 100644
--- a/lib/netdev-linux.c
+
quot;)
Signed-off-by: Mike Pattrick
---
lib/netdev-linux.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/lib/netdev-linux.c b/lib/netdev-linux.c
index c89a85a38..ff5e94856 100644
--- a/lib/netdev-linux.c
+++ b/lib/netdev-linux.c
@@ -2727,6 +2727,7 @@ netdev_linux_get_speed_locked(struct
message")
> Signed-off-by: Eelco Chaudron
Acked-by: Mike Pattrick
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
igned-off-by: Eelco Chaudron
Acked-by: Mike Pattrick
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
andomness.
>
> Fixes: c72e245a0e2c ("Add InMon's sFlow Agent library to the build system.")
> Signed-off-by: Eelco Chaudron
Acked-by: Mike Pattrick
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
a Y2K38 problem when storing uint32_t values in time_t. This patch
> updates the internal data structures to use uint32_t variables.
>
> Fixes: c72e245a0e2c ("Add InMon's sFlow Agent library to the build system.")
> Signed-off-by:
option to add/delete static fdb
> entry.")
> Signed-off-by: Eelco Chaudron
> ---
Acked-by: Mike Pattrick
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Tue, May 28, 2024 at 4:26 PM Ilya Maximets wrote:
>
> On 5/27/24 21:08, Mike Pattrick wrote:
> > Clang's static analyzer noted that the output from
> > netdev_linux_get_speed_locked can be checked even if this function
> > doesn't set any values.
> >
On Thu, May 23, 2024 at 6:47 AM Roi Dayan via dev
wrote:
>
> It is observed in some environments that there are much more ukeys than
> actual DP flows. For example:
>
> $ ovs-appctl upcall/show
> system@ovs-system:
> flows : (current 7) (avg 6) (max 117) (limit 2125)
> offloaded flows : 525
> dump
301 - 400 of 782 matches
Mail list logo
