is
already parsed.
Fixes: 9dd7f8907c37 ("openvswitch: Add original direction conntrack tuple to
sw_flow_key.")
Reported-by: Antonin Bas
Closes: https://github.com/openvswitch/ovs-issues/issues/327
Signed-off-by: Ilya Maximets
---
Note: I'm working on a selftest for this issue, but it req
fixed.
Hope this makes sense.
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 5/3/24 11:29, Eelco Chaudron wrote:
>
>
> On 3 May 2024, at 1:36, Ilya Maximets wrote:
>
>> While tracing NAT actions, pointer to the action may be stored in the
>> recirculation node for future reference. However, while translating
>> actions for the grou
>>
>> SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior lib/hash.c:46:22
>>
>> [0] https://github.com/llvm/llvm-project/issues/90848
>> Fixes: db5a101931c5 ("clang: Fix the alignment warning.")
>> Signed-o
.17 since it is needed for
a successful build.
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 5/3/24 00:42, Ihar Hrachyshka wrote:
> On Thu, May 2, 2024 at 5:52 PM Ilya Maximets <mailto:i.maxim...@ovn.org>> wrote:
>
> On 4/26/24 18:54, Ihar Hrachyshka wrote:
> > Remove the notion of cluster/leave --force since it was never
> > implemented.
illy error on my
> side, but I am unable to see this patch in OVS patchwork [1].
>
> If it is not there, would it be possible to resubmit?
>
> [1] https://patchwork.ozlabs.org/project/openvswitch/list/
For some reason it had 'Archived' flag set. I un-archived it:
https://patchwork.ozlabs.org/project/openvs
;,
> "Flow translation error",
> ]
Hi, Eelco. Thanks for the fix!
Did you consider changing this array to a dictionary? This may help
avoiding such issues in the future.
A few other general notes:
We may consider adding a comment to the C definition of the enum that
pyth
et_sctp_complete_csum(struct dp_packet *p, bool
> inner)
> tp_len = dp_packet_l4_size(p);
> }
>
> +if (!sh) {
> +return;
> +}
> +
> put_16aligned_be32(>sctp_csum, 0);
> csum = crc32c((void *) sh, tp_len);
> put_16aligned_be32(>sctp_csum, csum);
Please, don't add these checks. If these functions are called for
incorrect packet it's a bug in a code that calls them. We may add
assertions instead, e.g. ovs_assert(sh);
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
s full and
> + * connect() returns EAGAIN (on Linux) or EINPROGRESS (on POSIX). */
Double spaces.
> +for (int i = 0; i < sizeof(clientsocks) / sizeof(clientsocks[0]); i++) {
ARRAY_SIZE macro from util.h.
> +clientsocks[i] = make_unix_socket(SOCK_STREAM, true, NULL,
> client
11b ("ofproto-dpif-trace: Improve NAT tracing.")
Reported-by: Ales Musil
Signed-off-by: Ilya Maximets
---
ofproto/ofproto-dpif-trace.c | 3 ++-
ofproto/ofproto-dpif-trace.h | 2 +-
tests/ofproto-dpif.at| 22 ++
3 files changed, 25 insertions(+), 2 deletions(-
ing the change.
Let me know what you think.
Best regards, Ilya Maximets.
>
> ---
> Documentation/ref/ovsdb.7.rst | 44 ---
> ovsdb/ovsdb-server.1.in | 3 +--
> 2 files changed, 37 insertions(+), 10 deletions(-)
>
> diff --git a/Documen
On 4/12/24 09:26, jm...@redhat.com wrote:
> From: Jakob Meng
>
> The 'list-commands' command now supports machine-readable JSON output
> in addition to the plain-text output for humans.
>
> Reported-at: https://bugzilla.redhat.com/1824861
> Signed-off-by: Jakob Meng
> ---
> NEWS
The option was added to the test-only code. This shouldn't be
in the news. If we move the formatting responsibility out
of the UnixctlClient to the user, this patch may not be needed
at all.
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 4/12/24 09:26, jm...@redhat.com wrote:
> From: Jakob Meng
>
> With the '--pretty' option, ovs-appctl will now print JSON output in a
> more readable fashion, i.e. with additional line breaks, spaces and
> sorted dictionary keys.
>
> Signed-off-by: Jakob Meng
> ---
> NEWS
- Python:
> + * Added support for choosing the output format, e.g. 'json' or 'text'.
This is misleading. Unixctl should be mentioned.
The rest of the patch has similar issues to the C implementation,
will not repeat my comments here.
Best regards, Ilya Maximets.
_
On 4/12/24 09:26, jm...@redhat.com wrote:
> From: Jakob Meng
>
> For monitoring systems such as Prometheus it would be beneficial if
> OVS would expose statistics in a machine-readable format.
>
> This patch introduces support for different output formats to ovs-xxx
> tools, in particular
T. We will still have a
misaligned pointer, but it will be immediately cast back, so should
cause less issues.
Note: all arithmetic should be done on the uint8_t pointer, not a
misaligned uin32_t one to avoid potential other UB conditions.
Best regards, Ilya Maximets.
>
> lib/hash.c:46:22: runti
+00 00 00 00 00 02 11 00 00 01 23 16 ab 36 0b c4 08 84 00 26 07 65 01 02 \
> +03 04 05 06 07 08 > /dev/null])
> +done
> +
> +OVS_WAIT_UNTIL([test $(grep -c -E \
> + "0x: *36b1 *ee7c *0102 *36b1 *ee7c *0103 *86dd *6000" p1.out) -eq 5])
> +OVS_WAIT_UNTIL([test $(grep
but I'd guess clang
inlines the call and while doing that assumes the type. I'm not
sure it is allowed to do that. Also, the 'n' here is always less
than 4, so alignment should not be a problem because we can't copy
the whole thing in a single aligned instruction (maybe there are
instructions tha
>> dev->hw_ol_features |= NETDEV_TX_TSO_OFFLOAD;
>>> } else {
>>> VLOG_WARN("%s: Tx TSO offload is not supported.",
>>> netdev_get_name(>up));
>>> }
>>>
>>
On 4/30/24 16:41, Ales Musil wrote:
>
>
> On Tue, Apr 30, 2024 at 4:36 PM Ilya Maximets <mailto:i.maxim...@ovn.org>> wrote:
>
> Sparse doesn't understand _Float16 and some other types used by
> immintrin.h from GCC 13. This breaks sparse builds with DPDK on
On 4/30/24 12:41, Ales Musil wrote:
>
>
> On Fri, Apr 26, 2024 at 7:44 PM Ilya Maximets <mailto:i.maxim...@ovn.org>> wrote:
>
> Clang 18.1.3-2.fc41 throws a warning:
>
> lib/tc.c:3060:25: error: field 'sel' with variable sized type
>
On 4/30/24 13:12, Eelco Chaudron wrote:
>
>
> On 30 Apr 2024, at 11:53, Ilya Maximets wrote:
>
>> On 4/26/24 18:35, Ilya Maximets wrote:
>>> Cirrus CI is broken on FreeBSD 13.3 due to clang version update.
>>> It now complains about snprintf truncation th
; -FROM registry.hub.docker.com/library/ubuntu:latest
> +FROM registry.hub.docker.com/library/ubuntu:22.04
>
> ARG CONTAINERS_PATH
>
I think, we should also pin the version in build-linux-rpm
job in .github/workflows/test.yml.
Best regards, Ilya Maximets.
_
portable between
compilers, because it only defines a few specific variables. We may
have to add more as GCC headers change over time.
This fixes the build with a following config on F38 and Ubuntu 24.04:
./configure --enable-sparse --with-dpdk=yes --enable-Werror
Signed-off-by: Ilya Maximets
On 4/26/24 18:35, Ilya Maximets wrote:
> Cirrus CI is broken on FreeBSD 13.3 due to clang version update.
> It now complains about snprintf truncation the same way GCC does:
>
> tests/test-util.c:1129:16: error: 'snprintf' will always be truncated;
> specified size i
all, using GHA just for scheduling of a job that wider
community can't take advantage of seems a little unjustified.
Thoughts?
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 4/26/24 19:44, Ilya Maximets wrote:
> Clang 18.1.3-2.fc41 throws a warning:
>
> lib/tc.c:3060:25: error: field 'sel' with variable sized type
> 'struct tc_pedit_sel' not at the end of a struct or class is a
> GNU extension [-Werror,-Wgnu-variable-sized-
On 4/26/24 18:35, Ilya Maximets wrote:
> Cirrus CI is broken on FreeBSD 13.3 due to clang version update.
> It now complains about snprintf truncation the same way GCC does:
>
> tests/test-util.c:1129:16: error: 'snprintf' will always be truncated;
> specified size i
;
| ^
Refactor the structure into a proper union to avoid the build failure.
Interestingly, clang 18.1.3-2.fc41 on Fedora throws a warning, but
relatively the same version 18.1.3 (1) on Ubuntu 23.04 does not.
Signed-off-by: Ilya Maximets
---
lib/tc.c | 22
On 4/26/24 18:35, Ilya Maximets wrote:
> Cirrus CI is broken on FreeBSD 13.3 due to clang version update.
> It now complains about snprintf truncation the same way GCC does:
>
> tests/test-util.c:1129:16: error: 'snprintf' will always be truncated;
> specified size i
e compiler-specific, so cannot be
combined, AFAIK.
Signed-off-by: Ilya Maximets
---
tests/test-util.c | 13 ++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/tests/test-util.c b/tests/test-util.c
index 7d899fbbf..5d88d38f2 100644
--- a/tests/test-util.c
+++ b/tests/t
_OPTS $*
>>> +configure_ovn $EXTRA_OPTS $OPTS $*
>>>
>>> if [ "$CC" = "clang" ]; then
>>> set make CFLAGS="$CFLAGS -Wno-error=unused-command-line-argument"
>>> --
>>> 2.44.0
>>>
>>
On 4/11/24 15:43, Chris Riches wrote:
> On 11/04/2024 14:24, Ilya Maximets wrote:
>> On 4/11/24 10:59, Chris Riches wrote:
>>> From what we know so far, the DB was full of stale connection-tracking
>>> information such as the following:
>>>
>>> [...]
&
On 4/23/24 13:10, Ilya Maximets wrote:
> On 4/23/24 12:35, Simon Horman wrote:
>> On Thu, Apr 18, 2024 at 03:35:06PM +0100, Chris Riches wrote:
>>> On 15/04/2024 14:39, Jon Kohler wrote:
>>>>> On Apr 11, 2024, at 9:43 AM, Chris Riches
>>>>> wrote
On 4/12/24 01:45, Ilya Maximets wrote:
> A couple of fixes related to corner cases with probe intervals
> on RAFT connections between servers.
>
> Ilya Maximets (2):
> ovsdb: raft: Fix inability to join a cluster with a large database.
> ovsdb: raft: Fix probe intervals afte
On 4/23/24 12:35, Simon Horman wrote:
> On Thu, Apr 18, 2024 at 03:35:06PM +0100, Chris Riches wrote:
>> On 15/04/2024 14:39, Jon Kohler wrote:
>>>> On Apr 11, 2024, at 9:43 AM, Chris Riches wrote:
>>>>
>>>> On 11/04/2024 14:24, Ilya Maximets wrot
hit": "0",
"n_missed": "0"}}
}
Using dictionaries with names as keys saves us from some of the strange
naming. "ofprotos" is a strange word and is not understandable by users.
It's an internal word. The user-facing entity is a bridge, not ofproto.
W
On 4/12/24 16:19, Phelan, Michael wrote:
>> -Original Message-
>> From: Ilya Maximets
>> Sent: Friday, April 12, 2024 12:46 PM
>> To: Phelan, Michael
>> Cc: i.maxim...@ovn.org; Jakob Meng ; Aaron Conole
>> ; Stokes, Ian ; ovs-dev > d...@openvswitch
dev->hw_ol_features |= NETDEV_TX_GENEVE_TNL_TSO_OFFLOAD;
> } else {
> VLOG_WARN("%s: Tx Geneve tunnel TSO offload is not supported.",
> @@ -1426,6 +1419,21 @@ dpdk_eth_dev_init(struct netdev_dpdk *dev)
> }
> }
>
> +}
> +
, Ihar. Thanks for cleaning this up!
See some comments inline.
Best regards, Ilya Maximets.
>
> ---
>
> v1: initial version.
> v2: remove --force mentioned in ovsd-server(1).
>
> ---
> Documentation/ref/ovsdb.7.rst | 50 +--
> ovsdb/o
t be related to the master/main rename? The NEWS file
was changed after the rename, so I'm guessing, CI still trying
to apply patches to a version of the code before the rename.
But it's just a guess.
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 4/12/24 11:29, Eelco Chaudron wrote:
>
>
> On 12 Apr 2024, at 1:32, Ilya Maximets wrote:
>
>> Current regexp is not good enough. OpenSSL 3.3.0 is now available
>> and unfortunately the regexp is matching both 3.3.0 and 3.0.13.
>>
>> All the AppVeyo
oduce jsonrpc inactivity probes.")
Reported-by: Terry Wilson
Reported-at: https://issues.redhat.com/browse/FDP-144
Signed-off-by: Ilya Maximets
---
ovsdb/raft.c | 22 +-
1 file changed, 17 insertions(+), 5 deletions(-)
diff --git a/ovsdb/raft.c b/ovsdb/raft.c
index
;raft: Reintroduce jsonrpc inactivity probes.")
Signed-off-by: Ilya Maximets
---
ovsdb/raft.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/ovsdb/raft.c b/ovsdb/raft.c
index 083ebf66a..ac3d37ac4 100644
--- a/ovsdb/raft.c
+++ b/ovsdb/raft.c
@@ -5035,6 +5035,7 @@ raft_get_election_timer_from_log(s
A couple of fixes related to corner cases with probe intervals
on RAFT connections between servers.
Ilya Maximets (2):
ovsdb: raft: Fix inability to join a cluster with a large database.
ovsdb: raft: Fix probe intervals after install snapshot request.
ovsdb/raft.c | 23
the last dot. Hopefully, this is
good enough.
In addition, taking only the first result just in case it mismatches
again.
Fixes: 9d8208484a35 ("appveyor: Build with OpenSSL 3.0.")
Signed-off-by: Ilya Maximets
---
appveyor.yml | 10 +-
1 file changed, 5 insertions(+), 5 deletion
On 4/11/24 00:43, Ilya Maximets wrote:
> Fixing a few more issues with Python 3.12 and Python files in general.
> Switch CI testing to Python 3.12, more explanation in commit messages.
>
> Plan s to also backport these changes to fix issues on older branches
> and also to have un
On 4/11/24 10:59, Chris Riches wrote:
> On 10/04/2024 23:31, Ilya Maximets wrote:
>> On 4/10/24 17:48, Chris Riches wrote:
>>> If the database is particularly large (multi-GB), ovsdb-server can take
>> Hi, Chris. May I ask how did you end up with multi-GB databas
Missing and extra spaces, missing empty lines, unused imports and
variables, long lines.
Decided to just comment out the unused 'tail' and 'head' as they
seem useful in documenting the meaning of the words.
Files added to flake8-check to avoid future issues.
Signed-off-by: Ilya Maximets
.
Signed-off-by: Ilya Maximets
---
CC: David Marchand
CC: Kevin Traynor
.ci/dpdk-prepare.sh | 2 +-
.github/workflows/build-and-test.yml | 11 +++
2 files changed, 8 insertions(+), 5 deletions(-)
diff --git a/.ci/dpdk-prepare.sh b/.ci/dpdk-prepare.sh
index f7e6215dd
nes, wildcarded imports. Also cleaning up one place that handles
compatibility with Python 2 types, since we do not support Python 2
for a long time now.
Signed-off-by: Ilya Maximets
---
ovsdb/automake.mk | 1 +
ovsdb/ovsdb-doc | 50 +++
2 files changed
Fixing a few more issues with Python 3.12 and Python files in general.
Switch CI testing to Python 3.12, more explanation in commit messages.
Plan s to also backport these changes to fix issues on older branches
and also to have uniform CI on all branches if possible.
Ilya Maximets (3):
ovsdb
rts/bridges and
some other not that large things ends up with so much data?
Sounds a little strange.
Best regards, Ilya Maximets.
> several minutes to come up. This tends to fall afoul of the default
> systemd start timeout, which is typically 90s, putting the service into
> an infinite
dependency on hacking.
>>
>> A similar change landed in OVN a while ago:
>> https://github.com/ovn-org/ovn/commit/271186fa7d76
>>
>> Signed-off-by: Dumitru Ceara
>
> Acked-by: Simon Horman
Thanks, Dumitru and Simon!
Applied t
On 4/10/24 18:24, Simon Horman wrote:
> On Wed, Apr 10, 2024 at 02:10:20PM +0200, Ilya Maximets wrote:
>> On 4/6/24 00:08, Ilya Maximets wrote:
>>> Currently, calls like ovs_assert() just print out a condition that
>>> caused assertion to fail. But it may be no
On 4/10/24 18:17, Simon Horman wrote:
> On Tue, Apr 09, 2024 at 10:24:09PM +0200, Ilya Maximets wrote:
>> Without this change many unit tests are failing on systems with
>> Python 3.12:
>>
>> +++ /tests/testsuite.dir/at-groups/2352/stdout
>> @@ -1,3 +1,5 @@
On 4/10/24 12:04, Kevin Traynor wrote:
> On 10/04/2024 10:51, Eelco Chaudron wrote:
>>
>>
>> On 10 Apr 2024, at 11:41, Ilya Maximets wrote:
>>
>>> 13.3 was released on March 5 and 13.2 will reach EoL in June.
>>> Update now.
>>
>> Ch
On 4/10/24 11:37, Eelco Chaudron wrote:
>
>
> On 9 Apr 2024, at 21:55, Ilya Maximets wrote:
>
>> Current code checks spelling of names in commit message tags and that
>> makes no sense.
>>
>> Most of the tags are explicitly handled, but tags like 'Tes
> DISTANCE=$(git log --oneline ${CURR_BASE}..HEAD | wc -l);
>
Acked-by: Ilya Maximets
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
etion(-)
>
> diff --git a/appveyor.yml b/appveyor.yml
> index 050c7dead786..baa844753962 100644
> --- a/appveyor.yml
> +++ b/appveyor.yml
> @@ -3,7 +3,6 @@ image: Visual Studio 2019
> branches:
>only:
>- main
> - - master
> configuration
On 4/10/24 17:01, Kevin Traynor wrote:
> On 05/04/2024 23:08, Ilya Maximets wrote:
>> Currently, calls like ovs_assert() just print out a condition that
>> caused assertion to fail. But it may be not enough to understand what
>> exactly has happened, especially if assertion f
On 4/6/24 00:08, Ilya Maximets wrote:
> Currently, calls like ovs_assert() just print out a condition that
> caused assertion to fail. But it may be not enough to understand what
> exactly has happened, especially if assertion failed in some generic
> function like dp_packet_resize(
= $(srcdir)/python/ovs/dirs.py
> @@ -147,6 +147,15 @@ $(srcdir)/python/ovs/dirs.py: python/ovs/dirs.py.template
> EXTRA_DIST += python/ovs/dirs.py.template
> CLEANFILES += python/ovs/dirs.py
>
> +ALL_LOCAL += $(srcdir)/python/setup.py
> +$(srcd
On 4/10/24 12:44, Eelco Chaudron wrote:
>
>
> On 10 Apr 2024, at 12:09, Kevin Traynor wrote:
>
>> On 10/04/2024 11:04, Kevin Traynor wrote:
>>> On 10/04/2024 10:51, Eelco Chaudron wrote:
>>>>
>>>>
>>>> On 10 Apr 2024, at 11:4
13.3 was released on March 5 and 13.2 will reach EoL in June.
Update now.
Signed-off-by: Ilya Maximets
---
.cirrus.yml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.cirrus.yml b/.cirrus.yml
index d8a972280..8db385f00 100644
--- a/.cirrus.yml
+++ b/.cirrus.yml
@@ -2,7 +2,7
rr_log], [0], [dnl
>0 | module_0 | EMER | emergency
>1 | module_0 | ERR | error
Thanks! Applied to all branches down to 2.17.
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
amp; class->type_set_config) {
> class->type_set_config(datapath_type, cfg);
> }
> }
Thanks for the update! Applied.
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Converting to a raw string to avoid the issue.
This only affects OVS 2.17, support for XenServer was removed
in OVS 3.0.
Signed-off-by: Ilya Maximets
---
xenserver/opt_xensource_libexec_interface-reconfigure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
Current code checks spelling of names in commit message tags and that
makes no sense.
Most of the tags are explicitly handled, but tags like 'Tested-by' or
other lesser used ones are falling through to the spellchecker and
need to be excluded.
Signed-off-by: Ilya Maximets
---
utilities
it, as the updated text seems somewhat nonsensical.
> - Correct indentation of NEWS entry.
Thanks, Simon!
Acked-by: Ilya Maximets
>
> Changes in v2:
> - Keep two blank lines between versions.
> - Drop bogus update to OpenSSL hashes URL in appveyor.yml.
> - Drop other appveyor.yml
t to wait a bit for review on this version
before re-posting just for this change.
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 4/8/24 22:10, Frode Nordahl wrote:
> On Mon, Apr 8, 2024 at 9:18 PM Frode Nordahl wrote:
>>
>> On Mon, Apr 8, 2024 at 9:14 PM Ilya Maximets wrote:
>>>
>>> On 4/8/24 16:48, Frode Nordahl wrote:
>>>> On Mon, Apr 8, 2024 at 4:44 PM Ilya Maximets wrot
On 4/8/24 16:48, Frode Nordahl wrote:
> On Mon, Apr 8, 2024 at 4:44 PM Ilya Maximets wrote:
>>
>> On 4/8/24 16:39, Frode Nordahl wrote:
>>> The vlog - Python3 test makes use of output from Python
>>> Tracebacks in its assertion.
>>>
>>> In Pyth
lieve I did run tests with 3.12 a few times at some point
and didn't have this issue.
Bets regards, Ilya Maximets.
>
> Strip lines starting whith whitespace and otherwise only
> containing one or more occurence of the ``^`` character from the
> output before performing the test assertion
this one was just added today by Eelco. :)
And it's also in OVS repo, not in OVN.
>
>
>
>> On 8 Apr 2024, at 13:30, Ilya Maximets wrote:
>>
>> On 4/8/24 13:26, Alin Serdean wrote:
>>>
>>> Just one question: do we have to remove the
On 4/8/24 13:26, Alin Serdean wrote:
>
> Just one question: do we have to remove the xenserver reference in the
> checkpatch.py?
Hmm. Which one?
>
> Otherwise looks good.
>
> Acked-by: Alin Gabriel Serdean
>
>> On 8 Apr 2024, at 13:06, Ilya Maximets wro
Remaining bits from the OVS/OVN split.
Fixes: 1af37d11be73 ("Remove XenServer Code")
Signed-off-by: Ilya Maximets
---
Documentation/tutorials/index.rst | 6 --
README.rst| 3 ---
acinclude.m4 | 26 ---
build-aux/i
On 4/5/24 15:46, Eelco Chaudron wrote:
>
>
> On 5 Apr 2024, at 15:04, Ilya Maximets wrote:
>
>> On 4/5/24 14:33, Eelco Chaudron wrote:
>>>
>>>
>>> On 4 Apr 2024, at 14:09, Ilya Maximets wrote:
>>>
>>>> ukey_install() returns bool
rg/project/openvswitch/list/?series=382739=%2A=both
>> - that generally improve AF_UNIX unixctl socket handling, which I plan to
>> revive later, but nothing stops us from merging this before I get to it.
>>
>
> Yes, I noticed that conversation right after I replied ;) L
more carefully.
Better solution might be to use VLOG_ABORT() where appropriate instead.
Signed-off-by: Ilya Maximets
---
lib/vlog.c | 10 --
tests/library.at | 4 +++-
2 files changed, 11 insertions(+), 3 deletions(-)
diff --git a/lib/vlog.c b/lib/vlog.c
index b2653142f..e78c785f7
oto-dpif-sflow.c | 1 +
> ofproto/ofproto-dpif.c | 186 ---
> ofproto/ofproto-dpif.h | 4 +-
> tests/system-common-macros.at| 4 +
> tests/system-offloads-traffic.at | 12 ++
> tests/system-traffic.at | 31 ++
//github.com/torvalds/linux/commit/eff3c558bb7e61c41b53e4c8130e514a5a4df9ba
>> [2]:
>> https://github.com/torvalds/linux/commit/fa173a1b4e3fd1ab5451cbc57de6fc624c824b0a
>>
>> Acked-by: Mike Pattrick
>> Co-Authored-By: Luca Czesla
>> Signed-off-by: Luca Czesla
&
On 4/5/24 15:08, Ilya Maximets wrote:
> On 4/5/24 15:01, Eric Garver wrote:
>> On Fri, Apr 05, 2024 at 11:39:58AM +0200, Eelco Chaudron wrote:
>>>
>>>
>>> On 3 Apr 2024, at 16:35, Eric Garver wrote:
>>>
>>>> Kernel support has been added for
On 4/5/24 15:01, Eric Garver wrote:
> On Fri, Apr 05, 2024 at 11:39:58AM +0200, Eelco Chaudron wrote:
>>
>>
>> On 3 Apr 2024, at 16:35, Eric Garver wrote:
>>
>>> Kernel support has been added for this action. As such, we need to probe
>>> the datapath for support.
>>>
>>> Signed-off-by: Eric
On 4/5/24 14:33, Eelco Chaudron wrote:
>
>
> On 4 Apr 2024, at 14:09, Ilya Maximets wrote:
>
>> ukey_install() returns boolean signaling if the ukey was installed
>> or not. Installation may fail for a few reasons:
>>
>> 1. Conflicting ukey.
>> 2
On 4/4/24 14:46, David Marchand wrote:
> On Wed, Apr 3, 2024 at 8:13 PM Ilya Maximets wrote:
>>> - This patch fixes some misusage of the DPDK API.
>>
>> Hmm, I understand that the driver does something funny when it gets
>> outer flags set without any inner f
On 1/11/24 00:08, Eelco Chaudron wrote:
> This patch identifies new static analysis issues during a GitHub action
> run and reports them. The process involves analyzing the changes introduced
> in the current commit and comparing them to those in the preceding commit.
>
> However, there are two
ch has been renamed from 'master' to 'main'.
> +The OVS tree remains hosted on GitHub.
> +https://github.com/openvswitch/ovs.git
We use 3 spaces for the first level of indentation in the NEWS file.
I don't know why... I suppose it was an accident in the notes for v2.1.0,
where indentation went from 4 to 3 spaces. But we used it ever since
and it's better to keep the doc uniform.
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
leted flows.")
Fixes: 9cec8274ed9a ("ofproto-dpif-upcall: Add VLOG_WARN_RL logs for
upcall_cb() error.")
Signed-off-by: Ilya Maximets
---
ofproto/ofproto-dpif-upcall.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/ofproto/ofproto-dpif-upcall.c b/
,
but at least this change makes logging in openvswitch module more
consistent.
Fixes: 06bd2bdf19d2 ("openvswitch: Add timeout support to ct action")
Signed-off-by: Ilya Maximets
---
net/openvswitch/conntrack.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/net/o
too many fixes for that thing we have already and this one will
involve some extra driver-specific logic that we don't have any automated
tests for.
>
>
> - About the workaround (disabling outer udp checksum for net/ice and
> net/i40e), the net/iavf is subject to the sa
On 4/3/24 16:35, Eric Garver wrote:
> Kernel support has been added for this action. As such, we need to probe
> the datapath for support.
>
> Signed-off-by: Eric Garver
> ---
> include/linux/openvswitch.h | 2 +-
> lib/dpif.c | 6 ++-
> lib/dpif.h | 2 +-
>
t; lib/conntrack.c | 4 +++-
> tests/system-traffic.at | 10 +-
> 2 files changed, 12 insertions(+), 2 deletions(-)
Thanks! Applied and backported down to 2.17.
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
with
> exhaustion test" fail, as it relies on the previous assumptions.
>
> Fix it by creating and not advancing the first entry in SYN_SENT to
> avoid early eviction.
>
> Suggested-by: Ilya Maximets
> Reported-at: https://issues.redhat.com/browse/FDP-486
> Signed-off-by
On 4/3/24 00:28, Eric Garver wrote:
> On Fri, Mar 29, 2024 at 12:26:11AM +0100, Ilya Maximets wrote:
>> On 3/22/24 14:54, Eric Garver wrote:
> [..]
>>> @@ -1649,8 +1693,8 @@ check_support(struct dpif_backer *backer)
>>> backer->rt_support.max_hash_a
s good to me. Have you a related issue or is it just
> preventative?
Hmm. This function is only called with pre-registered types, so
this condition should not be actually possible.
The change itself is fine, but, I think, the patch name and the commit
message should be changed to indicate that
On 4/2/24 16:22, Eric Garver wrote:
> On Fri, Mar 29, 2024 at 12:26:11AM +0100, Ilya Maximets wrote:
>> On 3/22/24 14:54, Eric Garver wrote:
>>> Kernel support has been added for this action. As such, we need to probe
>>> the datapath for support.
>>>
>>
On 4/2/24 16:17, Ales Musil wrote:
>
>
> On Tue, Apr 2, 2024 at 4:03 PM Ilya Maximets <mailto:i.maxim...@ovn.org>> wrote:
>
> On 4/2/24 15:36, Ales Musil wrote:
> >
> >
> > On Tue, Apr 2, 2024 at 3:02 PM Ilya Maximets <mailto:i
1 - 100 of 6726 matches
Mail list logo
