Re: [ovs-dev] [Regression] openvswitch: Add eventmask support to CT action.

ld come up now. I have attached the patch below, please try it in your test rig. commit a717743bd355b3a25a83b196403db9d010b311b2 (HEAD -> ovs-set-ctmask-in-template) Author: Jarno Rajahalme Date: Mon Sep 24 14:34:26 2018 -0700 openvswitch: Set CT mask in template Set the con

Re: [ovs-dev] [PATCH] ovs-ofctl: Avoid read overrun in ofperr_decode_msg().

d for this special case, so remove it > in favor of a chain of ofpbufs. > > Found via gcc's address sanitizer. > > Reported-by: Lance Richardson <lrich...@redhat.com> > CC: Jarno Rajahalme <ja...@ovn.org> > Fixes: 506c1ddb3404 ("vconn: Better bundle error manag

Re: [ovs-dev] [PATCH v5] tunneling: Avoid recirculation on datapath by computing the recirculate actions at translate time.

> > On May 10, 2017, at 12:59 PM, Andy Zhou > wrote: > > On Wed, May 10, 2017 at 7:56 AM, William Tu > wrote: >>> It may be cleaner if we add a new trunc action for the datapath, say >>> trunc2 that

Re: [ovs-dev] [PATCH v5] tunneling: Avoid recirculation on datapath by computing the recirculate actions at translate time.

> On May 10, 2017, at 12:59 PM, Andy Zhou wrote: > > On Wed, May 10, 2017 at 7:56 AM, William Tu > wrote: >>> It may be cleaner if we add a new trunc action for the datapath, say >>> trunc2 that applies >>> to all outputs within

Re: [ovs-dev] [PATCH 2/2] revalidator: Fix logging of xlate_key() failure.

Acked-by: Jarno Rajahalme <ja...@ovn.org> > On May 1, 2017, at 12:58 PM, Joe Stringer <j...@ovn.org> wrote: > > This was being logged using xlate_strerror(), but the return code is > actually an errno code. Use ovs_strerror() instead. > > Fixes: dd0dc9eda0e0 ("

Re: [ovs-dev] [PATCH 1/2] revalidator: Revalidate ukeys created from flows.

Acked-by: Jarno Rajahalme <ja...@ovn.org> > On May 1, 2017, at 12:58 PM, Joe Stringer <j...@ovn.org> wrote: > > If there is no active ukey for a particular datapath flow, and it is > dumped from the datapath, then the revalidator threads will assemble a > ukey

Re: [ovs-dev] [patch_v7 2/9] dpdk: Remove batch sorting in userspace conntrack.

Would be nice to have a commit message, with the motivation for the change. Jarno > On Mar 24, 2017, at 2:15 AM, Darrell Ball wrote: > > Signed-off-by: Darrell Ball > Acked-by: Flavio Leitner > --- > lib/conntrack.c | 58

Re: [ovs-dev] [PATCH v2] config: Define OVS_CT_EVENT_* mask macros.

> On Apr 28, 2017, at 5:56 PM, Joe Stringer <j...@ovn.org> wrote: > > On 28 April 2017 at 17:46, Jarno Rajahalme <ja...@ovn.org> wrote: >> Unconditionally define OVS_CT_EVENT_* macros for the datapath netlink >> interface so that we do not need to include platfo

Re: [ovs-dev] [RFC PATCH] config: Compat for older kernels not having IPCT_LABEL.

> On Apr 28, 2017, at 4:53 PM, Joe Stringer <j...@ovn.org> wrote: > > On 28 April 2017 at 15:49, Jarno Rajahalme <ja...@ovn.org > <mailto:ja...@ovn.org>> wrote: >> Detect the presence of enum ip_conntrack_events member IPCT_LABEL at >> configur

[ovs-dev] [PATCH v2] config: Define OVS_CT_EVENT_* mask macros.

Stringer <j...@ovn.org> Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- build-aux/extract-odp-netlink-h | 19 +-- ofproto/ofproto-dpif-xlate.c| 4 +--- 2 files changed, 18 insertions(+), 5 deletions(-) diff --git a/build-aux/extract-odp-netlink-h b/build-aux/extract

Re: [ovs-dev] [v2] vswitchd: Add --cleanup option to the 'appctl exit' command

Some types noted below, otherwise: Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Apr 26, 2017, at 3:38 PM, Andy Zhou <az...@ovn.org> wrote: > > 'appctl exit' stops the running vswitchd daemon, without releasing > the datapath resources (such as bridges and ports) tha

Re: [ovs-dev] [PATCH] travis: Break Mac OS build for format specifier warnings.

Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Mar 20, 2017, at 10:10 PM, Ben Pfaff <b...@ovn.org> wrote: > > Until now, the Travis build for Mac OS X has been configured to ignore > format specifier warnings. These warnings have now been fixed, so this > commit cha

Re: [ovs-dev] [PATCH] compat: Remove unused netdevice backport code.

Maybe mention in the commit message that these are unused due to older than X.Y.Z Linux kernel versions not being supported any more. Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Feb 8, 2017, at 4:50 PM, Joe Stringer <j...@ovn.org> wrote: > > Signed-off-by: Joe S

[ovs-dev] [RFC PATCH] config: Compat for older kernels not having IPCT_LABEL.

t;j...@ovn.org> Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- acinclude.m4| 7 ++- build-aux/extract-odp-netlink-h | 4 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/acinclude.m4 b/acinclude.m4 index 7e4acc9..ea25e08 100644 --- a/acincl

Re: [ovs-dev] [PATCH v5] xlate: Use OVS_CT_ATTR_EVENTMASK.

> On Apr 28, 2017, at 12:31 PM, Joe Stringer <j...@ovn.org> wrote: > > On 27 April 2017 at 17:21, Jarno Rajahalme <ja...@ovn.org > <mailto:ja...@ovn.org>> wrote: >> Specify the event mask with CT commit including bits for CT features >> exposed at

Re: [ovs-dev] [action upcall meter v2 5/5] ofproto: Meter slowpath action when action upcall meters are configured

With the white-space nits below: Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Apr 28, 2017, at 2:01 AM, Andy Zhou <az...@ovn.org> wrote: > > If a slow path action is a controller action, meter it when the > controller meter is configured. For other kinds of slow path

Re: [ovs-dev] [action upcall meter v2 4/5] ofproto: Meter sample action when configured.

Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Apr 28, 2017, at 2:01 AM, Andy Zhou <az...@ovn.org> wrote: > > When slowpath meter is configured, add meter action when translate > sample action. > > Signed-off-by: Andy Zhou <az...@ovn.org> > >

Re: [ovs-dev] [action upcall meter v2 2/5] ofproto-dpif: Add 'meter_ids' to backer

With a note below: Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Apr 28, 2017, at 2:01 AM, Andy Zhou <az...@ovn.org> wrote: > > Add 'meter_ids', an id-pool object to manage datapath meter id, i.e. > provider_meter_id. > > Currently, only userspace datapath sup

Re: [ovs-dev] [action upcall meters 2/5] ofproto-dpif: Use backer to manage datapath meter allocation

> On Apr 27, 2017, at 11:48 PM, Andy Zhou <az...@ovn.org> wrote: > > On Thu, Apr 27, 2017 at 3:23 PM, Jarno Rajahalme <ja...@ovn.org > <mailto:ja...@ovn.org>> wrote: >> >>> On Apr 14, 2017, at 12:46 PM, Andy Zhou <az...@ovn.org> wrote: &g

Re: [ovs-dev] [action upcall meters 1/5] ofproto: Store meters using hmap

> On Apr 27, 2017, at 11:28 PM, Andy Zhou <az...@ovn.org> wrote: > > On Thu, Apr 27, 2017 at 3:14 PM, Jarno Rajahalme <ja...@ovn.org > <mailto:ja...@ovn.org>> wrote: >> This incremental needed to satisfy GCC 4.9.2, due to ‘meter’ potentially >> b

Re: [ovs-dev] [PATCH] tests: ICMP related to original direction test.

> On Apr 27, 2017, at 4:55 PM, Joe Stringer <j...@ovn.org> wrote: > > On 10 March 2017 at 16:10, Jarno Rajahalme <ja...@ovn.org> wrote: >> Normally ICMPP responses are in the reply direction of a conntrack > > 's/ICMPP/ICMP/' > >> entry. This test

[ovs-dev] [PATCH v5] xlate: Use OVS_CT_ATTR_EVENTMASK.

Signed-off-by: Jarno Rajahalme <ja...@ovn.org> Acked-by: Joe Stringer <j...@ovn.org> --- v5: Use addresses in the loopback range and zero port numbers in the probe to avoid hitting any real conntrack entries. build-aux/extract-odp-netlink-h | 2 ++ ofproto/ofproto-dpif-xla

Re: [ovs-dev] [PATCH v3] xlate: Use OVS_CT_ATTR_EVENTMASK.

> On Apr 27, 2017, at 4:15 PM, Joe Stringer <j...@ovn.org> wrote: > > On 27 April 2017 at 14:48, Jarno Rajahalme <ja...@ovn.org > <mailto:ja...@ovn.org>> wrote: >> Specify the event mask with CT commit including bits for CT features >> exposed at

[ovs-dev] [PATCH v4] xlate: Use OVS_CT_ATTR_EVENTMASK.

Signed-off-by: Jarno Rajahalme <ja...@ovn.org> Acked-by: Joe Stringer <j...@ovn.org> --- v4: Added the missing byte swap operations. build-aux/extract-odp-netlink-h | 2 ++ ofproto/ofproto-dpif-xlate.c| 6 ofproto/ofproto-dpif.c

Re: [ovs-dev] [action upcall meters 5/5] ofproto: Meter slowpath action when action upcall meters are configured

See comments below. Jarno > On Apr 14, 2017, at 12:46 PM, Andy Zhou wrote: > > If a slow path action is a controller action, meter it when the > controller meter is configured. For other kinds of slow path actions, > meter it when the slowpath meter is configured. > > Note,

Re: [ovs-dev] [action upcall meters 4/5] ofproto: Meter sample action when configured.

This breaks the test "ofproto-dpif - Bridge IPFIX sanity check” (currently test #1128), which appears to be the tests case that is being modified. More comments below. > On Apr 14, 2017, at 12:46 PM, Andy Zhou wrote: > > When slowpath meter is configured, add meter action when

Re: [ovs-dev] [action upcall meters 3/5] ofproto: Support action upcall meters

With small nits below: Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Apr 14, 2017, at 12:46 PM, Andy Zhou <az...@ovn.org> wrote: > > Allow action upcall meters, i.e. slowpath and controller meters, > to be added and displayed. > > Keep track of datapath meter ID

Re: [ovs-dev] [action upcall meters 2/5] ofproto-dpif: Use backer to manage datapath meter allocation

> On Apr 14, 2017, at 12:46 PM, Andy Zhou wrote: > > Add 'meter_ids', an id-pool object to manage datapath meter id. > > Currently, only userspace datapath supports meter, and it implements > the provider_meter_id management. Moving this function to 'backer' > allows other

Re: [ovs-dev] [action upcall meters 1/5] ofproto: Store meters using hmap

, const struct ofp_header *request, struct ofproto *ofproto = ofconn_get_ofproto(ofconn); struct ovs_list replies; uint32_t meter_id; -struct meter *meter; +struct meter *meter = NULL; ofputil_decode_meter_request(request, _id); Otherwise: Acked-by: Jarno Rajahalme <

[ovs-dev] [PATCH v3] xlate: Use OVS_CT_ATTR_EVENTMASK.

Signed-off-by: Jarno Rajahalme <ja...@ovn.org> Acked-by: Joe Stringer <j...@ovn.org> --- v3: Added feature probing to not use the new attribute on datapaths the do not support it. build-aux/extract-odp-netlink-h | 2 ++ ofproto/ofproto-dpif-xlate.c| 6 ofproto/of

Re: [ovs-dev] [PATCH] datapath-windows: Add missing IPCT_LABEL.

Pushed to master, Jarno > On Apr 27, 2017, at 11:07 AM, Sairam Venugopal <vsai...@vmware.com> wrote: > > Thanks for adding this in. > > Acked-by: Sairam Venugopal <vsai...@vmware.com> > > > > > > On 4/19/17, 7:01 PM, "ovs-dev-boun...@ope

Re: [ovs-dev] [PATCH 3/4] compat: Fix build error in kernels 4.10+

> On Apr 27, 2017, at 1:08 PM, Greg Rose wrote: > > This is an alternative solution patch for the issue reported by > Raymond Burkholder and the patch submitted by Guoshuai Li. It uses > the acinclude.m4 configuration file to check for the net parameter > that was added

Re: [ovs-dev] [PATCH v2 1/2] xlate: Use OVS_CT_ATTR_EVENTMASK.

> On Apr 27, 2017, at 10:18 AM, Joe Stringer <j...@ovn.org> wrote: > > On 24 April 2017 at 19:09, Jarno Rajahalme <ja...@ovn.org > <mailto:ja...@ovn.org>> wrote: >> Specify the event mask with CT commit including bits for CT features >> exposed at

Re: [ovs-dev] [PATCH] datapath: Delete conntrack entry clashing with an expectation.

> On Apr 27, 2017, at 10:36 AM, Joe Stringer <j...@ovn.org> wrote: > > On 26 April 2017 at 13:13, Jarno Rajahalme <ja...@ovn.org> wrote: >> Upstream commit: >> >>commit cf5d70918877c6a6655dc1e92e2ebb661ce904fd >>Author: Jarno Rajahalme <

Re: [ovs-dev] [PATCH v2 2/2] datapath: nf_connlabels_replace() backport.

> On Apr 27, 2017, at 10:31 AM, Joe Stringer <j...@ovn.org> wrote: > > On 24 April 2017 at 19:09, Jarno Rajahalme <ja...@ovn.org> wrote: >> Linux 4.7 changed nf_connlabels_replace() to trigger conntrack event >> for a label change only when the labels actually

Re: [ovs-dev] [PATCH 2/2] datapath: Add eventmask support to CT action.

> On Apr 27, 2017, at 10:15 AM, Joe Stringer <j...@ovn.org> wrote: > > On 24 April 2017 at 13:50, Jarno Rajahalme <ja...@ovn.org> wrote: >> Upstream commit: >> >>commit 120645513f55a4ac5543120d9e79925d30a0156f >>Author: Jarno Rajahalme <

Re: [ovs-dev] [PATCH 2/2] revalidator: Improve logging for transition_ukey().

gging. > > Suggested-by: Jarno Rajahalme <ja...@ovn.org> > Signed-off-by: Joe Stringer <j...@ovn.org> > --- > ofproto/ofproto-dpif-upcall.c | 17 - > 1 file changed, 16 insertions(+), 1 deletion(-) > > diff --git a/ofproto/ofproto-dpif-upca

[ovs-dev] [PATCH] datapath: Delete conntrack entry clashing with an expectation.

Upstream commit: commit cf5d70918877c6a6655dc1e92e2ebb661ce904fd Author: Jarno Rajahalme <ja...@ovn.org> Date: Fri Apr 14 14:26:38 2017 -0700 openvswitch: Delete conntrack entry clashing with an expectation. Conntrack helpers do not check for a potentially cl

[ovs-dev] [PATCH] xlate: Use OVS_CT_ATTR_EVENTMASK.

Specify the event mask with CT commit including bits for CT features exposed at the OVS interface (mark and label changes in addition to basic creation and destruction of conntrack entries). VMware-BZ: #1837218 Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- This patch depends on the fol

[ovs-dev] [PATCH 2/2] datapath: Add eventmask support to CT action.

Upstream commit: commit 120645513f55a4ac5543120d9e79925d30a0156f Author: Jarno Rajahalme <ja...@ovn.org> Date: Fri Apr 21 16:48:06 2017 -0700 openvswitch: Add eventmask support to CT action. Add a new optional conntrack action attribute OVS_CT_ATTR_EVENTMASK, whi

[ovs-dev] [PATCH 1/2] datapath: Typo fix.

Upstream commit: commit abd0a4f2b41812e9ba334945e256909e3d28da57 Author: Jarno Rajahalme <ja...@ovn.org> Date: Fri Apr 21 16:48:05 2017 -0700 openvswitch: Typo fix. Fix typo in a comment. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> Acked-by: Greg R

Re: [ovs-dev] [PATCH] ovs-ofctl: Document group selection algorithm.

Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Apr 24, 2017, at 9:06 AM, Ben Pfaff <b...@ovn.org> wrote: > > Signed-off-by: Ben Pfaff <b...@ovn.org> > --- > utilities/ovs-ofctl.8.in | 10 ++ > 1 file changed, 6 insertions(+), 4 deletions(-) > &g

Re: [ovs-dev] [PATCH v1] flow.c: Refactor the key_extract function in parsing frame.

As a policy, Linux kernel datapath changes other than backports need to go to upstream Linux first, new features to net-next tree, and bug fixes to net tree. See the documentation file ‘backporting-patches.rst’ in directory 'Documentation/internals/contributing/‘ of the OVS tree for more

Re: [ovs-dev] [PATCH] bridge: Log interface deletion

Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Apr 20, 2017, at 5:39 PM, Andy Zhou <az...@ovn.org> wrote: > > Currently, interface additions are logged but not deletion. This > makes system debugging, such as confirming OVSDB transaction are > timely replicated harder

Re: [ovs-dev] [PATCH v2 2/2] datapath: pass extended ACK struct to parsing functions

> On Apr 20, 2017, at 4:36 PM, Joe Stringer <j...@ovn.org> wrote: > > On 19 April 2017 at 16:54, Jarno Rajahalme <ja...@ovn.org > <mailto:ja...@ovn.org>> wrote: >> From: Johannes Berg <johannes.b...@intel.com> >> >> Upstream commit: >

Re: [ovs-dev] [PATCH 6/6] rstp: Add the 'ovs-appctl rstp/show' command.

I’d like to see one of the existing RSTP test cases modified to use this new feature. One more comment below, Jarno > On Mar 31, 2017, at 8:11 PM, nickcooper-zhangtonghao > wrote: > > The rstp/show command will help users and developers to > get more details about

Re: [ovs-dev] [PATCH 5/6] rstp: Add rstp port name for human reading.

Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Mar 31, 2017, at 8:11 PM, nickcooper-zhangtonghao <n...@opencloud.tech> > wrote: > > This patch is useful to debug rstp subsystem and log the > port name instead of port number. This patch will also > be used to disp

Re: [ovs-dev] [PATCH 4/6] rstp: Init a recursive mutex for rstp.

> On Mar 31, 2017, at 8:11 PM, nickcooper-zhangtonghao > wrote: > > This patch will be used for next patch. I don’t see exactly what in the following patch(es) need this. Could you elaborate? > > Signed-off-by: nickcooper-zhangtonghao > --- >

Re: [ovs-dev] [PATCH 3/6] stp: Add link-state checking support for stp ports.

> On Mar 31, 2017, at 8:11 PM, nickcooper-zhangtonghao > wrote: > > When bridge stp enabled, we enable the stp ports despite > ports are down. When initializing, this patch checks > link-state of ports and enable or disable them according > to their link-state. This patch

Re: [ovs-dev] [PATCH 1/6] rstp/stp: Unref the rstp/stp when bridges destroyed.

Looks correct to me. Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Mar 31, 2017, at 8:11 PM, nickcooper-zhangtonghao <n...@opencloud.tech> > wrote: > > When bridges destroyed, which stp enabled, you can > still get stp info via the command 'ovs-appctl stp/sh

[ovs-dev] [PATCH] datapath-windows: Add missing IPCT_LABEL.

Add the missing enum definition for IPCT_LABEL. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- datapath-windows/include/OvsDpInterfaceCtExt.h | 1 + 1 file changed, 1 insertion(+) diff --git a/datapath-windows/include/OvsDpInterfaceCtExt.h b/datapath-windows/include/OvsDpInterfaceC

[ovs-dev] [PATCH v2 2/2] datapath: pass extended ACK struct to parsing functions

new extended ACK reporting struct to all of the generic netlink parsing functions. For now, pass NULL in almost all callers (except for some in the core.) Signed-off-by: Johannes Berg <johannes.b...@intel.com> Signed-off-by: David S. Miller <da...@davemloft.net> Signed

[ovs-dev] [PATCH v2 1/2] datapath: Fix refcount leak on force commit.

Upstream commit: commit b768b16de58d5e0b1d7c3f936825b25327ced20c Author: Jarno Rajahalme <ja...@ovn.org> Date: Tue Mar 28 11:25:26 2017 -0700 openvswitch: Fix refcount leak on force commit. The reference count held for skb needs to be released when the skb's

Re: [ovs-dev] [PATCH 3/3] datapath: pass extended ACK struct to parsing functions

> On Apr 19, 2017, at 3:50 PM, Joe Stringer <j...@ovn.org> wrote: > > On 19 April 2017 at 14:35, Jarno Rajahalme <ja...@ovn.org > <mailto:ja...@ovn.org>> wrote: >> From: Johannes Berg <johannes.b...@intel.com> >> >> Upstream commit: >

Re: [ovs-dev] [PATCH 2/3] datapath: Fix ovs_flow_key_update()

OK, will drop this then, thanks! Jarno > -Yi-Hung > > On Wed, Apr 19, 2017 at 2:35 PM, Jarno Rajahalme <ja...@ovn.org> wrote: >> From: Yi-Hung Wei <yihung@gmail.com> >> >> Upstream commit: >> >>commit 6f56f6186c18e3fd54122b73da68e870687b8c5

[ovs-dev] [PATCH 3/3] datapath: pass extended ACK struct to parsing functions

new extended ACK reporting struct to all of the generic netlink parsing functions. For now, pass NULL in almost all callers (except for some in the core.) Signed-off-by: Johannes Berg <johannes.b...@intel.com> Signed-off-by: David S. Miller <da...@davemloft.net> Signed

[ovs-dev] [PATCH 2/3] datapath: Fix ovs_flow_key_update()

<yihung@gmail.com> Acked-by: Jiri Benc <jb...@redhat.com> Signed-off-by: David S. Miller <da...@davemloft.net> Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- datapath/flow.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/datapat

[ovs-dev] [PATCH 1/3] datapath: Fix refcount leak on force commit.

Upstream commit: commit b768b16de58d5e0b1d7c3f936825b25327ced20c Author: Jarno Rajahalme <ja...@ovn.org> Date: Tue Mar 28 11:25:26 2017 -0700 openvswitch: Fix refcount leak on force commit. The reference count held for skb needs to be released when the skb's

Re: [ovs-dev] [PATCH] ofproto: Report only un-deleted groups in group stats replies.

This was an oversight from when we groups were versioned for OF bundle support. Looks good to me, too. Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Apr 19, 2017, at 11:29 AM, Ben Pfaff <b...@ovn.org> wrote: > > Deleted groups hang around in the group table until the ne

Re: [ovs-dev] [PATCH branch-2.7 00/14] Backports for branch-2.7

For the series: Acked-by: Jarno Rajahalme <ja...@ovn.org> One of the userspace changes (indicate if had labels) changes the OVS library interface, so leave it for you to decide what to do with that. Jarno > On Apr 18, 2017, at 5:09 PM, Joe Stringer <j...@ov

Re: [ovs-dev] [PATCH 3/3] ofproto-dpif: Check support for resubmit with conntrack action.

> On Apr 18, 2017, at 8:56 AM, Ben Pfaff <b...@ovn.org> wrote: > > On Fri, Apr 14, 2017 at 05:25:49PM -0700, Jarno Rajahalme wrote: >> Use the existing probed support flag for the original direction tuple >> to determine if resubmit(ct) can be executed or not.

Re: [ovs-dev] [PATCH 2/3] ofproto-dpif: Check if original direction matches are supported.

> On Apr 17, 2017, at 4:47 PM, Ben Pfaff <b...@ovn.org> wrote: > > On Fri, Apr 14, 2017 at 05:25:48PM -0700, Jarno Rajahalme wrote: >> Use the existing probed support flag for the original direction tuple >> to determine if matches on the original direction tuple can

Re: [ovs-dev] [branch-2.7 3/4] ofproto: Add ref counting for variable length mf_fields.

Acked-by: Jarno Rajahalme <ja...@ovn.org> with two notes: 1. Maybe patch 4 should be applied before this one to avoid creating a potential memory leak in the history? 2. taking new references before releasing old ones in modify_flows_start__() would seem better. Since the table

Re: [ovs-dev] [branch-2.7 2/4] nx-match: Use vl_mff_map to parse match field.

Looks good to me: Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Mar 15, 2017, at 4:01 PM, Joe Stringer <j...@ovn.org> wrote: > > From: Yi-Hung Wei <yihung@gmail.com> > > vl_mff_map is introduced in commit 04f48a68c428 ("ofp-actions: Fix variabl

Re: [ovs-dev] [branch-2.7 1/4] nx-match: Fix oxm decode.

This patch should be prepended by a prior patch, as some required changes are now missing: 7befb20d0f70 (“ofp-util: Ignore unknown fields in nx_decode_packet_in2().”) Jarno > On Mar 15, 2017, at 4:01 PM, Joe Stringer wrote: > > From: Yi-Hung Wei > >

Re: [ovs-dev] [PATCH 2/2] dpif: Log packet metadata on execute.

> On Apr 14, 2017, at 8:54 PM, Ben Pfaff <b...@ovn.org> wrote: > > On Thu, Apr 13, 2017 at 04:47:36PM -0700, Jarno Rajahalme wrote: >> Debug log output for execute operations is missing the packet >> metadata, which can be instrumental in tracing what the data

Re: [ovs-dev] [PATCH 1/2] acinclude: Allow compile with Linux 4.11.

> On Apr 14, 2017, at 8:56 PM, Ben Pfaff <b...@ovn.org> wrote: > > On Thu, Apr 13, 2017 at 04:47:35PM -0700, Jarno Rajahalme wrote: >> Change the Linux kernel tests in OVS configuration. >> >> While the backports may still be a little behind, it is useful t

Re: [ovs-dev] [PATCH] ofp-parse: Fix match parsing with [x..y]=z format.

> On Apr 14, 2017, at 8:58 PM, Ben Pfaff <b...@ovn.org> wrote: > > On Thu, Apr 13, 2017 at 06:31:06PM -0700, Jarno Rajahalme wrote: >> Commit 21b2fa617126 ("ofp-parse: Allow match field names in actions >> and brackets in matches.") added support for

[ovs-dev] [PATCH 3/3] ofproto-dpif: Check support for resubmit with conntrack action.

Use the existing probed support flag for the original direction tuple to determine if resubmit(ct) can be executed or not. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- ofproto/ofproto-dpif.c | 86 ++ 1 file changed, 45 insertions(

[ovs-dev] [PATCH 2/3] ofproto-dpif: Check if original direction matches are supported.

Use the existing probed support flag for the original direction tuple to determine if matches on the original direction tuple can be supported. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- ofproto/ofproto-dpif.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-)

[ovs-dev] [PATCH 1/3] ofproto-dpif: Check support for CT action force commit flag.

filled by error messages from the datapath. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- ofproto/ofproto-dpif.c | 8 1 file changed, 8 insertions(+) diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c index 6a5ffb9..c0212f2 100644 --- a/ofproto/ofproto-dpif.c +++ b/o

[ovs-dev] [PATCH] ofp-parse: Fix match parsing with [x..y]=z format.

ched would be incorrect. Fix this and add a test case preventing regression in future. Fixes: 21b2fa617126 ("ofp-parse: Allow match field names in actions and brackets in matches.") Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- lib/ofp-parse.c| 6 +++--- tests/ovs-ofctl.

[ovs-dev] [PATCH 2/2] dpif: Log packet metadata on execute.

Debug log output for execute operations is missing the packet metadata, which can be instrumental in tracing what the datapath should be executing. No reason to have the metadata on the debug output, so add it there. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- lib/dpif.c | 7

Re: [ovs-dev] OVS performance with Kernel Datapath of Linux upstream vs Linux OVS tree.

you will be using a recent OVS release rather than an old one. Jarno > On Thu, 13 Apr 2017, 1:05 AM Jarno Rajahalme, <ja...@ovn.org > <mailto:ja...@ovn.org>> wrote: > > > On Apr 12, 2017, at 12:49 AM, Kapil Adhikesavalu <kapil20...@gmail.com > > <mailto:kapil

Re: [ovs-dev] [PATCH] tests: Add test for CT action with setting labels.

> On Apr 12, 2017, at 2:06 PM, Joe Stringer <j...@ovn.org> wrote: > > On 21 March 2017 at 15:51, Jarno Rajahalme <ja...@ovn.org> wrote: >> This test clearly demonstrates the bit order of labels in the OpenFlow >> wire format. >> >> Signed-off-b

Re: [ovs-dev] OVS performance with Kernel Datapath of Linux upstream vs Linux OVS tree.

> On Apr 12, 2017, at 12:49 AM, Kapil Adhikesavalu wrote: > > Hi, > > Is there any performance difference with using the OVS kernel Datapath > available part of Linux upstream Vs the module built from Linux OVS tree. > OVS tree kernel module has an Exact Match Cache,

Re: [ovs-dev] [PATCH RFC] dpif-netdev: Add Cuckoo Distributor to Accelerate Megaflow Search

Thanks for your contribution! I haven’t looked at the patch yet, but based on the description I’d ask you to characterize the difference and/or feature interaction with the Exact Match Cache (EMC). Particularly, does “orig-ovs” and/or “cd-ovs” have the conditional EMC feature (merged to master

Re: [ovs-dev] [PATCH] datapath: Avoid struct copy on conntrack labels.

Thanks for the review! Applied to master with an explanatory comment, Jarno > On Apr 10, 2017, at 5:11 PM, Andy Zhou <az...@ovn.org> wrote: > > On Sat, Apr 1, 2017 at 8:24 PM, Jarno Rajahalme <ja...@ovn.org > <mailto:ja...@ovn.org>> wrote: >> Olde

[ovs-dev] [PATCH] datapath: Avoid struct copy on conntrack labels.

Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- datapath/conntrack.c| 2 +- tests/system-traffic.at | 18 +- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/datapath/conntrack.c b/datapath/conntrack.c index 4df7352..cb8b3ff 100644 --- a/datapath/conntrack.

Re: [ovs-dev] [PATCH] ovs-ofctl: Document reset_counts, no_packet_counts, no_byte_counts.

Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Mar 30, 2017, at 8:55 AM, Ben Pfaff <b...@ovn.org> wrote: > > Signed-off-by: Ben Pfaff <b...@ovn.org> > --- > utilities/ovs-ofctl.8.in | 31 +-- > 1 file changed, 29 insertion

Re: [ovs-dev] [PATCH 2/2] conntrack: Add formatting support for IGMP, DCCP, and UDPLITE.

> On Mar 28, 2017, at 3:17 PM, Joe Stringer <j...@ovn.org> wrote: > > On 28 March 2017 at 13:43, Jarno Rajahalme <ja...@ovn.org> wrote: >> Print names for protocols that are supported by (Linux) conntrack >> (DCCP, UDPLITE) and IGMP, which has been seen in

[ovs-dev] [PATCH 2/2] conntrack: Add formatting support for IGMP, DCCP, and UDPLITE.

Print names for protocols that are supported by (Linux) conntrack (DCCP, UDPLITE) and IGMP, which has been seen in logs. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- lib/ct-dpif.c | 3 +++ lib/packets.h | 12 2 files changed, 15 insertions(+) diff --git a/lib/ct-dpif.c

[ovs-dev] [PATCH 1/2] netlink-conntrack: Change unsupported IPPROTO log to debug.

No point littering the logs with messages on an unsupported protocol, so change the log to debug level. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- lib/netlink-conntrack.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/netlink-conntrack.c b/lib/n

Re: [ovs-dev] [PATCH] meta-flow: Remove metadata prerequisite on ether type.

Ben & Numan, Thanks for the reviews, pushed to master. Jarno > On Mar 24, 2017, at 11:06 AM, Ben Pfaff <b...@ovn.org> wrote: > > On Wed, Mar 22, 2017 at 04:48:07PM -0700, Jarno Rajahalme wrote: >> Conntrack original direction tuple fields depend on the conntr

Re: [ovs-dev] [PATCH 3/3] ofproto-dpif-xlate.c: Include controller traffic for NetFlow.

ut this then concludes that we must account them anyway. Maybe you mean that even though a copy of the packet is being sent to controller (maybe for logging purposes), we should still NetFlow the original (upcalled) packet. If so: Acked-by: Jarno Rajahalme <ja...@ovn.org> > Signed-off-by

Re: [ovs-dev] [PATCH 2/3] ofproto-dpif-rid: Update comment for recirc_alloc_id__().

Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Mar 22, 2017, at 11:26 PM, Justin Pettit <jpet...@ovn.org> wrote: > > The hash is not recomputed if it is passed in as 0. > > Signed-off-by: Justin Pettit <jpet...@ovn.org> > --- > ofproto/ofproto-dpif-rid.

Re: [ovs-dev] [PATCH 1/3] ofproto-dpif: Update handle_action() comment.

Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Mar 22, 2017, at 11:26 PM, Justin Pettit <jpet...@ovn.org> wrote: > > The comment didn't mention the SLOW_LLDP and SLOW_ACTION reasons. > > Signed-off-by: Justin Pettit <jpet...@ovn.org> > --- > ofproto/ofp

Re: [ovs-dev] [PATCH] Decode the NXT_RESUME message with a loose match.

> On Mar 22, 2017, at 9:05 PM, Numan Siddique <nusid...@redhat.com> wrote: > > > > On Thu, Mar 23, 2017 at 5:19 AM, Jarno Rajahalme <ja...@ovn.org > <mailto:ja...@ovn.org>> wrote: > On Mar 22, 2017, at 1:49 PM, Jarno Rajahalme <ja..

Re: [ovs-dev] [PATCH] mirror: Allow concurrent lookups.

> On Mar 8, 2017, at 4:15 PM, Ben Pfaff <b...@ovn.org> wrote: > > On Tue, Feb 21, 2017 at 07:44:02PM -0800, Jarno Rajahalme wrote: >> Handler threads use a selection of mirror functions with the >> assumption that the data referred to is RCU protected, whil

Re: [ovs-dev] [PATCH] Decode the NXT_RESUME message with a loose match.

On Mar 22, 2017, at 1:49 PM, Jarno Rajahalme <ja...@ovn.org> wrote: > > >> On Mar 22, 2017, at 1:43 PM, Ben Pfaff <b...@ovn.org> wrote: >> >> On Wed, Mar 22, 2017 at 01:40:10PM -0700, Jarno Rajahalme wrote: >>> >>>> On Mar 22, 2017, at 1

[ovs-dev] [PATCH] meta-flow: Remove metadata prerequisite on ether type.

ail/ovs-dev/2017-March/330052.html Fixes: 7befb20d0f70 ("nx-match: Fix oxm decode.") Fixes: daf4d3c18da4 ("odp: Support conntrack orig tuple key.") Suggested-by: Numan Siddique <nusid...@redhat.com> Suggested-by: Ben Pfaff <b...@ovn.org> Signed-off-by: Jarno Raja

Re: [ovs-dev] [PATCH] Decode the NXT_RESUME message with a loose match.

> On Mar 22, 2017, at 1:21 PM, Ben Pfaff wrote: > > On Wed, Mar 22, 2017 at 09:30:36PM +0530, nusid...@redhat.com wrote: >> From: Numan Siddique >> >> When ovs-vswitchd sends the NX_PACKET_IN2 message, it may not >> encode ETH_TYPE of the packet. And with

[ovs-dev] [PATCH] tests: Add test for CT action with setting labels.

This test clearly demonstrates the bit order of labels in the OpenFlow wire format. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- tests/ofp-actions.at | 5 + 1 file changed, 5 insertions(+) diff --git a/tests/ofp-actions.at b/tests/ofp-actions.at index 6f9f5c1..11b3653

Re: [ovs-dev] [PATCH] compiler: Use C11 build assertions with new enough GCC or Clang.

LGTM with one question below, Acked-by: Jarno Rajahalme <ja...@ovn.org> > On Mar 16, 2017, at 2:04 PM, Ben Pfaff <b...@ovn.org> wrote: > > Until now, the BUILD_ASSERT and BUILD_ASSERT_DECL macros have used OVS's > home-grown build assertion strategy. This commit swit

[ovs-dev] [PATCH branch-2.7 25/25] lib: Indicate if netlink message had labels.

Signed-off-by: Jarno Rajahalme <ja...@ovn.org> Acked-by: Joe Stringer <j...@ovn.org> --- lib/ct-dpif.h | 1 + lib/netlink-conntrack.c | 1 + 2 files changed, 2 insertions(+) diff --git a/lib/ct-dpif.h b/lib/ct-dpif.h index 5da3c2c..e8e159a 100644 --- a/lib/ct-dpif.h +++ b/l

[ovs-dev] [PATCH branch-2.7 19/25] datapath: Simplify labels length logic.

Upstream commit: commit b87cec3814ccc7f6afb0a1378ee7e5110d07cdd3 Author: Jarno Rajahalme <ja...@ovn.org> Date: Thu Feb 9 11:21:56 2017 -0800 openvswitch: Simplify labels length logic. Since 23014011ba42 ("netfilter: conntrack: support a fixed size of 128

[ovs-dev] [PATCH branch-2.7 23/25] nx-match: Fix oxm decode.

match. Fixes: 7befb20d0f70 ("ofp-util: Ignore unknown fields in ofputil_decode_packet_in2()") Signed-off-by: Yi-Hung Wei <yihung@gmail.com> Signed-off-by: Joe Stringer <j...@ovn.org> Signed-off-by: Jarno Rajahalme <ja...@ovn.org> --- lib/nx-match.c | 10 +--

[ovs-dev] [PATCH branch-2.7 22/25] ofp-util: Ignore unknown fields in ofputil_decode_packet_in2().

metadata. OVN is already doing this. Signed-off-by: Jarno Rajahalme <ja...@ovn.org> Acked-by: Joe Stringer <j...@ovn.org> --- lib/nx-match.c | 25 - lib/nx-match.h | 4 ++-- lib/ofp-util.c | 5 +++-- 3 files changed, 21 insertions(+), 13 deletions(-) diff --

[ovs-dev] [PATCH branch-2.7 21/25] datapath: Inherit master's labels.

Upstream commit: commit 09aa98ad496d6b11a698b258bc64d7f64c55d682 Author: Jarno Rajahalme <ja...@ovn.org> Date: Thu Feb 9 11:21:58 2017 -0800 openvswitch: Inherit master's labels. We avoid calling into nf_conntrack_in() for expected connections, as that would

[ovs-dev] [PATCH branch-2.7 07/25] datapath: remove unnecessary EXPORT_SYMBOLs

s are really used only by openvswitch.ko. Remove the exports. Tested by loading all 4 openvswitch modules, nothing breaks. Signed-off-by: Jiri Benc <jb...@redhat.com> Acked-by: Pravin B Shelar <pshe...@ovn.org> Signed-off-by: David S. Miller <da...@davemloft

  1   2   3   4   >