Re: [ovs-dev] [PATCH v3 1/2] dpif-netdev: Decrease range of values for EMC probability.

-Original Message- From: Ilya Maximets Date: Monday, August 7, 2017 at 4:54 AM To: "Wang, Yipeng1" , Darrell Ball , "ovs-dev@openvswitch.org" Cc: Heetae Ahn , Kevin Traynor , "Loftus, Ciara" , "Fischetti, Antonio" Subject: Re: [PATCH v3 1/2] dpif-netdev: Decrease range of values for

Re: [ovs-dev] [PATCH v2 2/2] dpif-netdev: Fix emc replacement policy.

Hi Antonio Would you mind sharing your distribution algorithm ? I would like to understand how you saw some benefit in the 1000-5000 range. 1000| 1000, 999 7.85, 8.09 | 1000, 1000 8.77, 8.91 3000| 2993, 2987 7.61, 7.87 | 3000, 3000 8.58, 7.89 5000| 4336, 4872

Re: [ovs-dev] [PATCH 2/3] ovsdb-idl: Avoid new expression.

Thanks for working on it! I think new_ is not a good name. Could you please try to revise it? like: old --> old_datum new -->new_datum BTW, you also need to update 'new' in the description of struct ovsdb_idl_row which in the top of lib/ovsdb-idl-provider.h Thanks Zhenyu Gao 2017-08-08

Re: [ovs-dev] [PATCH 0/7] Add offload support for ip ttl and tcp flags

On Mon, Aug 07, 2017 at 06:19:04PM +0300, Roi Dayan wrote: > Hi, > > This series adds support for offloading ip ttl and tcp flags > using tc interface. This looks nice, thanks. Acked-by: Simon Horman I'm also happy to apply this if someone else provides a review. __

Re: [ovs-dev] [PATCH 1/2] netdev-vport: Always implement get_ifindex for netdev-vport

On Tue, Aug 08, 2017 at 07:36:25AM +0300, Roi Dayan wrote: > > > On 07/08/2017 20:05, Ben Pfaff wrote: > >On Mon, Aug 07, 2017 at 07:00:31AM -0700, Ben Pfaff wrote: > >>On Mon, Aug 07, 2017 at 07:32:02AM +0300, Roi Dayan wrote: > >>>From: Paul Blakey > >>> > >>>Always implement get_ifindex witho

Re: [ovs-dev] [PATCH v3 1/2] dpif-netdev: Decrease range of values for EMC probability.

> -Original Message- > From: Darrell Ball [mailto:db...@vmware.com] > Sent: Tuesday, August 8, 2017 8:12 AM > To: Ilya Maximets ; Wang, Yipeng1 > ; ovs-dev@openvswitch.org > Cc: Heetae Ahn ; Kevin Traynor > ; > Loftus, Ciara ; Fischetti, Antonio > > Subject: Re: [PATCH v3 1/2] dpif-netd

Re: [ovs-dev] [PATCH v3 0/6] netdev-dpdk: Use intermediate queue during packet transmission.

Hi Darrell, >Sorry, I was multitasking last week and did not get a chance to finish the >responses on Friday > >I looked thru. the code for all the patches The last 3 patches of V3 needed a >manual merge; as you know, the series needs a rebase after recent commits. I will rebase and send out v4.

Re: [ovs-dev] [PATCH v3 2/6] netdev-dpdk: Add netdev_dpdk_txq_flush function.

>Hi Bhanu > >Would it be possible to combine patches 1 and 2, rather than initially defining >an empty netdev_txq_flush for dpdk ? I think the combined patch would have >more context. No problem Darrell . I will merge 1 & 2 in V4. - Bhanuprakash. > > >-Original Message- >From: on behal

Re: [ovs-dev] [PATCH v1] netdev-dpdk: Execute QoS Checking before copying to mbuf

Hi Darrell, I am, I've had a cursory look over it already but was planning to do a deeper dive later this week as I have a few concerns about the approach. Ian > -Original Message- > From: Darrell Ball [mailto:db...@vmware.com] > Sent: Tuesday, August 8, 2017 3:07 AM > To: Gao Zhenyu ;

Re: [ovs-dev] [PATCH v3 4/6] netdev-dpdk: Add intermediate queue support.

> >This commit introduces netdev_dpdk_eth_tx_queue() function that >implements intermediate queue and packet buffering. The packets get >buffered till the threshold 'INTERIM_QUEUE_BURST_THRESHOLD[32] is >reached and eventually gets transmitted. > >To handle the case(eg: ping) wh

Re: [ovs-dev] [PATCH v1] netdev-dpdk: Execute QoS Checking before copying to mbuf

Thanks for the review. Please let me know if you have any concern on it. :) Thanks Zhenyu Gao 2017-08-08 17:08 GMT+08:00 Stokes, Ian : > Hi Darrell, > > I am, I've had a cursory look over it already but was planning to do a > deeper dive later this week as I have a few concerns about the approac

[ovs-dev] Hi dear

Good day dear, i hope this mail meets you well? my name is Jack, from the U.S. I know this may seem inappropriate so i ask for your forgiveness but i wish to get to know you better, if I may be so bold. I consider myself an easy-going man, adventurous, honest and fun loving person but I am curr

Re: [ovs-dev] [PATCH v1] netdev-dpdk: Implement TCP/UDP TX cksum in ovs-dpdk side

> > Hi Loftus, > > Thanks for testing and the comments! > Can you show more details about your phy-vm-phy,phy-phy setup and > testing steps? Then I can reproduce it to see if I can solve this pps problem. You're welcome. I forgot to mention my tests were with 64B packets. For phy-phy the setup

Re: [ovs-dev] [PATCH v3 6/6] dpif-netdev: Flush the packets in intermediate queue.

Hi Darrell, > >Under low rate traffic conditions, there can be 2 issues. > (1) Packets potentially can get stuck in the intermediate queue. > (2) Latency of the packets can increase significantly due to > buffering in intermediate queue. > >This commit handles the (1) i

Re: [ovs-dev] [PATCH 1/2] netdev-vport: Always implement get_ifindex for netdev-vport

On 08/08/2017 11:04, Simon Horman wrote: On Tue, Aug 08, 2017 at 07:36:25AM +0300, Roi Dayan wrote: On 07/08/2017 20:05, Ben Pfaff wrote: On Mon, Aug 07, 2017 at 07:00:31AM -0700, Ben Pfaff wrote: On Mon, Aug 07, 2017 at 07:32:02AM +0300, Roi Dayan wrote: From: Paul Blakey Always implem

Re: [ovs-dev] [PATCH v2 2/2] dpif-netdev: Fix emc replacement policy.

> -Original Message- > From: Darrell Ball [mailto:db...@vmware.com] > Sent: Tuesday, August 8, 2017 8:16 AM > To: Fischetti, Antonio ; Ilya Maximets > ; ovs-dev@openvswitch.org > Cc: Heetae Ahn > Subject: Re: [ovs-dev] [PATCH v2 2/2] dpif-netdev: Fix emc replacement policy. > > Hi Anton

Re: [ovs-dev] [PATCH v3 00/19] Add OVS DPDK keep-alive functionality.

HI Ilya, >I understand that using rte_keepalive library was worth in the early RFC >because size of RFC was comparable with the size of rte_keepalive library. >But now, as so many generic things was implemented in lib/keepalive.{c,h} >and the size of the patch-set is pretty large, IMHO, it's bette

Re: [ovs-dev] [PATCH 1/2] netdev-vport: Always implement get_ifindex for netdev-vport

On Tue, Aug 08, 2017 at 01:35:41PM +0300, Roi Dayan wrote: > > > On 08/08/2017 11:04, Simon Horman wrote: > >On Tue, Aug 08, 2017 at 07:36:25AM +0300, Roi Dayan wrote: > >> > >> > >>On 07/08/2017 20:05, Ben Pfaff wrote: > >>>On Mon, Aug 07, 2017 at 07:00:31AM -0700, Ben Pfaff wrote: > On Mon,

Re: [ovs-dev] [ovs-tests] Questions about ovs tests

On Mon, Aug 7, 2017 at 9:04 PM Sam wrote: > Hi all, > > I'm working on ovs tests, and I want to add my test, so I have few > questions: > > 1. what testing frame work does ovs-tests use, as I have seen lots of *.at > file, lots of AT_*() macro. > OVS uses GNU AutoTest. You can read more about

[ovs-dev] [PATCH V3 1/2] netdev-linux: Reduce log level for ENODEV errors getting ifindex

These are normal and unavoidable, because the vifs disappear from the kernel before they are removed them from the OVS database. Signed-off-by: Roi Dayan Reviewed-by: Paul Blakey --- lib/netdev-linux.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/lib/netdev-linux.

[ovs-dev] [PATCH V3 2/2] netdev-vport: Always implement get_ifindex for netdev-vport

From: Paul Blakey Always implement get_ifindex without checking if offload is enabled or not as this should not be related. From ovs-dpctl we cannot tell if offload is enabled or not as other_config is not being read. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Signed-off-by: Ben Pfaff

[ovs-dev] [PATCH V3 0/2] Fix for dumping vxlan flows from ovs-dpctl

Hi, The first patch is to avoid false errors about getting ifindex as the device might disappear already. The second patch is a fix for dumping vxlan rules with ovs-dpctl. V2->V3 - Reorder patches V1->V2 - Bring back ratelimiting Thanks, Roi Paul Blakey (1): netdev-vport: Always imp

[ovs-dev] [PATCH 4/4] netdev-tc-offloads: Add support for action set

From: Paul Blakey Implement support for offloading ovs action set using tc header rewrite action. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan --- lib/netdev-tc-offloads.c | 180 +-- 1 file changed, 176 insertions(+), 4 deletions(-) diff --git

[ovs-dev] [PATCH 1/4] compat: Add act_pedit compatibility for old kernels

From: Paul Blakey Added compatibility for action pedit. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan --- acinclude.m4| 7 include/linux/automake.mk | 1 + include/linux/tc_act/tc_pedit.h | 72 + 3 files changed, 80

[ovs-dev] [PATCH 0/4] Add offload support for action set

Hi, This series adds support for offloading action set using tc interface. Thanks, Roi Paul Blakey (4): compat: Add act_pedit compatibility for old kernels odp-util: Expose ovs flow key attr len table for reuse tc: Add header rewrite using tc pedit action netdev-tc-offloads: Add support

[ovs-dev] [PATCH 3/4] tc: Add header rewrite using tc pedit action

From: Paul Blakey To be later used to implement ovs action set offloading. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan --- lib/tc.c | 372 ++- lib/tc.h | 12 +++ 2 files changed, 381 insertions(+), 3 deletions(-) diff --git a

[ovs-dev] [PATCH 2/4] odp-util: Expose ovs flow key attr len table for reuse

From: Paul Blakey Make ovs_flow_key_attr_lens() public to be reused by other modules. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan --- lib/odp-util.c | 11 +-- lib/odp-util.h | 11 +++ 2 files changed, 12 insertions(+), 10 deletions(-) diff --git a/lib/odp-util.c b/lib/o

Re: [ovs-dev] [PATCH net-next] openvswitch: add NSH support

On Tue, 8 Aug 2017 12:59:40 +0800, Yi Yang wrote: > +struct ovs_key_nsh { > + __u8 flags; > + __u8 mdtype; > + __u8 np; > + __u8 pad; > + __be32 path_hdr; > + __be32 c[4]; "c" is a very poor name. Please rename it to something that expresses what this field contains. Also

[ovs-dev] [PATCH] rhel: Add support for "systemctl reload openvswitch"

The reload procedure will trigger a script that saves the flows and tlv maps then it restarts ovsdb-server, it stops ovs-vswitchd, it sets other_config:flow-restore-wait=true (to wait till flow restore is finished), it starts ovs-vswitchd, it restore the backupped flows/tlv maps and it removes othe

Re: [ovs-dev] [PATCH v5 1/2] OF support and translation of generic encap and decap

I know this comment is late as the patch has been merged already, but I just returned from vacation and only found today: I agree that the new simplified ovs-ofctl syntax for encap properties looks quite neat for the NSH use case at hand: encap(nsh(md_type=1)) encap(nsh(md_type=2,tlv(0x1000,10,

Re: [ovs-dev] [PATCH v3 0/6] netdev-dpdk: Use intermediate queue during packet transmission.

-Original Message- From: "Bodireddy, Bhanuprakash" Date: Tuesday, August 8, 2017 at 1:45 AM To: Darrell Ball , "d...@openvswitch.org" Subject: RE: [ovs-dev] [PATCH v3 0/6] netdev-dpdk: Use intermediate queue during packet transmission. Hi Darrell, >Sorry, I was multitask

Re: [ovs-dev] [PATCH v3 6/6] dpif-netdev: Flush the packets in intermediate queue.

-Original Message- From: "Bodireddy, Bhanuprakash" Date: Tuesday, August 8, 2017 at 2:55 AM To: Darrell Ball , "d...@openvswitch.org" Subject: RE: [ovs-dev] [PATCH v3 6/6] dpif-netdev: Flush the packets in intermediate queue. Hi Darrell, > >Under low rate traffic

Re: [ovs-dev] [ovs-discuss] Regarding CFM/OAM support in Openvswitch

On Tue, Aug 08, 2017 at 02:07:25PM +, ankaiah.nallamek...@wipro.com wrote: > Ethernet CFM/OAM supports Loopback protocol(LBM) and Link Trace > protocol(LTM), Is ovs is supporting these two protocols as well, if so > could you please describe how to use these two protocols. OVS doesn't support

[ovs-dev] DPDK build errors on travis

The travis builds with DPDK enabled and kernel 3.16.46 (e.g. https://travis-ci.org/openvswitch/ovs/jobs/262034416) are failing with the following errors: = Build lib/librte_eal/linuxapp/igb_uio make[1]: Entering directory `/home/travis/build/openvswitch/ovs/linux-3.16.46' WARNING: Symbol version

Re: [ovs-dev] 答复: Re: 答复: Re: 答复: Re: 答复: Re: [PATCH] ovn: Support for taas(tap-as-a-service) function

No problem. Thanks for considering the alternative approach! On Mon, Aug 7, 2017 at 9:12 PM, wrote: > Ok, I will make a new version which have no mirror switch. This may need > some days. > > Thanks > > > > > > Gao Zhenyu > 2017/08/07 22:34 > > 收件人：Ben Pfaff , > 抄送： wa

Re: [ovs-dev] DPDK build errors on travis

We ran these builds many times with 17.05.1 and they were fine. Is Travis switching over to a new build environment ? I saw a notification “This job ran on our Trusty environment, which is gradually becoming our default Linux environment. Read all about this in our blog: Trusty as a default Lin

[ovs-dev] [PATCH v4 0/5] netdev-dpdk: Use intermediate queue during packet transmission.

After packet classification, packets are queued in to batches depending on the matching netdev flow. Thereafter each batch is processed to execute the related actions. This becomes particularly inefficient if there are few packets in each batch as rte_eth_tx_burst() incurs expensive MMIO writes. T

[ovs-dev] [PATCH v4 1/5] netdev: Add netdev_txq_flush function.

Add netdev_txq_flush(), that flush packets on a queue. This is needed to transmit packets on the intermediate queue. This commit also implements netdev_dpdk_txq_flush() function. If there are any packets waiting in the queue, they are transmitted instantly using the rte_eth_tx_burst function. In X

[ovs-dev] [PATCH v4 2/5] netdev-dpdk: Add netdev_dpdk_vhost_txq_flush function.

Add netdev_dpdk_vhost_txq_flush(), that flushes packets on vHost User port queues. Also add netdev_dpdk_vhost_tx_burst() function that uses rte_vhost_enqueue_burst() to enqueue burst of packets on vHost User ports. Signed-off-by: Bhanuprakash Bodireddy Signed-off-by: Antonio Fischetti Co-authore

[ovs-dev] [PATCH v4 3/5] netdev-dpdk: Add intermediate queue support.

This commit introduces netdev_dpdk_eth_tx_queue() function that implements intermediate queue and packet buffering. The packets get buffered till the threshold 'INTERIM_QUEUE_BURST_THRESHOLD[32] is reached and eventually gets transmitted. Signed-off-by: Bhanuprakash Bodireddy Signed-off-by: Anton

[ovs-dev] [PATCH v4 4/5] netdev-dpdk: Enable intermediate queue for vHost User port.

This commit refactors the __netdev_dpdk_vhost_send() and enables intermediate queue where in the packets are buffered till the threshold 'INTERIM_QUEUE_BURST_THRESHOLD[32] is hit and eventually gets transmitted. This commit improves the throughput as reported below in simple Physical to virtual te

[ovs-dev] [PATCH v4 5/5] dpif-netdev: Flush the packets in intermediate queue.

Under low rate traffic conditions, there can be 2 issues. (1) Packets potentially can get stuck in the intermediate queue. (2) Latency of the packets can increase significantly due to buffering in intermediate queue. This commit handles the (1) issue by flushing the tx port queues using

Re: [ovs-dev] [PATCH] rhel: Add support for "systemctl reload openvswitch"

On 8 August 2017 at 07:42, Timothy Redaelli wrote: > The reload procedure will trigger a script that saves the flows and tlv > maps then it restarts ovsdb-server, it stops ovs-vswitchd, it sets > other_config:flow-restore-wait=true (to wait till flow restore is > finished), it starts ovs-vswitchd

Re: [ovs-dev] [PATCH v4 5/5] redhat: allow dpdk to also run as non-root user

On Sun, Aug 6, 2017 at 7:24 AM, Aaron Conole wrote: > Russell Bryant writes: > >> On Fri, Aug 4, 2017 at 1:00 PM, Aaron Conole wrote: >>> After this commit, users may start a dpdk-enabled ovs setup as a >>> non-root user. This is accomplished by exporting the $HOME directory, >>> which dpdk use

Re: [ovs-dev] [PATCH] rhel: Add support for "systemctl reload openvswitch"

On Tue, Aug 8, 2017 at 1:32 PM, Guru Shetty wrote: > On 8 August 2017 at 07:42, Timothy Redaelli wrote: > >> The reload procedure will trigger a script that saves the flows and tlv >> maps then it restarts ovsdb-server, it stops ovs-vswitchd, it sets >> other_config:flow-restore-wait=true (to wai

Re: [ovs-dev] [PATCH v4 5/5] redhat: allow dpdk to also run as non-root user

Russell Bryant writes: > On Sun, Aug 6, 2017 at 7:24 AM, Aaron Conole wrote: >> Russell Bryant writes: >> >>> On Fri, Aug 4, 2017 at 1:00 PM, Aaron Conole wrote: After this commit, users may start a dpdk-enabled ovs setup as a non-root user. This is accomplished by exporting the $HO

Re: [ovs-dev] [PATCH v3 4/6] dpif-netdev: Change rxq_scheduling to use rxq processing cycles.

On 08/01/2017 08:58 AM, Kevin Traynor wrote: Previously rxqs were assigned to pmds by round robin in port/queue order. Now that we have the processing cycles used for existing rxqs, use that information to try and produced a better balanced distribution of rxqs across pmds. i.e. given multiple p

[ovs-dev] [RFC_patch_v1] dp-packet: Reset DPDK HWOL bad checksum flags on init.

Reset the DPDK HWOL checksum bad flags on dp_packet_init_. This is an RFC as these flags should be managed by DPDK. Signed-off-by: Darrell Ball --- lib/dp-packet.c | 1 + lib/dp-packet.h | 9 + 2 files changed, 10 insertions(+) diff --git a/lib/dp-packet.c b/lib/dp-packet.c index 67aa40

Re: [ovs-dev] DPDK build errors on travis

Yes, travis is switching. We need to adapt to it sooner or later. It is possible that the best solution here is to disable the particular warning, for example by adding -Wno-error=inline to some appropriate CFLAGS. Or maybe this line in linux-build.sh needs adjustment: find ./ -type f | xarg

[ovs-dev] [PATCHv2 1/2] netdev: Refactor destruction of netdev_ports.

An upcoming patch will reuse this from elsewhere. Signed-off-by: Joe Stringer --- lib/netdev.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/lib/netdev.c b/lib/netdev.c index 7e9896b82928..3e8b211857d7 100644 --- a/lib/netdev.c +++ b/lib/netdev.c @@ -2255,6

[ovs-dev] [PATCHv2 2/2] dpif: Fix clean up of dpif_ports on dpif_close().

Commit 32b77c316d9982("dpif: Save added ports in a port map.") introduced tracking of all dpif ports by taking a reference on each available netdev when the dpif is opened, but it failed to clear out and release references to these netdevs when the dpif is closed. One of the problems introduced by

Re: [ovs-dev] [PATCH] rhel: Add support for "systemctl reload openvswitch"

On 8 August 2017 at 11:05, Russell Bryant wrote: > On Tue, Aug 8, 2017 at 1:32 PM, Guru Shetty wrote: > > On 8 August 2017 at 07:42, Timothy Redaelli > wrote: > > > >> The reload procedure will trigger a script that saves the flows and tlv > >> maps then it restarts ovsdb-server, it stops ovs-v

Re: [ovs-dev] [PATCH v2] acinclude: netdev-dpdk: use pkg-config of libdpdk

On Tue, Aug 08, 2017 at 07:52:13AM +0200, Christian Ehrhardt wrote: > On Mon, Aug 7, 2017 at 8:42 PM, Ben Pfaff wrote: > > > On Fri, Jul 14, 2017 at 08:36:39AM +0200, Christian Ehrhardt wrote: > > > If available use dpdk pkg-config info of libdpdk to set the right > > > include paths. > > > That

Re: [ovs-dev] [PATCH] dp-packet: Introduce dp_packet_batch_add_unsafe().

On Mon, Aug 7, 2017 at 11:01 PM, Ilya Maximets wrote: > On 07.08.2017 23:24, Andy Zhou wrote: >> On Mon, Aug 7, 2017 at 8:50 AM, Ilya Maximets wrote: >>> Almost all batch usecases covered by the new API introduced >>> in commit 72c84bc2db23 ("dp-packet: Enhance packet batch APIs.") >>> except uns

[ovs-dev] [RFC_patch_v2] dp-packet: Reset DPDK HWOL bad checksum flags on init.

Reset the DPDK HWOL checksum bad flags on dp_packet_init_. This is an RFC as these flags should be managed by DPDK. Signed-off-by: Darrell Ball --- lib/dp-packet.c | 1 + lib/dp-packet.h | 13 + 2 files changed, 14 insertions(+) diff --git a/lib/dp-packet.c b/lib/dp-packet.c index

[ovs-dev] DNS support options

Open vSwitch currently supports only IP addresses for specifying OpenFlow and OVSDB remotes. It would be nice to support DNS names. Open vSwitch can't afford to let DNS resolution block processing, so it needs some way to resolve DNS asynchronously. I've come up with the following solutions so fa

[ovs-dev] [PATCH] python: make python idl unicode-tolerant

Ensure that JSON is utf-8 encoded and that bytes sent/received on the stream sockets are in utf-8 form. Add a test case to verify that unicode column data can be sent/received successfully using Python module. JSON encoder magic to ensure utf-8 encoding suggested by Terry Wilson. Suggested-by: T

Re: [ovs-dev] DNS support options

> From: "Ben Pfaff" > To: d...@openvswitch.org > Sent: Tuesday, August 8, 2017 2:43:17 PM > Subject: [ovs-dev] DNS support options > > Open vSwitch currently supports only IP addresses for specifying > OpenFlow and OVSDB remotes. It would be nice to support DNS names. > Open vSwitch can't afford

Re: [ovs-dev] DNS support options

From: ovs-dev-boun...@openvswitch.org on behalf of Lance Richardson Sent: Tuesday, August 8, 2017 11:59 AM To: Ben Pfaff Cc: d...@openvswitch.org Subject: Re: [ovs-dev] DNS support options > From: "Ben Pfaff" > To: d...@openvswitch.org > Sent: Tuesd

[ovs-dev] [RFC_patch_v3] dp-packet: Reset DPDK HWOL checksum flags on init.

Reset the DPDK HWOL checksum flags on dp_packet_init_. This is an RFC as these flags should be managed by DPDK. Signed-off-by: Darrell Ball --- v2->v3: Use existing API to reset both bad and good HWOL checksum flags. lib/dp-packet.c | 1 + 1 file changed, 1 insertion(+) diff --git a/l

Re: [ovs-dev] DNS support options

On Tue, Aug 08, 2017 at 07:15:26PM +, Shashank Ram wrote: > > Open vSwitch currently supports only IP addresses for specifying > > OpenFlow and OVSDB remotes. It would be nice to support DNS names. > > Open vSwitch can't afford to let DNS resolution block processing, so it > > needs some way t

Re: [ovs-dev] [PATCH v5 1/2] OF support and translation of generic encap and decap

We can add the additional syntax at the same time we add something that has the need for it. On Tue, Aug 08, 2017 at 03:52:32PM +, Jan Scheurich wrote: > I know this comment is late as the patch has been merged already, but I just > returned from vacation and only found today: > > I agree th

Re: [ovs-dev] [PATCHv2 2/2] dpif: Fix clean up of dpif_ports on dpif_close().

Seems good to me! Acked-by: Paul Blakey Thanks On 08/08/2017 21:23, Joe Stringer wrote: Commit 32b77c316d9982("dpif: Save added ports in a port map.") introduced tracking of all dpif ports by taking a reference on each available netdev when the dpif is opened, but it failed to clear out and r

Re: [ovs-dev] DNS support options

On Tue, Aug 08, 2017 at 02:59:21PM -0400, Lance Richardson wrote: > > From: "Ben Pfaff" > > To: d...@openvswitch.org > > Sent: Tuesday, August 8, 2017 2:43:17 PM > > Subject: [ovs-dev] DNS support options > > > > Open vSwitch currently supports only IP addresses for specifying > > OpenFlow and OV

Re: [ovs-dev] [RFC v2] [OVS/NOVA] Vhost-user backends cross-version migration support

On Tue, Jul 18, 2017 at 03:42:08PM +0200, Maxime Coquelin wrote: > This is an revival from a thread I initiated earlier this year [0], that > I had to postpone due to other priorities. > > First, I'd like to thanks reviewers of my first proposal, this new > version tries to address the comments ma

Re: [ovs-dev] [PATCH v3 1/2] ovn-controller: readonly mode binding_run and get_br_int

On Thu, Jul 13, 2017 at 03:54:01PM -0700, Han Zhou wrote: > This change is to prepare for the future change for multi-threading. > Both binding_run() and get_br_int() are needed by pinctrl thread, > but we don't want to update SB DB or create bridges in that scenario, > so need "readonly" mode for

Re: [ovs-dev] [PATCH] rhel: Add support for "systemctl reload openvswitch"

On 08/08/2017 08:24 PM, Guru Shetty wrote: > > > On 8 August 2017 at 11:05, Russell Bryant > wrote: > > On Tue, Aug 8, 2017 at 1:32 PM, Guru Shetty > wrote: > > On 8 August 2017 at 07:42, Timothy Redaelli >

Re: [ovs-dev] [PATCH v3] tnl-ports: Remove netdevs in netdev_hash when deleted

On Thu, Jul 13, 2017 at 02:04:53AM +, fukaige wrote: > > > > -Original Message- > > From: fukaige > > Sent: Tuesday, July 11, 2017 3:34 PM > > To: 'Ben Pfaff' > > Cc: d...@openvswitch.org; Zhaoshenglong > > Subject: RE: [PATCH v3] tnl-ports: Remove netdevs in netdev_hash when > > dele

Re: [ovs-dev] DNS support options

In a project I worked on previously, we used unbound [1] for async DNS, and it worked well for our needs. We liked that DNSSEC was supported out of the box. If you're talking about just doing A/ lookups, that's also supported out of the box. If you want to do fancier things (NAPTR or SRV), then

Re: [ovs-dev] [PATCH v2] ovsschema: Fix line lengths.

On Thu, Jul 13, 2017 at 02:29:39AM +0100, Bhanuprakash Bodireddy wrote: > According to coding style the line lengths should be <=79. Fix the > schema file and update the checksum and version number to reflect the > change. > > Signed-off-by: Bhanuprakash Bodireddy > --- > v1->v2 > * Update vers

Re: [ovs-dev] DNS support options

> From: "Ben Pfaff" > To: "Lance Richardson" > Cc: d...@openvswitch.org > Sent: Tuesday, August 8, 2017 3:48:15 PM > Subject: Re: [ovs-dev] DNS support options > > On Tue, Aug 08, 2017 at 02:59:21PM -0400, Lance Richardson wrote: > > > From: "Ben Pfaff" > > > To: d...@openvswitch.org > > > Sent

Re: [ovs-dev] DNS support options

unbound looks like an excellent choice, thanks for pointing it out. On Tue, Aug 08, 2017 at 08:09:28PM +, Mark Michelson wrote: > In a project I worked on previously, we used unbound [1] for async DNS, and > it worked well for our needs. We liked that DNSSEC was supported out of the > box. If

Re: [ovs-dev] dpdk startup cannot send/recv packet in first serveral seconds

On Wed, Jul 19, 2017 at 10:44:39AM +0800, wenxu wrote: > I just test ovs-dpdk with restart. I found when the dpdk start the > PHYSICAL NIC can't send/recv packet Why is restart performance critical? OVS is designed so that it is rarely necessary to restart it. Usually, restart is only needed for

Re: [ovs-dev] Debugging on openvswitch source code

On Wed, Jul 19, 2017 at 08:57:08PM +0200, NOUGNANKE KOKOUVI BENOIT wrote: > I am trying to understand the openvswitch source code, in order to > customize some treatments. > > For example, I would like, when a packet is received on the OVS bridge, to > know all the functions that are called and th

Re: [ovs-dev] Add detail for ovs-vswitchd.conf.db manpage

Your message had no content. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] vswitch.xml:Add detail variable for forward-bpdu reserved mac address in ovs-vswitchd.conf.db manpage

I guess that you meant to send a patch, but it wasn't included. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCHv2 2/2] dpif: Fix clean up of dpif_ports on dpif_close().

On Tue, Aug 8, 2017 at 11:23 AM, Joe Stringer wrote: > Commit 32b77c316d9982("dpif: Save added ports in a port map.") > introduced tracking of all dpif ports by taking a reference on each > available netdev when the dpif is opened, but it failed to clear out and > release references to these netde

Re: [ovs-dev] DNS support options

On Tue, Aug 08, 2017 at 04:16:21PM -0400, Lance Richardson wrote: > > From: "Ben Pfaff" > > To: "Lance Richardson" > > Cc: d...@openvswitch.org > > Sent: Tuesday, August 8, 2017 3:48:15 PM > > Subject: Re: [ovs-dev] DNS support options > > > > On Tue, Aug 08, 2017 at 02:59:21PM -0400, Lance Rich

Re: [ovs-dev] [patch_v1] docs/dpdk: Consolidate pmd-cpu-mask references.

On Thu, Jul 27, 2017 at 04:50:26PM -0700, Darrell Ball wrote: > The DPDK introductory documentation has various references to > pmd-cpu-mask, including a section devoted to it. These parts of > the documentation seeemed to have been written at different times > and look like they were individually

Re: [ovs-dev] [patch_v1] docs/dpdk: Consolidate pmd-cpu-mask references.

This is on my todo list Ben Looking at Travis now. I will rebase later today. Thanks Darrell -Original Message- From: on behalf of Ben Pfaff Date: Tuesday, August 8, 2017 at 1:51 PM To: Darrell Ball Cc: "d...@openvswitch.org" Subject: Re: [ovs-dev] [patch_v1] docs/dpdk: Consolidate pm

Re: [ovs-dev] DNS support options

- Original Message - > From: "Ben Pfaff" > To: "Lance Richardson" > Cc: d...@openvswitch.org > Sent: Tuesday, August 8, 2017 4:49:52 PM > Subject: Re: [ovs-dev] DNS support options > > On Tue, Aug 08, 2017 at 04:16:21PM -0400, Lance Richardson wrote: > > > From: "Ben Pfaff" > > > To:

[ovs-dev] [PATCH] include: Add struct declaration to ofp-print.h.

If a libopenvswitch user includes ofp-print.h before ofp-util.h (which is standard alphabetical order), and turns on -Werror, then they would hit this compilation error in the include: error: 'struct ofputil_port_map' declared inside parameter list will not be visible outside of this definition or

Re: [ovs-dev] DNS support options

On Tue, Aug 08, 2017 at 04:59:10PM -0400, Lance Richardson wrote: > > > - Original Message - > > From: "Ben Pfaff" > > To: "Lance Richardson" > > Cc: d...@openvswitch.org > > Sent: Tuesday, August 8, 2017 4:49:52 PM > > Subject: Re: [ovs-dev] DNS support options > > > > On Tue, Aug 08,

Re: [ovs-dev] [PATCHv2 2/2] dpif: Fix clean up of dpif_ports on dpif_close().

On 8 August 2017 at 13:48, Andy Zhou wrote: > On Tue, Aug 8, 2017 at 11:23 AM, Joe Stringer wrote: >> Commit 32b77c316d9982("dpif: Save added ports in a port map.") >> introduced tracking of all dpif ports by taking a reference on each >> available netdev when the dpif is opened, but it failed to

[ovs-dev] [PATCH] nsh: Avoid zero-length array.

MSVC allows [] but not [0] for arrays in struct definitions. Reported-by: Alin Serdean Signed-off-by: Ben Pfaff --- include/openvswitch/nsh.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/openvswitch/nsh.h b/include/openvswitch/nsh.h index d9be1e6fa3b4..95210ac04b8

[ovs-dev] [PATCH] m4: Add pkg.m4 from pkg-config.

This way, users do not have to install the m4 file from pkg-config, which was not previously a requirement. Without this change, "configure" fails when pkg.m4 is not available via aclocal: ./configure: line 26189: `    PKG_CHECK_MODULES(DPDK, libdpdk,' Reported-by: Alin Serdean Signed-off-b

Re: [ovs-dev] [PATCH] m4: Add pkg.m4 from pkg-config.

Acked-by: Alin Gabriel Serdean > -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Wednesday, August 9, 2017 12:57 AM > To: d...@openvswitch.org > Cc: Ben Pfaff ; Alin Serdean > > Subject: [PATCH] m4: Add pkg.m4 from pkg-config. > > This way, users do not have to instal

Re: [ovs-dev] [PATCH] m4: Add pkg.m4 from pkg-config.

Thanks, applied to master and branch-2.8. On Tue, Aug 08, 2017 at 09:59:38PM +, Alin Serdean wrote: > Acked-by: Alin Gabriel Serdean > > > -Original Message- > > From: Ben Pfaff [mailto:b...@ovn.org] > > Sent: Wednesday, August 9, 2017 12:57 AM > > To: d...@openvswitch.org > > Cc: Be

[ovs-dev] [PATCH v2] nsh: Avoid zero-length array.

MSVC allows [] but not [0] for arrays in struct definitions, and does not allow nested [] inside a union. Reported-by: Alin Serdean Signed-off-by: Ben Pfaff --- v1->v2: Avoid [] in nested union also. include/openvswitch/nsh.h | 6 +++--- lib/packets.c | 2 +- 2 files changed, 4 ins

Re: [ovs-dev] [PATCH] include: Add struct declaration to ofp-print.h.

On Tue, Aug 08, 2017 at 02:30:28PM -0700, Joe Stringer wrote: > If a libopenvswitch user includes ofp-print.h before ofp-util.h (which > is standard alphabetical order), and turns on -Werror, then they would > hit this compilation error in the include: > > error: 'struct ofputil_port_map' declared

[ovs-dev] [PATCH] ofp-print: #include its own header first.

The OVS coding style document says that a .c file should include the corresponding .h file first, to ensure that the .h file includes all of its dependencies, but this file didn't do that. Signed-off-by: Ben Pfaff --- Depends on https://patchwork.ozlabs.org/patch/799445/. lib/ofp-print.c | 3 ++

Re: [ovs-dev] [PATCH v2] nsh: Avoid zero-length array.

Thanks a lot for the patch! Acked-by: Alin Gabriel Serdean > -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Wednesday, August 9, 2017 2:05 AM > To: d...@openvswitch.org > Cc: Ben Pfaff ; Alin Serdean > > Subject: [PATCH v2] nsh: Avoid zero-length array. > > MSVC al

[ovs-dev] [PATCH] ofproto-dpif: Mark packets as "untracked" after call to ct().

Packet and Connection state is only available to the processing path that follows the "recirc_table" argument of the ct() action. The previous behavior made these states available until the end of the pipeline. This commit changes the behavior so that the Packet and Connection state are cleared f

Re: [ovs-dev] [PATCH v2] nsh: Avoid zero-length array.

Thanks for the review. Applied to master and branch-2.8. On Tue, Aug 08, 2017 at 11:12:01PM +, Alin Serdean wrote: > Thanks a lot for the patch! > > Acked-by: Alin Gabriel Serdean > > > > -Original Message- > > From: Ben Pfaff [mailto:b...@ovn.org] > > Sent: Wednesday, August 9, 2

Re: [ovs-dev] [PATCH] include: Add struct declaration to ofp-print.h.

On 8 August 2017 at 16:10, Ben Pfaff wrote: > On Tue, Aug 08, 2017 at 02:30:28PM -0700, Joe Stringer wrote: >> If a libopenvswitch user includes ofp-print.h before ofp-util.h (which >> is standard alphabetical order), and turns on -Werror, then they would >> hit this compilation error in the inclu

Re: [ovs-dev] [PATCH] ofp-print: #include its own header first.

On 8 August 2017 at 16:11, Ben Pfaff wrote: > The OVS coding style document says that a .c file should include the > corresponding .h file first, to ensure that the .h file includes all of > its dependencies, but this file didn't do that. > > Signed-off-by: Ben Pfaff > --- Acked-by: Joe Stringer

Re: [ovs-dev] [PATCH] ofp-print: #include its own header first.

On Tue, Aug 08, 2017 at 04:23:10PM -0700, Joe Stringer wrote: > On 8 August 2017 at 16:11, Ben Pfaff wrote: > > The OVS coding style document says that a .c file should include the > > corresponding .h file first, to ensure that the .h file includes all of > > its dependencies, but this file didn'

[ovs-dev] [PATCH] netdev-dummy: Close pcap files when dummy device is closed.

Fixes a fd leak. Reported-by: Alin Gabriel Serdean Signed-off-by: Ben Pfaff --- lib/netdev-dummy.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/lib/netdev-dummy.c b/lib/netdev-dummy.c index 752f15765bb2..62ddd0c67834 100644 --- a/lib/netdev-dummy.c +++ b/lib/netdev-dummy.c @@ -708,

Re: [ovs-dev] [PATCH] netdev-dummy: Close pcap files when dummy device is closed.

Acked-by: Alin Gabriel Serdean > -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Wednesday, August 9, 2017 2:37 AM > To: d...@openvswitch.org > Cc: Ben Pfaff ; Alin Serdean > > Subject: [PATCH] netdev-dummy: Close pcap files when dummy device is > closed. > > Fixes a

[ovs-dev] [patch_v4] dp-packet: Reset DPDK HWOL checksum flags on init.

Reset the DPDK HWOL checksum flags in dp_packet_init_. The new HWOL bad checksum flag is uninitialized on non-dpdk ports and this is noticed as test failures using netdev-dummy ports where the bad checksum flag is checked. Fixes: 7451af618e0d ("dp-packet : Update DPDK rx checksum validation funct

  1   2   >