Re: [ovs-dev] [PATCH] ovsdb: Correctly log time since last compaction.

On Wed, Mar 07, 2018 at 10:01:59AM -0800, Ben Pfaff wrote: > file->last_compact is initialized from time_msec() so the difference has > to be computed relative to that clock, not against wall clock time. > > This only affected the log message, not the decision about when to > compact. > >

Re: [ovs-dev] [PATCH] ovsdb: Correctly log time since last compaction.

Ops! I think we sent it in the same minute. Thanks a lot Ben! :) On Wed, Mar 7, 2018 at 7:12 PM, Ben Pfaff wrote: > On Wed, Mar 07, 2018 at 10:01:59AM -0800, Ben Pfaff wrote: > > file->last_compact is initialized from time_msec() so the difference has > > to be computed relative

Re: [ovs-dev] [PATCH] tests: Wait for entire trace to hit log.

On Mon, Mar 05, 2018 at 05:18:52PM -0800, William Tu wrote: > On Mon, Mar 5, 2018 at 5:04 PM, Ben Pfaff wrote: > > "over max translation" appears in the log before the trace, but we're > > checking for the trace immediately after waiting. This changes the test > > to wait for

[ovs-dev] [PATCH] ovsdb: Fix time in log traces when compacting database

Current code is mixing wall and monotonic clocks and the traces are not useful since the timestamps are not accurate. This patch fixes it by using the same time reference for the log as used in the code. Without this patch, the traces look like this: compacting database online (1519124364.908

[ovs-dev] [PATCH] ovsdb: Correctly log time since last compaction.

file->last_compact is initialized from time_msec() so the difference has to be computed relative to that clock, not against wall clock time. This only affected the log message, not the decision about when to compact. Signed-off-by: Ben Pfaff Reported-by: Daniel Alvarez Sanchez

Re: [ovs-dev] *** SPAM *** [PATCH] [RFC] build-windows: Add pthread to windows build

On Mon, Mar 05, 2018 at 02:40:01PM +0200, Alin Gabriel Serdean wrote: > Until know we asked users to download a precompiled library of `pthreads` as > part of the build chain. > > A big problem with this approach is that the precompiled version of pthreads > is built using VS2010 and we must

Re: [ovs-dev] [PATCH] ovsdb: Fix time in log traces when compacting database

On Wed, Mar 07, 2018 at 07:02:30PM +0100, Daniel Alvarez wrote: > Current code is mixing wall and monotonic clocks and the traces are not > useful since the timestamps are not accurate. This patch fixes it by > using the same time reference for the log as used in the code. > > Without this patch,

Re: [ovs-dev] [PATCH] ovn: Calculate UDP checksum for DNS over IPv6

On Wed, Mar 07, 2018 at 09:31:00AM -0600, Mark Michelson wrote: > Unlike IPv4, IPv6 mandates the calculation of the UDP checksum. For DNS > resolution in OVN, we were setting the checksum to 0, which results in > errors. > > This patch fixes the problem by calculating the checksum for DNS over >

Re: [ovs-dev] [PATCH] jsonrpc-py.at: Fix two $PYTHON leftovers

On Wed, Mar 07, 2018 at 04:10:15PM +0100, Timothy Redaelli wrote: > Fix two $PYTHON leftovers. > One in JSONRPC_REQ_REPLY_SUCCESS_PYN and the other in > JSONRPC_REQ_REPLY_ERROR_PYN > > Fixes: 58bed3df484b ("jsonrpc-py.at: Run tests with Python 2 and 3.") > > Signed-off-by: Timothy Redaelli

Re: [ovs-dev] [PATCH] ovn-nb/sbctl: add inactivity probe in ovn-nb/sbctl set-connection

On Wed, Mar 07, 2018 at 01:30:16PM +0800, Guoshuai Li wrote: > From: Dong Jun > > This patch can set inactivity probe for connection by command > ovn-nbctl set-connection inactivity_probe=3 ptcp:6641:0.0.0.0 > ovn-sbctl set-connection inactivity_probe=3

[ovs-dev] [PATCH 1/2] tests: Fix hang when "SSL db: implementation" test failed.

The tests were killing $(cat pid) on failure but needed to kill $(cat ovsdb-server.pid). Reported-by: Alin Gabriel Serdean Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2018-March/344951.html Signed-off-by: Ben Pfaff --- tests/ovsdb-server.at | 17

[ovs-dev] [PATCH 2/2] ovsdb-server: Don't be picky about particular error in test.

On Windows this test reports "Unknown error" instead of "Protocol error", so disregard the particular error message. Reported-by: Alin Gabriel Serdean Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2018-March/344951.html Signed-off-by: Ben Pfaff ---

Re: [ovs-dev] [PATCH] tests-windows: Fix SSL ovsdb test which is hanging

On Tue, Mar 06, 2018 at 01:17:12PM +0200, Alin Gabriel Serdean wrote: > The test: > `1827. ovsdb-server.at:490: testing SSL db: implementation ...` > is hanging on Windows because the returned in the case the client failed to > connect is "Unknown error" vs the normal "Protocol error". > > Update

Re: [ovs-dev] [PATCH 3/3] use flow_table as indirect table

On Tue, Mar 06, 2018 at 11:23:28AM -0800, yipeng wang wrote: > From: Yipeng Wang > > It is not memory efficient to store pointers in the distributor. > In this commit, we store a 2 Byte index which is the index into > flow_table. If the flow table is larger than 2^16, the

Re: [ovs-dev] [PATCH] tests-windows: Make flow extractor work on Windows

Applying this commit adds a file named "c/_2018/march/06/ovs/tests/testsuite.dir/at-groups/42/stderr" to the repo! I think that the failure needs to be indented a bit to un-confuse "git am". When I fix that up, I get the following failure from flake8: ../tests/flowgen.py:17:1: F401 'os' imported

Re: [ovs-dev] [PATCH v2] datapath-windows: Do not drop Ip fragments less than MIN_FRAGMENT_SIZE

Hi Alin, Thanks for reviewing the patch. Can we get this patch applied? Thanks, Anand Kumar On 3/7/18, 3:42 AM, "ovs-dev-boun...@openvswitch.org on behalf of aserd...@ovn.org" wrote: Acked-by: Alin Gabriel Serdean

Re: [ovs-dev] [PATCH 2/2] ovsdb-server: Don't be picky about particular error in test.

Acked-by: Alin Gabriel Serdean > -Mesaj original- > De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele Ben Pfaff > Trimis: Wednesday, March 7, 2018 11:19 PM > Către: d...@openvswitch.org > Cc: Ben Pfaff ; Alin Gabriel Serdean

Re: [ovs-dev] [PATCH] tests-windows: Fix SSL ovsdb test which is hanging

> -Mesaj original- > De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele Ben Pfaff > Trimis: Thursday, March 8, 2018 2:11 AM > Către: aserd...@ovn.org > Cc: d...@openvswitch.org > Subiect: Re: [ovs-dev] [PATCH] tests-windows: Fix SSL ovsdb test which is > hanging >

Re: [ovs-dev] [PATCH v2] datapath-windows: Do not drop Ip fragments less than MIN_FRAGMENT_SIZE

Applied on master! Thanks, Alin. > -Mesaj original- > De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele Anand Kumar > Trimis: Thursday, March 8, 2018 2:16 AM > Către: aserd...@ovn.org; d...@openvswitch.org > Subiect: Re: [ovs-dev] [PATCH v2] datapath-windows: Do

[ovs-dev] [PATCH] ovs-bugtool: Fix ambiguous variable flake8 warnings

Flake8 complains: utilities/bugtool/ovs-bugtool.in:761:5: E741 ambiguous variable name 'l' utilities/bugtool/ovs-bugtool.in:1162:5: E741 ambiguous variable name 'l' Makefile:6193: recipe for target 'flake8-check' failed Signed-off-by: Alin Gabriel Serdean ---

Re: [ovs-dev] [PATCH 1/2] tests: Fix hang when "SSL db: implementation" test failed.

Acked-by: Alin Gabriel Serdean > -Mesaj original- > De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele Ben Pfaff > Trimis: Wednesday, March 7, 2018 11:19 PM > Către: d...@openvswitch.org > Cc: Ben Pfaff ; Alin Gabriel Serdean

Re: [ovs-dev] [PATCH] tests-windows: Fix SSL ovsdb test which is hanging

On Thu, Mar 08, 2018 at 01:45:51AM +0200, aserd...@ovn.org wrote: > > -Mesaj original- > > De la: ovs-dev-boun...@openvswitch.org > boun...@openvswitch.org> În numele Ben Pfaff > > Trimis: Wednesday, March 7, 2018 11:20 PM > > Către: Alin Gabriel Serdean > > Cc:

Re: [ovs-dev] *** SPAM *** [PATCH] [RFC] build-windows: Add pthread to windows build

On Thu, Mar 08, 2018 at 01:20:43AM +0200, aserd...@ovn.org wrote: > If we need the files in the pthread library, why not check in the files? > It seems more straightforward than checking in the tarball, especially if we > need to maintain it ourselves (which seems likely if it is truly

Re: [ovs-dev] [PATCH] tests-windows: Add OpenSSL directory to autotest path

On Tue, Mar 06, 2018 at 01:01:00PM +0200, Alin Gabriel Serdean wrote: > Running OpenSSL unit tests without it already being included in library path > revealed a problem: the AUTOTEST_PATH does not include it. > > This patch adds a new variable `SSL_DIR` which will be added in AUTOTEST_PATH. > >

Re: [ovs-dev] [PATCH] tests-windows: Fix SSL ovsdb test which is hanging

> -Mesaj original- > De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele Ben Pfaff > Trimis: Thursday, March 8, 2018 3:07 AM > Către: aserd...@ovn.org > Cc: d...@openvswitch.org > Subiect: Re: [ovs-dev] [PATCH] tests-windows: Fix SSL ovsdb test which is > hanging >

Re: [ovs-dev] [PATCH] tests-windows: Fix SSL ovsdb test which is hanging

On Thu, Mar 08, 2018 at 02:22:45AM +0200, aserd...@ovn.org wrote: > > -Mesaj original- > > De la: ovs-dev-boun...@openvswitch.org > boun...@openvswitch.org> În numele Ben Pfaff > > Trimis: Thursday, March 8, 2018 2:11 AM > > Către: aserd...@ovn.org > > Cc: d...@openvswitch.org > >

Re: [ovs-dev] [PATCH v2] tests-windows: Make flow extractor work on Windows

On Thu, Mar 08, 2018 at 02:24:19AM +0200, Alin Gabriel Serdean wrote: > +Traceback (most recent call last): > + File "../.././flowgen.py", line 204, in > +flows = os.fdopen(3, 'wb') > +OSError: [Errno 9] Bad file descriptor > ./library.at:4: exit code was 1, expected 0 > > Unfortunately

Re: [ovs-dev] *** SPAM *** [PATCH] [RFC] build-windows: Add pthread to windows build

-Mesaj original- De la: ovs-dev-boun...@openvswitch.org În numele Ben Pfaff Trimis: Wednesday, March 7, 2018 10:53 PM Către: Alin Gabriel Serdean Cc: d...@openvswitch.org Subiect: Re: [ovs-dev] *** SPAM *** [PATCH] [RFC]

Re: [ovs-dev] [PATCH 0/2] ofproto-dpif-xlate: translate action_set in clone action

On Thu, Mar 01, 2018 at 05:59:40PM -0500, Eric Garver wrote: > write_actions() defined inside of a clone() were being ignored. Notably this > affected patch ports between bridges. More details in patch 1. > > travis-ci: https://travis-ci.org/erig0/ovs/builds/347988851 > > Note: Travis failures

Re: [ovs-dev] [PATCH] tests-windows: Fix SSL ovsdb test which is hanging

> -Mesaj original- > De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele Ben Pfaff > Trimis: Wednesday, March 7, 2018 11:20 PM > Către: Alin Gabriel Serdean > Cc: d...@openvswitch.org > Subiect: Re: [ovs-dev] [PATCH] tests-windows: Fix SSL ovsdb

Re: [ovs-dev] [PATCH] tests-windows: Make flow extractor work on Windows

Thanks for the quick review. I removed the import and changed a bit the message. Applied on master. Alin. > -Mesaj original- > De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele Ben Pfaff > Trimis: Wednesday, March 7, 2018 11:07 PM > Către: Alin Gabriel Serdean

Re: [ovs-dev] [PATCH] ovs-bugtool: Fix ambiguous variable flake8 warnings

No worries! > -Mesaj original- > De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele Ben Pfaff > Trimis: Thursday, March 8, 2018 3:25 AM > Către: Alin Gabriel Serdean > Cc: d...@openvswitch.org > Subiect: Re: [ovs-dev] [PATCH] ovs-bugtool: Fix

Re: [ovs-dev] *** SPAM *** [PATCH] [RFC] build-windows: Add pthread to windows build

> -Mesaj original- > De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele Ben Pfaff > Trimis: Thursday, March 8, 2018 2:12 AM > Către: aserd...@ovn.org > Cc: d...@openvswitch.org > Subiect: Re: [ovs-dev] *** SPAM *** [PATCH] [RFC] build-windows: Add > pthread to

[ovs-dev] [PATCH] datapath-windows: Block established TCP connections from creating new CT Entry

Established TCP Connections could potentially form invalid Conntrack Entries when OVS is getting installed or the Conntrack Flows are applied. Prevent this from happening by explicitly requiring SYN packets to be present for creating new Conntrack entries. Signed-off-by: Sairam Venugopal

[ovs-dev] BUSINESS

BUSINESS Respects I’m Abdulhamid Saeed; from United Arab Emirates, and I have contacted you concerning business assistance in UAE. Kindly reply back for more information about the business Many thanks Abdul. ___ dev mailing list

Re: [ovs-dev] [PATCH] tests-windows: Add OpenSSL directory to autotest path

Thanks for the review! Applied on master. Alin. > -Mesaj original- > De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele Ben Pfaff > Trimis: Thursday, March 8, 2018 3:09 AM > Către: Alin Gabriel Serdean > Cc: d...@openvswitch.org > Subiect: Re:

Re: [ovs-dev] [PATCH v2] Upcall/Slowpath rate limiter for OVS

Ben, While digging further on how OFPM_SLOWPATH can be used for rate-limiting upcalls. Here is what I found. 1. Support for OFPM13_SLOWPATH meter already exists in OVS today, but it is tied to USERSPACE action. In netdev-path, handle_packet_upcall() -> dp_netdev_upcall() -> upcall_cb() ->

Re: [ovs-dev] [PATCH v2] datapath-windows: Do not drop Ip fragments less than MIN_FRAGMENT_SIZE

Acked-by: Alin Gabriel Serdean Alin. -Mesaj original- De la: ovs-dev-boun...@openvswitch.org În numele Anand Kumar Trimis: Wednesday, March 7, 2018 1:48 AM Către: d...@openvswitch.org Subiect: [ovs-dev] [PATCH v2] datapath-windows: Do

[ovs-dev] Fw: L.I.U P - Correspondent Contact Detail Survey/Update

Dear Sir or Madam , We are LIU Associates Management Services from Kuala Lumpur, Malaysia, managers of L.I.U P Currently we are going through the process of updating our correspondent list, where your company is listed as a correspondent. Please start by opening the Word document where

[ovs-dev] [PATCH] jsonrpc-py.at: Fix two $PYTHON leftovers

Fix two $PYTHON leftovers. One in JSONRPC_REQ_REPLY_SUCCESS_PYN and the other in JSONRPC_REQ_REPLY_ERROR_PYN Fixes: 58bed3df484b ("jsonrpc-py.at: Run tests with Python 2 and 3.") Signed-off-by: Timothy Redaelli --- tests/jsonrpc-py.at | 4 ++-- 1 file changed, 2

[ovs-dev] [PATCH] ovn: Calculate UDP checksum for DNS over IPv6

Unlike IPv4, IPv6 mandates the calculation of the UDP checksum. For DNS resolution in OVN, we were setting the checksum to 0, which results in errors. This patch fixes the problem by calculating the checksum for DNS over IPv6. It also alters the applicable test by skipping the checksum when

Re: [ovs-dev] [PATCH v7 0/6] OVS-DPDK flow offload with rte_flow

> -Original Message- > From: Yuanhan Liu [mailto:y...@fridaylinux.org] > Sent: Monday, January 29, 2018 7:00 AM > To: d...@openvswitch.org > Cc: Stokes, Ian ; Finn Christensen > ; Darrell Ball ; Chandran, Sugesh >

Re: [ovs-dev] [PATCH v7 1/6] dpif-netdev: associate flow with a mark id

> -Original Message- > From: Yuanhan Liu [mailto:y...@fridaylinux.org] > Sent: Monday, January 29, 2018 7:00 AM > To: d...@openvswitch.org > Cc: Stokes, Ian ; Finn Christensen > ; Darrell Ball ; Chandran, Sugesh >

Re: [ovs-dev] [PATCH v6 2/6] dpif-netdev: retrieve flow directly from the flow mark

> So that we could skip some very costly CPU operations, including but not > limiting to miniflow_extract, emc lookup, dpcls lookup, etc. Thus, > performance could be greatly improved. > > A PHY-PHY forwarding with 1000 mega flows (udp,tp_src=1000-1999) and > 1 million streams (tp_src=1000-1999,

[ovs-dev] [PATCH v6 4/5] stopwatch: Add API for waiting until samples have been processed

From: Jakub Sitnicki Will be used for testing the module. Signed-off-by: Jakub Sitnicki Signed-off-by: Mark Michelson --- lib/stopwatch.c | 34 ++ lib/stopwatch.h | 3 +++ 2 files changed, 29

[ovs-dev] [PATCH v6 1/5] Add stopwatch timing API

This is similar to the existing coverage and perf-counter APIs in OVS. However, rather than keeping counters, this is aimed at timing how long operations take to perform. "Operations" in this case can be anything from a loop iteration, to a function, to something more complex. The library allows

[ovs-dev] [PATCH v6 0/5] Stopwatch Library

This set of commits adds a new library for OVS that allows for measuring the performance of operations in OVS and compiling statistics from these measurements. For developers, this can provide a measurement of something that is either finer or coarser-grained than what is easily measured with a

[ovs-dev] [PATCH v6 3/5] stopwatch: Add API for retrieving calculated statistics

From: Jakub Sitnicki Will be used for testing the module. Signed-off-by: Jakub Sitnicki Signed-off-by: Mark Michelson --- lib/stopwatch.c | 34 ++ lib/stopwatch.h | 13 + 2 files changed, 47

[ovs-dev] [PATCH v6 2/5] Measure timing of ovn-controller loops.

This modifies ovn-controller to measure the amount of time it takes to detect a change in the southbound database and generate the resulting flow table. This may require multiple iterations of the ovn-controller loop. The statistics can be queried using: ovs-appctl -t ovn-controller

[ovs-dev] [PATCH v6 5/5] tests: Add tests for stopwatch module

From: Jakub Sitnicki Check if stopwatch module is calculating statistics as expected. Signed-off-by: Jakub Sitnicki Signed-off-by: Mark Michelson --- lib/stopwatch.c| 2 +- tests/automake.mk | 3 +- tests/library.at

Re: [ovs-dev] [PATCH] rhel: Avoid losing bridge configuration after adding DPDK ports

I've applied this to master and branch-2.9. On Wed, Feb 28, 2018 at 1:22 PM, Ben Pfaff wrote: > Russell, are you the right one to consider applying this? > > On Wed, Feb 28, 2018 at 12:32:23PM +, Vishal Deep Ajmera wrote: >> Hi, >> >> If the patch looks fine I request to get