Re: [ovs-dev] [PATCH v5] netdev-dpdk: support port representors

2019-01-16 Thread Stokes, Ian
> Hi Ian, > > > -Original Message- > > From: Stokes, Ian > > Sent: Wednesday, January 16, 2019 12:37 AM > > To: Kevin Traynor ; Ophir Munk > > ; ovs-dev@openvswitch.org > > Cc: Olga Shern ; Ilya Maximets > > > > Subject: RE: [PATCH v5] netdev-dpdk: support port representors > > > > > On

Re: [ovs-dev] [PATCH v5] netdev-dpdk: support port representors

2019-01-16 Thread Kevin Traynor
On 01/16/2019 10:21 AM, Thomas Monjalon wrote: > 16/01/2019 11:03, Ophir Munk: >> Hi Kevin and thank you for your comments. >> Please see inline... >> >> From: Kevin Traynor >>> On 01/15/2019 09:47 AM, Ophir Munk wrote: Dpdk port representors were introduced in dpdk versions 18.xx.

Re: [ovs-dev] [PATCH v6] Adding support for PMD auto load balancing

2019-01-16 Thread Stokes, Ian
> Port rx queues that have not been statically assigned to PMDs are > currently assigned based on periodically sampled load measurements. > The assignment is performed at specific instances – port addition, port > deletion, upon reassignment request via CLI etc. > > Due to change in traffic

Re: [ovs-dev] [PATCH v3] dpif-netdev: Per-port configurable EMC.

2019-01-16 Thread Stokes, Ian
> Conditional EMC insert helps a lot in scenarios with high numbers of > parallel flows, but in current implementation this option affects all the > threads and ports at once. There are scenarios where we have different > number of flows on different ports. For example, if one of the VMs >

Re: [ovs-dev] [PATCH v5] netdev-dpdk: support port representors

2019-01-16 Thread Aaron Conole
"Stokes, Ian" writes: >> Dpdk port representors were introduced in dpdk versions 18.xx. >> Prior to port representors there was a one-to-one relationship between an >> rte device (e.g. PCI bus) and an eth device (referenced as dpdk port id in >> OVS). With port representors the relationship

Re: [ovs-dev] Fix OpenFlow v1.3.4 Conformance test failures: 430.500, 430.510

2019-01-16 Thread Aaron Conole
"Iyengar, Prashanth" writes: > From fc0a9e1329573692c04438370f85e87125a268b0 Mon Sep 17 00:00:00 2001 > From: Prashanth Iyengar > Date: Mon, 14 Jan 2019 12:53:11 -0800 > Subject: [PATCH] Fix OpenFlow v1.3.4 Conf test failures: 430.500, 430.510 > > This commit adds additional verification to

Re: [ovs-dev] [PATCH branch-2.9 1/1] netdev-dpdk: Fix flow control configuration.

2019-01-16 Thread Stokes, Ian
> On 12/12/2018 22:18, Ian Stokes wrote: > > From: Sugesh Chandran > > > > Currently devices that do not support configuring flow control via the > > eth_dev API (e.g. SRIOV VFs) will fail during configuration setup when > > the interface is added even if flow control is not requested. This is >

Re: [ovs-dev] [PATCH v2] dpif-netdev: Per-port configurable EMC.

2019-01-16 Thread Ilya Maximets
On 20.11.2018 19:19, Ilya Maximets wrote: > Conditional EMC insert helps a lot in scenarios with high numbers > of parallel flows, but in current implementation this option affects > all the threads and ports at once. There are scenarios where we have > different number of flows on different

Re: [ovs-dev] [PATCH v1] travis: Add dpdk shared library build.

2019-01-16 Thread Lam, Tiago
On 09/11/2018 14:02, Ian Stokes wrote: > Add travis builds for DPDK as a shared library. > > Currently the DPDK builds in travis only compile DPDK as a static library. > With static builds in DPDK there is a risk that if a function is not > exported then it will not be supported when DPDK is used

Re: [ovs-dev] [PATCH v5] netdev-dpdk: support port representors

2019-01-16 Thread Kevin Traynor
On 01/16/2019 11:06 AM, Thomas Monjalon wrote: > 16/01/2019 11:56, Kevin Traynor: >> On 01/16/2019 10:21 AM, Thomas Monjalon wrote: >>> 16/01/2019 11:03, Ophir Munk: Hi Kevin and thank you for your comments. Please see inline... From: Kevin Traynor > On 01/15/2019 09:47

Re: [ovs-dev] [PATCH v1] Fix crash due to multiple tnl push action

2019-01-16 Thread Stokes, Ian
> On 16/01/2019 09:30, Anju Thomas wrote: > > > > Hi Folks, > > > > Are these changes planned to be merged as well? > > > > Regards > > Anju > > Hi Anju, > > Unfortunately, no. An RFC based on the below was proposed to the mailing > list here [1], but no discussion / comments happened after

Re: [ovs-dev] [PATCH v5] netdev-dpdk: support port representors

2019-01-16 Thread Kevin Traynor
On 01/16/2019 11:50 AM, Thomas Monjalon wrote: > 16/01/2019 12:38, Kevin Traynor: >> On 01/16/2019 11:06 AM, Thomas Monjalon wrote: >>> 16/01/2019 11:56, Kevin Traynor: On 01/16/2019 10:21 AM, Thomas Monjalon wrote: > But honestly, I doubt you need to talk about representors in this

[ovs-dev] [PATCH v3] dpif-netdev: Per-port configurable EMC.

2019-01-16 Thread Ilya Maximets
Conditional EMC insert helps a lot in scenarios with high numbers of parallel flows, but in current implementation this option affects all the threads and ports at once. There are scenarios where we have different number of flows on different ports. For example, if one of the VMs encapsulates

[ovs-dev] Thankfully

2019-01-16 Thread Phee Rujiphan
___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v1] Fix crash due to multiple tnl push action

2019-01-16 Thread Anju Thomas
Hi Ian, Thanks for getting back . I agree that the patch Tiago has posted in the latest needs more testing but this is more sort of an improvement. Can we merge the first part of the problem as addressed in https://mail.openvswitch.org/pipermail/ovs-dev/2018-May/346649.html This will

Re: [ovs-dev] [PATCH v5] netdev-dpdk: support port representors

2019-01-16 Thread Thomas Monjalon
16/01/2019 12:38, Kevin Traynor: > On 01/16/2019 11:06 AM, Thomas Monjalon wrote: > > 16/01/2019 11:56, Kevin Traynor: > >> On 01/16/2019 10:21 AM, Thomas Monjalon wrote: > >>> But honestly, I doubt you need to talk about representors in this patch. > >>> The change is to support multi-ports

[ovs-dev] [PATCH RFC] stt: fix return code during xmit

2019-01-16 Thread Aaron Conole
Following code looks like it might be wrong. I don't know much about the way the stt infrastructure is being used, so feel free to ignore if it is expected to return NETDEV_TX_OK even in error cases (just seems strange). Caught by compiler warning:

Re: [ovs-dev] [PATCH v1] travis: Add dpdk shared library build.

2019-01-16 Thread Kevin Traynor
On 11/09/2018 02:02 PM, Ian Stokes wrote: > Add travis builds for DPDK as a shared library. > > Currently the DPDK builds in travis only compile DPDK as a static library. > With static builds in DPDK there is a risk that if a function is not > exported then it will not be supported when DPDK is

[ovs-dev] [PATCH 0/2] ovn: Fix IPAM for connected logical router ports

2019-01-16 Thread Mark Michelson
Note: This patch will require backporting to 2.10 as well. ovn-kubernetes uses a pattern where they have a "join" switch that connects to multiple gateway routers. They make use of IPAM on the switch to allocate IP addresses on the switch ports. They then create the logical router port, connect

[ovs-dev] [PATCH 1/2] ovn: Clear dynamic_addresses when addresses are not "dynamic"

2019-01-16 Thread Mark Michelson
When a logical switch port changes to no longer use "dynamic" addresses, then the dynamic_addresses should be cleared. Reported-by: Girish Moodalbail Signed-off-by: Mark Michelson --- ovn/northd/ovn-northd.c | 2 +- tests/ovn.at| 19 +++ 2 files changed, 20

Re: [ovs-dev] [PATCH v4] netdev-dpdk: support port representors

2019-01-16 Thread Ophir Munk
Hi Ilya and thanks for your comments. Please see inline > -Original Message- > From: Ilya Maximets > Sent: Tuesday, January 15, 2019 11:16 AM > To: Ophir Munk ; ovs-dev@openvswitch.org > Cc: Asaf Penso ; Ian Stokes ; > Shahaf Shuler ; Thomas Monjalon > ; Olga Shern ; Kevin Traynor > >

Re: [ovs-dev] [PATCH v1] travis: Add dpdk shared library build.

2019-01-16 Thread Stokes, Ian
> On Wed, Jan 16, 2019 at 05:05:24PM +, Stokes, Ian wrote: > > > On 11/09/2018 02:02 PM, Ian Stokes wrote: > > > > Add travis builds for DPDK as a shared library. > > > > > > > > Currently the DPDK builds in travis only compile DPDK as a static > > > library. > > > > With static builds in DPDK

Re: [ovs-dev] [PATCH v5] netdev-dpdk: support port representors

2019-01-16 Thread Ilya Maximets
Not a full review. Comments inline. Best regards, Ilya Maximets. On 15.01.2019 12:17, Ophir Munk wrote: > Dpdk port representors were introduced in dpdk versions 18.xx. > Prior to port representors there was a one-to-one relationship > between an rte device (e.g. PCI bus) and an eth device

Re: [ovs-dev] [PATCH v1] travis: Add dpdk shared library build.

2019-01-16 Thread Aaron Conole
"Lam, Tiago" writes: > On 09/11/2018 14:02, Ian Stokes wrote: >> Add travis builds for DPDK as a shared library. >> >> Currently the DPDK builds in travis only compile DPDK as a static library. >> With static builds in DPDK there is a risk that if a function is not >> exported then it will not

Re: [ovs-dev] [PATCH] Un-revert Work around Python/C JSON unicode differences

2019-01-16 Thread Ben Pfaff
On Wed, Jan 16, 2019 at 09:22:07AM +0100, Daniel Alvarez Sanchez wrote: > Thanks for this! > > On Tue, Jan 15, 2019 at 8:48 PM Ben Pfaff wrote: > > > > On Mon, Jan 14, 2019 at 08:15:36AM -0600, Terry Wilson wrote: > > > This fix was reverted because it depended on a small bit of code > > > in a

[ovs-dev] [PATCH RFC] stt: fix return code during xmit

2019-01-16 Thread Aaron Conole
Following code looks like it might be wrong. I don't know much about the way the stt infrastructure is being used, so feel free to ignore if it is expected to return NETDEV_TX_OK even in error cases (just seems strange). --- datapath/ ___ dev mailing

Re: [ovs-dev] [PATCH v4] netdev-dpdk: support port representors

2019-01-16 Thread Ilya Maximets
On 16.01.2019 20:36, Ophir Munk wrote: > Hi Ilya and thanks for your comments. > Please see inline > >> -Original Message- >> From: Ilya Maximets >> Sent: Tuesday, January 15, 2019 11:16 AM >> To: Ophir Munk ; ovs-dev@openvswitch.org >> Cc: Asaf Penso ; Ian Stokes ; >> Shahaf Shuler ;

Re: [ovs-dev] [PATCH v1] travis: Add dpdk shared library build.

2019-01-16 Thread Ben Pfaff
On Wed, Jan 16, 2019 at 05:05:24PM +, Stokes, Ian wrote: > > On 11/09/2018 02:02 PM, Ian Stokes wrote: > > > Add travis builds for DPDK as a shared library. > > > > > > Currently the DPDK builds in travis only compile DPDK as a static > > library. > > > With static builds in DPDK there is a

Re: [ovs-dev] [PATCH v3] rhel: Split OpenvSwitch and OVN packages

2019-01-16 Thread Flavio Leitner
On Wed, Jan 16, 2019 at 01:31:24AM +0530, nusid...@redhat.com wrote: > From: Numan Siddique > > Up until now, OVN rpms were generated as sub packages of OpenvSwitch. > This patch now splits it and makes OVN rpms independent. > > A new spec file - ovn-fedora.spec.in is added for this. > The

[ovs-dev] [PATCH 2/2] ovn: Add port addresses to IPAM later.

2019-01-16 Thread Mark Michelson
ipam_add_port_adresses() needs to be called after the peer field is set on the ovn_port structures. This way, addresses taken by peered router ports will be added to the logical switch's IPAM and therefore will be barred from assignment to other ports. Reported-by: Girish Moodalbail

Re: [ovs-dev] [PATCH v1] travis: Add dpdk shared library build.

2019-01-16 Thread Stokes, Ian
> On 11/09/2018 02:02 PM, Ian Stokes wrote: > > Add travis builds for DPDK as a shared library. > > > > Currently the DPDK builds in travis only compile DPDK as a static > library. > > With static builds in DPDK there is a risk that if a function is not > > exported then it will not be supported

[ovs-dev] [PATCH v3] Policy-based routing (PBR) provides a mechanism to configure permit/deny and reroute policies on the router. Permit/deny policies are similar to OVN ACLs, but exist on the logical

2019-01-16 Thread Mary Manohar
Policy-based routing (PBR) provides a mechanism to configure permit/deny and reroute policies on the router. Permit/deny policies are similar to OVN ACLs, but exist on the logical-router. Reroute policies are needed for service-insertion and service-chaining. Currently, policies are stateless.

[ovs-dev] [PATCH v3] Policy-based routing

2019-01-16 Thread Mary Manohar
Mary Manohar (1): Policy-based routing (PBR) provides a mechanism to configure permit/deny and reroute policies on the router. Permit/deny policies are similar to OVN ACLs, but exist on the logical-router. Reroute policies are needed for service-insertion and service-chaining.

Re: [ovs-dev] [PATCH v3] Policy-based routing (PBR) provides a mechanism to configure permit/deny and reroute policies on the router. Permit/deny policies are similar to OVN ACLs, but exist on the log

2019-01-16 Thread Ben Pfaff
On Wed, Jan 16, 2019 at 07:01:13PM +, Mary Manohar wrote: > Policy-based routing (PBR) provides a mechanism to configure permit/deny and > reroute policies on the router. > Permit/deny policies are similar to OVN ACLs, but exist on the logical-router. > Reroute policies are needed for

Re: [ovs-dev] [PATCH v2] Monitor Database table to manage lifecycle of IDL client.

2019-01-16 Thread Ben Pfaff
On Fri, Jan 04, 2019 at 02:16:36AM +, Ted Elhourani wrote: > The Python IDL implementation supports ovsdb cluster connections. > This patch is a follow up to commit 31e434fc98, it adds the option of > connecting to the leader (the default) in the Raft-based cluster. It mimics > the exisiting C

Re: [ovs-dev] Policy-based routing (PBR) provides a mechanism to configure permit/deny and reroute policies on the router. Permit/deny policies are similar to OVN ACLs, but exist on the logical-router

2019-01-16 Thread 0-day Robot
Bleep bloop. Greetings Mary Manohar, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Inappropriate bracing around statement #101 FILE: ovn/northd/ovn-northd.c:4698: if

[ovs-dev] [PATCH] sandbox: Fix env for clustered OVN DBs.

2019-01-16 Thread Han Zhou
From: Han Zhou When ovn clustered mode is specified, the environment veriables OVN_NB_DB/OVN_SB_DB are wrong. It should be something like unix:nb1,unix:nb2,unix:nb3 but it turns out to be unix:nb1,unix:nb1,unix:nb2. So when nb3 becomes leader, the connection will always fail. It is caused by

Re: [ovs-dev] Fix OpenFlow v1.3.4 Conformance test failures: 430.500, 430.510

2019-01-16 Thread Iyengar, Prashanth
Hi Aaron, Apologies for the formatting issues earlier. Attached the patch to the message here as suggested. Let me know if this works. Otherwise, will look to submit a pull request. Sorry for the inconvenience. Thanks, Prashanth -Original Message- From: Aaron Conole Sent: Wednesday,

[ovs-dev] [PATCH] ofp-actions: Avoid overflow for ofpact_learn_spec->n_bits

2019-01-16 Thread Yifeng Sun
ofpact_learn_spec->n_bits is the size of immediate data that is following ofpact_learn_spec. Now it is defined as 'uint8_t'. In many places, it gets its value directly from mf_subfield->n_bits, whose type is 'unsigned int'. If input is large enough, there will be uint8_t overflow. For example,

Re: [ovs-dev] [PATCH 2/2] ovn: Add port addresses to IPAM later.

2019-01-16 Thread Ben Pfaff
On Wed, Jan 16, 2019 at 10:37:06AM -0500, Mark Michelson wrote: > ipam_add_port_adresses() needs to be called after the peer field is set > on the ovn_port structures. This way, addresses taken by peered router > ports will be added to the logical switch's IPAM and therefore will be > barred from

Re: [ovs-dev] [PATCH v3] dpif-netdev: Per-port configurable EMC.

2019-01-16 Thread Kevin Traynor
On 01/16/2019 01:13 PM, Stokes, Ian wrote: >> Conditional EMC insert helps a lot in scenarios with high numbers of >> parallel flows, but in current implementation this option affects all the >> threads and ports at once. There are scenarios where we have different >> number of flows on different

[ovs-dev] [PATCH 1/2] v2.10 ovn: Clear dynamic_addresses when addresses are not "dynamic"

2019-01-16 Thread Mark Michelson
When a logical switch port changes to no longer use "dynamic" addresses, then the dynamic_addresses should be cleared. Reported-by: Girish Moodalbail Signed-off-by: Mark Michelson Signed-off-by: Ben Pfaff --- ovn/northd/ovn-northd.c | 2 +- tests/ovn.at| 19 +++ 2

[ovs-dev] [PATCH 0/2] v2.10 ovn: Fix IPAM for connected logical router ports

2019-01-16 Thread Mark Michelson
ovn-kubernetes uses a pattern where they have a "join" switch that connects to multiple gateway routers. They make use of IPAM on the switch to allocate IP addresses on the switch ports. They then create the logical router port, connect the switch port to it, and copy the assigned addresses to the

[ovs-dev] [PATCH 2/2] v2.10 ovn: Add port addresses to IPAM later.

2019-01-16 Thread Mark Michelson
ipam_add_port_adresses() needs to be called after the peer field is set on the ovn_port structures. This way, addresses taken by peered router ports will be added to the logical switch's IPAM and therefore will be barred from assignment to other ports. Reported-by: Girish Moodalbail

Re: [ovs-dev] [PATCH 2/2] ovn: Add port addresses to IPAM later.

2019-01-16 Thread Mark Michelson
On 1/16/19 1:47 PM, Ben Pfaff wrote: On Wed, Jan 16, 2019 at 10:37:06AM -0500, Mark Michelson wrote: ipam_add_port_adresses() needs to be called after the peer field is set on the ovn_port structures. This way, addresses taken by peered router ports will be added to the logical switch's IPAM

Re: [ovs-dev] [PATCH v2] Monitor Database table to manage lifecycle of IDL client.

2019-01-16 Thread Ted Elhourani
Hi Numan, Thanks for the review, please find responses inline. Ted On Jan 11, 2019, at 2:23 AM, Numan Siddique mailto:nusid...@redhat.com>> wrote: On Fri, Jan 4, 2019 at 5:26 PM Numan Siddique mailto:nusid...@redhat.com>> wrote: Hi Ted, This patch is failing the below test cases for me.

Re: [ovs-dev] [PATCH v5] :Improved Packet Drop Statistics in OVS

2019-01-16 Thread Ben Pfaff
On Mon, Jan 07, 2019 at 09:59:24AM +, Anju Thomas wrote: > Currently OVS maintains explicit packet drop/error counters only on port > level. Packets that are dropped as part of normal OpenFlow processing are > counted in flow stats of “drop” flows or as table misses in table stats.

Re: [ovs-dev] [PATCH] Support for match & set ICMPv6 reserved and options type fields

2019-01-16 Thread Ben Pfaff
On Wed, Jan 16, 2019 at 12:40:48PM -0800, Ben Pfaff wrote: > On Fri, Jan 11, 2019 at 08:32:48AM +, Vishal Deep Ajmera wrote: > > Currently OVS supports all ARP protocol fields as OXM match fields to > > implement the relevant ARP procedures for IPv4. This includes support > > for matching

Re: [ovs-dev] [PATCH v3] Policy-based routing (PBR) provides a mechanism to configure permit/deny and reroute policies on the router. Permit/deny policies are similar to OVN ACLs, but exist on the log

2019-01-16 Thread Ben Pfaff
On Wed, Jan 16, 2019 at 12:32:02PM -0800, Ben Pfaff wrote: > On Wed, Jan 16, 2019 at 07:01:13PM +, Mary Manohar wrote: > > Policy-based routing (PBR) provides a mechanism to configure permit/deny > > and reroute policies on the router. > > Permit/deny policies are similar to OVN ACLs, but

Re: [ovs-dev] [PATCH v5] netdev-dpdk: support port representors

2019-01-16 Thread Ophir Munk
> -Original Message- > From: Kevin Traynor > Sent: Tuesday, January 15, 2019 4:20 PM > To: Ophir Munk ; ovs-dev@openvswitch.org > Cc: Ian Stokes ; Olga Shern ; Ilya > Maximets > Subject: Re: [PATCH v5] netdev-dpdk: support port representors > > On 01/15/2019 09:47 AM, Ophir Munk

Re: [ovs-dev] [RFC v2 2/2] lib/tc: add set ipv6 traffic class action offload via pedit

2019-01-16 Thread Ben Pfaff
On Wed, Jan 16, 2019 at 09:04:16AM +, Pieter Jansen van Vuuren wrote: > +/* These functions specifically help shifting values that are in > + * network byte order but stored in uint32_t variables. */ > +static uint32_t shift_ovs_be32_left(uint32_t word, int shift) > +{ > +uint32_t

[ovs-dev] [PATCH] ofpbuf: Reintroduce assertion on size in ofpbuf_pull().

2019-01-16 Thread Ben Pfaff
This assertion was removed as part of a commit that was intended to just be a cleanup. Fixes: 6fd6ed71cb9f ("ofpbuf: Simplify ofpbuf API.") Signed-off-by: Ben Pfaff --- include/openvswitch/ofpbuf.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/openvswitch/ofpbuf.h

[ovs-dev] [PATCH v2] odp-util: Fix a bug in parse_odp_push_nsh_action

2019-01-16 Thread Yifeng Sun
In this piece of code, 'struct ofpbuf b' should always point to metadata so that metadata can be filled with values through ofpbuf operations, like ofpbuf_put_hex and ofpbuf_push_zeros. However, ofpbuf_push_zeros may change the data pointer of 'struct ofpbuf b' and therefore, metadata will not

Re: [ovs-dev] [PATCH] Support for match & set ICMPv6 reserved and options type fields

2019-01-16 Thread Ben Pfaff
On Fri, Jan 11, 2019 at 08:32:48AM +, Vishal Deep Ajmera wrote: > Currently OVS supports all ARP protocol fields as OXM match fields to > implement the relevant ARP procedures for IPv4. This includes support > for matching copying and setting ARP fields. In IPv6 ARP has been > replaced by

Re: [ovs-dev] [PATCH 0/2] v2.10 ovn: Fix IPAM for connected logical router ports

2019-01-16 Thread Ben Pfaff
On Wed, Jan 16, 2019 at 02:46:28PM -0500, Mark Michelson wrote: > ovn-kubernetes uses a pattern where they have a "join" switch that > connects to multiple gateway routers. They make use of IPAM on the > switch to allocate IP addresses on the switch ports. They then create > the logical router

Re: [ovs-dev] [PATCH] openvswitch: Avoid OOB read when parsing flow nlattrs

2019-01-16 Thread David Miller
From: Ross Lagerwall Date: Mon, 14 Jan 2019 09:16:56 + > For nested and variable attributes, the expected length of an attribute > is not known and marked by a negative number. This results in an OOB > read when the expected length is later used to check if the attribute is > all zeros. Fix

Re: [ovs-dev] [PATCH v2] Monitor Database table to manage lifecycle of IDL client.

2019-01-16 Thread Ted Elhourani
Sure, I fixed and verified with “make flake8-check”. Ted > On Jan 16, 2019, at 12:29 PM, Ben Pfaff wrote: > > On Fri, Jan 04, 2019 at 02:16:36AM +, Ted Elhourani wrote: >> The Python IDL implementation supports ovsdb cluster connections. >> This patch is a follow up to commit 31e434fc98, it

Re: [ovs-dev] ovsdb-server: Correct json-rpc comment for "disable-monitor-cond".

2019-01-16 Thread 0-day Robot
Bleep bloop. Greetings Justin Pettit, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Justin Pettit needs to sign off. Lines checked: 26, Warnings: 0, Errors: 1

Re: [ovs-dev] [PATCH v2] odp-util: Fix a bug in parse_odp_push_nsh_action

2019-01-16 Thread Ben Pfaff
On Wed, Jan 16, 2019 at 02:36:50PM -0800, Yifeng Sun wrote: > In this piece of code, 'struct ofpbuf b' should always point to > metadata so that metadata can be filled with values through ofpbuf > operations, like ofpbuf_put_hex and ofpbuf_push_zeros. However, > ofpbuf_push_zeros may change the

Re: [ovs-dev] [PATCH] ovsdb-server: Correct json-rpc comment for "disable-monitor-cond".

2019-01-16 Thread Ben Pfaff
On Wed, Jan 16, 2019 at 02:52:51PM -0800, Justin Pettit wrote: > --- > ovsdb/ovsdb-server.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ovsdb/ovsdb-server.c b/ovsdb/ovsdb-server.c > index 8d213b27aae1..65a47a41d382 100644 > --- a/ovsdb/ovsdb-server.c > +++

[ovs-dev] [PATCH] ovsdb-server: Correct json-rpc comment for "disable-monitor-cond".

2019-01-16 Thread Justin Pettit
--- ovsdb/ovsdb-server.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ovsdb/ovsdb-server.c b/ovsdb/ovsdb-server.c index 8d213b27aae1..65a47a41d382 100644 --- a/ovsdb/ovsdb-server.c +++ b/ovsdb/ovsdb-server.c @@ -1409,7 +1409,7 @@ ovsdb_server_disable_monitor_cond(struct

Re: [ovs-dev] [PATCH] ovn: Add DHCP support for option 67 - bootfile name

2019-01-16 Thread Ben Pfaff
On Mon, Jan 14, 2019 at 06:03:42PM +0530, nusid...@redhat.com wrote: > From: Numan Siddique > > Signed-off-by: Numan Siddique Thanks, applied to master. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v3] rhel: Split OpenvSwitch and OVN packages

2019-01-16 Thread Ben Pfaff
On Wed, Jan 16, 2019 at 03:28:29PM -0200, Flavio Leitner wrote: > On Wed, Jan 16, 2019 at 01:31:24AM +0530, nusid...@redhat.com wrote: > > From: Numan Siddique > > > > Up until now, OVN rpms were generated as sub packages of OpenvSwitch. > > This patch now splits it and makes OVN rpms

Re: [ovs-dev] [PATCH] Support for match & set ICMPv6 reserved and options type fields

2019-01-16 Thread Ben Pfaff
On Fri, Jan 11, 2019 at 08:32:48AM +, Vishal Deep Ajmera wrote: > Currently OVS supports all ARP protocol fields as OXM match fields to > implement the relevant ARP procedures for IPv4. This includes support > for matching copying and setting ARP fields. In IPv6 ARP has been > replaced by

[ovs-dev] [PATCH v3] Monitor Database table to manage lifecycle of IDL client.

2019-01-16 Thread Ted Elhourani
The Python IDL implementation supports ovsdb cluster connections. This patch is a follow up to commit 31e434fc98, it adds the option of connecting to the leader (the default) in the Raft-based cluster. It mimics the exisiting C IDL support for clusters introduced in commit 1b1d2e6daa. The _Server

Re: [ovs-dev] Fix OpenFlow v1.3.4 Conformance test failures: 430.500, 430.510

2019-01-16 Thread Ben Pfaff
The attachment looks missing to me. On Wed, Jan 16, 2019 at 10:29:39PM +, Iyengar, Prashanth wrote: > Hi Aaron, > > Apologies for the formatting issues earlier. > Attached the patch to the message here as suggested. > Let me know if this works. Otherwise, will look to submit a pull request.

Re: [ovs-dev] [PATCH v3] Policy-based routing (PBR) provides a mechanism to configure permit/deny and reroute policies on the router. Permit/deny policies are similar to OVN ACLs, but exist on the log

2019-01-16 Thread Ben Pfaff
On Wed, Jan 16, 2019 at 07:01:13PM +, Mary Manohar wrote: > Policy-based routing (PBR) provides a mechanism to configure permit/deny and > reroute policies on the router. > Permit/deny policies are similar to OVN ACLs, but exist on the logical-router. > Reroute policies are needed for

[ovs-dev] € 2.000.000,00 EUR

2019-01-16 Thread florin . prodan
Lieber Freund, Ich bin Herr Richard Wahl der Mega-Gewinner von $ 533M In Mega Millions Jackpot spende ich an 5 zufällige Personen, wenn Sie diese E-Mail erhalten, dann wurde Ihre E-Mail nach einem Spinball ausgewählt. Ich habe den größten Teil meines Vermögens auf eine Reihe von

Re: [ovs-dev] [PATCH v5] netdev-dpdk: support port representors

2019-01-16 Thread Ophir Munk
Hi Ilya, Thanks for the quick review. Please find comments inline. > -Original Message- > From: Ilya Maximets > Sent: Wednesday, January 16, 2019 5:42 PM > To: Ophir Munk ; ovs-dev@openvswitch.org; Ian > Stokes > Cc: Asaf Penso ; Shahaf Shuler > ; Thomas Monjalon ; Olga > Shern ; Kevin

Re: [ovs-dev] [PATCH] ovn-nb.xml: Minor documentation corrections.

2019-01-16 Thread Han Zhou
On Wed, Jan 16, 2019 at 4:54 PM Ben Pfaff wrote: > > Signed-off-by: Ben Pfaff > --- > ovn/ovn-nb.xml | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/ovn/ovn-nb.xml b/ovn/ovn-nb.xml > index 6d6fb055a082..47a36ddab52c 100644 > --- a/ovn/ovn-nb.xml > +++

Re: [ovs-dev] [PATCH net-next] openvswitch: meter: Use struct_size() in kzalloc()

2019-01-16 Thread David Miller
From: "Gustavo A. R. Silva" Date: Tue, 15 Jan 2019 15:19:17 -0600 > One of the more common cases of allocation size calculations is finding the > size of a structure that has a zero-sized array at the end, along with memory > for some number of elements for that array. For example: > > struct

[ovs-dev] [PATCH] ovn-nb.xml: Minor documentation corrections.

2019-01-16 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- ovn/ovn-nb.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ovn/ovn-nb.xml b/ovn/ovn-nb.xml index 6d6fb055a082..47a36ddab52c 100644 --- a/ovn/ovn-nb.xml +++ b/ovn/ovn-nb.xml @@ -1093,7 +1093,7 @@ highest- matching row in this table

Re: [ovs-dev] Fix OpenFlow v1.3.4 Conformance test failures: 430.500, 430.510

2019-01-16 Thread Iyengar, Prashanth
Hi Ben, Sorry again! Attached the patch to email initially. Submitted a pull request for the same issue. https://github.com/openvswitch/ovs/pull/269 Thanks, Prashanth -Original Message- From: Ben Pfaff Sent: Wednesday, January 16, 2019 15:24 To: Iyengar, Prashanth Cc:

Re: [ovs-dev] [PATCH] ovsdb-server: Correct json-rpc comment for "disable-monitor-cond".

2019-01-16 Thread Justin Pettit
> On Jan 16, 2019, at 4:36 PM, Ben Pfaff wrote: > > On Wed, Jan 16, 2019 at 02:52:51PM -0800, Justin Pettit wrote: >> --- >> ovsdb/ovsdb-server.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/ovsdb/ovsdb-server.c b/ovsdb/ovsdb-server.c >> index

Re: [ovs-dev] [PATCH] sandbox: Fix env for clustered OVN DBs.

2019-01-16 Thread Ben Pfaff
On Wed, Jan 16, 2019 at 01:45:10PM -0800, Han Zhou wrote: > From: Han Zhou > > When ovn clustered mode is specified, the environment veriables > OVN_NB_DB/OVN_SB_DB are wrong. It should be something like > unix:nb1,unix:nb2,unix:nb3 but it turns out to be unix:nb1,unix:nb1,unix:nb2. > So when

Re: [ovs-dev] OVS seems to not release memory on ARP bursts

2019-01-16 Thread Ben Pfaff
I think you'll probably have to get someone else to track down the issue. I haven't found the time to try to reproduce it. On Wed, Jan 16, 2019 at 08:33:27AM +, Ani Sinha wrote: > Hi Ben: > > Any luck reproducing the issue? Also looking at similar issues in the past, I > see we have

[ovs-dev] [PATCH v6] Improved Packet Drop Statistics in OVS

2019-01-16 Thread Anju Thomas
Currently OVS maintains explicit packet drop/error counters only on port level. Packets that are dropped as part of normal OpenFlow processing are counted in flow stats of “drop” flows or as table misses in table stats. These can only be interpreted by controllers that know the

Re: [ovs-dev] [PATCH v5] :Improved Packet Drop Statistics in OVS

2019-01-16 Thread Anju Thomas
Sure Ben. I will send the patch right away. Regards Anju -Original Message- From: Ben Pfaff [mailto:b...@ovn.org] Sent: Thursday, January 17, 2019 2:18 AM To: Anju Thomas Cc: d...@openvswitch.org; Keshav Gupta Subject: Re: [ovs-dev] [PATCH v5] :Improved Packet Drop Statistics in OVS

Re: [ovs-dev] [PATCH v5] :Improved Packet Drop Statistics in OVS

2019-01-16 Thread Anju Thomas
Hi folks, Do these changes look ok? Regards & thanks Anju -Original Message- From: Anju Thomas [mailto:anju.tho...@ericsson.com] Sent: Monday, January 07, 2019 3:29 PM To: d...@openvswitch.org Cc: Anju Thomas ; Rohith Basavaraja ; Keshav Gupta Subject: [PATCH v5] :Improved Packet

Re: [ovs-dev] [PATCH v1] Fix crash due to multiple tnl push action

2019-01-16 Thread Anju Thomas
Hi Folks, Are these changes planned to be merged as well? Regards Anju -Original Message- From: Lam, Tiago [mailto:tiago@intel.com] Sent: Monday, July 02, 2018 11:27 PM To: Anju Thomas ; Ben Pfaff Cc: d...@openvswitch.org Subject: Re: [ovs-dev] [PATCH v1] Fix crash due to

Re: [ovs-dev] [PATCH v1] Fix crash due to multiple tnl push action

2019-01-16 Thread Lam, Tiago
On 16/01/2019 09:30, Anju Thomas wrote: > > Hi Folks, > > Are these changes planned to be merged as well? > > Regards > Anju Hi Anju, Unfortunately, no. An RFC based on the below was proposed to the mailing list here [1], but no discussion / comments happened after that. Further discussion

Re: [ovs-dev] [PATCH v5] netdev-dpdk: support port representors

2019-01-16 Thread Ophir Munk
Hi Kevin and thank you for your comments. Please see inline... > -Original Message- > From: Kevin Traynor > Sent: Tuesday, January 15, 2019 4:20 PM > To: Ophir Munk ; ovs-dev@openvswitch.org > Cc: Ian Stokes ; Olga Shern ; > Ilya Maximets > Subject: Re: [PATCH v5] netdev-dpdk: support

Re: [ovs-dev] [PATCH v5] netdev-dpdk: support port representors

2019-01-16 Thread Ophir Munk
Hi Ian, > -Original Message- > From: Stokes, Ian > Sent: Wednesday, January 16, 2019 12:37 AM > To: Kevin Traynor ; Ophir Munk > ; ovs-dev@openvswitch.org > Cc: Olga Shern ; Ilya Maximets > > Subject: RE: [PATCH v5] netdev-dpdk: support port representors > > > On 01/15/2019 09:47 AM,

Re: [ovs-dev] [PATCH v5] netdev-dpdk: support port representors

2019-01-16 Thread Thomas Monjalon
16/01/2019 11:03, Ophir Munk: > Hi Kevin and thank you for your comments. > Please see inline... > > From: Kevin Traynor > > On 01/15/2019 09:47 AM, Ophir Munk wrote: > > > Dpdk port representors were introduced in dpdk versions 18.xx. > > > Prior to port representors there was a one-to-one

[ovs-dev] Obědové karty

2019-01-16 Thread Martin Kaspar via dev
Dobrý den, moderní příspěvek na stravování v podobě obědové karty, kterou lze použít ve více než 15 000 restauracích a gastronomických zařízení po celé zemi, je nástroj, který Vám pomůže poskytnout svým zaměstnancům nejžádanější benefit v ČR. Výzkum Světové zdravotnické organizace WHO

[ovs-dev] [RFC v2 0/2] extend ovs-tc offload for more pedit action

2019-01-16 Thread Pieter Jansen van Vuuren
Hi all, This set extends the ovs-tc pedit interface to allow setting ipv4 dscp and ecn fields as well as ipv6 traffic class in tc via pedit. Patch 2 in this set also introduces the notion of boundary shifts to allow translating non-byte-aligned fields like traffic class and flow limit for IPv6 to

[ovs-dev] [RFC v2 2/2] lib/tc: add set ipv6 traffic class action offload via pedit

2019-01-16 Thread Pieter Jansen van Vuuren
Extend ovs-tc translation by allowing non-byte-aligned fields for set actions. Use new boundary shifts and add set ipv6 traffic class action offload via pedit. Signed-off-by: Pieter Jansen van Vuuren Signed-off-by: Louis Peens Reviewed-by: Simon Horman --- lib/netdev-tc-offloads.c | 4 ++

[ovs-dev] [RFC v2 1/2] lib/tc: add set ipv4 dscp and ecn action offload via pedit

2019-01-16 Thread Pieter Jansen van Vuuren
Add setting of ipv4 dscp and ecn fields in tc offload using pedit. Signed-off-by: Pieter Jansen van Vuuren Signed-off-by: Louis Peens Reviewed-by: Simon Horman --- lib/netdev-tc-offloads.c | 6 +- lib/tc.c | 5 + lib/tc.h | 1 + 3 files changed, 11

Re: [ovs-dev] [PATCH] odp-util: Fix parsing QinQ packet in parse_8021q_onward.

2019-01-16 Thread wangyunjian
Please ignore this patch, the baseline of the patch is incorrect. Thanks, Yunjian > -Original Message- > From: wangyunjian > Sent: Wednesday, January 16, 2019 2:28 PM > To: d...@openvswitch.org > Cc: b...@ovn.org; xudingke ; wangyunjian > > Subject: [ovs-dev] [PATCH]

Re: [ovs-dev] OVS seems to not release memory on ARP bursts

2019-01-16 Thread Ani Sinha
Hi Ben: Any luck reproducing the issue? Also looking at similar issues in the past, I see we have encountered something similar like here : https://mail.openvswitch.org/pipermail/ovs-dev/2018-February/344088.html Did we found out where the memory leak was? Was there a patch to fix it? Thanks

Re: [ovs-dev] [PATCH] Un-revert Work around Python/C JSON unicode differences

2019-01-16 Thread Daniel Alvarez Sanchez
Thanks for this! On Tue, Jan 15, 2019 at 8:48 PM Ben Pfaff wrote: > > On Mon, Jan 14, 2019 at 08:15:36AM -0600, Terry Wilson wrote: > > This fix was reverted because it depended on a small bit of code > > in a patch that was reverted that changed some python/ovs testing > > and build. The fix is