Re: [ovs-dev] [PATCH] debian, xenserver: Update logrotate config to match RHEL.

On Sun, 2017-04-16 at 13:19 -0700, Ben Pfaff wrote: > On Fri, Apr 14, 2017 at 10:41:01AM -0700, Greg Rose wrote: > > On Fri, 2017-04-14 at 10:03 -0700, Ben Pfaff wrote: > > > On Fri, Apr 14, 2017 at 09:05:41AM -0700, Greg Rose wrote: > > > > On Thu, 2017-04-13 a

Re: [ovs-dev] [PATCH] xenserver: Add install files to RPM file list

On Mon, 2017-04-17 at 09:38 -0700, Ben Pfaff wrote: > On Mon, Apr 17, 2017 at 09:18:53AM -0700, Greg Rose wrote: > > Add missing intall files to RPM file list to prevent file check error so > > that RPM files will be built. > > > > Signed-off-by: Greg Rose <gvrose8

[ovs-dev] [PATCH] xenserver: Add install files to RPM file list

Add missing intall files to RPM file list to prevent file check error so that RPM files will be built. Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- xenserver/openvswitch-xen.spec.in | 4 1 file changed, 4 insertions(+) diff --git a/xenserver/openvswitch-xen.spec.in b/xen

Re: [ovs-dev] [PATCH v1] flow.c: Refactor the key_extract function in parsing frame.

On Fri, 2017-04-21 at 00:21 -0700, Zhenyu Gao wrote: > 1. Consume switch/case to judge type of frame instead of using if/else. > 2. Add parse_ipv4hdr for ipv4 frame header parsing. > I think this patch addresses too many issues and should be broken up into at least two different patches with

Re: [ovs-dev] [PATCH branch-2.6] xenserver: Add install files to RPM file list

On Wed, 2017-04-19 at 20:34 -0700, Ben Pfaff wrote: > On Wed, Apr 19, 2017 at 10:25:11AM -0700, Greg Rose wrote: > > On Mon, 2017-04-17 at 14:08 -0700, Greg Rose wrote: > > > Add missing install files to RPM file list to prevent file check error > > > so t

Re: [ovs-dev] [PATCH branch-2.6] xenserver: Add install files to RPM file list

On Mon, 2017-04-17 at 14:08 -0700, Greg Rose wrote: > Add missing install files to RPM file list to prevent file check error > so that RPM files will be built. > > Signed-off-by: Greg Rose <gvrose8...@gmail.com> I have not seen this patch committed to the 2.6 branch. No

Re: [ovs-dev] [PATCH 01/10] userspace: Add OXM field MFF_PACKET_TYPE

On Tue, 2017-04-18 at 11:19 +, Zoltán Balogh wrote: > From: Jan Scheurich > > Allow packet type namespace OFPHTN_ETHERTYPE as alternative pre-requisite > for matching L3 protocols (MPLS, IP, IPv6, ARP etc). > > Scan packet_type in odp_flow string. > > Added

Re: [ovs-dev] [PATCH] debian, xenserver: Update logrotate config to match RHEL.

On Fri, 2017-04-14 at 09:05 -0700, Greg Rose wrote: > On Thu, 2017-04-13 at 10:47 -0700, Ben Pfaff wrote: > > Commit 618a5b45ae8b ("rhel: Avoid logrotate error if /var/run/openvswitch > > does not exist") updated the RHEL logrotate configuration. This commit > > m

Re: [ovs-dev] [PATCH] debian, xenserver: Update logrotate config to match RHEL.

On Fri, 2017-04-14 at 10:03 -0700, Ben Pfaff wrote: > On Fri, Apr 14, 2017 at 09:05:41AM -0700, Greg Rose wrote: > > On Thu, 2017-04-13 at 10:47 -0700, Ben Pfaff wrote: > > > Commit 618a5b45ae8b ("rhel: Avoid logrotate error if /var/run/openvswitch > > > does not ex

Re: [ovs-dev] [PATCH] xenserver: Add install files to RPM file list

On Mon, 2017-04-17 at 09:38 -0700, Ben Pfaff wrote: > On Mon, Apr 17, 2017 at 09:18:53AM -0700, Greg Rose wrote: > > Add missing intall files to RPM file list to prevent file check error so > > that RPM files will be built. > > > > Signed-off-by: Greg Rose <gvrose8

[ovs-dev] [PATCH branch-2.6] xenserver: Add install files to RPM file list

Add missing install files to RPM file list to prevent file check error so that RPM files will be built. Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- xenserver/openvswitch-xen.spec.in | 2 ++ 1 file changed, 2 insertions(+) diff --git a/xenserver/openvswitch-xen.spec.in b/xen

Re: [ovs-dev] [PATCH 2/2] ofproto-dpif-upcall: Fix key attr iteration.

ow->key, flow->key_len) { if (nl_attr_type(a) == OVS_KEY_ATTR_RECIRC_ID && nl_attr_get_u32(a) != 0) { return EINVAL; Reviewed-by: Greg Rose <gvrose8...@gmail.com> ___ dev mailing list d...@openvswitc

Re: [ovs-dev] [PATCH 1/2] ofproto-dpif-upcall: Fix action attr iteration.

VAL; } I suppose we have to protect ourselves from malformed messages but I suppose there might be some small impact on performance? Reviewed by: Greg Rose <gvrose8...@gmail.com> ___ dev mailing list d...@openvswitch.org https://mail.op

Re: [ovs-dev] [PATCHv2 1/2] netdev: Refactor destruction of netdev_ports.

data); ret = 0; } LGTM Reviewed-by: Greg Rose <gvrose8...@gmail.com> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v4 1/6] dpif-netdev: Change polled_queue to use dp_netdev_rxq.

ckets = -dp_netdev_process_rxq_port(pmd, poll_list[i].rx, +dp_netdev_process_rxq_port(pmd, poll_list[i].rxq->rx, poll_list[i].port_no); cycles_count_intermediate(pmd, Tested-by: Greg Rose <gvros

Re: [ovs-dev] [PATCH v4 2/6] dpif-netdev: Add rxq processing cycle counters.

cycles_count_intermediate(pmd, +cycles_count_intermediate(pmd, NULL, process_packets ? PMD_CYCLES_PROCESSING : PMD_CYCLES_IDLE); Tested-by: Greg Rose <gvrose8...@gmail.com> Reviewed-

Re: [ovs-dev] [PATCH v4 3/6] dpif-netdev: Count the rxq processing cycles for an rxq.

; +dp_netdev_rxq_set_cycles(poll_list[i].rxq, RXQ_CYCLES_PROC_CURR, + 0); +} +/* Start new measuring interval */ +pmd->rxq_interval = now + PMD_RXQ_INTERVAL; +} if (now > pmd->next_optimization) { T

Re: [ovs-dev] [PATCH v4 4/6] dpif-netdev: Change rxq_scheduling to use rxq processing cycles.

, rxqs[i]->pmd->numa_id); +} else { +rxqs[i]->pmd = rr_numa_get_pmd(numa); +VLOG_INFO("Core %d on numa node %d assigned port \'%s\' " + "rx queue %d (measured processing cycles %"PRIu64").", + rxqs[i]->pmd->core_id, numa_id, +

Re: [ovs-dev] [PATCH v4 5/6] dpif-netdev: Change pmd selection order.

_define([SED_NUMA_CORE_QUEUE_PATTERN], ["s/\(numa_id \)[[0-9]]*\( core_id \)[[0-9]]*:/\1\2:/;s/\(queue-id: \)1 2 5 6/\1/;s/\(queue-id: \)0 3 4 7/\1/"]) m4_define([DUMMY_NUMA], [--dummy-numa="0,0,0,0"]) Tested-by: Greg Rose <gvrose8...@gmail.com> Reviewed-by: Gre

Re: [ovs-dev] [PATCH v4 6/6] dpif-netdev: Add ovs-appctl dpif-netdev/pmd-rxq-rebalance.

lues shown by the above command. For each pmd thread of the datapath \fIdp\fR shows list of queue-ids with port names, which this thread polls. +.IP "\fBdpif-netdev/pmd-rxq-rebalance\fR [\fIdp\fR]" +Reassigns rxqs to pmds in the datapath \fIdp\fR based on their current usage. . .so

Re: [ovs-dev] [PATCH] datapath: Fix for force/commit action failures

On 07/13/2017 10:08 AM, Darrell Ball wrote: On 7/13/17, 9:25 AM, "ovs-dev-boun...@openvswitch.org on behalf of Greg Rose" <ovs-dev-boun...@openvswitch.org on behalf of gvrose8...@gmail.com> wrote: When there is an established connection in direction A->B, it is

[ovs-dev] [PATCH] datapath: Fix for force/commit action failures

ection. CC: d...@openvswitch.org CC: Pravin Shalar <pshe...@nicira.com> Signed-off-by: Joe Stringer <j...@ovn.org> Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- net/openvswitch/conntrack.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/net

Re: [ovs-dev] [PATCH] datapath: Fix for force/commit action failures

On 07/13/2017 10:46 AM, Joe Stringer wrote: On 13 July 2017 at 09:25, Greg Rose <gvrose8...@gmail.com> wrote: When there is an established connection in direction A->B, it is possible to receive a packet on port B which then executes ct(commit,force) without first performing ct() - ie,

Re: [ovs-dev] [PATCH] datapath: Fix for force/commit action failures

On 07/13/2017 11:03 AM, Joe Stringer wrote: On 13 July 2017 at 11:01, Greg Rose <gvrose8...@gmail.com> wrote: On 07/13/2017 10:46 AM, Joe Stringer wrote: On 13 July 2017 at 09:25, Greg Rose <gvrose8...@gmail.com> wrote: When there is an established connection in di

Re: [ovs-dev] [PATCH] tests: Add force/commit test to system-traffic.at

On 07/17/2017 11:05 AM, Joe Stringer wrote: On 17 July 2017 at 10:54, Greg Rose <gvrose8...@gmail.com> wrote: > On 07/17/2017 10:44 AM, gvrose8...@gmail.com wrote: >> >> From: Greg Rose <gvrose8...@gmail.com> >> >> Add a new test for the kernel module dat

Re: [ovs-dev] [PATCH] tests: Add force/commit test to system-traffic.at

On 07/17/2017 11:07 AM, Ben Pfaff wrote: On Mon, Jul 17, 2017 at 10:54:31AM -0700, Greg Rose wrote: > On 07/17/2017 10:44 AM, gvrose8...@gmail.com wrote: >> From: Greg Rose <gvrose8...@gmail.com> >> >> Add a new test for the kernel module datapath to test if the &

Re: [ovs-dev] [PATCH] tests: Add force/commit test to system-traffic.at

On 07/17/2017 11:23 AM, Darrell Ball wrote: On 7/17/17, 10:44 AM, "ovs-dev-boun...@openvswitch.org on behalf of gvrose8...@gmail.com" <ovs-dev-boun...@openvswitch.org on behalf of gvrose8...@gmail.com> wrote: From: Greg Rose <gvrose8...@gmail.com>

[ovs-dev] [PATCH] datapath: Fix for force/commit action failures

ection. Co-authored-by: Joe Stringer <j...@ovn.org> Signed-off-by: Joe Stringer <j...@ovn.org> Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- datapath/conntrack.c | 51 --- 1 file changed, 36 insertions(+), 15 deletions(-

Re: [ovs-dev] [PATCH] tests: Add force/commit test to system-traffic.at

On 07/17/2017 10:44 AM, gvrose8...@gmail.com wrote: From: Greg Rose <gvrose8...@gmail.com> Add a new test for the kernel module datapath to test if the conntrack force direction change and commit is working correctly. This test was used to find and root cause BZ 18090854. Signed-off-b

Re: [ovs-dev] [PATCH] tests: Add force/commit test to system-traffic.at

On 07/17/2017 12:35 PM, Joe Stringer wrote: On 17 July 2017 at 12:27, Darrell Ball <db...@vmware.com> wrote: > > > On 7/17/17, 11:26 AM, "Greg Rose" <gvrose8...@gmail.com> wrote: > > On 07/17/2017 11:23 AM, Darrell Ball wrote: > > >

Re: [ovs-dev] 答复: 答复: 答复: [PATCH] pkt reassemble: fix kernel panic for ovs reassemble

On 07/06/2017 08:25 PM, 王志克 wrote: Hi Greg, Any progress? Thanks. Br, Wang Zhike Hi Wang, I've been out of town since June 30 but will try to find some time to take this up again this week. Thanks, - Greg ___ dev mailing list

[ovs-dev] [PATCH] conntrack: Fix for force/commit bug

When the direction is being forced key->ct_state may not have been set. Check for this condition and take action to set the state correctly so that the force direction occurs. Co-authored-by: Joe Stringer <j...@ovn.org> Signed-off-by: Joe Stringer <j...@ovn.org> Signed-off-by: Gre

Re: [ovs-dev] [PATCH v2 0/4]tunneling : Improving tunneling performance by avoiding dp recirc.

ed-off-by: Zoltán Balogh <zoltan.bal...@ericsson.com> Co-authored-by: Zoltán Balogh <zoltan.bal...@ericsson.com> FWIW I applied these patches and they compiled, passed make check tests and checkpatch. Tested-by: Greg Rose <gvrose@8...@gmail.com> __

Re: [ovs-dev] [PATCH net] openvswitch: Fix for force/commit action failures

On 07/14/2017 11:42 AM, Joe Stringer wrote: On 14 July 2017 at 09:10, Greg Rose <gvrose8...@gmail.com> wrote: > When there is an established connection in direction A->B, it is > possible to receive a packet on port B which then executes > ct(commit,force) without first pe

[ovs-dev] [PATCH V3 net] openvswitch: Fix for force/commit action failures

ection. Fixes: dd41d330b03 ("openvswitch: Add force commit.") CC: Pravin Shelar <pshe...@nicira.com> CC: d...@openvswitch.org Signed-off-by: Joe Stringer <j...@ovn.org> Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- V2: Make sure nf_conntrack_in() is called for f

[ovs-dev] [PATCH net] openvswitch: Fix for force/commit action failures

ection. Fixes: dd41d330b03 ("openvswitch: Add force commit.") CC: Pravin Shelar <pshe...@nicira.com> CC: d...@openvswitch.org Signed-off-by: Joe Stringer <j...@ovn.org> Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- net/openvswitch/conntrack.c | 50 ++

Re: [ovs-dev] [PATCH] tests: Add force/commit test to system-traffic.at

On 07/17/2017 12:35 PM, Joe Stringer wrote: On 17 July 2017 at 12:27, Darrell Ball <db...@vmware.com> wrote: > > > On 7/17/17, 11:26 AM, "Greg Rose" <gvrose8...@gmail.com> wrote: > > On 07/17/2017 11:23 AM, Darrell Ball wrote: > > >

[ovs-dev] [PATCH V2] tests: Add force/commit test to system-traffic.at

From: Joe Stringer <j...@ovn.org> Add a new test check if the conntrack force direction change and commit is working correctly. This test was used to find and root cause BZ 18090854. Signed-off-by: Joe Stringer <j...@ovn.org> Signed-off-by: Greg Rose <gvrose8...@gmail.com> -

[ovs-dev] [PATCH V2] datapath: Fix for force/commit action failures

Upstream commit: commit 8b97ac5bda17cfaa257bcab6180af0f43a2e87e0 Author: Greg Rose <gvrose8...@gmail.com> Date: Fri Jul 14 12:42:49 2017 -0700 openvswitch: Fix for force/commit action failures When there is an established connection in direction A->B, it is

Re: [ovs-dev] [PATCH v1] vswitchd: Fix IFACE_STAT name error in iface_refresh_stats

ets") \ > IFACE_STAT(tx_multicast_packets,"tx_multicast_packets") \ > IFACE_STAT(rx_broadcast_packets,"rx_broadcast_packets") \ It does appear that this fixes a hole between 1518 and 1522 where packets sized 1519 to 1522 would not be han

Re: [ovs-dev] [PATCH V2] tests: Add force/commit test to system-traffic.at

On 07/18/2017 10:16 AM, Darrell Ball wrote: On 7/18/17, 8:42 AM, "ovs-dev-boun...@openvswitch.org on behalf of Greg Rose" <ovs-dev-boun...@openvswitch.org on behalf of gvrose8...@gmail.com> wrote: From: Joe Stringer <j...@ovn.org> Add a new test check

Re: [ovs-dev] [PATCH V2] tests: Add force/commit test to system-traffic.at

On 07/18/2017 01:23 PM, Joe Stringer wrote: On 18 July 2017 at 13:08, Greg Rose <gvrose8...@gmail.com> wrote: > On 07/18/2017 10:16 AM, Darrell Ball wrote: >> >> >> >> On 7/18/17, 8:42 AM, "ovs-dev-boun...@openvswitch.org on behalf of Greg >> Rose

Re: [ovs-dev] [PATCH 1/8] acinclude.m4: Support Linux kernel 4.12

Sure thing. Thanks Joe! On Fri, Jul 21, 2017 at 11:41 AM, Joe Stringer <j...@ovn.org> wrote: > On 19 July 2017 at 13:57, Greg Rose <gvrose8...@gmail.com> wrote: >> Allow datapath kernel modules to be configured and built for kernels up >> to 4.12. >> &g

Re: [ovs-dev] [PATCH 2/8] datapath: introduce nf_conntrack_helper_put function

Right, that's a cleaner solution. Thanks for pointing it out. I think there are a few others like that in the series then. - Greg On Fri, Jul 21, 2017 at 11:42 AM, Joe Stringer <j...@ovn.org> wrote: > On 19 July 2017 at 13:57, Greg Rose <gvrose8...@gmail.com> wrote: >

Re: [ovs-dev] [PATCH 6/8] datapath: Avoid using stack larger than 1024

Yep, missed that. That sounds like the right thing to do. Thanks, On Fri, Jul 21, 2017 at 11:41 AM, Joe Stringer <j...@ovn.org> wrote: > On 19 July 2017 at 13:57, Greg Rose <gvrose8...@gmail.com> wrote: >> Upstream commit: >> commit 9cc9a5cb176ccb4f2cda5ac34da

[ovs-dev] [PATCH] datapath: fix potential out of bound access in parse_ct

Miller <da...@davemloft.net> Pick up an upstream bug fix. Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- datapath/conntrack.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/datapath/conntrack.c b/datapath/conntrack.c index bba9bfe..b645ab1 100644 -

[ovs-dev] [PATCH V2] datapath: fix potential out of bound access in parse_ct

Miller <da...@davemloft.net> Pick up an upstream bug fix. Fixes: a94ebc39996b ("datapath: Add conntrack action") Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- V2 - Add appropriate "Fixes" tag for OOT repository --- datapath/conntrack.c | 7 +-- 1 file cha

Re: [ovs-dev] [PATCHv2 00/11] Backport upstream Linux patches and support 4.12 kernel

though the kernel they are targeted for has not been released yet. Thank you Joe! Regards, - Greg Greg Rose (7): datapath: introduce nf_conntrack_helper_put function datapath: Fix inconsistent teardown and release of private netdev state. compat: Implement upstream net device free

Re: [ovs-dev] [PATCH 01/11] datapath: introduce nf_conntrack_helper_put function

On 07/21/2017 04:46 PM, Joe Stringer wrote: From: Greg Rose <gvrose8...@gmail.com> Upstream commit: commit d91fc59cd77c719f33eda65c194ad8f95a055190 Author: Liping Zhang <zlpnob...@gmail.com> Date: Sun May 7 22:01:55 2017 +0800 netfilter: introduce nf_conntrac

Re: [ovs-dev] [PATCHv2 00/11] Backport upstream Linux patches and support 4.12 kernel

On 07/24/2017 10:19 AM, Joe Stringer wrote: On 24 July 2017 at 08:31, Greg Rose <gvrose8...@gmail.com> wrote: > On 07/21/2017 04:46 PM, Joe Stringer wrote: >> >> This series takes Greg's recent proposed series, rolls in a few missed >> upstream commits, and orders th

Re: [ovs-dev] [PATCH] dpif-netdev: Reorder elements in dp_netdev_port structure.

finity of rx queues. */ -bool need_reconfigure; /* True if we should reconfigure netdev. */ }; /* Contained by struct dp_netdev_flow's 'stats' member. */ Reviewed-by: Greg Rose <gvrose8...@gmail.com> Tested-by: Greg Rose <gvros

Re: [ovs-dev] [PATCH 1/2] ovs-bugtool: Collect OVS logs with "--ovs" option.

OPENVSWITCH_LOGS, CAP_NETWORK_CONFIG] ovs_info_list = ['process-tree'] # We cannot use iteritems, since we modify 'data' as we pass through for (k, v) in data.items(): Reviewed-by: Greg Rose <gvrose8...@gmail.com> Tested-by: Greg Rose

Re: [ovs-dev] [PATCH 2/2] ovs-bugtool: Run the 'dmesg' command without condition.

GS, log, last_mod_time=log_last_mod_time) -if not os.path.exists('/var/log/dmesg') and \ - not os.path.exists('/var/log/boot'): -cmd_output(CAP_SYSTEM_LOGS, [DMESG]) +cmd_output(CAP_SYSTEM_LOGS, [DMESG]) cmd_output(CAP_SYSTEM_SERVICES, [CHKCONFIG, '--list'])

Re: [ovs-dev] [PATCH V2] datapath: Fix for force/commit action failures

On 07/18/2017 04:29 PM, Joe Stringer wrote: On 18 July 2017 at 08:42, Greg Rose <gvrose8...@gmail.com> wrote: > Upstream commit: > commit 8b97ac5bda17cfaa257bcab6180af0f43a2e87e0 > Author: Greg Rose <gvrose8...@gmail.com> > Date: Fri Ju

[ovs-dev] [PATCH 1/8] acinclude.m4: Support Linux kernel 4.12

elper_put helper function") is present. Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- acinclude.m4 | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/acinclude.m4 b/acinclude.m4 index e7affc5..0be7a63 100644 --- a/acinclude.m4 +++ b/acinc

Re: [ovs-dev] [PATCH] conntrack: Fix for force/commit bug

On 07/12/2017 02:38 PM, Joe Stringer wrote: On 12 July 2017 at 11:05, Greg Rose <gvrose8...@gmail.com> wrote: When the direction is being forced key->ct_state may not have been set. Check for this condition and take action to set the state correctly so that the force direction oc

Re: [ovs-dev] 答复: 答复: 答复: [PATCH] pkt reassemble: fix kernel panic for ovs reassemble

On 06/26/2017 05:51 PM, 王志克 wrote: Hi Greg, The exact issue occured on the 20th of check-kmod (sometimes there are other kernel issue: kernel just hangs but without panic). OVS2.6.0 on CentOS7.2 with kernel 3.10.0-327.el7.x86_64. Some info below, which hopes helpful. datapath-sanity 1:

Re: [ovs-dev] 答复: 答复: 答复: [PATCH] pkt reassemble: fix kernel panic for ovs reassemble

]: *** [all-recursive] Error 1 make[2]: Leaving directory `/home/gvrose/prj/openvswitch-2.6.0/datapath' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/home/gvrose/prj/openvswitch-2.6.0' make: *** [all] Error 2 -Original Message- From: Greg Rose [mailto:gvrose8...@gmail.com] Sent

Re: [ovs-dev] 答复: 答复: 答复: [PATCH] pkt reassemble: fix kernel panic for ovs reassemble

18 01 74 23 48 8b 00 48 39 c8 75 f2 83 c6 01 40 0f b6 f6 RIP [] get_next_timer_interrupt+0x97/0x270 RSP Wang Zhike -邮件原件- 发件人: Greg Rose [mailto:gvrose8...@gmail.com] 发送时间: 2017年6月27日 6:26 收件人: 王志克 抄送: d

Re: [ovs-dev] [PATCH] vswitchd: Add 'appctl quit' command

On Tue, 2017-04-25 at 17:02 -0700, Andy Zhou wrote: > vswitchd can gracefully shutdown after receiving the 'appctl exit' > command. But the datapath resources vswitchd created can > linger on. This is not a problem, and in fact desireable when the > shutdown is transient in nature. Since

Re: [ovs-dev] [PATCH] bridge: Prohibit "default" bridge name.

er users from accessing arbitrary > * directories, e.g. consider a bridge named "../../../etc/". > * Acked-by: Greg Rose <gvrose8...@gmail.com> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] compat: Fix build error in kernel 4.10.0

er <r...@oneunified.net> > Reported-at: > https://mail.openvswitch.org/pipermail/ovs-dev/2017-April/331411.html > Signed-off-by: Guoshuai Li <l...@dtdream.com> Compile tested and looks OK to me. Reviewed-by: Greg Rose <gvrose8...@gmail.com> > --- > datapath/linux/comp

Re: [ovs-dev] nf_defrag_ipv6_enable problem in datapath/linux/compat/nf_conntrack_reasm.c

On Wed, 2017-04-26 at 00:33 +0800, Guoshuai Li wrote: > > > Sure, here it is: > > > > make -C /lib/modules/4.11.0-rc7+/build > > M=/home/gvrose/prj/ovs/datapath/linux modules > > make[4]: Entering directory `/home/gvrose/prj/net-next' > > CC [M] /home/gvrose/prj/ovs/datapath/linux/actions.o >

Re: [ovs-dev] [PATCH 2/2] datapath: Add eventmask support to CT action.

tfilter core init_conntrack() adds the event cache extension, so we > only need to set the ctmask value. However, if the system is > configured without support for events, the setting will be skipped due > to extension not being found. > > Signed-off-by: Jarno R

[ovs-dev] [PATCH 1/4] acinclude.m4: Fix parenthetical balance

Parenthetical imbalance was causing some checks to not run Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- acinclude.m4 | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/acinclude.m4 b/acinclude.m4 index 9f8e30d..0d6647e 100644 --- a/acinclude.m4 +++ b/acincl

[ovs-dev] [PATCH 0/4] Fixup 4.10 kernel compatability layer

-experimental Greg Rose (4): acinclude.m4: Fix parenthetical balance acinclude.m4: Add check for struct net parameter compat: Fix build error in kernels 4.10+ travis: Update kernels to kernel.org latest .travis.yml| 14 +++--- acinclude.m4

Re: [ovs-dev] [PATCH V2 1/4] acinclude.m4: Fix parenthetical balance

On Fri, 2017-04-28 at 14:18 -0700, Joe Stringer wrote: > On 28 April 2017 at 14:02, Greg Rose <gvrose8...@gmail.com> wrote: > > On Fri, 2017-04-28 at 13:55 -0700, Joe Stringer wrote: > >> On 27 April 2017 at 16:13, Greg Rose <gvrose8...@gmail.com> wrote: > >>

Re: [ovs-dev] [PATCH V2 1/4] acinclude.m4: Fix parenthetical balance

On Fri, 2017-04-28 at 13:55 -0700, Joe Stringer wrote: > On 27 April 2017 at 16:13, Greg Rose <gvrose8...@gmail.com> wrote: > > Parenthetical imbalance was causing some checks to not run > > > > Signed-off-by: Greg Rose <gvrose8...@gmail.com> > > --- &

Re: [ovs-dev] [PATCH V2 1/4] acinclude.m4: Fix parenthetical balance

On Fri, 2017-04-28 at 14:21 -0700, Joe Stringer wrote: > On 28 April 2017 at 14:18, Joe Stringer <j...@ovn.org> wrote: > > On 28 April 2017 at 14:02, Greg Rose <gvrose8...@gmail.com> wrote: > >> On Fri, 2017-04-28 at 13:55 -0700, Joe Stringer wrote: > >>

Re: [ovs-dev] [PATCH V2 1/4] acinclude.m4: Fix parenthetical balance

On Fri, 2017-04-28 at 14:33 -0700, Joe Stringer wrote: > On 28 April 2017 at 14:31, Greg Rose <gvrose8...@gmail.com> wrote: > > On Fri, 2017-04-28 at 14:21 -0700, Joe Stringer wrote: > >> On 28 April 2017 at 14:18, Joe Stringer <j...@ovn.org> wrote: > >>

Re: [ovs-dev] [PATCH V2 2/4] acinclude.m4: Add check for struct net parameter

On Fri, 2017-04-28 at 14:34 -0700, Joe Stringer wrote: > On 27 April 2017 at 16:13, Greg Rose <gvrose8...@gmail.com> wrote: > > The net parameter was added to nf_defrag_ipv6_enable in linux 4.10 > > > > Signed-off-by: Greg Rose <gvrose8...@gmail.com> > >

Re: [ovs-dev] [PATCH V2 1/4] acinclude.m4: Fix parenthetical balance

On Fri, 2017-04-28 at 14:47 -0700, Joe Stringer wrote: [snip] > > I've just started using "git clean" for this purpose, not sure if it's > more or less reliable than your methods. It will clobber any untracked > files though, so don't save any handy scripts in the directory :-) Ah yes, the

Re: [ovs-dev] [PATCH V2 3/4] compat: Fix build error in kernels 4.10+

On Fri, 2017-04-28 at 14:34 -0700, Joe Stringer wrote: > On 27 April 2017 at 16:13, Greg Rose <gvrose8...@gmail.com> wrote: > > This is an alternative solution patch for the issue reported by > > Raymond Burkholder and the patch submitted by Guoshuai Li. It uses > > the

Re: [ovs-dev] nf_defrag_ipv6_enable problem in datapath/linux/compat/nf_conntrack_reasm.c

On Tue, 2017-04-25 at 11:13 -0300, Raymond Burkholder wrote: > I am attempting to build openvswitch 2.7.90 on linux 4.10.12 on Debian > using: Which version or distribution of Debian? Is it the current 8.7.1 I see at the Debian site? Let me know and I'll try to reproduce and investigate.

Re: [ovs-dev] [PATCH 2/4] acinclude.m4: Add check for struct net parameter

On Thu, 2017-04-27 at 14:05 -0700, Andy Zhou wrote: > On Thu, Apr 27, 2017 at 1:08 PM, Greg Rose <gvrose8...@gmail.com> wrote: > > The net parameter was added to nf_defrag_ipv6_enable in linux 4.10 > > > > Signed-off-by: Greg Rose <gvrose8...@gmai

Re: [ovs-dev] [PATCH 3/4] compat: Fix build error in kernels 4.10+

On Thu, 2017-04-27 at 13:53 -0700, Jarno Rajahalme wrote: > > On Apr 27, 2017, at 1:08 PM, Greg Rose <gvrose8...@gmail.com> wrote: > > > > This is an alternative solution patch for the issue reported by > > Raymond Burkholder and the patch submitted by Guoshuai Li.

[ovs-dev] [PATCH V2 4/4] travis: Update kernels to kernel.org latest

Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- .travis.yml | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/.travis.yml b/.travis.yml index 6f2b065..3a73873 100644 --- a/.travis.yml +++ b/.travis.yml @@ -30,13 +30,13 @@ env: - BUILD_ENV="

Re: [ovs-dev] [PATCH] bridge: Prohibit "default" bridge name.

On Thu, 2017-04-27 at 14:47 -0700, William Tu wrote: > On Thu, Apr 27, 2017 at 11:17 AM, Ben Pfaff wrote: > > On Thu, Apr 27, 2017 at 10:17:20AM -0700, William Tu wrote: > >> On Thu, Apr 27, 2017 at 9:57 AM, Ben Pfaff wrote: > >> > On Thu, Apr 27, 2017 at 04:02:10AM

[ovs-dev] [PATCH 0/4] Fixup 4.10 kernel compatability layer

values of the init functions. Compile tested locally on 4.9.24 and 4.10.12 Linux kernels to ensure the inicremental change is valid but not verified again with Travis. Verified here: https://travis-ci.org/gvrose8192/ovs-experimental Greg Rose (4): acinclude.m4: Fix parenthetical

[ovs-dev] [PATCH V2 3/4] compat: Fix build error in kernels 4.10+

DEFRAG_ENABLE_TAKES_NET should be set and then checks for that at compile time. V2 - Incorporate suggestion from Joe Stringer to just return values of the init functions. Reported-by: Raymond Burkholder <r...@oneunified.net> CC: Guoshuai Li <l...@dtdream.com> Signed-off-b

[ovs-dev] [PATCH V2 2/4] acinclude.m4: Add check for struct net parameter

The net parameter was added to nf_defrag_ipv6_enable in linux 4.10 Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- acinclude.m4 | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/acinclude.m4 b/acinclude.m4 index 0d6647e..8653a30 100644 --- a/acinclude.m4

[ovs-dev] [PATCH 4/4] travis: Update kernels to kernel.org latest

Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- .travis.yml | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/.travis.yml b/.travis.yml index 6f2b065..3a73873 100644 --- a/.travis.yml +++ b/.travis.yml @@ -30,13 +30,13 @@ env: - BUILD_ENV="

[ovs-dev] [PATCH 3/4] compat: Fix build error in kernels 4.10+

DEFRAG_ENABLE_TAKES_NET should be set and then checks for that at compile time. Reported-by: Raymond Burkholder <r...@oneunified.net> CC: Guoshuai Li <l...@dtdream.com> Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- datapath/linux/compat/ip_fragment.c| 14 ++

Re: [ovs-dev] nf_defrag_ipv6_enable problem in datapath/linux/compat/nf_conntrack_reasm.c

Even with your patch applied I still run into compilation errors on the 4.11.rc7 upstream kernel. Perhaps there is more to do. I'll get the Debian distro as well and look into a fix there. Thanks, - Greg > > >> boun...@openvswitch.org] On Behalf Of Greg Rose > >> Sent:

Re: [ovs-dev] [PATCH v3 4/6] dpif-netdev: Change rxq_scheduling to use rxq processing cycles.

On 08/01/2017 08:58 AM, Kevin Traynor wrote: Previously rxqs were assigned to pmds by round robin in port/queue order. Now that we have the processing cycles used for existing rxqs, use that information to try and produced a better balanced distribution of rxqs across pmds. i.e. given multiple

Re: [ovs-dev] [PATCH v2 00/19] Add OVS DPDK keep-alive functionality.

On 07/28/2017 10:56 AM, Darrell Ball wrote: Thanks for testing Greg We are at DPDK 16.11.2 now See this link http://docs.openvswitch.org/en/latest/faq/releases/ Darrell Well that explains things! Thanks, I'll give it another go with 16.11.2. - Greg -Original Message- From: Greg

Re: [ovs-dev] [PATCH v2 00/19] Add OVS DPDK keep-alive functionality.

Bhanuprakash, After applying your patch series on top of current master and building I get the following error: libtool: compile: gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include -I ./include -I ./lib -I ./lib -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare -Wpointer-arith -Wformat

Re: [ovs-dev] FW: [patch_v1] docs/dpdk: Consolidate pmd-cpu-mask references.

on the ovs-dev list. Reviewed-by: Greg rose <gvrose8...@gmail.com> -Original Message- From: <ovs-dev-boun...@openvswitch.org> on behalf of Darrell Ball <dlu...@gmail.com> Date: Thursday, July 27, 2017 at 4:50 PM To: "d...@openvswitch.org" <d...@ope

Re: [ovs-dev] [PATCH v3 4/6] dpif-netdev: Change rxq_scheduling to use rxq processing cycles.

On 08/09/2017 08:47 AM, Kevin Traynor wrote: On 08/08/2017 07:15 PM, Greg Rose wrote: > On 08/01/2017 08:58 AM, Kevin Traynor wrote: >> Previously rxqs were assigned to pmds by round robin in >> port/queue order. >> >> Now that we have the processing cycles use

Re: [ovs-dev] [PATCH v4] route-table: Remove netdevs in netdev_hash when deleted

INK) { +if (change->ifname) { +tnl_port_map_delete_ipdev(change->ifname); +} +} } Works as advertised... Tested-by: Greg Rose <gvrose8...@gmail.com> Reviewed-by: Greg Rose <gvrose8...@gmail.com> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH] datapath: fix skb_panic due to the incorrect actions attrlen

s with sampled-"...) Cc: Neil McKee <neil.mc...@inmon.com> Signed-off-by: Liping Zhang <zlpnob...@gmail.com> Acked-by: Pravin B Shelar <pshe...@ovn.org> Signed-off-by: David S. Miller <da...@davemloft.net> Signed-off-by: Greg Rose <gvrose8...@gmail

Re: [ovs-dev] [PATCH 2/2] ofproto-dpif-ipfix: add interface Information Elements to flow key

On 08/16/2017 01:54 AM, Szczerbik, PrzemyslawX wrote: Hi, I haven't received any feedback on this patch for quite some time. Is there anything that I can do to expedite review process? Regards, Przemek Przemek, I'm in the process of looking into this patch but I'm running into an issue

Re: [ovs-dev] [PATCH 2/2] ofproto-dpif-ipfix: add interface Information Elements to flow key

On 08/16/2017 01:54 AM, Szczerbik, PrzemyslawX wrote: Hi, I haven't received any feedback on this patch for quite some time. Is there anything that I can do to expedite review process? Regards, Przemek [snip] I'll have a look at it over the next few days and see if I can provide some

Re: [ovs-dev] [PATCH] datapath: fix skb_panic due to the incorrect actions attrlen

On 08/18/2017 02:41 PM, Joe Stringer wrote: On 16 August 2017 at 15:48, Greg Rose <gvrose8...@gmail.com> wrote: > Upstream commit: > commit 494bea39f3201776cdfddc232705f54a0bd210c4 > Author: Liping Zhang <zlpnob...@gmail.com> > Date: Wed Au

Re: [ovs-dev] [PATCH] datapath: Remove untracked CT on newer kernels.

t; +#endif /* HAVE_NF_CT_IS_UNTRACKED */ > > /* Add NAT extension if not confirmed yet. */ > if (!nf_ct_is_confirmed(ct) && !nf_ct_nat_ext_add(ct)) > -- LGTM Acked-by: Greg Rose <gvrose8...@gmail.com> > 2.12.0 > > ___

Re: [ovs-dev] [PATCH] bridge: Fix controller status update

const char *role = ofp12_controller_role_to_str(cinfo->role); > +ovsrec_controller_set_role(cfg, role); > ovsrec_controller_set_status(cfg, >pairs); > -} else { > -ovsrec_controller_set_is_connected(cfg, false); > - o

Re: [ovs-dev] [PATCH] tests: Fix timing dependency bridge - multiple bridges share a controller

On Wed, May 17, 2017 at 11:37 AM, Andy Zhou wrote: > Without the fix, this test currently consistently fail when running > on Travis CI. Connecting to the controller can take more time than > running locally. Because the exact connecting time is variable, the > exact output should

Re: [ovs-dev] [PATCH 4.4-only] openvswitch: clear sender cpu before forwarding packets

h/vport.c > +++ b/net/openvswitch/vport.c > @@ -503,6 +503,7 @@ void ovs_vport_send(struct vport *vport, struct sk_buff > *skb) > } > > skb->dev = vport->dev; > + skb_sender_cpu_clear(skb); > vport->ops->send(skb); > return; > LGTM A

Re: [ovs-dev] [PATCH] treewide: Fix spelling of "prerequisites".

ot;sctp,ip_frag=later actions=set_field:->sctp_dst,output:1"], [1], [], [stderr]) AT_CHECK([tail -2 stderr | sed 's/^.*|WARN|//'], [0], [dnl -set_field sctp_dst lacks correct prerequisities +set_field sctp_dst lacks correct prerequisites ovs-ofctl: actio

Re: [ovs-dev] [PATCH v2] dpdk: announce deprecation of vhost-user server ports

On 06/09/2017 01:42 AM, Kavanagh, Mark B wrote: From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-boun...@openvswitch.org] On Behalf Of Ben Pfaff Sent: Thursday, June 8, 2017 10:34 PM To: Darrell Ball Cc: d...@openvswitch.org; Flavio Leitner

  1   2   3   4   5   6   7   8   9   10   >