Re: [ovs-dev] [PATCH] system-ovn.at: Fix race conditions.

2017-02-02 Thread Guru Shetty
On 2 February 2017 at 10:12, Ben Pfaff wrote: > On Wed, Feb 01, 2017 at 11:52:14PM -0800, Gurucharan Shetty wrote: > > The code to wait for a particular type of flow > > in ovs-vswitchd was not specific enough. This commit > > changes that and to be doubly sure, also uses the > >

Re: [ovs-dev] SFC patches for OVN

2017-02-03 Thread Guru Shetty
On 3 February 2017 at 11:59, Shuaijun Zhang wrote: > Hi All, > > I found a link (see below) it mentioned that a set of patches are developed > to support SFC within OVN > https://mail.openvswitch.org/pipermail/ovs-dev/2016-November/324909.html > > Can anyone please let me

Re: [ovs-dev] SFC patches for OVN

2017-02-03 Thread Guru Shetty
> > >> > Hi Guru, > > Thank you for your reply. I found the post. It was posted by John McDowall > yesterday. > > I'd like to try it. Just wonder which ovs version/branch it should be > applied to. 2.6.1 or the master branch? > > Master branch. > Thank you > Jason > >

Re: [ovs-dev] [PATCH] windows: netdev report error if query failed

2017-02-08 Thread Guru Shetty
On 7 February 2017 at 22:41, Alin Serdean wrote: > The netdev Windows construct uses query_netdev to see if a port exists > in the datapath, in the case an error occurred in the reply message > we returned 0, meaning netdev_open was successful. > > This patch

Re: [ovs-dev] [PATCH v11 2/5] ovn: avoid snat recirc only on gateway routers

2017-01-24 Thread Guru Shetty
On 21 January 2017 at 16:52, Mickey Spiegel wrote: > Currently, for performance reasons on gateway routers, ct_snat > that does not specify an IP address does not immediately trigger > recirculation. On gateway routers, ct_snat that does not specify > an IP address

Re: [ovs-dev] [PATCH v11 4/5] ovn: ovn-nbctl commands for distributed NAT

2017-01-26 Thread Guru Shetty
On 21 January 2017 at 16:52, Mickey Spiegel wrote: > This patch adds the new optional arguments "logical_port" and > "external_mac" to lr-nat-add, and displays that information in > lr-nat-list. > > Signed-off-by: Mickey Spiegel > Acked-by:

Re: [ovs-dev] [PATCH v11 3/5] ovn: distributed NAT flows

2017-01-26 Thread Guru Shetty
On 26 January 2017 at 09:47, Mickey Spiegel <mickeys@gmail.com> wrote: > > On Thu, Jan 26, 2017 at 8:53 AM, Guru Shetty <g...@ovn.org> wrote: > >> >> >> On 21 January 2017 at 16:52, Mickey Spiegel <mickeys@gmail.com> >> wrote: >> &g

Re: [ovs-dev] [PATCH v11 5/5] ovn: rewrite redirect-chassis description in ovn-nb.xml

2017-01-26 Thread Guru Shetty
On 21 January 2017 at 16:52, Mickey Spiegel wrote: > This optional patch addresses offline comments that the documentation > in ovn-nb.xml should not describe southbound constructs or flow > details, since it is user facing documentation. > > Signed-off-by: Mickey Spiegel

Re: [ovs-dev] [PATCH v12 6/6] ovn: specify options:nat-addresses as "router"

2017-01-27 Thread Guru Shetty
> > > > I should clarify that statement. It is a good thing if the chassis > changes, for example if doing simple high availability. The GARP > packet will fix L2 learning. > > As I think about it, if anyone uses logical routers without NAT > or load balancers, and the chassis changes, then GARP

Re: [ovs-dev] [PATCH v12 6/6] ovn: specify options:nat-addresses as "router"

2017-01-27 Thread Guru Shetty
On 26 January 2017 at 01:20, Mickey Spiegel wrote: > Currently in OVN, the "nat-addresses" in the "options" column of a > logical switch port of type "router" must be specified manually. > Typically the user would specify as "nat-addresses" all of the NAT > external IP

Re: [ovs-dev] [PATCH v2] ovn-trace: Possible null dereference

2017-01-30 Thread Guru Shetty
On 29 January 2017 at 23:04, Alin Serdean wrote: > From: Alin Serdean > > Found by inspection. > > Signed-off-by: Alin Gabriel Serdean > Applied, thanks! > --- > v2: change paranthesis as

Re: [ovs-dev] [PATCH] windows: Allow clients to read from server before disconnect

2017-01-27 Thread Guru Shetty
On 26 January 2017 at 11:12, Alin Serdean wrote: > Wait for clients to read from the pipe before disconnecting the server. > > Found while testing. > > Signed-off-by: Alin Gabriel Serdean > --- > Intended for master and

Re: [ovs-dev] [PATCH v3 4/4] datapath-windows: Add support for OVS_KEY_ATTR_TCP set action

2017-01-27 Thread Guru Shetty
On 26 January 2017 at 15:43, Alin Serdean wrote: > From: Alin Serdean > > This patch adds support for set action with OVS_KEY_ATTR_TCP attribute > (change TCP source or destination port). > > If the source or destination TCP port

Re: [ovs-dev] [PATCH v3 1/5] datapath-windows: Added a new file to support Ipv4 fragments.

2017-01-27 Thread Guru Shetty
On 27 January 2017 at 14:13, Anand Kumar wrote: > This patch adds functionalities to support IPv4 fragments, which will be > used by Conntrack module. > > Added a new structure to hold the Ipv4 fragments and a hash table to > hold Ipv4 datagram entries. Also added a clean

Re: [ovs-dev] [PATCH] python windows: Allow clients to read from server before disconnect

2017-01-27 Thread Guru Shetty
On 26 January 2017 at 11:44, Alin Serdean wrote: > Wait for clients to read from the pipe before disconnecting the server. > > Signed-off-by: Alin Gabriel Serdean > --- > Intended for master and branch-2.7 > Applied. > --- >

Re: [ovs-dev] [PATCH] tests windows: change service test

2017-01-27 Thread Guru Shetty
On 26 January 2017 at 10:32, Alin Serdean wrote: > Skip the test if the service 'ovsdb-server' is already defined. > > The arguments of the service are incomplete: in the former state > it will try to create the pidfile and unixctl in the configuration path. >

Re: [ovs-dev] [PATCH 1/3] ovn-trace: Possible null dereference

2017-01-27 Thread Guru Shetty
On 26 January 2017 at 23:14, Alin Serdean wrote: > Found by inspection. > > Signed-off-by: Alin Gabriel Serdean > --- > ovn/utilities/ovn-trace.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [ovs-dev] [PATCH] windows: wmi add include

2017-01-27 Thread Guru Shetty
On 26 January 2017 at 14:15, Alin Serdean wrote: > Add 'util.h' to includes otherwise the definition of the function > ovs_format_message will be unknown and an abort with the following > stacktrace will be triggered: > *1 ovs-vswitchd.exe!_output_l(_iobuf *

Re: [ovs-dev] [PATCH] windows: Broken internal netdevs

2017-02-22 Thread Guru Shetty
On 17 February 2017 at 03:10, Alin Serdean wrote: > Commit fa07525f9cf3fa698ebc23ea09da477d3d881a87 fixed error logging for > for regular netdevs, however it overlooked "internal" netdevs. > > This patch allows "internal" netdev objects to be created and passed

Re: [ovs-dev] [PATCH] windows: netdev report error if query failed

2017-02-09 Thread Guru Shetty
On 9 February 2017 at 08:23, Alin Serdean <aserd...@cloudbasesolutions.com> wrote: > Thanks Guru. > > > > Can you please apply https://github.com/openvswitch/ovs/commit/ > 583d34678d32482d616fe5bd7dc323f044788898 on branch-2.6 ? > Done. Thanks. > > > Thanks, &

Re: [ovs-dev] [PATCH] docker.rst: Add documentation to open up TCP ports.

2017-02-16 Thread Guru Shetty
On 16 February 2017 at 10:25, Ben Pfaff wrote: > On Tue, Feb 07, 2017 at 04:54:44AM -0800, Gurucharan Shetty wrote: > > Signed-off-by: Gurucharan Shetty > > --- > > Documentation/howto/docker.rst | 6 ++ > > 1 file changed, 6 insertions(+) > > > > diff --git

Re: [ovs-dev] [PATCH] ovn-ctl: Add bootstrap ovn-controller CA certificate option.

2017-01-18 Thread Guru Shetty
On 18 January 2017 at 14:26, Lance Richardson wrote: > > From: "Gurucharan Shetty" > > To: d...@openvswitch.org > > Sent: Wednesday, January 18, 2017 6:25:29 AM > > Subject: [ovs-dev] [PATCH] ovn-ctl: Add bootstrap ovn-controller CA > certificate option. > >

Re: [ovs-dev] [PATCH v2 1/5] datapath-windows: Added a new file to support Ipv4 fragments.

2017-01-18 Thread Guru Shetty
On 12 January 2017 at 13:13, Anand Kumar wrote: > This patch adds functionalities to handle IPv4 fragments, which will be > used by Conntrack module. > > Added a new structure to hold the Ipv4 fragments and a hash table to > hold Ipv4 datagram entries. Also added a clean

Re: [ovs-dev] [PATCH v2] msi: add ovs-vswitchd trigger info

2017-02-27 Thread Guru Shetty
On 27 February 2017 at 10:23, Sairam Venugopal wrote: > Thanks for sending this over. I was able to verify that ovs ports were > still retained after a reboot. > It will however be good to add the command to the documentation for folks > who don’t use the MSI. > Applied to

Re: [ovs-dev] [PATCH v4 1/3] Windows: Add internal switch port per OVS bridge

2016-11-10 Thread Guru Shetty
; Thanks, > Sairam > > On 11/4/16, 7:55 AM, "Guru Shetty" <g...@ovn.org> wrote: > > >On 10 October 2016 at 15:47, Sairam Venugopal <vsai...@vmware.com> wrote: > > > >> Sorry for the delay in the review. > >> > >> Acked-by: Sai

Re: [ovs-dev] [CudaMailTagged] [PATCH 1/4] ovn: Support DNAT with port.

2016-11-14 Thread Guru Shetty
On 14 November 2016 at 01:59, nickcooper-zhangtonghao <n...@opencloud.tech> wrote: > Hi Guru Shetty > > Because of public ip restrictions , I have different private IPs sharing a > single outbound internet IP. > The VMs with different private IPs will run different services(e

Re: [ovs-dev] [ovn-kubernetes][]README.md: Set OVS unique system-id

2016-11-25 Thread Guru Shetty
On 24 November 2016 at 02:26, wrote: > We can't find the mailbox in ovn-kubernetes CONTRIBUTING.md , so can you > have any advice for the follow bug ? > Thanks > Please submit a github pull request to the ovn-kubernetes repo. Also, please have a look at the following

Re: [ovs-dev] [PATCH 1/4] ovn: Support DNAT with port.

2016-11-15 Thread Guru Shetty
On 15 November 2016 at 06:30, nickcooper-zhangtonghao <n...@opencloud.tech> wrote: > Hi Guru Shetty. > LB may support DNAT with port. But in some case, there is only a public ip > address set on the gateway router, which is connected to multiple VMs. Thus > this publ

Re: [ovs-dev] [PATCH 2/2] ovn-nbctl: Fix manpage formatting typo.

2016-11-18 Thread Guru Shetty
On 11 October 2016 at 07:36, nickcooper-zhangtonghao < nickcooper-zhangtong...@opencloud.tech> wrote: > Signed-off-by: nickcooper-zhangtonghao opencloud.tech> > Applied, thanks. > --- > ovn/utilities/ovn-nbctl.8.xml | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [ovs-dev] [PATCH 1/2] ovn-nbctl: Add NAT commands.

2016-11-18 Thread Guru Shetty
On 11 October 2016 at 07:36, nickcooper-zhangtonghao < nickcooper-zhangtong...@opencloud.tech> wrote: > This patch provides the command line to create NAT rules > on logical router. > > Signed-off-by: nickcooper-zhangtonghao opencloud.tech> > --- >

Re: [ovs-dev] [PATCH 4/4] ovs: optimize 'ip_parse_port' function.

2016-11-18 Thread Guru Shetty
On 31 October 2016 at 19:00, nickcooper-zhangtonghao < nickcooper-zhangtong...@opencloud.tech> wrote: > Signed-off-by: nickcooper-zhangtonghao opencloud.tech> > Can you tell why one is better than the other? > --- > lib/packets.c | 11 --- > 1 file changed,

Re: [ovs-dev] [PATCH 1/2] ovn-nbctl: Add NAT commands.

2016-11-21 Thread Guru Shetty
On 21 November 2016 at 07:56, nickcooper-zhangtonghao <n...@opencloud.tech> wrote: > Hi Guru Shetty > The logical_ip address or network should be SNATed to an external_ip in a > gw router, then it's unnecessary that the logical_ip is mapped to > multiple external IPs. The exter

Re: [ovs-dev] [PATCH 9/9] ovn-controller: Drop most uses of OVS patch ports.

2016-12-07 Thread Guru Shetty
On 4 December 2016 at 23:17, Ben Pfaff wrote: > Until now, ovn-controller has implemented OVN logical patch ports and > l3gateway ports in terms of OVS patch ports. It is a hassle to create and > destroy ports, and it is also wasteful compared to what the patch ports > actually

Re: [ovs-dev] [PATCH 4/4] [RFC] ofproto-dpif: Make ofproto/trace output easier to read.

2016-12-07 Thread Guru Shetty
On 7 December 2016 at 08:36, Ben Pfaff wrote: > On Tue, Dec 06, 2016 at 11:28:43PM -0800, Ben Pfaff wrote: > > "ovs-appctl ofproto/trace" is invaluable for debugging, but as the users > of > > Open vSwitch have evolved it has failed to keep up with the times. It's > > pretty easy

Re: [ovs-dev] [RFC] Introducing experimental OVN integration for Mesos

2016-12-06 Thread Guru Shetty
On 5 December 2016 at 13:59, Ben Pfaff wrote: > Guru, did you ever have a look at this? It's always nice to integrate > with more systems. > Right. I did work with Nimay to get this patch sent to the mailing list as a RFC. The main reason it was a RFC was because of the

Re: [ovs-dev] OVN plugin for global-scope docker swarm service

2016-12-16 Thread Guru Shetty
On 16 December 2016 at 08:36, Jayashree(Jay) Beltur via dev < ovs-dev@openvswitch.org> wrote: > Hello,Currently, it looks like OVN has support for docker engine only. Is > there any effort to provide OVN plugin to docker swarm mode (global-scope > swarm service)?Thanks! > No immediate plans. It

Re: [ovs-dev] [PATCH v2 1/2] ovn-controller: Tie OpenFlow and logical flows using OpenFlow cookie.

2016-12-12 Thread Guru Shetty
On 9 December 2016 at 22:56, Ben Pfaff wrote: > This makes it easy to find the logical flow that generated a particular > OpenFlow flow, by running "ovn-sbctl dump-flows ". > > Later, this can be refined (and automated for "ofproto/trace"), but this > is still a significant

Re: [ovs-dev] [PATCH] windows: Change driver and MSI company name to LF

2017-01-13 Thread Guru Shetty
On 6 December 2016 at 15:30, Alin Serdean wrote: > Until now we used 'Open vSwitch' as the company/organization name. > > The project is now under The Linux Foundation ownership. > > This patch updates the MSI and driver attributes to reflect that ownership. > >

Re: [ovs-dev] [RFC] Introducing experimental OVN integration for Mesos

2017-01-11 Thread Guru Shetty
December 2016 at 17:43, Ben Pfaff <b...@ovn.org> wrote: > >> On Tue, Dec 06, 2016 at 07:55:36AM -0800, Guru Shetty wrote: >> > On 5 December 2016 at 13:59, Ben Pfaff <b...@ovn.org> wrote: >> > >> > > Guru, did you ever have a look at this? It

Re: [ovs-dev] [PATCH v8 7/8] ovn: avoid snat recirc only on gateway routers

2017-01-09 Thread Guru Shetty
On 8 January 2017 at 16:21, Mickey Spiegel wrote: > Currently, for performance reasons on gateway routers, ct_snat > that does not specify an IP address does not immediately trigger > recirculation. On gateway routers, ct_snat that does not specify > an IP address happens

Re: [ovs-dev] [PATCH V4 1/5] Python tests: Add winutils.py module

2017-01-03 Thread Guru Shetty
On 3 January 2017 at 12:10, Alin Balutoiu wrote: > From: Alin Balutoiu > > This patch adds a new python module which contains > helper functions. These will be neccessary for the > Windows implementation. > > They cover the

Re: [ovs-dev] [PATCH 1/2 v2] datapath-windows: Add Windows 10 family to solution

2017-01-03 Thread Guru Shetty
On 28 December 2016 at 16:25, Alin Serdean wrote: > This patch adds two more compiling targets: > - one for Windows 10 release > - one for Windows 10 Debug > > The new targets are flagged properly to use the new Windows 10 kernel mode > driver and its

Re: [ovs-dev] [PATCH 2/2 v2] datapath-windows: Conntrack disable type truncation warning

2017-01-03 Thread Guru Shetty
On 28 December 2016 at 16:25, Alin Serdean wrote: > Compiling with the WDK 10 gave the following warning: > Warning C4311 'type cast': pointer truncation from 'POVS_CT_ENTRY' to > 'UINT32' > ovsext (OVSExt\ovsext) Conntrack.c 1139 > > This patch disables

Re: [ovs-dev] [PATCH V2 1/5] Python tests: Add winutils.py module

2017-01-03 Thread Guru Shetty
On 3 January 2017 at 07:16, Alin Balutoiu wrote: > From: Alin Balutoiu > > This patch adds a new python module which contains > helper functions. These will be neccessary for the > Windows implementation. > > They cover the

Re: [ovs-dev] [PATCH V3 2/5] Python tests: Ported UNIX sockets to Windows

2017-01-03 Thread Guru Shetty
On 3 January 2017 at 08:46, Alin Balutoiu wrote: > From: Alin Balutoiu > > Unix sockets (AF_UNIX) are not supported on Windows. > The replacement of Unix sockets on Windows is implemented > using named pipes, we are trying to

Re: [ovs-dev] [PATCH V3 5/5] Python tests: Enable python tests on Windows

2017-01-03 Thread Guru Shetty
On 3 January 2017 at 08:46, Alin Balutoiu wrote: > From: Alin Balutoiu > > Updated the Readme with additional library required for > the python tests. > > Remove the code which disable python tests to > be run on Windows. > >

Re: [ovs-dev] [PATCH V3 2/5] Python tests: Ported UNIX sockets to Windows

2017-01-03 Thread Guru Shetty
elf._retry_connect = False > retval = errno.ENOENT > else: > # If retry_connect is false, it means it's already > # connected so we can set the value of retval to 0 > retval = 0 > > > >

Re: [ovs-dev] [PATCH v5 0/6] ovn: add distributed NAT capability

2017-01-04 Thread Guru Shetty
On 3 January 2017 at 01:33, Mickey Spiegel wrote: > Currently OVN supports NAT functionality by connecting each distributed > logical router to a centralized "l3gateway" router that resides on a > single chassis. NAT is only carried out in the "l3gateway" router. > > This

Re: [ovs-dev] [PATCH 3/3 v8] Windows: document multiple NIC support setup

2016-12-20 Thread Guru Shetty
On 20 December 2016 at 11:42, Alin Serdean wrote: > From: Alin Serdean > > This patch updates the documentation on how to set up OVS with multiple > NICs. > > Also update the documentation to show users how new internal ports are

Re: [ovs-dev] [PATCH 5/5] datapath-windows: Conntrack disable type truncation warning

2016-12-21 Thread Guru Shetty
On 5 December 2016 at 07:39, Alin Serdean wrote: > Compiling with the WDK 10 gave the following warning: > Warning C4311 'type cast': pointer truncation from 'POVS_CT_ENTRY' to > 'UINT32' > ovsext (OVSExt\ovsext) Conntrack.c 1139 > > This patch disables

Re: [ovs-dev] [PATCH 2/5] datapath-windows: Add Windows 10 family to solution

2016-12-21 Thread Guru Shetty
On 5 December 2016 at 07:39, Alin Serdean wrote: > This patch adds two more compiling targets: > - one for Windows 10 release > - one for Windows 10 Debug > > The new targets are flagged properly to use the new Windows 10 kernel mode > driver and its

Re: [ovs-dev] [PATCH] ovn-controller: Fix conntrack zone in gateway routers.

2016-12-20 Thread Guru Shetty
On 19 December 2016 at 21:26, Ben Pfaff wrote: > On Mon, Dec 19, 2016 at 04:12:17AM -0800, Gurucharan Shetty wrote: > > The gateway router was using the ct_next action to > > reassemble packets. But ct_next action by default would > > use the zone allocated for a logical port and

Re: [ovs-dev] [RFC: fedora ovn packaging 0/5] RFC fedora ovn packaging

2016-12-20 Thread Guru Shetty
On 15 December 2016 at 05:35, Andy Zhou wrote: > The goal of this series is to make it easier to set up OVN in > a larger setup, i.e. not having all services running on a single host. > > Currently ovn-central package starts and stop all three services > northbound-db, northd and

Re: [ovs-dev] [PATCH v2 2/2] ovn-northd: Add logical flows to support native DNS

2017-03-22 Thread Guru Shetty
On 13 March 2017 at 00:32, wrote: > From: Numan Siddique > > OVN implements native DNS resolution which can be used to resolve the > internal DNS names belonging to a logical datapath. > > To support this, the logical ports should be configured with the

Re: [ovs-dev] [PATCH] datapath-windows: Add support for OVS_CT_ATTR_FORCE_COMMIT

2017-03-22 Thread Guru Shetty
On 21 March 2017 at 00:02, Sairam Venugopal wrote: > Add support for handling OVS_CT_ATTR_FORCE_COMMIT in Conntrack action. > When this flag is specified, it implicitly means commit and deletes > entries in the reverse direction. > > Signed-off-by: Sairam Venugopal

Re: [ovs-dev] [PATCH v4 1/2] ovn: Gratuitous ARP for centralized NAT rules on a distributed router

2017-03-22 Thread Guru Shetty
> > > >> >>> This is achieved by extending >>> the syntax for "options:nat-addresses" in the southbound database, >>> allowing the condition 'is_chassis_resident("LPORT_NAME")' to be >>> appended >>> after the MAC and IP addresses. This condition is automatically inserted >>> by ovn-northd when

Re: [ovs-dev] [PATCH v3 2/2] ovn-northd: Add logical flows to support native DNS

2017-03-27 Thread Guru Shetty
On 27 March 2017 at 07:13, wrote: > From: Numan Siddique > > OVN implements native DNS resolution which can be used to resolve the > internal DNS names belonging to a logical datapath. > > To support this, a new table 'DNS' is added in the NB DB. A new

Re: [ovs-dev] [PATCH v6 2/2] ovn: Gratuitous ARP for distributed NAT rules

2017-03-30 Thread Guru Shetty
On 30 March 2017 at 11:42, Mickey Spiegel wrote: > This patch extends gratuitous ARP support for NAT addresses so that it > applies to distributed NAT rules on a distributed logical router. > Distributed NAT rules have type "dnat_and_snat" and specify > 'external_mac' and

Re: [ovs-dev] [PATCH v2 2/2] ovn-northd: Add logical flows to support native DNS

2017-03-22 Thread Guru Shetty
On 22 March 2017 at 09:51, Guru Shetty <g...@ovn.org> wrote: > > > On 13 March 2017 at 00:32, <nusid...@redhat.com> wrote: > >> From: Numan Siddique <nusid...@redhat.com> >> >> OVN implements native DNS resolution which can be used to resolve

Re: [ovs-dev] [PATCH v2 2/2] ovn-northd: Add logical flows to support native DNS

2017-03-23 Thread Guru Shetty
On 22 March 2017 at 21:25, Numan Siddique <nusid...@redhat.com> wrote: > > > On Wed, Mar 22, 2017 at 10:43 PM, Guru Shetty <g...@ovn.org> wrote: > >> >> >> On 22 March 2017 at 09:51, Guru Shetty <g...@ovn.org> wrote: >> >>>

Re: [ovs-dev] [PATCH v5 2/3] ovn: Gratuitous ARP for centralized NAT rules on a distributed router

2017-03-29 Thread Guru Shetty
On 27 March 2017 at 18:34, Mickey Spiegel wrote: > This patch extends gratuitous ARP support for NAT addresses so that it > applies to centralized NAT rules on a distributed router, in addition to > the existing gratuitous ARP support for NAT addresses on gateway routers.

Re: [ovs-dev] [PATCH v5 3/3] ovn: Gratuitous ARP for distributed NAT rules

2017-03-29 Thread Guru Shetty
On 27 March 2017 at 18:34, Mickey Spiegel wrote: > This patch extends gratuitous ARP support for NAT addresses so that it > applies to distributed NAT rules on a distributed logical router. > Distributed NAT rules have type "dnat_and_snat" and specify > 'external_mac' and

Re: [ovs-dev] [PATCH v3 2/2] ovn-northd: Add logical flows to support native DNS

2017-03-29 Thread Guru Shetty
> > > > Agree. It was in my mind. I somehow missed it out. > > >> >> The above would mean that for each logical port, we need to create a DNS >> record in the DNS table. Having the schema like the above has advantages. >> In the future, if we have to add new options for DNS, then it becomes >>

Re: [ovs-dev] [PATCH v5 1/3] ovn: Fix options:router-port in Gratuitous ARP tests

2017-03-28 Thread Guru Shetty
On 27 March 2017 at 18:34, Mickey Spiegel wrote: > In two of the Gratuitous ARP tests, "options:router-port" > is not set correctly. This does not currently affect > validity of the tests since the next line resets > "options:router-port" to the correct value. > >

Re: [ovs-dev] [PATCH v3 2/3] ovn: Gratuitous ARP for centralized NAT rules on a distributed router

2017-03-17 Thread Guru Shetty
On 2 February 2017 at 20:48, Mickey Spiegel wrote: > This patch extends gratuitous ARP support for NAT addresses so that it > applies to centralized NAT rules on a distributed router, in addition to > the existing gratuitous ARP support for NAT addresses on gateway

Re: [ovs-dev] [PATCH v4 1/2] ovn: Gratuitous ARP for centralized NAT rules on a distributed router

2017-03-21 Thread Guru Shetty
On 17 March 2017 at 15:30, Mickey Spiegel wrote: > This patch extends gratuitous ARP support for NAT addresses so that it > applies to centralized NAT rules on a distributed router, in addition to > the existing gratuitous ARP support for NAT addresses on gateway routers.

Re: [ovs-dev] [PATCH v2] datapath-windows: Pass fwdCtx to conntrack

2017-04-21 Thread Guru Shetty
On 20 April 2017 at 15:26, Yin Lin wrote: > There dependencies in Contrack module such as NAT and fragmentation on > OvsForwardingContext. This patch will make OvsForwardingContext public > in order to implement these functionalities. > > Signed-off-by: Yin Lin

Re: [ovs-dev] [PATCH] datapath-windows: Add software checksums for nbl which contain multiple nb

2017-04-21 Thread Guru Shetty
On 20 April 2017 at 19:43, Alin Serdean wrote: > Until now we only needed to compute software checksums on net buffer lists > containing a single net buffer. > > This patch allows the software checksums to be applied on a net buffer list > with multiple net

Re: [ovs-dev] [PATCH 2/2] ovn-util: Allow /32 IP addresses for router ports.

2017-04-21 Thread Guru Shetty
On 14 April 2017 at 20:38, Ben Pfaff wrote: > On Thu, Mar 09, 2017 at 11:46:38PM -0800, Gurucharan Shetty wrote: > > On Google cloud, a VM gets a /32 IP address. When OVN > > is deployed on such VMs, the OVN gateway router's IP > > address becomes a /32 IP address. This commit

Re: [ovs-dev] datapath-windows: Pass fwdCtx to conntrack

2017-04-20 Thread Guru Shetty
On 19 April 2017 at 13:18, Yin Lin wrote: > There dependencies in Contrack module such as NAT and fragmentation on > OvsForwardingContext. This patch will make OvsForwardingContext public > in order to implement these functionalities. > Can you please respin this with a

Re: [ovs-dev] [PATCH 2/2] ovn-util: Allow /32 IP addresses for router ports.

2017-04-21 Thread Guru Shetty
On 21 April 2017 at 10:42, Ben Pfaff <b...@ovn.org> wrote: > On Fri, Apr 21, 2017 at 10:10:26AM -0700, Guru Shetty wrote: > > On 14 April 2017 at 20:38, Ben Pfaff <b...@ovn.org> wrote: > > > > > On Thu, Mar 09, 2017 at 11:46:38PM -0800, Gurucharan Shetty wrote

Re: [ovs-dev] [PATCH] windows: Remove dead code in daemon-windows

2017-03-07 Thread Guru Shetty
On 5 February 2017 at 15:49, Alin Serdean wrote: > Found by inspection. > > Signed-off-by: Alin Gabriel Serdean > Applied to master. > --- > lib/daemon-windows.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > >

Re: [ovs-dev] [PATCH 01/10] windows: Add definition of getrusage

2017-03-07 Thread Guru Shetty
On 5 February 2017 at 20:41, Alin Serdean wrote: > getrusage is implemented in lib/getrusage-windows.c. > > This patch just adds its definition to include/windows/sys/resource.h, > which serves for files that include . > > Another that we could also do is to move

Re: [ovs-dev] [PATCH] ovn-controller: Don't bind non-existent interfaces.

2017-03-10 Thread Guru Shetty
On 8 March 2017 at 09:42, Russell Bryant wrote: > On Wed, Mar 8, 2017 at 2:18 AM, Gurucharan Shetty wrote: > > There are multiple reasons why a interface can exist > > in the Open vSwitch database but not exist in the system. > > For e.g, a restart of a host after

Re: [ovs-dev] [PATCH] ovn-controller: Don't bind non-existent interfaces.

2017-03-10 Thread Guru Shetty
On 8 March 2017 at 09:42, Russell Bryant wrote: > On Wed, Mar 8, 2017 at 2:18 AM, Gurucharan Shetty wrote: > > There are multiple reasons why a interface can exist > > in the Open vSwitch database but not exist in the system. > > For e.g, a restart of a host after

Re: [ovs-dev] [PATCH v2] datapath-windows: Fix GENEVE option header

2017-03-06 Thread Guru Shetty
atch changes the GENEVE option header into little endian. > > Found while testing. > > Signed-off-by: Alin Gabriel Serdean <aserd...@cloudbasesolutions.com> > Acked-by: Yin Lin <li...@vmware.com> > Applied, thanks. > --- > v2: Change commit title and me

Re: [ovs-dev] [PATCH] FAQ: Add another question about do-nothing flows.

2017-03-06 Thread Guru Shetty
On 6 March 2017 at 08:11, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff > Acked-by: Gurucharan Shetty > --- > Documentation/faq/openflow.rst | 21 + > 1 file changed, 21 insertions(+) > > diff --git a/Documentation/faq/openflow.rst

Re: [ovs-dev] [PATCH 05/10] windows: fix calls in netlink-socket

2017-03-07 Thread Guru Shetty
On 5 February 2017 at 20:41, Alin Serdean wrote: > Add nl_sock_transact forward declaration, since it is used before > being on implemented. This applies only on Windows. > > Move nl_sock_subscribe_packet__ function before it is used. > > It makes more sense to

Re: [ovs-dev] [PATCH 06/10] windows: add function definition to poll-loop.h

2017-03-07 Thread Guru Shetty
On 5 February 2017 at 20:41, Alin Serdean wrote: > poll_wevent_wait_at is used in the #define but the function definition > is missing. > > Signed-off-by: Alin Gabriel Serdean > Applied. Thanks > --- > lib/poll-loop.h | 3 ++-

Re: [ovs-dev] [PATCH 07/10] windows: add include to stream-windows.c

2017-03-07 Thread Guru Shetty
On 5 February 2017 at 20:41, Alin Serdean wrote: > fatal_signal_unlink_file_now is used but the header for it is missing in > the include section. > > Signed-off-by: Alin Gabriel Serdean > Applied. > --- > lib/stream-windows.c

Re: [ovs-dev] [PATCH v5 2/3] ovn-controller: Add 'dns_lookup' action

2017-04-24 Thread Guru Shetty
On 17 April 2017 at 08:13, wrote: > From: Numan Siddique > > This patch adds a new OVN action 'dns_lookup' to support native DNS. > ovn-controller parses this action and adds a NXT_PACKET_IN2 > OF flow with 'pause' flag set. > > A new table 'DNS' is

[ovs-dev] Bug#860786: Bug#860786: README.Debian: include IPv6 in examples for /etc/network/interfaces

2017-07-11 Thread Guru Shetty
On 19 April 2017 at 23:00, Daniel Pocock wrote: > Package: openvswitch-switch > Version: 2.3.0+git20140819-3+deb8u1 > Severity: wishlist > > > Looking at the examples for /etc/network/interfaces, none of them > include IPv6. > > I've tried configuring it using the example

Re: [ovs-dev] [PATCH v4 4/7] ovn: l3ha, handling of multiple gateway chassis

2017-07-12 Thread Guru Shetty
On 12 July 2017 at 06:36, Miguel Angel Ajo Pelayo wrote: > This patch in the series still has the race condition where all the chassis > the Gateway_Chassis list of a chassisredirect port will try to fight for > the chassis column of Port_Binding. Other than that it works. >

Re: [ovs-dev] [PATCH 2/2] openvswitch-switch.postinst: Remove upstart files.

2017-07-12 Thread Guru Shetty
On 12 July 2017 at 09:34, Ben Pfaff wrote: > On Mon, Jun 26, 2017 at 04:05:14AM -0700, Gurucharan Shetty wrote: > > For a while, ubuntu used upstart scripts as an alternative > > for sysv scripts. For e.g popular releases like ubuntu12.04 > > and ubuntu14.04 have upstart

Re: [ovs-dev] Fail to netdev_open internal iface with error "File exists"

2017-07-15 Thread Guru Shetty
IMO, we pretty much have a broken branch-2.7 for a while now. I can't seem to get geneve tunnels to work across 2 machines in a flaky way. I am not sure whether this is the cause of the problem, but looks like others are seeing similar issues. On 14 July 2017 at 06:34, Huanle Han

Re: [ovs-dev] [PATCH] Revert "netdev: Fix netdev_open() to adhere to class type if given"

2017-07-17 Thread Guru Shetty
On 17 July 2017 at 12:51, Justin Pettit wrote: > > > On Jul 17, 2017, at 7:49 AM, Eelco Chaudron wrote: > > > > On 17/07/17 11:10, Numan Siddique wrote: > >> > >> > >> On Mon, Jul 17, 2017 at 1:10 PM, Eelco Chaudron

Re: [ovs-dev] [PATCH v2] datapath-windows: Include ICMP type and code fields to find a matching ct entry

2017-06-27 Thread Guru Shetty
On 27 June 2017 at 12:48, Anand Kumar wrote: > Hi Guru, > > Could you please apply this patch? > Applied, thanks for the reminder. > > Thanks, > Anand Kumar > > On 6/23/17, 3:04 PM, "Sairam Venugopal" wrote: > > Acked-by: Sairam Venugopal

Re: [ovs-dev] [PATCH v5 3/3] ovn-northd: Add logical flows to support native DNS

2017-04-21 Thread Guru Shetty
On 17 April 2017 at 08:13, wrote: > From: Numan Siddique > > OVN implements native DNS resolution which can be used to resolve the > internal DNS names belonging to a logical datapath. > > To support this, a new table 'DNS' is added in the NB DB. A new

Re: [ovs-dev] [PATCH] debian, xenserver: Update logrotate config to match RHEL.

2017-04-24 Thread Guru Shetty
On 13 April 2017 at 10:47, Ben Pfaff wrote: > Commit 618a5b45ae8b ("rhel: Avoid logrotate error if /var/run/openvswitch > does not exist") updated the RHEL logrotate configuration. This commit > makes similar changes for Debian, by synchronizing with the RHEL version. > > In

Re: [ovs-dev] [PATCH] ovn: Add support for ACL logging.

2017-07-28 Thread Guru Shetty
On 28 July 2017 at 10:05, Ben Pfaff wrote: > On Thu, Jul 27, 2017 at 05:59:54PM -0700, Justin Pettit wrote: > > > > > On Jul 27, 2017, at 4:03 PM, Han Zhou wrote: > > > > > > > > > > > > On Wed, Jul 26, 2017 at 1:55 PM, Justin Pettit > wrote: >

Re: [ovs-dev] [PATCH] rhel: Add support for "systemctl reload openvswitch"

2017-08-08 Thread Guru Shetty
On 8 August 2017 at 11:05, Russell Bryant <russ...@ovn.org> wrote: > On Tue, Aug 8, 2017 at 1:32 PM, Guru Shetty <g...@ovn.org> wrote: > > On 8 August 2017 at 07:42, Timothy Redaelli <tredae...@redhat.com> > wrote: > > > >> The reload procedure will

Re: [ovs-dev] [PATCH] debian: Add another note on interfaces in "auto" section.

2017-08-07 Thread Guru Shetty
On 7 August 2017 at 10:14, Ben Pfaff <b...@ovn.org> wrote: > On Mon, Aug 07, 2017 at 10:10:40AM -0700, Guru Shetty wrote: > > On 7 August 2017 at 09:50, Ben Pfaff <b...@ovn.org> wrote: > > > > > On Sun, Aug 06, 2017 at 10:56:30PM -0700, Gurucharan Shetty

Re: [ovs-dev] [PATCH] debian: Add another note on interfaces in "auto" section.

2017-08-07 Thread Guru Shetty
> > > Acked-by: Ben Pfaff > Thank you! I applied this to master. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH RFC] Drop support for RHEL 5 and 6

2017-05-16 Thread Guru Shetty
On 15 May 2017 at 16:49, Joe Stringer wrote: > On 12 May 2017 at 07:45, Timothy Redaelli wrote: > > RHEL 6 is not supported anymore since it uses Python 2.6 and GCC 4.4.x, > > but Open vSwitch needs, at least, Python 2.7 and GCC 4.6 to build > correctly. > >

Re: [ovs-dev] [PATCH v9 1/4] datapath-windows: Add support for NAT in conntrack

2017-06-12 Thread Guru Shetty
On 9 June 2017 at 15:16, Yin Lin wrote: > From: Anand Kumar > > Add support for parsing netlink attributes related to NAT > in conntrack. > > Co-Authored-by: Yin Lin > Co-Authored-by: Darrell Ball > Signed-off-by:

Re: [ovs-dev] ifup locked when start ovs in debian9 with systemd

2017-06-19 Thread Guru Shetty
What OVS version is this? What is the platform version? i.e Debian/Ubuntu etc. Does your OVS have the following fix? https://github.com/openvswitch/ovs/commit/15af3d44c65eb3cd724378ce1b30c51aa87f4f69 On 19 June 2017 at 07:17, ychen wrote: > 1. phenomenon >ifup: waiting

Re: [ovs-dev] [PATCH 2/3] ovn: Ability to skip some IP addresses for SNAT.

2017-06-20 Thread Guru Shetty
ever the match for “nosnat” should be on destination IP. > > I will rebase it to current master and run the tests. > > Regards > - Manoj > > From: Guru Shetty <g...@ovn.org> > Date: Monday, June 19, 2017 at 1:04 PM > To: Manoj Sharma <manoj.sha...@nutanix.com> > Cc: &

Re: [ovs-dev] [PATCH] windows: Remove vlog_init() from service_start function

2017-06-20 Thread Guru Shetty
On 16 June 2017 at 10:06, Anand Kumar wrote: > When --syslog-method is passed as a cmd line argument and > ovs daemons are started as a service, --syslog-method argument is not > honoured, as vlog module is initialized by service_start function > before parsing the command

Re: [ovs-dev] [PATCH] tests: switch from signed to unsigned when formatting

2017-06-21 Thread Guru Shetty
On 20 June 2017 at 12:44, Alin Serdean wrote: > x->errline is a signed int > (https://github.com/openvswitch/ovs/blob/934386dd129a3f15b2546562a775f2 > f43dd3aac6/tests/test-sflow.c#L88) > Flagged by static code analysis. > > Signed-off-by: Alin Gabriel Serdean

Re: [ovs-dev] [PATCH] datapath-windows: Fix switch-case alignments in Conntrack.c

2017-06-21 Thread Guru Shetty
On 21 June 2017 at 11:20, Sairam Venugopal wrote: > Minor - Fix the switch case alignments. Found by inspection. > > Signed-off-by: Sairam Venugopal > Applied. > --- > datapath-windows/ovsext/Conntrack.c | 83 ++ > --- >

  1   2   3   >