Re: [ovs-dev] [PATCH net-next v2] ofproto: Honor OFPFF_RESET_COUNTS flag in flow modify message.

> On Dec 1, 2016, at 3:44 PM, Ben Pfaff wrote: > > On Thu, Dec 01, 2016 at 01:09:12PM -0800, Jarno Rajahalme wrote: >>> If I may be permitted to nit-pick, the name "modify_forward_counts" took >>> me a bit of thinking to properly understand. Maybe "modify_keep_stats" >>> would be

Re: [ovs-dev] [PATCH net-next v2] ofproto: Honor OFPFF_RESET_COUNTS flag in flow modify message.

On Thu, Dec 01, 2016 at 09:37:19PM +, Tony van der Peet wrote: > I will foreshadow another problem I found while implementing test > suite 140. This is where flow is created without SEND_FLOW_REM flag, > but flow delete does set this bit. The flow removed message is not > sent in this case. I

Re: [ovs-dev] [PATCH net-next v2] ofproto: Honor OFPFF_RESET_COUNTS flag in flow modify message.

On Thu, Dec 01, 2016 at 01:09:12PM -0800, Jarno Rajahalme wrote: > > If I may be permitted to nit-pick, the name "modify_forward_counts" took > > me a bit of thinking to properly understand. Maybe "modify_keep_stats" > > would be easier for me to understand at first glance. > > “stats” include

Re: [ovs-dev] [PATCH net-next v2] ofproto: Honor OFPFF_RESET_COUNTS flag in flow modify message.

Hi Ben, Jarno > Tony, does this solve the problem for you? Yes it does. I like the solution presented by Jarno a bit more than mine too, I had a feeling that adding a new flag would cause problems. I will foreshadow another problem I found while implementing test suite 140. This is where flow

Re: [ovs-dev] [PATCH net-next v2] ofproto: Honor OFPFF_RESET_COUNTS flag in flow modify message.

> On Nov 30, 2016, at 9:06 PM, Ben Pfaff wrote: > > On Wed, Nov 30, 2016 at 05:51:12PM -0800, Jarno Rajahalme wrote: >> While a flow modify must keep the original flow's flags, it must reset >> counts if (and only if) the reset_counts flag is present in the flow >> mod message. >>