ray...@redhat.com]
>>>>> Sent: Tuesday, December 19, 2017 3:07 PM
>>>>> To: Weglicki, MichalX <michalx.wegli...@intel.com>; d...@openvswitch.org
>>>>> Subject: Re: [ovs-dev] [PATCH v2] netdev: Custom statistics.
>>>>>
>>>>> On
> -Original Message-
> From: Kevin Traynor [mailto:ktray...@redhat.com]
> Sent: Monday, January 8, 2018 7:08 PM
> To: Weglicki, MichalX <michalx.wegli...@intel.com>; d...@openvswitch.org
> Subject: Re: [ovs-dev] [PATCH v2] netdev: Custom statistics.
>
> On
On Mon, Jan 08, 2018 at 08:28:45AM -0800, Ben Pfaff wrote:
> On Mon, Jan 08, 2018 at 11:55:26AM +, Weglicki, MichalX wrote:
> > Hi Ben,
> > > I don't like the idea implied in the code in a few places that name[] in
> > > struct netdev_custom_counter might not be null-terminated. I think that
MichalX <michalx.wegli...@intel.com>; d...@openvswitch.org
>>> Subject: Re: [ovs-dev] [PATCH v2] netdev: Custom statistics.
>>>
>>> On 12/05/2017 02:55 PM, Michal Weglicki wrote:
>>>> - New get_custom_stats interface function is added to netdev. It
>>>>
On Mon, Jan 08, 2018 at 11:55:26AM +, Weglicki, MichalX wrote:
> Hi Ben,
> > I don't like the idea implied in the code in a few places that name[] in
> > struct netdev_custom_counter might not be null-terminated. I think that
> > we should ensure that it is always null terminated. Otherwise
t; Subject: Re: [ovs-dev] [PATCH v2] netdev: Custom statistics.
>
> On Tue, Dec 05, 2017 at 02:55:20PM +, Michal Weglicki wrote:
> > - New get_custom_stats interface function is added to netdev. It
> > allows particular netdev implementation to expose custom
> > cou
On Tue, Dec 05, 2017 at 02:55:20PM +, Michal Weglicki wrote:
> - New get_custom_stats interface function is added to netdev. It
> allows particular netdev implementation to expose custom
> counters in dictionary format (counter name/counter value).
> - New statistics are retrieved using
> -Original Message-
> From: Kevin Traynor [mailto:ktray...@redhat.com]
> Sent: Tuesday, December 19, 2017 3:07 PM
> To: Weglicki, MichalX <michalx.wegli...@intel.com>; d...@openvswitch.org
> Subject: Re: [ovs-dev] [PATCH v2] netdev: Custom statistics.
>
> On
On 12/05/2017 02:55 PM, Michal Weglicki wrote:
> - New get_custom_stats interface function is added to netdev. It
> allows particular netdev implementation to expose custom
> counters in dictionary format (counter name/counter value).
> - New statistics are retrieved using experimenter code
