[Bug 948105] Review Request: rubygem-ronn - Manual authoring tool
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=948105 Mamoru TASAKA mtas...@fedoraproject.org changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #8 from Mamoru TASAKA mtas...@fedoraproject.org --- Okay, clean. This package (rubygem-ronn) is APPROVED by mtasaka -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=EySXdC8pw2a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 922460] Review Request: rubygem-syck - Gemified version of Syck from Ruby's stdlib
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=922460 --- Comment #5 from Mamoru TASAKA mtas...@fedoraproject.org --- Thank you for review! Then * For should item - It seems only this one? [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. License clause is included in README.rdoc, so this is not a problem * For rpmlint - spelling-error is actually not spelling errors - no-soname is expected (usually dlopen'ed libraries does not have soname) - For unused-direct-shlib-dependency: Although perhaps these extra linkages are not needed actually, leaving these won't harm and as this is specified by ruby-libs side (%_libdir/ruby/rbconfig.rb), I leave this as it is for now. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=04NOLTWe9ma=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 929256] Review Request: nomacs - Qt-based image viewer
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=929256 Mamoru TASAKA mtas...@fedoraproject.org changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|mtas...@fedoraproject.org Flags||fedora-review? --- Comment #5 from Mamoru TASAKA mtas...@fedoraproject.org --- Taking. I would appreciate it if you would review one of my review requests (e.g. bug 946968 , qt based) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=RboWU1pQz2a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 920436] Review Request: rubygem-bootstrap-sass - Bootstrap, converted to Sass
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=920436 Mamoru TASAKA mtas...@fedoraproject.org changed: What|Removed |Added Flags||needinfo?(dal...@redhat.com ||) --- Comment #4 from Mamoru TASAKA mtas...@fedoraproject.org --- ping? By the way, bug 922460 is assigned, so instead I would appreciate it if you would review swaps with my other requests (e.g. bug 892314 ) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Qkaki06e6fa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 903246] Review Request: cpopen - Creates a subprocess in simpler safer manner
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=903246 --- Comment #5 from Yaniv Bronhaim bronh...@gmail.com --- set cpopen-createproess.so permissions to 755 Updated: http://bronhaim.fedorapeople.org/python-cpopen.spec http://bronhaim.fedorapeople.org/python-cpopen-1.2.1-1.fc17.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Aih91SliQja=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 928541] Review Request: python-stem - Python controller library for Tor
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=928541 --- Comment #1 from Juan Orti Alcaine juan.o...@miceliux.com --- Spec URL: http://jorti.fedorapeople.org/stem/python-stem.spec SRPM URL: http://jorti.fedorapeople.org/stem/python-stem-1.0.1-2.fc18.src.rpm I have updated the source URL -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=p3Nk78MwQKa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 922460] Review Request: rubygem-syck - Gemified version of Syck from Ruby's stdlib
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=922460 Ricky Elrod rel...@redhat.com changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #6 from Ricky Elrod rel...@redhat.com --- Okay :) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=SY6eek330Za=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 922460] Review Request: rubygem-syck - Gemified version of Syck from Ruby's stdlib
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=922460 --- Comment #7 from Ricky Elrod rel...@redhat.com --- This package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Uoq0oGsshAa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 948105] Review Request: rubygem-ronn - Manual authoring tool
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=948105 Ricky Elrod rel...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #9 from Ricky Elrod rel...@redhat.com --- New Package SCM Request === Package Name: rubygem-ronn Short Description: Manual authoring tool Owners: codeblock Branches: f18 f19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=3Obt8cf3DZa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 946968] Review Request: pcmanfm-qt - Qt port of the LXDE file manager PCManFM
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=946968 Eugene A. Pivnev ti.eug...@gmail.com changed: What|Removed |Added CC||ti.eug...@gmail.com --- Comment #2 from Eugene A. Pivnev ti.eug...@gmail.com --- 1. Please - separate spec sections other then expressions inside them - e.g. with double CR. It's too hard to read spec now. 2. maybe to add -DCMAKE_BUILD_TYPE=Release to %cmake will be better (https://bugzilla.redhat.com/show_bug.cgi?id=919044#c22) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0oCHcPjI9Ma=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 947453] Review Request: perl-ExtUtils-BuildRC - A reader for Build.PL configuration files
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=947453 --- Comment #1 from Paul Howarth p...@city-fan.org --- Upstream update: Spec URL unchanged. SRPM: http://www.city-fan.org/~paul/extras/perl-ExtUtils-BuildRC/perl-ExtUtils-BuildRC-0.004-1.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=1v46eyZ9QJa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 946968] Review Request: pcmanfm-qt - Qt port of the LXDE file manager PCManFM
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=946968 --- Comment #3 from Mamoru TASAKA mtas...@fedoraproject.org --- (In reply to comment #2) 1. Please - separate spec sections other then expressions inside them - e.g. with double CR. It's too hard to read spec now. Well, even if I add one more new line between section, after review passed I again cut such extra line... (I agree that at least one line is needed between sections, but two lines are just redundant) 2. maybe to add -DCMAKE_BUILD_TYPE=Release to %cmake will be better (https://bugzilla.redhat.com/show_bug.cgi?id=919044#c22) May consider afterwards. I will wait for full reviews to see what are real blockers, thank you. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=wdLgRped2Na=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 946968] Review Request: pcmanfm-qt - Qt port of the LXDE file manager PCManFM
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=946968 Eugene A. Pivnev ti.eug...@gmail.com changed: What|Removed |Added Flags||fedora-review? --- Comment #4 from Eugene A. Pivnev ti.eug...@gmail.com --- Despite pcmanfm-qt is stil buggy now (working with remote FS like ssh/webdav) - _formally_ it can be packaged. I get it on review -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=NQHhNLPXbYa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 946968] Review Request: pcmanfm-qt - Qt port of the LXDE file manager PCManFM
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=946968 --- Comment #5 from Kevin Kofler ke...@tigcc.ticalc.org --- IMHO, the spacing between sections is fine as is, it's definitely not a review criterion. I'd remove the blank lines INSIDE the %prep, %install and %files sections though, then the blank lines between the sections become better demarcators. IMHO, the sections are not so large that they need cutting into chunks with blank lines. But again, the specfile is legible as is, so this is mostly a matter of personal taste. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=CQRQzNS1Mca=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 946968] Review Request: pcmanfm-qt - Qt port of the LXDE file manager PCManFM
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=946968 --- Comment #6 from Eugene A. Pivnev ti.eug...@gmail.com --- (In reply to comment #5) IMHO, the spacing between sections is fine as is, it's definitely not a review criterion. I'd remove the blank lines INSIDE the %prep, %install and %files sections though, then the blank lines between the sections become better demarcators. IMHO, the sections are not so large that they need cutting into chunks with blank lines. But again, the specfile is legible as is, so this is mostly a matter of personal taste. I agree that spec format is not blocker for review. But some kind of readability must be. As for me - I separate sections with one CR and no one blank CR inside sections. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=FNmEFzE7iWa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 946968] Review Request: pcmanfm-qt - Qt port of the LXDE file manager PCManFM
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=946968
--- Comment #7 from Eugene A. Pivnev ti.eug...@gmail.com ---
Package Review
==
= MUST items =
[+]: Package does not contain kernel modules.
[+]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
[+]: Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
[+]: %build honors applicable compiler flags or justifies otherwise.
[+]: Package contains no bundled libraries without FPC exception.
[+]: Changelog in prescribed format.
[+]: Sources contain only permissible code or content.
[+]: Development files must be in a -devel package
[+]: Package requires other packages for directories it uses.
[+]: Package uses nothing in %doc for runtime.
[+]: Package is not known to require ExcludeArch.
[+]: Fully versioned dependency in subpackages, if present.
[+]: Package complies to the Packaging Guidelines
[+]: License field in the package spec file matches the actual license.
[+]: License file installed when any subpackage combination is installed.
[+]: Package consistently uses macro is (instead of hard-coded directory
names).
[+]: Package is named according to the Package Naming Guidelines.
[+]: Package does not generate any conflict.
[+]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[+]: Package must own all directories that it creates.
[+]: Package does not own files or directories owned by other packages.
[+]: Requires correct, justified where necessary.
[+]: Spec file is legible and written in American English.
[+]: Package contains systemd file(s) if in need.
[+]: update-desktop-database is invoked when required
[+]: Useful -debuginfo package or justification otherwise.
[+]: Large documentation must go in a -doc subpackage.
[x]: All build dependencies are listed in BuildRequires, except for any that
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[x]: If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
= SHOULD items =
[+]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[+]: Final provides and requires are sane (see attachments).
[+]: Package functions as described.
[+]: Latest version is packaged.
[+]: Package does not include license text files separate from upstream.
[+]: Scriptlets must be sane, if used.
[+]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[+]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[+]: Packages should try to preserve timestamps of original installed files.
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: Dist tag is present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Uses parallel make.
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: SourceX tarball generation or download is documented.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define.
= EXTRA items =
[x]: Large data in /usr/share should live in a noarch subpackage if package is
[Bug 946968] Review Request: pcmanfm-qt - Qt port of the LXDE file manager PCManFM
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=946968 Eugene A. Pivnev ti.eug...@gmail.com changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #8 from Eugene A. Pivnev ti.eug...@gmail.com --- Silence... Ok - Approved. But - tune spec before bodhi: * resolve -DCMAKE_BUILD_TYPE=release question * non-break-space line 72, char 39, non-break-space line 75, char 39 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=TKq7Rgcijna=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 922460] Review Request: rubygem-syck - Gemified version of Syck from Ruby's stdlib
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=922460 Mamoru TASAKA mtas...@fedoraproject.org changed: What|Removed |Added Flags||fedora-cvs? --- Comment #8 from Mamoru TASAKA mtas...@fedoraproject.org --- Thank you! New Package SCM Request === Package Name: rubygem-syck Short Description: Gemified version of Syck from Ruby's stdlib Owners: mtasaka Branches: f19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=r2EipbsQqpa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 949214] Review Request: python-iptools - A few useful functions and objects for manipulating ip addresses in python
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=949214 Lokesh Mandvekar l...@buffalo.edu changed: What|Removed |Added CC||l...@buffalo.edu Flags||fedora-review? --- Comment #1 from Lokesh Mandvekar l...@buffalo.edu --- Hi, I'm a new packager in need of sponsorship and this is my first review (so please do let me know if my review needs improvement). * Koji build fails: http://koji.fedoraproject.org/koji/taskinfo?taskID=5222620 Going through the logs I see this: ImportError: No module named setuptools I ran koji like so: koji build --scratch f18 SRPM_file * rpmlint on spec shows no error and warnings, and on srpm shows a spelling-error warning, also need rpmlint output on binary rpm. Thanks, -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=VzkEBdChh5a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 949214] Review Request: python-iptools - A few useful functions and objects for manipulating ip addresses in python
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=949214 --- Comment #2 from Orion Poplawski or...@cora.nwra.com --- Review comments: - You might suggest what is needed to fix the build - You should list the warning and comment on whether it is relevant or not. In this case: python-iptools.src: W: spelling-error Summary(en_US) ip - pi, up, op I've capitalized IP. New package: http://www.cora.nwra.com/~orion/fedora/python-iptools-0.6.0-1.fc18.src.rpm * Sun Apr 7 2013 Orion Poplawski or...@cora.nwra.com - 0.6.0-2 - Add BR python-setuptools - Add %%check -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=FpAu9U0L7ra=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 929256] Review Request: nomacs - Qt-based image viewer
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=929256 --- Comment #6 from Mamoru TASAKA mtas...@fedoraproject.org --- Some notes: * description - Some part of description is redundant and better to fix - free image viewer is just redundant. Fedora does not allow non-free software. - for windows and Linux systems is not needed - License information is shown in License column, writing also in description is just redundant. * SourceURL: - For sourceforge based tarball, please follow: https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL#Sourceforge.net * Compilar flags - Optimization level -O2 in %optflags are replaced by -O3, which is discouraged on Fedora: https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Compiler_flags -- 227 Building CXX object CMakeFiles/nomacs.dir/src/DkConnection.cpp.o 228 /usr/bin/c++ -DHAVE_EXIV2_HPP -DLIBRAW_VERSION_14 -DNOMACS_VERSION=\1.0.0\ -DQT_CORE_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_NO_DEBUG -DQT_NO_DEBUG_OUTPUT -DWITH_OPENCV -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m32 -march=i686 -mtune=atom -fasynchronous-unwind-tables -O3 -DNDEBUG -I/usr/include/QtGui -I/usr/include/QtNetwork -I/usr/include/QtCore -I/usr/include/QtDesigner -I/usr/include/QtDeclarative -I/usr/include/QtScriptTools -I/usr/include/QtDBus -I/usr/include/QtXml -I/usr/include/QtSql -I/usr/include/QtOpenGL -I/usr/include/QtMultimedia -I/usr/include/QtXmlPatterns -I/usr/include/QtHelp -I/usr/include/QtUiTools -I/usr/include/QtTest -I/usr/include/QtScript -I/usr/include/QtSvg -I/usr/include/Qt3Support -I/usr/lib/qt4/mkspecs/default -I/usr/include/libraw -I/usr/include/opencv -I/builddir/build/BUILD/nomacs-1.0.0/build -I/builddir/build/BUILD/nomacs-1.0.0/src-o CMakeFiles/nomacs.dir/src/DkConnection.cpp.o -c /builddir/build/BUILD/nomacs-1.0.0/src/DkConnection.cpp -- Please remove -O3 optimization level. * Updating mime infomation - Installed desktop file contains mime information. Please follow https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop-database -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=EWCGXF5aTSa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 949214] Review Request: python-iptools - A few useful functions and objects for manipulating ip addresses in python
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=949214 Lokesh Mandvekar l...@buffalo.edu changed: What|Removed |Added Flags|fedora-review? | --- Comment #3 from Lokesh Mandvekar l...@buffalo.edu --- Thanks for the review comments. I guess the new package is: http://www.cora.nwra.com/~orion/fedora/python-iptools-0.6.0-2.fc18.src.rpm Both koji and rpmlint were successful If possible, could you please take a look at my review requests here: https://bugzilla.redhat.com/show_bug.cgi?id=947492 Many warnings in this one. and https://bugzilla.redhat.com/show_bug.cgi?id=946856 (reviewed once and modified, still needs further feedback I guess ) Thanks, -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=oC0QSNH63Ya=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 928226] Review Request: libmwaw: import library for some old mac text documents
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=928226 Volker Fröhlich volke...@gmx.at changed: What|Removed |Added CC||volke...@gmx.at --- Comment #1 from Volker Fröhlich volke...@gmx.at --- I think the headers don't explicitly say GPLv2+ anywhere. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=cyXX2upzRHa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 949214] Review Request: python-iptools - A few useful functions and objects for manipulating ip addresses in python
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=949214 Orion Poplawski or...@cora.nwra.com changed: What|Removed |Added Flags||fedora-review? --- Comment #4 from Orion Poplawski or...@cora.nwra.com --- Surely that's not the entirety of your review? rpmlint and koji are just the tip of the iceberg... -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0n9lGXCr2ca=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 949302] New: Review Request:python-optcomplete - Shell Completion Self-Generator for Python
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=949302 Bug ID: 949302 Summary: Review Request:python-optcomplete - Shell Completion Self-Generator for Python Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: or...@cora.nwra.com QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Category: --- Spec URL: http://www.cora.nwra.com/~orion/fedora/python-optcomplete.spec SRPM URL: http://www.cora.nwra.com/~orion/fedora/python-optcomplete-1.2-0.1.20130406hg4416852.fc18.src.rpm Description: This Python module aims at providing almost automatically shell completion for any Python program that already uses the optparse module. Fedora Account System Username: orion -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=JjepJEIsh1a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 947492] Review Request: luakit - Extremely fast, lightweight and flexible web browser
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=947492 Orion Poplawski or...@cora.nwra.com changed: What|Removed |Added CC||or...@cora.nwra.com --- Comment #1 from Orion Poplawski or...@cora.nwra.com --- - These spelling errors can be ignored. - Are the files in /etc/xdg/luakit expected to modified to configure luakit? If so, they need to be marked: %config(noreplace) in %files. If not, they need to go elsewhere. - See rpmlint -I for more information on the errors and in particular how to fix the non-executable-script error. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=7UJjdM5nPJa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 879928] Review Request: rigsofrods - Vehicle simulator based on soft-body physics
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=879928 Bug 879928 depends on bug 805246, which changed state. Bug 805246 Summary: please update mygui to new version 3.2 https://bugzilla.redhat.com/show_bug.cgi?id=805246 What|Removed |Added Status|NEW |CLOSED Resolution|--- |NEXTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0Hf8JhEI5ra=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 929256] Review Request: nomacs - Qt-based image viewer
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=929256 --- Comment #7 from Eugene A. Pivnev ti.eug...@gmail.com --- (In reply to comment #6) * description - Some part of description is redundant and better to fix Fixed * SourceURL: - For sourceforge based tarball, please follow: Fixed * Compilar flags - Optimization level -O2 in %optflags are replaced by -O3, which is discouraged on Fedora: Please remove -O3 optimization level. Seems that it is %cmake macro feature/bug. Nomacs not set -Ox at all. Try to replace %cmake with cmake - no one -O3. * Updating mime infomation Fixed. In addition - version update. Spec URL: http://tieugene.fedorapeople.org/rpms/nomacs/nomacs.spec SRPM URL: http://tieugene.fedorapeople.org/rpms/nomacs/nomacs-1.0.2-1.fc17.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=zkuiBW6dVha=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 928226] Review Request: libmwaw: import library for some old mac text documents
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=928226 --- Comment #2 from David Tardon dtar...@redhat.com --- (In reply to comment #1) I think the headers don't explicitly say GPLv2+ anywhere. Anything LGPLv2+ is automatically GPLv2+, so I do not think this is a problem. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=LMBRtDtTq6a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 949311] New: Review Request: python-workerpool - Multithreaded job distribution module
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=949311 Bug ID: 949311 Summary: Review Request: python-workerpool - Multithreaded job distribution module Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: or...@cora.nwra.com QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Category: --- Spec URL: http://www.cora.nwra.com/~orion/fedora/python-workerpool.spec SRPM URL: http://www.cora.nwra.com/~orion/fedora/python-workerpool-0.9.2-1.fc18.src.rpm Description: The workerpool module is a simple framework for easily distributing jobs into multiple worker threads. Examples of usage can be found in the unit tests and the samples provided. This module facilitates distributing simple operations into jobs that are sent to worker threads, maintained by a pool object. It consists of these components: * Jobs - single units of work that need to be performed. * Workers - workers grab jobs from a queue and run them. * Worker pool - keeps track of workers and the job queue. Fedora Account System Username: orion -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=eBe79PJzsqa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 949317] New: Review Request: rubygem-serialport - Ruby library that provide class for RS232 serail port
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=949317 Bug ID: 949317 Summary: Review Request: rubygem-serialport - Ruby library that provide class for RS232 serail port Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: alejandro.perez.tor...@gmail.com QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Category: --- Spec URL: http://aeperezt.fedorapeople.org/rpmdev/rubygem-serialport.spec SRPM URL: http://aeperezt.fedorapeople.org/rpmdev/rubygem-serialport-1.1.0-1.fc19.src.rpm Description: Ruby SerialPort is a class for using RS232 serial ports. It also contains low-level function to check current state of signals on the line. Fedora Account System Username:aeperezt -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=xHogdj4VWba=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 929256] Review Request: nomacs - Qt-based image viewer
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=929256 --- Comment #8 from Kevin Kofler ke...@tigcc.ticalc.org --- %cmake sets the build type to Release by default, and unfortunately this defaults to -O3 -DNDEBUG in CMake. Most packages override this to vastly different defaults, but nomacs uses the CMake defaults. IMHO, we should really change the default in our CMake packaging from -O3 to -O2. Anyway, to fix this, add to your %cmake line: -DCMAKE_CXX_FLAGS_RELEASE:STRING=-O2 -DNDEBUG -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Yl7n5DrYO9a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 949317] Review Request: rubygem-serialport - Ruby library that provide class for RS232 serail port
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=949317 Alejandro_Perez alejandro.perez.tor...@gmail.com changed: What|Removed |Added Flags||needinfo? --- Comment #1 from Alejandro_Perez alejandro.perez.tor...@gmail.com --- rpmlint Output: rpmlint SPECS/rubygem-serialport.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint SRPMS/rubygem-serialport-1.1.0-1.fc19.src.rpm rubygem-serialport.src: W: strange-permission rubygem-serialport.spec 0600L 1 packages and 0 specfiles checked; 0 errors, 1 warnings. rpmlint RPMS/x86_64/rubygem-serialport-1.1.0-1.fc19.x86_64.rpm rubygem-serialport.x86_64: W: no-soname /usr/lib64/gems/ruby/serialport-1.1.0/lib/serialport.so 1 packages and 0 specfiles checked; 0 errors, 1 warnings. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=CLeiREBX9ba=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 892335] Review Request: AudioCuesheetEditor
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=892335
--- Comment #27 from Sven Baus s.bau...@gmx.net ---
SPEC:
https://sourceforge.net/p/audiocuesheet/code/255/tree/trunk/RPM%20Build/SPECS/AudioCuesheetEditor.spec
RPM:
https://sourceforge.net/p/audiocuesheet/code/255/tree/trunk/RPM%20Build/RPMS/x86_64/AudioCuesheetEditor-0.3.0-1.fc17.x86_64.rpm
SRPM:
https://sourceforge.net/p/audiocuesheet/code/255/tree/trunk/RPM%20Build/SRPMS/AudioCuesheetEditor-0.3.0-1.fc17.src.rpm
rpmlint output (only errors mentioned):
AudioCuesheetEditor.spec:25: E: hardcoded-library-path in
%{buildroot}/usr/lib/%{name}
Needed by mono guidelines
AudioCuesheetEditor.spec:28: E: hardcoded-library-path in
%{buildroot}/usr/lib/%{name}/resources
Needed by mono guidelines
AudioCuesheetEditor.spec:29: E: hardcoded-library-path in
%{buildroot}/usr/lib/%{name}/%{name}.exe
Needed by mono guidelines
AudioCuesheetEditor.spec:46: E: hardcoded-library-path in /usr/lib/%{name}/*
Needed by mono guidelines
AudioCuesheetEditor.x86_64: E: no-binary
Binary is included!
AudioCuesheetEditor.src:25: E: hardcoded-library-path in
%{buildroot}/usr/lib/%{name}
Needed by mono guidelines
AudioCuesheetEditor.src:28: E: hardcoded-library-path in
%{buildroot}/usr/lib/%{name}/resources
Needed by mono guidelines
AudioCuesheetEditor.src:29: E: hardcoded-library-path in
%{buildroot}/usr/lib/%{name}/%{name}.exe
Needed by mono guidelines
AudioCuesheetEditor.src:46: E: hardcoded-library-path in /usr/lib/%{name}/*
Needed by mono guidelines
2 packages and 1 specfiles checked; 9 errors, 12 warnings.
This is version 0.3.0. I really would thank anyone for getting this inside
fedora ;).
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=OSOrNPfQZ1a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 949319] New: Review Request: rubygem-icaro - Ruby Api for Icaro Robotic
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=949319 Bug ID: 949319 Summary: Review Request: rubygem-icaro - Ruby Api for Icaro Robotic Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: alejandro.perez.tor...@gmail.com QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Category: --- Spec URL: http://aeperezt.fedorapeople.org/rpmdev/rubygem-icaro.spec SRPM URL: http://aeperezt.fedorapeople.org/rpmdev/rubygem-icaro-1.0.5-1.fc19.src.rpm Description: Icaro Robot API for Ruby Fedora Account System Username:aeperezt -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=s9Km5i152Ga=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 949319] Review Request: rubygem-icaro - Ruby Api for Icaro Robotic
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=949319 Alejandro_Perez alejandro.perez.tor...@gmail.com changed: What|Removed |Added Flags||needinfo? --- Comment #1 from Alejandro_Perez alejandro.perez.tor...@gmail.com --- RPMLINT Output: rpmlint SPECS/rubygem-icaro.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint SRPMS/rubygem-icaro-1.0.5-1.fc19.src.rpm rubygem-icaro.src: W: strange-permission rubygem-icaro.spec 0600L rpmlint RPMS/noarch/rubygem-icaro-1.0.5-1.fc19.noarch.rpm rubygem-icaro.noarch: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 1 warnings. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=T4H8zw65SUa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 929256] Review Request: nomacs - Qt-based image viewer
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=929256 --- Comment #9 from Eugene A. Pivnev ti.eug...@gmail.com --- (In reply to comment #8) %cmake sets the build type to Release by default, Sorry, but: https://bugzilla.redhat.com/show_bug.cgi?id=919044#c31 :-) Anyway, to fix this, add to your %cmake line: -DCMAKE_CXX_FLAGS_RELEASE:STRING=-O2 -DNDEBUG Fixed. URLs not changed -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=gWoQqqH85La=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 929256] Review Request: nomacs - Qt-based image viewer
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=929256 --- Comment #10 from Kevin Kofler ke...@tigcc.ticalc.org --- You're right, it doesn't, and IIRC this very issue is why it doesn't. But that means the -DCMAKE_BUILD_TYPE=release you're adding is the culprit, not the %cmake macro. :-) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=k01hXzyEQQa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 893866] Review Request: vboot-utils - Chromium OS vboot utilities
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=893866
--- Comment #22 from Peter Robinson pbrobin...@gmail.com ---
Some initial feedback:
Because it's only ARM and x86 the ExcludeArch should be:
ExclusiveArch: %{ix86} x86_64 %{arm}
You also need to put as comments the exact commands used to generate the source
tar file and record either the tag or the git ID used for the build as per
these guidelines:
http://fedoraproject.org/wiki/Packaging:SourceURL#Using_Revision_Control
It also needs a %description field.
For patch lines I tend to do the following primarily for readability:
%patch0 -p0 -b .nostatic
%patch1 -p0 -b .fixprintf
Rest of the review in progress.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=jra1865ZlXa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 893866] Review Request: vboot-utils - Chromium OS vboot utilities
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=893866 Peter Robinson pbrobin...@gmail.com changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=zRblN0Wg0Ha=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 949324] New: Review Request: oath-toolkit - One-time password components
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=949324 Bug ID: 949324 Summary: Review Request: oath-toolkit - One-time password components Product: Fedora Version: rawhide Component: Package Review Severity: unspecified Priority: unspecified Assignee: nob...@fedoraproject.org Reporter: jskar...@redhat.com QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Category: --- Spec URL: http://fedorapeople.org/~jskarvad/oath-toolkit/oath-toolkit.spec SRPM URL: http://fedorapeople.org/~jskarvad/oath-toolkit/oath-toolkit-2.0.2-1.fc18.src.rpm Description: The OATH Toolkit provide components for building one-time password authentication systems. It contains shared libraries, command line tools and a PAM module. Supported technologies include the event-based HOTP algorithm (RFC4226) and the time-based TOTP algorithm (RFC6238). OATH stands for Open AuTHentication, which is the organization that specify the algorithms. For managing secret key files, the Portable Symmetric Key Container (PSKC) format described in RFC6030 is supported. Fedora Account System Username: jskarvad -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ZJwewnjSvna=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 893866] Review Request: vboot-utils - Chromium OS vboot utilities
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=893866 --- Comment #23 from Peter Robinson pbrobin...@gmail.com --- Drop: BuildRequires: glibc gcc As per http://fedoraproject.org/wiki/Packaging:Guidelines#BuildRequires Exceptions -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=CYDqDSc3xYa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 893866] Review Request: vboot-utils - Chromium OS vboot utilities
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=893866
--- Comment #24 from Peter Robinson pbrobin...@gmail.com ---
There's a few minor bits to be cleaned up but we're mostly there.
? rpmlint output:
The output below is mostly OK, there's a few things like spaces vs tabs need
cleanup.
rpmlint vboot-utils.spec ../SRPMS/vboot-utils-20130222gite6cf2c2-2.fc18.src.rpm
vboot-utils.spec:18: W: mixed-use-of-spaces-and-tabs (spaces: line 18, tab:
line 1)
vboot-utils.spec: W: invalid-url Source0: vboot-utils-20130222gite6cf2c2.tar.xz
vboot-utils.src: W: spelling-error %description -l en_US chromebook - chrome
book, chrome-book, chromosome
vboot-utils.src: W: spelling-error %description -l en_US gpt - got, gt, pt
vboot-utils.src:18: W: mixed-use-of-spaces-and-tabs (spaces: line 18, tab: line
1)
vboot-utils.src: W: invalid-url Source0: vboot-utils-20130222gite6cf2c2.tar.xz
1 packages and 1 specfiles checked; 0 errors, 6 warnings.
rpmlint vboot-utils-20130222gite6cf2c2-2.fc20.x86_64.rpm
vboot-utils.x86_64: W: spelling-error %description -l en_US chromebook -
chrome book, chrome-book, chromosome
vboot-utils.x86_64: W: spelling-error %description -l en_US gpt - got, gt, pt
vboot-utils.x86_64: W: no-manual-page-for-binary dump_kernel_config
vboot-utils.x86_64: W: no-manual-page-for-binary dev_make_keypair
vboot-utils.x86_64: W: no-manual-page-for-binary dev_debug_vboot
vboot-utils.x86_64: W: no-manual-page-for-binary bmpblk_font
vboot-utils.x86_64: W: no-manual-page-for-binary bmpblk_utility
vboot-utils.x86_64: W: no-manual-page-for-binary tpmc
vboot-utils.x86_64: W: no-manual-page-for-binary tpm_init_temp_fix
vboot-utils.x86_64: W: no-manual-page-for-binary enable_dev_usb_boot
vboot-utils.x86_64: W: no-manual-page-for-binary dumpRSAPublicKey
vboot-utils.x86_64: W: no-manual-page-for-binary vbutil_kernel
vboot-utils.x86_64: W: no-manual-page-for-binary futility
vboot-utils.x86_64: W: no-manual-page-for-binary vbutil_firmware
vboot-utils.x86_64: W: no-manual-page-for-binary eficompress
vboot-utils.x86_64: W: no-manual-page-for-binary pad_digest_utility
vboot-utils.x86_64: W: no-manual-page-for-binary signature_digest_utility
vboot-utils.x86_64: W: no-manual-page-for-binary vbutil_keyblock
vboot-utils.x86_64: W: no-manual-page-for-binary vbutil_key
vboot-utils.x86_64: W: no-manual-page-for-binary efidecompress
vboot-utils.x86_64: W: no-manual-page-for-binary vbutil_what_keys
vboot-utils.x86_64: W: no-manual-page-for-binary dev_sign_file
vboot-utils.x86_64: W: no-manual-page-for-binary dump_fmap
vboot-utils.x86_64: W: no-manual-page-for-binary gbb_utility
vboot-utils.x86_64: W: no-manual-page-for-binary load_kernel_test
vboot-utils.x86_64: W: no-manual-page-for-binary verify_data
vboot-utils.x86_64: W: no-manual-page-for-binary crossystem
vboot-utils.x86_64: W: no-manual-page-for-binary cgpt
1 packages and 0 specfiles checked; 0 errors, 28 warnings.
+ package name satisfies the packaging naming guidelines
+ specfile name matches the package base name
+ package should satisfy packaging guidelines
+ license meets guidelines and is acceptable to Fedora
+ license matches the actual package license
+ latest version packaged
+ %doc includes license file
+ spec file written in American English
+ spec file is legible
? upstream sources match sources in the srpm
+ package successfully builds on at least one architecture
tested using koji scratch build on both x86 and ARM
+ BuildRequires list all build dependencies
There's a few redundent extras
n/a %find_lang instead of %{_datadir}/locale/*
n/a binary RPM with shared library files must call ldconfig in %post and
%postun+ does not use Prefix: /usr
n/a package owns all directories it creates
n/a no duplicate files in %files
+ Package perserves timestamps on install
Permissions on files must be set properly
+ consistent use of macros
+ package must contain code or permissible content
n/a large documentation files should go in -doc subpackage
+ files marked %doc should not affect package runtime
n/a header files should be in -devel
n/a static libraries should be in -static
n/a packages containing pkgconfig (.pc) files need 'Requires: pkgconfig'
n/a libfoo.so must go in -devel
n/a devel must require the fully versioned base
+ packages should not contain libtool .la files
n/a packages containing GUI apps must include %{name}.desktop file
+ packages must not own files or directories owned by other packages
+ filenames must be valid UTF-8
Optional:
+ if there is no license file, packager should query upstream to include it
n/a translations of description and summary for non-English languages, if
available
+ reviewer should build the package in mock/koji
+ the package should build into binary RPMs on all supported architectures
n/a review should test the package functions as described
+ scriptlets should be sane
n/a non -devel packages should require fully versioned base
n/a pkgconfig files should go in -devel
+ shouldn't have file dependencies outside /etc /bin
[Bug 949324] Review Request: oath-toolkit - One-time password components
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=949324
--- Comment #1 from Jaroslav Škarvada jskar...@redhat.com ---
For PAM module to correctly work with sshd, we will probably need selinux label
(for oath users configuration/state file) and appropriate rules:
Apr 7 20:49:26 yarda kernel: [23820.679293] type=1400
audit(1365360566.085:24): avc: denied { write } for pid=24819 comm=sshd
name=lib dev=dm-1 ino=786434
scontext=system_u:system_r:sshd_t:s0-s0:c0.c1023
tcontext=system_u:object_r:var_lib_t:s0 tclass=dir
Apr 7 20:49:26 yarda kernel: [23820.698179] type=1400
audit(1365360566.085:25): avc: denied { add_name } for pid=24819 comm=sshd
name=users.oath.lock scontext=system_u:system_r:sshd_t:s0-s0:c0.c1023
tcontext=system_u:object_r:var_lib_t:s0 tclass=dir
Apr 7 20:49:26 yarda kernel: [23820.718090] type=1400
audit(1365360566.124:26): avc: denied { create } for pid=24819 comm=sshd
name=users.oath.lock scontext=system_u:system_r:sshd_t:s0-s0:c0.c1023
tcontext=system_u:object_r:var_lib_t:s0 tclass=file
Apr 7 20:49:26 yarda kernel: [23820.737756] type=1400
audit(1365360566.144:27): avc: denied { write open } for pid=24819
comm=sshd path=/var/lib/users.oath.lock dev=dm-1 ino=806912
scontext=system_u:system_r:sshd_t:s0-s0:c0.c1023
tcontext=system_u:object_r:var_lib_t:s0 tclass=file
Apr 7 20:49:26 yarda kernel: [23820.759772] type=1400
audit(1365360566.165:28): avc: denied { lock } for pid=24819 comm=sshd
path=/var/lib/users.oath.lock dev=dm-1 ino=806912
scontext=system_u:system_r:sshd_t:s0-s0:c0.c1023
tcontext=system_u:object_r:var_lib_t:s0 tclass=file
Apr 7 20:49:26 yarda kernel: [23820.783848] type=1400
audit(1365360566.190:29): avc: denied { getattr } for pid=24819 comm=sshd
path=/var/lib/users.oath.new dev=dm-1 ino=810364
scontext=system_u:system_r:sshd_t:s0-s0:c0.c1023
tcontext=system_u:object_r:var_lib_t:s0 tclass=file
Apr 7 20:49:26 yarda kernel: [23820.846464] type=1400
audit(1365360566.253:30): avc: denied { remove_name } for pid=24819
comm=sshd name=users.oath.new dev=dm-1 ino=810364
scontext=system_u:system_r:sshd_t:s0-s0:c0.c1023
tcontext=system_u:object_r:var_lib_t:s0 tclass=dir
Apr 7 20:49:26 yarda kernel: [23820.867964] type=1400
audit(1365360566.274:31): avc: denied { rename } for pid=24819 comm=sshd
name=users.oath.new dev=dm-1 ino=810364
scontext=system_u:system_r:sshd_t:s0-s0:c0.c1023
tcontext=system_u:object_r:var_lib_t:s0 tclass=file
Apr 7 20:49:26 yarda kernel: [23820.889180] type=1400
audit(1365360566.295:32): avc: denied { unlink } for pid=24819 comm=sshd
name=users.oath dev=dm-1 ino=272776
scontext=system_u:system_r:sshd_t:s0-s0:c0.c1023
tcontext=system_u:object_r:etc_t:s0 tclass=file
Apr 7 20:49:26 yarda kernel: [23820.909548] type=1400
audit(1365360566.316:33): avc: denied { unlink } for pid=24819 comm=sshd
name=users.oath.lock dev=dm-1 ino=806912
scontext=system_u:system_r:sshd_t:s0-s0:c0.c1023
tcontext=system_u:object_r:var_lib_t:s0 tclass=file
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=OYsg1fVoGza=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 949324] Review Request: oath-toolkit - One-time password components
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=949324 --- Comment #2 from Jaroslav Škarvada jskar...@redhat.com --- Configuration and state is stored in one file, it's name is configurable through PAM, in the example from comment 1, the /var/lib/users.oath was used. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=EIJjBNufNea=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 911229] Review Request: nodejs-vows - Asynchronous behaviour-driven development (BDD) and continuous integration
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=911229 --- Comment #5 from Jamie Nguyen jamieli...@fedoraproject.org --- Spec URL: http://jamielinux.fedorapeople.org/mocha/nodejs-vows.spec SRPM URL: http://jamielinux.fedorapeople.org/mocha/SRPMS/nodejs-vows-0.7.0-4.fc18.src.rpm * Sun Apr 07 2013 Jamie Nguyen jamieli...@fedoraproject.org - 0.7.0-4 - use node-glob instead of wildcard.js, which is bundled from unknown origins - add a more detailed %%description - add /usr/bin/vows - add custom man page I've also opened an FPC ticket: https://fedorahosted.org/fpc/ticket/272 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0YbPufiyYIa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 893866] Review Request: vboot-utils - Chromium OS vboot utilities
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=893866 --- Comment #25 from Jon Disnard jdisn...@gmail.com --- I have uploaded the required fixes. SPEC FILE http://dl.dropbox.com/u/41369/fedora/SPECS/vboot-utils.spec SRPM http://dl.dropbox.com/u/41369/fedora/SRPMS/vboot-utils-20130222gite6cf2c2-3.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=HqkDuyE6fWa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 949336] New: Review Request: rtl-sdr - SDR utilities for Realtek RTL2832 based DVB-T dongles
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=949336 Bug ID: 949336 Summary: Review Request: rtl-sdr - SDR utilities for Realtek RTL2832 based DVB-T dongles Product: Fedora Version: rawhide Component: Package Review Severity: unspecified Priority: unspecified Assignee: nob...@fedoraproject.org Reporter: jskar...@redhat.com QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Category: --- Spec URL: http://fedorapeople.org/~jskarvad/rtl-sdr/rtl-sdr.spec SRPM URL: http://fedorapeople.org/~jskarvad/rtl-sdr/rtl-sdr-0-0.1.20130403git4a068f56.fc18.src.rpm Description: This package can turn your RTL2832 based DVB-T dongle into a SDR receiver. Fedora Account System Username: jskarvad The rtl-sdr-0-lib64-fix.patch was sent upstream. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Fcrfx9Eoyqa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 948000] Review Request: gr-osmosdr - Common software API for various radio hardware
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=948000 Jaroslav Škarvada jskar...@redhat.com changed: What|Removed |Added Depends On||949336 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=EVa1obW8COa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 949336] Review Request: rtl-sdr - SDR utilities for Realtek RTL2832 based DVB-T dongles
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=949336 Jaroslav Škarvada jskar...@redhat.com changed: What|Removed |Added Blocks||948000 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=oVVW6ykHR4a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 947640] Review Request: snappy - An open-source Gnome media player
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=947640 Michael Scherer m...@zarb.org changed: What|Removed |Added CC||m...@zarb.org --- Comment #2 from Michael Scherer m...@zarb.org --- Hi, a few comment : - I personnally find that Requires and BuildRequires are more readable if there is one per line, especially since this is cleaner when reviewing diff. - Requires: gstreamer1,clutter,clutter-gtk,gstreamer1-plugins-base,clutter-gst,gtk3 gtk3, gstreamer1 and clutter are likely already pulled by rpm automated library dependency. And gstreamer1-plugins-base is likely pulled already. Can you clean the Requires from redundant rpm ? - why is autoreconf -i run in %build ? - as %post run /usr/bin/update-mime-database , shouldn't it requires shared-mime-info as Requires(post) ? ( but I am not sure, since there is '|| :', I guess that should be checked by someone else. - the same goes for /usr/bin/gtk-update-icon-cache ? ( especially since that's a software in gtk2 rpm ) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=anRRZSoqrba=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 949336] Review Request: rtl-sdr - SDR utilities for Realtek RTL2832 based DVB-T dongles
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=949336 Michael Scherer m...@zarb.org changed: What|Removed |Added CC||m...@zarb.org --- Comment #1 from Michael Scherer m...@zarb.org --- Hi, - can you add a comment to the spec, saying patch was sent upstream ? ( just for tracking purpose, even if I guess it will be included upstream ) - why is doxygen and graphviz needed, as the documentation is not in the rpm ? ( ie, shouldn't the doc end in some rpm ? ) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=jOjWYj5mVsa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 947155] Review Request: mingw-gstreamer1 - MinGW build of GStreamer1
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=947155 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=7muFknP3FXa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 947155] Review Request: mingw-gstreamer1 - MinGW build of GStreamer1
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=947155 --- Comment #7 from Fedora Update System upda...@fedoraproject.org --- mingw-gstreamer1-1.0.6-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/mingw-gstreamer1-1.0.6-1.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=B0tu1vkKwJa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 949336] Review Request: rtl-sdr - SDR utilities for Realtek RTL2832 based DVB-T dongles
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=949336
Michael Scherer m...@zarb.org changed:
What|Removed |Added
Assignee|nob...@fedoraproject.org|m...@zarb.org
Flags||fedora-review?
--- Comment #2 from Michael Scherer m...@zarb.org ---
Package Review
==
Key:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Errors
==
- License is wrong, since there is a bundle of getopt
- there is getopt in bundle
- -devel should pull main with %{_isa}
- patch being sent upstream should be documented in spec
- install should use -p ( if I am not wrong ), but that's minor
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
GPL (v2 or later) (with incorrect FSF address), LGPL (v2.1 or later)
(with incorrect FSF address), GPL (v2 or later), Unknown or
generated. 1 files have unknown license. Detailed output of licensecheck
in /home/misc/checkout/git/FedoraReview/949336-rtl-sdr/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /etc/udev, /etc/udev/rules.d
[x]: %build honors applicable compiler flags or justifies otherwise.
[!]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[!]: Fully versioned dependency in subpackages, if present.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rtl-sdr-
devel
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 30720 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Each %files section contains %defattr if rpm 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not
[Bug 893866] Review Request: vboot-utils - Chromium OS vboot utilities
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=893866 Peter Robinson pbrobin...@gmail.com changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #26 from Peter Robinson pbrobin...@gmail.com --- Looks good. APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=bO4ce8MHw0a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 949336] Review Request: rtl-sdr - SDR utilities for Realtek RTL2832 based DVB-T dongles
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=949336 --- Comment #3 from Jaroslav Škarvada jskar...@redhat.com --- (In reply to comment #1) - can you add a comment to the spec, saying patch was sent upstream ? ( just for tracking purpose, even if I guess it will be included upstream ) Added. - why is doxygen and graphviz needed, as the documentation is not in the rpm Leftover, it seems there is no docs supported, removed, thanks for the catch. Both fixed without release bump. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=YqkJwwjfyta=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 947640] Review Request: snappy - An open-source Gnome media player
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=947640 --- Comment #3 from Michael Scherer m...@zarb.org --- And it doesn't build in mock on rawhide : checking for x86_64-redhat-linux-gnu-pkg-config... /usr/bin/x86_64-redhat-linux-gnu-pkg-config checking pkg-config is at least version 0.9.0... yes checking for GST... yes checking for CLUTTER... yes checking for CLUTTER_GST... no configure: error: Package requirements (clutter-gst-2.0 = 1.5.5) were not met: No package 'clutter-gst-2.0' found Consider adjusting the PKG_CONFIG_PATH environment variable if you installed software in a non-standard prefix. Alternatively, you may set the environment variables CLUTTER_GST_CFLAGS and CLUTTER_GST_LIBS to avoid the need to call pkg-config. See the pkg-config man page for more details. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=kq6mKMlsLIa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 902024] Review Request: gdk-pixbuf-psd - GdkPixbuf loader for the PSD file format
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=902024 --- Comment #17 from Nicolas Chauvet (kwizart) kwiz...@gmail.com --- el6 doesn't have the necessary libraries to test easily. But I can confirm that using this library breaks a working system. When I was testing with this library installed, another application started crashing. It was unable to even load xpm icons with error like: -- (amule:19706): GdkPixbuf-WARNING **: Error loading XPM image loader: Le type d'images « xpm » n'est pas pris en charge (amule:19706): Gdk-CRITICAL **: IA__gdk_drawable_get_size: assertion `GDK_IS_DRAWABLE (drawable)' failed -- Uninstalling this library and using yum reinstall gdk-pixbuf2 solved the issue. Trying with a scratch build from koji to reproduce the exact binary (f17 x86_64). http://koji.fedoraproject.org/koji/taskinfo?taskID=5224057 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=KcWI6TqeqWa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 949336] Review Request: rtl-sdr - SDR utilities for Realtek RTL2832 based DVB-T dongles
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=949336
--- Comment #4 from Jaroslav Škarvada jskar...@redhat.com ---
(In reply to comment #2)
Thanks for the review.
- License is wrong, since there is a bundle of getopt
- there is getopt in bundle
It seems to be used only on win32, we would probably need to change the license
field to GPL, thus removed in %pre and the license should be OK now.
- -devel should pull main with %{_isa}
fixed
- patch being sent upstream should be documented in spec
fixed
- install should use -p ( if I am not wrong ), but that's minor
fixed
Spec URL: http://fedorapeople.org/~jskarvad/rtl-sdr/rtl-sdr.spec
SRPM URL:
http://fedorapeople.org/~jskarvad/rtl-sdr/rtl-sdr-0-0.2.20130403git4a068f56.fc18.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=HyERQXqpLua=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 949336] Review Request: rtl-sdr - SDR utilities for Realtek RTL2832 based DVB-T dongles
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=949336 --- Comment #5 from Jaroslav Škarvada jskar...@redhat.com --- (In reply to comment #4) (In reply to comment #2) Thanks for the review. - License is wrong, since there is a bundle of getopt - there is getopt in bundle It seems to be used only on win32, we would probably need to change the license field to GPL, thus removed in %pre and the license should be OK now. It was probably OK, but removed in %prep to be safe the code is not included. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=VWjLZP27wra=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 949324] Review Request: oath-toolkit - One-time password components
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=949324 Michael Scherer m...@zarb.org changed: What|Removed |Added CC||m...@zarb.org --- Comment #3 from Michael Scherer m...@zarb.org --- Wouldn't it be useful to pre-create a file with proper permission ( and so selinux label ), have it owned by the rpm and document it ? also, fedora-review complain that bundled(gnulib) is not provided -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=kYKdZXpT3Ra=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 949324] Review Request: oath-toolkit - One-time password components
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=949324 --- Comment #4 from Jaroslav Škarvada jskar...@redhat.com --- (In reply to comment #3) Wouldn't it be useful to pre-create a file with proper permission ( and so selinux label ), have it owned by the rpm and document it ? This probably wouldn't help now, we still need the selinux label and rules (which currently probably doesn't exist) - I will manage this with the selinux guys once the package gets through the review - it's only minor issue with one sub-functionality. Also the user can use the pam_oath module multiple times in his/her PAM stack with multiple configuration files, thus I probably wouldn't like to provide the default file, but we could provide the instructions how to setup this / label the files in the README file. also, fedora-review complain that bundled(gnulib) is not provided Fixed without release bump. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=zSmMzOmyGca=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 894954] Review Request: qcommandline - Command line parser for Qt programs
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=894954
--- Comment #4 from Dan Callaghan dcall...@redhat.com ---
Thanks Sergio! Sorry for not replying sooner, the last few weeks have been very
busy.
(In reply to comment #2)
[!]: Uses parallel make.
which I don't know what it means.
I think this one is just because I forgot %{?_smp_mflags} in the make
invocation. I will fix that when I import the package.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=MecaSdxGWUa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 894954] Review Request: qcommandline - Command line parser for Qt programs
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=894954 Dan Callaghan dcall...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #5 from Dan Callaghan dcall...@redhat.com --- New Package SCM Request === Package Name: qcommandline Short Description: Command line parser for Qt programs Owners: dcallagh Branches: el6 f18 f19 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=nkrDZxigGFa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 949336] Review Request: rtl-sdr - SDR utilities for Realtek RTL2832 based DVB-T dongles
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=949336 Michael Scherer m...@zarb.org changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #6 from Michael Scherer m...@zarb.org --- Well, for the comment on the patch, that's more to say how it was sent upstream :) bit that's not a blocking point of the review, nd the rest is good, so the package is approved. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Chqpr8G9Mwa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 949324] Review Request: oath-toolkit - One-time password components
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=949324 --- Comment #5 from Michael Scherer m...@zarb.org --- What about having a directory for holding the various files ? This would keep the rules clean ( ie, everything in this directory would be labelled as foo_t, and foot_t is usable by pam_oath ? ) And the point of having a default file is also to make sure the permission are correct (ie 600 ) and to be able to check that using rpm -V -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=e8I8eFewYma=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 926062] Review Request: qpdfview - Qt-based PDF viewer
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=926062 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2013-04-07 20:24:25 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=iTpbIlajzia=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 926062] Review Request: qpdfview - Qt-based PDF viewer
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=926062 --- Comment #14 from Fedora Update System upda...@fedoraproject.org --- qpdfview-0.4.1-1.fc17 has been pushed to the Fedora 17 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=29u2WIB7Jua=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 926062] Review Request: qpdfview - Qt-based PDF viewer
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=926062 --- Comment #15 from Fedora Update System upda...@fedoraproject.org --- qpdfview-0.4.1-1.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ycnOGYhbKga=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 858064] Review Request: mingw-qt5-qtdeclarative - Qt5 for Windows - QtDeclarative component
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=858064 Bug 858064 depends on bug 858068, which changed state. Bug 858068 Summary: Review Request: mingw-qt5-qtjsbackend - Qt5 for Windows - QtJsBackend component https://bugzilla.redhat.com/show_bug.cgi?id=858068 What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=56RI1gl36Ca=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 858068] Review Request: mingw-qt5-qtjsbackend - Qt5 for Windows - QtJsBackend component
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=858068 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |ERRATA Last Closed||2013-04-07 20:24:48 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=mMN9UmSDh8a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 858068] Review Request: mingw-qt5-qtjsbackend - Qt5 for Windows - QtJsBackend component
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=858068 --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- mingw-qt5-qtscript-5.0.1-1.fc18, mingw-qt5-qttools-5.0.1-1.fc18, mingw-qt5-qtbase-5.0.1-4.fc18, mingw-qt5-qtjsbackend-5.0.1-1.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=HuVt8bvRLOa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 858074] Review Request: mingw-qt5-qtquick1 - Qt5 for Windows - QtQuick1 component
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=858074 Bug 858074 depends on bug 858076, which changed state. Bug 858076 Summary: Review Request: mingw-qt5-qtscript - Qt5 for Windows - QtScript component https://bugzilla.redhat.com/show_bug.cgi?id=858076 What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=dv1dkEQBbca=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 858076] Review Request: mingw-qt5-qtscript - Qt5 for Windows - QtScript component
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=858076 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |ERRATA Last Closed||2013-04-07 20:24:59 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=FardQFuXyna=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 858076] Review Request: mingw-qt5-qtscript - Qt5 for Windows - QtScript component
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=858076 --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- mingw-qt5-qtscript-5.0.1-1.fc18, mingw-qt5-qttools-5.0.1-1.fc18, mingw-qt5-qtbase-5.0.1-4.fc18, mingw-qt5-qtjsbackend-5.0.1-1.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=X8FzkOJnjma=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 858080] Review Request: mingw-qt5-qttools - Qt5 for Windows - QtTools component
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=858080 --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- mingw-qt5-qtscript-5.0.1-1.fc18, mingw-qt5-qttools-5.0.1-1.fc18, mingw-qt5-qtbase-5.0.1-4.fc18, mingw-qt5-qtjsbackend-5.0.1-1.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=3XdZDAfQVLa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 858080] Review Request: mingw-qt5-qttools - Qt5 for Windows - QtTools component
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=858080 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |ERRATA Last Closed||2013-04-07 20:25:08 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=y4pbRTVXgMa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 858082] Review Request: mingw-qt5-qttranslations - Qt5 for Windows - QtTranslations component
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=858082 Bug 858082 depends on bug 858080, which changed state. Bug 858080 Summary: Review Request: mingw-qt5-qttools - Qt5 for Windows - QtTools component https://bugzilla.redhat.com/show_bug.cgi?id=858080 What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=mLOvOrToGIa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 906481] Review Request: erlang-cowboy - Small, fast, modular HTTP server written in Erlang
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=906481 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Resolution|RAWHIDE |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=YkMpRPqurFa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 906481] Review Request: erlang-cowboy - Small, fast, modular HTTP server written in Erlang
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=906481 --- Comment #13 from Fedora Update System upda...@fedoraproject.org --- erlang-cowboy-0.8.2-4.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=WWtly05yjqa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 949371] New: Review Request: StarCluster - Tool for managing computing clusters hosted on Amazon's EC2
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=949371 Bug ID: 949371 Summary: Review Request: StarCluster - Tool for managing computing clusters hosted on Amazon's EC2 Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: or...@cora.nwra.com QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Category: --- Spec URL: http://www.cora.nwra.com/~orion/fedora/StarCluster.spec SRPM URL: http://www.cora.nwra.com/~orion/fedora/StarCluster-0.93.3-1.fc18.src.rpm Description: StarCluster is an open source cluster-computing toolkit for Amazon’s Elastic Compute Cloud (EC2) released under the LGPL license. StarCluster has been designed to automate and simplify the process of building, configuring, and managing clusters of virtual machines on Amazon’s EC2 cloud. StarCluster allows anyone to easily create a cluster computing environment in the cloud suited for distributed and parallel computing applications and systems. Fedora Account System Username: orion -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=DdoqexM26fa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 949214] Review Request: python-iptools - A few useful functions and objects for manipulating ip addresses in python
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=949214 Orion Poplawski or...@cora.nwra.com changed: What|Removed |Added Blocks||949371 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=JCrN04rE2wa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 949371] Review Request: StarCluster - Tool for managing computing clusters hosted on Amazon's EC2
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=949371 Orion Poplawski or...@cora.nwra.com changed: What|Removed |Added Depends On||949214, 949302, 949311 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=qOrZn2EUpMa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 949302] Review Request:python-optcomplete - Shell Completion Self-Generator for Python
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=949302 Orion Poplawski or...@cora.nwra.com changed: What|Removed |Added Blocks||949371 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=XT2mTdwWtsa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 949311] Review Request: python-workerpool - Multithreaded job distribution module
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=949311 Orion Poplawski or...@cora.nwra.com changed: What|Removed |Added Blocks||949371 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ERZmoAJOD3a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 888301] Review Request: orthanc - RESTful DICOM server for healthcare and medical research
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=888301 --- Comment #34 from Sebastien Jodogne s.jodo...@gmail.com --- Dear Mario and Peter, Thank you much for your help! The Orthanc package is now available in the repositories: http://koji.fedoraproject.org/koji/packageinfo?packageID=15874 I will now focus on EPEL. Cheers, Sébastien- -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=VL5jCzGYzVa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 888301] Review Request: orthanc - RESTful DICOM server for healthcare and medical research
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=888301 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=opdWgXRicTa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 888301] Review Request: orthanc - RESTful DICOM server for healthcare and medical research
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=888301 --- Comment #35 from Fedora Update System upda...@fedoraproject.org --- orthanc-0.5.0-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/orthanc-0.5.0-1.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8ABY5IHbZta=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 888301] Review Request: orthanc - RESTful DICOM server for healthcare and medical research
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=888301 --- Comment #36 from Fedora Update System upda...@fedoraproject.org --- orthanc-0.5.0-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/orthanc-0.5.0-1.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=azvnNafcZZa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
