[Bug 1372064] Review Request: lulzbot-marlin-firmware - Marlin firmware files for the Lulzbot family of 3D printers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372064



--- Comment #14 from Fedora Update System  ---
cura-lulzbot-20.03-2.fc23, lulzbot-marlin-firmware-20.03-2.fc23 has been pushed
to the Fedora 23 stable repository. If problems still persist, please make note
of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1342063] Review Request: python-mongoquery - A python implementation of mongodb queries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1342063



--- Comment #17 from Fedora Update System  ---
python-mongoquery-1.1.0-1.fc23 has been pushed to the Fedora 23 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378341] Review Request: fedpkg-copr - copr dist-git client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378341

Neal Gompa  changed:

   What|Removed |Added

 CC||ngomp...@gmail.com
   Assignee|nob...@fedoraproject.org|ngomp...@gmail.com
  Flags||fedora-review?



--- Comment #1 from Neal Gompa  ---
Taking this review

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1202064] Review Request: knock - A port-knocking server/client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1202064

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed|2016-09-07 04:18:19 |2016-09-22 20:24:17



--- Comment #25 from Fedora Update System  ---
knock-0.7.8-1.20151227git258a27e.fc24 has been pushed to the Fedora 24 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1342063] Review Request: python-mongoquery - A python implementation of mongodb queries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1342063



--- Comment #16 from Fedora Update System  ---
python-mongoquery-1.1.0-1.fc24 has been pushed to the Fedora 24 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375744] Review Request: gasnet - A Portable High-Performance Communication Layer for GAS Languages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375744

gil cattaneo  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



--- Comment #6 from gil cattaneo  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- All build dependencies are listed in BuildRequires, except for any that
  are listed in the exceptions section of Packaging Guidelines.
  Note: These BR are not needed: gcc-c++
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2
 IGNORE

= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "BSD (3 clause)", "Unknown or generated".
 370 files have unknown license. Detailed output of licensecheck in
 /home/gil/1375744-gasnet/licensecheck.txt
[?]: License file installed when any subpackage combination is installed.
[x]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by: /usr/lib/valgrind(valgrind-
 devel, valgrind-openmpi, valgrind)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 317440 bytes in 7 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Perl:
[?]: Package contains the mandatory BuildRequires and Requires:.
 Note: Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`";
 echo $version)) missing?

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the 

[Bug 1290337] Review Request: ed25519-java - Implementation of EdDSA ( Ed25519) in Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1290337

Christoph Junghans  changed:

   What|Removed |Added

 CC||jungh...@votca.org
   Assignee|nob...@fedoraproject.org|jungh...@votca.org
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375744] Review Request: gasnet - A Portable High-Performance Communication Layer for GAS Languages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375744



--- Comment #5 from Christoph Junghans  ---
Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=15755514

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375744] Review Request: gasnet - A Portable High-Performance Communication Layer for GAS Languages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375744



--- Comment #4 from Christoph Junghans  ---
(In reply to gil cattaneo from comment #1)
> can you take this https://bugzilla.redhat.com/show_bug.cgi?id=1290337 for me?
Java is not my expertise, but I try.

(In reply to gil cattaneo from comment #2)
> Build fails, seem missing a BRs:
> + popd
> + pushd mpich
> + '%{_mpich_load}'
> /var/tmp/rpm-tmp.RY5bU3: line 106: fg: no job control
> errore: Stato d'uscita errato da /var/tmp/rpm-tmp.RY5bU3 (%build)
> Stato d'uscita errato da /var/tmp/rpm-tmp.RY5bU3 (%build)
> Child return code was: 1
> EXCEPTION: [Error()]
Fixed

(In reply to gil cattaneo from comment #3)
> and before continue, please use for "Requires" this sintax "%{?_isa} =
> %{version}-%{release}"
Fixed

Spec URL:
https://raw.githubusercontent.com/junghans/fedora-review/master/gasnet/gasnet.spec
SRPM URL:
https://github.com/junghans/fedora-review/raw/master/gasnet/gasnet-1.26.4-2.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1256502] Review Request: python-getdns - python bindings for getdns

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1256502



--- Comment #3 from Paul Wouters  ---
I'm upgrading the core getdns packages to 1.0.0b2, and then will revisit these
bindings in a few days.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375744] Review Request: gasnet - A Portable High-Performance Communication Layer for GAS Languages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375744



--- Comment #3 from gil cattaneo  ---
and before continue, please use for "Requires" this sintax "%{?_isa} =
%{version}-%{release}"

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375744] Review Request: gasnet - A Portable High-Performance Communication Layer for GAS Languages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375744



--- Comment #2 from gil cattaneo  ---
Build fails, seem missing a BRs:
+ popd
+ pushd mpich
+ '%{_mpich_load}'
/var/tmp/rpm-tmp.RY5bU3: line 106: fg: no job control
errore: Stato d'uscita errato da /var/tmp/rpm-tmp.RY5bU3 (%build)
Stato d'uscita errato da /var/tmp/rpm-tmp.RY5bU3 (%build)
Child return code was: 1
EXCEPTION: [Error()]

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376436] Review Request: bitstream - Simpler access to binary structures such as specified by MPEG , DVB, IETF

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376436



--- Comment #6 from gil cattaneo  ---
(In reply to gil cattaneo from comment #4)

> [!]: Development files must be in a -devel package
>  Maybe should be change "Provides:   %{name}-devel =
> %{version}-%{release}" in "Provides:   %{name} = %{version}-%{release}" ?

as example see:
http://pkgs.fedoraproject.org/cgit/rpms/cereal.git/tree/cereal.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375744] Review Request: gasnet - A Portable High-Performance Communication Layer for GAS Languages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375744

gil cattaneo  changed:

   What|Removed |Added

 CC||punto...@libero.it
   Assignee|nob...@fedoraproject.org|punto...@libero.it
  Flags||fedora-review?



--- Comment #1 from gil cattaneo  ---
can you take this https://bugzilla.redhat.com/show_bug.cgi?id=1290337 for me?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1356657] Review Request: lxqt-wallet - Create a kwallet like functionality for LXQt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1356657

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed|2016-08-15 17:26:42 |2016-09-22 14:49:46



--- Comment #24 from Fedora Update System  ---
lxqt-wallet-3.0.0-1.el7, zulucrypt-5.0.0-3.20160802git064e9db.el7 has been
pushed to the Fedora EPEL 7 stable repository. If problems still persist,
please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1356739] Review Request: zulucrypt - Qt GUI front end to cryptsetup

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1356739

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed|2016-08-15 17:26:54 |2016-09-22 14:50:00



--- Comment #38 from Fedora Update System  ---
lxqt-wallet-3.0.0-1.el7, zulucrypt-5.0.0-3.20160802git064e9db.el7 has been
pushed to the Fedora EPEL 7 stable repository. If problems still persist,
please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1356739] Review Request: zulucrypt - Qt GUI front end to cryptsetup

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1356739
Bug 1356739 depends on bug 1356657, which changed state.

Bug 1356657 Summary: Review Request: lxqt-wallet - Create a kwallet like 
functionality for LXQt
https://bugzilla.redhat.com/show_bug.cgi?id=1356657

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1350143] Review Request: fmt - Small, safe and fast formating library for C++

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1350143



--- Comment #34 from Fedora Update System  ---
fmt-3.0.0-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376899] Review Request: pcaudiolib - Portable C Audio Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376899



--- Comment #5 from Ondřej Lysoněk  ---
Absolutely, I simply forgot about this.

Spec URL: http://www.fi.muni.cz/~xlysonek/pcaudiolib.spec
SRPM URL: http://www.fi.muni.cz/~xlysonek/pcaudiolib-1.0-3.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376900] Review Request: espeak-ng - eSpeak NG Text-to-Speech

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376900



--- Comment #6 from Petr Menšík  ---
In the meantime please change %{name} in %package devel Requires to
%{name}%{_isa}.
Also add BuildArch: noarch into %package vim and doc.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1360482] Review Request: nextcloud - a private, secure way to share and access files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1360482

Nick Bebout  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW
   Assignee|n...@fedoraproject.org|nob...@fedoraproject.org
  Flags|needinfo?(nb@fedoraproject. |
   |org)|



--- Comment #10 from Nick Bebout  ---
I'm going to unassign this.  Not sure that I could get this done in a timely
manner.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 977116] Review Request: pgmodeler - PostgreSQL Database Modeler

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=977116



--- Comment #55 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/pgmodeler

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376899] Review Request: pcaudiolib - Portable C Audio Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376899



--- Comment #4 from Petr Menšík  ---
Good, thank you. One last thing, devel subpackage should require also
architecture, it should be:
Requires: %{name}%{?_isa} = %{version}-%{release}

But it is not mandatory. Will you change it too, please?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1373486] Review Request: python34 - Version 3.4 of the Python programming language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373486



--- Comment #7 from Miro Hrončok  ---
This is because those directories aren't owned by any package this can require.
It's fine and intentional.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378526] New: Review Request: gap-pkg-hapcryst - Integral cohomology computations of Bieberbach groups

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378526

Bug ID: 1378526
   Summary: Review Request: gap-pkg-hapcryst - Integral cohomology
computations of Bieberbach groups
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: loganje...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://jjames.fedorapeople.org/gap-pkg-hapcryst/gap-pkg-hapcryst.spec
SRPM URL:
https://jjames.fedorapeople.org/gap-pkg-hapcryst/gap-pkg-hapcryst-0.1.11-1.fc26.src.rpm
Fedora Account System Username: jjames
Description:
This package is an add-on for Graham Ellis' HAP package.  HAPcryst
implements some functions for crystallographic groups (namely
OrbitStabilizer-type methods).  It is also capable of calculating free
resolutions for Bieberbach groups.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376900] Review Request: espeak-ng - eSpeak NG Text-to-Speech

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376900



--- Comment #5 from Ondřej Lysoněk  ---
Thank you! I'll wait for the promised espeak-ng 1.49.1 release.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376899] Review Request: pcaudiolib - Portable C Audio Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376899



--- Comment #3 from Ondřej Lysoněk  ---
Done, thanks!

Spec URL: http://www.fi.muni.cz/~xlysonek/pcaudiolib.spec
SRPM URL: http://www.fi.muni.cz/~xlysonek/pcaudiolib-1.0-2.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1373218] Review Request: zstd - Zstd compression library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373218



--- Comment #5 from Pádraig Brady  ---
The dreaded ping

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1373486] Review Request: python34 - Version 3.4 of the Python programming language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373486



--- Comment #6 from Charalampos Stratakis  ---
It seems there is a (minor?) conflict. Same issue also appears at python35.

By invoking 'rpm -ql python34' you get the list of files and dirs owned by the
rpm and these directories are shared among system-python-libs, sssd-common and
python34 on a Fedora 24 system:

/usr/share/systemtap
/usr/share/systemtap/tapset

Relevant part of the SPEC:

https://github.com/fedora-python/python34/blob/master/python34.spec#L1145

Should these dirs be removed from the SPEC?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 977116] Review Request: pgmodeler - PostgreSQL Database Modeler

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=977116



--- Comment #54 from Pavel Alexeev  ---
Thank you very much Sandro.

Could I review something for you?

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378021] Review Request: jetty-alpn - Jetty implementation of ALPN API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378021

gil cattaneo  changed:

   What|Removed |Added

 Blocks|652183 (FE-JAVASIG) |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=652183
[Bug 652183] Java SIG tracker bug
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378014] Review Request: perl-IO-FDPass - Pass a file descriptor over a socket

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378014



--- Comment #5 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/perl-IO-FDPass

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378014] Review Request: perl-IO-FDPass - Pass a file descriptor over a socket

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378014



--- Comment #4 from Paul Howarth  ---
(In reply to Petr Pisar from comment #3)
> (In reply to Paul Howarth from comment #2)
> > (In reply to Petr Pisar from comment #1)
> > > TODO: I believe the `coreutils' build-time dependency is not needed as the
> > > spec file does not call "make dist".
> > 
> > It's needed for %{_fixperms} though.
> > 
> I think it's responsibility of the package that defines the macro
> (rpm-build?).

There are probably a lot of macros defined there, some possibly for quite
esoteric situations. I think at best it would warrant a Recommends: or even a
Suggests: there for things it refers to in macro definitions.

To be honest I don't see coreutils ever disappearing from the minimal buildroot
but I'd rather not make it a special case, and specify a buildreq for
everything I explicitly use in a spec file.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378014] Review Request: perl-IO-FDPass - Pass a file descriptor over a socket

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378014



--- Comment #3 from Petr Pisar  ---
(In reply to Paul Howarth from comment #2)
> (In reply to Petr Pisar from comment #1)
> > TODO: I believe the `coreutils' build-time dependency is not needed as the
> > spec file does not call "make dist".
> 
> It's needed for %{_fixperms} though.
> 
I think it's responsibility of the package that defines the macro (rpm-build?).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378021] Review Request: jetty-alpn - Jetty implementation of ALPN API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378021



--- Comment #5 from gil cattaneo  ---
Issues:
[!]: Package contains no bundled libraries without FPC exception.
 See maven-shade-plugin and maven-bundle-plugin tasks

[!]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.

[!]: Package does not include license text files separate from upstream.

jetty-alpn.noarch: E: incorrect-fsf-address
/usr/share/licenses/jetty-alpn/gplv2+ce.html
jetty-alpn-javadoc.noarch: E: incorrect-fsf-address
/usr/share/licenses/jetty-alpn-javadoc/gplv2+ce.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378021] Review Request: jetty-alpn - Jetty implementation of ALPN API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378021

gil cattaneo  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378021] Review Request: jetty-alpn - Jetty implementation of ALPN API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378021



--- Comment #4 from gil cattaneo  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "EPL-1.0", "GPL (v2)", "Unknown or generated". 4 files have
 unknown license. Detailed output of licensecheck in /home/gil/1378021
 -jetty-alpn/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[!]: Package contains no bundled libraries without FPC exception.
 See maven-shade-plugin and maven-bundle-plugin tasks
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Java:
[x]: Bundled jar/class files should be removed before build
[x]: Packages have proper BuildRequires/Requires on jpackage-utils
 Note: Maven packages do not need to (Build)Require jpackage-utils. It
 is pulled in by maven-local
[x]: Javadoc documentation files are generated and included in -javadoc
 subpackage
[x]: Javadoc subpackages should not have Requires: jpackage-utils
[x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)

Maven:
[x]: If package contains pom.xml files install it (including metadata) even
 when building with ant
[x]: POM files have correct Maven mapping
[x]: Maven packages should use new style packaging
[x]: Old add_to_maven_depmap macro is not being used
[x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage-
 utils for %update_maven_depmap macro
[x]: Package DOES NOT use %update_maven_depmap in %post/%postun
[x]: Packages use .mfiles file list instead of %{_datadir}/maven2/poms

= SHOULD items =

Generic:
[!]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = 

[Bug 1378014] Review Request: perl-IO-FDPass - Pass a file descriptor over a socket

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378014



--- Comment #2 from Paul Howarth  ---
(In reply to Petr Pisar from comment #1)
> TODO: I believe the `coreutils' build-time dependency is not needed as the
> spec file does not call "make dist".

It's needed for %{_fixperms} though.

> TODO: Close standard input to the "perl Makefile.PL" command in order not to
> wait for interactive confirmation.

I'll avoid the interactive prompt by setting PERL_CANARY_STABILITY_NOPROMPT=1

> $ rpmlint perl-IO-FDPass.spec ../SRPMS/perl-IO-FDPass-1.1-2.fc26.src.rpm
> ../RPMS/x86_64/perl-IO-FDPass-*
> perl-IO-FDPass.src: W: spelling-error %description -l en_US unix -> UNIX,
> Unix, uni
> perl-IO-FDPass.x86_64: W: spelling-error %description -l en_US unix -> UNIX,
> Unix, uni
> 3 packages and 1 specfiles checked; 0 errors, 2 warnings.
> TODO: Upper-case the "unix" word in the description text.

Will do.

> Resolution: Package APPROVED.

Thanks for the review Petr.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378445] Review Request: kf5-kirigami - QtQuick plugins to build user interfaces based on the KDE UX guidelines

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378445

Fl@sh  changed:

   What|Removed |Added

 CC||alex.mail.1...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378077] Review Request: jetty-test-helper - Jetty toolchain test helper

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378077

gil cattaneo  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #5 from gil cattaneo  ---
Approved

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369534] Review Request: libsass - C/ C++ port of the Sass CSS precompiler

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369534



--- Comment #6 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/libsass

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376869] Review Request: gap-pkg-lpres - Nilpotent quotients of L-presented groups

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376869



--- Comment #3 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/gap-pkg-lpres

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1373486] Review Request: python34 - Version 3.4 of the Python programming language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373486



--- Comment #5 from Miro Hrončok  ---
Spec URL: https://github.com/fedora-python/python34/raw/master/python34.spec
SRPM URL:
https://churchyard.fedorapeople.org/SRPMS/python34-3.4.5-1.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378445] Review Request: kf5-kirigami - QtQuick plugins to build user interfaces based on the KDE UX guidelines

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378445

Rex Dieter  changed:

   What|Removed |Added

 Blocks||656997 (kde-reviews)
  Alias||kf5-kirigami



--- Comment #1 from Rex Dieter  ---
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=15750229

# rpmlint
kf5-kirigami.x86_64: W: no-documentation
kf5-kirigami-devel.x86_64: W: only-non-binary-in-usr-lib
kf5-kirigami-devel.x86_64: W: no-documentation
2 packages and 0 specfiles checked; 0 errors, 4 warnings.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=656997
[Bug 656997] kde-related package review tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378014] Review Request: perl-IO-FDPass - Pass a file descriptor over a socket

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378014

Petr Pisar  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Petr Pisar  ---
URL and Source0 addresses are usable. Ok.
Source archive is original (SHA-256:
ff3642dfd8e9cf2b4196c273cffbb2ccd5b55287e671ec6dd6083e8084546b10). Ok.
Summary verified from FDPass.pm. Ok.
Description verified from FDPass.pm. Ok.
License verified from COPYING. Ok.

TODO: I believe the `coreutils' build-time dependency is not needed as the spec
file does not call "make dist".

TODO: Close standard input to the "perl Makefile.PL" command in order not to
wait for interactive confirmation.

All tests pass. Ok.

$ rpmlint perl-IO-FDPass.spec ../SRPMS/perl-IO-FDPass-1.1-2.fc26.src.rpm
../RPMS/x86_64/perl-IO-FDPass-*
perl-IO-FDPass.src: W: spelling-error %description -l en_US unix -> UNIX, Unix,
uni
perl-IO-FDPass.x86_64: W: spelling-error %description -l en_US unix -> UNIX,
Unix, uni
3 packages and 1 specfiles checked; 0 errors, 2 warnings.
TODO: Upper-case the "unix" word in the description text.

$ rpm -q -lv -p ../RPMS/x86_64/perl-IO-FDPass-1.1-2.fc26.x86_64.rpm
drwxr-xr-x2 rootroot0 Sep 22 14:22
/usr/lib64/perl5/vendor_perl/IO
-rw-r--r--1 rootroot 4486 Jul  6  2015
/usr/lib64/perl5/vendor_perl/IO/FDPass.pm
drwxr-xr-x2 rootroot0 Sep 22 14:22
/usr/lib64/perl5/vendor_perl/auto/IO
drwxr-xr-x2 rootroot0 Sep 22 14:22
/usr/lib64/perl5/vendor_perl/auto/IO/FDPass
-rwxr-xr-x1 rootroot11240 Sep 22 14:22
/usr/lib64/perl5/vendor_perl/auto/IO/FDPass/FDPass.so
drwxr-xr-x2 rootroot0 Sep 22 14:22
/usr/share/doc/perl-IO-FDPass
-rw-r--r--1 rootroot  806 Jul  6  2015
/usr/share/doc/perl-IO-FDPass/Changes
-rw-r--r--1 rootroot 4630 Jul  6  2015
/usr/share/doc/perl-IO-FDPass/README
drwxr-xr-x2 rootroot0 Sep 22 14:22
/usr/share/licenses/perl-IO-FDPass
-rw-r--r--1 rootroot   62 Mar 29  2013
/usr/share/licenses/perl-IO-FDPass/COPYING
-rw-r--r--1 rootroot 3068 Sep 22 14:22
/usr/share/man/man3/IO::FDPass.3pm.gz
File layout and permissions are Ok.

$ rpm -q --requires -p ../RPMS/x86_64/perl-IO-FDPass-1.1-2.fc26.x86_64.rpm |
sort -f | uniq -c
  1 libc.so.6()(64bit)
  1 libc.so.6(GLIBC_2.2.5)(64bit)
  1 libc.so.6(GLIBC_2.4)(64bit)
  1 libperl.so.5.24()(64bit)
  1 perl(:MODULE_COMPAT_5.24.0)
  1 perl(XSLoader)
  1 rpmlib(CompressedFileNames) <= 3.0.4-1
  1 rpmlib(FileDigests) <= 4.6.0-1
  1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
  1 rpmlib(PayloadIsXz) <= 5.2-1
  1 rtld(GNU_HASH)
Binary requires are Ok.

$ rpm -q --provides -p ../RPMS/x86_64/perl-IO-FDPass-1.1-2.fc26.x86_64.rpm |
sort -f | uniq -c
  1 perl(IO::FDPass) = 1.1
  1 perl-IO-FDPass = 1.1-2.fc26
  1 perl-IO-FDPass(x86-64) = 1.1-2.fc26
Binary provides are Ok.

$ resolvedeps rawhide ../RPMS/x86_64/perl-IO-FDPass-1.1-2.fc26.x86_64.rpm 
Binary dependencies resolvable. Ok.

Package builds in F26
(http://koji.fedoraproject.org/koji/taskinfo?taskID=15750001). Ok.

Package is in line with Fedora and Perl packaging guidelines.

Please consider fixing `TODO' items before building this package.
Resolution: Package APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378445] New: Review Request: kf5-kirigami - QtQuick plugins to build user interfaces based on the KDE UX guidelines

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378445

Bug ID: 1378445
   Summary: Review Request: kf5-kirigami -  QtQuick plugins to
build user interfaces based on the KDE UX guidelines
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: rdie...@math.unl.edu
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://rdieter.fedorapeople.org/rpms/kf5/kf5-kirigami.spec
SRPM URL:
https://rdieter.fedorapeople.org/rpms/kf5/kf5-kirigami-1.0.2-1.fc24.src.rpm
Description: QtQuick plugins to build user interfaces based on the KDE UX
guidelines
Fedora Account System Username: rdieter

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1377733] Review Request: systemd-bootchart - Boot performance graphing tool

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1377733



--- Comment #8 from Zbigniew Jędrzejewski-Szmek  ---
http://pkgs.fedoraproject.org/cgit/rpms/systemd.git/commit/?h=f25=3250f0057369e1d9f3f1a499e9ad66e143ecb927

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1377733] Review Request: systemd-bootchart - Boot performance graphing tool

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1377733



--- Comment #7 from Zbigniew Jędrzejewski-Szmek  ---
Sorry, yet another request:
Please add Obsoletes: systemd < 231, so that this package is automatically
installed when upgrading both packages.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378014] Review Request: perl-IO-FDPass - Pass a file descriptor over a socket

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378014

Petr Pisar  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||ppi...@redhat.com
   Assignee|nob...@fedoraproject.org|ppi...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1374957] Review Request: python-colorspacious - Perform colorspace conversions accurately and easily

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1374957



--- Comment #1 from Dominik 'Rathann' Mierzejewski  ---
Spec URL:
https://rathann.fedorapeople.org/review/python-colorspacious/python-colorspacious.spec
SRPM URL:
https://rathann.fedorapeople.org/review/python-colorspacious/python-colorspacious-1.0.0-3.fc24.src.rpm

* Thu Sep 22 2016 Dominik Mierzejewski  1.0.0-3
- use a simpler patch (by QuLogic)
- add missing build dependency for building HTML docs

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1370451] Review Request: nodejs-grunt-contrib-copy - Copy files and folders

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1370451

Matthias Runge  changed:

   What|Removed |Added

 Blocks||1376389




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1376389
[Bug 1376389] Tracker for grafana dependencies
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378417] Review Request: nodejs-grunt-postcss - Apply several post-processors to your CSS using PostCSS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378417

Matthias Runge  changed:

   What|Removed |Added

 Blocks||956806 (nodejs-reviews)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=956806
[Bug 956806] Node.js Review Tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378423] Review Request: nodejs-grunt-contrib-compress - Compress files and folders

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378423

Matthias Runge  changed:

   What|Removed |Added

 Blocks||1376389




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1376389
[Bug 1376389] Tracker for grafana dependencies
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378423] New: Review Request: nodejs-grunt-contrib-compress - Compress files and folders

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378423

Bug ID: 1378423
   Summary: Review Request: nodejs-grunt-contrib-compress -
Compress files and folders
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: mru...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
http://www.matthias-runge.de/fedora/nodejs-grunt-contrib-compress.spec
SRPM URL:
http://www.matthias-runge.de/fedora/nodejs-grunt-contrib-compress-1.3.0-1.fc26.src.rpm
Description: Compress files and folders.
Fedora Account System Username: mrunge

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378420] Review Request: nodejs-autoprefixer - Parse CSS and add vendor prefixes to rules by Can I Use

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378420

Matthias Runge  changed:

   What|Removed |Added

 Blocks||1376389




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1376389
[Bug 1376389] Tracker for grafana dependencies
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378420] New: Review Request: nodejs-autoprefixer - Parse CSS and add vendor prefixes to rules by Can I Use

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378420

Bug ID: 1378420
   Summary: Review Request: nodejs-autoprefixer - Parse CSS and
add vendor prefixes to rules by Can I Use
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: mru...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: http://www.matthias-runge.de/fedora/nodejs-autoprefixer.spec
SRPM URL:
http://www.matthias-runge.de/fedora/nodejs-autoprefixer-6.4.1-1.fc26.src.rpm
Description: Parse CSS and add vendor prefixes to rules by Can I Use.
Fedora Account System Username: mrunge

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378416] Review Request: nodejs-postcss - Transforming styles with JS plugins

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378416

Matthias Runge  changed:

   What|Removed |Added

 Depends On||1378417




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1378417
[Bug 1378417] Review Request: nodejs-grunt-postcss - Apply several
post-processors to your CSS using PostCSS
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378417] Review Request: nodejs-grunt-postcss - Apply several post-processors to your CSS using PostCSS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378417

Matthias Runge  changed:

   What|Removed |Added

 Blocks||1376389, 1378416




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1376389
[Bug 1376389] Tracker for grafana dependencies
https://bugzilla.redhat.com/show_bug.cgi?id=1378416
[Bug 1378416] Review Request: nodejs-postcss - Transforming styles with JS
plugins
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378417] New: Review Request: nodejs-grunt-postcss - Apply several post-processors to your CSS using PostCSS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378417

Bug ID: 1378417
   Summary: Review Request: nodejs-grunt-postcss - Apply several
post-processors to your CSS using PostCSS
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: mru...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: http://www.matthias-runge.de/fedora/nodejs-grunt-postcss.spec
SRPM URL:
http://www.matthias-runge.de/fedora/nodejs-grunt-postcss-0.8.0-1.fc26.src.rpm
Description: Apply several post-processors to your CSS using PostCSS
Fedora Account System Username: mrunge

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378416] Review Request: nodejs-postcss - Transforming styles with JS plugins

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378416

Matthias Runge  changed:

   What|Removed |Added

 Blocks||1376389




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1376389
[Bug 1376389] Tracker for grafana dependencies
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378416] New: Review Request: nodejs-postcss - Transforming styles with JS plugins

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378416

Bug ID: 1378416
   Summary: Review Request: nodejs-postcss - Transforming styles
with JS plugins
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: mru...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: http://www.matthias-runge.de/fedora/nodejs-postcss.spec
SRPM URL:
http://www.matthias-runge.de/fedora/nodejs-postcss-5.2.0-1.fc26.src.rpm
Description: Transforming styles with JS plugins
Fedora Account System Username: mrunge

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378077] Review Request: jetty-test-helper - Jetty toolchain test helper

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378077



--- Comment #4 from Michael Simacek  ---
(In reply to gil cattaneo from comment #1)
> Could be possible import also the jetty-setuid module/s ?

I will package them as separate package.

(In reply to gil cattaneo from comment #3)
> Issues:
> - Bundled jar/class files should be removed before build
>   Note: Jar files in source (see attachment)
>   See: http://fedoraproject.org/wiki/Packaging:Java#Pre-
>   built_JAR_files_.2F_Other_bundled_software'
>  Please, remove
> ./jetty.toolchain-jetty-test-helper-3.1/eclipse-signing-maven-plugin/src/
> main/resources/org.eclipse.equinox.p2.jarprocessor_1.0.200.v20100503a.jar

Done.

> 
> [!]: If the source package does not include license text(s) as a separate
>  file from upstream, the packager SHOULD query upstream to include it.
> 

Filled:
https://github.com/eclipse/jetty.toolchain/issues/5

> [!]: Package does not include license text files separate from upstream.

Included license file from jetty (same license, same upstream)

Spec URL: https://msimacek.fedorapeople.org/jetty-test-helper.spec
SRPM URL:
https://msimacek.fedorapeople.org/jetty-test-helper-3.1-2.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1373486] Review Request: python34 - Version 3.4 of the Python programming language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373486



--- Comment #4 from Miro Hrončok  ---
Will do.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369224] Review Request: jackson-modules-base - Jackson modules: Base

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369224



--- Comment #14 from Fedora Update System  ---
jackson-modules-base-2.7.6-2.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-8cfed5403d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1332052] Review Request: python-filelock - A platform independent file lock

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1332052

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|ON_QA



--- Comment #4 from Fedora Update System  ---
python-filelock-2.0.6-1.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-330347da44

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1348202] Review Request: rubygem-pcaprub - libpcap bindings for ruby

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1348202

Fedora Update System  changed:

   What|Removed |Added

 Status|NEW |ON_QA



--- Comment #10 from Fedora Update System  ---
rubygem-pcaprub-0.12.4-1.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-84c96a7498

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1348162] Review Request: rubygem-net-dns - Pure Ruby DNS library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1348162

Fedora Update System  changed:

   What|Removed |Added

 Status|NEW |ON_QA



--- Comment #9 from Fedora Update System  ---
rubygem-net-dns-0.8.0-1.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-833d9e7e85

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1372718] Review Request: rubygem-puma - A simple, fast, threaded, and highly concurrent HTTP 1.1 server

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372718

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #26 from Fedora Update System  ---
rubygem-puma-3.6.0-3.fc25 has been pushed to the Fedora 25 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-97ac5ea7b4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1377812] Review Request: python-sphinxcontrib-blockdiag - Sphinx " blockdiag" extension

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1377812

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|ON_QA



--- Comment #4 from Fedora Update System  ---
python-sphinxcontrib-blockdiag-1.5.5-1.fc25 has been pushed to the Fedora 25
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-d0b335cd52

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1377733] Review Request: systemd-bootchart - Boot performance graphing tool

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1377733

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|ON_QA



--- Comment #6 from Fedora Update System  ---
systemd-bootchart-231-2.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-2f0fcabe02

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1370096] Review Request: rubygem-celluloid-essentials - Internally used tools, and superstructural dependencies of Celluloid

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1370096



--- Comment #7 from Germano Massullo  ---
Ok I will study how to implement tests in celluloid-essentials

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1370096] Review Request: rubygem-celluloid-essentials - Internally used tools, and superstructural dependencies of Celluloid

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1370096



--- Comment #6 from Jun Aruga  ---
(In reply to Germano Massullo from comment #3)
> Let's talk first about tests, because I think it is the biggest part to deal
> with.
> If I am right, enabling tests will require all "development dependencies"
> you can see at [1]. Many of them are not available in Fedora repositories
> 
> [1]: https://rubygems.org/gems/celluloid-essentials/versions/0.20.5

I think enabling tests will not require all "development dependencies", as Vit
said.
We do not test about benchmark, coverage, static code analysis (rubocop and
etc). We also do not use Bundler for our test in check section.

We want to test the logic, because there is often our environment specified
issue.

We sometimes comment out a test case in the test suite with "sed" command, and
etc, when it needs a development dependency that is not available in Fedora.

There are some tricky but typical techniques to package RPM.

For reference, you can see "sed" command lines in check section.
http://pkgs.fedoraproject.org/cgit/rpms/rubygem-sprockets.git/tree/rubygem-sprockets.spec
http://pkgs.fedoraproject.org/cgit/rpms/rubygem-puma.git/tree/rubygem-puma.spec


If you want to see more sample spec files about rubygem-*, for example you can
search by below search query on Google, to find those.

```
"rubygem-*.git" sed site:pkgs.fedoraproject.org filetype:spec
```

I think the adding test logic in check section may be a hard process for you,
especially if you are first time to do it. But after you have experienced
several packages, you may be accustomed to do it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1366047] Review Request: tss2 - IBM's TSS 2.0

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1366047



--- Comment #26 from Tomas Mraz  ---
(In reply to lo1 from comment #24)
> The developer has been using nonstandard variables such as LNFLAGS (as
> opposed to LDFLAGS) and CCFLAGS (for CFLAGS) etc.  There were other compile
> flags such as CCLFLAGS for compiling library and CCAFLAGS for compiling
> application.
> 
> Would that be OK to keep the naming of those nonstandard variables, while
> I'm making sure that the build includes hardending and optimalization with
> the RPM_OPT_FLAGS?

Yes, that should not be problem. However please also ensure that LDFLAGS set by
rpm build environment are applied when linking the binaries and library.

> I've fixed all warnings except for the "tss2-devel.x86_64: W: 
> only-non-binary-in-usr-lib".  Can this warning be ignored?

Yes, this can be ignored.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1373486] Review Request: python34 - Version 3.4 of the Python programming language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373486



--- Comment #3 from Charalampos Stratakis  ---
Is it possible to upgrade the package to its latest version? (Python 3.4.5)

Changelog: https://docs.python.org/3.4/whatsnew/changelog.html#python-3-4-5

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378021] Review Request: jetty-alpn - Jetty implementation of ALPN API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378021



--- Comment #3 from Michael Simacek  ---
You need latest jetty-alpn-api from rawhide. I built it yesterday, so it's
probably not on mirrors yet. You can either use koji repo or install it
manually from: http://koji.fedoraproject.org/koji/buildinfo?buildID=802911

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378341] New: Review Request: fedpkg-copr - copr dist-git client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378341

Bug ID: 1378341
   Summary: Review Request: fedpkg-copr - copr dist-git client
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: cl...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: http://clime.cz/fedpkg-copr.spec
SRPM URL: http://clime.cz/fedpkg-copr-0.6-1.fc23.src.rpm

Description: 

COPR dist-git client based on fedpkg. Used by copr-backend.service to fetch
srpms. copr-backend package is already in Fedora and it requires this package.


Fedora Account System Username: clime

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1370096] Review Request: rubygem-celluloid-essentials - Internally used tools, and superstructural dependencies of Celluloid

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1370096



--- Comment #5 from Vít Ondruch  ---
BTW from the list of dependencies, I guess that it would be possible to avoid
following packages:

benchmark_suite >= 0
bundler >= 0
coveralls >= 0
guard-rspec >= 0
pry >= 0
rake >= 0
rubocop >= 0
transpec >= 0

Not sure about these:

dotenv >= 0
nenv >= 0

The remaining packages might be just circular dependencies with culluloid*
packages and RSpec. Not bad IMO.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org