[Bug 1481630] Review Request: virtualbox-guest-additions - VirtualBox Guest Additions

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1481630

Hans de Goede  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-02-14 02:43:42



--- Comment #65 from Hans de Goede  ---
Ok, I've just imported virtualbox-guest-additions-5.2.6-4 (with one small fix
over the last version posted here) and started a build for it for rawhide.

Please disable the guest-additions sub-package in the rpmfusion package.

If you want to test this with vboxsf, here is a standalone version of vboxsf
which will build against the vboxguest included in the 4.16-rc1+ kernels in
rawhide:

https://github.com/jwrdegoede/vboxsf/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1538658] Review Request: python-anyconfig - common API to load and dump configuration files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1538658



--- Comment #14 from Zbigniew Jędrzejewski-Szmek  ---
Is there a new version of the spec file for review?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1537727] Review Request: python-cattrs - Python library for structuring and unstructuring data

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1537727

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1537727] Review Request: python-cattrs - Python library for structuring and unstructuring data

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1537727



--- Comment #3 from Fedora Update System  ---
python-cattrs-0.6.0-3.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-bb6df012c9

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1544605] Review Request: python-digitalocean - Easy access to Digital Ocean APIs to deploy droplets , images and more

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1544605



--- Comment #4 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-digitalocean

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1544562] Review Request: python-certbot-dns-route53 - Route53 DNS Authenticator plugin for Certbot

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1544562



--- Comment #4 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-certbot-dns-route53

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1544555] Review Request: python-certbot-dns-google - Google Cloud DNS Authenticator plugin for Certbot

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1544555



--- Comment #4 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-certbot-dns-google

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1538658] Review Request: python-anyconfig - common API to load and dump configuration files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1538658



--- Comment #13 from Satoru SATOH  ---
FYI.

I've released the new version 0.9.4 contains rpm related fixes and ...

(In reply to Zbigniew Jędrzejewski-Szmek from comment #12)
> (In reply to Brett Lentz from comment #11)
> > (In reply to Zbigniew Jędrzejewski-Szmek from comment #10)
> > > > %global sum Python library to load and dump configuration files in 
> > > > various formats
> > > Using normal Summary: and then %summary subsequently saves one line ;)
> > > 
> > 
> > Not true. The summary is used in 3 places because of the python2 & python3
> > sub-packaged. The macro saves copy/pasting the same text in 3 places.  :)
> 
> I didn't mean copying the text three times. I meant something like this:
> Summary: blah blah blah
> ...
> Summary: %summary
> ...
> Summary: %summary
> 
> Macro %summary is automatically defined to the contents of the last Summary
> line.

I didn't know this works. Thanks a lot for letting me know. Fixed it in the
upstream.

> > > During build I see the following error:
> > > > import cbor
> > > > ImportError: No module named cbor
> > > Is some dependency missing?

To keep dependencies at a minimum, anyconfig can process most ImportError-es at
runtime correctly and works well w/o some dependencies like cbor are missing.
And the new version becomes dependent on only some popular libraries by
default, so this kind of error disappears as much as possible, I think.

> > > and later:
> > > > toml.py:docstring of 
> > > > anyconfig.backend.toml.Parser._load_from_stream_fn:6: WARNING: 
> > > > Definition list ends without a blank line; unexpected unindent.
> > > > /builddir/build/BUILD/python-anyconfig-RELEASE_0.9.3/anyconfig/backend/xml.py:docstring
> > > >  of anyconfig.backend.xml._tweak_ns:4: WARNING: Field list ends without 
> > > > a blank line; unexpected unindent.
> > > > /builddir/build/BUILD/python-anyconfig-RELEASE_0.9.3/docs/api/anyconfig.cli.rst:4:
> > > >  WARNING: autodoc: failed to import module u'anyconfig.cli'; the 
> > > > following exception was raised:
> > > > Traceback (most recent call last):
> > > >   File "/usr/lib/python2.7/site-packages/sphinx/ext/autodoc.py", line 
> > > > 658, in import_object
> > > > __import__(self.modname)
> > > >   File 
> > > > "/builddir/build/BUILD/python-anyconfig-RELEASE_0.9.3/anyconfig/cli.py",
> > > >  line 42, in 
> > > > sys.stdout = codecs.getwriter(_ENCODING)(sys.stdout)
> > > >   File "/usr/lib64/python2.7/codecs.py", line 1009, in getwriter
> > > > return lookup(encoding).streamwriter
> > > > TypeError: lookup() argument 1 must be string, not None
> > > > done
> > > 
> > This looks like a bug in the docs. I'll point it out to upstream.
> Great.

Still I've been looking into this and may take some time to fix them
unfortunately.
But I don't think it's critical for packaging.

> > > And now the hard part: what is the difference in behaviour or output 
> > > between
> > > anyconfig-2 and anyconfig-3?
> > 
> > There is no difference, AFAICS.
> OK. If there is no difference, then only one version of the executable
> should be packed. See
> https://fedoraproject.org/wiki/Packaging:Python#Executables_in_.2Fusr.2Fbin:
> > If the executables provide the same functionality independent of whether 
> > they are run on top of Python 2 or Python 3, then only the Python 3 version 
> > of the executable should be packaged.
> 
> You went through the effort to get the symlinks right, but it now seems that
> not actually necessary ;(

Fixed in the upstream.


Brett-san,
could you please take a look at the RPM SPEC template in the upstream and try
to arrange the new version of RPM SPEC and srpm?
I tried to keep there are least differences between mine (upstream) and yours
as much as possible but maybe there are issues remained I'm not aware of or
forgot.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1328248] Review Request: python-pysword - Python bindings to read Sword bible files directly

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1328248



--- Comment #10 from TR Bentley  ---
https://trb143.fedorapeople.org/python-pysword-0.2.3-1.fc27.src.rpm

https://trb143.fedorapeople.org/python-pysword.spec

Sorry wrong files uploaded.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1328248] Review Request: python-pysword - Python bindings to read Sword bible files directly

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1328248



--- Comment #9 from Robert-André Mauchin  ---
%{__python3} setup.py build → %py3_build
%{__python3} setup.py install --skip-build -O1 --root %{buildroot} →
%py3_install


Also you should provide packages for both python2 and python3

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1328248] Review Request: python-pysword - Python bindings to read Sword bible files directly

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1328248



--- Comment #8 from TR Bentley  ---
Another set of updates 

https://trb143.fedorapeople.org/python-pysword.spec

https://trb143.fedorapeople.org/python-pysword-0.2.3-0.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1541566] Review Request: whipper - Python CD-DA ripper

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1541566



--- Comment #9 from Matthew  ---
Spec URL:
https://copr-be.cloud.fedoraproject.org/results/mruszczyk/whipper/fedora-rawhide-x86_64/00714828-whipper/whipper.spec

SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/mruszczyk/whipper/fedora-rawhide-x86_64/00714828-whipper/whipper-0.6.0-5.fc28.src.rpm

Description: CD-DA ripper focused on accuracy over speed.

Fedora Account System Username: mruszczyk

I had to update the spec once more, I was missing python2-setuptools.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1544562] Review Request: python-certbot-dns-route53 - Route53 DNS Authenticator plugin for Certbot

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1544562

Nick Bebout  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #3 from Nick Bebout  ---
Follows standard python packaging guidelines and spec template.

Please fix srpm, python2, and python3 %description, this is not rfc2136 plugin

Package APPROVED with that one minor change.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1544605] Review Request: python-digitalocean - Easy access to Digital Ocean APIs to deploy droplets , images and more

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1544605

Nick Bebout  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #3 from Nick Bebout  ---
Follows standard python packaging guidelines and spec template.

Package APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1544555] Review Request: python-certbot-dns-google - Google Cloud DNS Authenticator plugin for Certbot

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1544555

Nick Bebout  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #3 from Nick Bebout  ---
Follows standard python packaging guidelines and spec template.

Please fix srpm, python2, and python3 %description, this is not rfc2136 plugin

Package APPROVED with that one minor change.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519323] Review request: qesteidutil - Estonian ID card utility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519323



--- Comment #13 from Fedora Update System  ---
qesteidutil-3.12.10-1.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-54c7a5b01b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1543334] Review Request: python-xmlsec - Python bindings for the XML Security Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1543334

Jeremy Cline  changed:

   What|Removed |Added

 CC||jcl...@redhat.com



--- Comment #3 from Jeremy Cline  ---
Thanks for the review! I've fixed the noted issues during the initial import.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1512226] Review Request: python3-flask-cors - Cross Origin Resource Sharing ( CORS ) support for Flask

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1512226



--- Comment #9 from Athos Ribeiro  ---
Hi David,

Your package looks good to me and we are ready to moving forward on sponsoring
you into the packagers group. Any news on those informal package reviews? You
can link them here :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1516117] Review Request: python-hexdump - Dump binary data to hex format and restore from there

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1516117



--- Comment #7 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-hexdump

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1537398] Review Request: spectre-meltdown-checker - Spectre & Meltdown vulnerability/ mitigation checker

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1537398

Reto Gantenbein  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |ERRATA
Last Closed||2018-02-13 13:04:14



--- Comment #6 from Reto Gantenbein  ---
Thanks a lot for your support. The package is in the Fedora stable repositories
now. Somehow the "Fedora Update System" didn't properly propagate the changes
to the bug report:

spectre-meltdown-checker-0.33-1.fc26 has been pushed to the Fedora 26 stable
repository.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-d4404e0708

spectre-meltdown-checker-0.33-1.fc27 has been pushed to the Fedora 27 stable
repository.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-e3d1c4e564

The packages for the EPEL repositories are also on its way. If anyone could
help accelerating this, it would be much appreciated.

I guess this bug report can be closed now. Feel free to open another bug if you
have any issue with this package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1506428] Review Request: gnome-shell-extension-historymanager-prefix-search - Use PageUp and PageDown to search for previous GNOME Shell commands

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1506428



--- Comment #19 from Fedora Update System  ---
gnome-shell-extension-historymanager-prefix-search-10-2.fc27 has been pushed to
the Fedora 27 stable repository. If problems still persist, please make note of
it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1506429] Review Request: gnome-shell-extension-windowoverlay-icons - Show app icons on top of the windows thumbnails in Activities Overview

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1506429



--- Comment #19 from Fedora Update System  ---
gnome-shell-extension-windowoverlay-icons-27-2.fc27 has been pushed to the
Fedora 27 stable repository. If problems still persist, please make note of it
in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1506429] Review Request: gnome-shell-extension-windowoverlay-icons - Show app icons on top of the windows thumbnails in Activities Overview

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1506429

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2018-02-13 12:37:41



--- Comment #18 from Fedora Update System  ---
gnome-shell-extension-windowoverlay-icons-27-2.fc26 has been pushed to the
Fedora 26 stable repository. If problems still persist, please make note of it
in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1506428] Review Request: gnome-shell-extension-historymanager-prefix-search - Use PageUp and PageDown to search for previous GNOME Shell commands

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1506428

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2018-02-13 12:37:37



--- Comment #18 from Fedora Update System  ---
gnome-shell-extension-historymanager-prefix-search-10-2.fc26 has been pushed to
the Fedora 26 stable repository. If problems still persist, please make note of
it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1526705] Review Request: python-f5-icontrol-rest - F5 BIG-IP iControl REST API client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1526705



--- Comment #3 from Xavier Bachelot  ---
I've changed the package to use the github source, but I'm having some issues
with it now. I will nevertheless upload the latest spec and srpm asap.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1507103] Review Request: kronosnet - Multipoint-to-Multipoint network abstraction layer for High Availability applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1507103



--- Comment #37 from Jan Friesse  ---
@digimer:
Forgot one more thing. We need more %{_isa}. Just add them basically for every

Requires: libtap1

and

Requires: libknet1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1544899] Review Request: golang-github-muesli-smartcrop - Finds good image crops for arbitrary crop sizes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1544899

Athos Ribeiro  changed:

   What|Removed |Added

 Blocks||1529947




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1529947
[Bug 1529947] hugo-0.36 is available
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1507103] Review Request: kronosnet - Multipoint-to-Multipoint network abstraction layer for High Availability applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1507103



--- Comment #36 from Jan Friesse  ---
@digimer:
From my point of view, package is almost ready to pass all the required test,
but there are still few left:

- Please remove %defattr(-,root,root,-) everywhere

- For kronosnetd:
  * Requires(preun): shadow-utils <-- not needed

  * groupadd --force kronosnetadm <-- kronosnetadm should be system account
(and force is not needed), so result should be "groupadd -r kronosnetadm"

  * %systemd_post kronosnetd.service <-- I believe there was small
misunderstanding. So the question is, if you want to keep compatibility with
non-systemd systems (whole spec is written that way), then stanza should look
like:

```
%if %{defined _unitdir}
  %systemd_post kronosnetd.service
%else
/sbin/chkconfig --add kronosnetd
%endif
```
  * Please fix the "%preun -n kronosnetd" section similar way

  * Add %{?systemd_requires} (conditionally)

  * Add postun:
```
%postun -n kronosnetd
%if %{defined _unitdir}
  %systemd_postun kronosnetd.service
%endif
```

- Missing "BuildRequires: systemd" (probably conditional) so something like
  ```
  %if %{defined _unitdir} && %{defined buildkronosnetd}
BuildRequires: systemd
  %endif
  ```

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1544899] New: Review Request: golang-github-muesli-smartcrop - Finds good image crops for arbitrary crop sizes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1544899

Bug ID: 1544899
   Summary: Review Request: golang-github-muesli-smartcrop - Finds
good image crops for arbitrary crop sizes
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: athoscribe...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://athoscr.fedorapeople.org/packaging/golang-github-muesli-smartcrop.spec
SRPM URL:
https://athoscr.fedorapeople.org/packaging/golang-github-muesli-smartcrop-0.2.0-1.src.rpm
koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=25007381

Description: golang library to finds good image crops for arbitrary crop sizes
Fedora Account System Username: athoscr

rpmlint (spec and srpm):
1 packages and 1 specfiles checked; 0 errors, 0 warnings.

Notes:

The two images in the examples directory are licensed under creative commons
licenses.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1542650] Review Request: qevercloud - Unofficial Evernote Cloud API for Qt5

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1542650

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #7 from Fedora Update System  ---
qevercloud-4.0.0-1.fc27 has been pushed to the Fedora 27 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-cb548cbe27

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1541554] Review Request: podman - Manage Pods, Containers and Container Images

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1541554

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #9 from Fedora Update System  ---
podman-0.2-1.git3d0100b.fc27 has been pushed to the Fedora 27 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-803745b92f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1544865] New: Review Request: rubygem-guard-livereload - Guard plugin for livereload

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1544865

Bug ID: 1544865
   Summary: Review Request: rubygem-guard-livereload - Guard
plugin for livereload
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: jar.pro...@volny.cz
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://jackorp.fedorapeople.org/rubygem-guard-livereload/rubygem-guard-livereload.spec
SRPM URL:
https://jackorp.fedorapeople.org/rubygem-guard-livereload/rubygem-guard-livereload-2.5.2-1.fc28.src.rpm
Description: Guard::LiveReload automatically reloads your browser when 'view'
files are modified.
Fedora Account System Username: jackorp

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1396847] Review Request: screencloud - Easy to use screenshot sharing application

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1396847



--- Comment #5 from Tomáš Korbař  ---
Hello,
According to the fedora-review you dont have to list "gcc" and "make" in
BuildRequires, i compiled the code after removal and it works so i think you
can remove it.
Upstream already accepted change of desktop file and removed execution
permission from LICENSE and README.md so you can remove that parts too.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1396847] Review Request: screencloud - Easy to use screenshot sharing application

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1396847

Tomáš Korbař  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||tomas.k...@seznam.cz
   Assignee|nob...@fedoraproject.org|tomas.k...@seznam.cz



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 910146] Review Request: python-socksipychain - Python SOCKS/ HTTP Proxy module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=910146

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed|2013-11-11 13:32:54 |2018-02-13 10:58:17



--- Comment #19 from Fedora Update System  ---
python-socksipychain-2.0.15-1.el7 has been pushed to the Fedora EPEL 7 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534446] Review Request: timeshift - System restore tool for Linux

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534446



--- Comment #29 from Fedora Update System  ---
timeshift-18.1.1-4.el7 has been pushed to the Fedora EPEL 7 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 910699] Review Request: pagekite - makes localhost servers visible to the world

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=910699
Bug 910699 depends on bug 910146, which changed state.

Bug 910146 Summary: Review Request: python-socksipychain - Python SOCKS/HTTP 
Proxy module
https://bugzilla.redhat.com/show_bug.cgi?id=910146

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1543377] Review Request: python3-saml - Add SAML support to your Python software using this library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1543377



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/python3-saml

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1543334] Review Request: python-xmlsec - Python bindings for the XML Security Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1543334



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-xmlsec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1492475] Review Request: aftertheflood-sparks-fonts - a font to display charts within text

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1492475



--- Comment #11 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/aftertheflood-sparks-fonts. You may commit
to the branch "f27" in about 10 minutes.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1495293] Review Request: python-Naked - A command line application framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1495293



--- Comment #9 from Fedora Update System  ---
python-Naked-0.1.31-3.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-91d06f2add

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1495293] Review Request: python-Naked - A command line application framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1495293

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1544468] Review Request: fapolicyd - Application Whitelisting Daemon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1544468



--- Comment #6 from Steve Grubb  ---
Ah! You are right. We are using libudev and it has been subsumed into systemd.
So, systemd-devel is appropriate. Fixed.

New spec and SRPM is posted.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1544468] Review Request: fapolicyd - Application Whitelisting Daemon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1544468



--- Comment #5 from Marek Tamaskovic  ---
I can't build that package without the systemd-devel

Checking for required libraries
checking for udev_device_get_devnode in -ludev... no
configure: error: libudev not found
error: Bad exit status from /var/tmp/rpm-tmp.f6JG6O (%build)
RPM build errors:
Bad exit status from /var/tmp/rpm-tmp.f6JG6O (%build)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1544716] Review Request: golang-github-inconshreveable-go-vhost - HTTP/ TLS hostname multiplexing library for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1544716

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review?



--- Comment #1 from Robert-André Mauchin  ---
> This is my first package, but I already have sponsor (I guess)

According to fas info, you are already a member of the packager group, so you
need no sponsor, you already can request repos and branches:

User: jkucera, Name: Jiri Kucera, email: jkuc...@redhat.com, Creation:
2017-10-16, IRC Nick: None, Timezone: UTC, Locale: en, GPG key ID: None,
Status: active
Approved Groups: fedorabugs packager cla_done cla_fpca


Now this package:

 - When packaging a development snapshot, you need to add the date of the
commit in the Release field. See
https://fedoraproject.org/wiki/Packaging:Versioning#Snapshots

%global commit  06d84117953b22058c096b49a429ebd4f3d3d97b
%global shortcommit %(c=%{commit}; echo ${c:0:7})
%global commitdate  20160627

Name:   golang-%{provider}-%{project}-%{repo}
Version:0
Release:0.1.%{commitdate}git%{shortcommit}%{?dist}

   And then in the %changelog:

* Mon Feb 12 2018 Jiri Kucera  - 0-0.1.20160627git06d8411

 - Please add a comment explaining why the patch is needed, optionally link to
an upstream bug report or PR. (I guess this is yours
https://github.com/inconshreveable/go-vhost/pull/7 Just add it as a comment so
you'll know when to remove the patch once it has been accepted upstream).


Everything else is okay


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Apache (v2.0)", "Unknown or generated". 10 files have unknown
 license. Detailed output of licensecheck in /home/bob/packaging/review
 /golang-github-inconshreveable-go-vhost/review-golang-github-
 inconshreveable-go-vhost/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/gocode/src,
 /usr/share/gocode, /usr/share/gocode/src/github.com
[x]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by:
 /usr/share/gocode/src/github.com/inconshreveable(golang-github-
 inconshreveable-mousetrap-devel, golang-github-inconshreveable-muxado-
 devel)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[!]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[-]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf 

[Bug 1543813] Review Request: pwkickstart - generate kickstart passwords

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1543813



--- Comment #5 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/pwkickstart. You may commit to the branch
"f27" in about 10 minutes.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1310434] Review Request: python-wxpython4 - new implementation of wxPython (Phoenix)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1310434



--- Comment #13 from Scott Talbert  ---
Okay, I think this should address most of the rpmlint issues, re-enables the
tests (but there are still some that fail, and some that fail only in koji, so
I'm going to leave them || true for now), and addresses your other comments:

Spec URL: https://www.techie.net/~talbert/python-wxpython4.spec
SRPM URL: https://www.techie.net/~talbert/python-wxpython4-4.0.1-2.fc28.src.rpm

Thanks again Miro for your review.  :-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1544468] Review Request: fapolicyd - Application Whitelisting Daemon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1544468

Steve Grubb  changed:

   What|Removed |Added

  Flags|needinfo?(sgr...@redhat.com |
   |)   |



--- Comment #4 from Steve Grubb  ---
(In reply to Marek Tamaskovic from comment #3)
> Missing: 'BuildRequires: systemd-devel'

I think we are good here. The report in Comment #1 was that the -devel needed
to go. I check the systemd guidelines and that appears true:

https://fedoraproject.org/wiki/Packaging:Systemd#Filesystem_locations

rpm -ql systemd-devel shows nothing useful unless you are building a C program
against libsystemd.


> BuildRequires - no multiple requires in one line. Every package should be on
> unique line.

I can't find this in the packaging guidelines. Packaging guidelines just say
all dependencies need to be stated.

https://fedoraproject.org/wiki/Packaging:Guidelines#Build-Time_Dependencies_.28BuildRequires.29


> In files use macros i.e. etc: %{_sysconfdir} == /etc

Fixed.

New spec and SRPM posted.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1542650] Review Request: qevercloud - Unofficial Evernote Cloud API for Qt5

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1542650



--- Comment #6 from Fedora Update System  ---
qevercloud-4.0.0-1.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-cb548cbe27

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1542650] Review Request: qevercloud - Unofficial Evernote Cloud API for Qt5

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1542650

Fedora Update System  changed:

   What|Removed |Added

 Status|NEW |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1544468] Review Request: fapolicyd - Application Whitelisting Daemon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1544468

Marek Tamaskovic  changed:

   What|Removed |Added

 CC||sgr...@redhat.com
  Flags||needinfo?(sgr...@redhat.com
   ||)



--- Comment #3 from Marek Tamaskovic  ---
Missing: 'BuildRequires: systemd-devel'
BuildRequires - no multiple requires in one line. Every package should be on
unique line.
In files use macros i.e. etc: %{_sysconfdir} == /etc

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1542522] Review Request: jsonnet - a data templating language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1542522



--- Comment #4 from Naadir Jeewa  ---
> Sorry, I should have been more clear. Drop this completely. The Group: tag is 
> not used in EPEL, either.

I wasn't sure from the docs, so took a guess.

>>License: Apache-2.0
> Still not fixed. See my content above.

Sorry, missed that one.

> The default is to make all things writable by root, so this should probably be
> 0755 and 0644 (unless you have a good reason). Also, looking at /usr/lib on my
> system - libraries are usually installed with 755, not 644.

Amended

> make sure that the licence text is present if the user installs any 
> combination of packages

Amended
https://copr-be.cloud.fedoraproject.org/results/randomvariable/jsonnet/fedora-rawhide-x86_64/00714576-jsonnet/jsonnet.spec

https://copr-be.cloud.fedoraproject.org/results/randomvariable/jsonnet/fedora-rawhide-x86_64/00714576-jsonnet/jsonnet-0.9.5-4.src.rpm

Thanks for your time on this so far.

Naadir

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1544716] New: Review Request: golang-github-inconshreveable-go-vhost - HTTP/ TLS hostname multiplexing library for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1544716

Bug ID: 1544716
   Summary: Review Request: golang-github-inconshreveable-go-vhost
- HTTP/TLS hostname multiplexing library for Go
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: jkuc...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://raw.githubusercontent.com/i386x/golang-github-inconshreveable-go-vhost/master/golang-github-inconshreveable-go-vhost.spec
Patch0 URL:
https://raw.githubusercontent.com/i386x/golang-github-inconshreveable-go-vhost/master/mux_test-missing-format-string.patch
SRPM URL:
https://github.com/i386x/golang-github-inconshreveable-go-vhost/raw/master/golang-github-inconshreveable-go-vhost-0-0.1.git06d8411.fc27.src.rpm
Koji (scratch) build URL:
https://koji.fedoraproject.org/koji/taskinfo?taskID=24968645
Description: HTTP/TLS hostname multiplexing library for Go
Fedora Account System Username: jkucera
Notes: This is my first package, but I already have sponsor (I guess). This
package is a dependency of bettercap 2.0.0 [
https://bugzilla.redhat.com/show_bug.cgi?id=1540726#c11 ]

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1542522] Review Request: jsonnet - a data templating language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1542522



--- Comment #3 from Iwicki Artur  ---
>%if 0%{?rhel}
>Group: Development/Languages
>%endif
Sorry, I should have been more clear. Drop this completely. The Group: tag is
not used in EPEL, either.

>License: Apache-2.0
Still not fixed. See my content above.

>install -m 0555 -s ./jsonnet $RPM_BUILD_ROOT%{_bindir}
>install -m 0444 ./include/* $RPM_BUILD_ROOT%{_includedir}
>install -m 0444 -s ./lib%{name}.so $RPM_BUILD_ROOT%{_libdir}
The default is to make all things writable by root, so this should probably be
0755 and 0644 (unless you have a good reason). Also, looking at /usr/lib on my
system - libraries are usually installed with 755, not 644.

Regarding the licence: you should make sure that the licence text is present if
the user installs any combination of packages. Currently the licence is present
only in the main package. The lib package can be installed independently of the
main package, so it should contain a copy of the licence text. The -devel and
-python packages Require the lib package, so they don't need their own copy.
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Subpackage_Licensing

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1543813] Review Request: pwkickstart - generate kickstart passwords

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1543813



--- Comment #4 from Lukas Zapletal  ---
Thanks a lot!

https://pagure.io/releng/fedora-scm-requests/issue/4490
https://pagure.io/releng/fedora-scm-requests/issue/4491

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1520584] Review Request: perl-MooseX-Types-NetAddr-IP - NetAddr:: IP related types and coercions for Moose

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1520584

Fedora Update System  changed:

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|ERRATA  |---
   Keywords||Reopened



--- Comment #12 from Fedora Update System  ---
perl-MooseX-Types-NetAddr-IP-0.07-2.el7 has been pushed to the Fedora EPEL 7
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-1fc7101641

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1268696] Review Request: rubygem-guard-rspec - Guard gem for RSpec

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268696



--- Comment #13 from Vít Ondruch  ---
(In reply to Jaroslav Prokop from comment #11)
> The Guard::RSpec::RSpecProcess failures are happening because bundler is
> needed for them and the upstream does not seem to mention that or require it
> at all in the file.

Well, upstream is executing the test suite using Bundler, so in that case
Bundler is always loaded. The question is if we want to include Bundler as
build dependency or not. Both options have their pros/cons.



(In reply to Ilya Gradina from comment #10)
> (In reply to Vít Ondruch from comment #9)
> > Why are the Guard::RSpecFormatter tests failing anyway? It seems the time is
> > now formatted differently. Is it Ruby 2.5 thing? Or some incompatibility
> > with latest RSpec? Isn't there patch available upstream already?
> 
> Hi Vit, thanks for the remarks.
> I had two kinds of errors: Guard::RSpec::RSpecProcess,
> Guard::RSpecFormatter. Option "rspec --tag ~..." did not work for me, so I
> used "--exclude-pattern".
> 
> new spec:
> https://github.com/ilgrad/fedora-packages/raw/master/rubygems/rubygem-guard-
> rspec.spec

You still don't have any remark in the .spec file why you exclude the tests :(
That is always very essential to understand why something was done.

> also there is open issue with Guard::RSpecFormatter:
> https://github.com/guard/guard-rspec/issues/405

This does not appear to be related. I'd say that a bit more related is

https://github.com/guard/guard-rspec/pull/403

because it enables upstream to test against more recent versions of Ruby,
although it still does not include tests against Ruby 2.5 or ruby-head :(

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1542902] Review Request: php-pecl-redis4 - Extension for communicating with the Redis key-value store

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1542902

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #9 from Fedora Update System  ---
php-pecl-redis4-4.0.0~RC1-4.fc27 has been pushed to the Fedora 27 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-f266a9f303

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536852] Review Request: molsketch - Molecular Structures Editor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536852



--- Comment #39 from Fedora Update System  ---
molsketch-0.5.1-7.fc27 has been pushed to the Fedora 27 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-6ccf2bb289

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org