[Bug 1268696] Review Request: rubygem-guard-rspec - Guard gem for RSpec

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268696

Jaroslav Prokop  changed:

   What|Removed |Added

 Resolution|DEFERRED|NOTABUG
  Flags|fedora-review?  |



--- Comment #16 from Jaroslav Prokop  ---
Closing this (properly this time) as per stalled package review:

https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews?rd=Extras

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1268696] Review Request: rubygem-guard-rspec - Guard gem for RSpec

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268696

Vít Ondruch  changed:

   What|Removed |Added

 Blocks||201449 (FE-DEADREVIEW)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=201449
[Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response
should be blocking this bug.
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1268696] Review Request: rubygem-guard-rspec - Guard gem for RSpec

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268696

Jaroslav Prokop  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |DEFERRED
Last Closed||2019-07-28 21:56:26



--- Comment #15 from Jaroslav Prokop  ---
I am closing this because of inactivity from the maintainer.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1268696] Review Request: rubygem-guard-rspec - Guard gem for RSpec

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268696



--- Comment #14 from Jaroslav Prokop  ---
Ping... are you still interested in this package? It's been some time since the
last update on this bug.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1268696] Review Request: rubygem-guard-rspec - Guard gem for RSpec

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268696



--- Comment #13 from Vít Ondruch  ---
(In reply to Jaroslav Prokop from comment #11)
> The Guard::RSpec::RSpecProcess failures are happening because bundler is
> needed for them and the upstream does not seem to mention that or require it
> at all in the file.

Well, upstream is executing the test suite using Bundler, so in that case
Bundler is always loaded. The question is if we want to include Bundler as
build dependency or not. Both options have their pros/cons.



(In reply to Ilya Gradina from comment #10)
> (In reply to Vít Ondruch from comment #9)
> > Why are the Guard::RSpecFormatter tests failing anyway? It seems the time is
> > now formatted differently. Is it Ruby 2.5 thing? Or some incompatibility
> > with latest RSpec? Isn't there patch available upstream already?
> 
> Hi Vit, thanks for the remarks.
> I had two kinds of errors: Guard::RSpec::RSpecProcess,
> Guard::RSpecFormatter. Option "rspec --tag ~..." did not work for me, so I
> used "--exclude-pattern".
> 
> new spec:
> https://github.com/ilgrad/fedora-packages/raw/master/rubygems/rubygem-guard-
> rspec.spec

You still don't have any remark in the .spec file why you exclude the tests :(
That is always very essential to understand why something was done.

> also there is open issue with Guard::RSpecFormatter:
> https://github.com/guard/guard-rspec/issues/405

This does not appear to be related. I'd say that a bit more related is

https://github.com/guard/guard-rspec/pull/403

because it enables upstream to test against more recent versions of Ruby,
although it still does not include tests against Ruby 2.5 or ruby-head :(

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1268696] Review Request: rubygem-guard-rspec - Guard gem for RSpec

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268696



--- Comment #12 from Ilya Gradina  ---
(In reply to Jaroslav Prokop from comment #11)
> The Guard::RSpec::RSpecProcess failures are happening because bundler is
> needed for them and the upstream does not seem to mention that or require it
> at all in the file. I recommend notifying upstream about this. For the time
> being I would probably just comment out the specific test cases.

ok, thx.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1268696] Review Request: rubygem-guard-rspec - Guard gem for RSpec

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268696



--- Comment #11 from Jaroslav Prokop  ---
The Guard::RSpec::RSpecProcess failures are happening because bundler is needed
for them and the upstream does not seem to mention that or require it at all in
the file. I recommend notifying upstream about this. For the time being I would
probably just comment out the specific test cases.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1268696] Review Request: rubygem-guard-rspec - Guard gem for RSpec

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268696



--- Comment #10 from Ilya Gradina  ---
(In reply to Vít Ondruch from comment #9)
> Oh, you are applying the latest packaging techniques (unpacking the gem via
> %setup), very nice :)
> 
> However, the "rspec -Ilib spec ||:" is too hand-wavy. If the test suite
> fails entirely, you won't notice. I would rather see the tests disabled one
> by one or some explanation at minimum.
> 
> Why are the Guard::RSpecFormatter tests failing anyway? It seems the time is
> now formatted differently. Is it Ruby 2.5 thing? Or some incompatibility
> with latest RSpec? Isn't there patch available upstream already?

Hi Vit, thanks for the remarks.
I had two kinds of errors: Guard::RSpec::RSpecProcess, Guard::RSpecFormatter.
Option "rspec --tag ~..." did not work for me, so I used "--exclude-pattern".

new spec:
https://github.com/ilgrad/fedora-packages/raw/master/rubygems/rubygem-guard-rspec.spec
new srpm:
https://github.com/ilgrad/fedora-packages/raw/master/rubygems/rubygem-guard-rspec-4.7.3-3.fc28.src.rpm

also there is open issue with Guard::RSpecFormatter:
https://github.com/guard/guard-rspec/issues/405

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1268696] Review Request: rubygem-guard-rspec - Guard gem for RSpec

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268696



--- Comment #9 from Vít Ondruch  ---
Oh, you are applying the latest packaging techniques (unpacking the gem via
%setup), very nice :)

However, the "rspec -Ilib spec ||:" is too hand-wavy. If the test suite fails
entirely, you won't notice. I would rather see the tests disabled one by one or
some explanation at minimum.

Why are the Guard::RSpecFormatter tests failing anyway? It seems the time is
now formatted differently. Is it Ruby 2.5 thing? Or some incompatibility with
latest RSpec? Isn't there patch available upstream already?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1268696] Review Request: rubygem-guard-rspec - Guard gem for RSpec

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268696



--- Comment #8 from Ilya Gradina  ---
new spec:
https://github.com/ilgrad/fedora-packages/raw/master/rubygems/rubygem-guard-rspec.spec

new srpm:
https://github.com/ilgrad/fedora-packages/raw/master/rubygems/rubygem-guard-rspec-4.7.3-2.fc28.src.rpm

tests do not all pass.
Finished in 0.32727 seconds (files took 0.20452 seconds to load)
162 examples, 9 failures

I disabled tests with require gem_isolator, on the advice of Vit.

results tests:
https://paste.fedoraproject.org/paste/pvBj2aiPMZgBuK3IZRdpYA

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1268696] Review Request: rubygem-guard-rspec - Guard gem for RSpec

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268696



--- Comment #7 from Ilya Gradina  ---
(In reply to Jaroslav Prokop from comment #6)
> Hi, I'll be taking this  for a review. Have you advanced with the package,
> Ilya?
Thanks Jaroslav,

I'll send a new version of the package soon.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1268696] Review Request: rubygem-guard-rspec - Guard gem for RSpec

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268696

Jaroslav Prokop  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
  Flags||fedora-review?



--- Comment #6 from Jaroslav Prokop  ---
Hi, I'll be taking this  for a review. Have you advanced with the package,
Ilya?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1268696] Review Request: rubygem-guard-rspec - Guard gem for RSpec

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268696

Jaroslav Prokop  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|jar.pro...@volny.cz



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1268696] Review Request: rubygem-guard-rspec - Guard gem for RSpec

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268696
Bug 1268696 depends on bug 1516328, which changed state.

Bug 1516328 Summary: Review Request: rubygem-guard-compat - Tools for 
developing Guard compatible plugins
https://bugzilla.redhat.com/show_bug.cgi?id=1516328

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1268696] Review Request: rubygem-guard-rspec - Guard gem for RSpec

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268696



--- Comment #5 from Vít Ondruch  ---
(In reply to Ilya Gradina from comment #3)
> also as rubygem(gem_isolator)(I'll try
> to send soon on review request).

I would not mind if you disabled the specific test case ATM:

~~~
# Requires rubygem(gem_isolator).
mv spec/acceptance/formatter_spec.rb{,.disabled}
~~~

But:

1) Of course having gem_isolator in Fedora is better
2) There are another 4 test failures due to "uninitialized constant Bundler"
errors. It seems it would be better to disable these test cases, otherwise you
will need to fight with all the other dependencies specified in Gemfiles. Not
sure ...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1268696] Review Request: rubygem-guard-rspec - Guard gem for RSpec

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268696

Vít Ondruch  changed:

   What|Removed |Added

 CC||vondr...@redhat.com



--- Comment #4 from Vít Ondruch  ---
BTW I got "warning: bogus date in %changelog: Tue Dec 05 2018 Ilya Gradina
 - 4.7.3-1"

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1268696] Review Request: rubygem-guard-rspec - Guard gem for RSpec

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268696



--- Comment #3 from Ilya Gradina  ---
Hi Jaroslav,
thx for the review.
rubygem(launchy) - needed for tests, also as rubygem(gem_isolator)(I'll try to
send soon on review request).

results build on copr(with disable tests):
https://copr.fedorainfracloud.org/coprs/ilgrad/test_rubygems/build/684766/

new spec:
https://raw.githubusercontent.com/ilgrad/fedora-packages/master/rubygems/rubygem-guard-rspec.spec
new srpm:
https://github.com/ilgrad/fedora-packages/raw/master/rubygems/rubygem-guard-rspec-4.7.3-1.fc27.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1268696] Review Request: rubygem-guard-rspec - Guard gem for RSpec

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268696



--- Comment #2 from Jaroslav Prokop  ---
I am sorry, I forgot one last thing

* Unnecessary dependency
  - The rubygem "launchy" does not seem like dependency to guard-rspec so 
I would drop it from requires if possible.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1268696] Review Request: rubygem-guard-rspec - Guard gem for RSpec

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268696

Jaroslav Prokop  changed:

   What|Removed |Added

 CC||jar.pro...@volny.cz



--- Comment #1 from Jaroslav Prokop  ---
Hi Ilya, I did an informal review on this package.

* Outdated version
  - You should make it up to date with upstream release and also update it to   
more current fedora releases

* Group is not needed
  - Group tags are not needed currently, so you should delete lines:
~~~
Group: Development/Languages
~~~

~~~
Group: Documentation
~~~

In my opinion you could run the tests without -Ilib option.

Otherwise the package looks good.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1268696] Review Request: rubygem-guard-rspec - Guard gem for RSpec

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268696
Bug 1268696 depends on bug 1268695, which changed state.

Bug 1268695 Summary: Review Request: rubygem-guard-compat - Tools for 
developing Guard compatible plugins
https://bugzilla.redhat.com/show_bug.cgi?id=1268695

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |DUPLICATE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1268696] Review Request: rubygem-guard-rspec - Guard gem for RSpec

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268696

Ilya Gradina  changed:

   What|Removed |Added

 Depends On||1516328




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1516328
[Bug 1516328] Review Request: rubygem-guard-compat - Tools for developing
Guard compatible plugins
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1268696] Review Request: rubygem-guard-rspec - Guard gem for RSpec

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268696

Ilya Gradina  changed:

   What|Removed |Added

 Depends On||1268695




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1268695
[Bug 1268695] Review Request: rubygem-guard-compat - Tools for developing
Guard compatible plugins
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review