ash
+elif [ "$1" == "--quick-test" ]; then
+export PW_SKIP_BROWSER_TESTS=yes
+python3 manage.py test
+elif [ "$1" == "--test" ]; then
+xvfb-run --server-args='-screen 0, 1024x768x16' python3 manage.py test
+else # run whatever CMD is set to
+$@
+fi
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
___
Patchwork mailing list
Patchwork@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/patchwork
On 04/08/16 16:10, Daniel Axtens wrote:
This is preparation for a Docker-based dev environment.
Signed-off-by: Daniel Axtens <d...@axtens.net>
A good move generally.
Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
--
Andrew Donnellan OzLabs,
.
Signed-off-by: Daniel Axtens <d...@axtens.net>
All looks good.
Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
_
int.
Signed-off-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
diff --git a/patchwork/rest_serializers.py b/patchwork/rest_serializers.py
index af6b1b7..be55ad1 100644
--- a/patchwork/rest_serializers.py
+++ b/patchwork/rest_serializers.py
@@ -84,7 +84,7 @@ class PatchSe
On 09/08/16 14:38, Daniel Axtens wrote:
Yay for debugging with Docker.
Signed-off-by: Daniel Axtens <d...@axtens.net>
Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Austr
ql: [Warning] Using a password on the command line interface
can be insecure.
db_1 |
db_1 | /usr/local/bin/docker-entrypoint.sh: ignoring
/docker-entrypoint-initdb.d/*
db_1 |
db_1 |
db_1 | MySQL init process done. Ready for start up.
db_1 |
Perhaps 5 seconds isn't enough?
--
Andr
that later on in the series. :)
ACK, I want this in the API.
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
___
Patchwork mailing list
Patchwork@lists.ozlabs.org
https://lists.ozlabs.org/listinfo
-by: Daniel Axtens <d...@axtens.net>
Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
---
v2: call them prefixes rather than categories, only expose in
detail view
---
patchwork/api/patch.py | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/p
On 21/02/17 16:16, Daniel Axtens wrote:
We could possibly move this into the detail view. Andrew or Russell:
would that work for you?
That's fine by me.
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
this for non-model fields though...
At the moment, no. The use case is our CI system where we want to be
able to take each patch one by one and figure out which tree to apply it
to. So we don't need to filter on categories/prefixes.
I think it would be useful to implement regardless.
--
Andrew
it's more semantically meaningful to expose this as a
separate field.
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
___
Patchwork mailing list
Patchwork@lists.ozlabs.org
https
On 05/09/16 13:58, Andrew Donnellan wrote:
+def handle(self, *args, **options):
+path = (args[0] if args else
+options['infile'] if 'infile' in options else None)
argparse is giving you a file, not a string. As you've given a default
in the argument, this should
box')) as file_:
+with self.assertRaises(SystemExit) as exc:
+call_command('parsemail',
+ stdin=file_)
+
+self.assertEqual(exc.exception.code, 1)
Can we test the --list-id option at all?
--
Andrew Donnellan OzLabs, ADL Canberra
andre
as above.
This is the sanest approach I think. For each 1/N patch, create a new
series.
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
___
Patchwork mailing list
Patchwork@lists.ozlabs.org
On 03/09/16 17:07, Daniel Axtens wrote:
The try block just raises the exception it catches, so just get rid of
it.
Signed-off-by: Daniel Axtens <d...@axtens.net>
Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
---
patchwork/views/xm
On 13/09/16 07:53, Stephen Finucane wrote:
Add support for series. Series are groups of patches sent as one
bundle. For example:
It looks like patch 4 didn't hit the list.
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
On 14/09/16 16:38, Johannes Berg wrote:
That would be before the redirect though, no? Also, every page (while
Yes it would be.
logged in) loads the n_todo_pages(), and that takes virtually no time
at all.
Good point...
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel
nce.
A quick look at the code says that the todo list views call
.todo_patches() on every single project, which could be a bit slow.
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
___
Patchwork mail
aps series authors, etc. to be able to give series
names in patchwork. I don't really mind whether this attaches to a
Series or to a SeriesRevision.
I realise this makes the models a bit more heavy-weight.
Thoughts?
I like this idea quite a lot.
--
Andrew Donnellan OzLabs, ADL Ca
gt;
Co-authored-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
Please Cc me on tags.
Reviewed-by: Andy Doan <andy.d...@linaro.org>
---
v2:
- Resolve issue with REST API (Andrew Donnellan)
Um... this hasn't been fixed at all.
I'm working on proper REST support.
- Use mor
On 10/10/16 09:36, Stephen Finucane wrote:
This field was unused and has been for a long time (pre-0.9.0).
Signed-off-by: Stephen Finucane <step...@that.guru>
LGTM!
Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
--
Andrew Donnellan OzLabs,
it to the list again.
I assume it's
https://github.com/stephenfin/patchwork/commit/8a7d483e96c6dd52ef6de2ac4a8df37f39df37c2.
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
___
Patchwork
On 11/10/16 11:51, Russell Currey wrote:
- no series in the patch API at all. This could probably be implemented a few
different ways, but having no series at all is limiting
I'm looking at this currently.
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com
On 16/10/16 23:50, Stephen Finucane wrote:
It is now possible to parse and store series, so do just that.
The parsing at the moment is based on both RFC822 headers and
subject lines.
Signed-off-by: Stephen Finucane <step...@that.guru>
One minor issue below.
Reviewed-by: Andrew Don
string so doesn't
need double escaping. It's been a while since I've touched regexes in
Python...
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
___
Patchwork mailing list
Patchwork@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/patchwork
On 23/11/16 18:01, Andrew Donnellan wrote:
When generating an mbox for a patch with tags in the original commit
message, e.g.:
Example patch
This patch is awesome!
Signed-off-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
Acked-by: Russell Currey <rus...@r
When generating an mbox for a patch with tags in the original commit
message, e.g.:
Example patch
This patch is awesome!
Signed-off-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
Acked-by: Russell Currey <rus...@russell.cc>
the tags from the original email ar
=self.kwargs['pk'])
+
This should be:
+if 'pk' in self.kwargs:
+try:
+query = query.filter(id=int(self.kwargs['pk']))
+except (ValueError, Project.DoesNotExist):
+query = query.filter(linkname=self.kwargs['pk'])
--
Andrew Donnellan
at
https://github.com/ajdlinux/patchwork/tree/series-api-applied. No
guarantees it's correct.
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
___
Patchwork mailing list
Patchwork@lists.ozlabs.org
ium>2.0,<3.0
djangorestframework>=3.4,<3.5
-drf-nested-routers>=0.11.1,<0.12
Why are we removing this here?
+django-filter>=0.15,<0.16
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
reply to the RFC version of this
patch. Same comments apply here though.
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
___
Patchwork mailing list
Patchwork@lists.ozlabs.org
https://lists.ozla
On 31/10/16 17:08, Daniel Axtens wrote:
Looks good to me, thanks for making the fixups I asked for.
Reviewed-by: Daniel Axtens <d...@axtens.net>
Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
I think now every patch in the series has >= 1 review!
SHIP I
On 11/12/16 22:39, Thomas Monjalon wrote:
The List-Id header is retrieved from the Project object.
Fixes #53
Signed-off-by: Thomas Monjalon <thomas.monja...@6wind.com>
Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
---
patchwork/views/__init__.py | 1 +
1 fil
On 21/11/16 14:17, Andrew Donnellan wrote:
On 21/11/16 11:39, Russell Currey wrote:
Do you know if there's a way to get a reverse ordering of entries in
the REST
API? For example in the patches API each "page" has 30 entries, and
you can get
the latest page with ?page=last - but
of the filter series currently.
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
___
Patchwork mailing list
Patchwork@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/patchwork
stinfo/patchwork
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
___
Patchwork mailing list
Patchwork@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/patchwork
On 30/06/17 15:37, Daniel Axtens wrote:
Ah yes, sorry, you do.
I just downloaded it into the source dir and set PATH so py-afl-fuzz
could find it.
apt-get install --no-install-recommends afl works too :)
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM
docker/entrypoint.sh /usr/local/bin/entrypoint.sh
+RUN apt-get install -y cython cython3; pip3 install python-afl; pip install
python-afl
+
Do you need afl-fuzz itself as well?
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia L
On 03/07/17 16:04, Daniel Axtens wrote:
I'm up to my eyeballs in kernel networking code, so I'd really
appreciate that.
My envy for your current circumstances is limited...
Will do that this evening.
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM
Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
On 01/07/17 14:28, Daniel Axtens wrote:
Also picked up with afl-fuzz.
Signed-off-by: Daniel Axtens <d...@axtens.net>
---
patchwork/parser.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/patchwo
hould also merge this fix
to work around it.
dja - I'm happy to write this up and file it if you haven't already?
Andrew
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
___
Patchwo
On 03/07/17 15:31, Andrew Donnellan wrote:
So we should report this bug upstream, but we should also merge this fix
to work around it.
Oh, and this fix is, obviously:
Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
--
Andrew Donnellan OzLabs, ADL Ca
We accidentally broke the updating of tag counts for tags in comments, and
we didn't notice for quite a while.
Add a test for this.
Signed-off-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
---
patchwork/tests/test_parser.py | 37 ++---
1 file chang
comments")
Signed-off-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
---
patchwork/models.py | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/patchwork/models.py b/patchwork/models.py
index 56daea1..f8d2472 100644
--- a/patchwork/models.py
+++ b/patchwork/mode
and authenticate to API
endpoints. Enable this support and add some tests to validate correct
behavior.
Signed-off-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
Signed-off-by: Stephen Finucane <step...@that.guru>
Thanks for respinning this, was meaning to do so this coming week but
computers with slow mechanical hard
drives which take just a bit longer. Increase the second timeout from 15
seconds to 60 seconds, testing every 5 seconds.
Cc: Daniel Axtens <d...@axtens.net>
Signed-off-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
---
tools/docker/entrypoint.sh | 9
token support and add options to the user profile view to view
or regenerate tokens.
Signed-off-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
---
This is an RFC; I haven't written any tests or documentation, UI's a bit
ugly, need to split patches.
---
patchwork/settings/b
quest.user is actually the bundle owner.
Found by code inspection.
Fixes: 0b4f508a8438 ("views: Allow use of basic auth for bundle mboxes")
Signed-off-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
---
Given this is a (very, very, very minor) security issue, this shou
Add some tests to check that owners can view their private bundles while
other authenticated users can't.
Signed-off-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
---
I'm not very familiar with writing Django tests, please flame away
---
patchwork/tests/test_bundles.p
api/rest.rst gives an example of how to POST parameters to the PatchDetail
view at api/patches/. However, the endpoint in question doesn't
support POST - you need to use PUT or PATCH. Change it to PATCH.
Signed-off-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
---
I have no idea w
On 30/05/17 16:26, Russell Currey wrote:
What exactly does BA get used for at the moment?
REST requests that update status, e.g. sending a PATCH request on a
patch to change status from "new" to "under-review", or something like that.
--
Andrew Donnellan
-tested code.
Signed-off-by: Stephen Finucane <step...@that.guru>
One comment below
Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
---
We should probably look at integrating Django Compressor in a future
release, as the number of JS files we have is slowly increasing. Wor
Acked-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
On 10/06/17 03:25, Stephen Finucane wrote:
Signed-off-by: Stephen Finucane <step...@that.guru>
---
docs/api/rest.rst | 23 +++
1 file changed, 19 insertions(+), 4 deletions(-)
diff --git a/docs/api/res
and authenticate to API
endpoints. Enable this support and add some tests to validate correct
behavior.
Signed-off-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
Signed-off-by: Stephen Finucane <step...@that.guru>
Changes from my RFC (that I spotted on first reading):
* add to
when polling.
Signed-off-by: Aaron Conole <acon...@bytheb.org>
---
It should be noted that my motivation for this is to implement a git-pw
event poll command for CI integration.
If you think there's a better way of achieving this, let me know.
You should check out Snowpatch: Andrew Don
d the user to be a maintainer for the time being,
it's a bit annoying to have to ask the patchwork admin to add a new
maintainer though.
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
___
Patchwo
somewhere in
the frontend, rather than requiring admins. But yes, I get your point.
Personally, I think we can keep things as they are now and look towards 2.1
_if_ this is requested by real world Patchwork maintainers. Until then, as
before, YAGNI.
Agreed.
--
Andrew Donnellan O
lasses appear correct
Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
---
patchwork/parser.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/patchwork/parser.py b/patchwork/parser.py
index 3ab4eb3d2011..19ed7ca4e315 100644
--- a/patchwork/parser.py
+++
ge all those into one except block.
Regardless,
Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
---
patchwork/parser.py | 25 -
1 file changed, 24 insertions(+), 1 deletion(-)
diff --git a/patchwork/parser.py b/patchwork/parser.py
index 203e11584504..
s good.
Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
---
patchwork/parser.py | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/patchwork/parser.py b/patchwork/parser.py
index 4903aa8237e6..3ab4eb3d2011 100644
--- a/patchwork/parser.py
+++
On 28/06/17 16:55, Daniel Axtens wrote:
This is just a matter of correctly closing files we open.
Signed-off-by: Daniel Axtens <d...@axtens.net>
Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
---
patchwork/management/commands/parsearchive.py | 1 +
pat
viewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
---
patchwork/parser.py | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/patchwork/parser.py b/patchwork/parser.py
index 19ed7ca4e315..032af8a7be7c 100644
--- a/patchwork/parser.py
+++ b/patchwork/parser.py
@@
On 28/06/17 17:48, Daniel Axtens wrote:
The db limit is 255: we need to make sure we don't pass anything
longer in or it will throw an exception.
Signed-off-by: Daniel Axtens <d...@axtens.net>
Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
---
patchwork/p
Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
On 28/06/17 17:48, Daniel Axtens wrote:
The charset guessing algorithm doesn't work if it has to guess
multiple charsets, as it overwrites the payload with None.
Signed-off-by: Daniel Axtens <d...@axtens.net>
---
patchwo
() should return None, and thus
clean_header() should return None. We then need to plumb that
through.
Signed-off-by: Daniel Axtens <d...@axtens.net>
All looks good
Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
---
patchwork/pa
options['list_id'])
if result:
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
___
Patchwork mailing list
Patchwork@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/patchwork
was a
massive help in getting 2.0 out of the door, and I look forward to continuing
to work with him on future improvements over the coming months and years.
Thanks, Daniel!
Daniel is a 100% excellent person and I'm sure he'll be an excellent
maintainer too.
Thanks for all your work Daniel!
--
Andrew
On 27/08/17 21:37, Jeremy Kerr wrote:
OK, we're back up now. Please let me know if anything looks amiss.
I'm seeing a 500 immediately upon login at
https://patchwork.ozlabs.org/user/...
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
On 28/08/17 10:02, David Miller wrote:
I cannot change the state of any patch, which means I can't get any
work done at all today.
I've tried to log out and log back in again, same problem.
Now that jk has fixed user login, I can change the state of my patches fine.
--
Andrew Donnellan
Similar to what we already do on the patch list page, display the patch ID
on the patch detail page and make it a click-to-copy button.
Closes: #115 ("Show copy-able patch ID ("mpe mode") on patch detail page")
Signed-off-by: Andrew Donnellan <andrew.donnel...@au1.
behaviour by
default.
Suggested-by: Michael Ellerman <m...@ellerman.id.au>
Closes: #142 ("Ability to add tags that don't also have a column in the UI")
Signed-off-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
---
patchwork/fixtures/default_tags.xml | 5 -
@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/patchwork
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
___
Patchwork mailing list
Patchwork@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/patchwork
On 26/09/17 15:37, Andrew Donnellan wrote:
Currently looking at this.
For the ozlabs.org case, I'm also looking at getting the patch
backported straight into Debian.
Asked around on IRC - it seems that upstream's backporting policy is
quite restrictive when it comes to anything that's
= 2 AND
"patchwork_patch"."state_id" = 1) ORDER BY
"patchwork_submission"."date" ASC
These appear to be a result of pwclient list operations. We *do not*
need content/headers/diff in this case - so do not fetch them as it
is incredibly expensive - querie
at least). I can chase this up if no one else fancies
doing it. I am also happy to add this to the documentation until that happens.
Currently looking at this.
For the ozlabs.org case, I'm also looking at getting the patch
backported straight into Debian.
--
Andrew Donnellan
behaviour by
default.
Suggested-by: Michael Ellerman <m...@ellerman.id.au>
Closes: #142 ("Ability to add tags that don't also have a column in the UI")
Signed-off-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
---
v1->v2:
- fix 80 column limit in models.py
- add t
e tokens")
Signed-off-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
---
patchwork/templates/patchwork/profile.html | 2 ++
patchwork/views/user.py| 2 ++
2 files changed, 4 insertions(+)
diff --git a/patchwork/templates/patchwork/profile.html
b/patchwork/templa
On 19/12/17 16:41, Andrew Donnellan wrote:
In profile.html, if settings.ENABLE_REST_API == False, trying to render a
link to the generate_token page will raise a NoReverseMatch exception, so
we shouldn't render that. In any case, if the REST API is disabled, we
really shouldn't render the API
Signed-off-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
---
docs/development/contributing.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/development/contributing.rst
b/docs/development/contributing.rst
index 0cab79e..8988c9f 100644
--- a/docs/devel
On 19/12/17 16:32, Andrew Donnellan wrote:
Add a field, show_column, to the Tag model to determine whether the tag
gets a tag count column in the patch list view. This allows the creation of
tags that will be collated when generating mboxes but won't take up space
in the patch list.
No-one
= content.replace('\r\n', '\n')
Shouldn't this go before the removal of signatures?
Good point
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
___
Patchwork mailing list
Patchwork@lists.ozlabs.org
htt
On 08/01/18 18:49, Andrew Donnellan wrote:
On 08/01/18 18:46, Andrew Donnellan wrote:
When using Python 2, an incoming email that uses CRLF line endings won't
have the line endings converted by the email parser. This means that the
regex to detect pull request emails will fail to match.
Clean
need to resubmit) -
Thunderbird also saves with CRLF line endings.
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
___
Patchwork mailing list
Patchwork@lists.ozlabs.org
https://lists.ozlabs.org
Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
On 18/01/18 06:39, Stephen Finucane wrote:
Make the regex case insensitive to catch both 'git' and 'Git'.
Signed-off-by: Stephen Finucane <step...@that.guru>
Fixes: #159
---
patchwork/parser.py
On 29/01/18 12:41, Daniel Axtens wrote:
From: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
When using Python 2, an incoming email that uses CRLF line endings won't
have the line endings converted by the email parser. This means that the
regex to detect pull request emails will fail to
to
run our tests with...
Andrew
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
___
Patchwork mailing list
Patchwork@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/patchwork
--
Andrew
is happens.
Many apologies for the inconvenience!
Andrew
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
___
Patchwork mailing list
Patchwork@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/patchwork
here's anything obviously
wrong with that particular message ID - it appears to parse fine.
jk, any idea whether there's something particular about the ozlabs.org
instance that could be causing it to drop these patches?
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel.
Signed-off-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
---
patchwork/models.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/patchwork/models.py b/patchwork/models.py
index 3bf7c72dbe08..a41a5d882cca 100644
--- a/patchwork/models.py
+++ b/patchwork/models.py
@@ -442,6
Signed-off-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
---
patchwork/models.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/patchwork/models.py b/patchwork/models.py
index 3bf7c72dbe08..a41a5d882cca 100644
--- a/patchwork/models.py
+++ b/patchwork/models.py
@@ -442,6
Apologies for all the noise, you'll know why soon :)
On 06/02/18 17:53, Andrew Donnellan wrote:
Signed-off-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
---
patchwork/models.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/patchwork/models.py b/patchwork/models.py
Final one! I promise!
Signed-off-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
---
patchwork/models.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/patchwork/models.py b/patchwork/models.py
index 3bf7c72dbe08..f786a6107357 100644
--- a/patchwork/models.py
+++ b/patchwork/mod
Signed-off-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
---
patchwork/models.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/patchwork/models.py b/patchwork/models.py
index 3bf7c72dbe08..a41a5d882cca 100644
--- a/patchwork/models.py
+++ b/patchwork/models.py
@@ -442,6
Signed-off-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
---
patchwork/models.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/patchwork/models.py b/patchwork/models.py
index 3bf7c72dbe08..f786a6107357 100644
--- a/patchwork/models.py
+++ b/patchwork/models.py
@@ -442,6
this on for LinuxPPC...
Apologies for the noise on the list as we tested this setup!
Thanks to Joel Stanley for helping us with Jenkins setup, and a certain
bookstore-turned-cloud-provider for having a free tier of VMs for us to
run our tests with...
Andrew
--
Andrew Donnellan OzLabs
tches were properly
recorded. The problem is frequent enough that we would have noticed.
We have, anecdotally, noticed some regressions in database performance
in patchwork 2.0 which might increase the likelihood of hitting race
conditions. Hmm.
--
Andrew Donnellan OzLabs, AD
ious* python bug that this exposes: whitespace-only
headers cause an index error!
Signed-off-by: Daniel Axtens <d...@axtens.net>
Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ib
name: # use the latest provided name
person.name = name
person.save()
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
___
Patchwork mailing list
Patchwork@lists.ozla
en bug with a FIXME for searchability? Logging it is a
great idea.
Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com>
---
patchwork/parser.py | 23 +--
1 file changed, 21 insertions(+), 2 deletions(-)
diff --git a/patchwork/parser.py b/patchwork/parser.py
index
, but it's worth noting that as
always I'm not at OzLabs any more :)
incorrect, you're no longer at *IBM* any more ;)
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
___
Patchwork mailing list
1 - 100 of 206 matches
Mail list logo
