Thanks, patch applied.
On Thu, Mar 8, 2018 at 6:00 PM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:
> Thank you Joao
>
> Regards,
> Murtuza
>
>
> On Thu, Mar 8, 2018 at 10:19 PM, Joao De Almeida Pereira <
> jdealmeidapere...@pivotal.io> wrote:
>
>> Hello Murtuza/Dave,
>>
>>
Thank you Joao
Regards,
Murtuza
On Thu, Mar 8, 2018 at 10:19 PM, Joao De Almeida Pereira <
jdealmeidapere...@pivotal.io> wrote:
> Hello Murtuza/Dave,
>
> Nice splitting of some of the functionality into functions, removing some
> of the complexity of the initial function. Good job.
>
> I made
Hi Dave,
Please find updated patch.
--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Thu, Mar 8, 2018 at 6:10 PM, Dave Page wrote:
> Can you rebase this please?
>
> Thanks.
>
> On Thu, Mar 8, 2018 at 9:00 AM,
Can you rebase this please?
Thanks.
On Thu, Mar 8, 2018 at 9:00 AM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:
> Hi Dave,
>
> Please find updated patch & updated test case to cover that as well.
>
>
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB:
Hi Dave,
Please find updated patch & updated test case to cover that as well.
--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Wed, Mar 7, 2018 at 9:59 PM, Dave Page wrote:
> Hi
>
> On Wed, Mar 7, 2018 at 2:59
Hi
On Wed, Mar 7, 2018 at 2:59 PM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:
> Hi Dave,
>
> PFA updated patch.
>
>
Using your example on the ticket, I added a "character varying (32)" column
with NOT NULL to the table. When I then edit the column, and turn off NOT
NULL
Hi Dave,
PFA updated patch.
--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Wed, Mar 7, 2018 at 6:14 PM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:
>
> On Wed, Mar 7, 2018 at 6:12 PM, Dave Page
On Wed, Mar 7, 2018 at 6:12 PM, Dave Page wrote:
> Hi
>
> On Tue, Mar 6, 2018 at 4:06 PM, Joao De Almeida Pereira <
> jdealmeidapere...@pivotal.io> wrote:
>
>> Hi Murtuza,
>>
>> The code change works, and I passed the patches through our pipeline and
>> everything is green.
>>
Hi
On Tue, Mar 6, 2018 at 4:06 PM, Joao De Almeida Pereira <
jdealmeidapere...@pivotal.io> wrote:
> Hi Murtuza,
>
> The code change works, and I passed the patches through our pipeline and
> everything is green.
> Personally I would love this bug fixes to have refactored the function
> into
Hi Murtuza,
The code change works, and I passed the patches through our pipeline and
everything is green.
Personally I would love this bug fixes to have refactored the function into
smaller chunk and made it more readable so that the next time someone need
to check out a problem in the same area
Hi,
PFA patch to fix the issue in Table node where wrong sql was generated
while altering column.
--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
RM_2989.diff
Description: Binary data
fix_table_node_PEP8.diff
Description: Binary data
11 matches
Mail list logo