Re: [pgAdmin4][Patch]: Dashboard requests don't stop even after closing the panel

2017-07-28 Thread Dave Page
ile. > Please find the attached patch for the same. > > Thanks, > Khushboo > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgAdmin4][Patch]: RM_2596 - Query tool not working in Desktop Runtime on Mac OS X

2017-07-28 Thread Dave Page
; Please find attached patch and review. > > Thanks, > Surinder > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

2017-07-28 Thread Dave Page
On Fri, Jul 28, 2017 at 12:24 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > On Fri, Jul 28, 2017 at 4:11 PM, Dave Page <dp...@pgadmin.org> wrote: > >> Hi >> >> I took a quick look at this and have a couple of thoughts:

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

2017-07-28 Thread Dave Page
; EnterpriseDB: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> On Tue, Jul 25, 2017 at 10:56 AM, Shirley Wang <sw...@pivotal.io> wrote: >> >>> >>>> On Mon, Jul 24, 2017 at 8:11 PM, Dave Page <dp...@pgadmin.org> wrote: &

Re: [pgAdmin4][Patch]: Fixed RM #2603 - Import/Export File issues

2017-07-28 Thread Dave Page
the File Control once gets an error > 2. The encoding is not in alphabetical order > > Thanks, > Khsuhboo > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: Unified server/desktop config

2017-08-17 Thread Dave Page
7 AM, Surinder Kumar < >> surinder.ku...@enterprisedb.com> wrote: >> >>> Sure, I will update. >>> >>> On Wed, Aug 9, 2017 at 11:17 AM, Dave Page <dp...@pgadmin.org> wrote: >>> >>>> Please update the patch :-) >>>

pgAdmin 4 commit: Revert "Open query tool and debugger windows in new t

2017-07-07 Thread Dave Page
Revert "Open query tool and debugger windows in new tabs by default." This reverts commit 1a6fe946ce69736a4b9af8bcd79568f907fa383a. This is going to break the regression tests, so reverting it for now. Branch -- master Details ---

pgAdmin 4 commit: Fix handling of CREATE TABLE OF . Fixes #2534

2017-07-07 Thread Dave Page
Fix handling of CREATE TABLE OF . Fixes #2534 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d151bdb4cd9b6038864dc9596d279860628cb70f Author: Harshal Dhumal Modified Files --

Re: [RM2534][pgAdmin4] Fix issues related to table OF TYPE property.

2017-07-07 Thread Dave Page
ndia: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

pgAdmin 4 commit: Fix alert animation on IE11

2017-07-07 Thread Dave Page
Fix alert animation on IE11 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=08e874a0266e56f07ec61cbeed1173c249a2311f Author: Murtuza Zabuawala Modified Files --

pgAdmin 4 commit: Open query tool and debugger windows in new tabs by d

2017-07-07 Thread Dave Page
Open query tool and debugger windows in new tabs by default. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1a6fe946ce69736a4b9af8bcd79568f907fa383a Modified Files -- web/pgadmin/tools/debugger/__init__.py | 2 +-

Re: [pgAdmin4]: Webpacking of static JS/CSS

2017-07-12 Thread Dave Page
com> wrote: >>>>> On Tue, Jul 11, 2017 at 10:18 PM, Robert Eckhardt <reckha...@pivotal.io> >>>>> wrote: >>>> >>>>> The last email on this chain from Surinder says that it isn't working on >>>>> IE and he will submit ano

Re: More RHEL 6 build issues

2017-07-12 Thread Dave Page
Hi On Tue, Jul 11, 2017 at 5:40 PM, Devrim Gündüz <dev...@gunduz.org> wrote: > > Hi Dave, > > On Tue, 2017-07-11 at 12:26 +0100, Dave Page wrote: > > Anyway; the attached patch fixes the issue for me. I wonder if this is > some > > CentOS weirdness... > >

Re: pgadmin-for-web is going nowhere

2017-07-14 Thread Dave Page
ew, if any of which were setup with the help of our mailing lists, so it's presumably not that hard to do. Either that or the Docker guys have thicker skins than the Project Atomic guys :-) -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgAdmin4]: Webpacking of static JS/CSS

2017-07-17 Thread Dave Page
sion/javascript/slickgrid/event_handlers/handle_query_output_keyboard_event_spec.js:6411 PhantomJS 2.1.1 (Mac OS X 0.0.0) ERROR Error: Cannot find module "jquery" at regression/javascript/sqleditor_utils_spec.js:125 PhantomJS 2.1.1 (Mac OS X 0.0.0) ERROR Error: Cannot find module "jquery" at regression/javascript/sqleditor_utils_spec.js:125 PhantomJS 2.1.1 (Mac OS X 0.0.0) ERROR Error: Cannot find module "jquery" at pgadmin/static/bundle/slickgrid.js:1008 PhantomJS 2.1.1 (Mac OS X 0.0.0) ERROR Error: Cannot find module "jquery" at pgadmin/static/bundle/slickgrid.js:1008 -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: pgAdmin 4 v1.6 Released!

2017-07-17 Thread Dave Page
lse I need to check... > In the web/ subdirectory of the installation, you should find a file called config.py. Please create a file called config_local.py in the same directory, containing the following lines (excluding the lines) : from config import * # Debug mode DEBUG = True # Log

pgAdmin 4 commit: Show tablespace on partitions. Fixes #2551

2017-07-17 Thread Dave Page
Show tablespace on partitions. Fixes #2551 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=07aa74eaf56db72eab55dd735c710a4796abd669 Author: Harshal Dhumal Modified Files --

Re: [RM2551][pgAdmin4] show tablespace on partitions.

2017-07-17 Thread Dave Page
are Engineer* > > EnterpriseDB India: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

2017-07-17 Thread Dave Page
er only - regular users should be able to cancel their own queries. - On PG10, background workers are also shown in the dashboard. Should we prevent attempts to cancel their work (they'll fail anyway I believe). Thanks! -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: pgadmin-for-web is going nowhere

2017-07-17 Thread Dave Page
On Fri, Jul 14, 2017 at 7:17 PM, Josh Berkus <j...@berkus.org> wrote: > On 07/14/2017 01:01 AM, Dave Page wrote: > > > Setting up in server mode by following those docs takes just a few > minutes. > > > > > > Six months ago, I jumped on this with the goa

pgAdmin 4 commit: Fix proxy support with Qt 5.9+

2017-07-11 Thread Dave Page
Fix proxy support with Qt 5.9+ Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=374bf79911c5da6cd46fbf1b959fdd7ce44bceca Modified Files -- runtime/pgAdmin4.cpp | 5 + 1 file changed, 5 insertions(+)

Re: More RHEL 6 build issues

2017-07-11 Thread Dave Page
On Tue, Jul 11, 2017 at 12:09 PM, Devrim Gündüz <dev...@gunduz.org> wrote: > > Hi, > > Sorry, I missed this part: > > On Tue, 2017-07-11 at 11:44 +0100, Dave Page wrote: > > It was fixed in the code: > > > > # HTMLMIN doesn't work wi

Re: Windows testing required: Updated runtime

2017-07-11 Thread Dave Page
t. > > > > Happy to test > > > > Thanks > > > > Mike > > > > *From:* Dave Page [mailto:dp...@pgadmin.org] > *Sent:* 11 July 2017 13:11 > *To:* McDonaldR > *Cc:* pgadmin-hackers; pgAdmin Support > *Subject:* Re: Windows testing required: Upd

Re: More RHEL 6 build issues

2017-07-11 Thread Dave Page
ask_htmlmin.py", > line 1, in > from htmlmin.main import minify > ImportError: No module named main > It was fixed in the code: # HTMLMIN doesn't work with Python 2.6. if not config.DEBUG and sys.version_info >= (2,7): HTMLMIN(app) Though, we do have an unconditiona

pgAdmin 4 commit: Straighten line

2017-07-11 Thread Dave Page
Straighten line Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=68a6c496d9648df2c002f85ad42d34850f773b11 Modified Files -- web/pgadmin/dashboard/static/img/welcome_logo.png | Bin 22526 -> 22603 bytes 1 file changed, 0

Re: Windows testing required: Updated runtime

2017-07-11 Thread Dave Page
ng) > > > 3. Will there be a web install package. > There is a source tarball and Python wheel available at http://developer.pgadmin.org/~dpage/1.6/ Thanks! > > > Thanks > > > > Mike > > > > > > *From:* Dave Page [mailto:dp...@pgad

Re: [pgadmin-hackers][pgaweb][patch] Website patch to add SCSS

2017-07-11 Thread Dave Page
sions.json - s/PGAdmin/pgAdmin - We can remove the part about using sqlite for the DB. This is a Postgres project after all :-) Thanks. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: Windows testing required: Updated runtime

2017-07-11 Thread Dave Page
> Expanding elements in tree is snappy. > > > > I’ll test it some more tomorrow with connections to a production database. > > > > Ross > > > > *From:* Dave Page [mailto:dp...@pgadmin.org] > *Sent:* 11 July 2017 13:52 > *To:* Mike Surcouf > *Cc:* McDonaldR

Re: Windows testing required: Updated runtime

2017-07-11 Thread Dave Page
version that > worked).and all is ok again > > > > But I guess it works on your machine so it must be something wrong with my > setup > Hard to see what though, if it's not the zoom. I have tested on Windows 7 as well as Windows 10, so it *should* work. -- Dave Page Blog: http:

Re: Windows testing required: Updated runtime

2017-07-11 Thread Dave Page
nd that your end users may have issues you don’t. > There are so many environmental factors to consider. > Oh, after over 20 years in IT support and software development, I've become painfully aware of that :-). > > > Mike > > > > *From:* Dave Page [mailto:dp...@pgadmin.org]

pgAdmin 4 commit: Fix a compiler error with older compilers.

2017-07-11 Thread Dave Page
Fix a compiler error with older compilers. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=de06e63334ba041df6de4ba5a91e1650a9d8f024 Author: Mammoth Power Modified Files -- runtime/splash.png | Bin 28131 ->

pgAdmin 4 commit: Use the correct font for alerts on IE.

2017-07-10 Thread Dave Page
Use the correct font for alerts on IE. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=907c5fe1984ead9d1df1c7d0dbe458f9ab607488 Author: Murtuza Zabuawala Modified Files --

Re: [pgadmin4][patch] fix history panel on ie11

2017-07-10 Thread Dave Page
ectly on IE11. We had to downgrade the version of bowser to > 1.6.1 until the relevant pull request to react-split-pane has been accepted. > > Thanks! > Sarah & Rob > > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

pgAdmin 4 commit: Fix alignment of Object > delete/drop & properties ic

2017-07-10 Thread Dave Page
Fix alignment of Object > delete/drop & properties icons Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2bfe640a081cc59a22453c3db847817406cb6651 Author: Surinder Kumar Modified Files --

Re: [pgAdmin4][Patch]: Fixed #2550 declarative partitioning - drop/delete and drop cascade is not working for partition table

2017-07-10 Thread Dave Page
9517 <+91%2020%203058%209517>Mobile: +91 976-788-8246 > <+91%2097678%2088246>* > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

pgAdmin 4 commit: Fix history font on IE.

2017-07-10 Thread Dave Page
Fix history font on IE. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2dfa6223574d6a16bc5144462a1e440df80649d4 Modified Files -- web/pgadmin/static/scss/_typography.scss | 8 1 file changed, 4 insertions(+), 4

Re: [pgAdmin4]: Webpacking of static JS/CSS

2017-07-11 Thread Dave Page
values when >> needed? Or is it possible that we would get old content?) >> >> >>> *Taks remaining:* >>> >>> ​1. ​ >>> Fix local variables which are declared without using var, have to check >>> in each file >>> ​ by​

pgAdmin 4 commit: Ensure dependencies are packaged in the tarball

2017-07-11 Thread Dave Page
Ensure dependencies are packaged in the tarball Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6ad4a623c47154a2e3938805af52776039c23601 Modified Files -- pkg/src/build.sh | 19 +-- 1 file changed, 9 insertions(+),

Re: Windows testing required: Updated runtime

2017-07-07 Thread Dave Page
ere now, and we've made almost all the JS code static now so it avoids the templating engine, but there's still work to do to pack it all. Thanks. > > > Thanks > > > > Mike > > > > *From:* Dave Page [mailto:dp...@pgadmin.org] > *Sent:* 06 July 2017 15:59 &g

Re: Windows testing required: Updated runtime

2017-07-07 Thread Dave Page
> programfiles and restarted reinstalled. > > Also trying with AV disabled. > > Unfortunately I still get the same results. > > > > *From:* Mike Surcouf [mailto:mi...@surcouf.co.uk] > *Sent:* 07 July 2017 10:17 > *To:* 'Dave Page' > *Cc:* pgadmin-hackers; pgAdmin S

Re: Fix clear history option [pgAdmin4][RM2535]

2017-07-07 Thread Dave Page
* > > EnterpriseDB India: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

pgAdmin 4 commit: Enable pretty html output of our karma test results.

2017-07-07 Thread Dave Page
Enable pretty html output of our karma test results. While running yarn test:karma, visit localhost:9876/debug.html to see test output. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8646e9e404401478342ed44e41ed9fa009fe0e63 Author: Sarah

Re: [pgadmin-hackers][pgAdmin4][Patch] Make karma test results output to browser

2017-07-07 Thread Dave Page
st output. > > Thanks, > Matt and Sarah > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

pgAdmin 4 commit: Fix the formatting of the ROWS option for functions e

2017-07-07 Thread Dave Page
Fix the formatting of the ROWS option for functions etc. Fixes #2537 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=acd3568f064be65ec82d2b2e20189b7cf3df2fef Author: Murtuza Zabuawala Modified Files

pgAdmin 4 commit: Don't continually poll for graph data on the dashboar

2017-07-14 Thread Dave Page
Don't continually poll for graph data on the dashboard if the server is disconnected. Fixes #1165 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=da67963094e2bff82af536fc3f341cc7cd53356a Author: Khushboo Vashi

Re: [pgAdmin4][Patch]: Fixed RM #1165 - Too many request to update dashboard graphs when server is disconnected.

2017-07-14 Thread Dave Page
Thanks, patch applied. On Tue, Jul 11, 2017 at 5:12 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > please find the attached updated patch. > > Thanks, > Khushboo > > On Mon, Jul 10, 2017 at 6:54 PM, Dave Page <dp...@pgadmin.org> wrote

Re: [pgAdmin4][Patch] To fix the issue in privileges control

2017-07-14 Thread Dave Page
;>> for given role. >>> RM#1166 >>> >>> -- >>> Regards, >>> Murtuza Zabuawala >>> EnterpriseDB: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> >> > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgadmin-hackers] 10k Tables and more

2017-07-18 Thread Dave Page
. That's still an option of course, though I've yet to find anything better. A more generic solution might be to group tables if there are more than N - e.g. add an extra level into the hierarchy dynamically splitting them up into groups (which would probably also have to be dynamically

Re: [PATCH] Persist opened nodes in tree

2017-07-18 Thread Dave Page
code(b)};else{if("function"==typeof b)return; > +b&&"object"==typeof b&&(b=p.parse(p.stringify(b)))}c[a]=b;for(var > k=c.__jstorage_meta.CRC32,d=p.stringify(b),g=d.length,e= > 2538058380^g,h=0,f;4<=g;)f=d.charCodeAt(h)&255|(d. >

pgAdmin 4 commit: Add missing new files from the previous commit. Ooops

2017-07-18 Thread Dave Page
Add missing new files from the previous commit. Ooops. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6396b8ce1801ebb9b00013b5115ea7851ca094a7 Author: Surinder Kumar Modified Files --

Re: Testing out font changes in query editor tool

2017-07-18 Thread Dave Page
dd that as well? > > On Mon, Jul 17, 2017 at 5:55 AM Dave Page <dp...@pgadmin.org> wrote: > >> On Fri, Jul 14, 2017 at 5:06 AM, Murtuza Zabuawala <murtuza.zabuawala@ >> enterprisedb.com> wrote: >> >>> Hi Shirley, >>> >>> It's easy on t

Re: [RM2074][[RM2080]][pgAdmin4] handle large bytea and bytea[] data in datagrid

2017-07-18 Thread Dave Page
On Tue, Jul 18, 2017 at 2:40 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi Dave, > > On Tue, Jul 18, 2017 at 1:24 PM, Dave Page <dp...@pgadmin.org> wrote: > >> >> >> On Tue, Jul 18, 2017 at 8:26 AM, Harshal Dhumal < >> har

pgAdmin 4 commit: Refresh nodes correctly when there is a single child

2017-07-10 Thread Dave Page
Refresh nodes correctly when there is a single child that is updated. Fixes #2532 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ecd95141f3c89aa19e6723799c6cfe41db066d22 Author: Khushboo Vashi Modified

Re: [pgAdmin4][Patch]: Fixed #2532 - Left side tree: The node disappears on update if there is only one child exist for that category.

2017-07-10 Thread Dave Page
ategory. > > > Thanks, > Khushboo > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: pgagent build issue on SLES 12

2017-07-10 Thread Dave Page
On Mon, Jul 10, 2017 at 1:59 PM, Devrim Gündüz <dev...@gunduz.org> wrote: > > Hi Dave, > > On Mon, 2017-07-10 at 13:18 +0100, Dave Page wrote: > > What wxWidgets configs are available on that machine? > > wxWidgets-3_2-devel-3.1.0 > I have no idea if p

Re: [pgAdmin4][Patch] To fix "there is no disk..." warning in Windows

2017-07-10 Thread Dave Page
ool, you will get error. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

pgAdmin 4 commit: Handle un-mounted drives correctly on Windows. Fixes

2017-07-10 Thread Dave Page
Handle un-mounted drives correctly on Windows. Fixes #1999 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6d3d2cd458aa74c677559a3c3b3c2fb44da4aa6f Author: Murtuza Zabuawala Modified Files --

Re: pgagent build issue on SLES 12

2017-07-10 Thread Dave Page
all Stack (most recent call first): > CMakeLists.txt:95 (FIND_PACKAGE) > > and here is the CMakeOutput.log: > > https://www.gunduz.org/temp/pgagent-CMakeOutput.log > > Any hints how can I debug this? > What wxWidgets configs are available on that machine? -- Dav

Re: [pgAdmin4][Patch]: Fixed #2545 Partitioned table should be created using 'OF TYPE'

2017-07-10 Thread Dave Page
*Akshay Joshi* > *Principal Software Engineer * > > > > *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91 976-788-8246 > <+91%2097678%2088246>* > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

pgAdmin 4 commit: Handle partitioned tables created "OF TYPE". Fixes #2

2017-07-10 Thread Dave Page
Handle partitioned tables created "OF TYPE". Fixes #2545 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ed3cb7df417b3e0b4a1dc3da8d4224a09727412e Author: Akshay Joshi Modified Files --

pgAdmin 4 commit: Couple of typos in the release notes.

2017-07-10 Thread Dave Page
Couple of typos in the release notes. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7aa7ea0fe2eede85cbb95c3fe69bdbe6496b5cd8 Author: Harshal Dhumal Modified Files --

Re: [pgAdmin4][Patch]: Fixed RM #1165 - Too many request to update dashboard graphs when server is disconnected.

2017-07-10 Thread Dave Page
op trying to get data until I refresh the browser by clicking on another node that causes it to reload. If I then click back on the server node, it doesn't redraw the dashboard and start displaying new data upon reconnect. I have to change nodes again before it will respond to the re-connection. T

pgAdmin 4 commit: Bump version numbers prior to release.

2017-07-10 Thread Dave Page
Bump version numbers prior to release. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ea5dfe23a078080d98d8a549ff48efbdbc677974 Modified Files -- runtime/Info.plist | 4 ++-- runtime/pgAdmin4.pro | 2 +- web/config.py| 4

Re: [pgAdmin4][Patch] To fix the issue in Function, Procedure & Trigger Function modules

2017-07-07 Thread Dave Page
t is > disabled by default but once you change the value of "Returns a set?" > (under Options tab) to Yes while creating new function it gets enabled. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company

Re: pgAdmin 4 commit: Release notes for 1.6.

2017-07-10 Thread Dave Page
and friends > > > > > > > > > > -- > *Harshal Dhumal* > *Sr. Software Engineer* > > EnterpriseDB India: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On Mon, Jul 10, 2017 at 7:22 PM, Dave Page <dp...@pgadmin.org> wrote: &g

Re: [pgAdmin4][Patch]: To make session more secure in web mode

2017-07-20 Thread Dave Page
above scenarios, It is not > most necessary thing to include in our project but it will improve the > session security. > > On Thu, Jul 20, 2017 at 5:52 PM, Dave Page <dp...@pgadmin.org> wrote: > >> Hi >> >> On Thu, Jul 20, 2017 at 12:59 PM, Murtuza Zabuawala <

Re: Unified server/desktop config

2017-07-20 Thread Dave Page
gt; On Thu, Jul 20, 2017 at 10:22 PM, Murtuza Zabuawala <murtuza.zabuawala@ > enterprisedb.com> wrote: > >> Hi Dave, >> >> Partial patch for feature test got included in you patch :) >> >> >> On Thu, Jul 20, 2017 at 9:33 PM, Dave Page <dp...@pgadm

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

2017-07-20 Thread Dave Page
.. > > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On Thu, Jul 20, 2017 at 6:04 PM, Murtuza Zabuawala <murtuza.zabuawala@ > enterprisedb.com> wrote: > >> Hi Dave, >> >>

pgAdmin 4 commit: Add the Flask-Paranoid module for a little extra, wel

2017-07-20 Thread Dave Page
Add the Flask-Paranoid module for a little extra, well, paranoia in web mode. Fixes #2584 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=64f3a559abadd62b9c49b78e1a937191fb0253ef Author: Murtuza Zabuawala

Re: Build failed in Jenkins: pgadmin4-master-python27-feature #8

2017-07-19 Thread Dave Page
aster-python27-fe >> ature/8/display/redirect?page=changes> >> >> Changes: >> >> [Dave Page] Use client-side url_for in the sql editor and data grid >> modules. >> >> [Dave Page] Ensure revoked public privileges are displayed in the RE-SQL >>

Unified server/desktop config

2017-07-20 Thread Dave Page
anyone see if the patch breaks anything, or if I missed any side effects? Is it likely to break things during upgrades? I suspect so... so maybe this should prompt v2.0? I'd appreciate multiple reviews of this, as it could break things. Note that I haven't yet updated the docs. -- Dave Page

pgAdmin 4 commit: Remove debug logging of the URL map which is extremel

2017-07-20 Thread Dave Page
Remove debug logging of the URL map which is extremely long now, and not of a great deal of use. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=83ac1f3555066322077b1cdc212ee7ff74cf3322 Modified Files -- web/pgadmin/__init__.py |

Re: [pgadmin-hackers] [Design update] Style guide for pgAdmin4

2017-07-20 Thread Dave Page
On 20 Jul 2017, at 23:02, Shirley Wang wrote: >> >> Iirc, we did some back and forth over that about 18 months ago, as dialogues >> didn't look quite right without the bold - and I do think that it looks a >> little light on your mockup. I don't think there's a hard

pgAdmin 4 commit: Prevent the Werkzeug reloader from causing a "double

2017-07-21 Thread Dave Page
Prevent the Werkzeug reloader from causing a "double start" at init time. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a49a3103e298fcc4373856abe057dac09bc1df14 Author: Surinder Kumar Modified Files

pgAdmin 4 commit: Add an editorconfig file to help maintain coding stan

2017-07-21 Thread Dave Page
Add an editorconfig file to help maintain coding standards. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ede6765f6b2688719349f5d369123acd6c25dcd9 Author: Surinder Kumar Modified Files --

Re: [pgAdmin4][Patch]: Stop Flask from initialising service twice in Debug mode

2017-07-21 Thread Dave Page
N` is set to None, i.e. app is >> starting for the first time and then its value is changed to True. >> >> Please find attached patch. >> >> Thanks >> Surinder >> >> >> >> > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgadmin4][PATCH] Query History Arrow Navigation and Styling

2017-07-21 Thread Dave Page
ut stops it working if I *don't* click on the white area first. We need both I think :-) -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

pgAdmin 4 commit: Ensure arrow keys work correctly when the pane is foc

2017-07-21 Thread Dave Page
Ensure arrow keys work correctly when the pane is focused instead of the tab in the query tool history. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7182b5997627405449bdd0fed65aeb6de19c0a4f Author: Harshal Dhumal

Re: [pgAdmin4][Patch][RM_1918] : Implement the DB restriction field from pgAdmin III

2017-07-21 Thread Dave Page
com> wrote: > Hi, > > Please find attached patch for RM#1918 : Implement the DB restriction > field from pgAdmin III > > Thanks, > Atul > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgadmin4][PATCH] Query History Arrow Navigation and Styling

2017-07-21 Thread Dave Page
On Fri, Jul 21, 2017 at 12:34 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > > > On Jul 21, 2017 4:23 PM, "Dave Page" <dp...@pgadmin.org> wrote: > > > > On Fri, Jul 21, 2017 at 11:05 AM, Harshal Dhumal < > harshal.dhu...@enterprised

Re: [pgadmin4][PATCH] Query History Arrow Navigation and Styling

2017-07-21 Thread Dave Page
On Fri, Jul 21, 2017 at 11:05 AM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > On Fri, Jul 21, 2017 at 2:24 PM, Dave Page <dp...@pgadmin.org> wrote: > >> Hi >> >> On Fri, Jul 21, 2017 at 9:38 AM, Harshal Dhumal < >>

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

2017-07-21 Thread Dave Page
ll margin - however, I'm still not convinced that we don't need two keys for optimal behaviour of line commenting. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

2017-07-25 Thread Dave Page
On Tue, Jul 25, 2017 at 6:26 AM, Shirley Wang <sw...@pivotal.io> wrote: > >> On Mon, Jul 24, 2017 at 8:11 PM, Dave Page <dp...@pgadmin.org> wrote: >> >>> >>> >>> On Mon, Jul 24, 2017 at 3:28 PM, Shirley Wang <sw...@pivotal.io> wr

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

2017-07-26 Thread Dave Page
e. I'd also argue that >> attempting to maintain consistency across environments (IDEs, etc. ) is >> advantageous. This was the philosophy we were going with when enabling >> excel like behavior (also why I'm not fully happy with how it is today). >> >> -- Rob >> > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

pgAdmin 4 commit: Store the file dialog view on toggle.

2017-07-26 Thread Dave Page
Store the file dialog view on toggle. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=831c614a60725fb5cc116ee06bdea7bb477d1f2c Author: Harshal Dhumal Modified Files --

Re: [RM2579][pgAdmin4] Set default file listing layout as list instead of grid

2017-07-26 Thread Dave Page
On Wed, Jul 26, 2017 at 11:06 AM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > On Mon, Jul 24, 2017 at 4:23 PM, Dave Page <dp...@pgadmin.org> wrote: > >> Hi >> >> On Mon, Jul 24, 2017 at 11:34 AM, Harshal Dhumal < >>

pgAdmin 4 commit: Handle control visibility properly in javascript stri

2017-07-26 Thread Dave Page
Handle control visibility properly in javascript strict mode. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d1e7254fbd361f4e73ecfd9b0fa2fa69ad9820c5 Author: Khushboo Vashi Modified Files --

Re: [pgAdmin4][Patch]: Backform control visibility fix

2017-07-26 Thread Dave Page
Thanks, applied. On Tue, Jul 25, 2017 at 1:18 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to handle the control visibility even in > the javascript strict mode. > > Thanks, > Khushboo > -- Dave Page Blo

pgAdmin 4 commit: Update keyboard shortcuts per discussion. Also, make

2017-07-26 Thread Dave Page
Update keyboard shortcuts per discussion. Also, make the labels platform sensitive. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1fa9648a21c980c6ecdd5d87da64783b19dfab73 Author: Murtuza Zabuawala

Re: Build failed in Jenkins: pgadmin4-master-python26 #386

2017-07-26 Thread Dave Page
@pgadmin.org> >> wrote: >> >>> See <https://jenkins.pgadmin.org/job/pgadmin4-master-python26/38 >>> 6/display/redirect?page=changes> >>> >>> Changes: >>> >>> [Dave Page] Update keyboard shortcuts per discussion. Also, make the

pgAdmin 4 commit: Fixup tests following label changes.

2017-07-26 Thread Dave Page
Fixup tests following label changes. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=af26d983e5e20c64f0f73d22ebd998f54dff1e8a Author: Murtuza Zabuawala Modified Files --

pgAdmin 4 commit: Add controls and shortcuts for commenting/uncommentin

2017-07-19 Thread Dave Page
Add controls and shortcuts for commenting/uncommenting code in the SQL Editor. Fixes #2456. Take the opportunity to tidy up the menus and add access keys to appropriate buttons. Branch -- master Details ---

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

2017-07-19 Thread Dave Page
ptions for indent & unindent code in the same drop-down. >> 3) Updated shortcut documents accordingly. >> >> Please review. >> >> On Mon, Jul 17, 2017 at 3:05 PM, Dave Page <dp...@pgadmin.org> wrote: >> >>> Hi >>> >>> On Mon, Jul 17

Re: [pgAdmin4]: Webpacking of static JS/CSS

2017-07-19 Thread Dave Page
Load time ~2 sec on browser :) >> >> [image: Inline image 1] >> >> >> -- >> Regards, >> Murtuza Zabuawala >> EnterpriseDB: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> On Tue, Jul 18, 2017 at 9:01 PM, Dave Pag

Re: [pgAdmin4]: Webpacking of static JS/CSS

2017-07-19 Thread Dave Page
surinder.ku...@enterprisedb.com> wrote: > >> On Wed, Jul 19, 2017 at 4:27 PM, Dave Page <dp...@pgadmin.org> wrote: >> >>> That was a fun one to spot I'm sure! >>> >> ​Indeed, i had setup pgAdmin evn on Linux(as it works on Mac) and then i &g

pgAdmin 4 commit: Webpacking cleanups

2017-07-19 Thread Dave Page
Webpacking cleanups Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=dfa877262d67a9daaff2597d31217d9d3852 Author: Surinder Kumar Modified Files -- .../js/exclusion_constraint.js

Re: [pgAdmin4][Patch]: Improvise the treeview element selection

2017-07-24 Thread Dave Page
o eyes.[same as in pgAdmin3] >> >> Please find attached patch and review. >> >> Thanks, >> Surinder >> > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgadmin4][PATCH] Query History Arrow Navigation and Styling

2017-07-20 Thread Dave Page
ade these two patches so they both pass the linting test. > > Thanks, > Matt and João > > > On Thu, Jul 20, 2017 at 12:56 PM, Dave Page <dp...@pgadmin.org> wrote: > >> >> >> On Thu, Jul 20, 2017 at 2:18 PM, Joao De Almeida Pereira < >> jdealmeidap

Re: [pgadmin-hackers][pgaweb][patch] Update SCSS of styleguide

2017-07-20 Thread Dave Page
Thanks > Joao && Matt > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgadmin-hackers][patch]

2017-07-24 Thread Dave Page
ring this behavior back. > > Thanks > Joao & Matt > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

  1   2   3   4   5   6   7   8   9   10   >