Re: [pgadmin-hackers] Fix for issue RM1336 [pgadmin4]

Hi On Mon, Jul 4, 2016 at 3:00 PM, Harshal Dhumal wrote: > Hi, > > PFA updated patch for RM1336 and keyboard shortcuts file separately. > > This patch is same as last patch except I have removed keyboard shortcut > list from this patch. > > Also please see my

Re: [pgadmin-hackers] Fix for issue RM1336 [pgadmin4]

Hi, PFA updated patch for RM1336 and keyboard shortcuts file separately. This patch is same as last patch except I have removed keyboard shortcut list from this patch. Also please see my inline response below. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India:

Re: [pgadmin-hackers] Fix for issue RM1336 [pgadmin4]

Hi On Fri, Jul 1, 2016 at 11:10 AM, Harshal Dhumal wrote: > Hi, > > PFA patch > > This contains: > 1] All shortcuts' list which we are using in pgAdmin4. > 2] Fixed shortcut display tooltips. > > > -- > Harshal Dhumal > Software Engineer > > EnterpriseDB India:

Re: [pgadmin-hackers] Fix for issue RM1336 [pgadmin4]

Hi, PFA patch This contains: 1] All shortcuts' list which we are using in pgAdmin4. 2] Fixed shortcut display tooltips. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Jun 30, 2016 at 2:34 PM, Dave Page

Re: [pgadmin-hackers] Fix for issue RM1336 [pgadmin4]

Hi Harshal, On Thu, Jun 30, 2016 at 7:59 AM, Harshal Dhumal wrote: > Hi Dave, > > Somehow control key is mapped to Command key in Mac. So on Mac shortcuts are > Shift+Command+E, Shift+Command+X, Shift+Command+A OK, those work, but I think we need to take a step

Re: [pgadmin-hackers] Fix for issue RM1336 [pgadmin4]

Hi Dave, Somehow control key is mapped to Command key in Mac. So on Mac shortcuts are Shift+Command+E, Shift+Command+X, Shift+Command+A -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Jun 30, 2016 at 1:05 AM,

Re: [pgadmin-hackers] Fix for issue RM1336 [pgadmin4]

Hi On Wed, Jun 29, 2016 at 7:32 PM, Harshal Dhumal wrote: > Hi, > > Here is updated patch for RM1336 > > Fixed query tool shortcuts issue in Mac runtime and changed shortcut to show > "About" dialog in runtime from Ctrl+Shift+A > Alt+Shift+A I updated the

Re: [pgadmin-hackers] Fix for issue RM1336 [pgadmin4]

Hi, Here is updated patch for RM1336 Fixed query tool shortcuts issue in Mac runtime and changed shortcut to show "About" dialog in runtime from Ctrl+Shift+A > Alt+Shift+A -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL

Re: [pgadmin-hackers] Fix for issue RM1336 [pgadmin4]

Hi On Wed, Jun 29, 2016 at 7:05 PM, Harshal Dhumal wrote: > Hi, > > PFA upadated patch for RM1336 > > Issue fixed: Query tool shortcuts weren't working on mac runtime. Also > changed shortcut key for "Explain analyze" from Ctrl+Shift+A ---> > Alt+Shift+N as

Re: [pgadmin-hackers] Fix for issue RM1336 [pgadmin4]

Hi, PFA upadated patch for RM1336 Issue fixed: Query tool shortcuts weren't working on mac runtime. Also changed shortcut key for "Explain analyze" from Ctrl+Shift+A ---> Alt+Shift+N as Ctrl+Shift+A was conflicting with shortcut to show "about" dialog in runtime. -- *Harshal Dhumal*

Re: [pgadmin-hackers] Fix for issue RM1336 [pgadmin4]

On Mon, Jun 20, 2016 at 2:51 PM, Colin Beckingham wrote: > > On 20/06/16 09:33, Dave Page wrote: >> >> It's not that it's necessarily hard, it's that there are only 24 hours in >> the day to get things done. We've got a long list of improvements to make - >> some immediate

Re: [pgadmin-hackers] Fix for issue RM1336 [pgadmin4]

On 20/06/16 09:33, Dave Page wrote: It's not that it's necessarily hard, it's that there are only 24 hours in the day to get things done. We've got a long list of improvements to make - some immediate (i.e. in time for betaX - 2 being today in fact), others for GA and others for future

Re: [pgadmin-hackers] Fix for issue RM1336 [pgadmin4]

On Mon, Jun 20, 2016 at 2:29 PM, Adam Brusselback wrote: > I'm just wondering what the thought process is for making the shortcuts > configurable, or why that's going to be significantly hard? I find that to > be highly desirable feature, one of the reasons being

Re: [pgadmin-hackers] Fix for issue RM1336 [pgadmin4]

I'm just wondering what the thought process is for making the shortcuts configurable, or why that's going to be significantly hard? I find that to be highly desirable feature, one of the reasons being avoiding something like this from happening (with browser bindings). Some of us have other tools

Re: [pgadmin-hackers] Fix for issue RM1336 [pgadmin4]

OK, applied as-is for now. I guess all our shortcuts will probably end up being Ctrl+Shift+Something :-( On Mon, Jun 20, 2016 at 10:45 AM, Harshal Dhumal wrote: > Hi Dave, > > I tried to find unique shortcuts keys combination using function keys on > different

Re: [pgadmin-hackers] Fix for issue RM1336 [pgadmin4]

Hi Dave, I tried to find unique shortcuts keys combination using function keys on different platforms (windows, mac, linux ) but no success. Any combination of function keys with either of (or some of them together) Alt, Ctrl, Shift conflict with either browser functionality or with window

Re: [pgadmin-hackers] Fix for issue RM1336 [pgadmin4]

On Thu, Jun 16, 2016 at 3:28 PM, Ashesh Vashi wrote: > On Thu, Jun 16, 2016 at 5:10 PM, Dave Page wrote: >> >> On Thu, Jun 16, 2016 at 12:14 PM, Harshal Dhumal >> wrote: >> > Hi, >> > >> > As per my offline

Re: [pgadmin-hackers] Fix for issue RM1336 [pgadmin4]

On Thu, Jun 16, 2016 at 5:10 PM, Dave Page wrote: > On Thu, Jun 16, 2016 at 12:14 PM, Harshal Dhumal > wrote: > > Hi, > > > > As per my offline discussion with Ashesh; He is suggesting not to use > > Function keys as shortcuts. > > Why? That

Re: [pgadmin-hackers] Fix for issue RM1336 [pgadmin4]

On Thu, Jun 16, 2016 at 12:14 PM, Harshal Dhumal wrote: > Hi, > > As per my offline discussion with Ashesh; He is suggesting not to use > Function keys as shortcuts. Why? That is primarily what they are on the keyboard for. > And regarding configurable key

Re: [pgadmin-hackers] Fix for issue RM1336 [pgadmin4]

Hi, As per my offline discussion with Ashesh; He is suggesting not to use Function keys as shortcuts. And regarding configurable key options, I suspect It is going to be time consuming task, please let me know if you want me to start working it. Or can we keep current shortcuts from my last

Re: [pgadmin-hackers] Fix for issue RM1336 [pgadmin4]

Hi Hmm, I guess that's system dependent. What about Ctrl+F5? Or we bite the bullet and make it configurable. On Thu, Jun 16, 2016 at 11:47 AM, Harshal Dhumal wrote: > Hi Dave, > > Function keys won't work properly with browser as they already have > predefined

Re: [pgadmin-hackers] Fix for issue RM1336 [pgadmin4]

Hi Dave, Function keys won't work properly with browser as they already have predefined bindings. e.g. F5 for refresh (standard) F7 for Caret Browsing in firefox -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On

Re: [pgadmin-hackers] Fix for issue RM1336 [pgadmin4]

Thanks! On Thu, Jun 16, 2016 at 11:40 AM, Harshal Dhumal wrote: > Hi Dave, > > Ok, I'll change shortcut keys > > New shortcuts would be: > > Execute --> F5 > Explain -->F7 > Explain analyze --> Shift+F7 > > > > -- > Harshal Dhumal > Software Engineer > >

Re: [pgadmin-hackers] Fix for issue RM1336 [pgadmin4]

Hi Dave, Ok, I'll change shortcut keys New shortcuts would be: Execute --> F5 Explain -->F7 Explain analyze --> Shift+F7 -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Jun 16, 2016 at 4:03 PM, Dave

Re: [pgadmin-hackers] Fix for issue RM1336 [pgadmin4]

Hi, Can we not make them compatible with pgAdmin 3? Ctrl + Shift + E is significantly less convenient than F5. On Thu, Jun 16, 2016 at 11:28 AM, Harshal Dhumal wrote: > Hi, > > PAF patch for issue RM1336 > > Changes: Added keyboard shortcuts (static/non

[pgadmin-hackers] Fix for issue RM1336 [pgadmin4]

Hi, PAF patch for issue RM1336 Changes: Added keyboard shortcuts (static/non configurable) to some query tool operations. Execute --> Ctrl + Shift + E Explain -->Ctrl + Shift + X Explain analyze --> Ctrl + Shift + A Note: Keyboard shortcuts do not work if focus is set on any