Hi,
Please find attached updated patch for RM1720.
Also test this patch with updated test suite patch which Navnath would be
sending.
--
*Harshal Dhumal*
*Software Engineer*
EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Wed, Sep 21, 2016 at 8:39 PM, Da
Hi,
PFA patch to fix the issue where pgAdmin4 was throwing error when user
clicks on Statistics tab when using PG9.6.
RM#1719
*Issue:*
The column `waiting` has been removed from `pg_stat_activity` View instead
two new columns has been added `wait_event` and `wait_event_type`.
--
Regards,
Murtuza
Hi,
PFA patch to add favicon in base template for proper reference.
RM#1692
--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
RM_1692.patch
Description: Binary data
--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org
Fix title syntax.
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e909429da734c3b48a287951e0f6f008d0583309
Modified Files
--
docs/en_US/synonym_dialog.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--
Sent via pgadm
Hi Dave,
Please find the attached revised patch for regression errors which
we faced.
Firstly, apply patch for RM#1720(Harshal worked on this) and then apply
this patch. There is some code change in test suite due to code
modification in dev side.
Note: Run test suite only for server or da
Allow zooming in the runtime with Ctrl/Cmd+Plus and Ctrl/Cmd+Minus. Fixes #1726
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8c913f5773d792d1ad4841098385884db4fb9fef
Modified Files
--
runtime/BrowserWindow.cpp | 127 +
Hi
On Wed, Sep 21, 2016 at 6:57 PM, Tom Bollich wrote:
> Hey guys just letting you know that I went to upgrade to pga4 and found it
> to be completely unusable due to font size. I’m on windows 10 with the
> resolution of 3840x2160 and I’m attaching a screenshot that shows pga3,
> visual studio, a
Document keyboard shortcuts. Fixes #1727
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0ba414f0abee5f35c64c0b36a372b0518c493339
Modified Files
--
docs/en_US/getting_started.rst| 1 +
docs/en_US/keyboard_shortcuts.rst | 73
Drop all connections from the connection manager when a server is dropped to
avoid issues if sqlite reuses an ID. Fixes #1720
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f117685d77ce075e1c99ff7c32172f695850f95c
Author: Harshal Dhumal
Modi
Update regression tests to resolve issues where database/connections were
getting mixed up.
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1cb5a7c7cafe36d86bf609b04901ebf69960e093
Author: Navnath Gadakh
Modified Files
--
.../serv
Great - all tests pass now.
So, it would be very helpful if the rest of the tests that are
outstanding can now be completed before GA is wrapped on Monday :-)
Thanks!
On Thu, Sep 22, 2016 at 8:09 AM, Harshal Dhumal
wrote:
> Hi,
>
> Please find attached updated patch for RM1720.
>
> Also test th
Thanks, applied.
On Thu, Sep 22, 2016 at 12:36 PM, Navnath Gadakh
wrote:
> Hi Dave,
>Please find the attached revised patch for regression errors which we
> faced.
> Firstly, apply patch for RM#1720(Harshal worked on this) and then apply
> this patch. There is some code change in test su
Can you rebase this please?
(pgadmin4)piranha:web dpage$ git apply ~/Downloads/RM_1719.patch
error: patch failed: web/pgadmin/browser/server_groups/servers/__init__.py:662
error: web/pgadmin/browser/server_groups/servers/__init__.py: patch
does not apply
On Thu, Sep 22, 2016 at 8:20 AM, Murtuza Z
Ensure the favicon can be found. Fixes #1692
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9a56fb552c5ec3e7de17be104d4f84077102e7e2
Author: Murtuza Zabuawala
Modified Files
--
web/pgadmin/templates/base.html | 6 +++---
1 file cha
Thanks, committed.
On Thu, Sep 22, 2016 at 9:39 AM, Murtuza Zabuawala
wrote:
> Hi,
>
> PFA patch to add favicon in base template for proper reference.
> RM#1692
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent vi
Hi Dave,
PFA updated patch.
--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Thu, Sep 22, 2016 at 5:33 PM, Dave Page wrote:
> Can you rebase this please?
>
> (pgadmin4)piranha:web dpage$ git apply ~/Downloads/RM_1719.patch
> error: pa
Can you explain what was broken exactly please? Backups work fine for
me without the patch - and whilst they also work with it, I now get an
ugly command shell window flash up which I didn't before.
On Wed, Sep 21, 2016 at 11:48 AM, Surinder Kumar
wrote:
> Hi
>
> While working on RM1391 I found a
Hi,
PFA patch to add support for creating synonym for Packages.
RM#1611
--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
RM_1611.patch
Description: Binary data
--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To
Fix stats on PG 9.6. Fixes #1719
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f48f8066573fdd46ce4cf4063d299aaf60bdbc22
Author: Murtuza Zabuawala
Modified Files
--
.../browser/server_groups/servers/__init__.py | 14 +-
..
Thanks, applied.
On Thu, Sep 22, 2016 at 1:16 PM, Murtuza Zabuawala
wrote:
> Hi Dave,
>
> PFA updated patch.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Thu, Sep 22, 2016 at 5:33 PM, Dave Page wrote:
>>
>> Can you r
Fix default zoom setting.
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=821f70663e116fadce1226ad58a5a4a4fd859cb6
Modified Files
--
runtime/BrowserWindow.cpp | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
--
Sent vi
Add Packages as a synonym target type. Fixes #1611
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a113b43a1fb5613087a67be8b8a302dec7516d43
Author: Murtuza Zabuawala
Modified Files
--
.../servers/databases/schemas/synonyms/__init__
Thanks - committed. I noticed while testing that if I update a synonym
(I was changing the target package), the properties list doesn't seem
to auto-refresh when I hit OK on the dialogue. Can you reproduce that?
On Thu, Sep 22, 2016 at 2:08 PM, Murtuza Zabuawala
wrote:
> Hi,
>
> PFA patch to add
Yes, I can.
Seems like it got broken after we have made changes for sorting nodes.
--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Thu, Sep 22, 2016 at 7:27 PM, Dave Page wrote:
> Thanks - committed. I noticed while testing that if I
Misc fixes and additions for pgAgent support:
- Added DatetimepickerControl, MomentCell (using moment.js)
- Used the 'DatetimepickerControl' in Role (Also - resolved an issue, when
unset the datetime for 'Valid Until'.)
- Added a 'Select All/Unselect All' adaptor for Select2 used by pgAgent nodes
Hi
On Thu, Sep 22, 2016 at 11:47 AM, Ashesh Vashi <
ashesh.va...@enterprisedb.com> wrote:
> Hi Dave,
>
> Please find the patch for support for paAgent in pgAdmin 4.
>
Did you forget the binary switch?
piranha:web dpage$ git apply --binary ~/Downloads/pgagent_v2.patch
error: cannot apply binary
I sent an updated patch immediately.
On Sep 22, 2016 20:01, "Dave Page" wrote:
> Hi
>
> On Thu, Sep 22, 2016 at 11:47 AM, Ashesh Vashi <
> ashesh.va...@enterprisedb.com> wrote:
>
>> Hi Dave,
>>
>> Please find the patch for support for paAgent in pgAdmin 4.
>>
>
> Did you forget the binary switch
Hmm - that was clearly hiding from me. I'll take a look now.
Did you see the rest of my comments?
On Thu, Sep 22, 2016 at 3:37 PM, Ashesh Vashi
wrote:
> I sent an updated patch immediately.
>
>
> On Sep 22, 2016 20:01, "Dave Page" wrote:
>>
>> Hi
>>
>> On Thu, Sep 22, 2016 at 11:47 AM, Ashesh V
OK - I've logged it here: https://redmine.postgresql.org/issues/1728
That just became our second highest priority issue!
On Thu, Sep 22, 2016 at 3:09 PM, Murtuza Zabuawala
wrote:
> Yes, I can.
>
> Seems like it got broken after we have made changes for sorting nodes.
>
> --
> Regards,
> Murtuza
Will look at them.
On Sep 22, 2016 20:08, "Dave Page" wrote:
> Hmm - that was clearly hiding from me. I'll take a look now.
>
> Did you see the rest of my comments?
>
> On Thu, Sep 22, 2016 at 3:37 PM, Ashesh Vashi
> wrote:
> > I sent an updated patch immediately.
> >
> >
> > On Sep 22, 2016 20
Thanks. From the pgAgent patch:
- The date/time format is different again. Should be locale or ISO
(consistent across the app)
- I think we need to add hints under the less obvious options - e.g.
Job class and host agent
- On the job step subnode control, lets move the Script to it's own
tab (ca
Image updates
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e959c6835833ce9d0263546ea1a3482495d568f5
Author: Susan Douglas
Modified Files
--
docs/en_US/images/language_definition.png | Bin 59442 -> 39386 bytes
docs/en_US/images/l
Actually It doesn't broke anywhere, instead It runs successfully. On
debugging I found that it runs the subprocess.Popen() utility but it
doesn't run internally the pg_dump utitliy. On running the same command on
windows cmd prompt it works.
Then on setting parameters close_fds=False and cmd_shell
Hi,
PFA minor patch to fix the issue where we were displaying 'CREATE Script'
on Server-group & Server node.
RM#1578
--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
RM_1578.patch
Description: Binary data
--
Sent via pgadmin-hackers ma
Hi Dave,
On Thu, Sep 22, 2016 at 8:01 PM, Dave Page wrote:
> Hi
>
> On Thu, Sep 22, 2016 at 11:47 AM, Ashesh Vashi <
> ashesh.va...@enterprisedb.com> wrote:
>
>> Hi Dave,
>>
>> Please find the patch for support for paAgent in pgAdmin 4.
>>
>
> Did you forget the binary switch?
>
> piranha:web d
On Wed, Sep 21, 2016 at 8:40 PM, Dave Page wrote:
> Hi
>
> On Wed, Sep 21, 2016 at 2:30 PM, Surinder Kumar
> wrote:
> > Hi Dave/Ashesh
> >
> > The thing we can do is:
> > 1) We can display loading message same as other panels if returned
> response
> > is taking longer than 2 seconds, otherwise
Hi
*Issue:*
on updating node, we deselect and then again select the node updated to
refresh the panel. but it needs some delay of few milliseconds between
deselect and select to fix this issue.
Please find attached patch and review.
Thanks,
Surinder Kumar
RM1728.patch
Description: Binary data
37 matches
Mail list logo
