Hi,
Please find attached patch for the Data-type Reader.
This common functionality is required under Schema node as many nodes uses
the same functionality.
Thanks,
Khushboo
diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/templates/datatype/sql/9.1_plus/get_types.sql b/we
Hi,
On Wed, Mar 16, 2016 at 2:55 PM, Dave Page wrote:
> Hi
>
> On Wed, Mar 16, 2016 at 9:18 AM, Khushboo Vashi
> wrote:
> >
> >>> - Owner and schema should be allowed to be left blank (and then default
> >>> to the current user/schema)
> >
>
Hi,
Please find the updated Domain Module Patch.
To test this patch, please apply Backgrid Textarea Cell Patch before this.
Thanks,
Khushboo
On Wed, Mar 16, 2016 at 3:02 PM, Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:
> Hi,
>
> On Wed, Mar 16, 2016 at 2:55 PM, D
(i.e. S), then only I have used
qtLiteral function to quote the default value.
Is this right approach or not?
Thanks,
Khushboo
On Wed, Mar 16, 2016 at 9:40 PM, Dave Page wrote:
> Hi
>
> On Wed, Mar 16, 2016 at 2:03 PM, Khushboo Vashi
> wrote:
> > Hi,
> >
> >
owser/utils.py:424
>
> error: web/pgadmin/browser/utils.py: patch does not apply
>
> On Fri, Mar 18, 2016 at 4:03 AM, Khushboo Vashi
> wrote:
> > Hi,
> >
> > Added support for the Domain Dependencies, earlier it was coming as a
> Type.
> >
> > Please
Hi,
Introduced Backgrid Textarea cell.
Please find attachment for the same.
Thanks,
Khushboo
diff --git a/web/pgadmin/static/css/overrides.css b/web/pgadmin/static/css/overrides.css
index 7f25dca..fdefc74 100755
--- a/web/pgadmin/static/css/overrides.css
+++ b/web/pgadmin/static/css/overrides.cs
Hi,
Added support for the Domain Dependencies, earlier it was coming as a Type.
Please find attached Patch for the same.
Akshay,
Can you please verify the patch, as you have implemented this functionality.
Thanks,
Khushboo
diff --git a/web/pgadmin/browser/server_groups/servers/templates/depend
Hi Dave,
On Fri, Mar 18, 2016 at 8:31 PM, Dave Page wrote:
> On Thu, Mar 17, 2016 at 5:39 PM, Khushboo Vashi
> wrote:
> > Hi Dave,
> >
> > I have a query regarding your below feedback :
> >
> > - Default values should be auto-quoted when necessary (ie.
Hi,
Please find the attached Patch to update the Browser Tree Node Icon after
editing.
This will be applicable only when server will send the icon after editing.
Thanks,
Khushboo
diff --git a/web/pgadmin/browser/templates/browser/js/node.js b/web/pgadmin/browser/templates/browser/js/node.js
inde
Updated one comment.
On Wed, Mar 23, 2016 at 12:48 PM, Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:
> Hi,
>
> Please find attached updated patch for the Domains module.
>
> On Wed, Mar 16, 2016 at 9:40 PM, Dave Page wrote:
>
>> Hi
>>
>>
Hi Dave,
I think you forgot to attach the updated patch.
Thanks,
Khushboo
On Wed, Mar 23, 2016 at 5:33 PM, Dave Page wrote:
> On Tue, Mar 22, 2016 at 10:51 AM, Khushboo Vashi
> wrote:
> > Hi,
> >
> > Please find updated Patch for the Functions/Procedures Module.
&g
Hi,
Please find attached patch to fix below issues in the Collection Control:
1> Unique Collection Control:
Couldn't listen Change event
2> Subnode Collection Control:
Add button Label was not in Upper case
First Issue was reported by Murtuza.
Thanks,
Khushboo
diff --git a/web/pgadmin/static/js
Hi,
Please find the attached patch for the Backgrid *StringDepsCell.*
The *StringDepsCell* displays HTML escaped strings and accepts
anything typed in.
Also, Listen to the dependent fields.
Usage of the Backgrid Cell:
If the Precision cell is dependent on the Datatype then:
{
id: 'precision
enterprisedb.com>
>
>
> *http://www.linkedin.com/in/asheshvashi*
> <http://www.linkedin.com/in/asheshvashi>
>
> On Wed, Mar 30, 2016 at 6:39 PM, Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> Please find the attached patch for t
Hi Ashesh,
I have changed the function name (from *render_deps* to *updateUIDeps*),
which will be called on the dependent field change, as per your suggestion.
Please find attached patch for the same.
Thanks,
Khushboo
On Fri, Apr 1, 2016 at 3:56 PM, Khushboo Vashi <
khushboo
Hi,
Please find updated patch for the Foreign Table Module.
This patch is dependent on
1. Backgrid Depscell Patch, (submitted by me)
2. NodeAjaxOptionsCell Transform change patch, on which Ashesh and Murtuza
are working
Thanks,
Khushboo
On Wed, Feb 24, 2016 at 2:57 PM, Khushboo Vashi
Hi,
The SQL Help Tab does not load the Help page on the Google Chrome (version:
39.0) browser.
Please find the attached patch for the same.
Thanks,
Khushboo
diff --git a/web/pgadmin/browser/templates/browser/js/node.js b/web/pgadmin/browser/templates/browser/js/node.js
index 331d818..d38eee7 100
Hi,
Due to some typos in datamodel.js, the application does not load properly
in Google Chrome (ver: 39).
Fixed typos in datamodel.js
Thanks,
Khushboo
diff --git a/web/pgadmin/browser/static/js/datamodel.js b/web/pgadmin/browser/static/js/datamodel.js
index 71bd959..fa60f7c 100644
--- a/web/pgad
Hi,
Fixed an issue related to Type ( TypeError: 'str' does not support the
buffer interface)
for python3 in the session.py.
Please find attachment for the same.
Thanks,
Khushboo
diff --git a/web/pgadmin/utils/session.py b/web/pgadmin/utils/session.py
index 6675e88..f4daefb 100644
--- a/web/pgadm
Hi,
Fixed a minor bug related to update the tree in the node.js.
Due to this bug, After updating the Node, if the response data is null
then it gives an error.
Please find the attached patch for the same.
Thanks,
Khushboo
diff --git a/web/pgadmin/browser/templates/browser/js/node.js b/web/pgadm
Hi,
Do not send the request to the server if a model contains any error on
selection of the SQL Tab, while creating/updating any Node.
Please find the attached patch for the same.
Thanks,
Khushboo
diff --git a/web/pgadmin/static/js/backform.pgadmin.js b/web/pgadmin/static/js/backform.pgadmin.js
ot; is added from 9.5.Do we really require to add
> table constraint ?
>- In alter foreign table, below are the new functionality
> added.
> 1. ALTER [ COLUMN ] column_name SET STORAGE { PLAIN
> | EXTERNAL | EXTENDED | MAIN }
> 2. DISABLE T
Hi,
On Wed, May 4, 2016 at 4:37 PM, Dave Page
wrote:
> Hi
>
> On Wed, May 4, 2016 at 7:51 AM, Khushboo Vashi
> wrote:
> > Hi Dave,
> >
> > In PG 9.5, for Foreign Table Editing, below new functionalities are
> added:
> >
> > ALTER [ COLUMN ] column_n
Congrats Akshay.
On Fri, May 6, 2016 at 1:54 PM, Dave Page wrote:
> All,
>
> I'm pleased to announce that Akshay Joshi has been added to the
> pgAdmin 4 project as our newest committer. Akshay has been working on
> pgAdmin 3 for a number of years now, and has done some excellent work
> on pg
Hi,
When we try to drop any node and the visibility of the Delete/Drop context
Menu of that node is having dependency on some function then, after
deleting that node object, it gives a JS error.
Please find the attached patch to fix this issue.
Thanks,
Khushboo
diff --git a/web/pgadmin/browser/t
Hi,
Please find the attached patch for adding a TODO file.
Thanks,
Khushboo
diff --git a/TODO.txt b/TODO.txt
new file mode 100644
index 000..666edb8
--- /dev/null
+++ b/TODO.txt
@@ -0,0 +1,16 @@
+List of TODOs:
+
Hi,
In the Dependencies tab, the Icon of the Type is not showing up.
Please find the attached patch for the same.
Thanks,
Khushboo
diff --git a/web/pgadmin/static/css/overrides.css b/web/pgadmin/static/css/overrides.css
index 1927ff1..cbb7ff8 100755
--- a/web/pgadmin/static/css/overrides.css
+++
Hi,
In IE (ver: 10), the Save/Reset buttons are not getting enabled even after
changing the fields.
Please find the attached patch for the same.
Thanks,
Khushboo
diff --git a/web/pgadmin/browser/templates/browser/js/node.js b/web/pgadmin/browser/templates/browser/js/node.js
index 5810e74..6289c2
Hi,
Please find the attached re-based patch.
Thanks,
Khushboo
On Wed, Apr 6, 2016 at 2:38 PM, Ashesh Vashi
wrote:
> Hi Khushboo,
>
>
> On Tue, Apr 5, 2016 at 10:59 AM, Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>> Hi Ashesh,
>>
>&
Hi,
I have started reviewing the patch but the basic functionalities are
breaking on python 2.7.
Please test the patch on Python 2.7, fix the issues and resend the patch.
Thanks,
Khushboo
On Thu, May 12, 2016 at 6:03 PM, Harshal Dhumal <
harshal.dhu...@enterprisedb.com> wrote:
> Hi,
>
>
> --
>
n Fri, May 13, 2016 at 5:24 PM, Harshal Dhumal <
harshal.dhu...@enterprisedb.com> wrote:
> Hi
>
> PFA attached patches for table and it's child nodes with python 2.7
> compatibility.
>
> --
> *Harshal Dhumal*
> *Software Engineer *
>
>
>
> EenterpriseDB <http:/
On Thu, Jun 16, 2016 at 4:42 PM, Dave Page wrote:
>
>
> On Thu, Jun 16, 2016 at 12:04 PM, Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Hi Dave
>>
>> On Thu, Jun 16, 2016 at 2:42 PM, Akshay Joshi > .com> wrote:
>>
>>>
>>>
>>> On Thu, Jun 16, 2016 at 2:35 PM, Dave Page wrote:
>>>
>>
On Thu, Jun 16, 2016 at 5:07 PM, Dave Page wrote:
>
>
> On Thu, Jun 16, 2016 at 12:19 PM, Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>>
>>
>> On Thu, Jun 16, 2016 at 4:42 PM, Dave Page wrote:
>>
>>>
>>>
>
Hi,
Please find the attached patch to fix the RM #1351 - Foreign table column
options in pgAdmin 4.
Added the functionality to add column level options in Foreign Table.
Thanks,
Khushboo
diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/__init__.py b/web/pg
On Mon, Jul 11, 2016 at 7:15 PM, Priyanka Shendge <
priyanka.shen...@enterprisedb.com> wrote:
>
>
> On 11 July 2016 at 18:35, Dave Page wrote:
>
>> On Mon, Jul 11, 2016 at 1:25 PM, Priyanka Shendge
>> wrote:
>> > Sorry, by mistake i copied incomplete query. There is an OID present
>> for
>> > a
Hi Navnath,
I have just ran the automated test cases, I noticed that the login
test-case gets called (which actually post data and gets logged-in) each
time before every test case runs. I think this should not happen, user
login should be done only once.
Thanks,
Khushboo
On Mon, Jul 18, 2016 at
Hi,
Please find the attached patch for the RM 1470: [Desktop Runtime
Application] User can not drop domain.
The issue was produced because of execute_2darray function change. Now I
have changed the way of variable assignment to fix this issue.
Thanks,
Khushboo
diff --git a/web/pgadmin/browser/se
Hi,
Please find the attached patch for the fix of RM 1467: Unable to drop
trigger function, function and procedures.
The issue was produced because of execute_2darray function change.
Thanks,
Khushboo
diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/__init__.py
Hi,
Please find the attached patch to fix the RM 1527: XSS vulnerabilities.
Fixed items:
1. Tree Node labels while loading, adding and updating the node
2. Error and Success messages of Alertify dialogue
3. Properties dialogue: un-editable controls
4. SQL Editor title
Please review the patch an
On Wed, Aug 17, 2016 at 4:35 PM, Dave Page wrote:
> Hi,
>
> I did some quick testing, and found the following issues:
>
> - Package ACL is not shown in properties
>
> - Package header and body are not shown in properties
>
> - System package? is not shown in properties
>
> - The header for the RE
shboo
On Thu, Aug 18, 2016 at 10:50 AM, Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:
>
>
> On Wed, Aug 17, 2016 at 4:35 PM, Dave Page wrote:
>
>> Hi,
>>
>> I did some quick testing, and found the following issues:
>>
>> - Package
mpany
>
> On Thu, Aug 18, 2016 at 12:34 PM, Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>> Hi Harshal,
>>
>> Please see below review comments.
>>
>> 1. Please make one line space between every SQL block as per pgAdmin 4
>> standa
Hi,
Please find the attached patch to fix the RM 1785: PPAS Servers are
consider to be PostgreSQL until after the first disconnect/reconnect
Issue:
After creating a new server, the icon and the server type were not set
properly in the response, so fixed both in the response.
Thanks,
Khushboo
di
Hi,
Please find the attached patch to fix the below 2 bugs.
RM 1603: [Web Based] Export database failed if object contains double
quotes.
RM 1220: Backup database is not working with special characters
The issues which were fixed:
1. Client side data were not unescaped
2. Required command line
Hi,
The fix does not include a special case when database name has an equal to
(=) character in it.
Thanks,
Khushboo
On Fri, Oct 14, 2016 at 6:58 PM, Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:
> Hi,
>
> Please find the attached patch to fix the below 2 bugs.
&g
On Sat, Oct 15, 2016 at 11:52 AM, Dave Page wrote:
>
>
> On Friday, October 14, 2016, Ashesh Vashi
> wrote:
>
>> On Sat, Oct 15, 2016 at 4:59 AM, Dave Page wrote:
>>
>>> Hi
>>>
>>> On Friday, October 14, 2016, Khushboo Vashi <
; On Thu, Oct 20, 2016 at 12:08 PM, Ashesh Vashi
> wrote:
> > On Thu, Oct 20, 2016 at 4:26 PM, Khushboo Vashi
> > wrote:
> >>
> >>
> >>
> >> On Sat, Oct 15, 2016 at 11:52 AM, Dave Page wrote:
> >>>
> >>>
> >>>
Hi,
Please find the patch to fix RM 1887: Preferences values ate not stored
properly.
Thanks,
Khushboo
diff --git a/web/pgadmin/preferences/templates/preferences/preferences.js b/web/pgadmin/preferences/templates/preferences/preferences.js
index 09788fc..e02c926 100644
--- a/web/pgadmin/preferenc
Hi,
In dashboard.js, some of the DOM elements are in the global context, so,
changed those elements to be used only for the Dashboard context.
Please find the attached patch for the same.
Thanks,
Khushboo
diff --git a/web/pgadmin/dashboard/templates/dashboard/js/dashboard.js b/web/pgadmin/dashbo
On Mon, Nov 14, 2016 at 5:37 PM, Dave Page wrote:
> Hi
>
> (Khushboo, please see below)
>
> On Sun, Nov 13, 2016 at 1:26 PM, lambda wrote:
> > for the first question, pybabel support Chinese with zh_Hans_CN
> >
> > #pybabel --list-locales |grep zh
> > b'zh Chinese'
> > b'zh_Hans
Hi,
Please find the attached patch for the Backgrid password cell css.
Currently the password cell does not have proper css in the edit mode.
Thanks,
Khushboo
diff --git a/web/pgadmin/static/css/overrides.css b/web/pgadmin/static/css/overrides.css
index 5af03ba..9f8aa79 100755
--- a/web/pgadmin/s
: 'zh_CN',
> >> 'en' : 'English'
> >> }
> >> ```
> >> ok ?
> >
> >Hmm, I'm sure that failed yesterday - I remember debugging it! It's
> >working now though, so let's use zh_cn.
Hi,
Please find the attached patch to fix the RM #1924.
Thanks,
Khushboo
diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/views/templates/view/pg/9.4_plus/sql/update.sql b/web/pgadmin/browser/server_groups/servers/databases/schemas/views/templates/view/pg/9.4_plus/sql/upda
Hi,
Please find attached patch to fix RM #1855: Displaying error message at the
bottom of properties panel while creating Trigger Function.
Issue: The status-bar context was getting changed in properties dialogue. I
have removed status bar from properties (read-only mode) panel as that was
not re
Hi,
Please find the attached patch for RM #1801: Properly handle databases with
datallowconn == false.
Issue: While connecting the database, allowconn parameter was not in
consideration. Also, the database properties query call was on the
selected database which was not correct.
Fix: Put the ch
Hi,
Please find the attached updated patch.
On Fri, Nov 18, 2016 at 7:45 PM, Dave Page wrote:
> Hi
>
> On Fri, Nov 18, 2016 at 1:03 PM, Khushboo Vashi
> wrote:
> > Hi,
> >
> > Please find the attached patch for RM #1801: Properly handle databases
&g
Hi,
Please find the attached updated patch.
Thanks,
Khushboo
On Fri, Nov 25, 2016 at 2:56 PM, Dave Page wrote:
> Hi
>
> This doesn't apply - can you rebase it please?
>
> Thanks.
>
> On Thu, Nov 24, 2016 at 8:57 AM, Khushboo Vashi
> wrote:
> > Hi,
>
Hi.
Please find the attached updated patch.
Thanks,
Khushboo
On Fri, Nov 25, 2016 at 7:12 PM, Dave Page wrote:
> Hi
>
> On Fri, Nov 25, 2016 at 12:19 PM, Khushboo Vashi
> wrote:
> > Hi,
> >
> > Please find the attached updated patch.
>
> Please see
Hi,
Please find the attached updated patch.
Thanks,
Khushboo
On Mon, Dec 5, 2016 at 11:09 PM, Dave Page wrote:
> Hi
>
> On Friday, December 2, 2016, Khushboo Vashi com> wrote:
>
>> Hi.
>>
>> Please find the attached updated patch.
>>
>> Thanks,
&
Hi,
Please find the attached patch to fix the RM 1780: Rendering glitches in
the query editor line number column when editing many lines.
Some codemirror css were overwritten to increase the width of the line
number column in sql editor.
Due to those changes this issue was coming, I have removed
Hi,
Please find the attached patch to fix RM 2007: View Last 100 rows not
working with Pgadmin4.
To fix this issue I have changed the query which fetches the last 100 rows.
The issue is reproducible when we have more than one primary keys; because
the order by clause in the query was not applied
Hi,
Please find the attached updated patch.
Thanks,
Khushboo
On Mon, Dec 12, 2016 at 3:30 PM, Dave Page wrote:
> Hi
>
> On Fri, Dec 9, 2016 at 11:37 AM, Khushboo Vashi
> wrote:
> > Hi,
> >
> > Please find the attached patch to fix the RM 1780: Rendering glit
, 2016 at 5:32 AM, Khushboo Vashi
> wrote:
> > Hi,
> >
> > Please find the attached updated patch.
> >
> > Thanks,
> > Khushboo
> >
> > On Mon, Dec 5, 2016 at 11:09 PM, Dave Page wrote:
> >>
> >> Hi
> >>
> >>
changes are required.
> Thanks.
>
> On Fri, Dec 16, 2016 at 1:04 PM, Dave Page wrote:
> > Thanks, patch applied!
> >
> > On Fri, Dec 16, 2016 at 9:12 AM, Khushboo Vashi
> > wrote:
> >> Hi,
> >>
> >> Please find the attached updated p
Hi,
Issue: Can not modify the table information when it has postgis geometry
column.
Fix: Properly handled the table column type (when it does not refer to
pg_catalog) while creating SQL command.
Please find attached patch to fix this issue.
Thanks,
Khushboo
diff --git a/web/pgadmin/browser/ser
Hi,
Please find the attached patch to fix RM 1730 - Role membership control
display needs improvement
*Fixed items:*
- An alternate note is needed when shown on the properties panel
- Remove the border
- Align the label and control in columns as per other controls.
*Remaining*:
- Investigate m
Hi,
The updated patch attached.
Thanks,
Khushboo
On Sun, Jan 8, 2017 at 6:56 PM, Dave Page wrote:
> Hi
>
> On Friday, January 6, 2017, Khushboo Vashi com> wrote:
>
>> Hi,
>>
>> Please find the attached patch to fix RM 1730 - Role membership control
>>
Hi,
Please find the attached patch to fix the RM 2069 - Wrong tablespace
displayed in table properties.
When the table is created without a tablespace, the "pg_default" tablespace
gets selected rather than the default tablespace (the current database
tablespace).
So, this issue has been fixed.
T
Hi,
Please find the attached updated patch.
Thanks,
Khushboo
On Fri, Jan 20, 2017 at 5:31 PM, Dave Page wrote:
> On Fri, Jan 13, 2017 at 6:41 AM, Khushboo Vashi
> wrote:
> > Hi,
> >
> > Please find the attached patch to fix the RM 2069 - Wrong tablespace
> >
Hi,
Please find the attached rebased patch.
Thanks,
Khushboo
On Mon, Jan 30, 2017 at 6:20 PM, Dave Page wrote:
> Hi
>
> Can you rebase this please?
>
> Thanks.
>
> On Fri, Jan 27, 2017 at 11:53 AM, Khushboo Vashi
> wrote:
> > Hi,
> >
> > Please find
Hi,
On Fri, Feb 3, 2017 at 11:53 AM, Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:
> Hi,
>
> Please find the attached rebased patch.
>
> This patch also include fix for RM 2139: Message (Connection to the server
has been lost.) displayed with Materialized view a
t;
> Fixed
> On Fri, Feb 3, 2017 at 12:14 PM, Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> On Fri, Feb 3, 2017 at 11:53 AM, Khushboo Vashi <
>> khushboo.va...@enterprisedb.com> wrote:
>>
>>> Hi,
>>
Hi,
Please find the attached patch to fix RM 2089 : PARALLEL SAFE support for
functions missing.
Fix: Incorporated the PARALLEL SAFE support for the functions and
procedures for PostgreSQL 9.6.
Thanks,
Khushboo
diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/_
ects($1,$2)
>> $function$;
>>
>> but as per psql it should be
>>
>> CREATE OR REPLACE FUNCTION public.st_intersects(geom1 geometry, geom2
>> geometry)
>>
>> RETURNS boolean
>>
>> LANGUAGE sql
>>
>> *IMMUTABLE PARALLEL SAFE*
Hi,
Please find the attached updated patch.
Thanks,
Khushboo
On Fri, Feb 3, 2017 at 7:53 PM, Dave Page
wrote:
>
>
> On Fri, Feb 3, 2017 at 1:59 PM, Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>>
>>
>> On Fri, Feb 3, 2017 at 7:02 PM,
Hi,
Please find the attached updated patch.
Thanks,
Khushboo
On Wed, Feb 15, 2017 at 8:57 PM, Dave Page
wrote:
> Hi
>
> On Fri, Feb 10, 2017 at 7:28 AM, Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> Please find the attached u
Hi,
Please find the attached patch to fix the RM 2173: Sequences API test cases
are not working in PG9.2 and PPAS9.2
The query which fetches the privileges was not compatible with Postgres 9.2.
So, To fix this issue I have changed the query little bit.
Dave/Ashesh,
Please review my query change
Hi,
Please find the attached patch for #2190: Move language selection to
Preferences.
Moved the user language selection into Preferences.
For the desktop mode, if the user has selected the language from the
Preferences then that will be reflected otherwise English will be the
default language.
F
Hi,
On Mon, Mar 13, 2017 at 4:09 PM, Dave Page wrote:
> Hi
>
> On Fri, Mar 10, 2017 at 1:55 PM, Khushboo Vashi
> wrote:
> > Hi,
> >
> > Please find the attached patch for #2190: Move language selection to
> > Preferences.
> >
> > Moved the user
Hi,
Please find the attached updated patch.
Thanks,
Khushboo
On Fri, Mar 17, 2017 at 4:20 PM, Dave Page wrote:
> Hi
>
> On Fri, Mar 17, 2017 at 10:25 AM, Khushboo Vashi
> wrote:
> > Hi,
> >
> > On Mon, Mar 13, 2017 at 4:09 PM, Dave Page wrote:
> >>
&g
Hi,
Please find the attached updated patch.
Thanks,
Khushboo
On Fri, Mar 17, 2017 at 6:02 PM, Dave Page wrote:
> Hi
>
> On Fri, Mar 17, 2017 at 12:17 PM, Khushboo Vashi
> wrote:
> > Hi,
> >
> > Please find the attached updated patch.
> >
> > Thanks,
patch I recall going anywhere near there
> recently). If I check the Preferences dialogue, those options aren't
> there at all.
>
> Can you take a look ASAP please?
>
> Thanks.
>
> On Fri, Mar 24, 2017 at 10:20 AM, Dave Page wrote:
> > Thanks applied!
> >
> &
Hi,
The ascending/descending order is not working in the backgrid while
clicking on the headers.
If this functionality is required then please find the attached fix for the
same.
Thanks,
Khushboo
diff --git a/web/pgadmin/static/js/backgrid.pgadmin.js b/web/pgadmin/static/js/backgrid.pgadmin.js
in
sts around the makeComparator method.
>
> Tira & Matt
>
>
> On Mon, Mar 27, 2017 at 8:01 AM, Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> The ascending/descending order is not working in the backgrid while
>> clicking
Hi,
Please find the attached patch to fix RM #2291: Error highlighting broken.
Murtuza / Akshay,
Can you please review the patch?
Thanks,
Khushboo
diff --git a/web/pgadmin/tools/sqleditor/__init__.py b/web/pgadmin/tools/sqleditor/__init__.py
index f08b02e..0444377 100644
--- a/web/pgadmin/tools
Hi,
On Mon, Mar 27, 2017 at 9:57 PM, Dave Page wrote:
> On Mon, Mar 27, 2017 at 7:49 AM, Khushboo Vashi
> wrote:
> > Hi Dave,
> >
> > I have fixed the issue and the patch for the same is attached, but the
> > Binary path options are not translated properly.
&g
Hi,
Please find the attached updated patch.
Thanks,
Khushboo
On Sat, Apr 1, 2017 at 12:12 PM, Dave Page wrote:
> Hi
>
>
> On Friday, March 31, 2017, Khushboo Vashi
> wrote:
>
>> Hi,
>>
>> On Mon, Mar 27, 2017 at 9:57 PM, Dave Page wrote:
>>
>
Hi,
Please find the attached patch to fix the RM #2339: Horizontal scrolling in
the treeview.
I wanted to change the pgadmin.css file to fix this issue but the aciTree
library is located at browser/static/vendor/, so I have included this
change in the browser/static/css/browser.css file.
Thanks
Hi,
Please find the attached patch to fix the RM #2318: Foreign Table create
script puts columns in alphabetical order instead of the actual order of
the columns as the table was originally created
Fixed the column order in get_columns.sql template for PG 9.5 and above.
Other than this templates
psed again. I'm running in Google
> Chrome on Mac, if that helps narrow down the problem.
>
> On Tue, Apr 18, 2017 at 2:01 PM, Dave Page wrote:
> > Thanks, patch applied.
> >
> > On Fri, Apr 14, 2017 at 5:02 AM, Khushboo Vashi
> > wrote:
> >> Hi,
>
Hi,
Fixed RM #2315 : Sorting by size is broken.
Removed the pg_size_pretty function from query for the collection and
introduced the client side function to convert size into human readable
format. So, the sorting issue is fixed as the algorithm will get the actual
value of size instead of format
ode), the client side functionality is
implemented not for individual node , so this behaviour is different. For
the individual node still, we are using pg_size_pretty function
>
>
> Thanks
> Joao & Sarah
>
> On Tue, Apr 25, 2017 at 7:58 AM, Dave Page wrote:
>
>> A
using pg_size_pretty function for different fields like Size, Index
Size, Table space size, Tuple length, Size of Temporary files in different
modules and some of them are cell level and we don't require to put
overhead on cell level fields as sorting is not required for individual
node stat
ward.
>
> Thanks!
> Sarah & Joao
>
> On Thu, Apr 27, 2017 at 1:50 AM, Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>> Hi Joao & Sarah,
>>
>> On Wed, Apr 26, 2017 at 8:46 PM, Joao Pedro De Almeida Pereira <
>> jdealmeidap
Hi,
Please find the attached updated patch.
Thanks,
Khushboo
On Fri, Apr 28, 2017 at 7:58 PM, Matthew Kleiman
wrote:
> Hi Khushboo,
>
> That sounds good. Sorry if we weren't clear at first.
>
> Have a good holiday weekend!
>
> Sarah & Matt
>
>
> On Fri,
e followed the code structure of the pg_size_pretty function of
PostgreSQL :) .
Thanks,
> Joao and George
>
>
>
> On Thu, May 4, 2017 at 5:02 AM, Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> Please find the attached updated patch.
&g
readability in your first patch, and that the original structure was
> better (especially the sizes array)
> At first glance, the new sizePrettify appears to behave like a for loop,
> so that might be the simplest refactor.
>
> Added loop.
> Thanks,
> Joao and George
>
>
Yes. I am looking into this.
Thanks,
Khushboo
On Mon, Sep 7, 2015 at 1:31 PM, Dave Page wrote:
> Khushboo, can you look at this please?
>
> Thanks.
>
> On Sun, Sep 6, 2015 at 12:42 AM, Prasad wrote:
> > Hi,
> >
> > When you try to run pgadmin4 for first time(without presence of
> pgadmin4.db),
hanks,
Khushboo
On Mon, Sep 7, 2015 at 1:49 PM, Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:
> Yes. I am looking into this.
>
> Thanks,
> Khushboo
>
> On Mon, Sep 7, 2015 at 1:31 PM, Dave Page wrote:
>
>> Khushboo, can you look at this please?
>>
>
On Mon, Sep 7, 2015 at 5:28 PM, Dave Page wrote:
> On Mon, Sep 7, 2015 at 12:36 PM, Khushboo Vashi
> wrote:
> > Hi Dave,
> >
> > I have tried to reproduce the issue but couldn't reproduce it on UBUNTU
> as
> > well as on MAC.
>
> OK.
1 - 100 of 138 matches
Mail list logo
