Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

Committed - after rebased the patch. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Thu, May 26, 2016 at 4:41 PM, Murtuza Zabuawala <

Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

Hi, PFA updated patch which will also include new query given by Thom for "Of type" drop-down. Regards, Murtuza -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, May 26, 2016 at 4:04 PM, Thom Brown wrote: > On

Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

On 26 May 2016 at 11:20, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch for RM#1231 & RM#1237. > > Additionally I have shifted 'Advanced tab' after columns & constraint tab. > > > @Thom, > > Reading "Of type" drop-down, We borrowed sql query from pgadmin3 to >

Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

Hi, PFA patch for RM#1231 & RM#1237. Additionally I have shifted 'Advanced tab' after columns & constraint tab. @Thom, Reading "Of type" drop-down, We borrowed sql query from pgadmin3 to populate "Of type" combo box as given below. I was not able to find a way to differentiate between table &

Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

Thanks. On May 25, 2016 21:01, "Thom Brown" wrote: > Thanks. I've raised all of these in tickets 1231 to 1237. > > Thom > > On 25 May 2016 at 04:23, Ashesh Vashi > wrote: > >> Hi Thom, >> >> Can you please create RM cases for the same, it will be

Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

Thanks. I've raised all of these in tickets 1231 to 1237. Thom On 25 May 2016 at 04:23, Ashesh Vashi wrote: > Hi Thom, > > Can you please create RM cases for the same, it will be easy to track > those issues? > We're using

Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

Hi Thom, Can you please create RM cases for the same, it will be easy to track those issues? We're using "https://redmine.postgresql.org/projects/pgadmin4/; for the same. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company

Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

On 25 May 2016 at 02:00, Thom Brown wrote: > On 25 May 2016 at 00:29, Thom Brown wrote: >> On 24 May 2016 at 19:09, Ashesh Vashi wrote: >>> >>> On Mon, May 23, 2016 at 6:35 PM, Murtuza Zabuawala >>>

Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

On 25 May 2016 at 00:29, Thom Brown wrote: > On 24 May 2016 at 19:09, Ashesh Vashi wrote: >> >> On Mon, May 23, 2016 at 6:35 PM, Murtuza Zabuawala >> wrote: >>> >>> Hi, >>> >>> PFA patch, which will fixes below

Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

On Mon, May 23, 2016 at 6:35 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch, which will fixes below mentioned issues, > Committed. > > - Fixed all the review comments given by Dave on tables & its child nodes. > Can you please list down, what has not yet

Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

Hi, PFA patch, which will fixes below mentioned issues, - Fixed all the review comments given by Dave on tables & its child nodes. *Additional enhancements* - In Index node, We have updated the way columns were added, earlier it was using subnode control now we can insert/update values

Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

I think that makes sense, yes. Sent from my iPad > On 21 May 2016, at 04:12, Ashesh Vashi wrote: > > >> On Sat, May 21, 2016 at 12:01 AM, Dave Page wrote: >> Hi >> >> I just started to take a look at the table dialogue and friends. Here are

Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

On Sat, May 21, 2016 at 12:01 AM, Dave Page wrote: > Hi > > I just started to take a look at the table dialogue and friends. Here are > a few issues that we need to address - please take care of them: > > 1) Move columns to their own tab. Vertical scrolling is bad. > Should

Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

Hi I just started to take a look at the table dialogue and friends. Here are a few issues that we need to address - please take care of them: 1) Move columns to their own tab. Vertical scrolling is bad. 2) Similarly, move constraints to their own tab. 3) Ensure all labels only have a capital

Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

Hi, Please find add-on patch for Column node. Issue fixed: 1. Column node, 'Primary key' switch should be hidden under view node, refer column node visible condition for table node 2. 'Inherited from' column should be hidden. 2. Other columns except Default value should be disabled. On Wed,

Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

Hi, PFA table add-on patch version 8.4. (apply after 8.3) This includes changes for trigger node issues. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, May 18, 2016 at 4:19 PM, Murtuza Zabuawala <

Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

Hi, PFA table add-on patch version 8.3. (apply after 8.2) -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, May 18, 2016 at 3:20 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA table add-on patch

Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

Hi, PFA table add-on patch version 8.2 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, May 18, 2016 at 2:42 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > PFA patch for table node (version 8.1). apply

Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

Hi, PFA patch for table node (version 8.1). apply this patch on version 7 patch. Not all issue are fixed in this patch. Murtuza will be sending version 8.2 witch will have resolution for remaining issues. Apply version 8.2 patch on version 8.1 -- *Harshal Dhumal* *Software Engineer *

Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

Hi Harshal, Below are my review comments: I got below warning when I tried to apply the patch for table node as mentioned below: Table creation: - Trailing white spaces warnings $ git apply /projects/patches/pgadmin4/Table/table_14_May_V6.patch

Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

Hi, PFA add-on patch to Ver.6 patch, Which will add CREATE/SELECT etc Script support into table node. Regards, Murtuza -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, May 17, 2016 at 11:48 AM, Surinder Kumar <

Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

Hi, Please find attached add-on patch for table's subnode rule. Apply this patch at end after applying previous patches in email thread. *Issue fixed*: "Do Instead" on Rule node under View/M-View node not working in properties mode. Unable to generate proper SQL. On Mon, May 16, 2016 at 7:02

Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

Hi, PFA add-on patch for table and it's child node. (please apply this patch on version 6 patch) Murtuza and I fixed following issues: 1. SQL formatting 2. Vacuum grid should not be editable in properties mode. 3. Column datatype does not get displayed in the properties and edit mode. 4. Do not

Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

Hi, Review Comments: - Please replace 'can not' with 'cannot' in all the validation messages. - PG 9.1+ Inheritance issue as below: CREATE TABLE public.table1 ( ) ( ) INHERITS (a) WITH ( OIDS = FALSE ) TABLESPACE pg_default; ALTER TABLE public.table1 OWNER to postgres; brackets

Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

Hi, I have started reviewing the patch but the basic functionalities are breaking on python 2.7. Please test the patch on Python 2.7, fix the issues and resend the patch. Thanks, Khushboo On Thu, May 12, 2016 at 6:03 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > > -- >

Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

Hi, -- *Harshal Dhumal* *Software Engineer * EenterpriseDB On Tue, May 10, 2016 at 6:37 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Harshal, > > Pending issues to be fixed which I tried but not able to fix in > Constraints node, >

Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

Hi, Please find below responses. > > Please find the review comments so far: > > 1. On the Table Collection node, The fields in the grid should be Name, > Owner and Comments. OID is not required. Please follow same for the other > Nodes like Index, Constraints etc. > Fixed > 2. While Updating

Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

Hi, i have fixed all of below mentioned issues. > A couple more: > > > If I go to create a new table, give it a name, select a table to > inherit from, and then do nothing else, I get an error: > > ERROR: syntax error at or near "INHERITS" > LINE 2: INHERITS (test) > ^ > > This is because no

Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

Hi, -- *Harshal Dhumal* *Software Engineer * EenterpriseDB On Wed, Apr 27, 2016 at 6:13 PM, Thom Brown wrote: > On 27 April 2016 at 10:22, Harshal Dhumal > wrote: > > > > Hi, > > > > PFA attached patches for

Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

-- *Harshal Dhumal* *Software Engineer * EenterpriseDB On Thu, Apr 28, 2016 at 2:22 PM, Dave Page wrote: > > > > On 27 Apr 2016, at 13:43, Thom Brown wrote: > > > > On 27 April 2016 at 10:22, Harshal Dhumal > >

Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

> On 27 Apr 2016, at 13:43, Thom Brown wrote: > > On 27 April 2016 at 10:22, Harshal Dhumal > wrote: >> >> Hi, >> >> PFA attached patches for table node and all table child nodes. >> >> This patch includes below nodes, >> >> 1) Table node

Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

On 27 April 2016 at 14:34, Thom Brown wrote: > On 27 April 2016 at 13:43, Thom Brown wrote: >> On 27 April 2016 at 10:22, Harshal Dhumal >> wrote: >>> >>> Hi, >>> >>> PFA attached patches for table node and all table child nodes.

Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

Hi Thom, Thank you for your inputs, Will work on it & send updated patch again. Regards, Murtuza > On 27-Apr-2016, at 7:04 pm, Thom Brown wrote: > > On 27 April 2016 at 13:43, Thom Brown wrote: >> On 27 April 2016 at 10:22, Harshal Dhumal >>

Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

On 27 April 2016 at 13:43, Thom Brown wrote: > On 27 April 2016 at 10:22, Harshal Dhumal > wrote: >> >> Hi, >> >> PFA attached patches for table node and all table child nodes. >> >> This patch includes below nodes, >> >> 1) Table node

Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

On 27 April 2016 at 10:22, Harshal Dhumal wrote: > > Hi, > > PFA attached patches for table node and all table child nodes. > > This patch includes below nodes, > > 1) Table node -- Initial patch by Murtuza, > constraints

Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

Hi, The exclusion constraint has minor validation issue (this won't block testing of patch). I'm closely working with Ashesh to fix this. -- *Harshal Dhumal* *Software Engineer * EenterpriseDB On Wed, Apr 27, 2016 at 2:52 PM, Harshal Dhumal <