18.02.2022 08:00, Justin Pryzby пишет:
BRIN can also crash if passed a non-brin index.
I've been sitting on this one for awhile. Feel free to include it in your
patchset.
commit 08010a6037fc4e24a9ba05e5386e766f4310d35e
Author: Justin Pryzby
Date: Tue Jan 19 00:25:15 2021 -0600
First of all, thanks for the review and remarks!
18.02.2022 08:02, Michael Paquier пишет:
On Thu, Feb 17, 2022 at 05:40:41PM +0800, Julien Rouhaud wrote:
About the patch, it's incorrectly using a hardcoded 8192 block-size rather than
using the computed :block_size (or computing one when it's
On Tue, Feb 22, 2022 at 6:45 AM tanghy.f...@fujitsu.com
wrote:
>
> I found a problem when using it. When a replication workers exits, the
> transaction stats should be sent to stats collector if they were not sent
> before
> because it didn't reach PGSTAT_STAT_INTERVAL. But I saw that the stats
On Tue, Feb 22, 2022 at 1:03 AM Fujii Masao wrote:
> On 2022/02/21 14:45, Etsuro Fujita wrote:
> > On Fri, Feb 18, 2022 at 1:46 AM Fujii Masao
> > wrote:
> >> I reviewed 0001 patch. It looks good to me except the following minor
> >> things. If these are addressed, I think that the 001 patch
Hi,
In logical replication, currently Walsender sends the data that is
generated locally and the data that are replicated from other
instances. This results in infinite recursion in circular logical
replication setup.
Here the user is trying to have a 2-way replication setup with node 1
On Feb, Wed 23, 2022 at 10:58 PM Ajin Cherian wrote:
>
Few comments to V19-0001:
1. I think we should adjust the alignment format.
git am ../v19-0001-Skip-empty-transactions-for-logical-replication.patch
.git/rebase-apply/patch:197: indent with spaces.
* Before we send schema, make sure that
Below are my review comments just for the v1 patch test code.
==
1. "table sync error" versus "tablesync error"
+# Wait for the table sync error to be reported.
+$node_subscriber->poll_query_until(
+ 'postgres',
+ qq[
+SELECT apply_error_count = 0 AND sync_error_count > 0
+FROM
Hi,
I recently had to work on some internal tool which, among other things, has to
merge pg_hba.conf and pg_ident.conf files between an existing (possibly
already updated) instance and some external repository.
My biggest concern is that any issue in either the external repository content
or the
On Tue, Feb 22, 2022 at 8:15 AM Michael Paquier wrote:
>
> On Mon, Feb 21, 2022 at 05:00:43PM +0530, Amit Kapila wrote:
> > On Mon, Feb 21, 2022 at 4:56 PM Michael Paquier wrote:
> >
> > It is still under discussion. I'll take the necessary action along
> > with other things related to that view
On 2022-02-22 22:44:25 -0500, Tom Lane wrote:
> Andres Freund writes:
> > What about adding a pg_fatal() that's pg_log_fatal() + exit()? That keeps
> > pg_log_* stuff "log only", but adds something adjacent enough to hopefully
> > reduce future misunderstandings?
>
> I'd be okay with that,
On Tue, Feb 22, 2022 at 8:02 PM Masahiko Sawada wrote:
>
> On Tue, Feb 22, 2022 at 6:53 PM Amit Kapila wrote:
> >
>
> > 3. Can we send error stats pgstat_report_stat() as that will be called
> > via proc_exit() path. We can set the phase (apply/sync) in
> > apply_error_callback_arg and then use
Andres Freund writes:
> What about adding a pg_fatal() that's pg_log_fatal() + exit()? That keeps
> pg_log_* stuff "log only", but adds something adjacent enough to hopefully
> reduce future misunderstandings?
I'd be okay with that, except that pg_upgrade already has a pg_fatal
(because it has
Hi,
On 2022-02-22 18:23:19 -0500, Tom Lane wrote:
> Robert Haas writes:
> > On Fri, Nov 19, 2021 at 5:17 AM Peter Eisentraut
> > wrote:
> >> If people want to do that kind of thing (I'm undecided whether the
> >> complexity is worth it), then make it a different API. The pg_log_*
> >> calls
Hi. Below are my review comments for the v1 patch.
==
1. Commit message - wording
As the result of the discussion, we've concluded that the stats
collector is not an appropriate place to store the error information of
subscription workers.
SUGGESTION
It was decided (refer to the Discussion
On Tue, Feb 22, 2022 1:45 PM Masahiko Sawada wrote:
>
> I've attached a patch that changes pg_stat_subscription_workers view.
> It removes non-cumulative values such as error details such as
> error-XID and the error message from the view, and consequently the
> view now has only cumulative
On Thu, Feb 17, 2022 at 9:42 PM Amit Kapila wrote:
>
> On Mon, Jan 31, 2022 at 6:18 PM Ajin Cherian wrote:
> >
>
> Few comments:
> =
> 1. Is there any particular why the patch is not skipping empty xacts
> for streaming (in-progress) transactions as noted in the commit
> message as
>Ooh, nice find and diagnosys. I can confirm that the test fails as you
>described without the code fix, and doesn't fail with it.
>I attach the same patch, with the test file put in its final place
>rather than as a patch. Due to recent xlog.c changes this need a bit of
>
Hi,
I think we need to do something about this, because afaics this has data
corruption risks, albeit with a narrow window.
E.g. consider what happens if the value of wal_sync_method is reset to the
boot value and one of the catalog accesses in GUC check hooks causes WAL
writes (e.g. due to
On Wed, Feb 23, 2022 at 11:14 AM Andres Freund wrote:
>
> Hi,
>
> On 2022-02-22 14:45:19 +0900, Masahiko Sawada wrote:
> > I've attached a patch that changes pg_stat_subscription_workers view.
>
> Thanks for working on this!
>
> Why are the stats stored in the per-database stats file / as a
On Tue, Feb 22, 2022 at 11:04:16AM +0900, Michael Paquier wrote:
> On Fri, Feb 18, 2022 at 05:38:56PM +0800, Julien Rouhaud wrote:
> > On Fri, Feb 18, 2022 at 05:22:36PM +0900, Michael Paquier wrote:
> >> So, I have been looking at this problem, and I don't see a problem in
> >> doing something
Hi,
On 2022-02-18 12:10:51 +1300, David Rowley wrote:
> The other way I thought to fix it was by changing the logic for when
> generation blocks are freed. In the problem case mentioned above, the
> block being freed is the current block (which was just allocated). I
> made some changes to
On Tue, Feb 22, 2022 at 4:26 PM Andres Freund wrote:
> I've switched back and forth between gold and lld a couple times. Eventually I
> always get frustrated by lld causing slowdowns and other issues for gdb. Did
> you ever hit one of those?
Now that you mention it...gdb was very slow the last
Hi,
On 2022-02-22 14:45:19 +0900, Masahiko Sawada wrote:
> I've attached a patch that changes pg_stat_subscription_workers view.
Thanks for working on this!
Why are the stats stored in the per-database stats file / as a second level
below the database? While they're also associated with a
On Tue, Feb 22, 2022 at 4:47 AM Euler Taveira wrote:
>
> On Thu, Feb 17, 2022, at 3:36 AM, Amit Kapila wrote:
>
> As there is a new version, I would like to wait for a few more days
> before committing. I am planning to commit this early next week (by
> Tuesday) unless others or I see any more
Hi,
I think I did find a bug related to the test, but afaics not the cause of the
test failures we're seeing. See
https://www.postgresql.org/message-id/20220223014855.4lsddr464i7mymk2%40alap3.anarazel.de
I don't think it's related to the problem of this thread, because the logs of
primary3
Hi,
On 2022-02-22 17:48:55 -0800, Andres Freund wrote:
> I think the minor changes might unfortunately have introduced a race? Before
> the patch just used ConditionVariableSleep(), but now it also has a
> ConditionVariablePrepareToSleep(). Without re-checking the sleep condition
> until
>
Mark Wong writes:
> Take 3. :)
> I've upgraded everyone to the v14 buildfarm scripts and made sure the
> --test passed on HEAD on each one. So I hopefully didn't miss any
> (other than the one EOL OpenSUSE version that I will plan on upgrading.)
Thanks!
However ... it seems like most of your
Hi,
On 2021-06-11 12:27:57 -0400, Álvaro Herrera wrote:
> On 2021-Jun-10, Álvaro Herrera wrote:
>
> > Here's a version that I feel is committable (0001). There was an issue
> > when returning from the inner loop, if in a previous iteration we had
> > released the lock. In that case we need to
On Tuesday, February 22, 2022 11:47 PM Masahiko Sawada
wrote:
> On Tue, Feb 22, 2022 at 9:22 PM osumi.takami...@fujitsu.com
> wrote:
> > (4) doc/src/sgml/monitoring.sgml
> >
> >
> > role="column_definition">
> > - last_error_time timestamp with
> time zone
> > +
On Mon, 2022-02-21 at 11:42 +0100, Peter Eisentraut wrote:
> On 15.02.22 00:07, Jacob Champion wrote:
> > After this patch, bad padding is no longer ignored during decryption,
> > and encryption without padding now requires the input size to be a
> > multiple of the block size. To see the
Hi,
On 2022-01-13 19:24:09 -0800, Peter Geoghegan wrote:
> On Fri, Jul 20, 2018 at 8:16 PM Peter Geoghegan wrote:
> > On Mon, Jul 9, 2018 at 4:40 PM, Andres Freund wrote:
> > > FWIW, I've lately noticed that I spend a fair time waiting for the
> > > linker during edit-compile-test cycles. Due
On 2/22/22 21:12, Tomas Vondra wrote:
> On 2/22/22 01:36, Fujii Masao wrote:
>>
>>
>> On 2022/02/18 22:28, Tomas Vondra wrote:
>>> Hi,
>>>
>>> here's a slightly updated version of the patch series.
>>
>> Thanks for updating the patches!
>>
>>
>>> The 0001 part
>>> adds tracking of
On 2/19/22 06:33, Amit Kapila wrote:
> On Sat, Feb 19, 2022 at 7:48 AM Tomas Vondra
> wrote:
>>
>> Do we need to handle both FOR ALL TABLES and FOR ALL SEQUENCES at the
>> same time? That seems like a reasonable thing people might want.
>>
>
> +1. That seems reasonable to me as well. I think
Since 4035cd5d4, wal_compression=lz4 is supported. I think pg15 should also
support wal_compression=zstd. There are free bits in the WAL header.
The last message on that thread includes a patch doing just that, which I've
rebased.
Hi,
On 2022-02-22 08:55:23 -0500, Andrew Dunstan wrote:
> I'm pretty sure all my Windows machines with buildfarm animals are
> sufficiently modern except the XP machine, which only builds release 10
> nowadays.
Cool.
> What's involved in moving to require Unix socket support?
It works today
I've been playing with an idea I had a while back. Basically that it
would be useful to have some "noop" operators that are used purely to
influence the planner.
For context I've suggested in the past that there are two categories of hints:
1 Hints that override the planner's decisions with
On Mon, Feb 21, 2022 at 03:28:35PM -0500, Tom Lane wrote:
> Mark Wong writes:
> > On Sat, Feb 19, 2022 at 08:22:29AM -0800, Andres Freund wrote:
> >> Unfortunately it looks like it wasn't quite enough. All, or nearly all,
> >> your
> >> animals that ran since still seem to be failing in the same
On Tue, Feb 22, 2022 at 04:02:39PM +0200, Shmuel Kamensky wrote:
> I'm interested in creating a Postgres extension that would enable
> developers to write triggers in (modern) C++. Does anyone know if there is
> already some sort of translation wrapper between the native Postgres C
> API's and
> On 22 Feb 2022, at 18:13, Andres Freund wrote:
> On 2022-02-22 15:10:11 +0100, Daniel Gustafsson wrote:
>> The errorpaths that exit(2) the testrun should be converted to "bail out"
>> lines
>> when running with TAP output, but apart from that I think it's fairly spec
>> compliant.
>
> I'd
On 2022-02-22 15:10:30 -0500, Andrew Dunstan wrote:
> I'll be surprised if we can't come up with something cleaner than that.
Suggestions?
Hello all, this is my first time posting here (I first posted on the IRC
but didn't get any response), so let me know if there's a different
procedure for asking questions.
I'm interested in creating a Postgres extension that would enable
developers to write triggers in (modern) C++. Does anyone
On 2022-Feb-22, Imseih (AWS), Sami wrote:
> On 13.5 a wal flush PANIC is encountered after a standby is promoted.
>
> With debugging, it was found that when a standby skips a missing
> continuation record on recovery, the missingContrecPtr is not
> invalidated after the record is skipped.
On 2/22/22 01:36, Fujii Masao wrote:
>
>
> On 2022/02/18 22:28, Tomas Vondra wrote:
>> Hi,
>>
>> here's a slightly updated version of the patch series.
>
> Thanks for updating the patches!
>
>
>> The 0001 part
>> adds tracking of server_version_num, so that it's possible to enable
>> other
On 2/22/22 13:19, Andres Freund wrote:
> Hi,
>
> On 2022-02-22 09:28:37 -0800, Andres Freund wrote:
>> On 2022-02-14 09:46:20 -0800, Andres Freund wrote:
t/die-immediately.t aieee at t/die-immediately.t line 1.
t/die-immediately.t Dubious, test returned 255 (wstat 65280,
On Tue, Feb 22, 2022 at 09:37:11AM -0800, Nathan Bossart wrote:
> In my testing, I found that when I killed the server just before unlink()
> during WAL recyling, I ended up with links to the same file in pg_wal after
> restarting. My latest test produced links to the same file for the current
>
On 13.5 a wal flush PANIC is encountered after a standby is promoted.
With debugging, it was found that when a standby skips a missing continuation
record on recovery, the missingContrecPtr is not invalidated after the record
is skipped. Therefore, when the standby is promoted to a primary it
On Tue, 22 Feb 2022 at 07:39, Nitin Jadhav
wrote:
>
> > > Thank you for sharing the information. 'triggering backend PID' (int)
> > > - can be stored without any problem. 'checkpoint or restartpoint?'
> > > (boolean) - can be stored as a integer value like
> > >
Hi,
On 2022-02-22 09:28:37 -0800, Andres Freund wrote:
> On 2022-02-14 09:46:20 -0800, Andres Freund wrote:
> > > t/die-immediately.t aieee at t/die-immediately.t line 1.
> > > t/die-immediately.t Dubious, test returned 255 (wstat 65280, 0xff00)
> > > No subtests run
> >
> > Hm. Looks
On 02/21/22 16:09, Chapman Flack wrote:
> On 02/07/22 15:14, Chapman Flack wrote:
>> I'll work on some doc patches.
>
> It seems a bit of an impedance mismatch that there is a get_func_trftypes
> producing a C Oid[] (with its length returned separately), while
> get_transform_fromsql and
On Mon, Feb 21, 2022 at 05:19:48PM -0800, Nathan Bossart wrote:
> I also spent some time investigating whether durably renaming the archive
> status files was even necessary. In theory, it shouldn't be. If a crash
> happens before the rename is persisted, we might try to re-archive files,
> but
Hi,
On 2022-02-14 09:46:20 -0800, Andres Freund wrote:
> > t/die-immediately.t aieee at t/die-immediately.t line 1.
> > t/die-immediately.t Dubious, test returned 255 (wstat 65280, 0xff00)
> > No subtests run
>
> Hm. Looks different when a test is including our test helpers.
>
>
Hi,
Thanks for the updated version!
On 2022-02-22 15:10:11 +0100, Daniel Gustafsson wrote:
> The errorpaths that exit(2) the testrun should be converted to "bail out"
> lines
> when running with TAP output, but apart from that I think it's fairly spec
> compliant.
I'd much rather not use BAIL
On Thu, Feb 17, 2022 at 12:40 PM Robert Haas wrote:
>
> On Mon, Jan 31, 2022 at 1:57 PM Joshua Brindle
> wrote:
> > This is precisely the use case I am trying to accomplish with this
> > patchset, roughly:
> >
> > - An automated bot that creates users and adds them to the employees role
> > -
Kyotaro Horiguchi writes:
> Anyway, don't we use the -ftabstop option flag to silence compiler?
> The warning is contradicting our convention. The attached adds that
> flag.
No, we use pgindent to not have such inconsistent indentation.
regards, tom lane
I'm not sure about the current status, but found it while playing
around with the latest changes a bit, so thought of sharing it here.
+
+ strategy
+
+
+ This is used for copying the database directory. Currently, we have
+ two strategies the
On Tue, Feb 22, 2022 at 9:22 PM osumi.takami...@fujitsu.com
wrote:
>
> On Tuesday, February 22, 2022 2:45 PM Masahiko Sawada
> wrote:
> > I've attached a patch that changes pg_stat_subscription_workers view.
> > It removes non-cumulative values such as error details such as error-XID and
> >
+/* Kinds of checkpoint (as advertised via PROGRESS_CHECKPOINT_KIND) */
+#define PROGRESS_CHECKPOINT_KIND_WAL0
+#define PROGRESS_CHECKPOINT_KIND_TIME 1
+#define PROGRESS_CHECKPOINT_KIND_FORCE 2
+#define PROGRESS_CHECKPOINT_KIND_UNKNOWN3
On
On Tue, Feb 22, 2022 at 6:53 PM Amit Kapila wrote:
>
> On Tue, Feb 22, 2022 at 11:15 AM Masahiko Sawada
> wrote:
> >
> > I've attached a patch that changes pg_stat_subscription_workers view.
> > It removes non-cumulative values such as error details such as
> > error-XID and the error message
I wrote a few more small tests for psql to address uncovered territory
in SendQuery() especially:
- \timing
- client encoding handling
- notifications
What's still missing is:
- \watch
- pagers
For \watch, I think one would need something like the current cancel
test (since you need to get
> On 22 Feb 2022, at 00:08, Daniel Gustafsson wrote:
> I'll fix that.
The attached v3 fixes that thinko, and cleans up a lot of the output which
isn't diagnostic per the TAP spec to make it less noisy. It also fixes tag
support used in the ECPG tests and a few small cleanups. There is a blank
On 2/21/22 12:31, Andres Freund wrote:
>
> We still have a few issues with ports conflicts on windows. We should really
> consider just desupporting all windows versions without unix socket
> support. But until then it seems useful to be able to figure out random
> failures.
>
I'm pretty sure
Hi Chris,
> Breaking up the data into pages with page headers means a lot of extra work
> [...]. It would be much better to store the index in a set of external data
> files. This seems possible so long as I put the files under the database's
> directory and name things properly.
Just
On Tuesday, February 22, 2022 2:45 PM Masahiko Sawada
wrote:
> I've attached a patch that changes pg_stat_subscription_workers view.
> It removes non-cumulative values such as error details such as error-XID and
> the error message from the view, and consequently the view now has only
>
Em seg., 21 de fev. de 2022 às 13:13, Zheng Li
escreveu:
>
> 2. Table level
> Allows DDLs on the published tables to be replicated except for
> certain edge cases.
>
> Think how to handle triggers and functions with same name but different
purpose.
Publisher
create function public.audit()
Hi Zheng,
> I’m working on a patch to support logical replication of data
> definition language statements (DDLs).
That's great!
> However, there are still many edge cases to sort out because not every
> DDL statement can/should be replicated.
Maybe the first implementation shouldn't be
On Tue, Feb 22, 2022 at 11:15 AM Masahiko Sawada wrote:
>
> I've attached a patch that changes pg_stat_subscription_workers view.
> It removes non-cumulative values such as error details such as
> error-XID and the error message from the view, and consequently the
> view now has only cumulative
Hi,
On 2022-02-22 01:11:21 -0800, Andres Freund wrote:
> I've started to work on a few debugging aids to find problem like
> these. Attached are two WIP patches:
Forgot to attach. Also importantly includes a tap test for several of these
issues
Greetings,
Andres Freund
>From
Please excuse my late reply.
On Wed, Feb 16, 2022 at 12:20 PM Juan José Santamaría Flecha <
juanjo.santama...@gmail.com> wrote:
> On Tue, Feb 15, 2022 at 5:25 PM Andres Freund wrote:
>
>>
>> FWIW, I've looked at using either vcpkg or conan to more easily
>> install /
>>
> build dependencies
Hi,
On 2022-02-10 14:26:59 -0800, Andres Freund wrote:
> On 2022-02-11 09:10:38 +1300, Thomas Munro wrote:
> > It seems like I should go ahead and do that today, and we can study
> > further uses for PROCSIGNAL_BARRIER_SMGRRELEASE in follow-on work?
>
> Yes.
I wrote a test to show the problem.
> On 22 Feb 2022, at 07:14, Kyotaro Horiguchi wrote:
> Anyway, don't we use the -ftabstop option flag to silence compiler?
> The warning is contradicting our convention. The attached adds that
> flag.
Isn't this flag contradicting our convention? From the docs section you
reference further
At Tue, 22 Feb 2022 01:59:45 +0900, Fujii Masao
wrote in
>
> > Of the following, I think we should do (a) and (b) to make future
> > backpatchings easier.
> > a) Use RedoRecPtr and PriorRedoPtr after they are assigned.
> > b) Move assignment to PriorRedoPtr into the ControlFileLock section.
>
Hi Joel,
> I've compiled a list of all* PostgreSQL EXTENSIONs in the world:
The list is great. Thanks for doing this!
Just curious, is it a one-time experiment or you are going to keep the
list in an actual state similarly to awesome-* lists on GitHub, or ...
?
--
Best regards,
Aleksander
72 matches
Mail list logo
