On Thu, Sep 7, 2023 at 11:09 PM Aleksander Alekseev <
aleksan...@timescale.com> wrote:
> Probably it's just because of my limited experience with the optimizer
> but I don't find the proposed change particularly straightforward. I
> would suggest adding a comment before the Assert's and/or a detai
I noticed that we occasionally use "volatile" to access shared memory,
but usually not; and I'm not clear on the rules for doing so. For
instance, AdvanceXLInsertBuffer() writes to XLogCtl->xlblocks[nextidx]
through a volatile pointer; but then immediately writes to XLogCtl-
>InitializedUpTo with
On Tue, Sep 26, 2023 at 9:51 AM Richard Guo wrote:
> On Tue, Sep 26, 2023 at 5:45 AM Tom Lane wrote:
>
>> I'm inclined to write the comment more like "Usually the equal()
>> check is redundant, but in setop plans it may not be, since
>> prepunion.c assigns ressortgroupref equal to the column res
02.11.2023 18:22, Bruce Momjian wrote:
Third, I have come up with the following shell script to test for proper
pgindentation, which I run automatically before commit:
I would also suggest using a script like attached to check a patch for
new unicums (usually some of them are typos or inconsist
On Thu, Nov 2, 2023 at 8:52 PM Bruce Momjian wrote:
>
> Third, I have come up with the following shell script to test for proper
> pgindentation, which I run automatically before commit:
>
> #
> https://www.postgresql.org/message-id/CAGECzQQL-Dbb%2BYkid9Dhq-491MawHvi6hR_NGkhiDE%2B5zRZ6vQ%
On Fri, Nov 3, 2023 at 1:11 PM Amit Kapila wrote:
>
> On Thu, Nov 2, 2023 at 2:36 PM Amit Kapila wrote:
> >
> > On Thu, Nov 2, 2023 at 11:32 AM Michael Paquier wrote:
> > >
> > > On Thu, Nov 02, 2023 at 02:32:07PM +1100, Peter Smith wrote:
> > > > On Thu, Nov 2, 2023 at 2:25 PM Peter Smith
> >
Hi,
On 2023-10-31 16:23:17 -0500, David Christensen wrote:
> The patches are as follows:
>
> 0001 - doc updates
> 0002 - Basic key management and cipher support
> 0003 - Backend-related changes to support heap encryption
> 0004 - modifications to bin tools and programs to manage key rotation and
>
On Fri, 03 Nov 2023 at 10:03, Thomas Munro wrote:
> On Fri, Nov 3, 2023 at 2:22 PM Thomas Munro wrote:
>> On Fri, Nov 3, 2023 at 3:42 AM Japin Li wrote:
>> > I think this might be a bug comes from Illumos pseudo-tty. I can reproduce
>> > this by using pseudo-tty on Illumos.
>>
>> I don't know
On Thu, Nov 2, 2023 at 2:36 PM Amit Kapila wrote:
>
> On Thu, Nov 2, 2023 at 11:32 AM Michael Paquier wrote:
> >
> > On Thu, Nov 02, 2023 at 02:32:07PM +1100, Peter Smith wrote:
> > > On Thu, Nov 2, 2023 at 2:25 PM Peter Smith wrote:
> > >> Checking this patch yesterday prompted me to create a n
On Fri, Nov 3, 2023 at 2:22 PM Thomas Munro wrote:
> On Fri, Nov 3, 2023 at 3:42 AM Japin Li wrote:
> > I think this might be a bug comes from Illumos pseudo-tty. I can reproduce
> > this by using pseudo-tty on Illumos.
>
> I don't know but my guess is that this has to do with termios defaults
>
On Fri, 3 Nov 2023 at 13:49, Bruce Momjian wrote:
>
> On Fri, Oct 16, 2020 at 09:03:52AM +, Hou, Zhijie wrote:
> > /*
> >* Don't set the limit below 3/4 of hash_mem. In that case, we are at
> > the
> >* minimum number of partitions, so we aren't going to dramatically
>
On Fri, Nov 3, 2023 at 3:42 AM Japin Li wrote:
> On Thu, 02 Nov 2023 at 22:23, Tom Lane wrote:
> > Japin Li writes:
> >> It seems the 'SEL\t' is converted to 'SEL ' which is "SEL" with 5
> >> spaces.
> >
> > That would be plausible if readline were disabled, or otherwise
> > not functioning
On Thu, Nov 2, 2023 at 11:07:19AM -0500, Nathan Bossart wrote:
> On Thu, Nov 02, 2023 at 11:22:38AM -0400, Bruce Momjian wrote:
> > First, I have been hesitant to ascribe others as patch authors if I
> > heavily modified a doc patch because I didn't want them blamed for any
> > mistakes I made. H
On Fri, Oct 16, 2020 at 09:03:52AM +, Hou, Zhijie wrote:
> Hi
>
> In /src/backend/executor/nodeAgg.c
>
> I found the following comment still use work mem,
> Since hash_mem has been introduced, Is it more accurate to use hash_mem here ?
>
> @@ -1827,7 +1827,7 @@ hash_agg_set_limits(double has
On Fri, 3 Nov 2023 at 01:02, Richard Guo wrote:
> It seems that the test is still not stable on 32-bit machines even after
> 4b14e18714. I see the following plan diff on cfbot [1].
I recreated that locally this time. Seems there's still flexibility
to push or not push down the sort and the cost
On Wed, Oct 04, 2023 at 01:15:03PM -0700, Jeff Davis wrote:
> > The fact that there are multiple types of normalization and multiple
> > notions of equality doesn't make this easier.
And then there's text that isn't normalized to any of them.
> NFC is really the only one that makes sense.
Yes.
On Tue, Oct 17, 2023 at 05:07:40PM +0200, Daniel Verite wrote:
> > * Add a per-database option to enforce only storing assigned unicode
> > code points.
>
> There's a problem in the fact that the set of assigned code points is
> expanding with every Unicode release, which happens about every year.
On Wed, Oct 04, 2023 at 01:16:22PM -0400, Robert Haas wrote:
> There's a very popular commercial database where, or so I have been
> led to believe, any byte sequence at all is accepted when you try to
> put values into the database. [...]
In other circles we call this "just-use-8".
ZFS, for exam
On Fri, Oct 06, 2023 at 02:37:06PM -0400, Robert Haas wrote:
> > Sure, because TEXT in PG doesn't have codeset+encoding as part of it --
> > it's whatever the database's encoding is. Collation can and should be a
> > porperty of a column, since for Unicode it wouldn't be reasonable to
> > make tha
On 2023-11-01 16:39:24 -0400, Peter Eisentraut wrote:
> > OTOH, it seems somewhat unlikely that maintainer-clean is utilized much in
> > extensions. I see it in things like postgis, but that has it's own configure
> > etc, even though it also invokes pgxs.
>
> I thought about this. I don't think
On 11/2/23 22:33, Matthias van de Meent wrote:
> On Thu, 2 Nov 2023 at 22:25, Tomas Vondra
> wrote:
>>
>>
>>
>> On 11/2/23 21:02, Matthias van de Meent wrote:
>>> On Thu, 2 Nov 2023 at 20:32, Tomas Vondra
>>> wrote:
On 11/2/23 20:09, stepan rutz wrote:
> db1=# explain (analyze, seri
bowerbird and hammerkop didn't like commit a02b37fc. They're still
using the old 3rd build system that is not tested by CI. It's due for
removal in the 17 cycle IIUC but in the meantime I guess the new
codegen script needs to be invoked by something under src/tools/msvc?
varlena.obj : error LN
On Thu, 2 Nov 2023 at 22:25, Tomas Vondra wrote:
>
>
>
> On 11/2/23 21:02, Matthias van de Meent wrote:
> > On Thu, 2 Nov 2023 at 20:32, Tomas Vondra
> > wrote:
> >> On 11/2/23 20:09, stepan rutz wrote:
> >>> db1=# explain (analyze, serialize) select * from test;
> >>>
On 11/2/23 21:02, Matthias van de Meent wrote:
> On Thu, 2 Nov 2023 at 20:32, Tomas Vondra
> wrote:
>> On 11/2/23 20:09, stepan rutz wrote:
>>> db1=# explain (analyze, serialize) select * from test;
>>> QUERY PLAN
>>>
On Tue, 31 Oct 2023 at 22:23, David Christensen
wrote:
>
> Greetings,
>
> I am including an updated version of this patch series; it has been rebased
> onto 6ec62b7799 and reworked somewhat.
>
> The patches are as follows:
>
> 0001 - doc updates
> 0002 - Basic key management and cipher support
>
On Thu, 2 Nov 2023 at 20:26, Bharath Rupireddy
wrote:
>
> On Wed, Nov 1, 2023 at 4:24 AM Michael Paquier wrote:
> >
> > On Tue, Oct 31, 2023 at 04:26:18PM +0900, torikoshia wrote:
> > > Yes, calling pg_stat_reset_shared() for all stats types can do what I
> > > wanted
> > > to do.
> > > But call
On Thu, Nov 2, 2023 at 05:28:20PM +0900, Kyotaro Horiguchi wrote:
> Thank you for continuing this. The additional changes looks
> fine.
>
> Upon reviewing the table again in this line, further potential
> improvements and issues have been found. For example:
>
> character, varchar: don't follow
On Thu, 2 Nov 2023 at 20:32, Tomas Vondra wrote:
> On 11/2/23 20:09, stepan rutz wrote:
> > db1=# explain (analyze, serialize) select * from test;
> > QUERY PLAN
> >
Hi Thomas,
indeed by doing less the code also becomes trivial and
ExplainPropertyInteger can be used as a oneliner.
My intention was to actually get the realistic payload-bytes from the
wire-protocol counted by the serialization option. I am also adding the
protocol bits and the length of the da
On 11/2/23 20:09, stepan rutz wrote:
> Hi Thomas,
>
> you are right of course. Thanks!
>
> I have attached a new version of the patch that supports the syntax like
> suggested. The previous patch was insonsistent in style indeed.
>
> explain (analyze, serialize)
>
> and
>
> explain (analyze
On Wed, Nov 1, 2023 at 4:24 AM Michael Paquier wrote:
>
> On Tue, Oct 31, 2023 at 04:26:18PM +0900, torikoshia wrote:
> > Yes, calling pg_stat_reset_shared() for all stats types can do what I wanted
> > to do.
> > But calling it with 6 different parameters seems tiresome and I thought it
> > would
Hi Thomas,
you are right of course. Thanks!
I have attached a new version of the patch that supports the syntax like
suggested. The previous patch was insonsistent in style indeed.
explain (analyze, serialize)
and
explain (analyze, serialize binary)
That doesn't make too much of a difference
>On the patch itself I'm somewhat unconvinced that it is a good idea or
>long-term maintainable to actually have a kinda random copy of the
>configuration file(!) of an external software (doxygen in this)
Rather than copying the Doxyfile, we could just publish the non-default values.
As a mostly
On Tue, Oct 31, 2023 at 4:12 PM 邱宇航 wrote:
>
> >
> > I thought these can also be rewrite to:
> >
> > if (!XLogRecHasBlockRef(record, block_id))
>
> Oops, I missed that. New version is attached.
+1. Indeed a reasonable change. The attached v2 patch LGTM.
--
Bharath Rupireddy
PostgreSQL Contribut
On Tue, 2023-10-31 at 13:16 -0400, Isaac Morland wrote:
> Perhaps the search_path for running a maintenance command should be
> the search_path set for the table owner (ALTER ROLE … SET search_path
> …)?
That's an interesting idea; I hadn't considered that, or at least not
very deeply. I feel lik
On Thu, Nov 2, 2023 at 9:10 AM Nathan Bossart wrote:
>
> On Wed, Nov 01, 2023 at 09:15:20PM +, John Morris wrote:
> > This is a rebased version . Even though I labelled it “v3”, there should be
> > no changes from “v2”.
>
> Thanks. I think this is almost ready, but I have to harp on the
> pg
On 9/25/23 06:30, Andrey Lepikhov wrote:
> ...
> I can't stop thinking about this issue. It is bizarre when Postgres
> chooses a non-unique index if a unique index gives us proof of minimum
> scan.
That's true, but no one implemented this heuristics. So the "proof of
minimum scan" is merely hypoth
Hi,
On 9/15/23 22:09, stepan rutz wrote:
> Hi,
>
> please see a revised version yesterday's mail. The patch attached now
> provides the following:
>
> EXPLAIN(ANALYZE,SERIALIZE)
>
> and
>
> EXPLAIN(ANALYZE,SERIALIZEBINARY)
>
I haven't looked at the patch in detail yet, but this option name l
Hi,
Look like the tab completion for CREATE TABLE ... AS is not proposed.
gilles=# CREATE TABLE test
( OF PARTITION OF
The attached patch fix that and also propose the further completion
after the AS keyword.
gilles=# CREATE TABLE test
( AS O
On Sat, Oct 28, 2023 at 2:22 AM Jeff Davis wrote:
>
> I think I see what you are saying: WALRead() is at a lower level than
> the XLogReaderRoutine callbacks, because it's used by the .page_read
> callbacks.
>
> That makes sense, but my first interpretation was that WALRead() is
> above the XLogRe
On Thu, Nov 2, 2023 at 12:24 PM Shlok Kyal wrote:
> I went through the CFbot and found that docs build run is giving some
> error (link: https://cirrus-ci.com/task/5712582359646208):
>
> Just wanted to make sure you are aware of the issue.
I am now. Thanks! :-) Will try to keep an eye on the bu
On Thu, Nov 02, 2023 at 11:22:38AM -0400, Bruce Momjian wrote:
> First, I have been hesitant to ascribe others as patch authors if I
> heavily modified a doc patch because I didn't want them blamed for any
> mistakes I made. However, I also want to give them credit, so I decided
> I would annotate
Looking closer, I realized that my proposed change in RestoreGUCState
is unnecessary, because guc_free() is already permissive about being
passed a NULL. That leaves us with one live bug in
get_explain_guc_options, two probably-unreachable hazards in
check_GUC_init and write_one_nondefault_variabl
I have three suggestions on committing that I thought would be helpful
to the hacker audience.
First, I have been hesitant to ascribe others as patch authors if I
heavily modified a doc patch because I didn't want them blamed for any
mistakes I made. However, I also want to give them credit, so I
On Thu, 02 Nov 2023 at 22:23, Tom Lane wrote:
> Japin Li writes:
>> It seems the 'SEL\t' is converted to 'SEL ' which is "SEL" with 5 spaces.
>
> That would be plausible if readline were disabled, or otherwise
> not functioning.
>
I think this might be a bug comes from Illumos pseudo-tty.
On Thu, Nov 02, 2023 at 06:17:20AM +, Xiang Gao wrote:
> After reading the discussion, I understand that in order to avoid performance
> regression in some instances, we need to try our best to avoid runtime checks.
> I don't know if I understand it correctly.
The idea is that we don't want to
Japin Li writes:
> It seems the 'SEL\t' is converted to 'SEL ' which is "SEL" with 5 spaces.
That would be plausible if readline were disabled, or otherwise
not functioning.
regards, tom lane
Hello Alvaro, all,
I have done some research regarding this bug.
Basically, we forbid the creation of partitioned tables and indexes if a
default_tablespace is specified in postgresql.conf.
In tablespace.c, the comment says:
"Don't allow specifying that when creating a partitioned table, how
On Wed, Nov 1, 2023 at 9:18 AM Chapman Flack wrote:
> So, it would not have been my choice to assign RfC status before getting to a
> resolution on that.
It's up to the reviewer (here Chapman), not the author, to decide
whether to set it to RfC. I've set the status to "needs review".
On Tue, 2023-10-31 at 14:12 -0400, Corey Huinker wrote:
>
>
> > About the SELECT example:
> > -
> >
> > That example belongs to UPDATE, I'd say, because that is the main
> > operation.
>
> I'm iffy on that suggestion. A big part of putting it in SELECT was the fact
> tha
On 30.10.23 10:12, Tom Lane wrote:
+1 for counting such tests as "skipped" in the summary. -1 for
emitting a message per skipped test. If I'm intentionally not
running those tests, that would be very annoying noise, and
potentially would obscure messages I actually need to see.
In my usage, t
On 11/2/23 06:01, Corey Huinker wrote:
>
>
> Maybe I just don't understand, but I'm pretty sure ANALYZE does not
> derive index stats from column stats. It actually builds them from the
> row sample.
>
>
> That is correct, my error.
>
>
>
> > * now support extended statistic
> On 2 Nov 2023, at 13:40, Etsuro Fujita wrote:
> Attached is a small patch for that: s/heapam_visibility.c/snapmgr.c/.
No objections to the patch, the change is correct. However, with git grep and
ctags and other ways of discovery I wonder if we're not better off avoiding
such references to fi
Hi,
While working on something else, I noticed $SUBJECT: commit b7eda3e0e
moved XidInMVCCSnapshot() from tqual.c into snapmgr.c, but follow-up
commit c91560def updated this reference incorrectly:
@@ -1498,7 +1498,7 @@ GetMaxSnapshotSubxidCount(void)
* information may not be available. If we fi
Hi,
I went through the Cfbot and saw that some test are failing for it
(link: https://cirrus-ci.com/task/4631357628874752):
test: postgresql:recovery / recovery/019_replslot_limit
# test failed
--- stderr ---
# poll_query_un
On Thu, Nov 2, 2023 at 3:19 PM David Rowley wrote:
> I'm not yet seeing any failures in the buildfarm, so don't really want
> to push a fix for this one if there are going to be a few more
> unstable ones to fix. I may just hold off a while to see.
It seems that the test is still not stable on
Any new patches will now need to be submitted to the January
commitfest. (Normally we'd give advance notice of that change, but
we're a bit behind this time.)
I have started going through the patch entries looking for out-of-date
statuses and filling in missing author fields. Currently we're at:
N
On Thu, Nov 2, 2023 at 3:41 PM vignesh C wrote:
>
> I have slightly modified it now and also made it consistent with the
> replication slot upgrade, but I was not sure if we need to add
> anything more. Let me know if anything else needs to be added. I will
> add it.
>
I think it is important for
On Tue, Aug 29, 2023 at 6:41 PM Richard Guo wrote:
> So it seems that the new costing logic is quite crude and tends to be
> very conservative, but it can help avoid the large overhead in the worst
> cases. I think this might be a good start to push this patch forward.
>
> Any thoughts or commen
Hi,
On Thu, 19 Oct 2023 at 16:35, Marko Tiikkaja wrote:
>
> Hi,
>
> Thank you for the feedback.
>
> Apparently it took me six years, but I've attached the latest version
> of the patch which I believe addresses all issues. I'll add it to the
> open commitfest.
>
>
> .m
I went through the CFbot
On Wed, 1 Nov 2023 at 10:13, Michael Paquier wrote:
>
> On Mon, Oct 30, 2023 at 03:05:09PM +0530, vignesh C wrote:
> > The patch was not applying because of recent commits. Here is a
> > rebased version of the patches.
>
> + * We don't want the launcher to run while upgrading because it may st
Hi all!
Currently, only unnamed prepared statements are supported by psql with the
\bind command and it's not possible to create or use named prepared statements
through extended protocol.
This patch introduces 2 additional commands: \parse and \bindx.
\parse allows us to issue a Parse message to
Hi Bohdan!
I will see about making th ecurrent doxygen configuration available as a
download again in the next few days. Not sure whether there is an
additional actionable item yet as far as the project from John Morris
goes wrt. the postgresql.org sysadmin team.
The patch proposed is an enh
On Tue, Oct 31, 2023 at 2:25 AM David Rowley wrote:
>
> On Mon, 30 Oct 2023 at 23:48, Amit Kapila wrote:
> >
> > On Fri, Oct 27, 2023 at 3:23 AM David Rowley wrote:
> > > * parallel.c in HandleParallelMessages():
> > > * applyparallelworker.c in HandleParallelApplyMessages():
> >
> > Both the ab
On Thu, Nov 2, 2023 at 4:35 PM Daniel Gustafsson wrote:
>
> > On 1 Nov 2023, at 07:33, John Naylor wrote:
> >
> > I didn't see any recent mentions in the archives, so I'll volunteer to
> > be CF manager for 2023-11.
>
> You probably need some extra admin privileges on your account for accessing
> On 1 Nov 2023, at 07:33, John Naylor wrote:
>
> I didn't see any recent mentions in the archives, so I'll volunteer to
> be CF manager for 2023-11.
You probably need some extra admin privileges on your account for accessing the
CFM functionality, in the meantime I've switched the 202311 CF to
On Thu, Nov 2, 2023 at 11:32 AM Michael Paquier wrote:
>
> On Thu, Nov 02, 2023 at 02:32:07PM +1100, Peter Smith wrote:
> > On Thu, Nov 2, 2023 at 2:25 PM Peter Smith wrote:
> >> Checking this patch yesterday prompted me to create a new thread
> >> questioning the inconsistencies of the "GUC name
Hi,
> That sounds like a much better solution. Attached you will find a v4
> that implements your suggestion. Please let me know if there is
> something that I missed. I can confirm that the patch works.
>
> $ ./build/src/bin/psql/psql -h pg.neon.tech
> NOTICE: Welcome to Neon!
>
Hi,
Seems that Tom's patch cannot be applied to the current master branch.
I just re-generate the patch for others to play with.
On 11/2/23, Nathan Bossart wrote:
> On Wed, Nov 01, 2023 at 10:39:04PM -0400, Tom Lane wrote:
>> Nathan Bossart writes:
>>> What if we disallowed NULL string GUCs in
On Wed, Nov 1, 2023 at 8:33 AM Michael Paquier wrote:
>
> On Fri, Oct 27, 2023 at 05:05:39PM +0530, Amit Kapila wrote:
> > I was analyzing this part and it seems it could be tricky to upgrade
> > in FINISHEDCOPY state. Because the system would expect that subscriber
> > would know the old slotname
At Wed, 1 Nov 2023 11:36:01 -0400, Bruce Momjian wrote in
> On Wed, Mar 31, 2021 at 01:43:47PM +0200, Christoph Berg wrote:
> > Re: Kyotaro Horiguchi
> > I like that because it points to the "point" syntax so users can
> > figure out how to spell a box.
>
> I liked Horiguchi-san's patch from 202
On Thu, Nov 02, 2023 at 08:19:35PM +1300, David Rowley wrote:
> No tests were introduced. Is this the only existing one that's
> unstable as far as you saw?
That seems to be the only one.
> I'm not yet seeing any failures in the buildfarm, so don't really want
> to push a fix for this one if the
On Thu, 2 Nov 2023 at 18:39, Michael Paquier wrote:
> The CI has been telling me that the plans of the tests introduced by
> this patch are not that stable when building with 32b. See:
> diff -U3 /tmp/cirrus-ci-build/contrib/postgres_fdw/expected/postgres_fdw.out
> /tmp/cirrus-ci-build/build-32/
On Thu, 02 Nov 2023 at 13:42, Japin Li wrote:
> On Thu, 02 Nov 2023 at 13:01, Noah Misch wrote:
>> On Wed, Nov 01, 2023 at 03:19:39PM +0800, Japin Li wrote:
>>> I try to run regression test on illumos, the 010_tab_completion will
>>> failed because of timeout.
>>
>>> Any suggestions? Thanks in
74 matches
Mail list logo
