Hi,
While reading the nbtree codes, I noticed that the comments on
BTScanInsertData no longer describes the meaning of the nextkey and
backward fields. The comment curently only says:
* See comments in _bt_first for an explanation of the nextkey and backward
* fields.
Detailed comments used to
On Mon, Nov 17, 2025 at 8:52 PM Daniel Gustafsson wrote:
>
> Some of the internals does seem bleed through. Do you want to work on a patch
> for a suggestion on an improvement? Maybe it could be possible to improve the
> wording by incorporating constraint_type in some way?
>
I have changed thi
Hi.
Matheus Alcantara писал(а) 2025-11-18 00:09:
On Sat Nov 15, 2025 at 7:57 AM -03, Alexander Pyhalov wrote:
Here are some comments on my first look at the patches. I still don't
have too much experience with the executor code but I hope that I can
help with something.
v5-0001-mark_async_capa
Some more review comments for v7.
==
1.
+ * The status or value of the options 'create_slot' and 'copy_data' not
+ * available in the catalog table. We can use default values i.e. TRUE
+ * for both. This is what pg_dump uses.
Is it consistent to just use defaults for these 2 parameters, an
On Tue, Nov 18, 2025 at 1:02 AM Masahiko Sawada wrote:
>
> On Sun, Nov 16, 2025 at 9:51 PM Amit Kapila wrote:
>
> >
> > In v26-0002-FIXUP-remove-status_change_allowed-flag, by using
> > status_change_inprogress, we ensure that no backend is allowed to
> > toggle the logical_wal/decoding status ti
> On 24 Dec 2024, at 01:46, Peter Geoghegan wrote:
>
> On Wed, Nov 20, 2024 at 4:41 AM Andrey M. Borodin
> wrote:
>>> On 15 Nov 2024, at 21:33, Peter Geoghegan wrote:
>>> I propose this for the master branch only.
>>
>> The change seems correct to me: anyway cycle must be less than cycle o
On Wed, Nov 12, 2025 at 10:46:12AM +0530, Ashutosh Bapat wrote:
> But C implementation uses ObjectIdGetDatum() where ObjectId is 32 bit integer.
> values[4] = ObjectIdGetDatum(fctx->record[i].forknum);
>
> Since forknum values are within 16 bits and that's unlikely to change
> in future, int2 seem
On Tue, Nov 18, 2025 at 3:20 AM Masahiko Sawada wrote:
>
> On Thu, Nov 13, 2025 at 4:47 PM Masahiko Sawada wrote:
> >
> > On Wed, Nov 12, 2025 at 11:57 AM Arseniy Mukhin
> > wrote:
> > >
> > > Hi,
> > >
> > > On Mon, Oct 13, 2025 at 5:54 PM Arseniy Mukhin
> > > wrote:
> > > >
> > > > Hi,
> > >
Hello,
On Mon, Nov 17, 2025 at 03:59:30PM +1300, Thomas Munro wrote:
> On Tue, Nov 11, 2025 at 10:49 AM Michael Banck wrote:
> > |login: task ./test_signalhandler(767) looked up a bogus port 23 for3205,
> > most probably a bug.
>
> . o O { An absurdly far-fetched thought while browsing glibc/hu
On Mon, Nov 17, 2025 at 4:35 PM Amit Kapila wrote:
>
> On Thu, Nov 13, 2025 at 3:22 PM vignesh C wrote:
> >
> > On Thu, 13 Nov 2025 at 09:12, Amit Kapila wrote:
> > >
> > > On Thu, Nov 13, 2025 at 4:31 AM Peter Smith wrote:
> > > >
> > > > CURRENT
> > > > seq_sync_error_count
> > > > sync_error
On Fri, Nov 14, 2025 at 4:45 PM Amit Kapila wrote:
>
> On Fri, Nov 14, 2025 at 10:43 AM Peter Smith wrote:
> >
> > On Fri, Nov 14, 2025 at 2:53 PM Amit Kapila wrote:
> > >
> > > On Thu, Nov 13, 2025 at 4:46 PM Chao Li wrote:
> > > > > On Nov 13, 2025, at 13:17, Peter Smith wrote:
> > > > >
> >
Hi,
Thank you for the review.
Please find the attached patch.
Regards,
Vaibhav
EnterpriseDB
On Tue, Nov 18, 2025 at 7:28 AM Peter Smith wrote:
> Some review comments for v6.
>
> ==
> src/backend/utils/adt/ruleutils.c
>
> 1.
> +/*
> + * pg_get_subscription_string
> + * Build CREATE SUBSCRIP
On Fri, Aug 22, 2025 at 08:48:57AM +, Bertrand Drouvot wrote:
> Yeah, I think so. Thanks for the ping, done in attached.
The patch has been marked as ready for committer, and I see the value
in providing a view where it is possible to know to which OS page a
given shared buffer is linked to, b
On Tue, Nov 18, 2025 at 01:07:23PM +0800, jian he wrote:
> + errsave(parse->escontext,
> + errcode(ERRCODE_INVALID_TEXT_REPRESENTATION),
> + errmsg("malformed pg_ndistinct: \"%s\"", parse->str),
> + errdetail("Invalid \"%s\" value.",
> + PG_NDISTINCT_KEY_NDISTINCT));
>
> the errdetail is way too
On Tue, Nov 18, 2025 at 12:31 PM Samuel Thibault
wrote:
> On Mon, Nov 17, 2025 at 03:59:30PM +1300, Thomas Munro wrote:
> > . o O { An absurdly far-fetched thought while browsing glibc/hurd glue
> > code: if synchronous I/O is implemented as RPC on Mach ports, could
> > that mean that it's technic
On Mon, Nov 17, 2025 at 5:49 PM Chao Li wrote:
...
> > #1.
> > My original change, to fix the [, ...] grouping to remove ambiguity.
> >
> > #2
> > Now renames "all_publication_object" to "publication_all_objects".
> > This is a simple name change that does not affect anything. I felt
> > everythin
On Mon, Nov 17, 2025 at 2:56 PM Michael Paquier wrote:
>
> On Fri, Nov 14, 2025 at 03:25:27PM +0900, Michael Paquier wrote:
> > Thanks for the new versions, I'll also look at all these across the
> > next couple of days. Probably not at 0005~ for now.
>
> 0001 and 0002 from series v13 have been a
> On Nov 18, 2025, at 13:03, Chao Li wrote:
>
> Hi Tatsuo-san,
>
> I just reviewed 0006 docs changes and 0001. I plan to slowly review the
> patch, maybe one commit a day.
>
>> On Nov 18, 2025, at 10:33, Tatsuo Ishii wrote:
>>
>> Attached are the v35 patches for Row pattern recognition.
Hi Tatsuo-san,
I just reviewed 0006 docs changes and 0001. I plan to slowly review the patch,
maybe one commit a day.
> On Nov 18, 2025, at 10:33, Tatsuo Ishii wrote:
>
> Attached are the v35 patches for Row pattern recognition. In v34-0001
> gram.y patch, %type for RPR were misplaced. v35-0
On Tue, Nov 18, 2025 at 10:32 AM Andrew Kim wrote:
> I've double-checked everything after applying the v9 checksum patches
> and updating pg_filedump accordingly.
> Following your suggestion, I removed the checksum_impl.h include and
> the Assert redefinition, keeping only the port/checksum.h inc
>
> > But, if we don't care about the order of the combinations, I also don't
> > think we need to expose the functions at all. We know exactly how many
> > combinations there should be for any N attributes as each attribute must
> be
> > unique. So if we have the right number of unique combination
On Tue, Nov 18, 2025 at 5:34 AM Masahiko Sawada wrote:
>
> On Mon, Nov 17, 2025 at 8:44 AM Nathan Bossart
> wrote:
> >
> > On Mon, Nov 17, 2025 at 04:04:17PM +0100, Daniel Gustafsson wrote:
> > > Oh right, I had forgotten about that, thanks for the reminder. The patch
> > > as
> > > proposed i
> On Nov 11, 2025, at 06:33, Corey Huinker wrote:
>
>
> My attempts to test this all got stuck in wait_on_slots(). I haven't
> looked too closely, but I suspect the issue is that the socket never
> becomes readable because we don't send a query. If I set free_slot->inUse
> to false before p
On Tue, Nov 18, 2025 at 8:56 AM Bruce Momjian wrote:
>
> On Sat, Nov 15, 2025 at 06:52:15PM -0500, Robert Treat wrote:
> > On Sat, Nov 15, 2025 at 9:32 AM Bruce Momjian wrote:
> > > On Sat, Nov 15, 2025 at 06:02:53PM +0800, Rambabu V wrote:
> > > > Hi Team,
> > > >
> > > > seems stats are not ret
On Mon, Nov 17, 2025 at 09:32:37PM -0500, Corey Huinker wrote:
> So I looked at the generator functions, hoping they'd have enough in common
> that they could be made generic. And they're just different enough that I
> think it's not worth it to try.
>
> But, if we don't care about the order of th
Hi John,
Thanks for taking the time to review the v9-0001 refactoring patch and
for setting the CF entry to Needs Review.
On Fri, Nov 14, 2025 at 3:34 AM John Naylor wrote:
>
> On Thu, Nov 6, 2025 at 6:50 AM Andrew Kim wrote:
> > The v9 patch series is attached.
>
> Thanks! BTW, I've set the c
Hi Sami,
Thanks for the feedback. I have refactored the commit on the latest version
of PG and added a few more tests. To simplify the roll out of this feature,
I decided to work on analyze=false use case first. Please find the attached
patch for the same.
Regards,
Dinesh
On Thu, Mar 6, 2025 at 4
Thanks for the quick fix.
There's another one (the last one) in the previous email that needs fixing:
HWCAP_SVE for pg_popcount_aarch64.c
😅
Tom Lane 于2025年11月18日周二 04:31写道：
> I wrote:
> > ... I'm inclined to think
> > it's better to do something like
>
> > +#if defined(__linux__) && (defined(
Hi,
Some comments:
1===
Is there a test case can reproduce the assert fail in
SnapBuildGetOrBuildSnapshot()?
2===
We skip xact_decode() when SnapBuildCurrentState(builder) <
SNAPBUILD_FULL_SNAPSHOT, but it's a bug, so your NO.3 modification might be
wrong.
See threads in this for det
On Mon, Nov 17, 2025 at 6:35 PM Michael Paquier wrote:
> On Mon, Nov 17, 2025 at 08:53:35PM +0800, jian he wrote:
> > segfault:
> > SELECT '[{"attributes" : [1,2,3,4,5,67,6,7,8], "ndistinct" :
> 4}]'::pg_ndistinct;
> >
> > because src/backend/statistics/mvdistinct.c line: 310, Assert
> > Assert((
>
>
> This feels like a different pretty still compressed output for json.
> I don't think we should change the output functions to do that, but if
> you want to add a function that filters these contents a bit in the
> tests for the input functions, sure, why not.
>
+1, I'll probably just use the
Hi,
On Sun, Nov 16, 2025 at 8:01 AM 河田達也 wrote:
>
> Hi,
>
> I would like to propose a patch that adds memory usage reporting to
> VACUUM VERBOSE output. This helps users understand how much memory
> is being used for dead tuple tracking and whether memory limits are
> being hit during vacuum oper
On Mon, Nov 17, 2025 at 05:42:03PM +0300, Timur Magomedov wrote:
> On Fri, 2025-11-14 at 14:22 +0800, Japin Li wrote:
> > Yes, I can reproduce this by using your patch.
>
> Hello Japin!
> Thanks for reproducing the bug!
> I've made a fix on top of recent VCI version v20251117:
> https://www.postgr
Hi Nathan,
I just reviewed the patch. Looks to me the correct three-commit split:
0001 updates tooling/configure so that 0002 will not introduce formatting
violation
0002 makes large formatting rewrite (tab->white spaces), and so that the commit
needs to be added to .git-blace-ignore-revs
0003
Hi yuefei,
Thanks for your review.
At 2025-11-18 09:13:12, "Yuefei Shi" wrote:
> - /* only build a new snapshot if we don't have a prebuilt one */
> - if (builder->snapshot == NULL)
> - {
> - builder->snapshot = SnapBuildBuildSnapshot(builder);
> - /* increase refcount for the snapshot builder
On Thu, Nov 6, 2025 at 3:49 PM Matheus Alcantara
wrote:
>
> On Fri Oct 31, 2025 at 4:02 PM -03, I wrote:
> > It's showing a bit complicated to decide at runtime if we should use the
> > COPY or INSERT for batch insert into a foreign table. Perhaps we could
> > add a new option on CREATE FOREIGN TA
Some review comments for v6.
==
src/backend/utils/adt/ruleutils.c
1.
+/*
+ * pg_get_subscription_string
+ * Build CREATE SUBSCRIPTION statement for a subscription from its OID.
+ *
+ * This is internal version which helps pg_get_subscription_ddl_by_name() and
+ * pg_get_subscription_ddl_by_oi
On Fri, 7 Nov 2025 at 18:31, David Rowley wrote:
> I still need to do a bit more testing on this, but in the meantime
> thought I'd share what I've done with it so that other people can look
> in parallel.
I've been looking at the v11 patch again. I did some testing and can't break it.
I noted d
Hi Heikki
> I don't think we need to support that case. I hope there are no clusters
> in that state still in the wild, and you can work around it by upgrading
> to 9.3.5 or above and letting autovacuum run. But I wonder if a
> pre-upgrade check with a better error message would still be worthwhile
Hi Hackers,
I just noticed that for CREAT TABLE and ALTER TABLE, the doc states the
parameter “CONNECTION LIMIT”, but “CONNECTION_LIMIT” is also supported. But the
doc doesn’t mention anything about the alternative, should we add a short
statement such as “CONNECTION_LIMIT is also supported” to
Hi，
ocean_li_996 于2025年11月18日周二 08:48写道：
> Hi hackers,
> While reviewing the snapbuild implementation, I noticed several small
> changes that could improve code clarity, correctness, and reuse.
> I have prepared a patch with these modifications (attached):
>
> 1. Removed the Assert in SnapBuildGe
Hi Akshay,
I just reviewed v3 and got some comments:
> On Nov 17, 2025, at 22:34, Akshay Joshi wrote:
>
> All the review comments have been addressed in v3 patch.
1 - ruleutils.c
```
+ if (dbForm->datconnlimit != 0)
+ get_formatted_string(&buf, prettyFlags, 1, "CONNECTION
On Fri, Nov 14, 2025 at 09:52:41PM -0500, Bruce Momjian wrote:
> On Sat, Nov 15, 2025 at 01:41:04AM +0100, Tomas Vondra wrote:
> > > And then there is the problem of detecting when this happens.
> > >
> > > I think my big question is, when we join A->B->C->D, we do a lot of work
> > > in the optim
On Thu, Nov 13, 2025 at 4:47 PM Masahiko Sawada wrote:
>
> On Wed, Nov 12, 2025 at 11:57 AM Arseniy Mukhin
> wrote:
> >
> > Hi,
> >
> > On Mon, Oct 13, 2025 at 5:54 PM Arseniy Mukhin
> > wrote:
> > >
> > > Hi,
> > >
> > > On Thu, Oct 9, 2025 at 2:03 AM Masahiko Sawada
> > > wrote:
> > > >
> >
On Sat, Nov 15, 2025 at 06:52:15PM -0500, Robert Treat wrote:
> On Sat, Nov 15, 2025 at 9:32 AM Bruce Momjian wrote:
> > On Sat, Nov 15, 2025 at 06:02:53PM +0800, Rambabu V wrote:
> > > Hi Team,
> > >
> > > seems stats are not retained after upgrade. Below are the artifacts , is
> > > it
> > > ex
On Tue, Nov 18, 2025 at 08:31:41AM +0900, Michael Paquier wrote:
> Hmm. We should try to conclude over the benefit of TAP over
> isolation, and merge both patches together if the consensus is towards
> a TAP test.
>
> The isolation test feels much cleaner to me in terms of clarity and
> debugging
On Sun, Nov 16, 2025 at 01:03:30PM +0800, Rambabu V wrote:
> Thanks all for the proactive response and clarification.
>
> people will be confused by seeing the release notes, it should be a little bit
> clear or need to update.
Yes, the release notes are clear, but the non-release docs are not.
On Mon, Nov 17, 2025 at 08:53:35PM +0800, jian he wrote:
> segfault:
> SELECT '[{"attributes" : [1,2,3,4,5,67,6,7,8], "ndistinct" :
> 4}]'::pg_ndistinct;
>
> because src/backend/statistics/mvdistinct.c line: 310, Assert
> Assert((item->nattributes >= 2) && (item->nattributes <=
> STATS_MAX_DIMEN
On Mon, Nov 17, 2025 at 06:45:30PM +0300, Nazir Bilal Yavuz wrote:
> I have two patches to implement this: one moving the killtuples test
> under test/modules/index/, and another adding coverage for the
> recovery path.
>
> 0001 moves killtuples test under the test/modules/index/ without any
> imp
On Mon, Nov 17, 2025 at 12:18:55PM -0500, Corey Huinker wrote:
> On Mon, Nov 17, 2025 at 1:56 AM Michael Paquier wrote:
> Though, I was thinking some more about the output format. Using
> jsonb_pretty() makes it readable in one way, and very clumsy in other ways.
> Instead, I'm going to try doing
On Tue, Nov 18, 2025, 07:16 Nathan Bossart wrote:
> I'd like to mark myself as the committer this one, but I noticed that the
> commitfest entry [0] has been marked as Withdrawn. Could someone either
> reopen it or create a new one as appropriate (assuming there is a desire to
> continue with it
I created a commitfest entry for this one.
https://commitfest.postgresql.org/patch/6230/
--
nathan
On Mon, Nov 17, 2025 at 10:36 PM Michael Banck wrote:
> I mentioned that in a follow-up[0] to my original mail that you
> apparently did not see eiter:
>
> |By the way, on the back branches from 13-15 (before the above commit)
> |process title changes don't work either, presumably because __hurd__
I'd like to mark myself as the committer this one, but I noticed that the
commitfest entry [0] has been marked as Withdrawn. Could someone either
reopen it or create a new one as appropriate (assuming there is a desire to
continue with it)? I'm hoping to start spending more time on it soon.
[0]
Following up on Tom Lane's suggestion to use MemoryContexts for GUC
extra data [1], I've implemented a working solution that addresses the
design issues Robert Haas identified with my initial approach.
The original problem: GUC check hooks can only return a single chunk for
extra data, making it
On Sat Nov 15, 2025 at 7:57 AM -03, Alexander Pyhalov wrote:
>> Here are some comments on my first look at the patches. I still don't
>> have too much experience with the executor code but I hope that I can
>> help with something.
>>
>> v5-0001-mark_async_capable-subpath-should-match-subplan.patch
On Mon, Nov 17, 2025 at 8:44 AM Nathan Bossart wrote:
>
> On Mon, Nov 17, 2025 at 04:04:17PM +0100, Daniel Gustafsson wrote:
> > Oh right, I had forgotten about that, thanks for the reminder. The patch as
> > proposed is correct then.
>
> The patch is probably fine as-is, but this seems like a ca
I wrote:
> ... I'm inclined to think
> it's better to do something like
> +#if defined(__linux__) && (defined(__aarch64__) ? !defined(HWCAP_CRC32) :
> !defined(HWCAP2_CRC32))
> or perhaps that's too unreadable and we should break it out into
> multiple #if's.
I tried it as a nest of #ifdef's an
On Mon, Nov 17, 2025 at 10:13:30AM -0800, Jacob Champion wrote:
> On Fri, Oct 31, 2025 at 3:54 PM Jacob Champion
> wrote:
> > On Fri, Oct 31, 2025 at 2:55 PM Andres Freund wrote:
> > > msys '(echo; echo o conf recommends_policy 0; echo notest install
> > > IPC::Run) | cpan'
> >
> > Heh. Okay, I'
Steven Niu writes:
> IvorySQL team found the same build issue on our building machine when we
> built IvorySQL code which is based on PG 18.0.
> pg_crc32c_armv8_choose.c:58:32:error:'HWCAP CRC32' undeclared(first use in
> this function)
> 58 | return (getauxval(AT_HWCAP) & HWCAP_CRC32) != θ
On Sun, Nov 16, 2025 at 9:51 PM Amit Kapila wrote:
>
> On Fri, Nov 14, 2025 at 5:10 PM Masahiko Sawada wrote:
> >
> > On Fri, Nov 14, 2025 at 3:12 AM Amit Kapila wrote:
> > >
> > > On Fri, Nov 14, 2025 at 4:15 PM Masahiko Sawada
> > > wrote:
> > > >
> > > > On Fri, Nov 14, 2025 at 1:38 AM Amit
Nathan Bossart writes:
> Here is a rebased patch set. Notably, I've split it into three pieces.
> I'm planning to add 0002 to .git-blame-ignore-revs, as testing indicates
> this preserves the blame history reasonably well.
Good idea.
regards, tom lane
Alexander Korotkov writes:
> On Sun, Nov 16, 2025 at 7:27 PM Tom Lane wrote:
>> I dug into the history a little and could not find anything except
>> [1], which says
>>
>> I have made some changes (attachment).
>> * if the operator expression left or right side type category is
>> {array | domai
Here is a rebased patch set. Notably, I've split it into three pieces.
I'm planning to add 0002 to .git-blame-ignore-revs, as testing indicates
this preserves the blame history reasonably well.
--
nathan
>From 5d88f5b026dfe764d4e401297025ea865ae18bc5 Mon Sep 17 00:00:00 2001
From: Nathan Bossart
I wrote:
> Actually, after sleeping on it it seems like the obvious thing is
> to test "sslot1.nvalues * sslot2.nvalues", since the work we are
> thinking about saving scales as that product. But I'm not sure
> what threshold value to use if we do that. Maybe around 1?
Or maybe better, since
> > Thanks for starting this thread! This is a very useful
> > feature that users will find beneficial to easily narrow
> > down the reason the xmin horizon is being held back,
> > and take action.
>
> +1 for the idea. In BackendXidFindCutOffReason() you have directly
> reported using NOTICE I bel
Ilia Evdokimov writes:
> On 14.11.2025 01:21, Tom Lane wrote:
>> So after a bit of hacking I ended up with the attached. I split up
>> the refactorization into several steps to make it easier to review.
> I reviewed patches 0002-0004 with the refactoring, and I think the
> overall approach is e
On Fri, Oct 31, 2025 at 2:40 PM Jacob Champion
wrote:
> I even considered pulling the tarball straight from Github and
> hardcoding the shasum for it
(For anyone who tries this in the future: Github's source tarballs
don't appear to be stable over time.)
On Fri, Oct 31, 2025 at 3:54 PM Jacob Cha
Hi,
On Mon, Nov 17, 2025 at 01:12:24PM +, Bertrand Drouvot wrote:
> The script has been updated and the patch too (finding a new replacement in
> gist.c).
Finally, adding GistNSN to the game (as a typedef XLogRecPtr) gives the
attached.
Regards,
--
Bertrand Drouvot
PostgreSQL Contributors
On 11/17/25 10:23, Jakub Wartak wrote:
> On Tue, Nov 11, 2025 at 12:52 PM Tomas Vondra wrote:
>>
>> Hi,
>>
>> here's a rebased patch series, fixing most of the smaller issues from
>> v20251101, and making cfbot happy (hopefully).
>
> Hi Tomas,
>
> 0007b: pg_buffercache_pgproc -- nitpick,
On Mon, Nov 17, 2025 at 1:56 AM Michael Paquier wrote:
> On Fri, Nov 14, 2025 at 03:25:27PM +0900, Michael Paquier wrote:
> > Thanks for the new versions, I'll also look at all these across the
> > next couple of days. Probably not at 0005~ for now.
>
> 0001 and 0002 from series v13 have been ap
Hi hackers,
While reviewing the snapbuild implementation, I noticed several small changes
that could improve code clarity, correctness, and reuse.
I have prepared a patch with these modifications (attached):
1. Removed the Assert in SnapBuildGetOrBuildSnapshot(). When called from
logicalmsg_de
Thanks Andrew for the review.
On Tue, 11 Nov 2025 at 20:41, Andrew Dunstan wrote:
>
>
> On 2025-11-11 Tu 12:59 AM, Mahendra Singh Thalor wrote:
> >
> > Hi,
> > Here, I am attaching an updated patch for the review and testing.
> >
> > FIX: as suggested by Vaibhav, added error for --restrict-key opt
On 11/14/25 21:19, Masahiko Sawada wrote:
> After offline discussions with Sutou-san, we believe the current APIs
> work well, particularly for text-based formats, though we still need
> to verify there are no performance regressions.
I got pinged about this patch off-list. I won't have capacity t
On Mon, Nov 17, 2025 at 04:04:17PM +0100, Daniel Gustafsson wrote:
> Oh right, I had forgotten about that, thanks for the reminder. The patch as
> proposed is correct then.
The patch is probably fine as-is, but this seems like a candidate for the
ClosestMatch stuff added by commit 5ac51c8.
--
n
Hi,
On Fri, 31 Oct 2025 at 03:42, Michael Paquier wrote:
>
> On Thu, Oct 30, 2025 at 11:24:55AM -0400, Andres Freund wrote:
> > Well, it tests multiple index types, not just gist. I guess
> > test/modules/indexes/ or so should work? Not sure about plural or not.
>
> test/modules/index/ would work
Hi David,
It looks like there are some technical issues, but Tom and I are
currently discussing version 5 of the patches. Here is the link to the
ongoing discussion [0]. If you have any suggestions or feedback about
the patches, feel free to share them.
[0]:
https://www.postgresql.org/messa
Hi John!
On 15.11.2025 03:47, John Naylor wrote:
> On Sat, Nov 15, 2025 at 1:05 AM David Geier wrote:
>> I understand that you want to make progress with the use case at hand
>> but I feel like we're missing out on a lot of opportunity where the
>> introduced code would also be very beneficial.
>
Hi Ilia!
On 16.09.2025 17:52, Ilia Evdokimov wrote:
> Hi hackers,
>
> On 10.09.2025 16:56, Ilia Evdokimov wrote:
>> Unfortunately, the JOB benchmark does not contain semi join nodes.
>> However, TPC-DS does. I'll look for the queries with slowest planner
>> times there and check them.
>>
>> I'll
Hi Ilia!
On 13.10.2025 12:08, Ilia Evdokimov wrote:
>
> On 17.09.2025 12:40, Ilia Evdokimov wrote:
>> In v2 patch, when the join is reversed we pass the commutator operator
>> Oid to eqjoinsel_semi(), and inside that function we immediately call
>> get_opcode(). Did you mean for the function
>> t
On 14.11.2025 01:21, Tom Lane wrote:
This didn't look very much like the refactorization that I had in
mind: I thought we should have one copy of the matching code, not two.
Also, after looking closer at your patch I realized you were just
punting for cross-type comparison operators, which I fel
On Mon, Nov 17, 2025 at 9:42 AM Matheus Alcantara
wrote:
> I've spent some time playing with these patches. I still don't have to
> much comments on the syntax yet but I've noticed a small bug or perhaps
> I'm missing something?
Cool, thanks for looking. I am guessing that the paucity of feedback
On Tue, Nov 18, 2025 at 12:11 AM Thomas Munro wrote:
> On Mon, Nov 17, 2025 at 9:48 PM Anthonin Bonnefoy
> wrote:
> > Homebrew is now installing LLVM21 by default, so compiling with Homebrew's
> > default LLVM now fails without this patch.
>
> Ack, testing...
Looks good so far. Will try to pus
> On 17 Nov 2025, at 15:59, Fujii Masao wrote:
>
> On Mon, Nov 17, 2025 at 11:30 PM Daniel Gustafsson wrote:
>>
>>> On 17 Nov 2025, at 15:08, Sugamoto Shinya wrote:
>>
>>> I ordered the valid encodings alphabetically and extracted those into
>>> separate parameters.
>>
>> LGTM. Per project
On Mon, Nov 17, 2025 at 11:30 PM Daniel Gustafsson wrote:
>
> > On 17 Nov 2025, at 15:08, Sugamoto Shinya wrote:
>
> > I ordered the valid encodings alphabetically and extracted those into
> > separate parameters.
>
> LGTM. Per project style I don't think we should quote the names of encodings
Hi Hackers,
Thank you Chao Li, Peter Smith and Alvaro for the review.
I have incorporated all your review comments except below ones:
7
>
> ```
> + /* Append connection info to the CREATE SUBSCRIPTION statement */
> + appendStringInfo(&buf, "CONNECTION \'%s\'", conninfo);
> ```
> A co
Hi
On Thu Nov 6, 2025 at 1:45 PM -03, Robert Haas wrote:
> Here's v3. I've attempted to fix some more things that cfbot didn't
> like, one of which was an actual bug in 0005, and I also fixed a
> stupid few bugs in pgpa_collector.c and added a few more tests.
>
I've spent some time playing with th
On Fri, 2025-11-14 at 14:22 +0800, Japin Li wrote:
> Yes, I can reproduce this by using your patch.
Hello Japin!
Thanks for reproducing the bug!
I've made a fix on top of recent VCI version v20251117:
https://www.postgresql.org/message-id/1de545d00a5c0bb8aaf42f05dd118a2c19030041.camel%40postgrespr
The v3 patch adds a check for the CONNECT privilege on the target database
for pg_get_database_ddl(). This aligns its security model with functions
like pg_database_size(). Note that revoking permissions on the *pg_database*
table alone is insufficient to restrict DDL access; users must manually
re
On Fri, Nov 14, 2025 at 11:19 AM Japin Li wrote:
> On Thu, Nov 13, 2025 at 02:02:30PM +0530, Akshay Joshi wrote:
> > On Thu, Nov 13, 2025 at 10:18 AM Quan Zongliang
> > wrote:
> >
> > >
> > >
> > > On 11/13/25 12:17 PM, Quan Zongliang wrote:
> > > >
> > > >
> > > > On 11/12/25 8:04 PM, Akshay Jo
On Mon, 2025-11-17 at 12:34 +1100, Peter Smith wrote:
> Here are the latest patches.
>
> Changes include:
>
> PATCH 0002.
> - Address a new compiler warning reported by CI
>
Hello Peter!
Thanks for updating the patch!
According to the issue I've found recently with incorrect WAL record
[1], I've
> On 17 Nov 2025, at 15:08, Sugamoto Shinya wrote:
> I ordered the valid encodings alphabetically and extracted those into
> separate parameters.
LGTM. Per project style I don't think we should quote the names of encodings
since they are visibly not English words (see commit a243569bf65c5 whic
Manni Wood
[image: Attachments]8:09 AM (13 minutes ago)
to *Álvaro*, *psql-hackers*, *Chao*, *Nishant*, *Jim*
Hello! After waiting all weekend, my Friday e-mail did not get through
psql-hackers, so I am sending again, using Álvaro's advice to send to
lists.postgresql.org rather than plain postgres
On Tue, Nov 11, 2025 at 11:29 AM Mahendra Singh Thalor
wrote:
> On Thu, 6 Nov 2025 at 11:03, Mahendra Singh Thalor
> wrote:
> >
> > Thanks Vaibhav, Tushar and Andrew for the review and testing.
>
>
Thanks Mahendra, getting this error against v07 series patch
[edb@1a1c15437e7c bin]$ ./pg_dumpal
On Thu, Nov 13, 2025 at 9:58 AM Fujii Masao wrote:
> On Wed, Nov 12, 2025 at 10:23 PM Sugamoto Shinya
> wrote:
> > Thanks everyone for reviewing my proposal.
> > I've hard-coded the valid list of encoding names.
> >
> > Also, I modified the hint string into like "Valid encodings are \"hex\",
> \
Hi,
Based on documentation and experimentation, I believe the behavior works as
> follows, but I would appreciate
> confirmation or corrections:
>
> 1/ When the extension is listed in shared_preload_libraries: _PG_init()
> is executed before the server
> starts accepting connections, and hooks are
On Fri, 14 Nov 2025 18:08:24 +0900
Fujii Masao wrote:
> On Fri, Nov 14, 2025 at 4:50 PM Yugo Nagata wrote:
> > I could not reproduce it with the latest REL_16_STABLE branch.
> > Perhaps, the assertion failure you mentioned above was the one
> > fixed by 1d3ded521?
>
> Yeah, you're right! Thanks
On Tue, Nov 11, 2025 at 8:37 AM jian he wrote:
>
> On Thu, Nov 6, 2025 at 6:00 AM Corey Huinker wrote:
> > [...]
>
> Currently, patches v9-0001 through v9-0018 focus solely on refactoring
> pg_cast.castfunc.
I had a quick look but haven't finished the full review due to lack of
time today. Here
Hi,
On Thu, Nov 13, 2025 at 02:11:08PM +, Bertrand Drouvot wrote:
> On Fri, Nov 07, 2025 at 02:37:32PM +0100, Álvaro Herrera wrote:
>
> I guess/hope you'll get the same results if you use run_parallel.sh as
> mentioned
> above.
The .cocci script had an issue (not always detecting correctly
Added to CF: https://commitfest.postgresql.org/patch/6226/
> On Nov 12, 2025, at 09:10, Chao Li wrote:
>
>
>
> On Mon, Nov 10, 2025 at 8:02 PM Dagfinn Ilmari Mannsåker
> wrote:
> Chao Li writes:
>
> > Hi Hacker,
> >
> > While working on the other patch and editing guc_parameters.dat, I
> >
1 - 100 of 133 matches
Mail list logo
