Re: PostgreSQL Limits: maximum number of columns in SELECT result

2022-05-31 Thread Gavin Flower
On 1/06/22 12:42, Tom Lane wrote: David Rowley writes: I've adjusted the patch to use the wording proposed by Alvaro. See attached. Should we also change the adjacent item to "columns in a table", for consistency of wording? Not sure though, because s/per/in a/ throughout the list doesn't

Re: [PATCH] Proposal for HIDDEN/INVISIBLE column

2021-10-14 Thread Gavin Flower
On 15/10/21 07:01, Josef Šimánek wrote: čt 14. 10. 2021 v 13:17 odesílatel Gilles Darold napsal: Hi, Here is a proposal to implement HIDDEN columns feature in PostgreSQL. The user defined columns are always visible in the PostgreSQL. If user wants to hide some column(s) from a SELECT *

Re: Release 14 Schedule

2021-09-21 Thread Gavin Flower
On 21/09/21 14:23, Jonathan S. Katz wrote: On 9/20/21 2:33 AM, Nikolay Samokhvalov wrote: Observability-related improvements are also good and very important for the future of DBA operations -- compute_query_id, new pg_stat_**, etc. Things like new knob idle_session_timeout and 

Re: Data loss when '"json_populate_recorset" with long column name

2021-09-07 Thread Gavin Flower
On 8/09/21 2:08 am, Tom Lane wrote: Julien Rouhaud writes: On Tue, Sep 7, 2021 at 1:31 PM Michael Paquier wrote: Yeah. We should try to work toward removing the limits on NAMEDATALEN for the attribute names. Easier said than done :) Yes, but even if we eventually fix that my impression is

Re: Default to TIMESTAMP WITH TIME ZONE?

2021-08-13 Thread Gavin Flower
On 13/08/21 5:14 pm, Greg Stark wrote: I think having a GUC to change to a different set of semantics is not workable. However that doesn't mean we can't do anything. We could have a GUC that just disables allowing creating columns of type timestamp without tz. That could print an error with a

Re: 2021-08-12 release announcement draft

2021-08-11 Thread Gavin Flower
On 12/08/21 11:25 am, David Rowley wrote: Thanks for drafting this up. On Thu, 12 Aug 2021 at 04:32, Jonathan S. Katz wrote: Please ensure you have your feedback in no later than midnight today (Aug 11) AoE[1]. It might not be the exact technical feedback you had in mind, but I think the

Re: add operator ^= to mean not equal (like != and <>)

2021-08-10 Thread Gavin Flower
On 10/08/21 8:27 pm, 孙诗浩(思才) wrote: Hi everyone, I am doding some jobs in postgres. I want to add "^=" like "!=" and "<>". One problem is that '^' & '^=' is already used as the exclusive OR operator in programming languages such as: C, Java, JavaScript, and Python.  See:

Re: Replace l337sp34k in comments.

2021-07-30 Thread Gavin Flower
On 30/07/21 8:05 pm, Geoff Winkless wrote: On Thu, 29 Jul 2021 at 22:46, Gavin Flower wrote: Though in code, possibly it would be better to just use 'up-to-date' in code for consistency and to make the it easier to grep? If it's causing an issue, perhaps using a less syntactically problematic

Re: Replace l337sp34k in comments.

2021-07-29 Thread Gavin Flower
On 30/07/21 12:51 am, Geoff Winkless wrote: On Thu, 29 Jul 2021 at 11:22, Andrew Dunstan > wrote: Personally, I would have written this as just "up to date", I don't think the hyphens are required. FWIW Mirriam-Webster and the CED suggest "up-to-date" when

Re: Add proper planner support for ORDER BY / DISTINCT aggregates

2021-07-02 Thread Gavin Flower
On 2/07/21 8:39 pm, David Rowley wrote: On Fri, 2 Jul 2021 at 19:54, Ronan Dunklau wrote: I don't know if it's acceptable, but in the case where you add both an aggregate with an ORDER BY clause, and another aggregate without the clause, the output for the unordered one will change and use the

Re: Continuing instability in insert-conflict-specconflict test

2021-06-13 Thread Gavin Flower
On 14/06/21 11:49 am, Andres Freund wrote: Hi, On 2021-06-13 15:22:12 -0700, Noah Misch wrote: On Sun, Jun 13, 2021 at 06:09:20PM -0400, Tom Lane wrote: We might be able to get rid of the stuff about concurrent step completion in isolationtester.c if we required the spec files to use

Re: "an SQL" vs. "a SQL"

2021-06-10 Thread Gavin Flower
On 11/06/21 8:17 am, Isaac Morland wrote: On Thu, 10 Jun 2021 at 16:11, Gavin Flower mailto:gavinflo...@archidevsys.co.nz>> wrote: On 11/06/21 2:48 am, Isaac Morland wrote: > “A MIT …”? As far as I know it is pronounced M - I - T, which would > imply that i

Re: "an SQL" vs. "a SQL"

2021-06-10 Thread Gavin Flower
On 11/06/21 2:48 am, Isaac Morland wrote: On Thu, 10 Jun 2021 at 10:43, David Rowley > wrote: -      requires an MIT Kerberos installation and opens TCP/IP listen sockets. +       requires a MIT Kerberos installation and opens TCP/IP listen sockets.

Re: GSoC 2021 - Student looking for a mentor - Magzum Assanbayev

2021-04-04 Thread Gavin Flower
On 03/04/2021 06:14, Magzum Assanbayev wrote: Dear Sirs, Note that there are some females that hack pg! My name is Magzum Assanbayev, I am a Master Student at KIMEP University in Kazakhstan, expected to graduate in Spring 2022. Having made some research into your organization I have

Re: builtin functions, parameter names and psql's \df

2020-09-02 Thread Gavin Flower
On 02/09/2020 19:15, Julien Rouhaud wrote: On Wed, Sep 2, 2020 at 9:13 AM Oleksandr Shulgin wrote: On Wed, Sep 2, 2020 at 7:35 AM Andres Freund wrote: Hi, on a regular basis I remember a builtin function's name, or can figure it out using \df etc, but can't remember the argument order. A

Re: Hybrid Hash/Nested Loop joins and caching results from subplans

2020-08-25 Thread Gavin Flower
On 25/08/2020 20:48, David Rowley wrote: On Tue, 25 Aug 2020 at 08:26, Andres Freund wrote: While I'm against introducing a separate node for the caching, I'm *not* against displaying a different node type when caching is present. E.g. it'd be perfectly reasonable from my POV to have a 'Cached

Re: color by default

2020-01-05 Thread Gavin Flower
On 06/01/2020 18:38, Michael Paquier wrote: On Fri, Jan 03, 2020 at 01:10:30PM -0500, Robert Haas wrote: On Thu, Jan 2, 2020 at 6:38 PM Gavin Flower wrote: I find coloured output very difficult to read, as the colours seem to be chosen on the basis everyone uses white as the background colour

Re: color by default

2020-01-02 Thread Gavin Flower
On 01/01/2020 02:35, Tom Lane wrote: Peter Eisentraut writes: With the attached patch, I propose to enable the colored output by default in PG13. FWIW, I shall be setting NO_COLOR permanently if this gets committed. I wonder how many people there are who actually *like* colored output? I find

Re: Unknown type name bool

2019-07-12 Thread Gavin Flower
On 12/07/2019 17:54, Igal Sapir wrote: On Thu, Jul 11, 2019 at 10:27 PM Michael Paquier > wrote: On Thu, Jul 11, 2019 at 10:21:06PM -0700, Igal Sapir wrote: > Any thoughts?  (disclaimer: I have much more experience with Java than C) We don't support

Re: New EXPLAIN option: ALL

2019-06-19 Thread Gavin Flower
On 19/06/2019 18:15, Peter Eisentraut wrote: On 2019-06-18 23:15, David Fetter wrote: Are you proposing something along the lines of this? PROFILE [statement]; /* Shows the plan */ PROFILE RUN [statement]; /* Actually executes the query */ No, it would be EXPLAIN statement; /* Shows the plan

Re: [PATCH] Stop ALTER SYSTEM from making bad assumptions

2019-06-16 Thread Gavin Flower
On 17/06/2019 05:58, Magnus Hagander wrote: On Sun, Jun 16, 2019 at 7:43 PM Stephen Frost > wrote: * Tom Lane (t...@sss.pgh.pa.us ) wrote: > Stephen Frost mailto:sfr...@snowman.net>> writes: > > what we should do is clean

Re: PostgreSQL pollutes the file system

2019-03-27 Thread Gavin Flower
On 28/03/2019 03:41, Tom Lane wrote: Andreas Karlsson writes: On 3/27/19 3:26 PM, Tomas Vondra wrote: That is true, of course. But are there actual examples of such conflicts in practice? I mean, are there tools/packages that provide commands with a conflicting name? I'm not aware of any, and

Re: PostgreSQL pollutes the file system

2019-03-27 Thread Gavin Flower
On 28/03/2019 03:07, Andreas Karlsson wrote: On 3/27/19 2:51 PM, Tomas Vondra wrote: I think the consensus in this thread (and the previous ancient ones) is that it's not worth it. It's one thing to introduce new commands with the pg_ prefix, and it's a completely different thing to rename

Re: Should we increase the default vacuum_cost_limit?

2019-03-09 Thread Gavin Flower
On 10/03/2019 06:55, Tom Lane wrote: Andrew Dunstan writes: On 3/9/19 4:28 AM, David Rowley wrote: I agree that vacuum_cost_delay might not be granular enough, however. If we're going to change the vacuum_cost_delay into microseconds, then I'm a little concerned that it'll silently break

Re: Using POPCNT and other advanced bit manipulation instructions

2019-02-13 Thread Gavin Flower
On 14/02/2019 11:17, Alvaro Herrera wrote: On 2019-Feb-13, Alvaro Herrera wrote: It definitely is ... plans have changed from using IndexOnly scans to Seqscans, which is likely fallout from the visibilitymap_count() change. I think the problem here is that "unsigned long" is 32 bits in this

Re: [Patch] Log10 and hyperbolic functions for SQL:2016 compliance

2019-02-11 Thread Gavin Flower
On 12/02/2019 06:44, Lætitia Avrot wrote: Hi Andrew and Tom, I considered that option before writing my patch but I refrained for 2 reasons: - There is no consensus about how to name these functions. The standard 8000-2 goes with arsinh, arcosh and artanh,   but you will find easily

Re: Commit Fest 2019-01 is now closed

2019-02-07 Thread Gavin Flower
On 08/02/2019 00:53, Peter Eisentraut wrote: On 06/02/2019 21:09, Magnus Hagander wrote: This has now been pushed and is available. I've set it up with stable, 12 and 13 as possible versions for now, but I have not added any tags to the existing patches (except for one, in order to test it).

Re: Early WIP/PoC for inlining CTEs

2019-01-21 Thread Gavin Flower
On 22/01/2019 02:40, Andreas Karlsson wrote: On 1/18/19 9:34 PM, Robert Haas wrote: On Thu, Jan 17, 2019 at 10:48 AM Andreas Karlsson wrote: On 1/11/19 8:10 PM, Robert Haas wrote: WITH cte_name [[NOT] MATERIALIZED] AS (query) main_query... Hm, when would one want "NOT MATERIALIZED"? I am

Re: Protect syscache from bloating with negative cache entries

2019-01-17 Thread Gavin Flower
On 18/01/2019 08:48, Bruce Momjian wrote: On Thu, Jan 17, 2019 at 11:33:35AM -0500, Robert Haas wrote: The flaw in your thinking, as it seems to me, is that in your concern for "the likelihood that cache flushes will simply remove entries we'll soon have to rebuild," you're apparently unwilling

Re: Using POPCNT and other advanced bit manipulation instructions

2018-12-19 Thread Gavin Flower
On 20/12/2018 18:53, David Rowley wrote [...] Patched: postgres=# analyze t1; Time: 680.833 ms Time: 699.976 ms Time: 695.608 ms Time: 676.007 ms Time: 693.487 ms Time: 726.982 ms Time: 677.835 ms Time: 688.426 ms Master: postgres=# analyze t1; Time: 721.837 ms Time: 756.035 ms Time: 734.545

Re: Record last password change

2018-12-11 Thread Gavin Flower
On 11/12/2018 23:33, Michael Banck wrote: Hello, a customer recently mentioned that they'd like to be able to see when a (md5, scram) role had their password last changed. Use-cases for this would be issueing an initial password and then later making sure it got changed, or auditing that all

Re: pgsql: Remove WITH OIDS support, change oid catalog column visibility.

2018-11-21 Thread Gavin Flower
On 21/11/2018 21:20, Christoph Berg wrote: Re: Andres Freund 2018-11-21 The biggest user of WITH OID columns was postgres' catalog. This commit changes all 'magic' oid columns to be columns that are normally declared and stored. postgres=# \d+ pg_class [...] Indexe: "pg_class_oid_index"

Re: Speeding up INSERTs and UPDATEs to partitioned tables

2018-10-31 Thread Gavin Flower
On 01/11/2018 14:30, David Rowley wrote: On 1 November 2018 at 13:35, Amit Langote wrote: On 2018/11/01 8:58, David Rowley wrote: [...] I agree. I don't think "TupRouting" really needs to be in the name. Probably "To" can also just become "2" and we can put back the Parent/Child before

Re: Large writable variables

2018-10-16 Thread Gavin Flower
On 17/10/2018 09:36, Tom Lane wrote: Andres Freund writes: Attached is a patch that shrinks fmgr_builtins by 25%. That seems worthwhile, it's pretty frequently accessed, making it more dense is helpful. Unless somebody protests soon, I'm going to apply that... Hah. I'm pretty sure that

Re: [HACKERS] Horrible CREATE DATABASE Performance in High Sierra

2018-09-18 Thread Gavin Flower
On 19/09/2018 16:38, Tom Lane wrote: I wrote: Peter Eisentraut writes: What is the status of this? Is performance on High Sierra still bad? I committed the fix at 643c27e36. If Apple have done anything about the underlying problem, you couldn't tell it from their non-response to my bug

Re: POC: GROUP BY optimization

2018-06-29 Thread Gavin Flower
On 30/06/18 03:03, Tomas Vondra wrote: On 06/29/2018 04:51 PM, Teodor Sigaev wrote: I tried to attack the cost_sort() issues and hope on that basis we can solve problems with 0002 patch and improve incremental sort patch. OK, will do. Thanks for working on this! I hope, now we have a

Re: Partitioning with temp tables is broken

2018-06-19 Thread Gavin Flower
On 20/06/18 16:47, Michael Paquier wrote: On Wed, Jun 20, 2018 at 01:32:58PM +0900, Amit Langote wrote: Just a minor nit in the last sentence: "have to be from" -> "must be from / must belong to" I think that both have the same meaning, but I am no native speaker so I may be missing a nuance

Re: Code of Conduct plan

2018-06-03 Thread Gavin Flower
On 04/06/18 07:32, Adrian Klaver wrote: On 06/03/2018 11:29 AM, Tom Lane wrote: Two years ago, there was considerable discussion about creating a Code of Conduct for the Postgres community, as a result of which the core team announced a plan to create an exploration committee to draft a CoC

Re: PG 11 feature count

2018-05-17 Thread Gavin Flower
On 18/05/18 11:29, Bruce Momjian wrote: I regularly track the number of items documented in each major release. I use the attached script. You might be surprised to learn that PG 11 has the lowest feature count of any release back through 7.4: 7.4 280 8.0 238

Re: bulk typos

2018-04-01 Thread Gavin Flower
On 02/04/18 07:03, Tom Lane wrote: =?UTF-8?Q?F=C3=A9lix_GERZAGUET?= writes: On Sat, Mar 31, 2018 at 12:56 PM, Justin Pryzby wrote: I needed another distraction so bulk-checked for typos, limited to comments in *.[ch]. I think you introduced

Re: csv format for psql

2018-03-31 Thread Gavin Flower
On 31/03/18 21:33, Fabien COELHO wrote: Bonjour Daniel, For csv, Fabien and Peter expressed the opinion that we shouldn't create another fieldsep-like variable specifically for it, but instead reuse fieldsep. That's what my latest patch does. Now it turns out that sharing fieldsep comes with

Re: spelling of enable_partition_wise_join

2018-02-13 Thread Gavin Flower
On 14/02/18 09:27, Peter Eisentraut wrote: I wonder how others feel about this, but the spelling of enable_partition_wise_join feels funny to me every time I look at it. I would write it enable_partitionwise_join. Thoughts? As 'wise' is a suffix, not a word in this situation - so it be

Re: LIKE foo% optimization easily defeated by OR?

2018-01-03 Thread Gavin Flower
On 04/01/18 12:06, Greg Stark wrote: I think I found the bug 18" from the monitor I'll just be over here with the paper bag over my head mumbling about running RESET ALL before running tests... I think Linus has patented the use of a paper bag in your situation... So you might have to pay

Re: What does Time.MAX_VALUE actually represent?

2018-01-01 Thread Gavin Flower
On 01/02/2018 01:26 AM, Tels wrote: Moin, On Sat, December 30, 2017 4:25 pm, Gavin Flower wrote: On 12/31/2017 03:07 AM, Dave Cramer wrote: We are having a discussion on the jdbc project about dealing with 24:00:00. https://github.com/pgjdbc/pgjdbc/pull/992#issuecomment-354507612 Dave

Re: What does Time.MAX_VALUE actually represent?

2017-12-31 Thread Gavin Flower
2017 at 2:25 PM, Gavin Flower <gavinflo...@archidevsys.co.nz <mailto:gavinflo...@archidevsys.co.nz>> wrote: On 12/31/2017 03:07 AM, Dave Cramer wrote: We are having a discussion on the jdbc project about dealing with 24:00:00. https://github.com/

Re: What does Time.MAX_VALUE actually represent?

2017-12-30 Thread Gavin Flower
On 12/31/2017 03:07 AM, Dave Cramer wrote: We are having a discussion on the jdbc project about dealing with 24:00:00. https://github.com/pgjdbc/pgjdbc/pull/992#issuecomment-354507612 Dave Cramer In Dublin (I was there 2001 to 2004), Time tables show buses just after midnight, such as