Re: Docs: Encourage strong server verification with SCRAM

On 5/25/23 1:29 PM, Stephen Frost wrote: Greetings, * Jacob Champion (jchamp...@timescale.com) wrote: On 5/24/23 05:04, Daniel Gustafsson wrote: On 23 May 2023, at 23:02, Stephen Frost wrote: Perhaps more succinctly- maybe we should be making adjustments to the current language instead of jus

Re: PostgreSQL 16 Beta 1 release announcement draft

On 5/25/23 12:16 AM, Andres Freund wrote: Hi, On 2023-05-24 23:30:58 -0400, Jonathan S. Katz wrote: Ah, OK, that's why I didn't grok it. I read through the first message in[1] and definitely agree it should be in the announcement. How about: "PostgreSQL 16 also shows up to a 3

Re: PostgreSQL 16 Beta 1 release announcement draft

On 5/24/23 11:30 PM, Jonathan S. Katz wrote: On 5/24/23 9:20 PM, Jonathan S. Katz wrote: I currently have it as the below in the release announcement. If it you send any suggested updates, I can try to put them in before release: PostgreSQL 16 can also improve the performance of concurrent

Re: PostgreSQL 16 Beta 1 release announcement draft

On 5/24/23 9:20 PM, Jonathan S. Katz wrote: On 5/24/23 8:04 PM, Andres Freund wrote: Hi, On 2023-05-24 19:57:39 -0400, Jonathan S. Katz wrote: On 5/24/23 5:28 PM, Andres Freund wrote: I think the relation extension improvements ought to be mentioned here as well? Up to 3x faster

Re: PostgreSQL 16 Beta 1 release announcement draft

On 5/24/23 8:04 PM, Andres Freund wrote: Hi, On 2023-05-24 19:57:39 -0400, Jonathan S. Katz wrote: On 5/24/23 5:28 PM, Andres Freund wrote: I think the relation extension improvements ought to be mentioned here as well? Up to 3x faster concurrent data load with COPY seems practically

Re: PostgreSQL 16 Beta 1 release announcement draft

On 5/24/23 5:28 PM, Andres Freund wrote: I think the relation extension improvements ought to be mentioned here as well? Up to 3x faster concurrent data load with COPY seems practically relevant. I missed that -- not sure I'm finding it in the release notes with a quick grep -- which commit/t

Re: PostgreSQL 16 Beta 1 release announcement draft

On 5/22/23 3:23 PM, Erik Rijkers wrote: Op 5/21/23 om 19:07 schreef Jonathan S. Katz: On 5/19/23 12:17 AM, Jonathan S. Katz wrote: Hi, Attached is a draft of the release announcement for PostgreSQL 16 Beta Please provide feedback no later than May 24, 0:00 AoE. This will give Thanks

Re: PG 16 draft release notes ready

On 5/24/23 12:13 AM, David Rowley wrote: On Wed, 24 May 2023 at 15:54, Bruce Momjian wrote: On Wed, May 24, 2023 at 08:37:45AM +1200, David Rowley wrote: On Mon, 22 May 2023 at 07:05, Jonathan S. Katz wrote: * Parallel execution of queries that use `FULL` and `OUTER` joins I think this

Re: PG 16 draft release notes ready

On 5/22/23 4:18 PM, Robert Haas wrote: On Sun, May 21, 2023 at 3:05 PM Jonathan S. Katz wrote: * Support for regular expressions for matching usernames and databases names in `pg_hba.conf`, and user names in `pg_ident.conf` I suggest that this is not a major feature. Perhaps the work that I

Re: PG 16 draft release notes ready

On 5/23/23 4:37 PM, David Rowley wrote: On Mon, 22 May 2023 at 07:05, Jonathan S. Katz wrote: * Parallel execution of queries that use `FULL` and `OUTER` joins I think this should be `RIGHT` joins rather than `OUTER` joins. LEFT joins have been parallelizable I think for a long time now

Re: PG 16 draft release notes ready

On 5/21/23 3:04 PM, Jonathan S. Katz wrote: On 5/18/23 4:49 PM, Bruce Momjian wrote: I have completed the first draft of the PG 16 release notes. One thing that we could attempt for this beta is to include a prospective list of "major features + enhancements." Of course it can cha

Re: PG 16 draft release notes ready

On 5/21/23 3:24 PM, Andres Freund wrote: Hi, On May 21, 2023 11:46:56 AM PDT, "Jonathan S. Katz" wrote: On 5/21/23 1:13 PM, Andres Freund wrote: Looking through the release notes, I didn't see an entry for commit c6e0fe1f2a08505544c410f613839664eea9eb21 Author: David Rowle

Re: PG 16 draft release notes ready

On 5/18/23 4:49 PM, Bruce Momjian wrote: I have completed the first draft of the PG 16 release notes. One thing that we could attempt for this beta is to include a prospective list of "major features + enhancements." Of course it can change before the GA, but it'll give readers some idea of t

Re: PG 16 draft release notes ready

On 5/21/23 1:13 PM, Andres Freund wrote: Looking through the release notes, I didn't see an entry for commit c6e0fe1f2a08505544c410f613839664eea9eb21 Author: David Rowley Date: 2022-08-29 17:15:00 +1200 Improve performance of and reduce overheads of memory management even though I

Re: PostgreSQL 16 Beta 1 release announcement draft

On 5/19/23 12:17 AM, Jonathan S. Katz wrote: Hi, Attached is a draft of the release announcement for PostgreSQL 16 Beta 1. The goal of this announcement is to get people excited about testing the beta and highlight many of the new features. Please review for inaccuracies, omissions, and

Re: PostgreSQL 16 Beta 1 release announcement draft

On 5/19/23 10:57 AM, Nathan Bossart wrote: On Fri, May 19, 2023 at 12:17:50AM -0400, Jonathan S. Katz wrote: PostgreSQL 16 continues to give users to the ability grant privileged access to features without requiring superuser with new [predefined roles](https://www.postgresql.org/docs/devel

Re: PostgreSQL 16 Beta 1 release announcement draft

On 5/19/23 1:42 AM, Erik Rijkers wrote: Op 5/19/23 om 06:17 schreef Jonathan S. Katz: Hi, Attached is a draft of the release announcement for PostgreSQL 16 Beta Hi, The usual small fry: 'continues to to'  should be 'continues to' 'continues to give users t

PostgreSQL 16 Beta 1 release announcement draft

Hi, Attached is a draft of the release announcement for PostgreSQL 16 Beta 1. The goal of this announcement is to get people excited about testing the beta and highlight many of the new features. Please review for inaccuracies, omissions, and other suggestions / errors. Please provide feedba

Re: PG 16 draft release notes ready

On 5/18/23 4:49 PM, Bruce Momjian wrote: I have completed the first draft of the PG 16 release notes. You can see the output here: https://momjian.us/pgsql_docs/release-16.html I will adjust it to the feedback I receive; that URL will quickly show all updates. Still reading, but saw

Re: PG 16 draft release notes ready

On 5/18/23 4:49 PM, Bruce Momjian wrote: I have completed the first draft of the PG 16 release notes. You can see the output here: https://momjian.us/pgsql_docs/release-16.html I will adjust it to the feedback I receive; that URL will quickly show all updates. Thanks for going throu

Re: Order changes in PG16 since ICU introduction

On 5/18/23 1:55 PM, Jeff Davis wrote: On Wed, 2023-05-17 at 19:59 -0400, Jonathan S. Katz wrote: I did a quicker read through this time. LGTM overall. I like what you did with the explanations around sensitivity (now it makes sense). Committed, thank you. \o/ There are a few things I

Re: psql: Add role's membership options to the \du+ command

On 5/7/23 3:14 PM, Pavel Luzanov wrote: On 05.05.2023 19:51, David G. Johnston wrote: But if it is really a blocker then maybe we should produce 3 separate newline separated columns, one for the member of role, one for the list of attributes, and one with the grantor.  The column headers can b

Re: Order changes in PG16 since ICU introduction

On 5/17/23 6:59 PM, Jeff Davis wrote: On Tue, 2023-05-16 at 20:23 -0700, Jeff Davis wrote: Other than that, and I took your suggestions almost verbatim. Patch attached. Thank you! Attached new patch with a typo fix and a few other edits. I plan to commit soon. I did a quicker read through th

Re: Possible regression setting GUCs on \connect

On 5/17/23 1:30 PM, Alexander Korotkov wrote: Tom, On Wed, May 17, 2023 at 3:08 PM Tom Lane wrote: Amit Kapila writes: Tom/Nathan, do you have any further suggestions here? My recommendation is to revert this feature. I do not see any way that we won't regret it as a poor design. I have

Re: pg_stat_io not tracking smgrwriteback() is confusing

On 5/17/23 3:19 PM, Andres Freund wrote: Hi, On 2023-05-16 10:30:27 -0400, Jonathan S. Katz wrote: On 5/6/23 1:30 PM, Melanie Plageman wrote: I've done that in the attached v5. [RMT hat] RMT nudge on this thread, as we're approaching the Beta 1 cutoff. From the above discussion,

Re: Possible regression setting GUCs on \connect

On 5/17/23 12:47 PM, Nathan Bossart wrote: On Wed, May 17, 2023 at 08:08:36AM -0400, Tom Lane wrote: Amit Kapila writes: Tom/Nathan, do you have any further suggestions here? My recommendation is to revert this feature. I do not see any way that we won't regret it as a poor design. I agre

Re: WL_SOCKET_ACCEPT fairness on Windows

On 5/16/23 4:41 PM, Thomas Munro wrote: On Wed, May 17, 2023 at 2:57 AM Jonathan S. Katz wrote: Given this has sat for a bit, I wanted to see if any of your thinking has changed on whether this should be fixed for v16 or v17. I have personally not formed an opinion yet, but per the current

Re: Order changes in PG16 since ICU introduction

On 5/5/23 8:25 PM, Jeff Davis wrote: On Fri, 2023-04-21 at 20:12 -0400, Robert Haas wrote: On Fri, Apr 21, 2023 at 5:56 PM Jeff Davis wrote: Most of the complaints seem to be complaints about v15 as well, and while those complaints may be a reason to not make ICU the default, they are also an

Re: WL_SOCKET_ACCEPT fairness on Windows

On 3/31/23 11:00 PM, Thomas Munro wrote: I mention this now because I'm not sure whether to consider this an 'open item' for 16, or merely an enhancement for 17. I guess the former, because someone might call that a new denial of service vector. On the other hand, if you fill up the listen que

Re: pg_stat_io not tracking smgrwriteback() is confusing

On 5/6/23 1:30 PM, Melanie Plageman wrote: I've done that in the attached v5. [RMT hat] RMT nudge on this thread, as we're approaching the Beta 1 cutoff. From the above discussion, it sounds like it's pretty close to being ready. Thanks, Jonathan OpenPGP_signature Description: OpenPGP d

Re: Assert failure of the cross-check for nullingrels

On 5/16/23 9:49 AM, Tom Lane wrote: "Jonathan S. Katz" writes: Is there a specific commit targeted for v16 that introduced this issue? Does it only affect v16 or does it affect backbranches? It's part of the outer-join-aware-Vars stuff, so it's my fault ... and v16 only

Re: Assert failure of the cross-check for nullingrels

On 5/12/23 3:02 AM, Richard Guo wrote: On Fri, Mar 17, 2023 at 11:05 AM Richard Guo > wrote: Here is an updated patch with comments and test case.  I also change the code to store 'group_clause_relids' directly in RestrictInfo. BTW, I've added an open i

Re: 2023-05-11 release announcement draft

On 5/7/23 10:34 PM, David Rowley wrote: * Fix partition pruning bug with the boolean "IS NOT TRUE" and "IS NOT FALSE" conditions. NULL partitions were accidentally pruned when they shouldn't have been. Thanks for the additional explanation. I took your suggestion verbatim. Thanks, Jonathan

PostgreSQL 16 Beta 1 release date

Hi, The release date for PostgreSQL 16 Beta 1 is scheduled for May 25, 2023. Please ensure you have committed any work for Beta 1 released committed by May 21, 2023 AoE. Thank you for your efforts with resolving open items[2] as we work to stabilize PostgreSQL 16 for GA! Thanks, Jonathan [

Re: 2023-05-11 release announcement draft

On 5/7/23 1:09 AM, Erik Rijkers wrote: Op 5/7/23 om 05:37 schreef Jonathan S. Katz: Attached is a draft of the release announcement for the upcoming update release on May 11, 2023. Please provide any suggestions, corrections, or notable omissions no later than 2023-05-11 0:00 AoE. 'le

2023-05-11 release announcement draft

Hi, Attached is a draft of the release announcement for the upcoming update release on May 11, 2023. Please provide any suggestions, corrections, or notable omissions no later than 2023-05-11 0:00 AoE. Thanks, Jonathan The PostgreSQL Global Development Group has released an update to all s

Re: pg_stat_io not tracking smgrwriteback() is confusing

On 5/4/23 12:46 PM, Andres Freund wrote: Hi, On 2023-05-03 11:36:10 -0400, Jonathan S. Katz wrote: It'd be good if we can get this into Beta 1 if everyone is comfortable with the patch. I think we need one more iteration, then I think it can be committed. The changes are docs phrasin

Re: psql: Add role's membership options to the \du+ command

On 5/3/23 12:25 PM, Tom Lane wrote: "David G. Johnston" writes: On Wed, May 3, 2023 at 9:00 AM Jonathan S. Katz wrote: I don't see why this is an open item as this feature was not committed for v16. Open items typically revolve around committed features. The argument is th

Re: psql: Add role's membership options to the \du+ command

On 4/13/23 8:44 AM, Pavel Luzanov wrote: P.S. If no objections I plan to add this patch to Open Items for v16 https://wiki.postgresql.org/wiki/PostgreSQL_16_Open_Items [RMT hat] I don't see why this is an open item as this feature was not committed for v16. Open items typically revolve aroun

Re: pg_stat_io not tracking smgrwriteback() is confusing

On 4/27/23 11:36 AM, Melanie Plageman wrote: Thanks for the review! On Wed, Apr 26, 2023 at 10:22 PM Kyotaro Horiguchi wrote: At Wed, 26 Apr 2023 17:08:14 -0400, Melanie Plageman wrote in On Mon, Apr 24, 2023 at 9:29 PM Melanie Plageman wrote: I've yet to cook up a client backend test ca

Re: Move defaults toward ICU in 16?

On 4/17/23 2:33 PM, Tom Lane wrote: Jeff Davis writes: Is now a reasonable time to check it in and see what breaks? It looks like there are quite a few buildfarm members that specify neither -- with-icu nor --without-icu. I see you just pinged buildfarm-members again, so I'd think it's polite

Re: Possible regression setting GUCs on \connect

On 4/28/23 12:29 PM, Pavel Borisov wrote: Hi! On Fri, 28 Apr 2023 at 17:42, Jonathan S. Katz wrote: On 4/27/23 8:04 PM, Alexander Korotkov wrote: On Fri, Apr 28, 2023 at 2:30 AM Alexander Korotkov wrote: Additionally, I think if we start recording role OID, then we need a full set of

Re: Possible regression setting GUCs on \connect

On 4/27/23 8:04 PM, Alexander Korotkov wrote: On Fri, Apr 28, 2023 at 2:30 AM Alexander Korotkov wrote: Additionally, I think if we start recording role OID, then we need a full set of management clauses for each individual option ownership. Otherwise, we would leave this new role OID without n

Re: pg_stat_io not tracking smgrwriteback() is confusing

On 4/24/23 6:14 PM, Andres Freund wrote: Hi, On 2023-04-24 10:52:15 +0530, Amit Kapila wrote: On Sun, Apr 23, 2023 at 12:55 AM Jonathan S. Katz wrote: I wonder if it's worth doing so for 16? It'd give a more complete picture that way. The counter-argument I see is that we didn&#

Re: New committers: Nathan Bossart, Amit Langote, Masahiko Sawada

On 4/20/23 1:40 PM, Tom Lane wrote: The Core Team would like to extend our congratulations to Nathan Bossart, Amit Langote, and Masahiko Sawada, who have accepted invitations to become our newest Postgres committers. Please join me in wishing them much success and few reverts. Congratulations

Re: pg_stat_io not tracking smgrwriteback() is confusing

On 4/19/23 1:23 PM, Andres Freund wrote: Hi, I noticed that the numbers in pg_stat_io dont't quite add up to what I expected in write heavy workloads. Particularly for checkpointer, the numbers for "write" in log_checkpoints output are larger than what is visible in pg_stat_io. That partially i

Re: check_strxfrm_bug()

On 4/19/23 9:34 PM, Thomas Munro wrote: On Wed, Apr 19, 2023 at 2:31 PM Jonathan S. Katz wrote: To be clear, is the proposal to remove both "check_strxfrm_bug" and "TRUST_STRXFRM"? Given a bunch of folks who have expertise in this area of code all agree with removing the

Re: check_strxfrm_bug()

On 4/18/23 9:19 PM, Thomas Munro wrote: On Tue, Apr 18, 2023 at 11:52 AM Michael Paquier wrote: On Mon, Apr 17, 2023 at 03:40:14PM -0700, Peter Geoghegan wrote: +1 for getting rid of TRUST_STRXFRM. +1 The situation is not improving fast, and requires hard work to follow on each OS. Clearly

Re: Should we remove vacuum_defer_cleanup_age?

On 4/14/23 1:15 PM, Laurenz Albe wrote: Let's remove vacuum_defer_cleanup_age, and put a note in the release notes that recommends using statement_timeout and hot_standby_feedback = on on the standby instead. That should have pretty much the same effect, and it is measured in time and not in the

Re: Should we remove vacuum_defer_cleanup_age?

On 4/14/23 8:30 AM, Robert Haas wrote: On Thu, Apr 13, 2023 at 11:06 PM Laurenz Albe wrote: I am not against this in principle, but I know that there are people using this parameter; see the discussion linked in https://postgr.es/m/e1jkzxe-0006dw...@gemulon.postgresql.org I can't say if they

Re: Should we remove vacuum_defer_cleanup_age?

On 4/13/23 11:32 AM, Jonathan S. Katz wrote: On 4/12/23 11:34 PM, Amit Kapila wrote: On Tue, Apr 11, 2023 at 11:50 PM Andres Freund +1 to do one of the above. I think there is a good chance that somebody might be doing more harm by using it so removing this shouldn't be a pr

Re: Should we remove vacuum_defer_cleanup_age?

On 4/12/23 11:34 PM, Amit Kapila wrote: On Tue, Apr 11, 2023 at 11:50 PM Andres Freund wrote: On 2023-04-11 11:33:01 -0500, Justin Pryzby wrote: On Wed, Mar 22, 2023 at 10:00:48AM -0700, Andres Freund wrote: I don't know whether others think we should apply it this release, given the "late s

Re: longfin missing gssapi_ext.h

On 4/12/23 12:22 PM, Stephen Frost wrote: Greetings, * Tom Lane (t...@sss.pgh.pa.us) wrote: Stephen Frost writes: Updated patch set attached. LGTM Great, thanks. I cleaned up the commit messages a bit more and added links to the discussion. If there isn't anything more then I'll plan to

Re: longfin missing gssapi_ext.h

On 4/12/23 10:47 AM, Stephen Frost wrote: Greetings, * Jonathan S. Katz (jk...@postgresql.org) wrote: On 4/12/23 10:33 AM, Stephen Frost wrote: * Tom Lane (t...@sss.pgh.pa.us) wrote: Stephen Frost writes: Understood. Please find attached the updated patch with changes to the commit

Re: longfin missing gssapi_ext.h

On 4/12/23 10:33 AM, Stephen Frost wrote: Greetings, * Tom Lane (t...@sss.pgh.pa.us) wrote: Stephen Frost writes: Understood. Please find attached the updated patch with changes to the commit message to indicate that we now require MIT Kerberos, an additional explicit check for gssapi_ext.h

Re: When to drop src/tools/msvc support

On 4/11/23 10:12 AM, Tom Lane wrote: "Jonathan S. Katz" writes: On 4/11/23 9:49 AM, Tom Lane wrote: Sadly, I think we really have to ship both build systems in v16. But maybe we can make it clear in the release notes + docs that this is slated for deprecation and will be remove

Re: When to drop src/tools/msvc support

On 4/11/23 9:49 AM, Tom Lane wrote: Dave Page writes: On Tue, 11 Apr 2023 at 13:52, Jonathan S. Katz wrote: Do you think we'll have enough info by end of this week to make a decision on whether we can drop MSVC in v16? There's no way I can test anything this week - I'm on

Re: When to drop src/tools/msvc support

On 4/11/23 7:54 AM, Dave Page wrote: On Tue, 11 Apr 2023 at 11:58, Andrew Dunstan > wrote: For meson you just need to to "pip install meson ninja" in your python distro and you should be good to go (they will be installed in python's Scripts directory).

Re: longfin missing gssapi_ext.h

On 4/10/23 11:37 AM, Tom Lane wrote: Stephen Frost writes: * Tom Lane (t...@sss.pgh.pa.us) wrote: IOW, maybe it'd be okay to de-revert 3d4fa227b and add documentation saying that --with-gssapi requires MIT Kerberos not Heimdal. I'd be happy with that and can add the appropriate documentatio

Re: When to drop src/tools/msvc support

On 4/10/23 4:50 PM, Tom Lane wrote: Magnus Hagander writes: Thus, +1 on actually keeping it up and dropping it immediately as v17 opens, giving them a year of advantage. And probably updating the docs (if anybody were to read them.. but at least then we tried) stating that it's deprecated and w

Re: When to drop src/tools/msvc support

On 4/8/23 3:10 PM, Andres Freund wrote: Hi, I'd planned to write this soon anyway, but it was just brought up in [1]. Originally we had planned to drop src/tools/msvc support shortly after meson went in. Unfortunately, it took a bit longer than originally hoped for to merge meson support and th

Re: Minimal logical decoding on standbys

On 4/8/23 5:27 AM, Andres Freund wrote: Hi, On 2023-04-07 14:27:09 -0700, Andres Freund wrote: I think I'll push these in a few hours. While this needed more changes than I'd like shortly before the freeze, I think they're largely not in very interesting bits and pieces - and this feature has b

Re: PostgreSQL 16 Release Management Team & Feature Freeze

On 4/6/23 5:37 PM, Jonathan S. Katz wrote: On 3/21/23 11:35 AM, Jonathan S. Katz wrote: Additionally, the RMT has set the feature freeze to be **April 8, 2023 at 0:00 AoE**[1]. This is the last time to commit features for PostgreSQL 16. In  other words, no new PostgreSQL 16 feature can be

Re: Minimal logical decoding on standbys

On 4/8/23 12:01 AM, Andres Freund wrote: Hi, On 2023-04-08 09:15:05 +0530, Amit Kapila wrote: The new approach for invalidation looks clean. BTW, I see minor inconsistency in the following two error messages (errmsg): Thanks for checking. if (MyReplicationSlot->data.invalidated == RS_INVAL

Re: PostgreSQL 16 Release Management Team & Feature Freeze

On 3/21/23 11:35 AM, Jonathan S. Katz wrote: Additionally, the RMT has set the feature freeze to be **April 8, 2023 at 0:00 AoE**[1]. This is the last time to commit features for PostgreSQL 16. In  other words, no new PostgreSQL 16 feature can be committed after April 8, 2023 at 0:00 AoE

Re: SQL/JSON revisited

On 4/4/23 3:40 PM, Nikita Malakhov wrote: Hi hackers! The latest SQL standard contains dot notation for JSON. Are there any plans to include it into Pg 16? Or maybe we should start a separate thread for it? I would recommend starting a new thread to discuss the dot notation. Thanks, Jonath

Re: Check whether binaries can be released for s390x

Hi Namrata, On 4/4/23 8:56 AM, Namrata Bhave wrote: Hi, We are looking forward to get help from community on publishing s390x binaries. As per downloads page, apt repo supports Ubuntu on amd,arm,i386 and ppc64le. We had reached out earlier and are ready to provide infra if needed. Wanted t

Re: Support logical replication of DDLs

On 3/27/23 2:37 AM, Amit Kapila wrote: On Mon, Mar 27, 2023 at 2:52 AM Tom Lane wrote: And TBH, I don't think that I quite believe the premise in the first place. The whole point of using logical rather than physical replication is that the subscriber installation(s) aren't exactly like the

Re: User functions for building SCRAM secrets

On 3/22/23 2:48 AM, Michael Paquier wrote: On Tue, Feb 14, 2023 at 06:16:18PM -0500, Jonathan S. Katz wrote: I opted for the approach in [2]. v5 contains the branching logic for the UTF8 only tests, and the corresponding output files. I tested locally on macOS against both UTF8 + C locales

Re: PostgreSQL 16 Release Management Team & Feature Freeze

On 3/21/23 1:17 PM, Roberto Mello wrote: On Tue, Mar 21, 2023 at 9:35 AM Jonathan S. Katz wrote: You can track open items for the PostgreSQL 16 release here: https://wiki.postgresql.org/wiki/PostgreSQL_16_Open_Items The wiki page references April 8th, 2022, btw. Fixed :) Thanks

PostgreSQL 16 Release Management Team & Feature Freeze

Hi, We are pleased to announce the Release Management Team (RMT) (cc'd) for the PostgreSQL 16 release: - Alvaro Herrera - Amit Kapila - Jonathan Katz You can find information about the responsibilities of the RMT here: https://wiki.postgresql.org/wiki/Release_Management_Team Addit

Re: Remove last traces of SCM credential auth from libpq?

On 3/16/23 10:49 AM, Tom Lane wrote: Michael Paquier writes: libpq has kept some code related to the support of authentication with SCM credentials for some time now, code dead in the backend since 9.1. Wouldn't it be time to let it go and remove this code entirely, erroring in libpq if attemp

Re: logical decoding and replication of sequences, take 2

On 2/23/23 7:56 AM, Tomas Vondra wrote: On 2/22/23 18:04, Jonathan S. Katz wrote: On 2/22/23 5:02 AM, Tomas Vondra wrote: Interestingly, in systems that tend to have higher rates of failover (I'm thinking of a few distributed systems), this may cause int4 sequences to exhaust nu

Re: Raising the SCRAM iteration count

On 2/22/23 8:39 AM, Daniel Gustafsson wrote: On 17 Dec 2022, at 04:27, Michael Paquier wrote: Superuser-only GUCs should be documented as such, or do you intend to make it user-settable like I suggested upthread :) ? I don't really have strong feelings, so I reverted to being user-settable

Re: logical decoding and replication of sequences, take 2

On 2/22/23 5:02 AM, Tomas Vondra wrote: On 2/22/23 03:28, Jonathan S. Katz wrote: Thanks for continuing to work on this patch! I tested the latest version and have some feedback/clarifications. Thanks! Also I should mention I've been testing with both async/sync logical replicati

Re: logical decoding and replication of sequences, take 2

Hi, On 2/16/23 10:50 AM, Tomas Vondra wrote: Hi, Here's a rebased patch, without the last bit which is now unnecessary thanks to c981d9145dea. Thanks for continuing to work on this patch! I tested the latest version and have some feedback/clarifications. I did some testing using a demo-app

Re: Support logical replication of DDLs

On 2/19/23 11:14 PM, Amit Kapila wrote: On Sun, Feb 19, 2023 at 7:50 AM Jonathan S. Katz wrote: On 2/17/23 4:15 AM, Amit Kapila wrote: This happens because of the function used in the index expression. Now, this is not the only thing, the replication can even fail during DDL replication

Re: Support logical replication of DDLs

On 2/17/23 4:15 AM, Amit Kapila wrote: On Fri, Feb 17, 2023 at 1:13 AM Jonathan S. Katz wrote: On 2/16/23 2:38 PM, Alvaro Herrera wrote: On 2023-Feb-16, Jonathan S. Katz wrote: On 2/16/23 12:53 PM, Alvaro Herrera wrote: I don't think this is the fault of logical replication. Con

Re: The output sql generated by pg_dump for a create function refers to a modified table name

On 2/17/23 1:18 PM, Tom Lane wrote: It can be reproduced with INSERT too, on the same principle as the others: put the DML command inside a WITH, and give it an alias conflicting with the outer query. Ah, I see based on your example below. I did not alias the INSERT statement in the way (and

Re: The output sql generated by pg_dump for a create function refers to a modified table name

On 2/17/23 11:19 AM, Jonathan S. Katz wrote: On 2/17/23 10:09 AM, Tom Lane wrote: Agreed on that -- while it's harder to set up, I do prefer the original example[1] to demonstrate this, as it shows the issue given it does not have those multiple occurrences, at least not within the

Re: The output sql generated by pg_dump for a create function refers to a modified table name

On 2/17/23 10:09 AM, Tom Lane wrote: "Jonathan S. Katz" writes: Good catch. Do you have thoughts on how we can adjust the naming logic to handle cases like this? I think it's perfectly fine that ruleutils decided to use different aliases for the two different occurrenc

Re: The output sql generated by pg_dump for a create function refers to a modified table name

On 2/17/23 5:22 AM, vignesh C wrote: Hi, The output sql generated by pg_dump for the below function refers to a modified table name: create table t1 (c1 int); create table t2 (c1 int); CREATE OR REPLACE FUNCTION test_fun(c1 int) RETURNS void LANGUAGE SQL BEGIN ATOMIC WITH delete_t1 AS (

Re: Support logical replication of DDLs

On 2/16/23 2:43 PM, Jonathan S. Katz wrote: On 2/16/23 2:38 PM, Alvaro Herrera wrote: On 2023-Feb-16, Jonathan S. Katz wrote: On 2/16/23 12:53 PM, Alvaro Herrera wrote: I don't think this is the fault of logical replication.  Consider that for the backend server, the function source

Re: Support logical replication of DDLs

On 2/16/23 2:38 PM, Alvaro Herrera wrote: On 2023-Feb-16, Jonathan S. Katz wrote: On 2/16/23 12:53 PM, Alvaro Herrera wrote: I don't think this is the fault of logical replication. Consider that for the backend server, the function source code is just an opaque string that is given t

Re: Support logical replication of DDLs

On 2/16/23 12:53 PM, Alvaro Herrera wrote: On 2023-Feb-16, Jonathan S. Katz wrote: [replication tries to execute this command] 2023-02-16 16:11:10.570 UTC [25207] STATEMENT: CREATE OR REPLACE FUNCTION public.availability_rule_bulk_insert ( IN availability_rule public.availability_rule, IN

Re: Support logical replication of DDLs

Hi, On 2/14/23 10:01 PM, houzj.f...@fujitsu.com wrote: Here is the new version patch which addressed above comments. I also fixed a bug for the deparsing of CREATE RULE that it didn't add parentheses for rule action list. I started testing this change set from this patch. I'm doing a mix of

Re: Move defaults toward ICU in 16?

On 2/16/23 4:35 AM, Robert Haas wrote: On Thu, Feb 16, 2023 at 1:01 AM Jeff Davis wrote: It feels very wrong to me to explain that sort order is defined by the operating system on which Postgres happens to run. Saying that it's defined by ICU, which is part of the Unicode consotium, is much bet

Re: User functions for building SCRAM secrets

On 2/14/23 3:19 PM, Jonathan S. Katz wrote: On 2/14/23 3:17 PM, Andres Freund wrote: This reliably fails on CI: https://cirrus-ci.com/github/postgresql-cfbot/postgresql/commitfest%2F42%2F3988 I think this is related to encoding issues. The 32bit debian task intentionally uses LANG=C

Re: Move defaults toward ICU in 16?

On 2/13/23 8:11 PM, Jeff Davis wrote: On Thu, 2023-02-02 at 05:13 -0800, Jeff Davis wrote: As a project, do we want to nudge users toward ICU as the collation provider as the best practice going forward? One consideration here is security. Any vulnerability in ICU collation routines could easi

Re: User functions for building SCRAM secrets

On 2/14/23 3:17 PM, Andres Freund wrote: Hi, On 2023-01-23 00:58:40 -0500, Jonathan S. Katz wrote: Here is another attempt at this patch that takes into account the SCRAM code refactor. I addressed some of Daniel's previous feedback, but will need to make another pass on the docs an

2023-02-09 release announcement draft

Hi, Attached is a draft of the announcement for the 2023-02-09 update release. Please review and provide corrections, notable omissions, and suggestions no later than 2023-02-09 0:00 AoE. Thanks! Jonathan The PostgreSQL Global Development Group has released an update to all supported version

Re: First draft of back-branch release notes is done

On 2/5/23 9:39 PM, Tom Lane wrote: Prevent clobbering of cached parsetrees for utility statements in SQL functions (Tom Lane, Daniel Gustafsson) If a SQL-language function executes the same utility command more than once within a single calling

Re: First draft of back-branch release notes is done

On 2/5/23 3:01 PM, Tom Lane wrote: "Jonathan S. Katz" writes: On Feb 4, 2023, at 10:24 AM, Tom Lane wrote: “Prevent clobbering of cached parsetrees…Bad things could happen if…” While I chuckled over the phrasing, I’m left to wonder what the “bad things” are, in case I need t

Re: First draft of back-branch release notes is done

> On Feb 4, 2023, at 10:24 AM, Tom Lane wrote: > > ... at > > https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=f282b026787da69d88a35404cf62f1cc21cfbb7c > > As usual, please send corrections/comments by Sunday. While reviewing for the release announcement, I noticed this (a

Re: User functions for building SCRAM secrets

w our best practices and sends a pre-built SCRAM secret over the wire, a hook can then verify that the secret is not contained within a common password dictionary. Thanks, Jonathan [1] https://github.com/aws/pg_tle/blob/main/docs/04_hooks.md From 756c93f83869b7f8cbb87a7e4ccd967cbd8e8553 Mon

Re: Handle infinite recursion in logical replication setup

On 1/10/23 10:17 AM, Amit Kapila wrote: On Tue, Jan 10, 2023 at 8:13 AM Jonathan S. Katz wrote: This consistently created the deadlock in my testing. Discussing with Masahiko off-list, this is due to a deadlock from 4 processes: the walsenders on A and B, and the apply workers on A and B

Re: Handle infinite recursion in logical replication setup

On 9/12/22 1:23 AM, vignesh C wrote: On Fri, 9 Sept 2022 at 11:12, Amit Kapila wrote: On Thu, Sep 8, 2022 at 9:32 AM vignesh C wrote: The attached patch has the changes to handle the same. Pushed. I am not completely sure whether we want the remaining documentation patch in this thread

Re: Refactor SCRAM code to dynamically handle hash type and key length

On 12/20/22 2:25 AM, Michael Paquier wrote: On Tue, Dec 20, 2022 at 08:58:38AM +0900, Michael Paquier wrote: Thanks! I have applied for I have here.. There are other pieces to think about in this area. FYI, I have spent a few hours looking at the remaining parts of the SCRAM code that could

Re: Refactor SCRAM code to dynamically handle hash type and key length

On 12/16/22 10:08 PM, Michael Paquier wrote: On Thu, Dec 15, 2022 at 04:59:52AM +0900, Michael Paquier wrote: However, that's only half of the picture. The key length and the hash type (or just the hash type to know what's the digest/key length to use but that's more invasive) still need to be

Re: Raising the SCRAM iteration count

On 12/14/22 6:52 PM, Michael Paquier wrote: On Wed, Dec 14, 2022 at 01:59:04PM -0500, Jonathan S. Katz wrote: HA-256 that we will just need to pick up? The attached v2 has the GUC rename and a change to GUC_REPORT such that the frontend can use the real value rather than the default. I kept

<    1   2   3   4   5   6   7   >