Re: Raising the SCRAM iteration count

2022-12-14 Thread Jonathan S. Katz
On 12/14/22 6:25 AM, Daniel Gustafsson wrote: On 14 Dec 2022, at 02:00, Michael Paquier wrote: On Tue, Dec 13, 2022 at 12:17:58PM +0100, Daniel Gustafsson wrote: It does raise an interesting point though, if we in the future add suppprt for SCRAM-SHA-512 (which seems reasonable to do) it's not

Re: Raising the SCRAM iteration count

2022-12-12 Thread Jonathan S. Katz
On 12/9/22 7:15 PM, Andres Freund wrote: Hi, On 2022-12-09 11:55:07 +0100, Daniel Gustafsson wrote: Our current hardcoded value for iteration count is 4096, which is based on a recommendation from RFC 7677. This is however the lower end of the scale, and is related to computing power in 2015 g

Re: User functions for building SCRAM secrets

2022-11-26 Thread Jonathan S. Katz
On 11/26/22 2:53 PM, Jonathan S. Katz wrote: On 11/16/22 10:09 PM, Michael Paquier wrote: git diff --check reports some whitespaces. Ack. Will fix on the next pass. (I've been transitioning editors, which could have resulted in that), Fixed (and have run that check subsequ

Re: User functions for building SCRAM secrets

2022-11-26 Thread Jonathan S. Katz
On 11/16/22 10:09 PM, Michael Paquier wrote: On Thu, Nov 10, 2022 at 11:14:34PM -0500, Jonathan S. Katz wrote: On 10/31/22 8:56 PM, Michael Paquier wrote: Well, one could pass a salt based on something generated by random() to emulate what we currently do in the default case, as well. The

Re: heavily contended lwlocks with long wait queues scale badly

2022-11-21 Thread Jonathan S. Katz
On 11/20/22 2:56 PM, Andres Freund wrote: Hi, On 2022-11-09 17:03:13 -0800, Andres Freund wrote: On 2022-11-09 09:38:08 -0800, Andres Freund wrote: I'm on a hike, without any connectivity, Thu afternoon - Sun. I think it's OK to push it to HEAD if I get it done in the next few hours. Bigger is

Re: User functions for building SCRAM secrets

2022-11-10 Thread Jonathan S. Katz
On 10/31/22 8:56 PM, Michael Paquier wrote: On Mon, Oct 31, 2022 at 04:27:08PM -0400, Jonathan S. Katz wrote: 1. password only -- this defers to the PG defaults for SCRAM 2. password + salt -- this is useful for the password history / dictionary case to allow for a predictable way to check a

Re: 2022-11-10 release announcement draft

2022-11-07 Thread Jonathan S. Katz
On 11/7/22 10:59 AM, Erikjan Rijkers wrote: Op 07-11-2022 om 16:51 schreef Jonathan S. Katz: Hi, Attached is a draft of the release announcement for the 2022-11-10 release. Please provide feedback no later than 2022-11-10 0:00 AoE[1]. 'now exists'  should be (I think)

2022-11-10 release announcement draft

2022-11-07 Thread Jonathan S. Katz
Hi, Attached is a draft of the release announcement for the 2022-11-10 release. Please provide feedback no later than 2022-11-10 0:00 AoE[1]. Thanks, Jonathan [1] https://en.wikipedia.org/wiki/Anywhere_on_Earth The PostgreSQL Global Development Group has released an update to all supported ve

Re: Draft back-branch release notes are up

2022-11-07 Thread Jonathan S. Katz
On 11/7/22 10:30 AM, Jonathan S. Katz wrote: On 11/6/22 11:14 AM, Tom Lane wrote: Justin Pryzby writes: +  Fix planner failure with extended statistics on partitioned tables +  (Richard Guo, Justin Pryzby) This can also happen with inheritance tables. +  Add missing guards

Re: Draft back-branch release notes are up

2022-11-07 Thread Jonathan S. Katz
On 11/6/22 11:14 AM, Tom Lane wrote: Justin Pryzby writes: + Fix planner failure with extended statistics on partitioned tables + (Richard Guo, Justin Pryzby) This can also happen with inheritance tables. + Add missing guards for NULL connection pointer Maybe should be N

Re: heavily contended lwlocks with long wait queues scale badly

2022-11-03 Thread Jonathan S. Katz
On 11/1/22 1:41 PM, Andres Freund wrote: Andres: when you suggested backpatching, were you thinking of the Nov 2022 release or the Feb 2023 release? I wasn't thinking that concretely. Even if we decide to backpatch, I'd be very hesitant to do it in a few days. Yeah this was my thinking (and

Re: heavily contended lwlocks with long wait queues scale badly

2022-11-01 Thread Jonathan S. Katz
On 11/1/22 8:37 AM, Robert Haas wrote: On Tue, Nov 1, 2022 at 3:17 AM Bharath Rupireddy wrote: Below are test results with v3 patch. +1 for back-patching it. First, awesome find and proposed solution! The problem with back-patching stuff like this is that it can have unanticipated consequen

Re: User functions for building SCRAM secrets

2022-10-31 Thread Jonathan S. Katz
On 10/31/22 6:05 PM, Dagfinn Ilmari Mannsåker wrote: * password (text) - a plaintext password * salt (text) - a base64 encoded salt […] + /* +* determine if this a valid base64 encoded string +* TODO: look into refactoring the SCRAM decode code in libpq/auth-scram.c +

User functions for building SCRAM secrets

2022-10-31 Thread Jonathan S. Katz
Hi, We currently do not provide any SQL functions for generating SCRAM secrets, whereas we have this support for other passwords types (plaintext and md5 via `md5(password || username)`). If a user wants to build a SCRAM secret via SQL, they have to implement our SCRAM hashing funcs on their

PostgreSQL 15 GA - Oct 13, 2022

2022-10-10 Thread Jonathan S. Katz
Hi, The PostgreSQL 15 GA will be Oct 13, 2022. Thanks, Jonathan OpenPGP_signature Description: OpenPGP digital signature

Re: START_REPLICATION SLOT causing a crash in an assert build

2022-10-08 Thread Jonathan S. Katz
On 10/8/22 1:40 PM, Andres Freund wrote: On 2022-10-08 09:53:50 -0700, Andres Freund wrote: On 2022-10-07 19:56:33 -0700, Andres Freund wrote: I'm planning to push this either later tonight (if I feel up to it after cooking dinner) or tomorrow morning PST, due to the release wrap deadline. I

Re: START_REPLICATION SLOT causing a crash in an assert build

2022-10-06 Thread Jonathan S. Katz
On 10/6/22 1:10 AM, Kyotaro Horiguchi wrote: At Thu, 6 Oct 2022 13:44:43 +0900, Michael Paquier wrote in On Wed, Oct 05, 2022 at 11:24:57PM -0400, Jonathan S. Katz wrote: On 10/5/22 8:44 PM, Andres Freund wrote: I have two ideas how to fix it. As a design constraint, I'd be interest

Re: START_REPLICATION SLOT causing a crash in an assert build

2022-10-05 Thread Jonathan S. Katz
On 10/5/22 8:44 PM, Andres Freund wrote: Hi, On 2022-10-05 13:00:53 -0400, Jonathan S. Katz wrote: On 9/27/22 1:52 AM, Kyotaro Horiguchi wrote: Thanks! At Mon, 26 Sep 2022 19:53:02 -0700, Andres Freund wrote in I wonder if the correct fix here wouldn't be to move the slotname o

Re: START_REPLICATION SLOT causing a crash in an assert build

2022-10-05 Thread Jonathan S. Katz
On 9/27/22 1:52 AM, Kyotaro Horiguchi wrote: Thanks! At Mon, 26 Sep 2022 19:53:02 -0700, Andres Freund wrote in I wonder if the correct fix here wouldn't be to move the slotname out of PgStat_StatReplSlotEntry? Ugh. Right. I thought its outer struct as purely the part for the common header.

PostgreSQL 15 RC2 + GA release dates

2022-10-03 Thread Jonathan S. Katz
Hi, We are planning a PostgreSQL 15 RC2 release for October 6, 2022. We are releasing a second release candidate due to the revert of an optimization around the GROUP BY clause. We are still planning the PostgreSQL 15 GA release for October 13, but we may push this to October 20 based on rep

Re: Question: test "aggregates" failed in 32-bit machine

2022-10-03 Thread Jonathan S. Katz
On 10/2/22 8:45 PM, Michael Paquier wrote: On Sun, Oct 02, 2022 at 02:11:12PM -0400, Tom Lane wrote: "Jonathan S. Katz" writes: OK. For v15 I am heavily in favor for the least risky approach given the point we are at in the release cycle. The RMT hasn’t met yet to discuss, but from

Re: Question: test "aggregates" failed in 32-bit machine

2022-10-02 Thread Jonathan S. Katz
> On Oct 2, 2022, at 1:12 PM, Tom Lane wrote: > > "Jonathan S. Katz" writes: >>> On 10/1/22 6:57 PM, Tom Lane wrote: >>> I plan to have a look tomorrow at the idea of reverting only the cost_sort >>> changes, and rewriting get_cheapest_g

Re: Question: test "aggregates" failed in 32-bit machine

2022-10-02 Thread Jonathan S. Katz
On 10/1/22 6:57 PM, Tom Lane wrote: "Jonathan S. Katz" writes: On 10/1/22 3:13 PM, Tom Lane wrote: I'm still of the opinion that we need to revert this code for now. [RMT hat, but speaking just for me] reading through Tom's analysis, this seems to be the safest path f

Re: Question: test "aggregates" failed in 32-bit machine

2022-10-01 Thread Jonathan S. Katz
On 10/1/22 3:13 PM, Tom Lane wrote: I'm still of the opinion that we need to revert this code for now. [RMT hat, but speaking just for me] reading through Tom's analysis, this seems to be the safest path forward. I have a few questions to better understand: 1. How invasive would the revert

PostgreSQL 15 RC1 release announcement draft

2022-09-28 Thread Jonathan S. Katz
Hi, Attached is a draft of the PostgreSQL 15 RC 1 release announcement. Please provide feedback no later than 2022-09-29 0:00 AoE. Thanks, Jonathan The PostgreSQL Global Development Group announces that the first release candidate of PostgreSQL 15 is now available for download. As a release c

PostgreSQL 15 GA release date

2022-09-26 Thread Jonathan S. Katz
Hi, The PostgreSQL 15 GA release (15.0) is now scheduled for October 13, 2022. The release team changed this from the planned date of October 6 to allow for additional testing of recent changes. Please let us know if you have any questions. We're excited that we are very close to officially

Re: First draft of the PG 15 release notes

2022-09-23 Thread Jonathan S. Katz
On 9/23/22 1:33 PM, Tom Lane wrote: "Jonathan S. Katz" writes: On 9/23/22 11:25 AM, Tom Lane wrote: I'm planning to do a final(?) pass over the v15 notes today, but I thought it'd be appropriate to push this separately. RE "final pass", there's still an

Re: First draft of the PG 15 release notes

2022-09-23 Thread Jonathan S. Katz
On 9/23/22 11:25 AM, Tom Lane wrote: "Jonathan S. Katz" writes: Adjusted to be similar to your suggestion. Updated patch attached. I pushed this with a bit more copy-editing. I'm planning to do a final(?) pass over the v15 notes today, but I thought it'd be appr

Re: why can't a table be part of the same publication as its schema

2022-09-22 Thread Jonathan S. Katz
> On Sep 22, 2022, at 8:02 AM, Alvaro Herrera wrote: > > FWIW I put this to CI: > https://cirrus-ci.com/build/5823276948652032 (master) > > and everything appears to be OK. If anybody has reservations about this > grammar change, please speak up soon, as there's not much time before RC1. >

Re: why can't a table be part of the same publication as its schema

2022-09-21 Thread Jonathan S. Katz
On 9/21/22 10:24 AM, Alvaro Herrera wrote: On 2022-Sep-20, Robert Haas wrote: I don't think we should change this behavior that's already in logical replication. While I understand the reasons why "GRANT ... ALL TABLES IN SCHEMA" has a different behavior (i.e. it's not applied to future objects

Re: why can't a table be part of the same publication as its schema

2022-09-20 Thread Jonathan S. Katz
[personal views, not RMT] On 9/20/22 4:06 PM, Mark Dilger wrote: I don't complain that it is buidling on the existing behavior. I'm *only* concerned about the keywords we're using for this. Consider the following: -- AS ADMIN CREATE USER bob NOSUPERUSER; GRANT ALL PRIVILEGES ON

Re: why can't a table be part of the same publication as its schema

2022-09-20 Thread Jonathan S. Katz
(RMT hat on, unless otherwise noted) On 9/20/22 9:42 AM, Robert Haas wrote: On Mon, Sep 19, 2022 at 11:03 PM Jonathan S. Katz wrote: For #1 (allowing calls that have schema/table overlap...), there appears to be both a patch that allows this (reversing[8]), and a suggestion for dealing with a

Re: why can't a table be part of the same publication as its schema

2022-09-20 Thread Jonathan S. Katz
On 9/20/22 10:55 AM, Mark Dilger wrote: On Sep 19, 2022, at 8:03 PM, Jonathan S. Katz wrote: "When a partitioned table is added to a publication, all of its existing and future partitions are implicitly considered to be part of the publication."[10] Additionally, this is the beh

Re: why can't a table be part of the same publication as its schema

2022-09-19 Thread Jonathan S. Katz
On 9/19/22 4:52 PM, Jonathan S. Katz wrote: On 9/19/22 11:16 AM, Alvaro Herrera wrote: This seems a pretty arbitrary restriction.  It feels like you're adding this restriction precisely so that you don't have to write the code to reject the ALTER .. SET SCHEMA if an incompatible con

Re: why can't a table be part of the same publication as its schema

2022-09-19 Thread Jonathan S. Katz
On 9/19/22 11:16 AM, Alvaro Herrera wrote: diff --git a/doc/src/sgml/logical-replication.sgml b/doc/src/sgml/logical-replication.sgml index 1ae3287..0ab768d 100644 --- a/doc/src/sgml/logical-replication.sgml +++ b/doc/src/sgml/logical-replication.sgml @@ -1120,6 +1120,11 @@ test_sub=# SELECT *

PostgreSQL 15 RC1 + GA dates

2022-09-16 Thread Jonathan S. Katz
Hi, The release team is planning to release PostgreSQL 15 Release Candidate 1 (RC1) on 2022-09-29. Please ensure all open items[1] are resolved no later than 2022-09-24 0:00 AoE. Following recent release patterns, we planning for 2022-10-06 to be the GA date. This may change based on what re

Re: First draft of the PG 15 release notes

2022-09-13 Thread Jonathan S. Katz
On 9/13/22 7:13 AM, Alvaro Herrera wrote: On 2022-Sep-12, Jonathan S. Katz wrote: + + + Column-level and row-level filtering on + logical replication + publications. + + -column-level filtering +the ability to specify column lists Adjusted to be similar to

Re: First draft of the PG 15 release notes

2022-09-12 Thread Jonathan S. Katz
On 9/4/22 2:42 PM, Nathan Bossart wrote: I noticed that the v15 release notes still refer to pg_checkpointer, which was renamed to pg_checkpoint in b9eb0ff. diff --git a/doc/src/sgml/release-15.sgml b/doc/src/sgml/release-15.sgml index d432c2db44..362728753a 100644 --- a/doc/src/sgml/release-15.

Re: PostgreSQL 15 release announcement draft

2022-09-12 Thread Jonathan S. Katz
On 9/12/22 4:17 PM, David Rowley wrote: On Tue, 13 Sept 2022 at 04:53, Jonathan S. Katz wrote: Here is a (penultimate?) draft that includes URLs. Please provide any additional feedback no later than 2022-09-14 0:00 AoE. After that, we will begin the translation process. Thanks for drafting

Re: PostgreSQL 15 release announcement draft

2022-09-12 Thread Jonathan S. Katz
On 9/12/22 3:34 PM, Justin Pryzby wrote: On Mon, Sep 12, 2022 at 12:52:49PM -0400, Jonathan S. Katz wrote: sorted. Using `row_number()`, `rank()`, and `count()` as [window functions](https://www.postgresql.org/docs/15/functions-window.html) also have performance benefits in PostgreSQL 15, and

Re: PostgreSQL 15 release announcement draft

2022-09-12 Thread Jonathan S. Katz
On 9/12/22 2:01 PM, Peter Eisentraut wrote: On 12.09.22 18:52, Jonathan S. Katz wrote: On 9/1/22 9:10 PM, Jonathan S. Katz wrote: New version attached. Here is a (penultimate?) draft that includes URLs. Please provide any additional feedback no later than 2022-09-14 0:00 AoE. After that

Re: PostgreSQL 15 release announcement draft

2022-09-12 Thread Jonathan S. Katz
On 9/1/22 9:10 PM, Jonathan S. Katz wrote: New version attached. Here is a (penultimate?) draft that includes URLs. Please provide any additional feedback no later than 2022-09-14 0:00 AoE. After that, we will begin the translation process. Thanks, Jonathan The PostgreSQL Global

Re: PostgreSQL 15 Beta 4 release announcement draft

2022-09-07 Thread Jonathan S. Katz
On 9/7/22 1:18 AM, Erik Rijkers wrote: Op 07-09-2022 om 03:40 schreef Jonathan S. Katz: Hi, I've attached a draft of the PostgreSQL 15 Beta 4 release announcement. Please review for correctness and if there are any omissions. Please provide feedback on the draft no later than Sep 8, 2

Re: PostgreSQL 15 Beta 4 release announcement draft

2022-09-07 Thread Jonathan S. Katz
On 9/7/22 4:02 AM, Alvaro Herrera wrote: Hi Jonathan, On 2022-Sep-06, Jonathan S. Katz wrote: * [`MERGE`](https://www.postgresql.org/docs/15/sql-merge.html) statements are explicitly rejected inside of a [common-table expression](https://www.postgresql.org/docs/15/queries-with.html) (aka

PostgreSQL 15 Beta 4 release announcement draft

2022-09-06 Thread Jonathan S. Katz
Hi, I've attached a draft of the PostgreSQL 15 Beta 4 release announcement. Please review for correctness and if there are any omissions. Please provide feedback on the draft no later than Sep 8, 2022 0:00 AoE. Thanks! Jonathan The PostgreSQL Global Development Group announces that the fourt

Re: pg15b3: recovery fails with wal prefetch enabled

2022-09-06 Thread Jonathan S. Katz
On 9/5/22 10:03 PM, Thomas Munro wrote: On Tue, Sep 6, 2022 at 1:51 PM Tom Lane wrote: "Jonathan S. Katz" writes: On 9/5/22 7:18 PM, Thomas Munro wrote: Well I was about to commit this, but beta4 just got stamped (but not yet tagged). I see now that Jonathan (with RMT hat on, C

Re: pg15b3: recovery fails with wal prefetch enabled

2022-09-05 Thread Jonathan S. Katz
On 9/5/22 7:18 PM, Thomas Munro wrote: On Mon, Sep 5, 2022 at 9:08 PM Thomas Munro wrote: At Mon, 05 Sep 2022 14:15:27 +0900 (JST), Kyotaro Horiguchi wrote in At Mon, 5 Sep 2022 16:54:07 +1200, Thomas Munro wrote in On reflection, it'd be better not to clobber any pre-existing error there,

Re: POC: GROUP BY optimization

2022-09-04 Thread Jonathan S. Katz
On 9/4/22 6:14 PM, Tomas Vondra wrote: I've pushed the fix to 15+master. In the end I just used David's patches that set parallel_setup_cost to 0. Thanks! I have closed the open item. Jonathan OpenPGP_signature Description: OpenPGP digital signature

Re: First draft of the PG 15 release notes

2022-09-04 Thread Jonathan S. Katz
On 5/10/22 11:44 AM, Bruce Momjian wrote: I have completed the first draft of the PG 15 release notes I assume there will be major adjustments in the next few weeks based on feedback. I wanted to propose the "major enhancements" section to see if we can get an iteration in prior to Beta 4.

Re: PostgreSQL 15 release announcement draft

2022-09-01 Thread Jonathan S. Katz
On 8/31/22 8:15 PM, Justin Pryzby wrote: On Tue, Aug 30, 2022 at 03:58:48PM -0400, Jonathan S. Katz wrote: In this latest release, PostgreSQL improves on its in-memory and on-disk sorting algorithms, with benchmarks showing speedups of 25% - 400% based on sort types. rather than "bas

Re: PostgreSQL 15 release announcement draft

2022-09-01 Thread Jonathan S. Katz
On 8/31/22 1:51 PM, Michael Banck wrote: Hi, On Tue, Aug 30, 2022 at 03:58:48PM -0400, Jonathan S. Katz wrote: ### Other Notable Changes PostgreSQL server-level statistics are now collected in shared memory, eliminating the statistics collector process and writing these stats to disk

Re: SQL/JSON features for v15

2022-09-01 Thread Jonathan S. Katz
On 9/1/22 5:13 PM, Andrew Dunstan wrote: On 2022-08-31 We 14:22, Andrew Dunstan wrote: On 2022-08-31 We 12:48, Jonathan S. Katz wrote: With RMT hat on -- Andrew can you please revert the patchset? :-( Yes, I'll do it, starting with the v15 branch. Might take a day or so. done

Re: POC: GROUP BY optimization

2022-09-01 Thread Jonathan S. Katz
On 9/1/22 9:06 AM, Tomas Vondra wrote: On 8/30/22 15:15, Jonathan S. Katz wrote: On 8/18/22 3:29 AM, Tomas Vondra wrote: On 8/18/22 03:32, David Rowley wrote: Here are a couple of patches to demo the idea. Yeah, that's an option too. I should have mentioned it along wit

Re: SQL/JSON features for v15

2022-08-31 Thread Jonathan S. Katz
On 8/31/22 3:08 PM, Andrew Dunstan wrote: On 2022-08-31 We 14:45, Tom Lane wrote: To the extent that there was a management failure here, it was that we didn't press for a resolution sooner. Given the scale of the concerns raised in June, I kind of agree with Andres' opinion that fixing them p

Re: SQL/JSON features for v15

2022-08-31 Thread Jonathan S. Katz
On 8/31/22 12:26 PM, Robert Haas wrote: On Wed, Aug 31, 2022 at 10:20 AM Jonathan S. Katz wrote: Andres, Robert, Tom: With this recent work, have any of your opinions changed on including SQL/JSON in v15? No. Nothing's been committed, and there's no time to review anything in d

Re: SQL/JSON features for v15

2022-08-31 Thread Jonathan S. Katz
On 8/31/22 8:38 AM, Andrew Dunstan wrote: On 2022-08-31 We 07:01, Amit Langote wrote: On Wed, Aug 31, 2022 at 3:51 PM Amit Langote wrote: SELECT JSON_VALUE(jsonb '"aaa"', '$' RETURNING int DEFAULT 111 ON ERROR); - json_value - -111 -(1 row) - +ERROR: syntax error at or

PostgreSQL 15 release announcement draft

2022-08-30 Thread Jonathan S. Katz
Hi, Please see the first draft for the PostgreSQL 15 release announcement. This is the announcement that goes out when we ship 15.0. A few notes on the first draft: 1. I have not put in any links yet -- I want to ensure the document is close to being static before I add those in. 2. I have

Re: SQL/JSON features for v15

2022-08-30 Thread Jonathan S. Katz
On 8/30/22 9:16 AM, Andrew Dunstan wrote: On 2022-08-30 Tu 06:29, Amit Langote wrote: On Tue, Aug 30, 2022 at 6:19 PM Alvaro Herrera wrote: On 2022-Aug-30, Amit Langote wrote: Patches 0001-0006: Yeah, these add the overhead of an extra function call (typin() -> typin_opt_error()) in possib

Re: POC: GROUP BY optimization

2022-08-30 Thread Jonathan S. Katz
On 8/18/22 3:29 AM, Tomas Vondra wrote: On 8/18/22 03:32, David Rowley wrote: Here are a couple of patches to demo the idea. Yeah, that's an option too. I should have mentioned it along with the cpu_operator_cost. BTW would you mind taking a look at the costing? I think it's fine, but it

Re: SQL/JSON features for v15

2022-08-29 Thread Jonathan S. Katz
On 8/29/22 8:56 AM, Amit Langote wrote: On Sat, Aug 27, 2022 at 5:11 AM Nikita Glukhov wrote: I am not sure if it's OK to eval_const_expressions() on a Query sub-expression during parse-analysis. IIUC, it is only correct to apply it to after the rewriting phase. Maybe it would be bette

Re: SQL/JSON features for v15

2022-08-27 Thread Jonathan S. Katz
On 8/26/22 4:36 PM, Andrew Dunstan wrote: On 2022-08-26 Fr 16:11, Nikita Glukhov wrote: Hi, On 26.08.2022 22:25, Andrew Dunstan wrote: On 2022-08-24 We 20:05, Nikita Glukhov wrote: v8 - is a highly WIP patch, which I failed to finish today. Even some test cases fail now, and they simply sho

Re: SQL/JSON features for v15

2022-08-26 Thread Jonathan S. Katz
On 8/24/22 8:16 PM, Andrew Dunstan wrote: On 2022-08-24 We 20:05, Nikita Glukhov wrote: v8 - is a highly WIP patch, which I failed to finish today. Even some test cases fail now, and they simply show unfinished things like casts to bytea (they can be simply removed) and missing safe input fun

PostgreSQL 15 Beta 4

2022-08-25 Thread Jonathan S. Katz
Hi, We will be releasing a PostgreSQL 15 Beta 4 on September 8, 2022. Please have open items[1] completed and committed no later than September 5, 2022 0:00 AoE[2]. Thanks, Jonathan [1] https://wiki.postgresql.org/wiki/PostgreSQL_15_Open_Items [2] https://en.wikipedia.org/wiki/Anywhere_on_E

Re: SQL/JSON features for v15

2022-08-23 Thread Jonathan S. Katz
On 8/23/22 1:26 PM, Andres Freund wrote: Hi, On 2022-08-23 13:18:49 -0400, Jonathan S. Katz wrote: Taking RMT hat off, if the outcome is "revert", I do want to ensure we don't lose momentum on getting this into v16. I know a lot of time and effort has gone into this featureset

Re: SQL/JSON features for v15

2022-08-23 Thread Jonathan S. Katz
On 8/23/22 2:10 PM, Andrew Dunstan wrote: On 2022-08-23 Tu 13:24, Tom Lane wrote: "Jonathan S. Katz" writes: I saw Andrew suggest that the controversial parts of the patchset may be severable from some of the new functionality, so I would like to see that proposal and if it is

Re: SQL/JSON features for v15

2022-08-23 Thread Jonathan S. Katz
On 8/23/22 11:08 AM, Tom Lane wrote: Robert Haas writes: At the end of the day, the RMT is going to have to take a call here. It seems to me that Andres's concerns about code quality and lack of comments are probably somewhat legitimate, and in particular I do not think the use of subtransactio

Re: SQL/JSON features for v15

2022-08-23 Thread Jonathan S. Katz
On 8/23/22 12:13 AM, Michael Paquier wrote: On Mon, Aug 22, 2022 at 07:57:29PM -0700, Andres Freund wrote: To me it feels like there's a probably too much work here to cram it at this point. If several other committers shared the load of working on this it'd perhaps be doable, but I've not seen

Re: SQL/JSON features for v15

2022-08-22 Thread Jonathan S. Katz
On 8/19/22 10:11 AM, Jonathan S. Katz wrote: Hi, On 8/17/22 11:45 PM, Nikita Glukhov wrote: Hi, On 17.08.2022 04:45, Jonathan S. Katz wrote: On 8/15/22 10:14 PM, Andres Freund wrote: I pushed a few cleanups to https://github.com/anarazel/postgres/commits/json while I was hacking on this

Re: SQL/JSON features for v15

2022-08-19 Thread Jonathan S. Katz
Hi, On 8/17/22 11:45 PM, Nikita Glukhov wrote: Hi, On 17.08.2022 04:45, Jonathan S. Katz wrote: On 8/15/22 10:14 PM, Andres Freund wrote: I pushed a few cleanups to https://github.com/anarazel/postgres/commits/json while I was hacking on this (ignore that it's based on the meson

Re: SQL/JSON features for v15

2022-08-16 Thread Jonathan S. Katz
Hi, On 8/15/22 10:14 PM, Andres Freund wrote: I pushed a few cleanups to https://github.com/anarazel/postgres/commits/json while I was hacking on this (ignore that it's based on the meson tree, that's just faster for me). Some of them might not be applicable anymore, but it might still make sen

Re: PG 15 (and to a smaller degree 14) regression due to ExprEvalStep size

2022-08-11 Thread Jonathan S. Katz
On 8/10/22 9:27 AM, Amit Langote wrote: On Wed, Aug 10, 2022 at 3:57 AM Andres Freund wrote: One way this code could be drastically simplified is to force all type-coercions to go through the "io coercion" path, which could be implemented as a single execution step (which thus could trivially s

Re: SQL/JSON features for v15

2022-08-11 Thread Jonathan S. Katz
On 8/10/22 11:50 AM, Andrew Dunstan wrote: On 2022-08-09 Tu 16:58, Jonathan S. Katz wrote: Hi, (Personal hat, not RMT hat unless otherwise noted). This thread[1] raised some concerns around the implementation of the SQL/JSON features that are slated for v15, which includes an outstanding

Re: moving basebackup code to its own directory

2022-08-10 Thread Jonathan S. Katz
On 8/10/22 12:32 PM, Magnus Hagander wrote: On Wed, Aug 10, 2022 at 6:20 PM Tom Lane wrote: Robert Haas writes: David Steele voted for back-patching this on the grounds that it would make future back-patching easier, which is an argument that seems to me to have some merit, although on the o

Re: SQL/JSON features for v15

2022-08-09 Thread Jonathan S. Katz
On 8/9/22 4:58 PM, Jonathan S. Katz wrote: We're looking for additional input on what makes sense as a best course of action, given what is presented in[3]. Missed adding Amit on the CC. Jonathan OpenPGP_signature Description: OpenPGP digital signature

SQL/JSON features for v15

2022-08-09 Thread Jonathan S. Katz
Hi, (Personal hat, not RMT hat unless otherwise noted). This thread[1] raised some concerns around the implementation of the SQL/JSON features that are slated for v15, which includes an outstanding open item[2]. Given the current state of the discussion, when the RMT met on Aug 8, they severa

Re: PG 15 (and to a smaller degree 14) regression due to ExprEvalStep size

2022-08-09 Thread Jonathan S. Katz
On 8/9/22 4:15 PM, Andrew Dunstan wrote: On 2022-08-09 Tu 15:50, Jonathan S. Katz wrote: On 8/9/22 3:22 PM, Andres Freund wrote: OTOH, it's not a great sign  this is around json again... Yeah, I was thinking about that too. Ouch :-( I think after 10 years of being involved wit

Re: PG 15 (and to a smaller degree 14) regression due to ExprEvalStep size

2022-08-09 Thread Jonathan S. Katz
On 8/9/22 2:57 PM, Andres Freund wrote: Hi, On 2022-08-09 14:04:48 -0400, Jonathan S. Katz wrote:   2. Recommend holding up the v15 release to allow for the code to be redesigned and fixed (as based on Andres' estimates, this would push the release out several months). Obviously tha

Re: PG 15 (and to a smaller degree 14) regression due to ExprEvalStep size

2022-08-09 Thread Jonathan S. Katz
On 8/9/22 3:22 PM, Andres Freund wrote: Hi, On 2022-08-09 15:17:44 -0400, Tom Lane wrote: We have delayed releases for $COOL_FEATURE in the past, and I think our batting average on that is still .000: not once has it worked out well. I think it semi worked when jsonb (?) first went in - it to

Re: PG 15 (and to a smaller degree 14) regression due to ExprEvalStep size

2022-08-09 Thread Jonathan S. Katz
On 8/9/22 11:03 AM, Andrew Dunstan wrote: On 2022-08-09 Tu 09:59, Jonathan S. Katz wrote: The RMT met today to discuss the state of this open item surrounding the SQL/JSON feature set. We discussed the specific concerns raised about the code and debated four different options:   1. Do

Re: PG 15 (and to a smaller degree 14) regression due to ExprEvalStep size

2022-08-09 Thread Jonathan S. Katz
On 8/5/22 4:36 PM, Andres Freund wrote: Hi, I tried to look into some of the questions from Amit, but I have e.g. no idea what exactly the use of subtransactions tries to achieve - afaics 1a36bc9dba8 is the first patch to introduce needing to evaluate parts expressions in a subtransaction - but

Re: 2022-08-11 release announcement draft

2022-08-08 Thread Jonathan S. Katz
On 8/8/22 12:44 PM, Justin Pryzby wrote: On Mon, Aug 08, 2022 at 11:50:16AM -0400, Jonathan S. Katz wrote: * Fix [`pg_upgrade`](https://www.postgresql.org/docs/current/pgupgrade.html) to detect non-upgradable usages of functions accepting `anyarray` parameters. use or usage This line comes

2022-08-11 release announcement draft

2022-08-08 Thread Jonathan S. Katz
Hi, Please see attached draft of the 2022-08-11 release announcement. Please provide feedback on {technical accuracy, omissions, any other errors} no later than 2022-08-11 0:00 AoE[1]. Thanks, Jonathan [1] https://en.wikipedia.org/wiki/Anywhere_on_Earth The PostgreSQL Global Development Gro

Re: pg15b2: large objects lost on upgrade

2022-08-04 Thread Jonathan S. Katz
On 8/3/22 4:19 PM, Tom Lane wrote: "Jonathan S. Katz" writes: I did rule out wanting to do the "xid + $X" check after reviewing some of the output. I think that both $X could end up varying, and it really feels like a bandaid. It is that. I wouldn't feel comfortable

Re: pg15b2: large objects lost on upgrade

2022-08-03 Thread Jonathan S. Katz
On 8/3/22 2:08 PM, Peter Geoghegan wrote: On Wed, Aug 3, 2022 at 1:47 PM Tom Lane wrote: Again, this seems to me to be breaking the test's real-world applicability for a (false?) sense of stability. I agree. A lot of the VACUUM test flappiness issues we've had to deal with in the past now se

Re: pg15b2: large objects lost on upgrade

2022-08-03 Thread Jonathan S. Katz
> On Aug 3, 2022, at 10:14 AM, Tom Lane wrote: > > Robert Haas writes: >>> On Tue, Aug 2, 2022 at 3:51 PM Tom Lane wrote: >>> I also think that ">=" is a sufficient requirement. > >> I don't really like this approach. Imagine that the code got broken in >> such a way that relfrozenxid and r

Re: pg15b2: large objects lost on upgrade

2022-08-02 Thread Jonathan S. Katz
On 8/2/22 4:20 PM, Jonathan S. Katz wrote: On 8/2/22 3:51 PM, Tom Lane wrote: "Jonathan S. Katz" writes: On 8/2/22 3:39 PM, Tom Lane wrote: I am not in favor of disabling autovacuum in the test: ordinary users are not going to do that while pg_upgrade'ing, so it'

Re: pg15b2: large objects lost on upgrade

2022-08-02 Thread Jonathan S. Katz
On 8/2/22 3:51 PM, Tom Lane wrote: "Jonathan S. Katz" writes: On 8/2/22 3:39 PM, Tom Lane wrote: I am not in favor of disabling autovacuum in the test: ordinary users are not going to do that while pg_upgrade'ing, so it'd make the test less representative of real-world usa

Re: pg15b2: large objects lost on upgrade

2022-08-02 Thread Jonathan S. Katz
On 8/2/22 3:39 PM, Tom Lane wrote: "Jonathan S. Katz" writes: On 8/2/22 3:23 PM, Robert Haas wrote: I'm not quite sure how to rule that theory in or out, though. Without overcomplicating this, are we able to check to see if autovacuum ran during the course of the test? L

Re: pg15b2: large objects lost on upgrade

2022-08-02 Thread Jonathan S. Katz
On 8/2/22 3:23 PM, Robert Haas wrote: On Tue, Aug 2, 2022 at 1:12 PM Tom Lane wrote: Not sure what to make of this, except that maybe the test is telling us about an actual bug of exactly the kind it's designed to expose. That could be, but what would the bug be exactly? It's hard to think of

Re: pg15b2: large objects lost on upgrade

2022-08-02 Thread Jonathan S. Katz
On 8/2/22 1:12 PM, Tom Lane wrote: "Jonathan S. Katz" writes: Given this appears to be resolved, I have removed this from "Open Items". Thanks! Sadly, we're still not out of the woods. I see three buildfarm failures in this test since Robert resolved the "-X

Re: pg15b2: large objects lost on upgrade

2022-08-01 Thread Jonathan S. Katz
On 7/30/22 10:40 AM, Tom Lane wrote: Noah Misch writes: The pg_backend_pid is from "SELECT pg_catalog.pg_backend_pid();" in ~/.psqlrc, so the lack of -X caused that. The latest commit fixes things on a normal GNU/Linux box, so I bet it will fix wrasse. Yup, looks like we're all good now. Th

Re: Handle infinite recursion in logical replication setup

2022-07-25 Thread Jonathan S. Katz
On 7/25/22 4:54 AM, vignesh C wrote: On Sun, Jul 24, 2022 at 10:21 PM Jonathan S. Katz wrote: On 7/22/22 12:47 AM, Amit Kapila wrote: On Fri, Jul 22, 2022 at 1:39 AM Jonathan S. Katz wrote: BTW, do you have any opinion on the idea of the first remaining patch where we accomplish two

Re: Handle infinite recursion in logical replication setup

2022-07-24 Thread Jonathan S. Katz
On 7/22/22 12:47 AM, Amit Kapila wrote: On Fri, Jul 22, 2022 at 1:39 AM Jonathan S. Katz wrote: 1. I'm concerned by calling this "Bidirectional replication" in the docs that we are overstating the current capabilities. I think this is accentuated int he opening par

Re: Handle infinite recursion in logical replication setup

2022-07-21 Thread Jonathan S. Katz
Hi, On 7/21/22 6:34 AM, vignesh C wrote: On Thu, Jul 21, 2022 at 2:06 PM Amit Kapila wrote: On Wed, Jul 20, 2022 at 2:33 PM vignesh C wrote: Modified. Apart from this I have run pgperltidy on the perl file and renamed 032_origin.pl to 030_origin.pl as currently there is 029_on_error.pl, 03

Re: PG15 beta1 sort performance regression due to Generation context change

2022-07-15 Thread Jonathan S. Katz
On 7/15/22 6:52 PM, Andres Freund wrote: Hi, On 2022-07-15 18:40:11 -0400, Jonathan S. Katz wrote: What I find interesting is the resistance to adding any documentation around this feature to guide users in case they hit the regression. I understand it can be difficult to provide guidance on

Re: PG15 beta1 sort performance regression due to Generation context change

2022-07-15 Thread Jonathan S. Katz
Thank you for the very detailed analysis. Comments inline. On 7/15/22 7:12 PM, David Rowley wrote: On Sat, 16 Jul 2022 at 10:40, Jonathan S. Katz wrote: What I find interesting is the resistance to adding any documentation around this feature to guide users in case they hit the regression. I

Re: PG15 beta1 sort performance regression due to Generation context change

2022-07-15 Thread Jonathan S. Katz
On 7/15/22 6:40 PM, Jonathan S. Katz wrote: On 7/15/22 4:54 PM, Tom Lane wrote: Tomas Vondra writes: ... My personal opinion is that it's a rare regression. Other optimization patches have similar rare regressions, except that David spent so much time investigating this one it seems

Re: PG15 beta1 sort performance regression due to Generation context change

2022-07-15 Thread Jonathan S. Katz
On 7/15/22 4:54 PM, Tom Lane wrote: Tomas Vondra writes: ... My personal opinion is that it's a rare regression. Other optimization patches have similar rare regressions, except that David spent so much time investigating this one it seems more serious. Yeah, this. I fear we're making a moun

Re: PG15 beta1 sort performance regression due to Generation context change

2022-07-15 Thread Jonathan S. Katz
On 7/15/22 4:36 PM, Tomas Vondra wrote: On 7/13/22 17:32, Andres Freund wrote: Hi, On 2022-07-13 09:23:00 -0400, Jonathan S. Katz wrote: On 7/13/22 12:13 AM, David Rowley wrote: On Tue, 12 Jul 2022 at 17:15, David Rowley wrote: So far only Robert has raised concerns with this regression

Re: PG15 beta1 sort performance regression due to Generation context change

2022-07-13 Thread Jonathan S. Katz
Hi David, On 7/13/22 12:13 AM, David Rowley wrote: On Tue, 12 Jul 2022 at 17:15, David Rowley wrote: So far only Robert has raised concerns with this regression for PG15 (see [2]). Tom voted for leaving things as they are for PG15 in [3]. John agrees, as quoted above. Does anyone else have any

<    1   2   3   4   5   6   7   >