Re: [Proposal] Global temporary tables

2022-02-26 Thread Justin Pryzby
". Have you looked at Gilles Darold's GTT extension ? >From b89f3cc5c78e7b4c3e10ab39ef527b524d0d112d Mon Sep 17 00:00:00 2001 From: Justin Pryzby Date: Sat, 1 Jan 2022 17:02:30 -0600 Subject: [PATCH 02/11] f!0002-gtt-v64-doc.patch --- doc/src/sgml/ref/create_table.sgml | 42 --

Re: explain_regress, explain(MACHINE), and default to explain(BUFFERS) (was: BUFFERS enabled by default in EXPLAIN (ANALYZE))

2022-02-26 Thread Justin Pryzby
001 From: Justin Pryzby Date: Sat, 22 Feb 2020 21:17:10 -0600 Subject: [PATCH 1/6] Add GUC: explain_regress This changes the defaults for explain to: costs off, timing off, summary off. It'd be reasonable to use this for new regression tests which are not intended to be backpatched. --- cont

Re: Missed condition-variable wakeups on FreeBSD

2022-02-26 Thread Justin Pryzby
On Sat, Feb 26, 2022 at 02:07:05PM -0500, Tom Lane wrote: > I don't know much about how gdb interacts with kernel calls on > FreeBSD, but I speculate that the poll(2) call returns with EINTR > after gdb releases the process, and then things resume fine, > suggesting that we lost an interrupt

Re: Adding CI to our tree

2022-02-25 Thread Justin Pryzby
This is the other half of my CI patches, which are unrelated to the TAP ones on the other thread. >From 88c01c09ee26db2817629265fc12b2dbcd8c9a91 Mon Sep 17 00:00:00 2001 From: Justin Pryzby Date: Mon, 17 Jan 2022 00:53:04 -0600 Subject: [PATCH 1/7] cirrus: include hints how to install OS packa

Re: set TESTDIR from perl rather than Makefile

2022-02-25 Thread Justin Pryzby
On Sun, Feb 20, 2022 at 04:39:08PM -0800, Andres Freund wrote: > On 2022-02-19 17:53:09 -0600, Justin Pryzby wrote: > > I also meant to also attach it. > > Is the patch actually independent of the other patches in your stack? Yes - I rearranged it that way for this thread. How

Re: Add parameter jit_warn_above_fraction

2022-02-25 Thread Justin Pryzby
On Fri, Feb 25, 2022 at 04:16:01PM +0100, Magnus Hagander wrote: > + { > + {"jit_warn_above_fraction", PGC_SUSET, LOGGING_WHEN, > + gettext_noop("Sets the fraction of query time spent on > JIT before writing" > + "a

Re: set TESTDIR from perl rather than Makefile

2022-02-24 Thread Justin Pryzby
On Mon, Feb 21, 2022 at 07:00:54AM -0500, Andrew Dunstan wrote: > On 2/19/22 18:53, Justin Pryzby wrote: > > On Sat, Feb 19, 2022 at 05:41:49PM -0600, Justin Pryzby wrote: > >> I rebased and fixed the check-guc script to work, made it work with vpath > >> builds, and cle

Re: document that brin's autosummarize parameter is off by default

2022-02-24 Thread Justin Pryzby
Ten months ago, Jaime Casanova wrote: > Hi everyone, > > Just noted that the default value of autosummarize reloption for brin > indexes is not documented, or at least not well documented. > > I added the default value in create_index.sgml where other options > mention their own defaults, also

Re: Report checkpoint progress with pg_stat_progress_checkpoint (was: Report checkpoint progress in server logs)

2022-02-23 Thread Justin Pryzby
+ Whenever the checkpoint operation is running, the + pg_stat_progress_checkpoint view will contain a + single row indicating the progress of the checkpoint. The tables below Maybe it should show a single row , unless the checkpointer isn't running at all (like in single user mode). +

Re: CLUSTER on partitioned index

2022-02-23 Thread Justin Pryzby
On Tue, Jul 20, 2021 at 08:27:02PM -0400, Alvaro Herrera wrote: > I have to wonder if there really *is* a use case for CLUSTER in the > first place on regular tables, let alone on partitioned tables, which > are likely to be large and thus take a lot of time. What justifies > spending so much

Re: shared_preload_libraries = 'pg_stat_statements' failing with installcheck (compute_query_id = auto)

2022-02-22 Thread Justin Pryzby
On Tue, Feb 22, 2022 at 11:04:16AM +0900, Michael Paquier wrote: > On Fri, Feb 18, 2022 at 05:38:56PM +0800, Julien Rouhaud wrote: > > On Fri, Feb 18, 2022 at 05:22:36PM +0900, Michael Paquier wrote: > >> So, I have been looking at this problem, and I don't see a problem in > >> doing something

wal_compression=zstd

2022-02-22 Thread Justin Pryzby
for zlib. I'm of the impression nobody cares about this, otherwise it would've been included 5-10 years ago. Only 0001 should be reviewed for pg15 - the others are optional/future work. >From 9253013c789ffb121272bfeeaa9dcdebbef79ced Mon Sep 17 00:00:00 2001 From: Justin Pryzby Date: Fri, 18

Re: Adding CI to our tree (ccache)

2022-02-20 Thread Justin Pryzby
On Sun, Feb 20, 2022 at 12:47:31PM -0800, Andres Freund wrote: > > Did you ever try to use clcache (or others) ? > > > > When I tried, it refused to cache because of our debug settings > > (DebugInformationFormat) - which seem to be enabled even in release mode. > > > I wonder if that'll be an

Re: Adding CI to our tree (ccache)

2022-02-20 Thread Justin Pryzby
Have you tried to use the yet-to-be-released ccache with MSVC ? Also, do you know about msbuild /outputResultsCache ? When I tried that, it gave a bunch of error. https://cirrus-ci.com/task/5697497241747456 |[16:35:13.605] 1>c:\cirrus\pgsql.sln.metaproj : error : MSB4252: Project

Re: Uniforms the errors msgs at tuplestore paths

2022-02-20 Thread Justin Pryzby
On Sun, Feb 20, 2022 at 11:12:42AM -0300, Ranier Vilela wrote: > Like how the commit > https://github.com/postgres/postgres/commit/07daca53bfcad59618a9c6fad304e380cc9d2bc1 > The are some paths that were missed: I think these are all unified by the existing tuplestore patch.

Re: set TESTDIR from perl rather than Makefile

2022-02-19 Thread Justin Pryzby
On Sat, Feb 19, 2022 at 05:41:49PM -0600, Justin Pryzby wrote: > I rebased and fixed the check-guc script to work, made it work with vpath > builds, and cleaned it up some. I also meant to also attach it. > This (and other) patches ran here. > https://github.com/justinpryzby/p

set TESTDIR from perl rather than Makefile

2022-02-19 Thread Justin Pryzby
Forking: On Tue, Feb 15, 2022 at 10:42:09PM -0800, Andres Freund wrote: > >> I was thinking that we should make Utils.pm's INIT block responsible for > >> figuring out both the directory a test should run in and the log location, > >> instead having that in vcregress.pl and Makefile.global.in.

Re: pg_upgrade verbosity when redirecting output to log file

2022-02-18 Thread Justin Pryzby
+* If outputting to a tty / or , append newline. pg_log_v() will put the +* individual progress items onto the next line.

Re: Assert in pageinspect with NULL pages

2022-02-17 Thread Justin Pryzby
BRIN can also crash if passed a non-brin index. I've been sitting on this one for awhile. Feel free to include it in your patchset. commit 08010a6037fc4e24a9ba05e5386e766f4310d35e Author: Justin Pryzby Date: Tue Jan 19 00:25:15 2021 -0600 pageinspect: brin_page_items(): check that given

Re: Nonrandom scanned_pages distorts pg_class.reltuples set by VACUUM

2022-02-17 Thread Justin Pryzby
On Wed, Feb 16, 2022 at 07:43:09PM -0800, Peter Geoghegan wrote: > > I also have a hard time making heads or tails out of the commit message of > > 44fa84881ff. It's quite long without being particularly descriptive. The > > commit just changes a lot of things at once, making it hard to precisely

Re: adding 'zstd' as a compression algorithm (initdb/lz4)

2022-02-16 Thread Justin Pryzby
z4 in initdb when available. This patch intends to implement that. I have no particular interest in this, but if anyone wants, I will add it to the next CF (or the one after that). commit 2a3c5950e625ccfaebc49bbf71b8db16dc143cd2 Author: Justin Pryzby Date: Tue Feb 15 19:14:33 2022 -0600 in

Re: Adding CI to our tree

2022-02-15 Thread Justin Pryzby
On Sun, Feb 13, 2022 at 01:53:19PM -0800, Andres Freund wrote: > Hi, > > On 2022-02-13 15:31:20 -0600, Justin Pryzby wrote: > > Oh - I suppose you're right. That's an unfortunate consequence of running a > > single prove instance without chdir. > > I don't think

Re: make tuplestore helper function

2022-02-15 Thread Justin Pryzby
On Tue, Jan 11, 2022 at 10:19:33AM -0500, Melanie Plageman wrote: > > If the expectedDesc NULL check were an 0001 patch, then 0002 (the main > > patch) > > would be even easier to review. Only foreign.c is different. > > I'll wait to do that if preferred by committer. > Are you imagining that

Re: Small and unaffected typo in pg_logical_slot_get_changes_guts()

2022-02-15 Thread Justin Pryzby
On Wed, Feb 16, 2022 at 11:27:58AM +0900, Kasahara Tatsuhito wrote: > - tuplestore_donestoring(tupstore); > + tuplestore_donestoring(p->tupstore); Melanie's tuplestore patch also removes the bogus line.

Re: adding 'zstd' as a compression algorithm

2022-02-15 Thread Justin Pryzby
On Tue, Feb 15, 2022 at 03:23:30PM -0500, Robert Haas wrote: > On Tue, Feb 15, 2022 at 1:55 PM Justin Pryzby wrote: > > Regarding the patch: > > > > I suppose it should support windows, and whatever patches use zstd should > > update the install instructions. See 9ca4

Re: adding 'zstd' as a compression algorithm

2022-02-15 Thread Justin Pryzby
I think the WAL patch (4035cd5d4) should support zstd if library support is added. A supplementary patch for that already exists. https://www.postgresql.org/message-id/ynqwd2gsmrnqw...@paquier.xyz There's also some in-progress patches: - Konstantin and Daniil have a patch to add libpq

Re: refactoring basebackup.c (zstd)

2022-02-15 Thread Justin Pryzby
+++ b/configure @@ -801,6 +805,7 @@ infodir docdir oldincludedir includedir +runstatedir There's superfluous changes to ./configure unrelated to the changes in configure.ac. Probably because you're using a different version of autotools, or a vendor's patched copy. You can remove the

Re: Time to increase hash_mem_multiplier default?

2022-02-15 Thread Justin Pryzby
On Mon, Feb 14, 2022 at 10:32:43PM -0800, Peter Geoghegan wrote: > On Wed, Jan 19, 2022 at 11:32 AM John Naylor > wrote: > > I don't have anything really profound to say here, but in the last > > year I did on a couple occasions recommend clients to raise > > hash_mem_multiplier to 2.0 to fix

Re: Postgres 14.2 Windows can't rename temporary statistics file

2022-02-14 Thread Justin Pryzby
On Mon, Feb 14, 2022 at 09:19:54PM -0300, Ranier Vilela wrote: > I've reported this issue, but without success in fixing it. It'd be helpful to provide a link to the prior discussions, and summarize it. https://wiki.postgresql.org/wiki/PostgreSQL_14_Open_Items

Re: Adding CI to our tree

2022-02-13 Thread Justin Pryzby
On Sat, Feb 12, 2022 at 02:26:25PM -0800, Andres Freund wrote: > On 2022-02-12 16:06:40 -0600, Justin Pryzby wrote: > > I had some success with that, but it doesn't seem to be significantly > > faster - > > it looks a lot like the tests are not actually running in parallel.

Re: Adding CI to our tree

2022-02-13 Thread Justin Pryzby
On Sun, Feb 13, 2022 at 01:23:16PM -0800, Andres Freund wrote: > If you're seeing this on windows on one of your test branches, that's much > more likely to be caused by the alltaptests stuff, than by the change in > artifact instruction. Oh - I suppose you're right. That's an unfortunate

Re: Adding CI to our tree

2022-02-13 Thread Justin Pryzby
On Sat, Feb 12, 2022 at 04:24:20PM -0800, Andres Freund wrote: > > What I am excited about is that some of your other changes showed that we > > don't need separate *_artifacts for separate directories anymore. That used > > to > > be the case, but an array of paths is now supported. Putting log,

Re: Adding CI to our tree

2022-02-12 Thread Justin Pryzby
On Sat, Feb 12, 2022 at 05:20:08PM -0800, Andres Freund wrote: > On 2022-02-03 23:04:04 -0600, Justin Pryzby wrote: > > > I'm a bit worried about the increased storage and runtime overhead due to > > > the > > > docs changes. We probably can make it a good bit cheap

Re: Adding CI to our tree

2022-02-12 Thread Justin Pryzby
On Sat, Feb 12, 2022 at 04:24:20PM -0800, Andres Freund wrote: > > > e5286ede1b4 cirrus: avoid unnecessary double star ** > > > > Can't get excited about this, but whatever. > > > > What I am excited about is that some of your other changes showed that we > > don't need separate *_artifacts for

Re: [Proposal] Fully WAL logged CREATE DATABASE - No Checkpoints

2022-02-12 Thread Justin Pryzby
On Sat, Feb 12, 2022 at 06:00:44PM -0800, Andres Freund wrote: > Hi, > > On 2022-02-11 16:19:12 -0500, Robert Haas wrote: > > I somewhat hope we never end up with THREE strategies for creating a new > > database, but now that I think about it, we might. Somebody might want to > > use a fancy FS

Re: Adding CI to our tree

2022-02-12 Thread Justin Pryzby
On Tue, Jan 18, 2022 at 05:16:26PM -0800, Andres Freund wrote: > On 2022-01-18 15:08:47 -0600, Justin Pryzby wrote: > > On Mon, Jan 17, 2022 at 12:16:19PM -0800, Andres Freund wrote: > > > I think it might still be worth adding stopgap way of running all tap > > > te

buildfarm warnings

2022-02-12 Thread Justin Pryzby
Is there any check for warnings from new code, other than those buildfarm members with -Werror ? It'd be better to avoid warnings, allowing members to use -Werror, rather than to allow/ignore warnings, which preclude that possibility. A circular problem. I checked for warnings on master during

Re: refactoring basebackup.c

2022-02-12 Thread Justin Pryzby
The LZ4 patches caused new compiler warnings. It's the same issue that was fixed at 71ce8 for gzip. I think they would've been visible in the CI environment, too. https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=wrasse=2022-02-12%2005%3A08%3A48=make

Re: support for MERGE

2022-02-11 Thread Justin Pryzby
On Fri, Feb 11, 2022 at 05:25:49PM -0300, Alvaro Herrera wrote: > > I'm not sure git diff --cherry-pick is widely known/used, but I think > > using that relative to master may be good enough. > > I had never heard of git diff --cherry-pick, and the manpages I found > don't document it, so

Re: support for MERGE

2022-02-11 Thread Justin Pryzby
On Fri, Feb 11, 2022 at 03:21:43PM -0300, Alvaro Herrera wrote: > On 2022-Jan-28, Justin Pryzby wrote: > > Have you looked at code coverage ? I have an experimental patch to add > > that to > > cirrus, and ran it with this patch; visible here: > > https://cirrus-c

Re: pgsql: Add TAP test to automate the equivalent of check_guc

2022-02-11 Thread Justin Pryzby
On Fri, Feb 11, 2022 at 10:41:27AM -0500, Tom Lane wrote: > Justin Pryzby writes: > > On Fri, Feb 11, 2022 at 09:59:55AM -0500, Tom Lane wrote: > >> This seems like a pretty bad idea even if it weren't failing outright. > >> We should be examining the version of th

Re: pgsql: Add TAP test to automate the equivalent of check_guc

2022-02-11 Thread Justin Pryzby
On Fri, Feb 11, 2022 at 09:59:55AM -0500, Tom Lane wrote: > Christoph Berg writes: > > this test is failing at Debian package compile time: > > Could not open /usr/share/postgresql/15/postgresql.conf.sample: No such > > file or directory at t/003_check_guc.pl line 47. > > > So it's trying to

Re: refactoring basebackup.c

2022-02-11 Thread Justin Pryzby
On Fri, Feb 11, 2022 at 08:35:25PM +0530, Jeevan Ladhe wrote: > Thanks Robert for the bravity :-) FYI: there's a couple typos in the last 2 patches. I added them to my typos branch; feel free to wait until April if you'd prefer to see them fixed in bulk. diff --git

Re: can we add subscription TAP test option "vcregress subscriptioncheck" for MSVC builds?

2022-02-10 Thread Justin Pryzby
On Thu, Feb 10, 2022 at 10:21:08PM +0530, Bharath Rupireddy wrote: > Thanks for the comments. Above looks good to me, changed that way, PSA v2. I spy a typo: subcription -- Justin

Re: warn if GUC set to an invalid shared library

2022-02-09 Thread Justin Pryzby
/src/test/regress/sql/rules.sql @@ -1198,6 +1198,7 @@ drop table hat_data; -- test for pg_get_functiondef properly regurgitating SET parameters -- Note that the function is kept around to stress pg_dump. +SET check_function_bodies=no; CREATE FUNCTION func_with_set_params() RETU

Re: wrong fds used for refilenodes after pg_upgrade relfilenode changes Reply-To:

2022-02-09 Thread Justin Pryzby
On Wed, Feb 09, 2022 at 02:00:04PM -0800, Andres Freund wrote: > On linux we can do so by a) checking if readlink(/proc/self/fd/$fd) points to > a filename ending in " (deleted)", b) doing fstat(fd) and checking if st_nlink > == 0. You could also stat() the file in proc/self/fd/N and compare

Re: is the base backup protocol used by out-of-core tools?

2022-02-08 Thread Justin Pryzby
On Tue, Feb 08, 2022 at 11:26:41AM -0500, Robert Haas wrote: > Patches for the nuking are attached. If nobody writes back, I'm going > to assume that means nobody cares, and commit these some time before > feature freeze. If one or more people do write back, then my plan is > to see what they have

Re: GUC flags

2022-02-07 Thread Justin Pryzby
On Tue, Feb 08, 2022 at 10:44:07AM +0900, Michael Paquier wrote: > What do you think about the updated version attached? I have applied > the addition of config_data() separately. Looks fine > + # Check if this line matches a GUC parameter. > + if ($line =~ m/^#?([_[:alpha:]]+) (= .*|[^

Re: 2022-02-10 release announcement draft

2022-02-06 Thread Justin Pryzby
On Sun, Feb 06, 2022 at 08:01:02PM -0500, Jonathan S. Katz wrote: > Hi, > > Attached is a draft for the release announcement for the 2022-02-10 > cumulative update release. > > Please review for technical accuracy or if you believe any items should be > added/removed. Please provide feedback no

Re: GUC flags

2022-02-06 Thread Justin Pryzby
Thanks for working on it. Your test is checking that stuff in sample.conf is actually a GUC and not marked NOT_IN_SAMPLE. But those are both unlikely mistakes to make. The important/interesting test is the opposite: that all GUCs are present in the sample file. It's a lot easier for someone to

Re: Release notes for February minor releases

2022-02-06 Thread Justin Pryzby
On Sun, Feb 06, 2022 at 02:22:25PM -0500, Jonathan S. Katz wrote: > I'm working on the release announcement and have been following this thread. > > Are there steps we can provide to help a user detect that this occurred, > even though it's a low-probability? It's the same question as raised

Re: Release notes for February minor releases

2022-02-04 Thread Justin Pryzby
On Fri, Feb 04, 2022 at 04:29:19PM -0500, Tom Lane wrote: > > + A previous bug fix disabled building of extended statistics for > > + old-style inheritance trees, but any existing statistics data was > > + not removed, and that data would become more and more out-of-date > > +

Re: Release notes for February minor releases

2022-02-04 Thread Justin Pryzby
Build extended statistics for partitioned tables (Justin Pryzby) + + + A previous bug fix disabled building of extended statistics for + old-style inheritance trees, but it also prevented building them for + partitioned tables, which was an unnecessary restriction. + If y

Re: Adding CI to our tree

2022-02-03 Thread Justin Pryzby
On Thu, Feb 03, 2022 at 11:57:18AM -0800, Andres Freund wrote: > On 2022-02-02 21:58:28 -0600, Justin Pryzby wrote: > > FYI: I've rebased these against your cirrus/windows changes. > > Did you put then on a dedicated branch, or only intermixed with other changes? Yes it's interm

Re: do only critical work during single-user vacuum?

2022-02-03 Thread Justin Pryzby
On Thu, Feb 03, 2022 at 07:26:01PM -0800, Andres Freund wrote: > Which reminds me: Perhaps we ought to hint about reducing / removing > autovacuum cost limits in this situation? And perhaps make autovacuum absorb > config changes while running? It's annoying that an autovac halfway into a > huge

Re: do only critical work during single-user vacuum?

2022-02-03 Thread Justin Pryzby
On Tue, Feb 01, 2022 at 04:50:31PM -0500, John Naylor wrote: > On Thu, Jan 27, 2022 at 8:28 PM Justin Pryzby wrote: > > > I'm sure you meant "&" here (fixed in attached patch to appease the cfbot): > > + if (options | VACOPT_MINIMAL) > > Tha

Re: Adding CI to our tree

2022-02-02 Thread Justin Pryzby
On Tue, Jan 18, 2022 at 03:08:47PM -0600, Justin Pryzby wrote: > On Mon, Jan 17, 2022 at 12:16:19PM -0800, Andres Freund wrote: > > I think it might still be worth adding stopgap way of running all tap tests > > on > > windows though. Having a vcregress.pl function to

Re: Condition pushdown: why (=) is pushed down into join, but BETWEEN or >= is not?

2022-02-01 Thread Justin Pryzby
> Subject: [PATCH v1 1/6] Rebaee David's patch against the latest code. If you use git-am, then the author/commit information is preserved. It's probably good to include a link to the patch in any case. > Subject: [PATCH v1 4/6] remove duplicated qual executing.

Re: GUC flags

2022-01-31 Thread Justin Pryzby
On Mon, Jan 31, 2022 at 02:17:41PM +0900, Michael Paquier wrote: > With all those doc fixes, applied after an extra round of review. So > this makes us rather covered with the checks on the flags. Thanks > Now, what do we do with the rest of check_guc that involve a direct > lookup at what's on

Re: pg_walinspect - a new extension to get raw WAL data and WAL stats

2022-01-31 Thread Justin Pryzby
is was simpler. https://www.postgresql.org/message-id/20210622031358.gf29...@telsasoft.com On Mon, Jun 21, 2021 at 10:13:58PM -0500, Justin Pryzby wrote: > +/* compression methods supported */ > +#define BKPIMAGE_COMPRESS_PGLZ 0x04 > +#define BKPIMAGE_COMPRESS_ZLIB 0x08 > +#define BKPI

Re: Why is INSERT-driven autovacuuming based on pg_class.reltuples?

2022-01-30 Thread Justin Pryzby
On Thu, Jan 27, 2022 at 01:59:38PM -0800, Peter Geoghegan wrote: > On Thu, Jan 27, 2022 at 12:20 PM Peter Geoghegan wrote: > > Both VACUUM and ANALYZE update pg_class.reltuples. But this code seems > > to assume that it's only something that VACUUM can ever do. Why > > wouldn't we expect a plain

Re: GUC flags

2022-01-29 Thread Justin Pryzby
On Sat, Jan 29, 2022 at 03:38:53PM +0900, Michael Paquier wrote: > +-- Three exceptions as of transaction_* > +SELECT name FROM pg_settings_flags > + WHERE NOT no_show_all AND no_reset_all > + ORDER BY 1; > + name > + > + transaction_deferrable > +

Re: warn if GUC set to an invalid shared library

2022-01-28 Thread Justin Pryzby
Thanks for loooking On Fri, Jan 28, 2022 at 11:36:20PM +, Cary Huang wrote: > This is fine as this is what these patches are aiming to provide. However, > when I try to restart the server, it fails to start because abc.so and xyz.so > do not exist. Setting the parameters

Re: support for MERGE

2022-01-28 Thread Justin Pryzby
On Fri, Jan 28, 2022 at 05:27:37PM -0300, Alvaro Herrera wrote: > The one thing I'm a bit bothered about is the fact > that we expose a lot of executor functions previously static. I am now > wondering if it would be better to move the MERGE executor support > functions into nodeModifyTable.c,

Re: GUC flags

2022-01-27 Thread Justin Pryzby
On Wed, Jan 26, 2022 at 03:29:29PM +0900, Michael Paquier wrote: > On Tue, Jan 25, 2022 at 09:44:26PM -0600, Justin Pryzby wrote: > > It seems like an arbitrary and short-sighted policy to expose a handful of > > flags in the view for the purpose of retiring ./check_guc, but not ex

Re: do only critical work during single-user vacuum?

2022-01-27 Thread Justin Pryzby
On Fri, Jan 21, 2022 at 05:41:58PM -0500, John Naylor wrote: > On Wed, Jan 19, 2022 at 5:26 PM Michael Paquier wrote: > > > > Could you avoid introducing a new grammar pattern in VACUUM? Any new > > option had better be within the parenthesized part as it is extensible > > at will with its set

Re: warn if GUC set to an invalid shared library

2022-01-27 Thread Justin Pryzby
On Sun, Jan 09, 2022 at 11:58:18AM -0800, Maciek Sakrejda wrote: > On Sat, Jan 8, 2022 at 2:07 PM Justin Pryzby wrote: > > Unfortunately, the output for dlopen() is not portable, which (I think) > > means > > most of what I wrote can't be made to work.. Since it doesn't wo

Re: Write visibility map during CLUSTER/VACUUM FULL

2022-01-27 Thread Justin Pryzby
On Sun, Dec 26, 2021 at 08:59:31PM -0600, Justin Pryzby wrote: > Rebased on 8e1fae193864527c931a704bd7908e4fbc983f5c. > > Would someone step up to "own" this patch ? > > If not, its CF entry may need to be closed (there's no status for "needs > author").

Re: Output clause for Upsert aka INSERT...ON CONFLICT

2022-01-26 Thread Justin Pryzby
On Thu, Jan 27, 2022 at 10:24:14AM +0530, Anand Sowmithiran wrote: > The INSERT...ON CONFLICT is used for doing upserts in one of our app. > Our app works with both MS SQL and Postgresql, based on customer needs. > > Unlike the MS SQL MERGE command's OUTPUT clause that gives the $action >

Re: GUC flags

2022-01-25 Thread Justin Pryzby
On Wed, Jan 26, 2022 at 09:54:43AM +0900, Michael Paquier wrote: > On Tue, Jan 25, 2022 at 12:07:51PM -0600, Justin Pryzby wrote: > > On Tue, Jan 25, 2022 at 11:47:14AM +0100, Peter Eisentraut wrote: > >> Does this stuff have any value for users? I'm worried we are exposing a &

Re: pg_ls_tmpdir to show directories and shared filesets (and pg_ls_*)

2022-01-25 Thread Justin Pryzby
id|pg_logical/replorigin_checkpoint)$') and filename!~'[0-9]' +order by path collate "C", filename collate "C"; + path |filename | type ++-+-- + PG_VERSION | PG_VERSION | - + base

Re: GUC flags

2022-01-25 Thread Justin Pryzby
On Tue, Jan 25, 2022 at 11:47:14AM +0100, Peter Eisentraut wrote: > On 25.01.22 02:07, Justin Pryzby wrote: > > +CREATE TABLE pg_settings_flags AS SELECT name, category, > > + 'NO_SHOW_ALL' =ANY(flags) AS no_show_all, > > + 'NO_RESET_ALL' =ANY(flags) AS no_reset_all, &

Re: pg_upgrade should truncate/remove its logs before running

2022-01-25 Thread Justin Pryzby
On Mon, Jan 24, 2022 at 10:59:40AM +0900, Michael Paquier wrote: > On Thu, Jan 20, 2022 at 07:51:37PM +0900, Michael Paquier wrote: > > Neat idea. That would work fine for my case. So I am fine to stick > > with this suggestion. > > I have been looking at this idea, and the result is quite

Re: GUC flags

2022-01-24 Thread Justin Pryzby
On Wed, Jan 05, 2022 at 11:36:41PM -0600, Justin Pryzby wrote: > On Thu, Jan 06, 2022 at 02:19:08PM +0900, Michael Paquier wrote: > > > + initStringInfo(); > > > + appendStringInfoChar(, '{'); > > > + > > > + if (flags & GUC_NO_SHOW_ALL) >

explain_regress, explain(MACHINE), and default to explain(BUFFERS) (was: BUFFERS enabled by default in EXPLAIN (ANALYZE))

2022-01-24 Thread Justin Pryzby
I'm renaming this thread for better visibility, since buffers is a small, optional part of the patches I sent. I made a CF entry here. https://commitfest.postgresql.org/36/3409/ On Wed, Dec 01, 2021 at 06:58:20PM -0600, Justin Pryzby wrote: > On Mon, Nov 15, 2021 at 01:09:54PM -0600, Jus

Re: pg_upgrade should truncate/remove its logs before running

2022-01-24 Thread Justin Pryzby
On Mon, Jan 24, 2022 at 12:39:30PM -0500, Bruce Momjian wrote: > On Mon, Jan 24, 2022 at 10:59:40AM +0900, Michael Paquier wrote: > > On Thu, Jan 20, 2022 at 07:51:37PM +0900, Michael Paquier wrote: > > > Neat idea. That would work fine for my case. So I am fine to stick > > > with this

Re: typos

2022-01-23 Thread Justin Pryzby
On Mon, Jan 24, 2022 at 04:01:47PM +0900, Michael Paquier wrote: > On Sun, Jan 23, 2022 at 09:00:01PM -0600, Justin Pryzby wrote: > > Feel free to ignore this for now and revisit in April... > > I don't mind fixing that now. That means less to do later. Thanks. > > @Micha

Re: [PATCH] Implement INSERT SET syntax

2022-01-23 Thread Justin Pryzby
Hi, On Fri, Jan 21, 2022 at 05:24:51PM +0800, wenjing zeng wrote: > Since this feature adds INSERT OVERRIDING SET syntax, it is recommended to > add some related testcases. Thanks for proposing some more tests. Note that your patch caused Gareth's patches to break under the cfbot.

makefiles writing to $@ should first write to $@.new

2022-01-23 Thread Justin Pryzby
There are many Makefile rules like foo: bar ./tool $< > $@ If the rule is interrupted (due to ^C or ENOSPC), foo can be 0 bytes or partially written, but won't be rebuilt until someone runs distclean or debugs it and removes the individual file, as I did for errcodes.h. It'd be better

typos

2022-01-23 Thread Justin Pryzby
+8,8 @@ * Portions Copyright (c) 1996-2022, PostgreSQL Global Development Group * Portions Copyright (c) 1994, Regents of the University of California * + * IDENTIFICATION + * src/port/pgcheckdir.c *--------- */ -- 2.17

pg_upgrade/test.sh and v9.5

2022-01-22 Thread Justin Pryzby
ns TO 'Default';" "postgres" pg_regress was changed to do that recently: commit f45dc59a38cab1d2af6baaedb79559fe2e9b3781 Author: Tom Lane Date: Wed Oct 20 18:44:37 2021 -0400 Improve pg_regress.c's infrastructure for issuing psql commands. -- Justin &g

Re: document the need to analyze partitioned tables

2022-01-21 Thread Justin Pryzby
Thanks for looking at this On Fri, Jan 21, 2022 at 06:21:57PM +0100, Tomas Vondra wrote: > Hi, > > On 10/8/21 14:58, Justin Pryzby wrote: > > Cleaned up and attached as a .patch. > > > > The patch implementing autoanalyze on partitioned tables should > > rever

Re: Poor performance PostgreSQL13/PostGIS 3.x

2022-01-20 Thread Justin Pryzby
On Thu, Jan 20, 2022 at 10:31:15PM +, Lugosi, Jim wrote: > We are struggling to figure out what is going on. We are migrating from > PostgreSQL 9.6 to PostgreSQL 13 w/ PostGIS. Our 9.6 version was compiled > from source and the new version (13) was installed using Yum. BTW, the new >

Re: pg_upgrade should truncate/remove its logs before running

2022-01-19 Thread Justin Pryzby
On Thu, Jan 20, 2022 at 12:01:29PM +0900, Michael Paquier wrote: > On Wed, Jan 19, 2022 at 06:05:40PM -0600, Justin Pryzby wrote: > > > I'm not sure these restrictions are needed ? > > This could lead to issues with rmtree() if we are not careful enough, > no? We'd had

Re: pg_upgrade should truncate/remove its logs before running

2022-01-19 Thread Justin Pryzby
On Wed, Jan 19, 2022 at 05:13:18PM +0900, Michael Paquier wrote: > On Tue, Jan 11, 2022 at 10:08:13PM -0600, Justin Pryzby wrote: > > I asked about that before. Right now, it'll exit(1) when mkdir fails. > > > > I had written a patch to allow "." by skipping mkd

Re: Adding CI to our tree

2022-01-18 Thread Justin Pryzby
On Mon, Jan 17, 2022 at 12:16:19PM -0800, Andres Freund wrote: > I think it might still be worth adding stopgap way of running all tap tests on > windows though. Having a vcregress.pl function to find all directories with t/ > and run the tests there, shouldn't be a lot of code... I started doing

Re: libpq compression (part 2)

2022-01-17 Thread Justin Pryzby
On Tue, Jan 18, 2022 at 02:06:32AM +0500, Daniil Zakhlystov wrote: > > => Since March, errmsg doesn't need extra parenthesis around it (e3a87b4). > I’ve resolved the stuck tests and added zlib support for CI Windows builds to > patch 0003-*. Thanks > for the suggestion, all tests seem to be OK

Re: \d with triggers: more than one row returned by a subquery used as an expression

2022-01-17 Thread Justin Pryzby
On Mon, Jan 17, 2022 at 05:02:00PM -0500, Tom Lane wrote: > Justin Pryzby writes: > > On Fri, Dec 17, 2021 at 09:43:56AM -0600, Justin Pryzby wrote: > >> I want to mention that the 2nd problem I mentioned here is still broken. > >> https://www.postgresql.org/mes

Re: Avoiding smgrimmedsync() during nbtree index builds

2022-01-17 Thread Justin Pryzby
On Sun, Jan 16, 2022 at 02:25:59PM -0600, Justin Pryzby wrote: > On Thu, Jan 13, 2022 at 09:52:55AM -0600, Justin Pryzby wrote: > > This is failing on windows CI when I use initdb --data-checksums, as > > attached. > > > > https://cirrus-ci.com/task/5612464120266752 &g

Re: Map WAL segment files on PMEM as WAL buffers

2022-01-16 Thread Justin Pryzby
On Thu, Jan 06, 2022 at 10:43:37PM -0600, Justin Pryzby wrote: > On Fri, Jan 07, 2022 at 12:50:01PM +0900, Takashi Menjo wrote: > > > But in this case it really doesn't work :( > > > > > > running bootstrap script ... 2022-01-05 23:17:30.244 CST [12088] FATAL:

Re: pg_dump/restore --no-tableam

2022-01-16 Thread Justin Pryzby
On Mon, Jan 17, 2022 at 02:55:58PM +0900, Michael Paquier wrote: > On Tue, Jan 11, 2022 at 10:09:07PM -0600, Justin Pryzby wrote: > > I suppose you're right - I had previously renamed it from no-tableam. > > Thanks for the new version. I have noticed that support for the > opti

Re: Avoiding smgrimmedsync() during nbtree index builds

2022-01-16 Thread Justin Pryzby
On Thu, Jan 13, 2022 at 09:52:55AM -0600, Justin Pryzby wrote: > This is failing on windows CI when I use initdb --data-checksums, as attached. > > https://cirrus-ci.com/task/5612464120266752 > https://api.cirrus-ci.com/v1/artifact/task/5612464120266752/regress_diffs/src/

Re: [PATCH] Full support for index LP_DEAD hint bits on standby

2022-01-15 Thread Justin Pryzby
On Sat, Jan 15, 2022 at 08:39:14PM +0300, Michail Nikolaev wrote: > Hello, Junien. > > Thanks for your attention. > > > The cfbot reports that this patch is currently failing at least on > > Linux and Windows, e.g. https://cirrus-ci.com/task/6532060239101952. > > Fixed. It was the issue with

Re: MultiXact/SLRU buffers configuration

2022-01-15 Thread Justin Pryzby
On Sat, Jan 15, 2022 at 12:16:59PM +0500, Andrey Borodin wrote: > > 15 янв. 2022 г., в 03:20, Shawn Debnath написал(а): > > On Fri, Jan 14, 2022 at 05:28:38PM +0800, Julien Rouhaud wrote: > >>> PFA rebase of the patchset. Also I've added a patch to combine > >>> page_number, page_status, and

Re: Add 64-bit XIDs into PostgreSQL 15

2022-01-14 Thread Justin Pryzby
I tried to pg_upgrade from a v13 instance like: time make check -C src/bin/pg_upgrade oldsrc=`pwd`/13 oldbindir=`pwd`/13/tmp_install/usr/local/pgsql/bin I had compiled and installed v13 into `pwd`/13. First, test.sh failed, because of an option in initdb which doesn't exist in the old version:

Re: extended stats on partitioned tables

2022-01-14 Thread Justin Pryzby
On Mon, Dec 13, 2021 at 09:40:09PM +0100, Tomas Vondra wrote: > 1) If the table is a separate relation (not part of an inheritance > tree), this should make no difference. -> OK > > 2) If the table is using "old" inheritance, this reverts back to > pre-regression behavior. So people will keep

Re: Adding CI to our tree

2022-01-14 Thread Justin Pryzby
On Fri, Jan 14, 2022 at 03:34:11PM -0800, Andres Freund wrote: > Hi, > > On 2022-01-13 15:27:40 -0500, Andrew Dunstan wrote: > > I can probably adjust to whatever we decide to do. But I think we're > > really just tinkering at the edges here. What I think we really need is > > the moral

Re: [PATCH] psql: \dn+ to show size of each schema (and \dA+ for AMs)

2022-01-14 Thread Justin Pryzby
Rebased before Julian asks. >From cf57143c85a2a6088fe6038e6d41771fd60aae34 Mon Sep 17 00:00:00 2001 From: Justin Pryzby Date: Tue, 13 Jul 2021 21:25:48 -0500 Subject: [PATCH 1/4] Add pg_am_size(), pg_namespace_size() .. See also: 358a897fa, 528ac10c7 --- src/backend/utils/adt/dbsize.c |

Re: support for MERGE

2022-01-14 Thread Justin Pryzby
Resending some language fixes to the public documentation. >From 28b8532976ddb3e8b617ca007fae6b4822b36527 Mon Sep 17 00:00:00 2001 From: Justin Pryzby Date: Sat, 13 Nov 2021 12:11:46 -0600 Subject: [PATCH] f!typos --- doc/src/sgml/mvcc.sgml | 8 ++--- doc/src/sgml/

Re: libpq compression (part 2)

2022-01-13 Thread Justin Pryzby
has a couple "noise" hunks that get rid of ^M characters added in previous patches. The ^M shouldn't be added in the first place. Did you apply my fixes using git-am or something else ? On Fri, Jan 14, 2022 at 02:12:17AM +0500, Daniil Zakhlystov wrote: > > On 12 Jan 2022, at

<    5   6   7   8   9   10   11   12   13   14   >