threshold, but it's also OK for it to wait until a vacuum
of the table or until some activity consumes an xid.
--
Kevin Grittner
VMware vCenter Server
https://www.vmware.com/
.
(2) The behavior is correct if the index creation is skipped or if
enable_indexscan is turned off in the transaction, confirming Andres'
analysis.
(3) Pruning seems to happen as intended; the bug found by Peter seems to be
entirely about failing to TestForOldSnapshot() where needed.
--
Kevin G
ows always be removed as soon as possible after
the threshold is crossed as long as they don't often linger too awfully far
past that limit and allow debilitating bloat.
(2) It _is_ a problem if results inconsistent with the snapshot are
returned -- a "snapshot too old" err
se rates become common.
I am reviewing the issue and patches now, and hope I can make some useful
contribution to the discussion.
--
Kevin Grittner
VMware vCenter Server
https://www.vmware.com/
> https://postgr.es/m/20180427222842.in2e4mibx45zdth5%40alap3.anarazel.de
> is, I think, a good overview, with a bunch of links.
Thanks! Will review.
--
Kevin Grittner
VMware vCenter Server
https://www.vmware.com/
r
> (possibly indefinitely), but that's really a separate problem"
>
> And that's entirely possibly in postgres.
Is it possible for an inode to be evicted while there is an open FD
referencing it?
> The commit was dicussed on list too, btw...
Can you point to a post expl
layer POV. Why isn't this declared in snapmgr.h or a new header file?
I will take a look.
--
Kevin Grittner
VMware vCenter Server
https://www.vmware.com/
On Tue, Jan 22, 2019 at 8:27 AM Kevin Grittner wrote:
> With the help of VMware's Dirk Hohndel (VMware's Chief Open Source
> Officer, a VP position near the top of the organization, and a
> personal friend of Linus), I have been fortunate enough to make
> contact directly
4.13, but that isn't actually maintained any
> more, and I don't think any distro uses it (distros tend to use the
> long-term stable kernels that are maintained, or sometimes maintain
> their own patch queue).
I think that eliminates the need for this patch.
--
Kevin Grittner
VMware vCenter Server
https://www.vmware.com/
ues with using those techniques with set-oriented statements for
the transition table approach?
--
Kevin Grittner
VMware vCenter Server
https://www.vmware.com/
d_fkey"
DETAIL: Key (t1id)=(4) is not present in table "t1".
All inserts occur before the statement fails, per standard.
Kevin Grittner
VMware vCenter Server
https://www.vmware.com/
e considered a resounding success. We should
probably add an alternative result file to cover this case, but
otherwise I don't see anything which requires action.
Congratulations on making this work so well!
--
Kevin Grittner
VMware vCenter Server
https://www.vmware.com/
about it at all. If we do see some failures, we can take
another look to see whether any action is needed.
--
Kevin Grittner
VMware vCenter Server
https://www.vmware.com/
ary for a serialization anomaly to be seen.
--
Kevin Grittner
VMware vCenter Server
https://www.vmware.com/
great if someone with a big test machine could stress test
and benchmark this versus current production versions.
--
Kevin Grittner
VMware vCenter Server
https://www.vmware.com/
On Fri, Sep 21, 2018 at 7:29 AM Thomas Munro
wrote:
> I'll add it to the next Commitfest so I know when to rebase it.
I signed up as reviewer in that CF.
--
Kevin Grittner
VMware vCenter Server
https://www.vmware.com/
sm would be especially beneficial.
Will take care of it.
--
Kevin Grittner
VMware vCenter Server
https://www.vmware.com/
> +/*
> + * If the transaction is committing, but it has been partially released
> + * already, then treat this as a roll back. It was marked as rolled
> back.
> + */
> +if (isCommit && SxactIsPartiallyReleased(MySerializableXact))
> +isCommit = false;
> +
>
> Isn't it better to add an assertion to check if
> MySerializableXact->flags has SXACT_FLAG_ROLLED_BACK flag for safety?
>
> [1] https://en.wikipedia.org/wiki/Snapshot_isolation#Definition
>
> Regards,
>
> --
> Masahiko Sawada
> NIPPON TELEGRAPH AND TELEPHONE CORPORATION
> NTT Open Source Software Center
--
Kevin Grittner
VMware vCenter Server
https://www.vmware.com/
d to
understand. Our score was 32.2.
Perhaps in next year's review we could try to ease this a little.
In the meantime, I was very happy to see the so many new faces at
PostgresOpen SV 2018; maybe it's just a happy coincidence, but if this
effort had anything to do with drawing in more people, it was well
worth the effort!
Kevin Grittner
--
Kevin Grittner
VMware vCenter Server
https://www.vmware.com/
19 matches
Mail list logo
