RE: add \dpS to psq [16beta1]

2023-06-28 Thread Shinoda, Noriyoshi (PN Japan FSIP)
Hi, Thank you for developing a good feature. I found while testing PostgreSQL 16 Beta 1 that the output of the \? metacommand did not include \dS, \dpS. The attached patch changes the output of the \? meta command to: Current output psql=# \? \z [PATTERN] same as \dp \dp

RE: [16Beta1][doc] pgstat: Track time of the last scan of a relation

2023-06-05 Thread Shinoda, Noriyoshi (PN Japan FSIP)
Hi, David. > I've now pushed this change. Thank you so much. -Original Message- From: David Rowley Sent: Monday, June 5, 2023 2:37 PM To: Shinoda, Noriyoshi (PN Japan FSIP) Cc: PostgreSQL-development ; dp...@pgadmin.org; and...@anarazel.de; br...@momjian.us; v...@postgresfriends.

RE: [16Beta1][doc] pgstat: Track time of the last scan of a relation

2023-06-01 Thread Shinoda, Noriyoshi (PN Japan FSIP)
- From: David Rowley Sent: Wednesday, May 31, 2023 3:14 PM To: Shinoda, Noriyoshi (PN Japan FSIP) Cc: PostgreSQL-development ; dp...@pgadmin.org; and...@anarazel.de; br...@momjian.us; v...@postgresfriends.org Subject: Re: [16Beta1][doc] pgstat: Track time of the last scan of a relation On W

[16Beta1][doc] pgstat: Track time of the last scan of a relation

2023-05-30 Thread Shinoda, Noriyoshi (PN Japan FSIP)
Hi, hackers. PostgreSQL 16 Beta1, added last access time to pg_stat_all_tables and pg_stat_all_indexes views by this patch [1]. According to the documentation [2], the data type of the columns added to these views is 'timestamptz'. However, columns of the same data type in

[16Beta1][doc] Add BackendType for standalone backends

2023-05-28 Thread Shinoda, Noriyoshi (PN Japan FSIP)
Hi, hackers. In PostgreSQL 16 Beta 1, standalone backend was added to the backend type by this patch [1]. I think this patch will change the value of backend_type column in the pg_stat_activity view, but it's not explained in the documentation. The attached patch fixes monitoring.sgml. [1] Add

RE: running logical replication as the subscription owner

2023-04-10 Thread Shinoda, Noriyoshi (PN Japan FSIP)
Hi hackers, Thank you for developing a great feature. The following commit added a column to the pg_subscription catalog. https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=482675987bcdffb390ae735cfd5f34b485ae97c6

RE: run pgindent on a regular basis / scripted manner

2023-02-08 Thread Shinoda, Noriyoshi (PN Japan FSIP)
Hi, I tried the committed pgindent. The attached small patch changes spaces in the usage message to tabs. Options other than --commit start with a tab. Regards, Noriyoshi Shinoda From: Andrew Dunstan Sent: Thursday, February 9, 2023 7:10 AM To: Jelte Fennema Cc: Robert Haas ; Tom Lane ; Justin

RE: Perform streaming logical transactions by background workers and parallel apply

2023-01-09 Thread Shinoda, Noriyoshi (PN Japan FSIP)
Regards, Noriyoshi Shinoda -Original Message- From: houzj.f...@fujitsu.com Sent: Monday, January 9, 2023 7:15 PM To: Shinoda, Noriyoshi (PN Japan FSIP) ; Amit Kapila Cc: Masahiko Sawada ; wangw.f...@fujitsu.com; Peter Smith ; shiy.f...@fujitsu.com; PostgreSQL Hackers ; Dilip Kumar Su

RE: Perform streaming logical transactions by background workers and parallel apply

2023-01-09 Thread Shinoda, Noriyoshi (PN Japan FSIP)
Hi, Thanks for the great new feature. Applied patches include adding wait events LogicalParallelApplyMain, LogicalParallelApplyStateChange. However, it seems that monitoring.sgml only contains descriptions for pg_locks. The attached patch adds relevant wait event information. Please update if

RE: pg_upgrade: Make testing different transfer modes easier

2022-12-18 Thread Shinoda, Noriyoshi (PN Japan FSIP)
Hi, With the addition of --copy option, pg_upgrade now has three possible transfer mode options. Currently, an error does not occur even if multiple transfer modes are specified. For example, we can also run "pg_upgrade --link --copy --clone" command. As discussed in Horiguchi-san's previous

RE: Improve logging when using Huge Pages

2022-11-04 Thread Shinoda, Noriyoshi (PN Japan FSIP)
behavior as huge_pages=try in PostgreSQL. Regards, Noriyoshi Shinoda -Original Message- From: Thomas Munro Sent: Thursday, November 3, 2022 10:10 AM To: Shinoda, Noriyoshi (PN Japan FSIP) Cc: Jacob Champion ; Masahiko Sawada ; Fujii Masao ; Justin Pryzby ; PostgreSQL-development

[PG15 Doc] remove "tty" connect string from manual

2022-08-15 Thread Shinoda, Noriyoshi (PN Japan FSIP)
Hello, hackers. As of PostgreSQL 14, "tty" in the libpq connection string has already been removed with the commit below. https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=14d9b37607ad30c3848ea0f2955a78436eff1268 But

RE: Improve logging when using Huge Pages

2022-08-03 Thread Shinoda, Noriyoshi (PN Japan FSIP)
oposed this time and consider it again. Regards, Noriyoshi Shinoda -Original Message- From: Jacob Champion Sent: Tuesday, August 2, 2022 5:45 AM To: Shinoda, Noriyoshi (PN Japan FSIP) ; Masahiko Sawada ; Fujii Masao Cc: Justin Pryzby ; PostgreSQL-development ; Julien Rouhaud ; To

RE: Add --{no-,}bypassrls flags to createuser

2022-07-13 Thread Shinoda, Noriyoshi (PN Japan FSIP)
Hi, Thanks to the developers and reviewers. The attached small patch fixes the message in "createuser --help" command. The patch has changed to specify a time stamp for the --valid-for option. I don't think the SGML description needs to be modified. Regards, Noriyoshi Shinoda -Original

RE: PG15 beta1 fix pg_stats_ext/pg_stats_ext_exprs view manual

2022-06-26 Thread Shinoda, Noriyoshi (PN Japan FSIP)
Thanks for your comment. sorry for the late reply. I hope it will be fixed during the period of PostgreSQL 15 Beta. Regards, Noriyoshi Shinoda -Original Message- From: Justin Pryzby Sent: Tuesday, June 14, 2022 11:30 PM To: Shinoda, Noriyoshi (PN Japan FSIP) Cc: pgsql-hack

PG15 beta1 fix pg_stats_ext/pg_stats_ext_exprs view manual

2022-05-24 Thread Shinoda, Noriyoshi (PN Japan FSIP)
Hi hackers, Thanks to all the developers. The attached patch updates the manual for the pg_stats_ext and pg_stats_ext_exprs view. The current pg_stats_ext/pg_stats_ext_exprs view manual are missing the inherited column. This column was added at the same time as the stxdinherit column in the

PG15 beta1 fix pg_database view document

2022-05-22 Thread Shinoda, Noriyoshi (PN Japan FSIP)
Hi hackers, Thanks to all the developers. The attached patch updates the manual for the pg_database catalog. The current pg_database view definition is missing the datlocprovider column. The attached patch adds this column info. https://www.postgresql.org/docs/15/catalog-pg-database.html

PG15 beta1 fix pg_stat_recovery_prefetch view manual

2022-05-20 Thread Shinoda, Noriyoshi (PN Japan FSIP)
Hi hackers, Thanks to all the developers. The attached patch updates the manual for the pg_stat_recovery_prefetch view. The current pg_stat_recovery_prefetch view definition is missing the stats_reset column. The attached patch adds information in the stats_reset column.

RE: PG15 beta1 fix pg_stat_statements view document

2022-05-20 Thread Shinoda, Noriyoshi (PN Japan FSIP)
Hi, Thank you for your comment. I attached the fixed patch. -Original Message- From: Michael Paquier Sent: Saturday, May 21, 2022 12:33 PM To: Nathan Bossart Cc: Shinoda, Noriyoshi (PN Japan FSIP) ; PostgreSQL-development ; mag...@hagander.net Subject: Re: PG15 beta1 fix

PG15 beta1 fix pg_stat_statements view document

2022-05-20 Thread Shinoda, Noriyoshi (PN Japan FSIP)
Hi hackers, The attached patch modifies the pg_stat_statements view documentation updated in PostgreSQL 15 Beta 1. The data type of the following columns in the pg_stat_statements view is bigint in the current document, but it is actually double precision. jit_generation_time

RE: Documentation issue with pg_stat_recovery_prefetch

2022-04-20 Thread Shinoda, Noriyoshi (PN Japan FSIP)
Hi, Thank you for developing the new feature. The pg_stat_recovery_prefetch view documentation doesn't seem to have a description of the stats_reset column. The attached small patch adds a description of the stats_reset column. Regards, Noriyoshi Shinoda -Original Message- From:

RE: WIP: WAL prefetch (another approach)

2022-04-12 Thread Shinoda, Noriyoshi (PN Japan FSIP)
Hi, Thank you for your reply. I missed the message, sorry. Regards, Noriyoshi Shinoda -Original Message- From: Thomas Munro Sent: Tuesday, April 12, 2022 6:28 PM To: Shinoda, Noriyoshi (PN Japan FSIP) Cc: Justin Pryzby ; Tomas Vondra ; Stephen Frost ; Andres Freund ; Jakub Wartak

RE: WIP: WAL prefetch (another approach)

2022-04-12 Thread Shinoda, Noriyoshi (PN Japan FSIP)
Hi, Thank you for developing the great feature. I tested this feature and checked the documentation. Currently, the documentation for the pg_stat_prefetch_recovery view is included in the description for the pg_stat_subscription view.

RE: Expose JIT counters/timing in pg_stat_statements

2022-04-08 Thread Shinoda, Noriyoshi (PN Japan FSIP)
Hi, thank you for the great features. The attached small patch changes the data type in the document. The following columns are actually double precision but bigint in the docs. jit_generation_time jit_inlining_time jit_optimization_time jit_emission_count Regards, Noriyoshi Shinoda From:

RE: Column Filtering in Logical Replication

2022-03-25 Thread Shinoda, Noriyoshi (PN Japan FSIP)
Hello, The 'prattrs' column has been added to the pg_publication_rel catalog, but the current commit to catalog.sgml seems to have added it to pg_publication_namespace. The attached patch fixes this. Regards, Noriyoshi Shinoda -Original Message- From: Tomas Vondra Sent: Saturday,

RE: ICU for global collation

2022-03-17 Thread Shinoda, Noriyoshi (PN Japan FSIP)
Hi, Thank you to all the developers. I found that the description of the pg_database.daticulocale column was not written in the documentation. The attached small patch adds a description of the daticulocale column to catalogs.sgml. Regards, Noriyoshi Shinoda -Original Message- From:

RE: row filtering for logical replication

2022-02-23 Thread Shinoda, Noriyoshi (PN Japan FSIP)
> You can give it for multiple tables. See below as an example: Thank you very much. I understood. Regards, Noriyoshi Shinoda -Original Message- From: Amit Kapila Sent: Thursday, February 24, 2022 11:25 AM To: Shinoda, Noriyoshi (PN Japan FSIP) Cc: Euler Taveira ; houz

RE: row filtering for logical replication

2022-02-23 Thread Shinoda, Noriyoshi (PN Japan FSIP)
Hi, Thank you for developing of the great feature. If multiple tables are specified when creating a PUBLICATION, is it supposed that the WHERE clause condition is given to only one table? I attached the operation log below. --- operation log --- postgres=> CREATE TABLE data1(c1 INT PRIMARY

RE: refactoring basebackup.c

2022-02-11 Thread Shinoda, Noriyoshi (PN Japan FSIP)
Hi, Hackers. Thank you for developing a great feature. The current help message shown below does not seem to be able to specify the 'client-' or 'server-' for lz4 compression. --compress = {[{client, server}-]gzip, lz4, none}[:LEVEL] The attached small patch fixes the help message as follows:

RE: refactoring basebackup.c

2022-01-24 Thread Shinoda, Noriyoshi (PN Japan FSIP)
Hi, Thank you for committing a great feature. I have tested the committed features. The attached small patch fixes the output of the --help message. In the previous commit, only gzip and none were output, but in the attached patch, client-gzip and server-gzip are added. Regards, Noriyoshi

RE: Improve logging when using Huge Pages

2021-11-21 Thread Shinoda, Noriyoshi (PN Japan FSIP)
this specification. Regards, Noriyoshi Shinoda -Original Message- From: Masahiko Sawada [mailto:sawada.m...@gmail.com] Sent: Thursday, November 11, 2021 2:45 PM To: Fujii Masao Cc: Justin Pryzby ; Shinoda, Noriyoshi (PN Japan FSIP) ; PostgreSQL-development ; Julien Rouhaud ; Tom Lane

RE: Improve logging when using Huge Pages

2021-11-08 Thread Shinoda, Noriyoshi (PN Japan FSIP)
...@oss.nttdata.com] Sent: Tuesday, November 2, 2021 11:35 PM To: Shinoda, Noriyoshi (PN Japan FSIP) ; pgsql-hack...@postgresql.org; Masahiko Sawada Cc: rjuju...@gmail.com; t...@sss.pgh.pa.us; Kyotaro Horiguchi ; Justin Pryzby Subject: Re: Improve logging when using Huge Pages On 2021/11/02

RE: Improve logging when using Huge Pages

2021-11-02 Thread Shinoda, Noriyoshi (PN Japan FSIP)
d uses IsPostmasterEnvironment to suppress the output message. Regards, Noriyoshi Shinoda -Original Message- From: Fujii Masao [mailto:masao.fu...@oss.nttdata.com] Sent: Tuesday, November 2, 2021 1:25 AM To: Masahiko Sawada ; Shinoda, Noriyoshi (PN Japan FSIP) Cc: pgsql-hack...@postgresql.org;

RE: Improve logging when using Huge Pages

2021-10-27 Thread Shinoda, Noriyoshi (PN Japan FSIP)
, October 22, 2021 11:38 AM To: Shinoda, Noriyoshi (PN Japan FSIP) Cc: masao.fu...@oss.nttdata.com; pgsql-hack...@postgresql.org; rjuju...@gmail.com; t...@sss.pgh.pa.us; Kyotaro Horiguchi Subject: Re: Improve logging when using Huge Pages + ereport(LOG, (errmsg("Anonymous s

RE: Improve logging when using Huge Pages

2021-09-27 Thread Shinoda, Noriyoshi (PN Japan FSIP)
Cc: masao.fu...@oss.nttdata.com; Shinoda, Noriyoshi (PN Japan FSIP) ; pgsql-hack...@postgresql.org; rjuju...@gmail.com; t...@sss.pgh.pa.us Subject: Re: Improve logging when using Huge Pages At Tue, 21 Sep 2021 19:23:22 -0500, Justin Pryzby wrote in > On Wed, Sep 22, 2021 at 02:03:11AM +0900,

RE: Improve logging when using Huge Pages

2021-09-20 Thread Shinoda, Noriyoshi (PN Japan FSIP)
mentation. Regards, Noriyoshi Shinoda -Original Message- From: Kyotaro Horiguchi [mailto:horikyota@gmail.com] Sent: Friday, September 17, 2021 1:15 PM To: masao.fu...@oss.nttdata.com Cc: pry...@telsasoft.com; Shinoda, Noriyoshi (PN Japan FSIP) ; pgsql-hack...@postgresql.org; rju

RE: Improve logging when using Huge Pages

2021-09-08 Thread Shinoda, Noriyoshi (PN Japan FSIP)
Regards, Noriyoshi Shinoda -Original Message- From: Kyotaro Horiguchi [mailto:horikyota@gmail.com] Sent: Wednesday, September 8, 2021 11:18 AM To: pry...@telsasoft.com Cc: masao.fu...@oss.nttdata.com; Shinoda, Noriyoshi (PN Japan FSIP) ; pgsql-hack...@postgresql.org; rjuju...@gmail.co

RE: Improve logging when using Huge Pages

2021-09-06 Thread Shinoda, Noriyoshi (PN Japan FSIP)
] https://www.postgresql.org/message-id/20210903.141206.103927759882272221.hor Regards, Noriyoshi Shinoda -Original Message- From: Fujii Masao [mailto:masao.fu...@oss.nttdata.com] Sent: Saturday, September 4, 2021 1:36 AM To: Tom Lane Cc: Kyotaro Horiguchi ; Shinoda, Noriyoshi (PN Japan FSIP

RE: New predefined roles- 'pg_read/write_all_data'

2021-09-05 Thread Shinoda, Noriyoshi (PN Japan FSIP)
Thank you for your quick response. I understood the specifications from your explanation. Regards, Noriyoshi Shinoda From: Stephen Frost [mailto:sfr...@snowman.net] Sent: Sunday, September 5, 2021 8:50 PM To: Shinoda, Noriyoshi (PN Japan FSIP) Cc: Anastasia Lubennikova ; Michael Banck

RE: New predefined roles- 'pg_read/write_all_data'

2021-09-05 Thread Shinoda, Noriyoshi (PN Japan FSIP)
Hi hackers, I have tested this new feature with PostgreSQL 14 Beta 3 environment. I created a user granted with pg_write_all_data role and executed UPDATE and DELETE statements on tables owned by other users. If there is no WHERE clause, it can be executed as expected, but if the WHERE clause

RE: Improve logging when using Huge Pages

2021-09-03 Thread Shinoda, Noriyoshi (PN Japan FSIP)
ards, Noriyoshi Shinoda -Original Message- From: Fujii Masao [mailto:masao.fu...@oss.nttdata.com] Sent: Wednesday, September 1, 2021 2:06 AM To: Julien Rouhaud ; Shinoda, Noriyoshi (PN Japan FSIP) Cc: pgsql-hack...@postgresql.org Subject: Re: Improve logging when using Huge Pages On 2

Improve logging when using Huge Pages

2021-08-30 Thread Shinoda, Noriyoshi (PN Japan FSIP)
Hi Hackers, In the current version, when GUC huge_pages=try, which is the default setting, no log is output regardless of the success or failure of the HugePages acquisition. If you want to output logs, you need to set log_min_messages=DEBUG3, but it will output a huge amount of extra logs.

RE: WIP: WAL prefetch (another approach)

2021-04-12 Thread Shinoda, Noriyoshi (PN Japan FSIP)
Hi, Thank you for developing a great feature. I tested this feature and checked the documentation. Currently, the documentation for the pg_stat_prefetch_recovery view is included in the description for the pg_stat_subscription view.

RE: list of extended statistics on psql

2021-01-16 Thread Shinoda, Noriyoshi (PN Japan FSIP)
Hi, hackers. I tested this committed feature. It doesn't seem to be available to non-superusers due to the inability to access pg_statistics_ext_data. Is this the expected behavior? --- operation --- postgres=> CREATE STATISTICS stat1_data1 ON c1, c2 FROM data1; CREATE STATISTICS postgres=>

RE: pgsql: Add key management system

2020-12-26 Thread Shinoda, Noriyoshi (PN Japan FSIP)
Hi, Thank you for developing a great feature. I tested it immediately. The attached patch changes the value of the --file-encryption-keylen option of the initdb command to mandatory. No value is currently required. I also changed the help message and the manual. Regards, Noriyoshi Shinoda