Re: [PATCH] Simplify permission checking logic in user.c

2020-12-30 Thread Stephen Frost
Greetings, * Paul Martinez (paul...@google.com) wrote: > This small patch simply modifies the code to replace the if/else-if chain with > separate if statements, and always checks whether the user has the CREATEROLE > privilege. (The have_createrole_privilege function includes another superuser >

Re: pg_ls_tmpdir to show directories and shared filesets (and pg_ls_*)

2020-12-23 Thread Stephen Frost
umns." > > On Mon, Nov 23, 2020 at 06:06:19PM -0500, Tom Lane wrote: > > I'm mostly concerned about removing the isdir output of pg_stat_file(). > > Maybe we could compromise to the extent of keeping that, allowing it > > to be partially duplicative of a file-type-c

Re: BUG #16079: Question Regarding the BUG #16064

2020-12-21 Thread Stephen Frost
Greetings, * Magnus Hagander (mag...@hagander.net) wrote: > On Mon, Dec 21, 2020 at 8:06 PM Stephen Frost wrote: > > * Magnus Hagander (mag...@hagander.net) wrote: > > > On Mon, Dec 21, 2020 at 7:44 PM Tom Lane wrote: > > > > BTW, do we have a client-side setting t

Re: BUG #16079: Question Regarding the BUG #16064

2020-12-21 Thread Stephen Frost
Greetings, * Magnus Hagander (mag...@hagander.net) wrote: > On Mon, Dec 21, 2020 at 7:44 PM Tom Lane wrote: > > BTW, do we have a client-side setting to insist that passwords not be > > sent in MD5 hashing either? A person who is paranoid about this would > > likely want to disable that code pat

Re: BUG #16079: Question Regarding the BUG #16064

2020-12-21 Thread Stephen Frost
Greetings, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Stephen Frost writes: > > * Tom Lane (t...@sss.pgh.pa.us) wrote: > >> Jeff Janes writes: > >>> I would suggest going further. I would make the change on the client > >>> side, > >>> an

Re: BUG #16079: Question Regarding the BUG #16064

2020-12-21 Thread Stephen Frost
Greetings, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Jeff Janes writes: > > On Sun, Dec 20, 2020 at 7:58 PM Stephen Frost wrote: > >> * Magnus Hagander (mag...@hagander.net) wrote: > >>> Maybe we should do the same for LDAP (and RADIUS)? This seems like a > >&

Re: Proposed patch for key managment

2020-12-20 Thread Stephen Frost
Greetings, * Alastair Turner (min...@decodable.me) wrote: > On Mon, 21 Dec 2020 at 00:33, Stephen Frost wrote: > > * Alastair Turner (min...@decodable.me) wrote: > > > What I'd like specifically is to have the option of an external > > > keyring as a first class

Re: Proposed patch for key managment

2020-12-20 Thread Stephen Frost
Greetings, * Alastair Turner (min...@decodable.me) wrote: > On Sun, 20 Dec 2020 at 22:59, Stephen Frost wrote: > > Yes, it's true that after things are implemented it can be more > > difficult to change them- but if you're concerned about the specific > > on-

Re: Proposed patch for key managment

2020-12-20 Thread Stephen Frost
Greetings Alastair, * Alastair Turner (min...@decodable.me) wrote: > On Sat, 19 Dec 2020 at 16:58, Bruce Momjian wrote: > > To enable the direct injection of keys into the server, we would need a > > new command for this, since trying to make the passphrase command do > > this will lead to unnece

Re: Proposed patch for key managment

2020-12-18 Thread Stephen Frost
Greetings Alastair, * Alastair Turner (min...@decodable.me) wrote: > On Wed, 16 Dec 2020 at 22:43, Stephen Frost wrote: > > If I'm following, you're suggesting something like: > > > > cluster_passphrase_command = 'aws get %q' > > > > and the

Re: Refactor routine to check for ASCII-only case

2020-12-18 Thread Stephen Frost
Greetings, * Heikki Linnakangas (hlinn...@iki.fi) wrote: > On 18/12/2020 05:57, Michael Paquier wrote: > >As mentioned in [1], there are three places where there is the same > >routine to check if a string is made only of ASCII characters. > > > >This makes for a small-ish but nice cleanup, as per

Re: Proposed patch for key managment

2020-12-18 Thread Stephen Frost
Greetings, * Bruce Momjian (br...@momjian.us) wrote: > On Fri, Dec 18, 2020 at 08:18:53AM -0500, Stephen Frost wrote: > > - C API in backend - we should try to at least set up the structure to > > allow multiple encryption implementations, either via different > > li

Re: Proposed patch for key managment

2020-12-18 Thread Stephen Frost
Greetings, * Bruce Momjian (br...@momjian.us) wrote: > On Fri, Dec 18, 2020 at 10:01:22AM +0900, Michael Paquier wrote: > > On Thu, Dec 17, 2020 at 12:10:22PM -0500, Bruce Momjian wrote: > > > On Thu, Dec 17, 2020 at 11:39:55AM -0500, Stephen Frost wrote: > > >> I do

Re: Proposed patch for key managment

2020-12-18 Thread Stephen Frost
Greetings, * Michael Paquier (mich...@paquier.xyz) wrote: > On Thu, Dec 17, 2020 at 12:10:22PM -0500, Bruce Momjian wrote: > > Agreed. I think there is serious risk we would do AES in a different > > way than OpenSSL, especially if I did it. ;-) We can add a native AES > > one day if we want, b

Re: Proposed patch for key managment

2020-12-17 Thread Stephen Frost
Greetings, * Michael Paquier (mich...@paquier.xyz) wrote: > On Wed, Dec 16, 2020 at 05:04:12PM -0500, Bruce Momjian wrote: > >> fallback implementation. Finally, pgcrypto is not touched, but we > > > > I have a fallback implemention --- it fails? ;-) Did you want me to > > include an AES imple

Re: Proposed patch for key managment

2020-12-16 Thread Stephen Frost
Greetings, * Alastair Turner (min...@decodable.me) wrote: > On Wed, 16 Dec 2020 at 21:32, Stephen Frost wrote: > > * Alastair Turner (min...@decodable.me) wrote: > > > On Wed, 16 Dec 2020 at 00:12, Bruce Momjian wrote: > > > > The second approach is to ma

Re: Proposed patch for key managment

2020-12-16 Thread Stephen Frost
Greetings, * Alastair Turner (min...@decodable.me) wrote: > On Wed, 16 Dec 2020 at 00:12, Bruce Momjian wrote: > > The second approach is to make a new API for what you want > > I am trying to motivate for an alternate API. Specifically, an API > which allows any potential adopter of Postgre

Re: Proposed patch for key managment

2020-12-16 Thread Stephen Frost
Greetings, * Michael Paquier (mich...@paquier.xyz) wrote: > On Tue, Dec 15, 2020 at 02:09:09PM -0500, Stephen Frost wrote: > > Yeah, looking at what's been done there seems like the right approach to > > me as well, ideally we'd have one set of APIs that'll suppor

Re: Proposed patch for key managment

2020-12-15 Thread Stephen Frost
Greetings, * Bruce Momjian (br...@momjian.us) wrote: > On Tue, Dec 15, 2020 at 10:05:49AM +0900, Michael Paquier wrote: > > On Mon, Dec 14, 2020 at 06:06:15PM -0500, Bruce Momjian wrote: > > > I am getting close to applying these patches, probably this week. The > > > patches are cumulative: > >

Re: Autovacuum worker doesn't immediately exit on postmaster death

2020-12-10 Thread Stephen Frost
Greetings, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Alvaro Herrera writes: > > On 2020-Oct-29, Stephen Frost wrote: > >> I do think it'd be good to find a way to check every once in a while > >> even when we aren't going to delay though. Not sure what the be

Re: Change default of checkpoint_completion_target

2020-12-10 Thread Stephen Frost
Greetings, * Alvaro Herrera (alvhe...@alvh.no-ip.org) wrote: > On 2020-Dec-10, Stephen Frost wrote: > > * Laurenz Albe (laurenz.a...@cybertec.at) wrote: > > > On Tue, 2020-12-08 at 17:29 +, Bossart, Nathan wrote: > > > > +1 to setting checkpoint_compl

Re: Change default of checkpoint_completion_target

2020-12-10 Thread Stephen Frost
Greetings, * Laurenz Albe (laurenz.a...@cybertec.at) wrote: > On Tue, 2020-12-08 at 17:29 +, Bossart, Nathan wrote: > > +1 to setting checkpoint_completion_target to 0.9 by default. > > +1 for changing the default or getting rid of it, as Tom suggested. Attached is a patch to change it from

Re: Proposed patch for key managment

2020-12-09 Thread Stephen Frost
Greetings, * Daniel Gustafsson (dan...@yesql.se) wrote: > > On 2 Dec 2020, at 22:38, Bruce Momjian wrote: > > Attached is a patch for key management, which will eventually be part of > > cluster file encryption (CFE), called TDE (Transparent Data Encryption) > > by Oracle. > > The attackvector p

Re: Change default of checkpoint_completion_target

2020-12-07 Thread Stephen Frost
Greetings, * Peter Eisentraut (peter.eisentr...@enterprisedb.com) wrote: > On 2020-12-07 18:53, Stephen Frost wrote: > >* Michael Paquier (mich...@paquier.xyz) wrote: > >>On Sun, Dec 06, 2020 at 10:03:08AM -0500, Stephen Frost wrote: > >>>* Alvaro Herrera (

Change default of checkpoint_completion_target

2020-12-07 Thread Stephen Frost
Greetings, * Michael Paquier (mich...@paquier.xyz) wrote: > On Sun, Dec 06, 2020 at 10:03:08AM -0500, Stephen Frost wrote: > > * Alvaro Herrera (alvhe...@alvh.no-ip.org) wrote: > >> You keep making this statement, and I don't necessarily disagree, but if > >> that

Re: A few new options for CHECKPOINT

2020-12-06 Thread Stephen Frost
Greetings, * Alvaro Herrera (alvhe...@alvh.no-ip.org) wrote: > On 2020-Dec-05, Stephen Frost wrote: > > So- just to be clear, CHECKPOINTs are more-or-less always happening in > > PG, and running this command might do something or might end up doing > > nothing depending

Re: A few new options for CHECKPOINT

2020-12-05 Thread Stephen Frost
Greetings, * Bossart, Nathan (bossa...@amazon.com) wrote: > On 12/5/20, 6:41 AM, "Stephen Frost" wrote: > > Assuming we actually want to do this, which I still generally don't > > agree with since it isn't really clear if it'll actually end up doing >

Re: automatic analyze: readahead - add "IO read time" log message

2020-12-05 Thread Stephen Frost
Greetings, * Tomas Vondra (tomas.von...@enterprisedb.com) wrote: > Thanks. I'll do some testing/benchmarking once my machines are free, in > a couple days perhaps. But as I said before, I don't expect this to > behave very differently from other places that already do prefetching. Agreed, but wou

Re: A few new options for CHECKPOINT

2020-12-05 Thread Stephen Frost
Greetings, * Bossart, Nathan (bossa...@amazon.com) wrote: > This all seems reasonable to me. I've attached a new version of the > patch. diff --git a/doc/src/sgml/ref/checkpoint.sgml b/doc/src/sgml/ref/checkpoint.sgml index 2afee6d7b5..2b1e56fbd7 100644 --- a/doc/src/sgml/ref/checkpoint.sgml +++

Re: A few new options for CHECKPOINT

2020-12-04 Thread Stephen Frost
Greetings, * Alvaro Herrera (alvhe...@alvh.no-ip.org) wrote: > I think starting a spread checkpoint has some usefulness, if your > checkpoint interval is very large but your completion target is not very > close to 1. In that case, you're expressing that you want a checkpoint > to start now and n

Re: Add docs stub for recovery.conf

2020-12-04 Thread Stephen Frost
Greetings, * David G. Johnston (david.g.johns...@gmail.com) wrote: > On Fri, Dec 4, 2020 at 12:00 PM Stephen Frost wrote: > > Obviously, I'd then have to adjust the patch that I proposed for default > > roles, or move forward with it as-is, depending on what we end up doing

Re: WIP: WAL prefetch (another approach)

2020-12-04 Thread Stephen Frost
Greetings, * Andres Freund (and...@anarazel.de) wrote: > On 2020-12-04 13:27:38 -0500, Stephen Frost wrote: > > If I follow correctly, this patch will scan ahead in the WAL and let > > the kernel know that certain blocks will be needed soon. Ideally, > > though I don'

Re: Add docs stub for recovery.conf

2020-12-04 Thread Stephen Frost
Greetings, * Bruce Momjian (br...@momjian.us) wrote: > On Wed, Dec 2, 2020 at 08:07:47PM -0500, Isaac Morland wrote: > > On Wed, 2 Dec 2020 at 19:33, David G. Johnston > > wrote: > > > > On Wed, Dec 2, 2020 at 5:26 PM Bruce Momjian wrote: > > > > I think the ideal solution is to c

Re: WIP: WAL prefetch (another approach)

2020-12-04 Thread Stephen Frost
Greetings, * Thomas Munro (thomas.mu...@gmail.com) wrote: > On Thu, Nov 19, 2020 at 10:00 AM Stephen Frost wrote: > > * Thomas Munro (thomas.mu...@gmail.com) wrote: > > > Hmm. Every time I try to think of a protocol change for the > > > restore_command API that would

Re: Add docs stub for recovery.conf

2020-12-02 Thread Stephen Frost
Greetings, * Bruce Momjian (br...@momjian.us) wrote: > On Wed, Dec 2, 2020 at 02:47:13PM -0500, Stephen Frost wrote: > > * David G. Johnston (david.g.johns...@gmail.com) wrote: > > > On Mon, Nov 30, 2020 at 11:42 AM Bruce Momjian wrote: > > > > The downside is you

Re: Add docs stub for recovery.conf

2020-12-02 Thread Stephen Frost
Greetings, * David G. Johnston (david.g.johns...@gmail.com) wrote: > On Mon, Nov 30, 2020 at 11:42 AM Bruce Momjian wrote: > > The downside is you end up with X-1 dummy sections just to allow for > > references to old syntax, and you then have to find them all and remove > > them when you impleme

Re: Log message for GSS connection is missing once connection authorization is successful.

2020-12-02 Thread Stephen Frost
Greetings, * Stephen Frost (sfr...@snowman.net) wrote: > * vignesh C (vignes...@gmail.com) wrote: > > Thanks for testing this, I had missed testing this. The expression > > matching was not correct. Attached v6 patch which includes the fix for > > this. > > This genera

Re: SELECT INTO deprecation

2020-12-02 Thread Stephen Frost
Greetings, * Peter Eisentraut (peter.eisentr...@enterprisedb.com) wrote: > While reading about deprecating and removing various things in other > threads, I was wondering about how deprecated SELECT INTO is. There are > various source code comments about this, but the SELECT INTO reference page >

Re: Online verification of checksums

2020-11-30 Thread Stephen Frost
Greetings, * Michael Paquier (mich...@paquier.xyz) wrote: > On Fri, Nov 27, 2020 at 11:15:27AM -0500, Stephen Frost wrote: > > * Magnus Hagander (mag...@hagander.net) wrote: > >> On Thu, Nov 26, 2020 at 8:42 AM Michael Paquier > >> wrote: > >>> But he

Re: A few new options for CHECKPOINT

2020-11-29 Thread Stephen Frost
Greetings, * Bossart, Nathan (bossa...@amazon.com) wrote: > On 11/28/20, 9:50 AM, "Stephen Frost" wrote: > >> Granted, I used a rather aggressive checkpoint_timeout, but I think > >> this demonstrates that waiting for a non-immediate checkpoint to > >> com

Re: Add docs stub for recovery.conf

2020-11-29 Thread Stephen Frost
Greetings, * Craig Ringer (craig.rin...@enterprisedb.com) wrote: > On Sat, Nov 14, 2020 at 1:42 AM Bruce Momjian wrote: > > Clearly we have need for documenting these renamings somewhere. We were > > going to go with a simple URL redirect and a "tip" for > > default/pre-installed roles, but I lik

Re: A few new options for CHECKPOINT

2020-11-28 Thread Stephen Frost
Greetings, * Bossart, Nathan (bossa...@amazon.com) wrote: > On 11/27/20, 10:58 AM, "Stephen Frost" wrote: > > If you'd like to show that I'm wrong, and it's entirely possible that I > > am, then retry the above with actual load on the system, and also &

Re: Log message for GSS connection is missing once connection authorization is successful.

2020-11-27 Thread Stephen Frost
sh it. Thanks, Stephen From f78100d1c7401d4d47e6ee58f1baaac5b21b1216 Mon Sep 17 00:00:00 2001 From: Stephen Frost Date: Fri, 27 Nov 2020 16:52:44 -0500 Subject: [PATCH] Add GSS information to connection authorized log message GSS information (if used) such as if the connection was authorized using GSS or if it

Re: A few new options for CHECKPOINT

2020-11-27 Thread Stephen Frost
Greetings, * Bossart, Nathan (bossa...@amazon.com) wrote: > On 11/27/20, 8:29 AM, "Stephen Frost" wrote: > > Also note that, in all other cases (that is, when there *is* outstanding > > WAL since the last checkpoint), pg_start_backup actually just waits for >

Re: proposal: possibility to read dumped table's name from file

2020-11-27 Thread Stephen Frost
Greetings, * Pavel Stehule (pavel.steh...@gmail.com) wrote: > > I agree that being able to configure pg_dump via a config file would > > be very useful, but the syntax proposed here feels much more like a > > hacked-up syntax designed to meet this one use case, rather than a > > good general-purpo

Re: proposal: possibility to read dumped table's name from file

2020-11-27 Thread Stephen Frost
Greetings, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Dean Rasheed writes: > > Actually, that raises a different possible benefit of passing options > > in an options file -- if the user wants to pass in a table name > > pattern, it can be a nuisance if the shell's argument processing does > > addi

Re: A few new options for CHECKPOINT

2020-11-27 Thread Stephen Frost
Greetings, * Bossart, Nathan (bossa...@amazon.com) wrote: > Thanks to all for the feedback. I've attached v2 of the patch. I've > removed the WAIT and FORCE options and renamed IMMEDIATE to FAST. > > On 11/25/20, 7:52 AM, "Stephen Frost" wrote: > > I&#x

Re: Online verification of checksums

2020-11-27 Thread Stephen Frost
Greetings, * Magnus Hagander (mag...@hagander.net) wrote: > On Thu, Nov 26, 2020 at 8:42 AM Michael Paquier wrote: > > On Tue, Nov 24, 2020 at 12:38:30PM -0500, David Steele wrote: > > > We are not just looking at one LSN value. Here are the steps we are > > > proposing (I'll skip checks for zero

Re: A few new options for CHECKPOINT

2020-11-25 Thread Stephen Frost
Greetings, * Bossart, Nathan (bossa...@amazon.com) wrote: > On 11/24/20, 4:03 PM, "tsunakawa.ta...@fujitsu.com" > wrote: > > From: Bossart, Nathan > >> The main purpose of this patch is to give users more control over their > >> manually > >> requested checkpoints or restartpoints. I suspect

Re: pg_ls_tmpdir to show directories and shared filesets (and pg_ls_*)

2020-11-24 Thread Stephen Frost
Greetings, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Stephen Frost writes: > > * Tom Lane (t...@sss.pgh.pa.us) wrote: > >> I took a quick look through this. This is just MHO, of course: > >> > >> * I don't think it's okay to change the existing sig

Re: Online verification of checksums

2020-11-23 Thread Stephen Frost
Greetings, On Mon, Nov 23, 2020 at 20:28 Michael Paquier wrote: > On Mon, Nov 23, 2020 at 05:28:52PM -0500, Stephen Frost wrote: > > * Anastasia Lubennikova (a.lubennik...@postgrespro.ru) wrote: > >> Yes and this is a tricky part. Until you have explained it in your > l

Re: pg_ls_tmpdir to show directories and shared filesets (and pg_ls_*)

2020-11-23 Thread Stephen Frost
Greetings, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Justin Pryzby writes: > >> This patch has been waiting for input from a committer on the approach I've > >> taken with the patches since March 10, so I'm planning to set to "Ready" - > >> at > >> least ready for senior review. > > I took a qui

Re: New default role- 'pg_read_all_data'

2020-11-23 Thread Stephen Frost
Greetings, * Anastasia Lubennikova (a.lubennik...@postgrespro.ru) wrote: > On 29.10.2020 17:19, Stephen Frost wrote: > >* Georgios Kokolatos (gkokola...@protonmail.com) wrote: > >>this patch is in "Ready for committer" state and the Cfbot is happy. > >Glad th

Re: Online verification of checksums

2020-11-23 Thread Stephen Frost
Greetings, * Anastasia Lubennikova (a.lubennik...@postgrespro.ru) wrote: > On 23.11.2020 18:35, Stephen Frost wrote: > >* Anastasia Lubennikova (a.lubennik...@postgrespro.ru) wrote: > >>On 21.11.2020 04:30, Michael Paquier wrote: > >>>The only method I can think as

Re: Online verification of checksums

2020-11-23 Thread Stephen Frost
Greetings, * Anastasia Lubennikova (a.lubennik...@postgrespro.ru) wrote: > On 21.11.2020 04:30, Michael Paquier wrote: > >The only method I can think as being really > >reliable is based on two facts: > >- Do a check only on pd_checksums, as that validates the full contents > >of the page. > >- Wh

Re: Online verification of checksums

2020-11-23 Thread Stephen Frost
Greetings, * Michael Paquier (mich...@paquier.xyz) wrote: > On Fri, Nov 20, 2020 at 11:08:27AM -0500, Stephen Frost wrote: > > David Steele (da...@pgmasters.net) wrote: > >> Our current plan for pgBackRest: > >> > >> 1) Remove the LSN check as you have do

Default role -> Predefined role

2020-11-20 Thread Stephen Frost
Greetings, Attached is a patch to move from 'default role' terminology to 'predefined role' in the documentation. In the code, I figured it made more sense to avoid saying either one and instead opted for just 'ROLE_NAME_OF_ROLE' as the #define, which we were very close to (one removing the 'DEFA

Re: Online verification of checksums

2020-11-20 Thread Stephen Frost
Greetings, * David Steele (da...@pgmasters.net) wrote: > On 11/20/20 2:28 AM, Michael Paquier wrote: > >On Mon, Nov 16, 2020 at 11:41:51AM +0100, Magnus Hagander wrote: > >>I was referring to the latest patch on the thread. But as I said, I have > >>not read up on all the different issues raised i

Re: Disable WAL logging to speed up data loading

2020-11-20 Thread Stephen Frost
Greetings, * osumi.takami...@fujitsu.com (osumi.takami...@fujitsu.com) wrote: > On Friday, Nov 20, 2020 9:33 AM Tsunakawa, Takayuki > wrote: > > From: Kyotaro Horiguchi > > > At Thu, 19 Nov 2020 11:04:17 -0500, Stephen Frost > > > > * Laurenz Albe (laurenz.a..

Re: Disable WAL logging to speed up data loading

2020-11-19 Thread Stephen Frost
Greetings, * Laurenz Albe (laurenz.a...@cybertec.at) wrote: > On Thu, 2020-11-19 at 05:24 +, osumi.takami...@fujitsu.com wrote: > > > > > ereport(WARNING, > > > > > (errmsg("WAL was generated with wal_level=minimal, data may > > > > > be missing"), > > > > > errhint("This hap

Re: WIP: WAL prefetch (another approach)

2020-11-18 Thread Stephen Frost
Greetings, * Thomas Munro (thomas.mu...@gmail.com) wrote: > On Sat, Nov 14, 2020 at 4:13 AM Stephen Frost wrote: > > * Tomas Vondra (tomas.von...@enterprisedb.com) wrote: > > > On 11/13/20 3:20 AM, Thomas Munro wrote: > > > > I'm not really sure what to d

Re: proposal: possibility to read dumped table's name from file

2020-11-18 Thread Stephen Frost
Greetings, * Justin Pryzby (pry...@telsasoft.com) wrote: > On Wed, Nov 11, 2020 at 06:49:43AM +0100, Pavel Stehule wrote: > > >> Perhaps this feature could co-exist with a full blown configuration for > > >> pg_dump, but even then there's certainly issues with what's proposed- > > >> how would you

Re: WIP: WAL prefetch (another approach)

2020-11-13 Thread Stephen Frost
Greetings, * Tomas Vondra (tomas.von...@enterprisedb.com) wrote: > On 11/13/20 3:20 AM, Thomas Munro wrote: > > I'm not really sure what to do about achive restore scripts that > > block. That seems to be fundamentally incompatible with what I'm > > doing here. > > IMHO we can't do much about th

Re: [PATCH] remove deprecated v8.2 containment operators

2020-11-13 Thread Stephen Frost
Greetings, * Magnus Hagander (mag...@hagander.net) wrote: > On Thu, Nov 12, 2020 at 11:28 PM Tom Lane wrote: > > > The changes to the contrib modules appear to be incomplete in some ways. > > > In cube, hstore, and seg, there are no changes to the extension > > > scripts to remove the operators

Re: Add docs stub for recovery.conf

2020-11-12 Thread Stephen Frost
Greetings, * Stephen Frost (sfr...@snowman.net) wrote: > * Bruce Momjian (br...@momjian.us) wrote: > > On Thu, Nov 12, 2020 at 10:21:02AM +0800, Craig Ringer wrote: > > > Here's how the rendered docs look: https://imgur.com/a/VyjzEw5 > > > > > > Th

Re: Add docs stub for recovery.conf

2020-11-12 Thread Stephen Frost
Greetings, * Bruce Momjian (br...@momjian.us) wrote: > On Thu, Nov 12, 2020 at 10:21:02AM +0800, Craig Ringer wrote: > > Here's how the rendered docs look: https://imgur.com/a/VyjzEw5 > > > > Think. You're used to recovery.conf. You've recently switched to pg 12. You > > search for "recovery.conf

Re: Allow matching whole DN from a client certificate

2020-11-11 Thread Stephen Frost
Greetings, * Andrew Dunstan (and...@dunslane.net) wrote: > Currently we only match the Common Name (CN) of a client certificate > when authenticating a user. The attached patch allows matching the > entire Distinguished Name (DN) of the certificate. This is enabled by > the HBA line option "client

Re: In-place persistance change of a relation

2020-11-11 Thread Stephen Frost
Greetings, * Kyotaro Horiguchi (horikyota@gmail.com) wrote: > At Tue, 10 Nov 2020 09:33:12 -0500, Stephen Frost wrote > in > > * Kyotaro Horiguchi (horikyota@gmail.com) wrote: > > > For fuel(?) of the discussion, I tried a very-quick PoC for in-place > &g

Re: Disable WAL logging to speed up data loading

2020-11-11 Thread Stephen Frost
Greetings, * tsunakawa.ta...@fujitsu.com (tsunakawa.ta...@fujitsu.com) wrote: > * ALTER TABLE SET UNLOGGED/LOGGED without data copy > Good: > - Does not require server restart (if this feature can be used in all > wal_level settings). > > Bad: > - The user has to maintain and modify some scripts

Re: proposal: possibility to read dumped table's name from file

2020-11-10 Thread Stephen Frost
Greetings, * Pavel Stehule (pavel.steh...@gmail.com) wrote: > rebase + minor change - using pg_get_line_buf instead pg_get_line_append I started looking at this and went back through the thread and while I tend to agree that JSON may not be a good choice for this, it's not the only possible alter

Re: Disable WAL logging to speed up data loading

2020-11-10 Thread Stephen Frost
Greetings, * Kyotaro Horiguchi (horikyota@gmail.com) wrote: > For fuel(?) of the discussion, I tried a very-quick PoC for in-place > ALTER TABLE SET LOGGED/UNLOGGED and resulted as attached. After some > trials of several ways, I drifted to the following way after poking > several ways. > > 1

Re: Disable WAL logging to speed up data loading

2020-11-10 Thread Stephen Frost
Greetings, * Kyotaro Horiguchi (horikyota@gmail.com) wrote: > At Mon, 9 Nov 2020 10:18:08 -0500, Stephen Frost wrote > in > > Greetings, > > > > * osumi.takami...@fujitsu.com (osumi.takami...@fujitsu.com) wrote: > > > When I consider the use case is the

Re: Disable WAL logging to speed up data loading

2020-11-09 Thread Stephen Frost
Greetings, * David G. Johnston (david.g.johns...@gmail.com) wrote: > On Mon, Nov 9, 2020 at 10:36 AM Stephen Frost wrote: > > * David G. Johnston (david.g.johns...@gmail.com) wrote: > > > If the commit doesn't complete all of the newly created pages are junk. > >

Re: automatic analyze: readahead - add "IO read time" log message

2020-11-09 Thread Stephen Frost
Greetings, * Tomas Vondra (tomas.von...@2ndquadrant.com) wrote: > On 11/4/20 5:02 PM, Stephen Frost wrote: > >* Tomas Vondra (tomas.von...@2ndquadrant.com) wrote: > >>>If you highlight "738754560" in the output it appears to duplicate the > >>>sys

Re: Disable WAL logging to speed up data loading

2020-11-09 Thread Stephen Frost
Greetings, * David G. Johnston (david.g.johns...@gmail.com) wrote: > On Mon, Nov 9, 2020 at 8:18 AM Stephen Frost wrote: > > Presently, my feeling is that we could address this use-case without > > having to introduce a new cluster-wide WAL level, and that's the > >

Re: Reduce the time required for a database recovery from archive.

2020-11-09 Thread Stephen Frost
Greetings, * Dmitry Shulga (d.shu...@postgrespro.ru) wrote: > > On 19 Oct 2020, at 23:25, Stephen Frost wrote: > >>>> Implementation of this approach assumes running several background > >>>> processes (bgworkers) > >>>> each of wh

Re: Disable WAL logging to speed up data loading

2020-11-09 Thread Stephen Frost
Greetings, * osumi.takami...@fujitsu.com (osumi.takami...@fujitsu.com) wrote: > On Tuesday, Nov 3, 2020 3:02 AM Stephen Frost wrote: > > I'm not sure that wal_level=none is really the right way to address this > > use-case. We already have unlogged tables and that's p

Re: automatic analyze: readahead - add "IO read time" log message

2020-11-04 Thread Stephen Frost
for VACUUM in a bit. If you're doing further benchmarking of ANALYZE though, this would probably be the better patch to use. Certainly improved performance here quite a bit with effective_io_concurrency set to 16. Thanks, Stephen From b154e180718b4b57433093719a43ee6310d1da6f Mon Sep 17 00

Re: automatic analyze: readahead - add "IO read time" log message

2020-11-04 Thread Stephen Frost
Greetings, * Tomas Vondra (tomas.von...@2ndquadrant.com) wrote: > On Wed, Nov 04, 2020 at 09:07:59AM +, Jakub Wartak wrote: > >I saw up 410MB/s for a few seconds with this patch on NVMe, and that's > >huge ~5.2x improvement which is amazing for a such simple patch. Nice! > >The system and da

Re: automatic analyze: readahead - add "IO read time" log message

2020-11-03 Thread Stephen Frost
Greetings, * Jakub Wartak (jakub.war...@tomtom.com) wrote: > >Interesting that you weren't seeing any benefit to disabling readahead. > > I've got some free minutes and I have repeated the exercise in more realistic > and strict environment that previous one to conclude that the current > situat

Re: public schema default ACL

2020-11-02 Thread Stephen Frost
Greetings, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Robert Haas writes: > > On Mon, Nov 2, 2020 at 5:51 AM Peter Eisentraut > > wrote: > >> I'm not convinced, however, that this would would really move the needle > >> in terms of the general security-uneasiness about the public schema and > >> s

Re: Disable WAL logging to speed up data loading

2020-11-02 Thread Stephen Frost
Greetings, * Magnus Hagander (mag...@hagander.net) wrote: > On Mon, Nov 2, 2020 at 4:28 PM Robert Haas wrote: > > > > On Thu, Oct 29, 2020 at 4:00 PM Fujii Masao > > wrote: > > > Yes. What I meant was such a safe guard needs to be implemented. > > > > > > This may mean that if we want to recove

Re: public schema default ACL

2020-11-02 Thread Stephen Frost
Greetings, * Peter Eisentraut (peter.eisentr...@2ndquadrant.com) wrote: > On 2020-10-31 17:35, Noah Misch wrote: > >Overall, that's 3.2 votes for (b)(3)(X) and 0.0 to 1.0 votes for changing > >nothing. That suffices to proceed with (b)(3)(X). However, given the few > >votes and the conspicuous n

Re: Autovacuum worker doesn't immediately exit on postmaster death

2020-10-30 Thread Stephen Frost
Greetings, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Alvaro Herrera writes: > > On 2020-Oct-29, Stephen Frost wrote: > >> I do think it'd be good to find a way to check every once in a while > >> even when we aren't going to delay though. Not sure what the be

Re: Autovacuum worker doesn't immediately exit on postmaster death

2020-10-29 Thread Stephen Frost
Greetings, * Andres Freund (and...@anarazel.de) wrote: > On 2020-10-29 12:27:53 -0400, Tom Lane wrote: > > Maybe put a check into vacuum_delay_point, and poll the pipe when we're > > about to sleep anyway? > > Perhaps we should just replace the pg_usleep() with a latch wait? I'm not sure why, bu

Re: Autovacuum worker doesn't immediately exit on postmaster death

2020-10-29 Thread Stephen Frost
Greetings, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Victor Yegorov writes: > > ср, 28 окт. 2020 г. в 19:44, Alexander Kukushkin : > >> I know, nobody in their mind should do that, but, if the postmaster > >> process is killed with SIGKILL signal, most backend processes > >> correctly notice the f

Re: New default role- 'pg_read_all_data'

2020-10-29 Thread Stephen Frost
Greetings, * Georgios Kokolatos (gkokola...@protonmail.com) wrote: > this patch is in "Ready for committer" state and the Cfbot is happy. Glad that's still the case. :) > Is there any committer that is available for taking a look at it? If there aren't any objections or further comments, I'll t

Re: Log message for GSS connection is missing once connection authorization is successful.

2020-10-29 Thread Stephen Frost
Greetings, * vignesh C (vignes...@gmail.com) wrote: > I have made a v2 patch based on the changes you have suggested. The > patch for the same is attached. > From b067cf823750f200102be0a0cad9a26a08e29a92 Mon Sep 17 00:00:00 2001 > From: Vignesh C > Date: Wed, 28 Oct 2020 08:19:06 +0530 > Subject

Re: Internal key management system

2020-10-28 Thread Stephen Frost
Greetings, * Craig Ringer (craig.rin...@enterprisedb.com) wrote: > On Mon, Oct 26, 2020 at 11:02 PM Stephen Frost wrote: > > TL;DR: > > * Important to check that key rotation is possible on a replica, i.e. > primary and standby can have different cluster passphrase and KE

Re: Log message for GSS connection is missing once connection authorization is successful.

2020-10-28 Thread Stephen Frost
Greetings, * vignesh C (vignes...@gmail.com) wrote: > Log message for GSS connection is missing once connection > authorization is successful. We have similar log messages for SSL > connections once the connection authorization is successful. This > message will help the user to identify the conne

Re: automatic analyze: readahead - add "IO read time" log message

2020-10-27 Thread Stephen Frost
Greetings Jakub, * Jakub Wartak (jakub.war...@tomtom.com) wrote: > > The analyze is doing more-or-less random i/o since it's skipping through > > the table picking out select blocks, not doing regular sequential i/o. > VS > >> Breakpoint 1, heapam_scan_analyze_next_block (scan=0x10c8098, > >> blo

Re: automatic analyze: readahead - add "IO read time" log message

2020-10-26 Thread Stephen Frost
Greetings, * Jakub Wartak (jakub.war...@tomtom.com) wrote: > I have I hope interesting observation (and nano patch proposal) on system > where statistics freshness is a critical factor. Autovacuum/autogathering > statistics was tuned to be pretty very aggressive: > autovacuum_vacuum_cost_delay=0

Re: Internal key management system

2020-10-26 Thread Stephen Frost
Greetings, * Craig Ringer (craig.rin...@enterprisedb.com) wrote: > On Mon, Oct 19, 2020 at 11:16 AM Masahiko Sawada > wrote: > > The patch introduces only key management infrastructure but with no > > key. Currently, there is no interface to dynamically add a new > > encryption key. > > I'm a b

Re: [doc] remove reference to pg_dump pre-8.1 switch behaviour

2020-10-24 Thread Stephen Frost
Greetings, * Heikki Linnakangas (hlinn...@iki.fi) wrote: > On 23/10/2020 17:51, Tom Lane wrote: > >But anyway, this was about documentation not code. What I'm wondering > >about is when to drop things like, say, this bit in the regex docs: > > > > Two significant incompatibilities exist betwe

Re: [doc] remove reference to pg_dump pre-8.1 switch behaviour

2020-10-23 Thread Stephen Frost
Greetings, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Stephen Frost writes: > > We do need to decide at what point we're going to move forward pg_dump's > > oldest server version support. > > I'm not really in a big hurry to move it forward at all. There were

Re: [doc] remove reference to pg_dump pre-8.1 switch behaviour

2020-10-23 Thread Stephen Frost
Greetings, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Stephen Frost writes: > > Isn't this a bit pre-mature as we still support running pg_dump against > > 8.0 clusters..? > > The removed para was discussing the behavior of pg_dump itself. What > server version you

Re: [doc] remove reference to pg_dump pre-8.1 switch behaviour

2020-10-23 Thread Stephen Frost
Greetings, * Heikki Linnakangas (hlinn...@iki.fi) wrote: > On 06/10/2020 15:15, Ian Lawrence Barwick wrote: > >2020年10月6日(火) 21:13 Ian Lawrence Barwick : > >>The pg_dump doc page [1], under the -t/--table option, contains a Note > >>documenting the behavioural differences introduced in PostgreSQL

Re: Reduce the time required for a database recovery from archive.

2020-10-19 Thread Stephen Frost
Greetings, * Dmitry Shulga (d.shu...@postgrespro.ru) wrote: > > On 9 Sep 2020, at 21:26, Stephen Frost wrote: > > * Dmitry Shulga (d.shu...@postgrespro.ru) wrote: > >> Overall archive file processing is done one by one, and this might > >> create a performance bo

Re: [Patch] Using Windows groups for SSPI authentication

2020-10-16 Thread Stephen Frost
Greetings, * Russell Foster (russell.foster.cod...@gmail.com) wrote: > On Thu, Oct 15, 2020 at 11:31 AM Stephen Frost wrote: > > > Please don't top-post on these lists.. > Didn't even know what that was, had to look it up. Hopefully it is > resolved. Gmail does too

Re: [Patch] Using Windows groups for SSPI authentication

2020-10-15 Thread Stephen Frost
Greetings, * Russell Foster (russell.foster.cod...@gmail.com) wrote: > Right after I sent that I realized that sspi-group was a bad idea, not sure > if that's even a thing. Tried to cancel as it was still in moderation, but > it made it through anyways! You are right, it is very windows specific.

<    3   4   5   6   7   8   9   10   11   12   >