Re: [PATCH] Added TRANSFORM FOR for COMMENT tab completion

2021-10-07 Thread Suraj Khamkar
T", "COLLATION", "COLUMN", Apart from this I don't have any major comment. Regards, Suraj Khamkar On Thu, Oct 7, 2021 at 3:29 PM Shinya Kato wrote: > On 2021-10-07 17:14, katouknl wrote: > > Hi, > > > > Thank you for the review. > >

Re: [PATCH] Added TRANSFORM FOR for COMMENT tab completion

2021-10-06 Thread Suraj Khamkar
fix_tab_complete_comment.patch fix_tab_complete_comment.patch:38: trailing whitespace. COMPLETE_WITH_QUERY(Query_for_list_of_languages); warning: 1 line adds whitespace errors. Regards, Suraj Khamkar On Wed, Sep 29, 2021 at 2:04 PM katouknl wrote: > Hi, > > I created a patch for COMME

Re: Tab completion for CREATE SCHEMAAUTHORIZATION

2021-08-11 Thread Suraj Khamkar
tc. Thanks.. On Mon, Aug 9, 2021 at 11:30 PM Dagfinn Ilmari Mannsåker wrote: > Hi Suraj, > > Suraj Khamkar writes: > > > Hello Dagfinn, > > > > I had a look at your patch and below are my review comments. > > Please correct me if I am missing something. &

Re: Tab completion for CREATE SCHEMAAUTHORIZATION

2021-08-09 Thread Suraj Khamkar
Hello Dagfinn, I had a look at your patch and below are my review comments. Please correct me if I am missing something. 1. For me the patch does not apply cleanly. I have been facing the error of trailing whitespaces. surajkhamkar@localhost:postgres$ git apply v2-0001-Add-tab-complet