Re: A strange GiST error message or fillfactor of GiST build

2018-09-12 Thread Kyotaro HORIGUCHI
Hello. At Fri, 07 Sep 2018 16:12:29 -0400, Tom Lane wrote in <19695.1536351...@sss.pgh.pa.us> > Bruce Momjian writes: > > So, are we going to output a notice if a non-100% fill factor is > > specified? > > I would not think that's helpful. I agree. My understanding is that: It has'nt been wo

Re: A strange GiST error message or fillfactor of GiST build

2018-09-07 Thread Tom Lane
Bruce Momjian writes: > So, are we going to output a notice if a non-100% fill factor is > specified? I would not think that's helpful. regards, tom lane

Re: A strange GiST error message or fillfactor of GiST build

2018-09-07 Thread Bruce Momjian
On Thu, Sep 6, 2018 at 04:16:45PM +0900, Kyotaro HORIGUCHI wrote: > Hello. > > > Just my 2 cents: that was a hacky use case for development reasons. > > I know. So I intended to preserve the parameter with default of 100% if no > one strongly objects to preserve. Then I abandoned that since I ha

Re: A strange GiST error message or fillfactor of GiST build

2018-09-06 Thread Kyotaro HORIGUCHI
Hello. > Just my 2 cents: that was a hacky use case for development reasons. I know. So I intended to preserve the parameter with default of 100% if no one strongly objects to preserve. Then I abandoned that since I had:p > I think that removing fillfactor is good idea and your latest patch

Re: A strange GiST error message or fillfactor of GiST build

2018-09-05 Thread Andrey Borodin
> 5 сент. 2018 г., в 13:29, Kyotaro HORIGUCHI > написал(а): > > We don't preserve it for Andrey's use case. Just my 2 cents: that was a hacky use case for development reasons. I think that removing fillfactor is good idea and your latest patch looks good from my POV. Best regards, Andrey B

Re: A strange GiST error message or fillfactor of GiST build

2018-09-05 Thread Kyotaro HORIGUCHI
At Tue, 4 Sep 2018 13:05:55 +0300, Alexander Korotkov wrote in > On Tue, Sep 4, 2018 at 12:16 PM Kyotaro HORIGUCHI > wrote: > > I agree that fillfactor should be ignored in certain cases > > (inserting the first tuple into empty pages or something like > > that). Even though GiST doesn't need

Re: A strange GiST error message or fillfactor of GiST build

2018-09-04 Thread Alexander Korotkov
On Tue, Sep 4, 2018 at 12:16 PM Kyotaro HORIGUCHI wrote: > I agree that fillfactor should be ignored in certain cases > (inserting the first tuple into empty pages or something like > that). Even though GiST doesn't need fillfactor at all, it is > defined independently from AM instances What exac

Re: A strange GiST error message or fillfactor of GiST build

2018-09-04 Thread Kyotaro HORIGUCHI
At Mon, 3 Sep 2018 23:05:23 +0300, Alexander Korotkov wrote in > On Mon, Sep 3, 2018 at 9:09 PM Andrey Borodin wrote: > > > 3 сент. 2018 г., в 20:16, Alexander Korotkov > > > написал(а): > > > That's a good idea. Especially if we take into account that > > > fillfactor is not a forever bad

Re: A strange GiST error message or fillfactor of GiST build

2018-09-03 Thread Alexander Korotkov
On Mon, Sep 3, 2018 at 9:09 PM Andrey Borodin wrote: > > 3 сент. 2018 г., в 20:16, Alexander Korotkov > > написал(а): > > That's a good idea. Especially if we take into account that > > fillfactor is not a forever bad idea for GIST, it just doesn't look > > reasonable for current building algor

Re: A strange GiST error message or fillfactor of GiST build

2018-09-03 Thread Andrey Borodin
> 3 сент. 2018 г., в 20:16, Alexander Korotkov > написал(а): > > That's a good idea. Especially if we take into account that > fillfactor is not a forever bad idea for GIST, it just doesn't look > reasonable for current building algorithm. So, we can decide to > ignore it, but if we would s

Re: A strange GiST error message or fillfactor of GiST build

2018-09-03 Thread Alexander Korotkov
On Sat, Sep 1, 2018 at 9:45 PM Tom Lane wrote: > Alexander Korotkov writes: > > Thus, I would vote for removing GiST fillfactor altogether. Assuming > > we can't do this for compatibility reasons, I would vote for setting > > default GiST fillfactor to 100, and don't introduce new places where >

Re: A strange GiST error message or fillfactor of GiST build

2018-09-01 Thread Tom Lane
Alexander Korotkov writes: > Thus, I would vote for removing GiST fillfactor altogether. Assuming > we can't do this for compatibility reasons, I would vote for setting > default GiST fillfactor to 100, and don't introduce new places where > we take it into account. We probably can't remove the

Re: A strange GiST error message or fillfactor of GiST build

2018-09-01 Thread Alexander Korotkov
On Sat, Sep 1, 2018 at 6:03 PM Robert Haas wrote: > On Wed, Aug 29, 2018 at 4:32 AM, Kyotaro HORIGUCHI > wrote: > > After the attached patch applied, the above messages becomes as > > follows. (And index can be built being a bit sparse by fill > > factor.) > > > >> ERROR: index row size 8016 exc

Re: A strange GiST error message or fillfactor of GiST build

2018-09-01 Thread Robert Haas
On Wed, Aug 29, 2018 at 4:32 AM, Kyotaro HORIGUCHI wrote: > After the attached patch applied, the above messages becomes as > follows. (And index can be built being a bit sparse by fill > factor.) > >> ERROR: index row size 8016 exceeds maximum 7333 for index "y_cube_idx" > > I'm not sure why 277

Re: A strange GiST error message or fillfactor of GiST build

2018-08-30 Thread Andrey Borodin
Hello! > 30 авг. 2018 г., в 2:42, Kyotaro HORIGUCHI > написал(а): > > At Wed, 29 Aug 2018 10:42:59 -0300, Andrey Borodin > wrote in <6fbe12b2-4f59-4db9-bde9-62c880118...@yandex-team.ru> >> >> We are passing freespace everywhere. Also, we pass GistInsertState, and >> GistState. >> Maybe let'

Re: A strange GiST error message or fillfactor of GiST build

2018-08-29 Thread Kyotaro HORIGUCHI
Hello. At Wed, 29 Aug 2018 10:42:59 -0300, Andrey Borodin wrote in <6fbe12b2-4f59-4db9-bde9-62c880118...@yandex-team.ru> > >> postgres=# create table y as select cube(array(SELECT random() as a FROM > >> generate_series(1,1000))) from generate_series(1,1e3,1); > >> SELECT 1000 > >> postgres=#

Re: A strange GiST error message or fillfactor of GiST build

2018-08-29 Thread Andrey Borodin
Hi! > 29 авг. 2018 г., в 5:32, Kyotaro HORIGUCHI > написал(а): > > Hello. > > In the discussion about cube's dimention limit [1], I found that > the error messages looks strange. > > https://www.postgresql.org/message-id/f0e1a404-a495-4f38-b817-06355b537...@yandex-team.ru > >> postgres=# cre

A strange GiST error message or fillfactor of GiST build

2018-08-29 Thread Kyotaro HORIGUCHI
Hello. In the discussion about cube's dimention limit [1], I found that the error messages looks strange. https://www.postgresql.org/message-id/f0e1a404-a495-4f38-b817-06355b537...@yandex-team.ru > postgres=# create table y as select cube(array(SELECT random() as a FROM > generate_series(1,100