Re: Clean up find_typedefs and add support for Mac

2023-12-15 Thread Andrew Dunstan
On 2023-12-15 Fr 11:06, Tom Lane wrote: Andrew Dunstan writes: Here's more or less what I had in mind. Do we really need the dependency on an install tree? Can't we just find the executables (or .o files for Darwin) in the build tree? Seems like that would simplify usage, and reduce the

Re: Clean up find_typedefs and add support for Mac

2023-12-15 Thread Tristan Partin
On Fri Dec 15, 2023 at 10:06 AM CST, Tom Lane wrote: Andrew Dunstan writes: > Here's more or less what I had in mind. Do we really need the dependency on an install tree? Can't we just find the executables (or .o files for Darwin) in the build tree? Seems like that would simplify usage, and

Re: Clean up find_typedefs and add support for Mac

2023-12-15 Thread Tristan Partin
if ($using_osx) { # On OS X, we need to examine the .o files # exclude ecpg/test, which pgindent does too my $obj_wanted = sub { /^.*\.o\z/s && !($File::Find::name =~

Re: Clean up find_typedefs and add support for Mac

2023-12-15 Thread Tom Lane
Andrew Dunstan writes: > Here's more or less what I had in mind. Do we really need the dependency on an install tree? Can't we just find the executables (or .o files for Darwin) in the build tree? Seems like that would simplify usage, and reduce the possibility for version-skew errors.

Re: Clean up find_typedefs and add support for Mac

2023-12-15 Thread Andrew Dunstan
On 2023-12-14 Th 10:36, Tristan Partin wrote: On Thu Dec 14, 2023 at 9:16 AM CST, Andrew Dunstan wrote: On 2023-12-13 We 15:59, Tristan Partin wrote: > On Wed Dec 13, 2023 at 2:35 PM CST, Andrew Dunstan wrote: >> >> On 2023-12-12 Tu 18:02, Tom Lane wrote: >> > "Tristan Partin" writes: >> >>

Re: Clean up find_typedefs and add support for Mac

2023-12-14 Thread Tristan Partin
On Thu Dec 14, 2023 at 9:16 AM CST, Andrew Dunstan wrote: On 2023-12-13 We 15:59, Tristan Partin wrote: > On Wed Dec 13, 2023 at 2:35 PM CST, Andrew Dunstan wrote: >> >> On 2023-12-12 Tu 18:02, Tom Lane wrote: >> > "Tristan Partin" writes: >> >> The big patch here is adding support for Mac.

Re: Clean up find_typedefs and add support for Mac

2023-12-14 Thread Andrew Dunstan
On 2023-12-13 We 15:59, Tristan Partin wrote: On Wed Dec 13, 2023 at 2:35 PM CST, Andrew Dunstan wrote: On 2023-12-12 Tu 18:02, Tom Lane wrote: > "Tristan Partin" writes: >> The big patch here is adding support for Mac. objdump -W doesn't work on >> Mac. So, I used dsymutil and dwarfdump

Re: Clean up find_typedefs and add support for Mac

2023-12-13 Thread Tristan Partin
On Wed Dec 13, 2023 at 2:35 PM CST, Andrew Dunstan wrote: On 2023-12-12 Tu 18:02, Tom Lane wrote: > "Tristan Partin" writes: >> The big patch here is adding support for Mac. objdump -W doesn't work on >> Mac. So, I used dsymutil and dwarfdump to achieve the same result. > We should probably

Re: Clean up find_typedefs and add support for Mac

2023-12-13 Thread Andrew Dunstan
On 2023-12-12 Tu 18:02, Tom Lane wrote: "Tristan Partin" writes: The big patch here is adding support for Mac. objdump -W doesn't work on Mac. So, I used dsymutil and dwarfdump to achieve the same result. We should probably nuke the current version of src/tools/find_typedef altogether in

Re: Clean up find_typedefs and add support for Mac

2023-12-13 Thread Tristan Partin
On Wed Dec 13, 2023 at 11:27 AM CST, Tom Lane wrote: "Tristan Partin" writes: > That makes sense to me. Where can I find the buildfarm code to propose > a different patch, at least pulling in the current state of the > buildfarm script? Or perhaps Andrew is the best person for this job. I

Re: Clean up find_typedefs and add support for Mac

2023-12-13 Thread Tom Lane
"Tristan Partin" writes: > That makes sense to me. Where can I find the buildfarm code to propose > a different patch, at least pulling in the current state of the > buildfarm script? Or perhaps Andrew is the best person for this job. I think this is the authoritative repo:

Re: Clean up find_typedefs and add support for Mac

2023-12-13 Thread Tristan Partin
On Tue Dec 12, 2023 at 5:02 PM CST, Tom Lane wrote: "Tristan Partin" writes: > The big patch here is adding support for Mac. objdump -W doesn't work on > Mac. So, I used dsymutil and dwarfdump to achieve the same result. We should probably nuke the current version of src/tools/find_typedef

Re: Clean up find_typedefs and add support for Mac

2023-12-12 Thread Tom Lane
"Tristan Partin" writes: > The big patch here is adding support for Mac. objdump -W doesn't work on > Mac. So, I used dsymutil and dwarfdump to achieve the same result. We should probably nuke the current version of src/tools/find_typedef altogether in favor of copying the current buildfarm

Clean up find_typedefs and add support for Mac

2023-12-12 Thread Tristan Partin
The script was using a few deprecated things according to POSIX: - -o instead of || - egrep - `` instead of $() I removed those for their "modern" equivalents. Hopefully no buildfarm member complains. I can remove any of those patches though. I did go ahead and remove egrep usage from the