On Mon, Feb 6, 2023 at 2:45 PM Michael Paquier wrote:
>
> On Mon, Feb 06, 2023 at 12:27:51PM +0900, Masahiko Sawada wrote:
> > I thought that too, but I thought it's better to ignore it, instead of
> > erroring out. For example, we can specify both --disable and
> > --progress options to pg_checks
On Mon, Feb 06, 2023 at 12:27:51PM +0900, Masahiko Sawada wrote:
> I thought that too, but I thought it's better to ignore it, instead of
> erroring out. For example, we can specify both --disable and
> --progress options to pg_checksum commands, but we don't write any
> progress information in thi
On Mon, Feb 6, 2023 at 9:35 AM Michael Paquier wrote:
>
> On Sat, Feb 04, 2023 at 12:32:15PM +0900, Michael Paquier wrote:
> > That seems rather OK seen from here. I'll see about getting that
> > applied except if there is an objection of any kind.
>
> Okay, I have looked at that again this morni
On Sat, Feb 04, 2023 at 12:32:15PM +0900, Michael Paquier wrote:
> That seems rather OK seen from here. I'll see about getting that
> applied except if there is an objection of any kind.
Okay, I have looked at that again this morning and I've spotted one
tiny issue: specifying --progress with --s
On Thu, Feb 02, 2023 at 05:56:47PM +0900, Masahiko Sawada wrote:
> Seems a good idea. Please find an attached patch.
That seems rather OK seen from here. I'll see about getting that
applied except if there is an objection of any kind.
--
Michael
signature.asc
Description: PGP signature
On Thu, Feb 2, 2023 at 3:12 PM Michael Paquier wrote:
>
> On Thu, Feb 02, 2023 at 02:57:44PM +0900, Masahiko Sawada wrote:
> > It seems that the --progress option doesn't work with command_like()
> > since the progress information is written in stderr but command_like()
> > doesn't want it.
>
> Wh
On Thu, Feb 02, 2023 at 02:57:44PM +0900, Masahiko Sawada wrote:
> It seems that the --progress option doesn't work with command_like()
> since the progress information is written in stderr but command_like()
> doesn't want it.
What about command_checks_all()? It should check for stderr, stdout
a
On Wed, Feb 1, 2023 at 10:25 AM Michael Paquier wrote:
>
> On Fri, Jan 06, 2023 at 04:28:42PM +0900, Masahiko Sawada wrote:
> > I've attached the simple patch to add the progress reporting option to
> > pg_verifybackup. The progress information is displayed with --progress
> > option only during t
On Fri, Jan 06, 2023 at 04:28:42PM +0900, Masahiko Sawada wrote:
> I've attached the simple patch to add the progress reporting option to
> pg_verifybackup. The progress information is displayed with --progress
> option only during the checksum verification, which is the most time
> consuming task.
