st 18. 9. 2019 v 4:57 odesílatel Pavel Stehule
napsal:
>
>
> st 18. 9. 2019 v 4:53 odesílatel Ryan Lambert
> napsal:
>
>> Hi Pavel,
>> I took a quick look through the patch, I'll try to build and test it
>> tomorrow.
>>
>>
>> --- a/src/include/nodes/parsenodes.h
>> +++
st 18. 9. 2019 v 4:53 odesílatel Ryan Lambert
napsal:
> Hi Pavel,
> I took a quick look through the patch, I'll try to build and test it
> tomorrow.
>
>
> --- a/src/include/nodes/parsenodes.h
> +++ b/src/include/nodes/parsenodes.h
> @@ -3145,6 +3145,7 @@ typedef struct DropdbStmt
> NodeTag type;
Hi Pavel,
I took a quick look through the patch, I'll try to build and test it
tomorrow.
--- a/src/include/nodes/parsenodes.h
+++ b/src/include/nodes/parsenodes.h
@@ -3145,6 +3145,7 @@ typedef struct DropdbStmt
NodeTag type;
char *dbname; /* database to drop */
bool missing_ok; /* skip error
Hi
I started work on this patch. I changed syntax to
DROP DATABASE [ ( FORCE , ..) ] [IF EXISTS ...]
and now I try to fix all other points from Tom's list
út 17. 9. 2019 v 12:15 odesílatel Tom Lane napsal:
> Pavel Stehule writes:
> > [ drop-database-force-20190708.patch ]
>
> I took a brief
út 3. 9. 2019 v 18:46 odesílatel Alvaro Herrera
napsal:
> On 2019-Jul-25, Pavel Stehule wrote:
>
> > čt 25. 7. 2019 v 5:11 odesílatel Tom Lane napsal:
> >
> > > Pavel Stehule writes:
>
> > > * I'm concerned that the proposed syntax is not future-proof.
> >
> > Can be
> >
> > DROP DATABASE '('
On 2019-Jul-25, Pavel Stehule wrote:
> čt 25. 7. 2019 v 5:11 odesílatel Tom Lane napsal:
>
> > Pavel Stehule writes:
> > * I'm concerned that the proposed syntax is not future-proof.
>
> Can be
>
> DROP DATABASE '(' options ...) [IF EXISTS] name
>
> ok?
Seems weird to me. I'd rather have
I set the status to Waiting on Author since Tom's concerns [1] have not been
addressed.
[1] https://www.postgresql.org/message-id/15707.1564024305%40sss.pgh.pa.us
Thanks,
Ryan
On Thu, Jul 25, 2019 at 8:45 PM Pavel Stehule wrote:
> čt 25. 7. 2019 v 5:11 odesílatel Tom Lane napsal:
>> Pavel Stehule writes:
>> > [ drop-database-force-20190708.patch ]
>>
>> I took a brief look at this, but I don't think it's really close to
>> being committable.
Hi Pavel,
The concept
čt 25. 7. 2019 v 5:11 odesílatel Tom Lane napsal:
> Pavel Stehule writes:
> > [ drop-database-force-20190708.patch ]
>
> I took a brief look at this, but I don't think it's really close to
> being committable.
>
> * The documentation claims FORCE will fail if you don't have privileges
> to
Pavel Stehule writes:
> [ drop-database-force-20190708.patch ]
I took a brief look at this, but I don't think it's really close to
being committable.
* The documentation claims FORCE will fail if you don't have privileges
to terminate the other session(s) in the target DB. This is a lie; the
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: not tested
Documentation:not tested
Hi,
The latest patch [1] applies cleanly and basic functionality
po 8. 7. 2019 v 0:07 odesílatel Thomas Munro
napsal:
> On Thu, Jun 27, 2019 at 7:15 AM Pavel Stehule
> wrote:
> > fixed
>
> Hi Pavel,
>
> FYI t/050_dropdb.pl fails consistently with this patch applied:
>
> https://travis-ci.org/postgresql-cfbot/postgresql/builds/555234838
with attached patch
On Thu, Jun 27, 2019 at 7:15 AM Pavel Stehule wrote:
> fixed
Hi Pavel,
FYI t/050_dropdb.pl fails consistently with this patch applied:
https://travis-ci.org/postgresql-cfbot/postgresql/builds/555234838
--
Thomas Munro
https://enterprisedb.com
Hi
po 24. 6. 2019 v 10:28 odesílatel Anthony Nowocien
napsal:
> Hi,
> patch no longer applies (as of 12beta2).
>
> postgres@ubuntudev:~/pg_testing/source/postgresql-12beta2$ patch -p1 <
> drop-database-force-20190310_01.patch
> patching file doc/src/sgml/ref/drop_database.sgml
> patching file
Hi,
patch no longer applies (as of 12beta2).
postgres@ubuntudev:~/pg_testing/source/postgresql-12beta2$ patch -p1 <
drop-database-force-20190310_01.patch
patching file doc/src/sgml/ref/drop_database.sgml
patching file doc/src/sgml/ref/dropdb.sgml
patching file src/backend/commands/dbcommands.c
Also works fine according to my testing. Documentation is also clear.
Thanks for this useful patch.
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: tested, passed
Documentation:not tested
The feature works fine on my machine. The code is well-written.
Yes, I think it is because of this code Snippet
if (force_terminate)
{
/* try to terminate backend */
#ifdef HAVE_SETSID
kill(-(proc->pid), SIGTERM);
#else
kill(proc->pid,
Is this the intended behavior? SIGTERM is received.
test=# begin;
BEGIN
test=# create table test(a int);
CREATE TABLE
In another terminal drop the database.
test=# begin;
psql: FATAL: terminating connection due to administrator command
server closed the connection unexpectedly
This
On 31.03.2019, 04:35 Andres Freund wrote:
>
> > bool
> > -CountOtherDBBackends(Oid databaseId, int *nbackends, int *nprepared)
> > +CountOtherDBBackends(Oid databaseId, int *nbackends, int *nprepared, bool
> > force_terminate)
> > {
>
> That doesn't seem like a decent API to me.
Only excuse
Hi,
On 2019-03-10 11:20:42 +0100, Filip Rembiałkowski wrote:
> bool
> -CountOtherDBBackends(Oid databaseId, int *nbackends, int *nprepared)
> +CountOtherDBBackends(Oid databaseId, int *nbackends, int *nprepared, bool
> force_terminate)
> {
That doesn't seem like a decent API to me.
Hello,
This is a feature I have wanted for a long time, thank you for your work on
this.
The latest patch [1] applied cleanly for me. In dbcommands.c the comment
references a 5 second delay, I don't see where that happens, am I missing
something?
I tested both the dropdb program and the in
Thank you. Updated patch attached.
On Sat, Mar 9, 2019 at 2:53 AM Thomas Munro wrote:
>
> On Wed, Mar 6, 2019 at 1:39 PM Filip Rembiałkowski
> wrote:
> > Here is Pavel's patch rebased to master branch, added the dropdb
> > --force option, a test case & documentation.
>
> Hello,
>
>
On Wed, Mar 6, 2019 at 1:39 PM Filip Rembiałkowski
wrote:
> Here is Pavel's patch rebased to master branch, added the dropdb
> --force option, a test case & documentation.
Hello,
cfbot.cputube.org says this fails on Windows, due to a missing semicolon here:
#ifdef HAVE_SETSID
Here is Pavel's patch rebased to master branch, added the dropdb
--force option, a test case & documentation.
I'm willing to work on it if needed. What are possible bad things that
could happen here? Is the documentation clear enough?
Thanks.
On Tue, Dec 18, 2018 at 4:34 PM Marti Raudsepp
I wonder if this idea from seven years ago might be useful:
https://postgr.es/m/1305688547-sup-7...@alvh.no-ip.org
--
Álvaro Herrerahttps://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Marti Raudsepp writes:
> I think Filip's approach of setting pg_database.datallowconn='false'
> is pretty clever to avoid the synchronization problem.
Some bull-in-a-china-shop has recently added logic that allows ignoring
datallowconn and connecting anyway, so I'm not sure that that'd provide
a
On Tue, Dec 18, 2018 at 01:25:32PM +0100, Filip Rembiałkowski wrote:
> Hi,
>
> I propose a simple patch (works-for-me), which adds --force (-f)
> option to dropdb utility.
Nice!
I did something like this in user space back in 2010.
Hi
> út 18. 12. 2018 v 16:11 odesílatel Filip Rembiałkowski
> napsal:
>> Please share opinions if this makes sense at all, and has any chance
>> going upstream.
Clearly since Pavel has another implementation of the same concept,
there is some interest in this feature. :)
On Tue, Dec 18, 2018
Hi
út 18. 12. 2018 v 16:11 odesílatel Filip Rembiałkowski <
filip.rembialkow...@gmail.com> napsal:
> Hi,
>
> I propose a simple patch (works-for-me), which adds --force (-f)
> option to dropdb utility.
>
> Pros: This seems to be a desired option for many sysadmins, as this
> thread proves:
>
101 - 130 of 130 matches
Mail list logo
