Hello,
While reviewing the ICU versioning work a while back, I mentioned the
idea of using a user-supplied command to get a collversion string for
the libc collation provider. I was reminded about that by recent news
about an upcoming glibc/CLDR resync that is likely to affect
PostgreSQL users
> "Andres" == Andres Freund writes:
>> However, this commit broke float8 test on 32-bit FreeBSD 11 with
>> clang 3.8.0 compiler. Regressions.diff follows:
Andres> Does this happen with a newer clang version too?
float8 test (and all other tests) passes for me on clang 3.9.1 on fbsd11
on
Proposed patch. Checking isnull in a elog(ERROR) is important, because
the column is not marked NOT NULL. This is not true for other columns
where we simply do Assert(!isnull).
--
Álvaro Herrerahttps://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA,
On Tue, Sep 4, 2018 at 10:02 AM Thomas Munro
wrote:
> const char *querylocaleversion(int mask, locale_t locale);
>
> Then the patch for pg_locale.c is trivial, see attached.
Oops, here's that one, FWIW.
--
Thomas Munro
http://www.enterprisedb.com
On Tue, Sep 04, 2018 at 03:49:09PM +, Bossart, Nathan wrote:
> Yes. I've started working on this again, but the new patch set is
> probably still a few days out.
Thanks, Nathan.
--
Michael
signature.asc
Description: PGP signature
Hi,
On 2018-09-04 11:45:10 +0200, Georgy Buranov wrote:
> Hi Andres. Thank you very much for your help.
>
> I tried the following solution and I have some problems.
>
> * I have 9.6 postgres and I do not have separate field for rd_pkindex
> * All I have is rd_replidindex field. Usually (when
Hi,
I heard from my colleagues that we have an extension that does a similar
thing. I'm attaching the source. It creates operator "==" for some data
types, that works like "IS NOT DISTINCT FROM". You can then perform hash
joins on this operator. Apparently the hash join machinery supports
On Tue, Sep 4, 2018 at 9:39 AM Andrew Gierth
wrote:
>
> > "Andres" == Andres Freund writes:
>
> >> However, this commit broke float8 test on 32-bit FreeBSD 11 with
> >> clang 3.8.0 compiler. Regressions.diff follows:
>
> Andres> Does this happen with a newer clang version too?
>
> float8
On Sun, Sep 02, 2018 at 01:07:47PM -0700, Michael Paquier wrote:
> Wouldn't something like the attached provide more adapted error
> handling? That's mostly error handling beautification, so I would be
> incline to just fix HEAD.
>
> (I have noticed some inconsistent error string format in
Hi,
So here is the last set of benchmark results, this time from ext4 on a
small SATA-based RAID (3 x 7.2k). As before, I'm only attaching PDFs
with the simple charts, full results are available in the git repository
[1]. Overall the numbers are rather boring, with almost no difference
between
On 30 August 2018 at 00:06, Amit Langote wrote:
> With various overheads gone thanks to 0001 and 0002, locking of all
> partitions via find_all_inheritos can be seen as the single largest
> bottleneck, which 0003 tries to address. I've kept it a separate patch,
> because I'll need to think a bit
Sandeep Thakkar writes:
> I'm seeing this warning (git.postgresql.org[0: 2620:122:b000:7::243]:
> errno=Network is unreachable) on one of the buildfarm animals (anole) from
> last few weeks. The git version is 1.7.4.2. When I use https, it errors
> "fatal: cannot exec 'git-remote-https':
On 3 September 2018 at 00:17, Tomas Vondra wrote:
> Hi,
>
> Attached is an updated version of the patch series, adopting a couple of
> improvements - both for MCV lists and histograms.
>
>
> MCV
> ---
>
> For the MCV list part, I've adopted the approach proposed by Dean, using
> base selectivity
> "Tom" == Tom Lane writes:
>> I kinda wonder if we should add -mno-x87 or such in configure when
>> we detect clang, obviously it doesn't deal correctly with this.
Tom> Seems worth looking into, but what happens if someone tries to
Tom> compile for x87 hardware? Or do we care anymore?
On Tue, Sep 04, 2018 at 03:09:21PM -0700, Jimmy Yih wrote:
> When an empty namespace is being initially populated with certain objects,
> it is possible for a DROP SCHEMA operation to come in and delete the
> namespace without using CASCADE. These objects would be created but are
> left unusable.
On 2018/09/05 1:50, Alvaro Herrera wrote:
> Proposed patch. Checking isnull in a elog(ERROR) is important, because
> the column is not marked NOT NULL. This is not true for other columns
> where we simply do Assert(!isnull).
Looks good. Thanks for taking care of other sites as well.
@@
On 2018-09-05 01:47:52 +0100, Andrew Gierth wrote:
> > "Tom" == Tom Lane writes:
>
> >> I kinda wonder if we should add -mno-x87 or such in configure when
> >> we detect clang, obviously it doesn't deal correctly with this.
>
> Tom> Seems worth looking into, but what happens if someone
On Tue, Sep 4, 2018 at 1:42 PM Dilip Kumar wrote:
>
> I have tested pg_upgrade with different block size (1K, 4K, 8K, 32K).
> The upgrade is working fine from v10 to v11 and I am able to fetch
> data with index scan on the hash index after an upgrade.
>
Thanks, do you see any way to write a
On 2018/09/04 21:51, Alvaro Herrera wrote:
> On 2018-Sep-04, Amit Langote wrote:
>
>> On 2018/09/04 13:08, Alvaro Herrera wrote:
>
>>> I think it'd be pointless noise. If we really want to protect against
>>> that, I think we should promote the Assert for relpartbound's isnull
>>> flag into an
On Tue, Sep 04, 2018 at 06:02:51PM -0400, Stephen Frost wrote:
> * Tom Lane (t...@sss.pgh.pa.us) wrote:
>> Michael Paquier writes:
>>> While hacking another patch, I have noticed that triggerring multiple
>>> times in a row installcheck on test_pg_dump results in a failure because
>>> it is
On 2018-09-04 19:02:02 -0400, Tom Lane wrote:
> Andres Freund writes:
> > ... Note that we've previously encountered similar issues
> > on gcc, which is why we've tried to force gcc's hand with
> > -fexcess-precision=standard.
>
> Right. Annoying that clang doesn't have that. We can't
В Tue, 04 Sep 2018 15:48:24 -0400
Tom Lane пишет:
> I tried to reproduce the problem, without success, on a few different
> FreeBSD images I had laying about:
>
> FreeBSD 11.0/x86_64, clang version 3.8.0
> (this confirms OP's report that x86_64 is OK)
>
> FreeBSD 10.3/ppc, gcc 4.2.1
>
> "Andres" == Andres Freund writes:
Andres> Thomas and I are sitting in a cafe and are trying to figure out
Andres> what's going on...
I have a standalone test case:
#include
#include
int main(int argc, char **argv)
{
double d1 = (argc ? 1e180 : 0);
double d2 = (argv ? 1e200 :
On Tue, Sep 4, 2018 at 12:59 PM, R, Siva wrote:
> We recently encountered an issue where the opaque data flags on a gin data
> leaf page was corrupted while replaying a gin insert WAL record. Upon
> further examination of the redo code, we found a bug in ginRedoRecompress
> code, which extracts
Greetings,
* Tom Lane (t...@sss.pgh.pa.us) wrote:
> Michael Paquier writes:
> > While hacking another patch, I have noticed that triggerring multiple
> > times in a row installcheck on test_pg_dump results in a failure because
> > it is missing clean up actions on the role
Hello,
When an empty namespace is being initially populated with certain objects,
it is possible for a DROP SCHEMA operation to come in and delete the
namespace without using CASCADE. These objects would be created but are
left unusable. This is capable of leaving behind pg_class, pg_type, and
> "Tom" == Tom Lane writes:
>> The reason it behaves oddly is this: on i387 FPU (and NOT on arm32
>> or on 32-bit i386 with a modern architecture specified to the
>> compiler), the result of 1e200 * 1e180 is not in fact infinite,
>> because it fits in an 80-bit long double. So
On 2018-09-04 17:46:29 -0400, Tom Lane wrote:
> Andrew Gierth writes:
> > The reason it behaves oddly is this: on i387 FPU (and NOT on arm32 or on
> > 32-bit i386 with a modern architecture specified to the compiler), the
> > result of 1e200 * 1e180 is not in fact infinite, because it fits in an
В Tue, 4 Sep 2018 11:06:56 -0700
Thomas Munro пишет:
> On Tue, Sep 4, 2018 at 9:39 AM Andrew Gierth
> wrote:
> >
> > > "Andres" == Andres Freund writes:
> >
> > >> However, this commit broke float8 test on 32-bit FreeBSD 11 with
> > >> clang 3.8.0 compiler. Regressions.diff
Victor Wagner writes:
> Tom Lane пишет:
>> (I was testing PG HEAD, not the 11 branch, but I don't see a reason
>> to think that'd make a difference.)
> Alas, it does. First thing I've done after discovering this bug, it is
> to look if it exists in master. And master passes this test on the
On 2018-09-04 16:13:45 -0400, Tom Lane wrote:
> Victor Wagner writes:
> > Tom Lane пишет:
> >> (I was testing PG HEAD, not the 11 branch, but I don't see a reason
> >> to think that'd make a difference.)
>
> > Alas, it does. First thing I've done after discovering this bug, it is
> > to look if
Hi, Siva!
On Tue, Sep 4, 2018 at 11:01 PM R, Siva wrote:
> We recently encountered an issue where the opaque data flags on a gin data
> leaf page was corrupted while replaying a gin insert WAL record. Upon further
> examination of the redo code, we found a bug in ginRedoRecompress code, which
Andrew Gierth writes:
> The reason it behaves oddly is this: on i387 FPU (and NOT on arm32 or on
> 32-bit i386 with a modern architecture specified to the compiler), the
> result of 1e200 * 1e180 is not in fact infinite, because it fits in an
> 80-bit long double. So __builtin_isinf reports that
On Mon, Sep 3, 2018 at 2:30 PM, Alexander Korotkov <
a.korot...@postgrespro.ru> wrote:
> The current version of patch doesn't really distinguish spaces and
> delimiters in format string in non-FX mode. So, spaces and delimiters
> are forming single group. For me Oracle behavior is ridiculous at
On 2018-09-04 15:16:27 -0700, Andres Freund wrote:
> I'm now looking at how it comes that clang on linux doesn't default to
> x87 math, but freebsd does.
Oh well. I present you, without comments, the following:
switch (Triple.getOS()) {
case llvm::Triple::FreeBSD:
case
Thomas Munro writes:
> On Tue, Sep 4, 2018 at 9:39 AM Andrew Gierth
> wrote:
>> I also confirmed that without #define isinf(x) __builtin_isinf(x), on
>> both 32bit and 64bit fbsd isinf() compiles as a function call, so the
>> OP's proposed change would not be desirable.
Presumably what we are
> "Victor" == Victor Wagner writes:
Victor> Do you reproducing problem in REL_11_STABLE? It doesn't exist
Victor> in master.
Oh, I missed that. It is reproducible on REL_11_STABLE with clang 3.9.1,
I'll dig into it more.
--
Andrew (irc:RhodiumToad)
> "Andrew" == Andrew Gierth writes:
> "Andres" == Andres Freund writes:
Andres> Thomas and I are sitting in a cafe and are trying to figure out
Andres> what's going on...
Andrew> I have a standalone test case:
Andrew> #include
Andrew> #include
Andrew> int main(int argc, char
Hi,
On 2018-09-04 15:16:27 -0700, Andres Freund wrote:
> I think this is pretty clearly a C99 violation by clang (note how gcc
> automatically enables -fexcess-precision=standard in C99 mode). I'll
> report something, but I've little hope this getting fixed quickly - and
> it'll definitely not
Andres Freund writes:
> ... Note that we've previously encountered similar issues
> on gcc, which is why we've tried to force gcc's hand with
> -fexcess-precision=standard.
Right. Annoying that clang doesn't have that. We can't realistically
program around an issue that might or might not show
Hi Stephen,
While hacking another patch, I have noticed that triggerring multiple
times in a row installcheck on test_pg_dump results in a failure because
it is missing clean up actions on the role regress_dump_test_role.
Roles are shared objects, so I think that we ought to not let traces of
it
On Tue, Sep 4, 2018 at 12:59 PM Victor Wagner wrote:
>
> В Tue, 04 Sep 2018 15:48:24 -0400
> Tom Lane пишет:
>
>
> > I tried to reproduce the problem, without success, on a few different
> > FreeBSD images I had laying about:
> >
> > FreeBSD 11.0/x86_64, clang version 3.8.0
> > (this
Michael Paquier writes:
> While hacking another patch, I have noticed that triggerring multiple
> times in a row installcheck on test_pg_dump results in a failure because
> it is missing clean up actions on the role regress_dump_test_role.
> Roles are shared objects, so I think that we ought to
> "Andrew" == Andrew Gierth writes:
Andrew> Specifying a recent microarch makes it use 64-bit FP registers
Andrew> rather than 80-bit ones:
Andrew> cc -O2 -m32 -march=skylake flttst.c && ./a.out
Andrew> r1 = 1, r2 = 1
where "recent" means "since about 2000 or so":
cc -O2 -m32
On September 4, 2018 9:11:25 PM PDT, Tom Lane wrote:
>Michael Paquier writes:
>> On Tue, Sep 04, 2018 at 03:09:21PM -0700, Jimmy Yih wrote:
>>> When an empty namespace is being initially populated with certain
>objects,
>>> it is possible for a DROP SCHEMA operation to come in and delete the
On 2018/09/04 22:24, David Rowley wrote:
> On 30 August 2018 at 00:06, Amit Langote
> wrote:
>> With various overheads gone thanks to 0001 and 0002, locking of all
>> partitions via find_all_inheritos can be seen as the single largest
>> bottleneck, which 0003 tries to address. I've kept it a
Andres Freund writes:
> On September 4, 2018 9:11:25 PM PDT, Tom Lane wrote:
>> I think that line of thought leads to an enormous increase in locking
>> overhead, for which we'd get little if any gain in usability. So my
>> inclination is to make an engineering judgment that we won't fix this.
On Tue, Sep 4, 2018 at 10:33 AM Andres Freund wrote:
> Hi,
>
> Thanks for the patches!
>
> On 2018-09-03 19:06:27 +1000, Haribabu Kommi wrote:
> > I found couple of places where the zheap is using some extra logic in
> > verifying
> > whether it is zheap AM or not, based on that it used to took
On Wed, Sep 5, 2018 at 9:46 AM Tom Lane wrote:
>
> Amit Kapila writes:
> > Does anybody else have any idea on how can we write a test for
> > non-default block size or if we already have anything similar?
>
> Build with a non-default BLCKSZ and see if the regression tests pass.
> There's no way
Hi
2018-09-04 9:21 GMT+02:00 Dean Rasheed :
> AFAICS this patch does nothing to consider parallel safety -- that is,
> as things stand, a variable is allowed in a query that may be
> parallelised, but its value is not copied to workers, leading to
> incorrect results. For example:
>
> create
Collegues,
Few days ago commit
1f349aa7d9a6633e87db071390c73a39ac279ba4
Fix 8a934d67 for libc++ and make more include order resistant.
was introduced into branch REL_11_STABLE.
It seems that it deals with GLIBC-based systems (i.e Linux and Hurd)
only, and shouldn't affect systems with
On 2018-Sep-04, Amit Langote wrote:
> On 2018/09/04 13:08, Alvaro Herrera wrote:
> > I think it'd be pointless noise. If we really want to protect against
> > that, I think we should promote the Assert for relpartbound's isnull
> > flag into an if test.
>
> So that we can elog(ERROR, ...) if
On 28 August 2018 at 22:43, Ashutosh Bapat
wrote:
> On Fri, Aug 24, 2018 at 6:46 AM, Andres Freund wrote:
>
>>
>>> @@ -2883,7 +2885,7 @@ CopyFrom(CopyState cstate)
>>> if (slot == NULL) /* "do nothing" */
>>> skip_tuple = true;
>>>
On September 4, 2018 6:16:24 AM PDT, Victor Wagner wrote:
>
>Collegues,
>
>Few days ago commit
>
> 1f349aa7d9a6633e87db071390c73a39ac279ba4
>
>Fix 8a934d67 for libc++ and make more include order resistant.
>
>was introduced into branch REL_11_STABLE.
>It seems that it deals with GLIBC-based
On 9/3/18, 6:20 PM, "Michael Paquier" wrote:
> Nathan, could you rebase your patch set? From what I can see the last
> patch set applies with one conflict, and it would be nice for clarity to
> split the routines for analyze, vacuum and cluster into separate places.
> Similar to what is done
Michael Paquier writes:
> On Tue, Sep 04, 2018 at 03:09:21PM -0700, Jimmy Yih wrote:
>> When an empty namespace is being initially populated with certain objects,
>> it is possible for a DROP SCHEMA operation to come in and delete the
>> namespace without using CASCADE.
> It seems to me that we
On Tue, Sep 4, 2018 at 7:52 PM, Kyotaro HORIGUCHI
wrote:
> At Mon, 3 Sep 2018 18:14:22 +0900, Masahiko Sawada
> wrote in
>> Thank you for updating the patch!
>>
>> On Tue, Jul 31, 2018 at 6:11 PM, Kyotaro HORIGUCHI
>> wrote:
>> > Hello.
>> >
>> > At Tue, 24 Jul 2018 16:47:41 +0900, Masahiko
At Mon, 3 Sep 2018 18:14:22 +0900, Masahiko Sawada
wrote in
> Thank you for updating the patch!
>
> On Tue, Jul 31, 2018 at 6:11 PM, Kyotaro HORIGUCHI
> wrote:
> > Hello.
> >
> > At Tue, 24 Jul 2018 16:47:41 +0900, Masahiko Sawada
> > wrote in
> >
> >> On Mon, Jul 23, 2018 at 4:16 PM,
AFAICS this patch does nothing to consider parallel safety -- that is,
as things stand, a variable is allowed in a query that may be
parallelised, but its value is not copied to workers, leading to
incorrect results. For example:
create table foo(a int);
insert into foo select * from
On Tue, Sep 4, 2018 at 10:49 AM, Dilip Kumar wrote:
> On Tue, Sep 4, 2018 at 10:14 AM, Amit Kapila wrote:
>> On Mon, Sep 3, 2018 at 2:44 PM Dilip Kumar wrote:
>>> On Mon, Sep 3, 2018 at 8:37 AM, Amit Kapila wrote:
>>> > On Sat, Sep 1, 2018 at 10:28 AM Dilip Kumar wrote:
>>> >>
>>> >> I think
Hi Dilip,
Thanks for taking a look.
On 2018/09/03 20:57, Dilip Kumar wrote:
> The idea looks interesting while going through the patch I observed
> this comment.
>
> /*
> * inheritance_planner
> * Generate Paths in the case where the result relation is an
> * inheritance set.
> *
> *
On 2018/08/24 7:22, David Rowley wrote:
> On 24 August 2018 at 02:26, Amit Langote wrote:
>> One of the patches I sent last week does the same thing, among a
>> couple of other things with regard to handling relations in the
>> executor. On a cursory look at the patch, your take of it looks
>>
On Mon, Sep 3, 2018 at 10:06 PM, Yugo Nagata wrote:
> Hi,
>
> On Sat, 1 Sep 2018 07:40:40 +0200 (CEST)
> Fabien COELHO wrote:
>
>> > Attached is a patch to allow pg_verity_checksums to specify a database
>> > to scan. This is usefule for users who want to verify checksums of
>> > relations
>>
On 2018/09/04 17:14, David Rowley wrote:
> On 4 September 2018 at 19:31, Amit Langote
> wrote:
>> On 2018/08/24 7:22, David Rowley wrote:
>>> On 24 August 2018 at 02:26, Amit Langote wrote:
One of the patches I sent last week does the same thing, among a
couple of other things with
On 2018/09/04 13:08, Alvaro Herrera wrote:
> On 2018-Sep-04, Amit Langote wrote:
>
>> On 2018/09/04 10:19, Michael Paquier wrote:
>>> On Tue, Sep 04, 2018 at 09:47:07AM +0900, Amit Langote wrote:
On 2018/09/04 6:39, Alvaro Herrera wrote:
> After looking, it seems that this is just
On Tue, 4 Sep 2018 at 00:01, Pavan Deolasee wrote:
>
> I've rebased the patch against the current master. The patch hasn't changed
> much since the last time.
>
Hi Pavan,
I had this crash when running sqlsmith against the previous version of
this patch and just confirmed it still crash with
On 4 September 2018 at 19:31, Amit Langote
wrote:
> On 2018/08/24 7:22, David Rowley wrote:
>> On 24 August 2018 at 02:26, Amit Langote wrote:
>>> One of the patches I sent last week does the same thing, among a
>>> couple of other things with regard to handling relations in the
>>> executor.
Hello,
We are using PostgreSQL to execute some SQL scripts "auto translated" from HIVE
QL, where the join operator "<=>" is heavily used. The semantic same operator
in PostgreSQL is "IS NOT DISTINCT FROM".
However, we found when "IS NOT DISTINCT FROM" is used in joins, only nested
loop plan
At Mon, 3 Sep 2018 23:05:23 +0300, Alexander Korotkov
wrote in
> On Mon, Sep 3, 2018 at 9:09 PM Andrey Borodin wrote:
> > > 3 сент. 2018 г., в 20:16, Alexander Korotkov
> > > написал(а):
> > > That's a good idea. Especially if we take into account that
> > > fillfactor is not a forever bad
Hi,
I'm seeing this warning (git.postgresql.org[0: 2620:122:b000:7::243]:
errno=Network is unreachable) on one of the buildfarm animals (anole) from
last few weeks. The git version is 1.7.4.2. When I use https, it errors
"fatal: cannot exec 'git-remote-https': Permission denied"
On Mon, Oct 30,
Hi Andres. Thank you very much for your help.
I tried the following solution and I have some problems.
* I have 9.6 postgres and I do not have separate field for rd_pkindex
* All I have is rd_replidindex field. Usually (when REPLICA IDENTITY
is NOT FULL), it still contains the primary key
* But
On Tue, Sep 4, 2018 at 12:16 PM Kyotaro HORIGUCHI
wrote:
> I agree that fillfactor should be ignored in certain cases
> (inserting the first tuple into empty pages or something like
> that). Even though GiST doesn't need fillfactor at all, it is
> defined independently from AM instances
What
On 2018/08/16 17:22, Amit Langote wrote:
> 0004-Revise-executor-range-table-relation-opening-closing.patch
>
> This adds two arrays to EState indexed by RT indexes, one for
> RangeTblEntry's and another for Relation pointers. The former reduces the
> cost of fetching RangeTblEntry by RT index.
73 matches
Mail list logo
